)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"8c4717d94364edac09954c8c80469fe860df5e7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f647be14_2c898835","updated":"2025-08-11 14:40:12.000000000","message":"recheck: unrelated failure","commit_id":"424a3b54052552d0aeb5a6320d2e2d802f5c5ef3"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"bc394805eb7df4be0549b901186f4bd0814303a7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f9dcf612_e3248ea0","updated":"2026-01-14 16:57:33.000000000","message":"I am wondering about the scenario where kolla_same_external_internal_vip is set to true. In this case, Let\u0027s Encrypt will attempt to manage both internal and external certificates for the same FQDN. We should ensure that DNS records for both endpoints point to the same VIP to avoid validation failures during the HTTP-01 or DNS-01 challenges. Do we have any safeguard or documentation note for this?","commit_id":"1aa6664711f3e16d8906b61cfbff803de6c21d45"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"bd7519f488fd5d085d0a102e991d64cfd9ff4579","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"964694c5_f311a6ca","in_reply_to":"909a55f0_a847a12e","updated":"2026-01-15 11:53:14.000000000","message":"You\u0027re right. Thanks for pointing that out. I misinterpreted conditional assignment of the original variable ``letsencrypt_managed_certs``.\nIf ``kolla_same_external_internal_vip`` is true, either one of ``letsencrypt_manage_external_cert`` or ``letsencrypt_manage_internal_cert`` should be set to false to avoid renewing two separate certs for the same FQDN.\nI\u0027ll make a change.","commit_id":"1aa6664711f3e16d8906b61cfbff803de6c21d45"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"9d514c43ef1dddd88a921dc78a61f612ad633432","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f828c4ab_61abc881","in_reply_to":"964694c5_f311a6ca","updated":"2026-01-21 15:43:02.000000000","message":"I made another variable which can be used to prevent the scenario you brought.\nThis variable ``letsencrypt_unified_renew`` is only set to true when all 4 variables\n- ``enable_letsencrypt``\n- ``letsencrypt_manage_external_cert``\n- ``letsencrypt_manage_internal_cert``\n- ``kolla_same_external_internal_vip``\n\nare true","commit_id":"1aa6664711f3e16d8906b61cfbff803de6c21d45"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"43be2953e6d1defbfad200d46b4e7a58055a8aec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f5fbfc02_eb88f3c1","in_reply_to":"f828c4ab_61abc881","updated":"2026-03-04 14:15:41.000000000","message":"Done","commit_id":"1aa6664711f3e16d8906b61cfbff803de6c21d45"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"8a5820a435dce7b48fac2c1f820c0e733e0594da","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"909a55f0_a847a12e","in_reply_to":"f9dcf612_e3248ea0","updated":"2026-01-14 19:34:23.000000000","message":"My apologies, I missed the updated documentation tables in the initial read. I see that the shared VIP scenario is now explicitly covered.\n\nHowever, I still have a minor concern regarding the default behavior: \nWhen `kolla_same_external_internal_vip` is `true`, the logic sets both `letsencrypt_manage_external_cert` and `letsencrypt_manage_internal_cert` to `true`. \n\nIf `kolla_external_fqdn` and `kolla_internal_fqdn` are identical (which is a common setup), Let\u0027s Encrypt might attempt to issue and renew two separate certificates for the exact same FQDN simultaneously. This could lead to:\n1. Unnecessary rate-limiting on the Let\u0027s Encrypt side.\n2. Potential validation conflicts during the HTTP-01 challenge if multiple lego processes try to handle the same token path.\n\nWouldn\u0027t it be safer to default `letsencrypt_manage_internal_cert` to `false` when `kolla_same_external_internal_vip` is `true`, since the external certificate would already cover the shared endpoint?","commit_id":"1aa6664711f3e16d8906b61cfbff803de6c21d45"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"18e5e4aa2e9d49fef609b6b7b0bced6480e1026e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"49a227df_68b39d11","updated":"2026-06-01 19:23:00.000000000","message":"Needs a reno, this causes the internal cert to suddenly be managed via LE which might break stuff.","commit_id":"501b5d297a21f12f77fb3b06bed2e6e18d8a8910"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5b8e0c2f57a90bfd6fe9ebb896d445611fb1b682","unresolved":true,"context_lines":[{"line_number":504,"context_line":""},{"line_number":505,"context_line":"letsencrypt_webserver_port: \"8081\""},{"line_number":506,"context_line":"letsencrypt_managed_certs: \"{{ \u0027\u0027 if not enable_letsencrypt | bool else (\u0027internal\u0027 if letsencrypt_internal_cert_server !\u003d \u0027\u0027 and kolla_same_external_internal_vip | bool else (\u0027internal,external\u0027 if letsencrypt_internal_cert_server !\u003d \u0027\u0027 and letsencrypt_external_cert_server !\u003d \u0027\u0027 else (\u0027internal\u0027 if letsencrypt_internal_cert_server !\u003d \u0027\u0027 else (\u0027external\u0027 if letsencrypt_external_cert_server !\u003d \u0027\u0027 and not kolla_same_external_internal_vip | bool else \u0027\u0027)))) }}\""},{"line_number":507,"context_line":"letsencrypt_external_cert_server: \"\""},{"line_number":508,"context_line":"letsencrypt_internal_cert_server: \"\""},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"magnum_internal_fqdn: \"{{ kolla_internal_fqdn }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d5306be8_6c4b48a0","side":"PARENT","line":507,"updated":"2025-08-12 11:28:26.000000000","message":"If you are removing variables that can be used by users - it\u0027s not a refactor, because it\u0027s not backwards compatible.","commit_id":"a9f5c2710927838734478c8ebe7bacb23e10adf1"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"f43c2b01d800dc320f354b508440608a1c6d815b","unresolved":false,"context_lines":[{"line_number":504,"context_line":""},{"line_number":505,"context_line":"letsencrypt_webserver_port: \"8081\""},{"line_number":506,"context_line":"letsencrypt_managed_certs: \"{{ \u0027\u0027 if not enable_letsencrypt | bool else (\u0027internal\u0027 if letsencrypt_internal_cert_server !\u003d \u0027\u0027 and kolla_same_external_internal_vip | bool else (\u0027internal,external\u0027 if letsencrypt_internal_cert_server !\u003d \u0027\u0027 and letsencrypt_external_cert_server !\u003d \u0027\u0027 else (\u0027internal\u0027 if letsencrypt_internal_cert_server !\u003d \u0027\u0027 else (\u0027external\u0027 if letsencrypt_external_cert_server !\u003d \u0027\u0027 and not kolla_same_external_internal_vip | bool else \u0027\u0027)))) }}\""},{"line_number":507,"context_line":"letsencrypt_external_cert_server: \"\""},{"line_number":508,"context_line":"letsencrypt_internal_cert_server: \"\""},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"magnum_internal_fqdn: \"{{ kolla_internal_fqdn }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"305505f0_6166daca","side":"PARENT","line":507,"in_reply_to":"3864519f_96968e7c","updated":"2025-08-18 13:46:41.000000000","message":"Done","commit_id":"a9f5c2710927838734478c8ebe7bacb23e10adf1"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"a4293e07d529c10dbcd0bb9b4bc377f03d9649fb","unresolved":true,"context_lines":[{"line_number":504,"context_line":""},{"line_number":505,"context_line":"letsencrypt_webserver_port: \"8081\""},{"line_number":506,"context_line":"letsencrypt_managed_certs: \"{{ \u0027\u0027 if not enable_letsencrypt | bool else (\u0027internal\u0027 if letsencrypt_internal_cert_server !\u003d \u0027\u0027 and kolla_same_external_internal_vip | bool else (\u0027internal,external\u0027 if letsencrypt_internal_cert_server !\u003d \u0027\u0027 and letsencrypt_external_cert_server !\u003d \u0027\u0027 else (\u0027internal\u0027 if letsencrypt_internal_cert_server !\u003d \u0027\u0027 else (\u0027external\u0027 if letsencrypt_external_cert_server !\u003d \u0027\u0027 and not kolla_same_external_internal_vip | bool else \u0027\u0027)))) }}\""},{"line_number":507,"context_line":"letsencrypt_external_cert_server: \"\""},{"line_number":508,"context_line":"letsencrypt_internal_cert_server: \"\""},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"magnum_internal_fqdn: \"{{ kolla_internal_fqdn }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3864519f_96968e7c","side":"PARENT","line":507,"in_reply_to":"d5306be8_6c4b48a0","updated":"2025-08-13 10:53:35.000000000","message":"Will change the wording","commit_id":"a9f5c2710927838734478c8ebe7bacb23e10adf1"}],"ansible/roles/letsencrypt/tasks/precheck.yml":[{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"18e5e4aa2e9d49fef609b6b7b0bced6480e1026e","unresolved":true,"context_lines":[{"line_number":11,"context_line":"- name: Ensure at least one part of certificate is set to be managed by Let\u0027s Encrypt"},{"line_number":12,"context_line":"  run_once: true"},{"line_number":13,"context_line":"  assert:"},{"line_number":14,"context_line":"    that: letsencrypt_manage_external_cert or letsencrypt_manage_internal_cert"},{"line_number":15,"context_line":"    fail_msg:"},{"line_number":16,"context_line":"      \"At least one of the variables from \u0027letsencrypt_manage_external_cert\u0027 and"},{"line_number":17,"context_line":"      \u0027letsencrypt_manage_internal_cert\u0027 needs to be true when Let\u0027s Encrypt is enabled.\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"d7f46e5b_ed48c07e","line":14,"range":{"start_line":14,"start_character":10,"end_line":14,"end_character":78},"updated":"2026-06-01 19:23:00.000000000","message":"| bool","commit_id":"501b5d297a21f12f77fb3b06bed2e6e18d8a8910"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"18e5e4aa2e9d49fef609b6b7b0bced6480e1026e","unresolved":true,"context_lines":[{"line_number":12,"context_line":"  run_once: true"},{"line_number":13,"context_line":"  assert:"},{"line_number":14,"context_line":"    that: letsencrypt_manage_external_cert or letsencrypt_manage_internal_cert"},{"line_number":15,"context_line":"    fail_msg:"},{"line_number":16,"context_line":"      \"At least one of the variables from \u0027letsencrypt_manage_external_cert\u0027 and"},{"line_number":17,"context_line":"      \u0027letsencrypt_manage_internal_cert\u0027 needs to be true when Let\u0027s Encrypt is enabled.\""},{"line_number":18,"context_line":"  when: enable_letsencrypt | bool"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Checking free port for LetsEncrypt server"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"186d2924_fb05581d","line":17,"range":{"start_line":15,"start_character":4,"end_line":17,"end_character":89},"updated":"2026-06-01 19:23:00.000000000","message":"scalar block instead ?","commit_id":"501b5d297a21f12f77fb3b06bed2e6e18d8a8910"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"18e5e4aa2e9d49fef609b6b7b0bced6480e1026e","unresolved":true,"context_lines":[{"line_number":56,"context_line":"  run_once: true"},{"line_number":57,"context_line":"  assert:"},{"line_number":58,"context_line":"    that: letsencrypt_external_cert_server \u003d\u003d letsencrypt_internal_cert_server"},{"line_number":59,"context_line":"    fail_msg:"},{"line_number":60,"context_line":"      \"When the address of external VIP and internal VIP are identical and both certificates are set to be managed by letsencrypt role,"},{"line_number":61,"context_line":"      ACME servers are required to be identical too.\\n"},{"line_number":62,"context_line":"      Please check the value of variables \u0027letsencrypt_external_cert_server\u0027 and \u0027letsencrypt_internal_cert_server\u0027.\""},{"line_number":63,"context_line":"  when: letsencrypt_unified_renew | bool"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"dee556ec_19f6d66d","line":62,"range":{"start_line":59,"start_character":4,"end_line":62,"end_character":117},"updated":"2026-06-01 19:23:00.000000000","message":"scalar block","commit_id":"501b5d297a21f12f77fb3b06bed2e6e18d8a8910"}],"ansible/roles/loadbalancer/templates/haproxy/haproxy.json.j2":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"2258988b44a0ebf2dadf0cb7592f9bbd45f1c00e","unresolved":true,"context_lines":[{"line_number":25,"context_line":"            \"owner\": \"root\","},{"line_number":26,"context_line":"            \"perm\": \"0600\","},{"line_number":27,"context_line":"            \"optional\": {{ (not haproxy_single_external_frontend | bool) | string | lower }}"},{"line_number":28,"context_line":"        }{% if kolla_enable_tls_external | bool and not letsencrypt_manage_external_cert %},"},{"line_number":29,"context_line":"        {"},{"line_number":30,"context_line":"            \"source\": \"{{ container_config_directory }}/haproxy.pem\","},{"line_number":31,"context_line":"            \"dest\": \"/etc/haproxy/certificates/haproxy.pem\","}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"5e8b5d6d_e4e62a94","line":28,"updated":"2025-10-02 13:11:39.000000000","message":"```suggestion\n        }{% if kolla_enable_tls_external | bool and not letsencrypt_manage_external_cert | bool %},\n```","commit_id":"28884b8a7d1566d8cba784c620e17b0add5de290"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"60266b953c99f6d687de3ce1999eb049ccc9684c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            \"owner\": \"root\","},{"line_number":26,"context_line":"            \"perm\": \"0600\","},{"line_number":27,"context_line":"            \"optional\": {{ (not haproxy_single_external_frontend | bool) | string | lower }}"},{"line_number":28,"context_line":"        }{% if kolla_enable_tls_external | bool and not letsencrypt_manage_external_cert %},"},{"line_number":29,"context_line":"        {"},{"line_number":30,"context_line":"            \"source\": \"{{ container_config_directory }}/haproxy.pem\","},{"line_number":31,"context_line":"            \"dest\": \"/etc/haproxy/certificates/haproxy.pem\","}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"771772fd_b3b4ea75","line":28,"in_reply_to":"5e8b5d6d_e4e62a94","updated":"2025-10-02 14:15:58.000000000","message":"Fix applied.","commit_id":"28884b8a7d1566d8cba784c620e17b0add5de290"}],"doc/source/admin/tls.rst":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"2258988b44a0ebf2dadf0cb7592f9bbd45f1c00e","unresolved":true,"context_lines":[{"line_number":333,"context_line":"   * - External + internal (default)"},{"line_number":334,"context_line":"     - Enable Let\u0027s Encrypt; no further changes."},{"line_number":335,"context_line":"   * - Internal only"},{"line_number":336,"context_line":"     - Set ``letsencrypt_manage_ internal_cert: true`` and ``letsencrypt_manage_external_cert: false``"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":".. list-table:: Let\u0027s Encrypt Management (When external VIP and internal VIP are NOT identical)"},{"line_number":339,"context_line":"   :widths: 28 72"}],"source_content_type":"text/x-rst","patch_set":8,"id":"5582a19e_a3f6dde5","line":336,"updated":"2025-10-02 13:11:39.000000000","message":"```suggestion\n     - Set ``letsencrypt_manage_internal_cert: true`` and ``letsencrypt_manage_external_cert: false``\n```","commit_id":"28884b8a7d1566d8cba784c620e17b0add5de290"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"60266b953c99f6d687de3ce1999eb049ccc9684c","unresolved":false,"context_lines":[{"line_number":333,"context_line":"   * - External + internal (default)"},{"line_number":334,"context_line":"     - Enable Let\u0027s Encrypt; no further changes."},{"line_number":335,"context_line":"   * - Internal only"},{"line_number":336,"context_line":"     - Set ``letsencrypt_manage_ internal_cert: true`` and ``letsencrypt_manage_external_cert: false``"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":".. list-table:: Let\u0027s Encrypt Management (When external VIP and internal VIP are NOT identical)"},{"line_number":339,"context_line":"   :widths: 28 72"}],"source_content_type":"text/x-rst","patch_set":8,"id":"b7c160a5_863f7939","line":336,"in_reply_to":"5582a19e_a3f6dde5","updated":"2025-10-02 14:15:58.000000000","message":"Fix applied.","commit_id":"28884b8a7d1566d8cba784c620e17b0add5de290"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"9b6a9b5ddcea978d7699a0155d8da0b6d8131257","unresolved":true,"context_lines":[{"line_number":346,"context_line":"   * - External + internal"},{"line_number":347,"context_line":"     - Set ``letsencrypt_manage_internal_cert: true``"},{"line_number":348,"context_line":"   * - Internal only"},{"line_number":349,"context_line":"     - Set ``letsencrypt_manage_ internal_cert: true`` and ``letsencrypt_manage_external_cert: false``"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"You can also use custom ACME servers for each internal and external"},{"line_number":352,"context_line":"certificate request by setting server URL on"}],"source_content_type":"text/x-rst","patch_set":10,"id":"8b399f71_0b620ae3","line":349,"range":{"start_line":349,"start_character":13,"end_line":349,"end_character":47},"updated":"2026-01-09 09:49:55.000000000","message":"``letsencrypt_manage_ internal_cert:...\nto\n``letsencrypt_manage_internal_cert:","commit_id":"0d29dcb8c207967ed6bcc9df014523f0200e1622"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"3e2f751205353778f05a8b2eb71bbe97e7e53b20","unresolved":true,"context_lines":[{"line_number":346,"context_line":"   * - External + internal"},{"line_number":347,"context_line":"     - Set ``letsencrypt_manage_internal_cert: true``"},{"line_number":348,"context_line":"   * - Internal only"},{"line_number":349,"context_line":"     - Set ``letsencrypt_manage_ internal_cert: true`` and ``letsencrypt_manage_external_cert: false``"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"You can also use custom ACME servers for each internal and external"},{"line_number":352,"context_line":"certificate request by setting server URL on"}],"source_content_type":"text/x-rst","patch_set":10,"id":"7bc3f942_36ebd92f","line":349,"range":{"start_line":349,"start_character":13,"end_line":349,"end_character":47},"in_reply_to":"63f50c0e_a965f2d9","updated":"2026-01-14 14:35:27.000000000","message":"Oh I didn\u0027t catch that! Thank you.","commit_id":"0d29dcb8c207967ed6bcc9df014523f0200e1622"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"a0e936db80cb6388182a923f833d6bdbee40f949","unresolved":false,"context_lines":[{"line_number":346,"context_line":"   * - External + internal"},{"line_number":347,"context_line":"     - Set ``letsencrypt_manage_internal_cert: true``"},{"line_number":348,"context_line":"   * - Internal only"},{"line_number":349,"context_line":"     - Set ``letsencrypt_manage_ internal_cert: true`` and ``letsencrypt_manage_external_cert: false``"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"You can also use custom ACME servers for each internal and external"},{"line_number":352,"context_line":"certificate request by setting server URL on"}],"source_content_type":"text/x-rst","patch_set":10,"id":"53a2d80c_2c89a5e7","line":349,"range":{"start_line":349,"start_character":13,"end_line":349,"end_character":47},"in_reply_to":"7bc3f942_36ebd92f","updated":"2026-01-14 14:37:36.000000000","message":"Done","commit_id":"0d29dcb8c207967ed6bcc9df014523f0200e1622"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"b5f4e47471c36cc4c3efb020f89c74d2ce15b872","unresolved":true,"context_lines":[{"line_number":346,"context_line":"   * - External + internal"},{"line_number":347,"context_line":"     - Set ``letsencrypt_manage_internal_cert: true``"},{"line_number":348,"context_line":"   * - Internal only"},{"line_number":349,"context_line":"     - Set ``letsencrypt_manage_ internal_cert: true`` and ``letsencrypt_manage_external_cert: false``"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"You can also use custom ACME servers for each internal and external"},{"line_number":352,"context_line":"certificate request by setting server URL on"}],"source_content_type":"text/x-rst","patch_set":10,"id":"f6e4dbbc_ad4eb763","line":349,"range":{"start_line":349,"start_character":13,"end_line":349,"end_character":47},"in_reply_to":"8b399f71_0b620ae3","updated":"2026-01-14 13:40:06.000000000","message":"Do you want to make this a normal text?","commit_id":"0d29dcb8c207967ed6bcc9df014523f0200e1622"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"70a168e2891df1b8f2ebd0f46f877a2c18679320","unresolved":true,"context_lines":[{"line_number":346,"context_line":"   * - External + internal"},{"line_number":347,"context_line":"     - Set ``letsencrypt_manage_internal_cert: true``"},{"line_number":348,"context_line":"   * - Internal only"},{"line_number":349,"context_line":"     - Set ``letsencrypt_manage_ internal_cert: true`` and ``letsencrypt_manage_external_cert: false``"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"You can also use custom ACME servers for each internal and external"},{"line_number":352,"context_line":"certificate request by setting server URL on"}],"source_content_type":"text/x-rst","patch_set":10,"id":"63f50c0e_a965f2d9","line":349,"range":{"start_line":349,"start_character":13,"end_line":349,"end_character":47},"in_reply_to":"f6e4dbbc_ad4eb763","updated":"2026-01-14 14:33:42.000000000","message":"you have spaces in the: letsencrypt_manage_ internal_cer variable","commit_id":"0d29dcb8c207967ed6bcc9df014523f0200e1622"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"d3447c63f6ef32f5b533c2d7d7226d9a69cf4a79","unresolved":true,"context_lines":[{"line_number":316,"context_line":"  with HAProxy."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"By default, both external and internal certificates are managed by"},{"line_number":319,"context_line":"Let\u0027s Encrypt.  when ``enable_letsencrypt`` is set to true."},{"line_number":320,"context_line":"You can configure which certificates are managed by Let\u0027s Encrypt by explicitly"},{"line_number":321,"context_line":"setting ``letsencrypt_manage_external_cert`` and"},{"line_number":322,"context_line":"``letsencrypt_manage_internal_cert`` to ``true`` or ``false``."}],"source_content_type":"text/x-rst","patch_set":14,"id":"98796db2_5ce8d8ca","line":319,"updated":"2026-01-21 15:46:10.000000000","message":"```suggestion\nLet\u0027s Encrypt  when ``enable_letsencrypt`` is set to true.\n```","commit_id":"45b6cfd573f32fa6f1db0b9e64da4edcb7ce30d5"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"fbced82f5a640e2cf778c47b09f7f96ef98cb260","unresolved":false,"context_lines":[{"line_number":316,"context_line":"  with HAProxy."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"By default, both external and internal certificates are managed by"},{"line_number":319,"context_line":"Let\u0027s Encrypt.  when ``enable_letsencrypt`` is set to true."},{"line_number":320,"context_line":"You can configure which certificates are managed by Let\u0027s Encrypt by explicitly"},{"line_number":321,"context_line":"setting ``letsencrypt_manage_external_cert`` and"},{"line_number":322,"context_line":"``letsencrypt_manage_internal_cert`` to ``true`` or ``false``."}],"source_content_type":"text/x-rst","patch_set":14,"id":"e6243685_b51f350d","line":319,"in_reply_to":"98796db2_5ce8d8ca","updated":"2026-01-21 15:51:37.000000000","message":"Fix applied.","commit_id":"45b6cfd573f32fa6f1db0b9e64da4edcb7ce30d5"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"18e5e4aa2e9d49fef609b6b7b0bced6480e1026e","unresolved":true,"context_lines":[{"line_number":316,"context_line":"  with HAProxy."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"By default, both external and internal certificates are managed by"},{"line_number":319,"context_line":"Let\u0027s Encrypt  when ``enable_letsencrypt`` is set to true."},{"line_number":320,"context_line":"You can configure which certificates are managed by Let\u0027s Encrypt by explicitly"},{"line_number":321,"context_line":"setting ``letsencrypt_manage_external_cert`` and"},{"line_number":322,"context_line":"``letsencrypt_manage_internal_cert`` to ``true`` or ``false``."}],"source_content_type":"text/x-rst","patch_set":16,"id":"f2bc4885_68eacac5","line":319,"range":{"start_line":319,"start_character":13,"end_line":319,"end_character":15},"updated":"2026-06-01 19:23:00.000000000","message":"nit: double space","commit_id":"501b5d297a21f12f77fb3b06bed2e6e18d8a8910"}]}