)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"74fb7b70bd4dda1ea349a576e917cee9db542095","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"6d4f1066_fda428d6","updated":"2025-08-23 08:44:58.000000000","message":"I don\u0027t think this is backportable, the risk of regressions by getting one of the special cases wrong is too high.\n\nI\u0027m only 1/3rd done with the changes so far, only found reno comments","commit_id":"4158dde0b57f590ab4d098bac0c4dd22dc9e5678"}],"ansible/library/kolla_container.py":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"534c47f1018ad8bf8af201bca23f3906132ce0ac","unresolved":true,"context_lines":[{"line_number":231,"context_line":"author: Sam Yaple"},{"line_number":232,"context_line":"\u0027\u0027\u0027"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"EXAMPLES \u003d \u0027\u0027\u0027"},{"line_number":235,"context_line":"- hosts: kolla_container"},{"line_number":236,"context_line":"  tasks:"},{"line_number":237,"context_line":"    - name: Start container"}],"source_content_type":"text/x-python","patch_set":39,"id":"15a435c5_de7ab4ad","side":"PARENT","line":234,"updated":"2025-08-25 11:09:22.000000000","message":"we need to add those removed common options now in examples","commit_id":"133db6ae22a281fd45901b1716c7cd17cf67889e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"534c47f1018ad8bf8af201bca23f3906132ce0ac","unresolved":true,"context_lines":[{"line_number":362,"context_line":"        \u0027environment\u0027: None,"},{"line_number":363,"context_line":"        \u0027restart_policy\u0027: None,"},{"line_number":364,"context_line":"        \u0027restart_retries\u0027: 10,"},{"line_number":365,"context_line":"        \u0027api_version\u0027: \u0027auto\u0027,"},{"line_number":366,"context_line":"        \u0027graceful_timeout\u0027: 10,"},{"line_number":367,"context_line":"        \u0027client_timeout\u0027: 120,"},{"line_number":368,"context_line":"        \u0027container_engine\u0027: \u0027docker\u0027,"}],"source_content_type":"text/x-python","patch_set":39,"id":"d23efa76_5dfcd899","side":"PARENT","line":365,"updated":"2025-08-25 11:09:22.000000000","message":"api_version is lost in current config. do we need it?","commit_id":"133db6ae22a281fd45901b1716c7cd17cf67889e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"534c47f1018ad8bf8af201bca23f3906132ce0ac","unresolved":true,"context_lines":[{"line_number":389,"context_line":"            new_args[k] \u003d v"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    env_module_common_options \u003d new_args.pop(\u0027environment\u0027, dict()) or dict()"},{"line_number":392,"context_line":"    new_args[\u0027environment\u0027] \u003d env_module_common_options"},{"line_number":393,"context_line":"    new_args[\u0027environment\u0027].update(env_module_environment)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    # if pid_mode \u003d \"\"/None/False, remove it"}],"source_content_type":"text/x-python","patch_set":39,"id":"0aa5660d_4f760f8b","side":"PARENT","line":392,"updated":"2025-08-25 11:09:22.000000000","message":"note: environment is empty now, we\u0027re passing it in every role so it probably won\u0027t bring any harm","commit_id":"133db6ae22a281fd45901b1716c7cd17cf67889e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"534c47f1018ad8bf8af201bca23f3906132ce0ac","unresolved":true,"context_lines":[{"line_number":392,"context_line":"    new_args[\u0027environment\u0027] \u003d env_module_common_options"},{"line_number":393,"context_line":"    new_args[\u0027environment\u0027].update(env_module_environment)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    # if pid_mode \u003d \"\"/None/False, remove it"},{"line_number":396,"context_line":"    if not new_args.get(\u0027pid_mode\u0027, False):"},{"line_number":397,"context_line":"        new_args.pop(\u0027pid_mode\u0027, None)"},{"line_number":398,"context_line":"    # if ipc_mode \u003d \"\"/None/False, remove it"}],"source_content_type":"text/x-python","patch_set":39,"id":"bc49f402_ad9e7eb6","side":"PARENT","line":395,"updated":"2025-08-25 11:09:22.000000000","message":"we removed this bit of code, and some roles are still passing \u0027\u0027 for those. Not sure if that will cause lack of idempotency - None vs \u0027\u0027.","commit_id":"133db6ae22a281fd45901b1716c7cd17cf67889e"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"534c47f1018ad8bf8af201bca23f3906132ce0ac","unresolved":true,"context_lines":[{"line_number":51,"context_line":"      - The version of the api for docker-py to use when contacting docker"},{"line_number":52,"context_line":"    required: False"},{"line_number":53,"context_line":"    type: str"},{"line_number":54,"context_line":"    default: auto"},{"line_number":55,"context_line":"  auth_email:"},{"line_number":56,"context_line":"    description:"},{"line_number":57,"context_line":"      - The email address used to authenticate"}],"source_content_type":"text/x-python","patch_set":39,"id":"0830ed3c_1a1fa37d","line":54,"updated":"2025-08-25 11:09:22.000000000","message":"it is now \u0027none\u0027","commit_id":"48fc779fa9776c155de76d07789c966262febac9"}],"ansible/roles/releasenotes/notes/bug-2120302-75ee33ed6595493e.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"74fb7b70bd4dda1ea349a576e917cee9db542095","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":37,"id":"2b4b3e83_c603cb51","updated":"2025-08-23 08:44:58.000000000","message":"wrong path? I\u0027d expect just releasenotes/notes/bug-2120302-75ee33ed6595493e.yaml","commit_id":"4158dde0b57f590ab4d098bac0c4dd22dc9e5678"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d3d20b6e1ec7a45dd7d06c8bba4281a3bab804c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"b360600c_c8cb19c3","in_reply_to":"2b4b3e83_c603cb51","updated":"2025-08-25 09:24:30.000000000","message":"Done","commit_id":"4158dde0b57f590ab4d098bac0c4dd22dc9e5678"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"74fb7b70bd4dda1ea349a576e917cee9db542095","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dropped ``common_options`` argument for ``kolla_container``."},{"line_number":5,"context_line":"    ``common_options`` has never been properly validated nor obfuscated"},{"line_number":6,"context_line":"    for sensitive data."},{"line_number":7,"context_line":"    This change addresses the issue where auth_password was visible in log"},{"line_number":8,"context_line":"    despite already having no_log\u003dTrue on the auth_password parameter itself,"},{"line_number":9,"context_line":"    because it was nested inside common_options dict."},{"line_number":10,"context_line":"    `LP#2120302 \u003chttps://launchpad.net/bugs/2120302\u003e`__"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":37,"id":"fe89a86c_e639e41d","line":9,"range":{"start_line":6,"start_character":4,"end_line":9,"end_character":53},"updated":"2025-08-23 08:44:58.000000000","message":"```suggestion\n    for sensitive data. This change addresses the issue where\n    ``auth_password`` was visible in the log despite already having\n    ``no_log\u003dTrue`` on the ``auth_password`` parameter itself,\n    because it was nested inside the ``common_options`` dict.\n```","commit_id":"4158dde0b57f590ab4d098bac0c4dd22dc9e5678"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"76af77b28d2a42d32d85971448d0f750103f3717","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dropped ``common_options`` argument for ``kolla_container``."},{"line_number":5,"context_line":"    ``common_options`` has never been properly validated nor obfuscated"},{"line_number":6,"context_line":"    for sensitive data."},{"line_number":7,"context_line":"    This change addresses the issue where auth_password was visible in log"},{"line_number":8,"context_line":"    despite already having no_log\u003dTrue on the auth_password parameter itself,"},{"line_number":9,"context_line":"    because it was nested inside common_options dict."},{"line_number":10,"context_line":"    `LP#2120302 \u003chttps://launchpad.net/bugs/2120302\u003e`__"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":37,"id":"5597fd52_dfa775c3","line":9,"range":{"start_line":6,"start_character":4,"end_line":9,"end_character":53},"in_reply_to":"fe89a86c_e639e41d","updated":"2025-08-25 09:24:23.000000000","message":"Fix applied.","commit_id":"4158dde0b57f590ab4d098bac0c4dd22dc9e5678"}],"zuul.d/project.yaml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"9104e6ea939e060913f5560ff0dea99ea780976c","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    check:"},{"line_number":13,"context_line":"      jobs:"},{"line_number":14,"context_line":"        - kolla-ansible-centos10s"},{"line_number":15,"context_line":"        - kolla-ansible-debian"},{"line_number":16,"context_line":"        - kolla-ansible-debian-podman"},{"line_number":17,"context_line":"        - kolla-ansible-ubuntu"},{"line_number":18,"context_line":"        - kolla-ansible-ubuntu-podman"},{"line_number":19,"context_line":"        - kolla-ansible-ubuntu-kvm"},{"line_number":20,"context_line":"        - kolla-ansible-ubuntu-multinode-ipv6"},{"line_number":21,"context_line":"        - kolla-ansible-ubuntu-bifrost"},{"line_number":22,"context_line":"        - kolla-ansible-ubuntu-zun"},{"line_number":23,"context_line":"        - kolla-ansible-ubuntu-magnum"},{"line_number":24,"context_line":"        - kolla-ansible-ubuntu-octavia"},{"line_number":25,"context_line":"        - kolla-ansible-ubuntu-masakari"},{"line_number":26,"context_line":"        - kolla-ansible-debian-ironic"},{"line_number":27,"context_line":"        - kolla-ansible-ubuntu-ironic"},{"line_number":28,"context_line":"        - kolla-ansible-debian-upgrade"},{"line_number":29,"context_line":"        - kolla-ansible-ubuntu-upgrade"},{"line_number":30,"context_line":"        - kolla-ansible-ubuntu-cells"},{"line_number":31,"context_line":"        - kolla-ansible-debian-mariadb"},{"line_number":32,"context_line":"        - kolla-ansible-ubuntu-mariadb"},{"line_number":33,"context_line":"        - kolla-ansible-debian-ovn"},{"line_number":34,"context_line":"        - kolla-ansible-ubuntu-ovn"},{"line_number":35,"context_line":"        - kolla-ansible-debian-upgrade-ovn"},{"line_number":36,"context_line":"        - kolla-ansible-ubuntu-upgrade-ovn"},{"line_number":37,"context_line":"        - kolla-ansible-debian"},{"line_number":38,"context_line":"        - kolla-ansible-ubuntu-prometheus-opensearch"},{"line_number":39,"context_line":"        - kolla-ansible-ubuntu-prometheus-opensearch-upgrade"},{"line_number":40,"context_line":"        - kolla-ansible-ubuntu-venus"},{"line_number":41,"context_line":"        - kolla-ansible-ubuntu-cephadm"},{"line_number":42,"context_line":"        - kolla-ansible-ubuntu-upgrade-cephadm"},{"line_number":43,"context_line":"        - kolla-ansible-ubuntu-haproxy-fqdn"},{"line_number":44,"context_line":"        - kolla-ansible-ubuntu-lets-encrypt"},{"line_number":45,"context_line":"        - kolla-ansible-ubuntu-skyline"},{"line_number":46,"context_line":"        - kolla-ansible-ubuntu-skyline-sso"},{"line_number":47,"context_line":"        - kolla-ansible-ubuntu-container-engine-migration"},{"line_number":48,"context_line":"        - kolla-ansible-ubuntu-container-engine-migration-multinode"},{"line_number":49,"context_line":"        - kolla-ansible-debian-container-engine-migration"},{"line_number":50,"context_line":"        - kolla-ansible-debian-container-engine-migration-multinode"},{"line_number":51,"context_line":"    check-arm64:"},{"line_number":52,"context_line":"      jobs:"},{"line_number":53,"context_line":"        - kolla-ansible-centos10s-aarch64"},{"line_number":54,"context_line":"        - kolla-ansible-debian-aarch64"},{"line_number":55,"context_line":"        - kolla-ansible-debian-aarch64-podman"},{"line_number":56,"context_line":"        - kolla-ansible-debian-upgrade-aarch64"},{"line_number":57,"context_line":"    gate:"},{"line_number":58,"context_line":"      jobs:"},{"line_number":59,"context_line":"        - kolla-ansible-debian"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"382ad3b9_eece252d","side":"PARENT","line":56,"range":{"start_line":15,"start_character":0,"end_line":56,"end_character":46},"updated":"2025-08-21 13:43:02.000000000","message":"unsure how that will fix the issue. looks like this is from another change?","commit_id":"133db6ae22a281fd45901b1716c7cd17cf67889e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"32a5f96b24c4524b0caf31a9d89342418a661d6f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    check:"},{"line_number":13,"context_line":"      jobs:"},{"line_number":14,"context_line":"        - kolla-ansible-centos10s"},{"line_number":15,"context_line":"        - kolla-ansible-debian"},{"line_number":16,"context_line":"        - kolla-ansible-debian-podman"},{"line_number":17,"context_line":"        - kolla-ansible-ubuntu"},{"line_number":18,"context_line":"        - kolla-ansible-ubuntu-podman"},{"line_number":19,"context_line":"        - kolla-ansible-ubuntu-kvm"},{"line_number":20,"context_line":"        - kolla-ansible-ubuntu-multinode-ipv6"},{"line_number":21,"context_line":"        - kolla-ansible-ubuntu-bifrost"},{"line_number":22,"context_line":"        - kolla-ansible-ubuntu-zun"},{"line_number":23,"context_line":"        - kolla-ansible-ubuntu-magnum"},{"line_number":24,"context_line":"        - kolla-ansible-ubuntu-octavia"},{"line_number":25,"context_line":"        - kolla-ansible-ubuntu-masakari"},{"line_number":26,"context_line":"        - kolla-ansible-debian-ironic"},{"line_number":27,"context_line":"        - kolla-ansible-ubuntu-ironic"},{"line_number":28,"context_line":"        - kolla-ansible-debian-upgrade"},{"line_number":29,"context_line":"        - kolla-ansible-ubuntu-upgrade"},{"line_number":30,"context_line":"        - kolla-ansible-ubuntu-cells"},{"line_number":31,"context_line":"        - kolla-ansible-debian-mariadb"},{"line_number":32,"context_line":"        - kolla-ansible-ubuntu-mariadb"},{"line_number":33,"context_line":"        - kolla-ansible-debian-ovn"},{"line_number":34,"context_line":"        - kolla-ansible-ubuntu-ovn"},{"line_number":35,"context_line":"        - kolla-ansible-debian-upgrade-ovn"},{"line_number":36,"context_line":"        - kolla-ansible-ubuntu-upgrade-ovn"},{"line_number":37,"context_line":"        - kolla-ansible-debian"},{"line_number":38,"context_line":"        - kolla-ansible-ubuntu-prometheus-opensearch"},{"line_number":39,"context_line":"        - kolla-ansible-ubuntu-prometheus-opensearch-upgrade"},{"line_number":40,"context_line":"        - kolla-ansible-ubuntu-venus"},{"line_number":41,"context_line":"        - kolla-ansible-ubuntu-cephadm"},{"line_number":42,"context_line":"        - kolla-ansible-ubuntu-upgrade-cephadm"},{"line_number":43,"context_line":"        - kolla-ansible-ubuntu-haproxy-fqdn"},{"line_number":44,"context_line":"        - kolla-ansible-ubuntu-lets-encrypt"},{"line_number":45,"context_line":"        - kolla-ansible-ubuntu-skyline"},{"line_number":46,"context_line":"        - kolla-ansible-ubuntu-skyline-sso"},{"line_number":47,"context_line":"        - kolla-ansible-ubuntu-container-engine-migration"},{"line_number":48,"context_line":"        - kolla-ansible-ubuntu-container-engine-migration-multinode"},{"line_number":49,"context_line":"        - kolla-ansible-debian-container-engine-migration"},{"line_number":50,"context_line":"        - kolla-ansible-debian-container-engine-migration-multinode"},{"line_number":51,"context_line":"    check-arm64:"},{"line_number":52,"context_line":"      jobs:"},{"line_number":53,"context_line":"        - kolla-ansible-centos10s-aarch64"},{"line_number":54,"context_line":"        - kolla-ansible-debian-aarch64"},{"line_number":55,"context_line":"        - kolla-ansible-debian-aarch64-podman"},{"line_number":56,"context_line":"        - kolla-ansible-debian-upgrade-aarch64"},{"line_number":57,"context_line":"    gate:"},{"line_number":58,"context_line":"      jobs:"},{"line_number":59,"context_line":"        - kolla-ansible-debian"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"dae3bd48_f8aa7305","side":"PARENT","line":56,"range":{"start_line":15,"start_character":0,"end_line":56,"end_character":46},"in_reply_to":"382ad3b9_eece252d","updated":"2025-08-21 13:47:07.000000000","message":"Done","commit_id":"133db6ae22a281fd45901b1716c7cd17cf67889e"}]}