)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"cb0a0b51e2d4c77d71737fb97abbb0899c72166e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dad4f0d2_6872ee6f","updated":"2026-06-18 15:33:16.000000000","message":"+2 on John\u0027s part. We are running this patch successfully at a private deployment. I\u0027ve tried to address review comments.","commit_id":"c2452ee422687d0d22cfe38626135738bf08c7c1"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"08ab5240c9f5255edb345cfb09ada7ea432bacb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bd466b5c_c42a23bc","updated":"2026-07-02 14:20:16.000000000","message":"+2 on John\u0027s parts","commit_id":"bab6581df1ed08b0299d3b64d868cf5f81669e22"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"6cc7826532dc390d43c192bade60a3b9b1afa669","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"68bf68c6_2781a633","updated":"2026-07-16 07:06:57.000000000","message":"according to manila code base vast_host, vast_password and vast_user should be vast_mgmt_* :\n\nhttps://github.com/openstack/manila/blob/c2e67de82b40eecd416a539c230db1e518a69275/manila/share/drivers/vastdata/driver.py#L56\n\nhttps://github.com/openstack/manila/blob/c2e67de82b40eecd416a539c230db1e518a69275/doc/source/configuration/shared-file-systems/drivers/vastdata_driver.rst#vast-share-driver-configuration-example","commit_id":"cdbfddd7fc59e056a47b171b315321510111e8a6"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"5dc6dc5e0d58755de1826d58c3c05f2ead8737f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3870e969_facf9c4c","in_reply_to":"68bf68c6_2781a633","updated":"2026-07-16 08:19:17.000000000","message":"doh, thanks, good spot","commit_id":"cdbfddd7fc59e056a47b171b315321510111e8a6"}],"ansible/roles/manila/templates/manila-share.conf.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1c96f262cbb2111b8c520a111d6e8d96c57bc7e6","unresolved":true,"context_lines":[{"line_number":190,"context_line":"vast_password \u003d {{ manila_vast_password }}"},{"line_number":191,"context_line":"{%     endif %}"},{"line_number":192,"context_line":"vast_vippool_name \u003d {{ manila_vast_vippool_name }}"},{"line_number":193,"context_line":"vast_root_export \u003d {{ manila_vast_root_export | default(\"manila\") }}"},{"line_number":194,"context_line":"vast_mgmt_port \u003d {{ manila_vast_port }}"},{"line_number":195,"context_line":"{% endif %}"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"6715cc24_dde22283","line":193,"range":{"start_line":193,"start_character":48,"end_line":193,"end_character":65},"updated":"2026-07-15 13:14:14.000000000","message":"Should that rather go to role defaults for clarity? Especially if in future we\u0027re going to get to autogenerating role docs?","commit_id":"bab6581df1ed08b0299d3b64d868cf5f81669e22"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"01acbc0b962f3f1bb971b8645f4a2b112e6ae011","unresolved":false,"context_lines":[{"line_number":190,"context_line":"vast_password \u003d {{ manila_vast_password }}"},{"line_number":191,"context_line":"{%     endif %}"},{"line_number":192,"context_line":"vast_vippool_name \u003d {{ manila_vast_vippool_name }}"},{"line_number":193,"context_line":"vast_root_export \u003d {{ manila_vast_root_export | default(\"manila\") }}"},{"line_number":194,"context_line":"vast_mgmt_port \u003d {{ manila_vast_port }}"},{"line_number":195,"context_line":"{% endif %}"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"104232c1_bdce05fd","line":193,"range":{"start_line":193,"start_character":48,"end_line":193,"end_character":65},"in_reply_to":"6715cc24_dde22283","updated":"2026-07-15 13:20:49.000000000","message":"Marked as resolved.","commit_id":"bab6581df1ed08b0299d3b64d868cf5f81669e22"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"6cc7826532dc390d43c192bade60a3b9b1afa669","unresolved":true,"context_lines":[{"line_number":182,"context_line":"share_driver \u003d manila.share.drivers.vastdata.driver.VASTShareDriver"},{"line_number":183,"context_line":"snapshot_support \u003d true"},{"line_number":184,"context_line":"driver_handles_share_servers \u003d false"},{"line_number":185,"context_line":"vast_host \u003d {{ manila_vast_host }}"},{"line_number":186,"context_line":"{%     if manila_vast_api_token is defined and manila_vast_api_token | length \u003e 0 %}"},{"line_number":187,"context_line":"vast_api_token \u003d {{ manila_vast_api_token }}"},{"line_number":188,"context_line":"{%     else %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"aa197ab7_b4d5cf29","line":185,"updated":"2026-07-16 07:06:57.000000000","message":"```suggestion\nvast_mgmt_host \u003d {{ manila_vast_host }}\n```","commit_id":"cdbfddd7fc59e056a47b171b315321510111e8a6"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"5dc6dc5e0d58755de1826d58c3c05f2ead8737f2","unresolved":false,"context_lines":[{"line_number":182,"context_line":"share_driver \u003d manila.share.drivers.vastdata.driver.VASTShareDriver"},{"line_number":183,"context_line":"snapshot_support \u003d true"},{"line_number":184,"context_line":"driver_handles_share_servers \u003d false"},{"line_number":185,"context_line":"vast_host \u003d {{ manila_vast_host }}"},{"line_number":186,"context_line":"{%     if manila_vast_api_token is defined and manila_vast_api_token | length \u003e 0 %}"},{"line_number":187,"context_line":"vast_api_token \u003d {{ manila_vast_api_token }}"},{"line_number":188,"context_line":"{%     else %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"552d956b_2f188b00","line":185,"in_reply_to":"aa197ab7_b4d5cf29","updated":"2026-07-16 08:19:17.000000000","message":"Done","commit_id":"cdbfddd7fc59e056a47b171b315321510111e8a6"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"6cc7826532dc390d43c192bade60a3b9b1afa669","unresolved":true,"context_lines":[{"line_number":186,"context_line":"{%     if manila_vast_api_token is defined and manila_vast_api_token | length \u003e 0 %}"},{"line_number":187,"context_line":"vast_api_token \u003d {{ manila_vast_api_token }}"},{"line_number":188,"context_line":"{%     else %}"},{"line_number":189,"context_line":"vast_user \u003d {{ manila_vast_user }}"},{"line_number":190,"context_line":"vast_password \u003d {{ manila_vast_password }}"},{"line_number":191,"context_line":"{%     endif %}"},{"line_number":192,"context_line":"vast_vippool_name \u003d {{ manila_vast_vippool_name }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"4c949bfa_27579fd5","line":189,"updated":"2026-07-16 07:06:57.000000000","message":"```suggestion\nvast_mgmt_user \u003d {{ manila_vast_user }}\n```","commit_id":"cdbfddd7fc59e056a47b171b315321510111e8a6"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"5dc6dc5e0d58755de1826d58c3c05f2ead8737f2","unresolved":false,"context_lines":[{"line_number":186,"context_line":"{%     if manila_vast_api_token is defined and manila_vast_api_token | length \u003e 0 %}"},{"line_number":187,"context_line":"vast_api_token \u003d {{ manila_vast_api_token }}"},{"line_number":188,"context_line":"{%     else %}"},{"line_number":189,"context_line":"vast_user \u003d {{ manila_vast_user }}"},{"line_number":190,"context_line":"vast_password \u003d {{ manila_vast_password }}"},{"line_number":191,"context_line":"{%     endif %}"},{"line_number":192,"context_line":"vast_vippool_name \u003d {{ manila_vast_vippool_name }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"177a29f2_2e0678c6","line":189,"in_reply_to":"4c949bfa_27579fd5","updated":"2026-07-16 08:19:17.000000000","message":"Done","commit_id":"cdbfddd7fc59e056a47b171b315321510111e8a6"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"6cc7826532dc390d43c192bade60a3b9b1afa669","unresolved":true,"context_lines":[{"line_number":187,"context_line":"vast_api_token \u003d {{ manila_vast_api_token }}"},{"line_number":188,"context_line":"{%     else %}"},{"line_number":189,"context_line":"vast_user \u003d {{ manila_vast_user }}"},{"line_number":190,"context_line":"vast_password \u003d {{ manila_vast_password }}"},{"line_number":191,"context_line":"{%     endif %}"},{"line_number":192,"context_line":"vast_vippool_name \u003d {{ manila_vast_vippool_name }}"},{"line_number":193,"context_line":"vast_root_export \u003d {{ manila_vast_root_export }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"60d9b64d_0733539b","line":190,"updated":"2026-07-16 07:06:57.000000000","message":"```suggestion\nvast_mgmt_password \u003d {{ manila_vast_password }}\n```","commit_id":"cdbfddd7fc59e056a47b171b315321510111e8a6"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"5dc6dc5e0d58755de1826d58c3c05f2ead8737f2","unresolved":false,"context_lines":[{"line_number":187,"context_line":"vast_api_token \u003d {{ manila_vast_api_token }}"},{"line_number":188,"context_line":"{%     else %}"},{"line_number":189,"context_line":"vast_user \u003d {{ manila_vast_user }}"},{"line_number":190,"context_line":"vast_password \u003d {{ manila_vast_password }}"},{"line_number":191,"context_line":"{%     endif %}"},{"line_number":192,"context_line":"vast_vippool_name \u003d {{ manila_vast_vippool_name }}"},{"line_number":193,"context_line":"vast_root_export \u003d {{ manila_vast_root_export }}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9caef6e9_50f7b8a0","line":190,"in_reply_to":"60d9b64d_0733539b","updated":"2026-07-16 08:19:17.000000000","message":"Done","commit_id":"cdbfddd7fc59e056a47b171b315321510111e8a6"}],"doc/source/reference/storage/manila-vast-guide.rst":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"bb6aadebd5ec602ff9cbe339acdc7ef5a27236c1","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"   manila_vast_mgmt_host: \"\u003chostname or IP for VAST REST API\u003e\""},{"line_number":29,"context_line":"   manila_vast_mgmt_user: \"\u003cusername\u003e\""},{"line_number":30,"context_line":"   vast_mgmt_password: \"\u003cpassword\u003e\""},{"line_number":31,"context_line":"   manila_vast_vippool_name: \"\u003cvirtual IP pool name\u003e\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The driver assumes tenant networks that which to mount"}],"source_content_type":"text/x-rst","patch_set":2,"id":"478cf28d_e152f755","line":30,"updated":"2025-10-10 08:07:50.000000000","message":"```suggestion\n   manila_vast_mgmt_password: \"\u003cpassword\u003e\"\n```","commit_id":"96fac1deece91b953208a86c75c3b69ffb939468"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"cb0a0b51e2d4c77d71737fb97abbb0899c72166e","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"   manila_vast_mgmt_host: \"\u003chostname or IP for VAST REST API\u003e\""},{"line_number":29,"context_line":"   manila_vast_mgmt_user: \"\u003cusername\u003e\""},{"line_number":30,"context_line":"   vast_mgmt_password: \"\u003cpassword\u003e\""},{"line_number":31,"context_line":"   manila_vast_vippool_name: \"\u003cvirtual IP pool name\u003e\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The driver assumes tenant networks that which to mount"}],"source_content_type":"text/x-rst","patch_set":2,"id":"2ce7dfb8_6eb8335b","line":30,"in_reply_to":"478cf28d_e152f755","updated":"2026-06-18 15:33:16.000000000","message":"Done","commit_id":"96fac1deece91b953208a86c75c3b69ffb939468"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"bb6aadebd5ec602ff9cbe339acdc7ef5a27236c1","unresolved":true,"context_lines":[{"line_number":29,"context_line":"   manila_vast_mgmt_user: \"\u003cusername\u003e\""},{"line_number":30,"context_line":"   vast_mgmt_password: \"\u003cpassword\u003e\""},{"line_number":31,"context_line":"   manila_vast_vippool_name: \"\u003cvirtual IP pool name\u003e\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The driver assumes tenant networks that which to mount"},{"line_number":34,"context_line":"their VAST backed NFS file shares are able to route to the"},{"line_number":35,"context_line":"VAST virtual IP pool you have chosen."}],"source_content_type":"text/x-rst","patch_set":2,"id":"659fe372_f59e4752","line":32,"updated":"2025-10-10 08:07:50.000000000","message":"should we add manila_vast_root_export here ?","commit_id":"96fac1deece91b953208a86c75c3b69ffb939468"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"cb0a0b51e2d4c77d71737fb97abbb0899c72166e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"   manila_vast_mgmt_user: \"\u003cusername\u003e\""},{"line_number":30,"context_line":"   vast_mgmt_password: \"\u003cpassword\u003e\""},{"line_number":31,"context_line":"   manila_vast_vippool_name: \"\u003cvirtual IP pool name\u003e\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The driver assumes tenant networks that which to mount"},{"line_number":34,"context_line":"their VAST backed NFS file shares are able to route to the"},{"line_number":35,"context_line":"VAST virtual IP pool you have chosen."}],"source_content_type":"text/x-rst","patch_set":2,"id":"738b2036_2d82c0c6","line":32,"in_reply_to":"659fe372_f59e4752","updated":"2026-06-18 15:33:16.000000000","message":"Done","commit_id":"96fac1deece91b953208a86c75c3b69ffb939468"}],"etc/kolla/globals.yml":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"bb6aadebd5ec602ff9cbe339acdc7ef5a27236c1","unresolved":true,"context_lines":[{"line_number":720,"context_line":"#manila_vast_mgmt_user:"},{"line_number":721,"context_line":"#manila_vast_mgmt_password:"},{"line_number":722,"context_line":"#manila_vast_vippool_name:"},{"line_number":723,"context_line":"#vast_root_export:"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"############"},{"line_number":726,"context_line":"# Prometheus"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"82651574_0fdc1c6f","line":723,"updated":"2025-10-10 08:07:50.000000000","message":"```suggestion\n#manila_vast_root_export:\n```","commit_id":"96fac1deece91b953208a86c75c3b69ffb939468"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"cb0a0b51e2d4c77d71737fb97abbb0899c72166e","unresolved":false,"context_lines":[{"line_number":720,"context_line":"#manila_vast_mgmt_user:"},{"line_number":721,"context_line":"#manila_vast_mgmt_password:"},{"line_number":722,"context_line":"#manila_vast_vippool_name:"},{"line_number":723,"context_line":"#vast_root_export:"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"############"},{"line_number":726,"context_line":"# Prometheus"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d91174d6_fa49f55a","line":723,"in_reply_to":"82651574_0fdc1c6f","updated":"2026-06-18 15:33:16.000000000","message":"Done","commit_id":"96fac1deece91b953208a86c75c3b69ffb939468"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7a843e8a57be117e89a10a87dc32921db1946f1f","unresolved":true,"context_lines":[{"line_number":708,"context_line":""},{"line_number":709,"context_line":"# Vast configuration for Manila"},{"line_number":710,"context_line":"#manila_vast_mgmt_host:"},{"line_number":711,"context_line":"#manila_vast_mgmt_user:"},{"line_number":712,"context_line":"#manila_vast_vippool_name:"},{"line_number":713,"context_line":"#manila_vast_root_export:"},{"line_number":714,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dc828be1_2cf7d8b0","line":711,"updated":"2026-06-18 15:44:15.000000000","message":"Should we sync the default username with cinder_vast_user? And do we need the mgmt part in the variable (I understand the sync with manila.conf, although it could be easier for an operator to skip the mgmt part - I\u0027m not persistent on changing that)","commit_id":"c2452ee422687d0d22cfe38626135738bf08c7c1"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"ad6a5aca29e91cd88b1829fbe35d6b403387011e","unresolved":false,"context_lines":[{"line_number":708,"context_line":""},{"line_number":709,"context_line":"# Vast configuration for Manila"},{"line_number":710,"context_line":"#manila_vast_mgmt_host:"},{"line_number":711,"context_line":"#manila_vast_mgmt_user:"},{"line_number":712,"context_line":"#manila_vast_vippool_name:"},{"line_number":713,"context_line":"#manila_vast_root_export:"},{"line_number":714,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1703c32f_de6c2afb","line":711,"in_reply_to":"0444f8c7_cb2de2e3","updated":"2026-06-19 14:47:56.000000000","message":"Done","commit_id":"c2452ee422687d0d22cfe38626135738bf08c7c1"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"907d57d92ec10e136888e0181f379302461b3f5b","unresolved":true,"context_lines":[{"line_number":708,"context_line":""},{"line_number":709,"context_line":"# Vast configuration for Manila"},{"line_number":710,"context_line":"#manila_vast_mgmt_host:"},{"line_number":711,"context_line":"#manila_vast_mgmt_user:"},{"line_number":712,"context_line":"#manila_vast_vippool_name:"},{"line_number":713,"context_line":"#manila_vast_root_export:"},{"line_number":714,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0444f8c7_cb2de2e3","line":711,"in_reply_to":"dc828be1_2cf7d8b0","updated":"2026-06-19 12:14:42.000000000","message":"Good question - VAST supports creating API tokens so we should prefer that rather username/password. There should be a separate token for Cinder. The only likely shared bit is the VAST host and port. I can add that. I renamed the vars.","commit_id":"c2452ee422687d0d22cfe38626135738bf08c7c1"}]}