)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5d6dd880a0c75a5137176979d90e738b21bcd70c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"41d99738_b5530e42","updated":"2025-09-05 07:04:16.000000000","message":"Just a slight reminder, that we decided on the PTG to rework all the Cinder backends into something generic - https://etherpad.opendev.org/p/kolla-flamingo-ptg#L196","commit_id":"f17b82784229cd5a0fe2ea88d0bc9ff2c8b2247a"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"650e1c95118f1f68a0d0f3e26844a45da3197c2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f2a2f2a7_9a4c370e","updated":"2025-10-13 14:38:19.000000000","message":"LGTM, let\u0027s wait for upstream cinder","commit_id":"f17b82784229cd5a0fe2ea88d0bc9ff2c8b2247a"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"717147cf0c58083c90a6d0e7b2b4b0692bb2bd17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fabf304c_e8d0c70e","in_reply_to":"41d99738_b5530e42","updated":"2026-06-18 13:54:48.000000000","message":"Acknowledged","commit_id":"f17b82784229cd5a0fe2ea88d0bc9ff2c8b2247a"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"19e9b974c4307cdf87bfa6ab28ccda8227a891cd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4550919a_7f341407","updated":"2026-06-18 12:14:38.000000000","message":"@mnasiadka@gmail.com, as I remember, we agreed not to merge other custom Cinder drivers and plan to create a generic driver. so waiting -2 from your side.\n@john@johngarbutt.com, please change the code to add generic support","commit_id":"910830b085ce795e68ab3c3c5aedc3db4181b556"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"665356ad4e39795890ad580b568a63ab0e548e96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"19f6a1be_ebda6bce","updated":"2026-06-18 11:01:10.000000000","message":"We are using this patch on Epoxy and it works with a VAST appliance.\nI didn\u0027t find anything on the rework - that can be considered separately.","commit_id":"910830b085ce795e68ab3c3c5aedc3db4181b556"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"98cc147d0b57b569c95fa09d151c936513d0352d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"92333e59_7eb2a4ae","updated":"2026-06-18 11:40:50.000000000","message":"docs missing in doc/source/reference/storage","commit_id":"910830b085ce795e68ab3c3c5aedc3db4181b556"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2e84706bfed88d0886bd4d3edc56da421ff209f8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5918f9e2_06daee14","in_reply_to":"4550919a_7f341407","updated":"2026-06-18 12:46:52.000000000","message":"Maksim, you can\u0027t force contributors to change the approach - and doing the generic approach and deprecating everything else (or dropping) is a lot to ask for - doing the generic approach is fantastic, but we don\u0027t want to scare off contributors - do we? I\u0027m fine with that being done outside of that commit, which has been here since 2025.","commit_id":"910830b085ce795e68ab3c3c5aedc3db4181b556"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"5177c4d4f2294fa074628cdac97c761c03eece6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"72c37094_35158920","in_reply_to":"5918f9e2_06daee14","updated":"2026-06-18 13:20:05.000000000","message":"Agree it would be nice to add the generic driver. Unfortunately John is no longer around and Darmach (who volunteered for the task) is not available at the moment.","commit_id":"910830b085ce795e68ab3c3c5aedc3db4181b556"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"85aa5dc1e9f4e4097e57b9d80a9330dbc6a4d253","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"91785fea_636f81a4","in_reply_to":"69e5d727_93336c40","updated":"2026-06-18 15:12:13.000000000","message":"Maksim, I\u0027d like to remind you that you advocated for merging the Huawei patch, so we did and we agreed to work on the generic approach, but nobody did that.\nSince nobody did that - I\u0027m not going to block people on an agreed but never implemented plan.\nSee https://review.opendev.org/c/openstack/kolla-ansible/+/869252/comments/44f148ea_32754fd9","commit_id":"910830b085ce795e68ab3c3c5aedc3db4181b556"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"505ae7137a9d963d1076935254cdd0ecbb461ae3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"69e5d727_93336c40","in_reply_to":"72c37094_35158920","updated":"2026-06-18 15:06:30.000000000","message":"double standards?\n\n1. https://review.opendev.org/c/openstack/kolla-ansible/+/869252/comments/4c2225a0_ae3bfae4\n\n2. https://etherpad.opendev.org/p/kolla-flamingo-ptg#L196","commit_id":"910830b085ce795e68ab3c3c5aedc3db4181b556"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4f7d615d56254758d3b96733bce9e5a9cffc8d60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a4283bce_ea44a0ea","in_reply_to":"91785fea_636f81a4","updated":"2026-06-18 15:15:28.000000000","message":"Okay. I\u0027m okay with specific driver support. Thanks for clarification.","commit_id":"910830b085ce795e68ab3c3c5aedc3db4181b556"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1d53e9fdab239e9e9b720fc8b51f618a8cc45142","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3faeb31a_a9a1ac57","in_reply_to":"92333e59_7eb2a4ae","updated":"2026-06-18 11:41:06.000000000","message":"argh, I was blind.","commit_id":"910830b085ce795e68ab3c3c5aedc3db4181b556"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a309b90138bdc3b8ea94dc4e8bf134ca07f745f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a1579d90_7df8ec9c","updated":"2026-06-18 13:22:05.000000000","message":"+2 on John\u0027s work","commit_id":"4d5683d2d3545681ace476195703fae7b70d7642"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"368cc19795efbfe2ddef74d58f744e2954674924","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6191c47f_1fe71d11","updated":"2026-06-19 14:43:35.000000000","message":"Trivial change to fix line length for the linter","commit_id":"3131410289b5b5a7c4bdd78d81f71037a00166eb"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"44374d63f0f69d1f53158b0c020caea565712cdb","unresolved":true,"context_lines":[{"line_number":842,"context_line":"enable_cinder_backend_pure_fc: \"no\""},{"line_number":843,"context_line":"enable_cinder_backend_pure_roce: \"no\""},{"line_number":844,"context_line":"enable_cinder_backend_pure_nvme_tcp: \"no\""},{"line_number":845,"context_line":"enable_cinder_backend_vast: \"no\""},{"line_number":846,"context_line":"enable_cinder_backend_lightbits: \"no\""},{"line_number":847,"context_line":"enable_cloudkitty: \"no\""},{"line_number":848,"context_line":"enable_collectd: \"no\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c6435482_a35b83f8","line":845,"updated":"2025-09-04 16:48:16.000000000","message":"nit: not alphabetically sorted. should be on line 847","commit_id":"f17b82784229cd5a0fe2ea88d0bc9ff2c8b2247a"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"717147cf0c58083c90a6d0e7b2b4b0692bb2bd17","unresolved":false,"context_lines":[{"line_number":842,"context_line":"enable_cinder_backend_pure_fc: \"no\""},{"line_number":843,"context_line":"enable_cinder_backend_pure_roce: \"no\""},{"line_number":844,"context_line":"enable_cinder_backend_pure_nvme_tcp: \"no\""},{"line_number":845,"context_line":"enable_cinder_backend_vast: \"no\""},{"line_number":846,"context_line":"enable_cinder_backend_lightbits: \"no\""},{"line_number":847,"context_line":"enable_cloudkitty: \"no\""},{"line_number":848,"context_line":"enable_collectd: \"no\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"671bed4a_58b8e9f1","line":845,"in_reply_to":"c6435482_a35b83f8","updated":"2026-06-18 13:54:48.000000000","message":"Done","commit_id":"f17b82784229cd5a0fe2ea88d0bc9ff2c8b2247a"}],"ansible/roles/cinder/templates/cinder.conf.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f54dc9d59eeaaa5fe0226f2c6578a02e2dcb105c","unresolved":true,"context_lines":[{"line_number":231,"context_line":"{% if enable_cinder_backend_vast | bool %}"},{"line_number":232,"context_line":"[{{ cinder_backend_vast_name }}]"},{"line_number":233,"context_line":"volume_driver \u003d cinder.volume.drivers.vastdata.driver.VASTVolumeDriver"},{"line_number":234,"context_line":"volume_backend_name \u003d {{ cinder_backend_vast_name }}"},{"line_number":235,"context_line":"vast_vippool_name \u003d {{ cinder_vast_vippool_name }}"},{"line_number":236,"context_line":"vast_subsystem \u003d {{ cinder_vast_subsystem }}"},{"line_number":237,"context_line":"san_ip \u003d {{ cinder_vast_ip }}"},{"line_number":238,"context_line":"san_api_port \u003d {{ cinder_vast_port }}"},{"line_number":239,"context_line":"san_login \u003d {{ cinder_vast_username }}"},{"line_number":240,"context_line":"san_password \u003d {{ cinder_vast_password }}"},{"line_number":241,"context_line":"{% endif %}"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"[privsep_entrypoint]"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"af495dbe_cc855e4a","line":240,"range":{"start_line":234,"start_character":0,"end_line":240,"end_character":41},"updated":"2026-06-18 11:43:24.000000000","message":"No mention about these in the docs, no default values for these, no dedicated section for VAST driver, how are people supposed to use it?","commit_id":"910830b085ce795e68ab3c3c5aedc3db4181b556"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"1d960513d1e3a5c171ee29982fd78ded677a7027","unresolved":false,"context_lines":[{"line_number":231,"context_line":"{% if enable_cinder_backend_vast | bool %}"},{"line_number":232,"context_line":"[{{ cinder_backend_vast_name }}]"},{"line_number":233,"context_line":"volume_driver \u003d cinder.volume.drivers.vastdata.driver.VASTVolumeDriver"},{"line_number":234,"context_line":"volume_backend_name \u003d {{ cinder_backend_vast_name }}"},{"line_number":235,"context_line":"vast_vippool_name \u003d {{ cinder_vast_vippool_name }}"},{"line_number":236,"context_line":"vast_subsystem \u003d {{ cinder_vast_subsystem }}"},{"line_number":237,"context_line":"san_ip \u003d {{ cinder_vast_ip }}"},{"line_number":238,"context_line":"san_api_port \u003d {{ cinder_vast_port }}"},{"line_number":239,"context_line":"san_login \u003d {{ cinder_vast_username }}"},{"line_number":240,"context_line":"san_password \u003d {{ cinder_vast_password }}"},{"line_number":241,"context_line":"{% endif %}"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"[privsep_entrypoint]"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fe8a202_d92e3efc","line":240,"range":{"start_line":234,"start_character":0,"end_line":240,"end_character":41},"in_reply_to":"af495dbe_cc855e4a","updated":"2026-06-18 13:54:31.000000000","message":"Done","commit_id":"910830b085ce795e68ab3c3c5aedc3db4181b556"}],"doc/source/reference/storage/cinder-guide.rst":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e6c1c071c1e7bbac55ba2a81ddbd734a0c1dfbdf","unresolved":true,"context_lines":[{"line_number":200,"context_line":"The following parameters must also be set in ``globals.yml``:"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"* ``cinder_vast_ip`` - management IP address of the VAST storage system"},{"line_number":203,"context_line":"* ``cinder_vast_password`` - management API password"},{"line_number":204,"context_line":"* ``cinder_vast_vippool_name`` - name of the Virtual IP pool configured for NVMe/TCP connections"},{"line_number":205,"context_line":"* ``cinder_vast_subsystem`` - NVMe subsystem identifier"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"cab275da_e95d10fa","line":203,"updated":"2026-06-18 13:57:16.000000000","message":"Are we sort of saying people they should put password cleartext in globals.yml?","commit_id":"4d5683d2d3545681ace476195703fae7b70d7642"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"5ffb3f0e954b45be0fba93a8643a76061a919e0e","unresolved":false,"context_lines":[{"line_number":200,"context_line":"The following parameters must also be set in ``globals.yml``:"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"* ``cinder_vast_ip`` - management IP address of the VAST storage system"},{"line_number":203,"context_line":"* ``cinder_vast_password`` - management API password"},{"line_number":204,"context_line":"* ``cinder_vast_vippool_name`` - name of the Virtual IP pool configured for NVMe/TCP connections"},{"line_number":205,"context_line":"* ``cinder_vast_subsystem`` - NVMe subsystem identifier"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"90cc017c_87a04440","line":203,"in_reply_to":"cab275da_e95d10fa","updated":"2026-06-18 14:14:47.000000000","message":"Fair point. I was anticipating someone one would reference a secret. For clarity I\u0027ve suggested putting it directly in passwords.yml.","commit_id":"4d5683d2d3545681ace476195703fae7b70d7642"}]}