)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8054be289e220ebf912f09e4a3475b111d98dd5a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Grzegorz Koper \u003cgrzegorzk@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-09-05 13:06:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds Valkey"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change replaces Redis with Valkey, which is non-existent"},{"line_number":10,"context_line":"on Rocky Linux 10 / CentOS Stream 10 due to licensing issues."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"564be3e5_a40fa500","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":4},"updated":"2025-09-05 13:10:42.000000000","message":"Add","commit_id":"3a7d66352b7ad8f57e915e0fea14fb8320872f0c"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"715ae37546c948e18b49952a437b5db7cd204a1b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Grzegorz Koper \u003cgrzegorzk@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-09-05 13:06:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds Valkey"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change replaces Redis with Valkey, which is non-existent"},{"line_number":10,"context_line":"on Rocky Linux 10 / CentOS Stream 10 due to licensing issues."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"64ad4bea_e9a98ba7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":4},"in_reply_to":"564be3e5_a40fa500","updated":"2025-09-05 14:46:37.000000000","message":"Still a WIP :D\nLost it between patchsets:\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/959539/3//COMMIT_MSG","commit_id":"3a7d66352b7ad8f57e915e0fea14fb8320872f0c"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"49601e3755681109e2dd0cd0a1d6171a49020f2f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Grzegorz Koper \u003cgrzegorzk@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-10-27 13:07:43 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Valkey"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change replaces Redis with Valkey, which is non-existent"},{"line_number":10,"context_line":"on Rocky Linux 10 / CentOS Stream 10 due to licensing issues."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"a0ae6b49_5c9487ba","line":7,"updated":"2025-10-28 12:53:21.000000000","message":"NIT: let\u0027s change the name to sth like: Replace Redis with Valkey","commit_id":"8378d128419600b227e59c4644f116cd0f1ee7d0"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"b5255e95e3c217a52fdada0335b1c374ac381023","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Grzegorz Koper \u003cgrzegorzk@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-10-27 13:07:43 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Valkey"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change replaces Redis with Valkey, which is non-existent"},{"line_number":10,"context_line":"on Rocky Linux 10 / CentOS Stream 10 due to licensing issues."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":34,"id":"c4f33015_dba79b4a","line":7,"in_reply_to":"a0ae6b49_5c9487ba","updated":"2025-10-29 15:07:18.000000000","message":"Done","commit_id":"8378d128419600b227e59c4644f116cd0f1ee7d0"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"baf2b5bf1ed15880e0e17adadaf20599c77cb1a3","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-10-29 15:06:56 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace Redis with Valkey"},{"line_number":8,"context_line":" "},{"line_number":9,"context_line":"This change replaces Redis with Valkey, which is non-existent"},{"line_number":10,"context_line":"on Rocky Linux 10 / CentOS Stream 10 due to licensing issues."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":41,"id":"7bc9bb12_9efcf351","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":1},"updated":"2025-10-29 15:11:00.000000000","message":"Stray space breaks change title","commit_id":"4e28f38bd0c8e573ef27448286b34d41f54c97c5"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"a8d616d00f73757f3890b9d2ee890b21b5a202cc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-10-29 15:06:56 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace Redis with Valkey"},{"line_number":8,"context_line":" "},{"line_number":9,"context_line":"This change replaces Redis with Valkey, which is non-existent"},{"line_number":10,"context_line":"on Rocky Linux 10 / CentOS Stream 10 due to licensing issues."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":41,"id":"3dedc597_3763f922","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":1},"in_reply_to":"7bc9bb12_9efcf351","updated":"2025-10-29 15:15:24.000000000","message":"Done","commit_id":"4e28f38bd0c8e573ef27448286b34d41f54c97c5"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"491915688498a599b018f4b695a58013ba49b152","unresolved":true,"context_lines":[{"line_number":10,"context_line":"on Rocky Linux 10 / CentOS Stream 10 due to licensing issues."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifcc6ec6e943c20867d969b0bdb0e4cbac53eea1e"},{"line_number":13,"context_line":"Depends-On: I02f3adf9825636e2b81c50543d6f95ea986019b6"},{"line_number":14,"context_line":"Signed-off-by: Grzegorz Koper \u003cgrzegorzk@stackhpc.com\u003e"},{"line_number":15,"context_line":"Signed-off-by: Bartosz Bezak \u003cbartosz@stackhpc.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":54,"id":"696c7bc3_84163745","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":53},"updated":"2025-11-03 16:03:44.000000000","message":"This should be a URL, not a change id","commit_id":"ba8a8f719b596744272ee55daae28e89b6d3868c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b5d634383a6a7196ffd7d6cfc78d6c9a529c5f23","unresolved":false,"context_lines":[{"line_number":10,"context_line":"on Rocky Linux 10 / CentOS Stream 10 due to licensing issues."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ifcc6ec6e943c20867d969b0bdb0e4cbac53eea1e"},{"line_number":13,"context_line":"Depends-On: I02f3adf9825636e2b81c50543d6f95ea986019b6"},{"line_number":14,"context_line":"Signed-off-by: Grzegorz Koper \u003cgrzegorzk@stackhpc.com\u003e"},{"line_number":15,"context_line":"Signed-off-by: Bartosz Bezak \u003cbartosz@stackhpc.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":54,"id":"ec487976_ddad01cf","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":53},"in_reply_to":"696c7bc3_84163745","updated":"2025-11-04 09:50:23.000000000","message":"Done","commit_id":"ba8a8f719b596744272ee55daae28e89b6d3868c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"8054be289e220ebf912f09e4a3475b111d98dd5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"216a9d22_7fd7668a","updated":"2025-09-05 13:10:42.000000000","message":"Code change looks good. Do we have enough test coverage to be confident it works?","commit_id":"3a7d66352b7ad8f57e915e0fea14fb8320872f0c"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"f24ed1845300e7be0a5a7687554347c36e13299f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8d2dd10d_d52675df","updated":"2025-09-08 14:28:34.000000000","message":"recheck - depends on changed","commit_id":"202419b9bffa167684eb09c2352fd423679a1b87"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a478a4e4851545310867ad2b203a7f1473ce87fa","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7892c624_ba22fe85","updated":"2025-10-06 13:44:13.000000000","message":"I think you still need a precheck that fails if enable_redis is set to true, the same for all additional variables like cinder_coordination_backend set to \"redis\" and so on","commit_id":"dca29fd18be09b71b65d688c1e84eb1f4f79acf2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b5d634383a6a7196ffd7d6cfc78d6c9a529c5f23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b45cf7c8_286d35ce","in_reply_to":"7892c624_ba22fe85","updated":"2025-11-04 09:50:23.000000000","message":"Done","commit_id":"dca29fd18be09b71b65d688c1e84eb1f4f79acf2"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"10facd89c06d9951c0e5e5424e82c0aa658fdea4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"12e76ce8_f1b8df79","updated":"2025-10-27 11:42:46.000000000","message":"recheck - https://review.opendev.org/c/openstack/kolla/+/964867/3 merged","commit_id":"e811e72f78695996db331a6970b486a1d9035b0c"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"49601e3755681109e2dd0cd0a1d6171a49020f2f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":34,"id":"0d09afd5_10a203c9","updated":"2025-10-28 12:53:21.000000000","message":"NIT: please also alter docs and add reno:\n\n\n./doc/source/admin/password-rotation.rst:61:* ``redis_master_password``\n./doc/source/reference/networking/designate-guide.rst:54:   enable a supported coordination backend, currently only ``redis``\n./doc/source/reference/networking/designate-guide.rst:56:   ``designate_coordination_backend`` variable. It defaults to ``redis``\n./doc/source/reference/networking/designate-guide.rst:57:   when ``redis`` is enabled (``enable_redis`` is set to ``yes``).\n\n./README.rst:97:- `Redis \u003chttps://redis.io/\u003e`__ an in-memory data structure store.","commit_id":"8378d128419600b227e59c4644f116cd0f1ee7d0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a6263f67501e15b215a51601f6bb82097c9dceab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"afa37ad4_44da36cd","in_reply_to":"0d09afd5_10a203c9","updated":"2025-10-30 12:41:01.000000000","message":"Done","commit_id":"8378d128419600b227e59c4644f116cd0f1ee7d0"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7a10ebcf0d5f75d48d29fe315712eb79cc875590","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"ac65aaec_d96b3360","updated":"2025-10-29 11:49:10.000000000","message":"recheck dashboard tests fixed","commit_id":"669eee136411b925f25a7f20e637d589627ccf1d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"66f95d87d1648e943d3460f9bade77bf41241e5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"2d2a5001_2a6119dd","updated":"2025-10-29 15:29:27.000000000","message":"recheck depends on changed","commit_id":"a5606c30ccdcf5cb217dc064f9afb2635a159ede"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"5b221b650b49e32edc23200ab69deb810afd2940","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"d596a5b2_5dfbd00f","updated":"2025-10-29 15:32:52.000000000","message":"recheck depends on changed","commit_id":"a5606c30ccdcf5cb217dc064f9afb2635a159ede"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0b06e920112f200faeba651a259c4dbec45efe51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"d03f66a8_3f93cd97","updated":"2025-10-31 09:34:03.000000000","message":"recheck new images uploaded","commit_id":"c8111326a7eabc8fc6024b8dd836405c2251d19e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"99d75e933a7326c4df9ca380ab9e10f886730270","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":69,"id":"ee51df3a_8dbe14f4","updated":"2025-11-05 15:26:58.000000000","message":"Backport to 2025.1 (adapt upgrade.yml into a separate playbook)","commit_id":"b8bfea1fbe83fc2daf032498ac87c925065968dd"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"7148a84ae2c099309f10f2d5a7f600b6df75d04b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":69,"id":"4688bf13_d871d469","updated":"2025-11-05 14:18:16.000000000","message":"one comment, otherwise LGTM","commit_id":"b8bfea1fbe83fc2daf032498ac87c925065968dd"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7bbe12bb32741f24f5615635773da86756e4cf0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":92,"id":"9216434f_9ee37d81","updated":"2025-11-06 19:49:38.000000000","message":"recheck unrelated failure in ovn job","commit_id":"86c732dfabeb8cc9b116da758b3c55eb5d8a2b43"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"301e2295869a97ac8ed2242da0b0535fcf72eb3b","unresolved":true,"context_lines":[{"line_number":978,"context_line":"####################"},{"line_number":979,"context_line":"# Valkey options"},{"line_number":980,"context_line":"####################"},{"line_number":981,"context_line":"valkey_connection_string: \"valkey://{% for host in groups[\u0027valkey\u0027] %}{% if host \u003d\u003d groups[\u0027valkey\u0027][0] %}default:{{ valkey_master_password }}@{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ valkey_sentinel_port }}?sentinel\u003dkolla{% else %}\u0026sentinel_fallback\u003d{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ valkey_sentinel_port }}{% endif %}{% endfor %}{{ valkey_connection_string_extras }}\""},{"line_number":982,"context_line":"valkey_connection_string_extras: \"\u0026db\u003d0\u0026socket_timeout\u003d60\u0026retry_on_timeout\u003dyes\""},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"113c9649_5aef77b7","line":981,"updated":"2025-09-09 10:26:47.000000000","message":"```suggestion\nvalkey_connection_string: \"redis://{% for host in groups[\u0027valkey\u0027] %}{% if host \u003d\u003d groups[\u0027valkey\u0027][0] %}default:{{ valkey_master_password }}@{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ valkey_sentinel_port }}?sentinel\u003dkolla{% else %}\u0026sentinel_fallback\u003d{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ valkey_sentinel_port }}{% endif %}{% endfor %}{{ valkey_connection_string_extras }}\"\n```","commit_id":"631a08b1bbd9529a2b2bfcd66fa4807e7f5e3ac8"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"69710274347b13a1d8036fc9ef4266b60ca19a05","unresolved":false,"context_lines":[{"line_number":978,"context_line":"####################"},{"line_number":979,"context_line":"# Valkey options"},{"line_number":980,"context_line":"####################"},{"line_number":981,"context_line":"valkey_connection_string: \"valkey://{% for host in groups[\u0027valkey\u0027] %}{% if host \u003d\u003d groups[\u0027valkey\u0027][0] %}default:{{ valkey_master_password }}@{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ valkey_sentinel_port }}?sentinel\u003dkolla{% else %}\u0026sentinel_fallback\u003d{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ valkey_sentinel_port }}{% endif %}{% endfor %}{{ valkey_connection_string_extras }}\""},{"line_number":982,"context_line":"valkey_connection_string_extras: \"\u0026db\u003d0\u0026socket_timeout\u003d60\u0026retry_on_timeout\u003dyes\""},{"line_number":983,"context_line":""},{"line_number":984,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"09f8e26a_0b191d64","line":981,"in_reply_to":"113c9649_5aef77b7","updated":"2025-09-09 10:49:21.000000000","message":"Thanks @bartosz@stackhpc.com, good catch!","commit_id":"631a08b1bbd9529a2b2bfcd66fa4807e7f5e3ac8"}],"ansible/group_vars/all/common.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8b827d32cbdcb2620d901c0143b42d3455cfe529","unresolved":true,"context_lines":[{"line_number":338,"context_line":"# valid values: [\"elasticsearch\", \"redis\"]"},{"line_number":339,"context_line":"osprofiler_backend: \"elasticsearch\""},{"line_number":340,"context_line":"opensearch_connection_string: \"elasticsearch://{{ opensearch_address | put_address_in_context(\u0027url\u0027) }}:{{ opensearch_port }}\""},{"line_number":341,"context_line":"osprofiler_backend_connection_string: \"{{ valkey_connection_string if osprofiler_backend \u003d\u003d \u0027valkey\u0027 else opensearch_connection_string }}\""},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"######################"},{"line_number":344,"context_line":"# Backend TLS options"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"2c71b896_3cb80d5c","line":341,"updated":"2025-10-16 13:15:32.000000000","message":"Are you sure there\u0027s a valkey osprofiler backend?","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c278d603544d8c0d4bfe49d7ecc25fa24df0ec67","unresolved":false,"context_lines":[{"line_number":338,"context_line":"# valid values: [\"elasticsearch\", \"redis\"]"},{"line_number":339,"context_line":"osprofiler_backend: \"elasticsearch\""},{"line_number":340,"context_line":"opensearch_connection_string: \"elasticsearch://{{ opensearch_address | put_address_in_context(\u0027url\u0027) }}:{{ opensearch_port }}\""},{"line_number":341,"context_line":"osprofiler_backend_connection_string: \"{{ valkey_connection_string if osprofiler_backend \u003d\u003d \u0027valkey\u0027 else opensearch_connection_string }}\""},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"######################"},{"line_number":344,"context_line":"# Backend TLS options"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"fbb3097a_e77a562b","line":341,"in_reply_to":"2c71b896_3cb80d5c","updated":"2025-10-17 08:20:15.000000000","message":"Done","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"}],"ansible/group_vars/all/valkey.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b3be2718dfae3ff19f98aac5d311da52d403901c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"enable_valkey: \"no\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"valkey_connection_string: \"redis://{% for host in groups[\u0027valkey\u0027] %}{% if host \u003d\u003d groups[\u0027valkey\u0027][0] %}default:{{ valkey_master_password }}@{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ valkey_sentinel_port }}?sentinel\u003dkolla{% else %}\u0026sentinel_fallback\u003d{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ valkey_sentinel_port }}{% endif %}{% endfor %}{{ valkey_connection_string_extras }}\""},{"line_number":5,"context_line":"valkey_connection_string_extras: \"\u0026db\u003d0\u0026socket_timeout\u003d60\u0026retry_on_timeout\u003dyes\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"valkey_as_primary: false"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"a3fae480_e869eb93","line":4,"updated":"2025-10-08 14:42:48.000000000","message":"multiline please","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"02b02207dc943fd89c6d0c77df2c2f64d8305c4e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"enable_valkey: \"no\""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"valkey_connection_string: \"redis://{% for host in groups[\u0027valkey\u0027] %}{% if host \u003d\u003d groups[\u0027valkey\u0027][0] %}default:{{ valkey_master_password }}@{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ valkey_sentinel_port }}?sentinel\u003dkolla{% else %}\u0026sentinel_fallback\u003d{{ \u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027) }}:{{ valkey_sentinel_port }}{% endif %}{% endfor %}{{ valkey_connection_string_extras }}\""},{"line_number":5,"context_line":"valkey_connection_string_extras: \"\u0026db\u003d0\u0026socket_timeout\u003d60\u0026retry_on_timeout\u003dyes\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"valkey_as_primary: false"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3cd591cf_63462612","line":4,"in_reply_to":"a3fae480_e869eb93","updated":"2025-10-17 10:32:25.000000000","message":"Done","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b3be2718dfae3ff19f98aac5d311da52d403901c","unresolved":true,"context_lines":[{"line_number":9,"context_line":"valkey_port: \"6379\""},{"line_number":10,"context_line":"valkey_sentinel_port: \"26379\""},{"line_number":11,"context_line":"valkey_sentinel_monitor_name: kolla"},{"line_number":12,"context_line":"valkey_sentinel_quorum: 2 # We should land on some sane defaults here"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"d68ab3fa_3870b0c1","line":12,"updated":"2025-10-08 14:42:48.000000000","message":"We usually put comments a line before, with # NOTE(nick): something","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"02b02207dc943fd89c6d0c77df2c2f64d8305c4e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"valkey_port: \"6379\""},{"line_number":10,"context_line":"valkey_sentinel_port: \"26379\""},{"line_number":11,"context_line":"valkey_sentinel_monitor_name: kolla"},{"line_number":12,"context_line":"valkey_sentinel_quorum: 2 # We should land on some sane defaults here"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ca20eef1_1bd8e6b2","line":12,"in_reply_to":"d68ab3fa_3870b0c1","updated":"2025-10-17 10:32:25.000000000","message":"Done","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"}],"ansible/roles/gnocchi/templates/gnocchi.conf.j2":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"301e2295869a97ac8ed2242da0b0535fcf72eb3b","unresolved":true,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"[incoming]"},{"line_number":69,"context_line":"{% if gnocchi_incoming_storage \u003d\u003d \u0027valkey\u0027 %}"},{"line_number":70,"context_line":"driver \u003d valkey"},{"line_number":71,"context_line":"valkey_url \u003d {{ valkey_connection_string }}"},{"line_number":72,"context_line":"{% endif %}"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"d7bbb87c_8f0a1c8d","line":70,"updated":"2025-09-09 10:26:47.000000000","message":"```suggestion\ndriver \u003d redis\n```","commit_id":"631a08b1bbd9529a2b2bfcd66fa4807e7f5e3ac8"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"69710274347b13a1d8036fc9ef4266b60ca19a05","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"[incoming]"},{"line_number":69,"context_line":"{% if gnocchi_incoming_storage \u003d\u003d \u0027valkey\u0027 %}"},{"line_number":70,"context_line":"driver \u003d valkey"},{"line_number":71,"context_line":"valkey_url \u003d {{ valkey_connection_string }}"},{"line_number":72,"context_line":"{% endif %}"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"6f4ce4a0_caeacfb4","line":70,"in_reply_to":"d7bbb87c_8f0a1c8d","updated":"2025-09-09 10:49:21.000000000","message":"Done","commit_id":"631a08b1bbd9529a2b2bfcd66fa4807e7f5e3ac8"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"301e2295869a97ac8ed2242da0b0535fcf72eb3b","unresolved":true,"context_lines":[{"line_number":68,"context_line":"[incoming]"},{"line_number":69,"context_line":"{% if gnocchi_incoming_storage \u003d\u003d \u0027valkey\u0027 %}"},{"line_number":70,"context_line":"driver \u003d valkey"},{"line_number":71,"context_line":"valkey_url \u003d {{ valkey_connection_string }}"},{"line_number":72,"context_line":"{% endif %}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"[storage]"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"bb06ce2b_a1f324d8","line":71,"updated":"2025-09-09 10:26:47.000000000","message":"```suggestion\nredis_url \u003d {{ valkey_connection_string }}\n```","commit_id":"631a08b1bbd9529a2b2bfcd66fa4807e7f5e3ac8"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"69710274347b13a1d8036fc9ef4266b60ca19a05","unresolved":false,"context_lines":[{"line_number":68,"context_line":"[incoming]"},{"line_number":69,"context_line":"{% if gnocchi_incoming_storage \u003d\u003d \u0027valkey\u0027 %}"},{"line_number":70,"context_line":"driver \u003d valkey"},{"line_number":71,"context_line":"valkey_url \u003d {{ valkey_connection_string }}"},{"line_number":72,"context_line":"{% endif %}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"[storage]"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"026e9a4e_700eb299","line":71,"in_reply_to":"bb06ce2b_a1f324d8","updated":"2025-09-09 10:49:21.000000000","message":"Done","commit_id":"631a08b1bbd9529a2b2bfcd66fa4807e7f5e3ac8"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b3be2718dfae3ff19f98aac5d311da52d403901c","unresolved":true,"context_lines":[{"line_number":66,"context_line":"{% endif %}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"[incoming]"},{"line_number":69,"context_line":"{% if gnocchi_incoming_storage \u003d\u003d \u0027valkey\u0027 %}"},{"line_number":70,"context_line":"driver \u003d redis"},{"line_number":71,"context_line":"redis_url \u003d {{ valkey_connection_string }}"},{"line_number":72,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"2e62866b_80ae0cc0","line":69,"updated":"2025-10-08 14:42:48.000000000","message":"Do we run redis/valkey in the gnocchi job?","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c278d603544d8c0d4bfe49d7ecc25fa24df0ec67","unresolved":false,"context_lines":[{"line_number":66,"context_line":"{% endif %}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"[incoming]"},{"line_number":69,"context_line":"{% if gnocchi_incoming_storage \u003d\u003d \u0027valkey\u0027 %}"},{"line_number":70,"context_line":"driver \u003d redis"},{"line_number":71,"context_line":"redis_url \u003d {{ valkey_connection_string }}"},{"line_number":72,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"ce1b6aba_f6a32670","line":69,"in_reply_to":"2e62866b_80ae0cc0","updated":"2025-10-17 08:20:15.000000000","message":"We do now","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"}],"ansible/roles/masakari/templates/masakari.conf.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b3be2718dfae3ff19f98aac5d311da52d403901c","unresolved":true,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{% if service_name \u003d\u003d \u0027masakari-api\u0027 %}"},{"line_number":86,"context_line":"[coordination]"},{"line_number":87,"context_line":"{% if masakari_coordination_backend \u003d\u003d \u0027valkey\u0027 %}"},{"line_number":88,"context_line":"backend_url \u003d {{ valkey_connection_string }}"},{"line_number":89,"context_line":"{% elif masakari_coordination_backend \u003d\u003d \u0027etcd\u0027 %}"},{"line_number":90,"context_line":"# NOTE(jan.gutter): etcd v3.4 removed the default `v3alpha` api_version. Until"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"519bf765_ec01c24a","line":87,"updated":"2025-10-08 14:42:48.000000000","message":"Do we run redis/valkey in the masakari job?","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c278d603544d8c0d4bfe49d7ecc25fa24df0ec67","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{% if service_name \u003d\u003d \u0027masakari-api\u0027 %}"},{"line_number":86,"context_line":"[coordination]"},{"line_number":87,"context_line":"{% if masakari_coordination_backend \u003d\u003d \u0027valkey\u0027 %}"},{"line_number":88,"context_line":"backend_url \u003d {{ valkey_connection_string }}"},{"line_number":89,"context_line":"{% elif masakari_coordination_backend \u003d\u003d \u0027etcd\u0027 %}"},{"line_number":90,"context_line":"# NOTE(jan.gutter): etcd v3.4 removed the default `v3alpha` api_version. Until"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"bc8d6172_e4e19786","line":87,"in_reply_to":"519bf765_ec01c24a","updated":"2025-10-17 08:20:15.000000000","message":"We do now.","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"}],"ansible/roles/mistral/templates/mistral.conf.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b3be2718dfae3ff19f98aac5d311da52d403901c","unresolved":true,"context_lines":[{"line_number":100,"context_line":"{% endif %}"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"[coordination]"},{"line_number":103,"context_line":"backend_url \u003d {{ valkey_connection_string }}"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"[oslo_concurrency]"},{"line_number":106,"context_line":"lock_path \u003d /var/lib/mistral/tmp"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"912e9683_3c010790","line":103,"updated":"2025-10-08 14:42:48.000000000","message":"Does mistral have a precheck that it needs redis/valkey?","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c278d603544d8c0d4bfe49d7ecc25fa24df0ec67","unresolved":true,"context_lines":[{"line_number":100,"context_line":"{% endif %}"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"[coordination]"},{"line_number":103,"context_line":"backend_url \u003d {{ valkey_connection_string }}"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"[oslo_concurrency]"},{"line_number":106,"context_line":"lock_path \u003d /var/lib/mistral/tmp"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"9ed5ca97_d9027d69","line":103,"in_reply_to":"912e9683_3c010790","updated":"2025-10-17 08:20:15.000000000","message":"It does not, only Octavia and Cinder were lucky enough to get the precheck with Redis\nDo we want all services using Valkey to have such a precheck ?","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"56b7d44c0febe8e14e7d9b0f2bad9223efd2ccc5","unresolved":false,"context_lines":[{"line_number":100,"context_line":"{% endif %}"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"[coordination]"},{"line_number":103,"context_line":"backend_url \u003d {{ valkey_connection_string }}"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"[oslo_concurrency]"},{"line_number":106,"context_line":"lock_path \u003d /var/lib/mistral/tmp"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"2ea4282b_6be53731","line":103,"in_reply_to":"9ed5ca97_d9027d69","updated":"2025-10-29 11:50:00.000000000","message":"Surely not in this patch, but makes sense.","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"}],"ansible/roles/octavia/tasks/precheck.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b3be2718dfae3ff19f98aac5d311da52d403901c","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    - octavia_network_type \u003d\u003d \"tenant\""},{"line_number":66,"context_line":"    - neutron_plugin_agent !\u003d \u0027openvswitch\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"- name: Checking whether Valkey is enabled for octavia jobboard"},{"line_number":69,"context_line":"  assert:"},{"line_number":70,"context_line":"    that: enable_valkey | bool"},{"line_number":71,"context_line":"    fail_msg: \"Valkey must be enabled when using octavia jobboard\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"12e7d13d_55e5cd7d","line":68,"range":{"start_line":68,"start_character":47,"end_line":68,"end_character":54},"updated":"2025-10-08 14:42:48.000000000","message":"```suggestion\n- name: Checking whether Valkey is enabled for Octavia Jobboard\n```","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c278d603544d8c0d4bfe49d7ecc25fa24df0ec67","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    - octavia_network_type \u003d\u003d \"tenant\""},{"line_number":66,"context_line":"    - neutron_plugin_agent !\u003d \u0027openvswitch\u0027"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"- name: Checking whether Valkey is enabled for octavia jobboard"},{"line_number":69,"context_line":"  assert:"},{"line_number":70,"context_line":"    that: enable_valkey | bool"},{"line_number":71,"context_line":"    fail_msg: \"Valkey must be enabled when using octavia jobboard\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"f280a491_3735f00f","line":68,"range":{"start_line":68,"start_character":47,"end_line":68,"end_character":54},"in_reply_to":"12e7d13d_55e5cd7d","updated":"2025-10-17 08:20:15.000000000","message":"Done","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"}],"ansible/roles/prechecks/tasks/service_checks.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"7148a84ae2c099309f10f2d5a7f600b6df75d04b","unresolved":true,"context_lines":[{"line_number":69,"context_line":"  assert:"},{"line_number":70,"context_line":"    that:"},{"line_number":71,"context_line":"      - not (enable_redis | default(false)) | bool"},{"line_number":72,"context_line":"    msg: \"Redis support has been replaced with Valkey, please set enable_redis to no and enable_valkey to yes\""}],"source_content_type":"text/x-yaml","patch_set":69,"id":"a3689f1d_5c036127","line":72,"range":{"start_line":72,"start_character":66,"end_line":72,"end_character":84},"updated":"2025-11-05 14:18:16.000000000","message":"remove enable_redis and consider to use enable_valkey ?","commit_id":"b8bfea1fbe83fc2daf032498ac87c925065968dd"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"308f7b7d3b43e31239efb40e456b7630eacf285f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  assert:"},{"line_number":70,"context_line":"    that:"},{"line_number":71,"context_line":"      - not (enable_redis | default(false)) | bool"},{"line_number":72,"context_line":"    msg: \"Redis support has been replaced with Valkey, please set enable_redis to no and enable_valkey to yes\""}],"source_content_type":"text/x-yaml","patch_set":69,"id":"99e29f3c_41510830","line":72,"range":{"start_line":72,"start_character":66,"end_line":72,"end_character":84},"in_reply_to":"a3689f1d_5c036127","updated":"2025-11-05 15:58:53.000000000","message":"Acknowledged","commit_id":"b8bfea1fbe83fc2daf032498ac87c925065968dd"}],"ansible/roles/telegraf/templates/telegraf.conf.j2":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"301e2295869a97ac8ed2242da0b0535fcf72eb3b","unresolved":true,"context_lines":[{"line_number":68,"context_line":"  password \u003d \"{{ rabbitmq_password }}\""},{"line_number":69,"context_line":"{% endif %}"},{"line_number":70,"context_line":"{% if inventory_hostname in groups[\u0027valkey\u0027] and enable_valkey | bool %}"},{"line_number":71,"context_line":"[[inputs.valkey]]"},{"line_number":72,"context_line":"  servers \u003d [\"tcp://:{{ valkey_master_password }}@{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ valkey_port }}\"]"},{"line_number":73,"context_line":"{% endif %}"},{"line_number":74,"context_line":"{% if inventory_hostname in groups[\u0027mariadb\u0027] and (enable_mariadb or enable_external_mariadb_load_balancer) | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"b9cee024_c692f1be","line":71,"updated":"2025-09-09 10:26:47.000000000","message":"```suggestion\n[[inputs.redis]]\n```","commit_id":"631a08b1bbd9529a2b2bfcd66fa4807e7f5e3ac8"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"69710274347b13a1d8036fc9ef4266b60ca19a05","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  password \u003d \"{{ rabbitmq_password }}\""},{"line_number":69,"context_line":"{% endif %}"},{"line_number":70,"context_line":"{% if inventory_hostname in groups[\u0027valkey\u0027] and enable_valkey | bool %}"},{"line_number":71,"context_line":"[[inputs.valkey]]"},{"line_number":72,"context_line":"  servers \u003d [\"tcp://:{{ valkey_master_password }}@{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ valkey_port }}\"]"},{"line_number":73,"context_line":"{% endif %}"},{"line_number":74,"context_line":"{% if inventory_hostname in groups[\u0027mariadb\u0027] and (enable_mariadb or enable_external_mariadb_load_balancer) | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"3c8ebcf0_e36fe012","line":71,"in_reply_to":"b9cee024_c692f1be","updated":"2025-09-09 10:49:21.000000000","message":"Done","commit_id":"631a08b1bbd9529a2b2bfcd66fa4807e7f5e3ac8"}],"ansible/roles/valkey/defaults/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8b827d32cbdcb2620d901c0143b42d3455cfe529","unresolved":true,"context_lines":[{"line_number":37,"context_line":"valkey_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":38,"context_line":"valkey_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":39,"context_line":"valkey_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":40,"context_line":"valkey_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_listen valkey-server {{ valkey_port }}\"]"},{"line_number":41,"context_line":"valkey_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":42,"context_line":"valkey_healthcheck:"},{"line_number":43,"context_line":"  interval: \"{{ valkey_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"2bcdd2af_22275eb6","line":40,"updated":"2025-10-16 13:15:32.000000000","message":"Can\u0027t we use valkey CLI to healtcheck the node?","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"70cb6d261e85c1ad212307d0ac7a9045d20cf874","unresolved":false,"context_lines":[{"line_number":37,"context_line":"valkey_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":38,"context_line":"valkey_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":39,"context_line":"valkey_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":40,"context_line":"valkey_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_listen valkey-server {{ valkey_port }}\"]"},{"line_number":41,"context_line":"valkey_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":42,"context_line":"valkey_healthcheck:"},{"line_number":43,"context_line":"  interval: \"{{ valkey_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"57e9b77f_6e822c27","line":40,"in_reply_to":"2bcdd2af_22275eb6","updated":"2025-11-04 09:54:14.000000000","message":"Done","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"d44362b51c07754cfb667890a046dfc0ba923189","unresolved":false,"context_lines":[{"line_number":37,"context_line":"valkey_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":38,"context_line":"valkey_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":39,"context_line":"valkey_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":40,"context_line":"valkey_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_listen valkey-server {{ valkey_port }}\"]"},{"line_number":41,"context_line":"valkey_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":42,"context_line":"valkey_healthcheck:"},{"line_number":43,"context_line":"  interval: \"{{ valkey_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"09480f76_74c0651a","line":40,"in_reply_to":"2bcdd2af_22275eb6","updated":"2026-02-11 16:13:30.000000000","message":"Trying","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8b827d32cbdcb2620d901c0143b42d3455cfe529","unresolved":true,"context_lines":[{"line_number":74,"context_line":"valkey_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":75,"context_line":"valkey_sentinel_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"valkey_conf_path: \"/etc/valkey/valkey.conf\""},{"line_number":78,"context_line":"valkey_generated_conf_path: \"/etc/valkey/valkey-regenerated-by-config-rewrite.conf\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"aef472e2_f3b63104","line":77,"updated":"2025-10-16 13:15:32.000000000","message":"Why do we need it here? Does it need to be configurable?","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c278d603544d8c0d4bfe49d7ecc25fa24df0ec67","unresolved":false,"context_lines":[{"line_number":74,"context_line":"valkey_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":75,"context_line":"valkey_sentinel_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"valkey_conf_path: \"/etc/valkey/valkey.conf\""},{"line_number":78,"context_line":"valkey_generated_conf_path: \"/etc/valkey/valkey-regenerated-by-config-rewrite.conf\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"a106e730_ca600002","line":77,"in_reply_to":"aef472e2_f3b63104","updated":"2025-10-17 08:20:15.000000000","message":"I guess we do since,\nhttps://github.com/openstack/kolla-ansible/commit/257ef9fae82dda82d3ef477919c14aa3a8915971","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8b827d32cbdcb2620d901c0143b42d3455cfe529","unresolved":true,"context_lines":[{"line_number":75,"context_line":"valkey_sentinel_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"valkey_conf_path: \"/etc/valkey/valkey.conf\""},{"line_number":78,"context_line":"valkey_generated_conf_path: \"/etc/valkey/valkey-regenerated-by-config-rewrite.conf\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"32e4ca66_625d41ac","line":78,"updated":"2025-10-16 13:15:32.000000000","message":"ditto","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c278d603544d8c0d4bfe49d7ecc25fa24df0ec67","unresolved":false,"context_lines":[{"line_number":75,"context_line":"valkey_sentinel_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"valkey_conf_path: \"/etc/valkey/valkey.conf\""},{"line_number":78,"context_line":"valkey_generated_conf_path: \"/etc/valkey/valkey-regenerated-by-config-rewrite.conf\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3c746cba_e24e1aa9","line":78,"in_reply_to":"32e4ca66_625d41ac","updated":"2025-10-17 08:20:15.000000000","message":"We do since:\nhttps://github.com/openstack/kolla-ansible/commit/257ef9fae82dda82d3ef477919c14aa3a8915971","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"}],"ansible/roles/valkey/tasks/check.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b3be2718dfae3ff19f98aac5d311da52d403901c","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  become: true"},{"line_number":8,"context_line":"  command: \"{{ kolla_container_engine }} exec valkey valkey-cli -h {{ api_interface_address }} -a {{ valkey_master_password }} ping\""},{"line_number":9,"context_line":"  register: valkey_check"},{"line_number":10,"context_line":"  changed_when: \"valkey_check.stdout !\u003d \u0027PONG\u0027\""},{"line_number":11,"context_line":"  failed_when: \"valkey_check.stdout !\u003d \u0027PONG\u0027\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"2c1cf870_cc7de4fe","line":10,"updated":"2025-10-08 14:42:48.000000000","message":"so is it changed then, or failed?","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c278d603544d8c0d4bfe49d7ecc25fa24df0ec67","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  become: true"},{"line_number":8,"context_line":"  command: \"{{ kolla_container_engine }} exec valkey valkey-cli -h {{ api_interface_address }} -a {{ valkey_master_password }} ping\""},{"line_number":9,"context_line":"  register: valkey_check"},{"line_number":10,"context_line":"  changed_when: \"valkey_check.stdout !\u003d \u0027PONG\u0027\""},{"line_number":11,"context_line":"  failed_when: \"valkey_check.stdout !\u003d \u0027PONG\u0027\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"6cf53ccd_d2c1d46b","line":10,"in_reply_to":"2c1cf870_cc7de4fe","updated":"2025-10-17 08:20:15.000000000","message":"pasta from redis role , fixed","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8b827d32cbdcb2620d901c0143b42d3455cfe529","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Valkey ping pong check"},{"line_number":7,"context_line":"  become: true"},{"line_number":8,"context_line":"  command: \"{{ kolla_container_engine }} exec valkey valkey-cli -h {{ api_interface_address }} -a {{ valkey_master_password }} ping\""},{"line_number":9,"context_line":"  register: valkey_check"},{"line_number":10,"context_line":"  changed_when: \"valkey_check.stdout !\u003d \u0027PONG\u0027\""},{"line_number":11,"context_line":"  failed_when: \"valkey_check.stdout !\u003d \u0027PONG\u0027\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"0692c213_e55a71d6","line":8,"updated":"2025-10-16 13:15:32.000000000","message":"multiline please","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c278d603544d8c0d4bfe49d7ecc25fa24df0ec67","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Valkey ping pong check"},{"line_number":7,"context_line":"  become: true"},{"line_number":8,"context_line":"  command: \"{{ kolla_container_engine }} exec valkey valkey-cli -h {{ api_interface_address }} -a {{ valkey_master_password }} ping\""},{"line_number":9,"context_line":"  register: valkey_check"},{"line_number":10,"context_line":"  changed_when: \"valkey_check.stdout !\u003d \u0027PONG\u0027\""},{"line_number":11,"context_line":"  failed_when: \"valkey_check.stdout !\u003d \u0027PONG\u0027\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"54cfc473_77c2bf3d","line":8,"in_reply_to":"0692c213_e55a71d6","updated":"2025-10-17 08:20:15.000000000","message":"Done","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"}],"ansible/roles/valkey/tasks/precheck.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b3be2718dfae3ff19f98aac5d311da52d403901c","unresolved":true,"context_lines":[{"line_number":15,"context_line":"  check_mode: false"},{"line_number":16,"context_line":"  register: container_facts"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Checking free port for valkey"},{"line_number":19,"context_line":"  vars:"},{"line_number":20,"context_line":"    service: \"{{ valkey_services[\u0027valkey\u0027] }}\""},{"line_number":21,"context_line":"  wait_for:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"b63a26e0_6b133059","line":18,"updated":"2025-10-08 14:42:48.000000000","message":"```suggestion\n- name: Checking free port for Valkey\n```","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c6ad3b1d03e0c93e77bfcaf23d6b2610c50ac66b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  check_mode: false"},{"line_number":16,"context_line":"  register: container_facts"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- name: Checking free port for valkey"},{"line_number":19,"context_line":"  vars:"},{"line_number":20,"context_line":"    service: \"{{ valkey_services[\u0027valkey\u0027] }}\""},{"line_number":21,"context_line":"  wait_for:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"1d6ce8c6_d503ccdc","line":18,"in_reply_to":"b63a26e0_6b133059","updated":"2025-10-15 21:00:17.000000000","message":"Done","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"}],"ansible/roles/valkey/tasks/upgrade.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b3be2718dfae3ff19f98aac5d311da52d403901c","unresolved":true,"context_lines":[{"line_number":21,"context_line":"  become: true"},{"line_number":22,"context_line":"  shell: \u003e-"},{"line_number":23,"context_line":"    {{ kolla_container_engine }} exec valkey bash -c"},{"line_number":24,"context_line":"    \"until valkey-cli -h {{ api_interface_address }} -p {{ valkey_port }} -a {{ valkey_master_password }}"},{"line_number":25,"context_line":"    info replication | grep -q \u0027master_link_status:up\u0027; do sleep 1; done\""},{"line_number":26,"context_line":"  register: replication_check"},{"line_number":27,"context_line":"  until: replication_check.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ed785ef2_a890726e","line":24,"updated":"2025-10-08 14:42:48.000000000","message":"split it into more lines please","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c6ad3b1d03e0c93e77bfcaf23d6b2610c50ac66b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  become: true"},{"line_number":22,"context_line":"  shell: \u003e-"},{"line_number":23,"context_line":"    {{ kolla_container_engine }} exec valkey bash -c"},{"line_number":24,"context_line":"    \"until valkey-cli -h {{ api_interface_address }} -p {{ valkey_port }} -a {{ valkey_master_password }}"},{"line_number":25,"context_line":"    info replication | grep -q \u0027master_link_status:up\u0027; do sleep 1; done\""},{"line_number":26,"context_line":"  register: replication_check"},{"line_number":27,"context_line":"  until: replication_check.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"f8fa3e57_aeae145a","line":24,"in_reply_to":"ed785ef2_a890726e","updated":"2025-10-15 21:00:17.000000000","message":"Done","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b3be2718dfae3ff19f98aac5d311da52d403901c","unresolved":true,"context_lines":[{"line_number":46,"context_line":"  shell: \u003e-"},{"line_number":47,"context_line":"    {{ kolla_container_engine }} exec valkey bash -c"},{"line_number":48,"context_line":"    \u0027until [ \"$(valkey-cli -h {{ api_interface_address }} -p {{ valkey_port }} -a {{ valkey_master_password }}"},{"line_number":49,"context_line":"    info replication | grep role | cut -d \":\" -f2 | tr -d \"\\r\")\" \u003d \"master\" ]; do sleep 1; done\u0027"},{"line_number":50,"context_line":"  register: master_check"},{"line_number":51,"context_line":"  until: master_check.rc \u003d\u003d 0"},{"line_number":52,"context_line":"  retries: 30"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"0c7b9012_817edee5","line":49,"range":{"start_line":49,"start_character":35,"end_line":49,"end_character":75},"updated":"2025-10-08 14:42:48.000000000","message":"that looks a bit brittle","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c6ad3b1d03e0c93e77bfcaf23d6b2610c50ac66b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  shell: \u003e-"},{"line_number":47,"context_line":"    {{ kolla_container_engine }} exec valkey bash -c"},{"line_number":48,"context_line":"    \u0027until [ \"$(valkey-cli -h {{ api_interface_address }} -p {{ valkey_port }} -a {{ valkey_master_password }}"},{"line_number":49,"context_line":"    info replication | grep role | cut -d \":\" -f2 | tr -d \"\\r\")\" \u003d \"master\" ]; do sleep 1; done\u0027"},{"line_number":50,"context_line":"  register: master_check"},{"line_number":51,"context_line":"  until: master_check.rc \u003d\u003d 0"},{"line_number":52,"context_line":"  retries: 30"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"c29d68e7_1340d9df","line":49,"range":{"start_line":49,"start_character":35,"end_line":49,"end_character":75},"in_reply_to":"0c7b9012_817edee5","updated":"2025-10-15 21:00:17.000000000","message":"Done","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b3be2718dfae3ff19f98aac5d311da52d403901c","unresolved":true,"context_lines":[{"line_number":52,"context_line":"  retries: 30"},{"line_number":53,"context_line":"  delay: 2"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- name: Stop all Redis containers"},{"line_number":56,"context_line":"  become: true"},{"line_number":57,"context_line":"  kolla_container:"},{"line_number":58,"context_line":"    name: redis"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"c40eb211_05efb243","line":55,"updated":"2025-10-08 14:42:48.000000000","message":"Remove them, right?","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c6ad3b1d03e0c93e77bfcaf23d6b2610c50ac66b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  retries: 30"},{"line_number":53,"context_line":"  delay: 2"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- name: Stop all Redis containers"},{"line_number":56,"context_line":"  become: true"},{"line_number":57,"context_line":"  kolla_container:"},{"line_number":58,"context_line":"    name: redis"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ff5eb93a_1e189e89","line":55,"in_reply_to":"c40eb211_05efb243","updated":"2025-10-15 21:00:17.000000000","message":"Done","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b3be2718dfae3ff19f98aac5d311da52d403901c","unresolved":true,"context_lines":[{"line_number":59,"context_line":"    action: stop"},{"line_number":60,"context_line":"  when:"},{"line_number":61,"context_line":"    - inventory_hostname in groups[\u0027redis\u0027]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- name: Set Valkey as primary (retemplate)"},{"line_number":65,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"88c793c4_082a8a04","line":62,"updated":"2025-10-08 14:42:48.000000000","message":"Too many newlines","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c6ad3b1d03e0c93e77bfcaf23d6b2610c50ac66b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    action: stop"},{"line_number":60,"context_line":"  when:"},{"line_number":61,"context_line":"    - inventory_hostname in groups[\u0027redis\u0027]"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- name: Set Valkey as primary (retemplate)"},{"line_number":65,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"491d8b13_82a9cd09","line":62,"in_reply_to":"88c793c4_082a8a04","updated":"2025-10-15 21:00:17.000000000","message":"Done","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8b827d32cbdcb2620d901c0143b42d3455cfe529","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Set migration flag if Redis is present"},{"line_number":13,"context_line":"  set_fact:"},{"line_number":14,"context_line":"    valkey_is_migrating_from_redis: \"{{ redis_container_facts.containers[\u0027redis\u0027] is defined }}\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Perform Redis to Valkey migration steps"},{"line_number":17,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"76a66879_dceca8d6","line":14,"updated":"2025-10-16 13:15:32.000000000","message":"Just change that to `valkey_migration` or similar, that long name is not helping anybody","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c278d603544d8c0d4bfe49d7ecc25fa24df0ec67","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Set migration flag if Redis is present"},{"line_number":13,"context_line":"  set_fact:"},{"line_number":14,"context_line":"    valkey_is_migrating_from_redis: \"{{ redis_container_facts.containers[\u0027redis\u0027] is defined }}\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Perform Redis to Valkey migration steps"},{"line_number":17,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"55e386ff_c210375e","line":14,"in_reply_to":"76a66879_dceca8d6","updated":"2025-10-17 08:20:15.000000000","message":"Done","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8b827d32cbdcb2620d901c0143b42d3455cfe529","unresolved":true,"context_lines":[{"line_number":20,"context_line":"      set_fact:"},{"line_number":21,"context_line":"        valkey_port: \"6380\""},{"line_number":22,"context_line":"        valkey_sentinel_port: \"26380\""},{"line_number":23,"context_line":"        valkey_sentinel_monitor_name: kolla-temp"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    - name: Set valkey master host to valkey[0]"},{"line_number":26,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"e78dd65c_6a244cbf","line":23,"updated":"2025-10-16 13:15:32.000000000","message":"add quotes","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c278d603544d8c0d4bfe49d7ecc25fa24df0ec67","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      set_fact:"},{"line_number":21,"context_line":"        valkey_port: \"6380\""},{"line_number":22,"context_line":"        valkey_sentinel_port: \"26380\""},{"line_number":23,"context_line":"        valkey_sentinel_monitor_name: kolla-temp"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    - name: Set valkey master host to valkey[0]"},{"line_number":26,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"e470b075_133fddc3","line":23,"in_reply_to":"e78dd65c_6a244cbf","updated":"2025-10-17 08:20:15.000000000","message":"Done","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8b827d32cbdcb2620d901c0143b42d3455cfe529","unresolved":true,"context_lines":[{"line_number":89,"context_line":"      retries: 30"},{"line_number":90,"context_line":"      delay: 2"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    - name: Stop all Redis containers"},{"line_number":93,"context_line":"      become: true"},{"line_number":94,"context_line":"      kolla_container:"},{"line_number":95,"context_line":"        name: redis"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"71341e96_9a601a8a","line":92,"updated":"2025-10-16 13:15:32.000000000","message":"You need to remove the systemd unit, not just stop the containers","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"322ab03527d44185d7030cfec2a8d5389d179c41","unresolved":false,"context_lines":[{"line_number":89,"context_line":"      retries: 30"},{"line_number":90,"context_line":"      delay: 2"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    - name: Stop all Redis containers"},{"line_number":93,"context_line":"      become: true"},{"line_number":94,"context_line":"      kolla_container:"},{"line_number":95,"context_line":"        name: redis"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"95a0d7ba_2d8c4191","line":92,"in_reply_to":"71341e96_9a601a8a","updated":"2025-10-17 09:47:25.000000000","message":"stop_and_remove_container action removes systemd unit.","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8b827d32cbdcb2620d901c0143b42d3455cfe529","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        action: stop_and_remove_container"},{"line_number":97,"context_line":"      when: inventory_hostname in groups[\u0027redis\u0027]"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    - name: Stop all Sentinel containers"},{"line_number":100,"context_line":"      become: true"},{"line_number":101,"context_line":"      kolla_container:"},{"line_number":102,"context_line":"        name: redis_sentinel"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"87d9e4f5_f13b475a","line":99,"updated":"2025-10-16 13:15:32.000000000","message":"ditto","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"322ab03527d44185d7030cfec2a8d5389d179c41","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        action: stop_and_remove_container"},{"line_number":97,"context_line":"      when: inventory_hostname in groups[\u0027redis\u0027]"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    - name: Stop all Sentinel containers"},{"line_number":100,"context_line":"      become: true"},{"line_number":101,"context_line":"      kolla_container:"},{"line_number":102,"context_line":"        name: redis_sentinel"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"da7d2ff5_9ca8ebb7","line":99,"in_reply_to":"87d9e4f5_f13b475a","updated":"2025-10-17 09:47:25.000000000","message":"Done","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"}],"ansible/roles/valkey/templates/valkey-sentinel.conf.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8b827d32cbdcb2620d901c0143b42d3455cfe529","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{% set valkey_master_address \u003d \u0027api\u0027 | kolla_address(groups[\u0027valkey\u0027][0]) %}"},{"line_number":2,"context_line":"daemonize no"},{"line_number":3,"context_line":"pidfile \"/var/run/valkey/valkey-sentinel.pid\""},{"line_number":4,"context_line":"logfile \"/var/log/kolla/valkey/valkey-sentinel.log\""}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"db2b7e22_ead6d96e","line":1,"updated":"2025-10-16 13:15:32.000000000","message":"It\u0027s not used?","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c278d603544d8c0d4bfe49d7ecc25fa24df0ec67","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set valkey_master_address \u003d \u0027api\u0027 | kolla_address(groups[\u0027valkey\u0027][0]) %}"},{"line_number":2,"context_line":"daemonize no"},{"line_number":3,"context_line":"pidfile \"/var/run/valkey/valkey-sentinel.pid\""},{"line_number":4,"context_line":"logfile \"/var/log/kolla/valkey/valkey-sentinel.log\""}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"706d7f3a_036a5dc3","line":1,"in_reply_to":"db2b7e22_ead6d96e","updated":"2025-10-17 08:20:15.000000000","message":"Done","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"49601e3755681109e2dd0cd0a1d6171a49020f2f","unresolved":true,"context_lines":[{"line_number":4,"context_line":"bind {{ api_interface_address }}"},{"line_number":5,"context_line":"port {{ valkey_sentinel_port }}"},{"line_number":6,"context_line":"sentinel myid {{ inventory_hostname | hash(\u0027sha1\u0027) }}"},{"line_number":7,"context_line":"sentinel monitor {{ valkey_sentinel_monitor_name }} {{ api_interface_address }} {{ valkey_port }} {{ valkey_sentinel_quorum }}"},{"line_number":8,"context_line":"sentinel auth-pass {{ valkey_sentinel_monitor_name }} {{ valkey_master_password }}"},{"line_number":9,"context_line":"sentinel down-after-milliseconds {{ valkey_sentinel_monitor_name }} 5000"},{"line_number":10,"context_line":"sentinel failover-timeout {{ valkey_sentinel_monitor_name }} 60000"}],"source_content_type":"text/x-jinja2","patch_set":34,"id":"ff6a6134_09cc48cb","line":7,"updated":"2025-10-28 12:53:21.000000000","message":"sentinel should monitor master and not itself? previously we had:\n\n./ansible/roles/redis/templates/redis-sentinel.conf.j2:8:sentinel monitor kolla {{ redis_master_address }} {{ redis_port }} 2","commit_id":"8378d128419600b227e59c4644f116cd0f1ee7d0"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"d3f5a0eef70ef99c808766982d13ae85e96a8c84","unresolved":false,"context_lines":[{"line_number":4,"context_line":"bind {{ api_interface_address }}"},{"line_number":5,"context_line":"port {{ valkey_sentinel_port }}"},{"line_number":6,"context_line":"sentinel myid {{ inventory_hostname | hash(\u0027sha1\u0027) }}"},{"line_number":7,"context_line":"sentinel monitor {{ valkey_sentinel_monitor_name }} {{ api_interface_address }} {{ valkey_port }} {{ valkey_sentinel_quorum }}"},{"line_number":8,"context_line":"sentinel auth-pass {{ valkey_sentinel_monitor_name }} {{ valkey_master_password }}"},{"line_number":9,"context_line":"sentinel down-after-milliseconds {{ valkey_sentinel_monitor_name }} 5000"},{"line_number":10,"context_line":"sentinel failover-timeout {{ valkey_sentinel_monitor_name }} 60000"}],"source_content_type":"text/x-jinja2","patch_set":34,"id":"b1902b0b_f15d8d42","line":7,"in_reply_to":"88164da0_40a1d126","updated":"2025-10-28 13:02:58.000000000","message":"But looks like I\u0027ve missed a conditional in between patchsets, using api_interface_address results in misconfigured sentinel nodes.\n\nThanks for pointing that out.","commit_id":"8378d128419600b227e59c4644f116cd0f1ee7d0"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"060e6ea28db4a1790beaa33eabfad0f61c77f40e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"bind {{ api_interface_address }}"},{"line_number":5,"context_line":"port {{ valkey_sentinel_port }}"},{"line_number":6,"context_line":"sentinel myid {{ inventory_hostname | hash(\u0027sha1\u0027) }}"},{"line_number":7,"context_line":"sentinel monitor {{ valkey_sentinel_monitor_name }} {{ api_interface_address }} {{ valkey_port }} {{ valkey_sentinel_quorum }}"},{"line_number":8,"context_line":"sentinel auth-pass {{ valkey_sentinel_monitor_name }} {{ valkey_master_password }}"},{"line_number":9,"context_line":"sentinel down-after-milliseconds {{ valkey_sentinel_monitor_name }} 5000"},{"line_number":10,"context_line":"sentinel failover-timeout {{ valkey_sentinel_monitor_name }} 60000"}],"source_content_type":"text/x-jinja2","patch_set":34,"id":"88164da0_40a1d126","line":7,"in_reply_to":"ff6a6134_09cc48cb","updated":"2025-10-28 12:57:25.000000000","message":"Previously we hardcoded valkey_sentinel_monitor_name as \"kolla\".\nNow we use a variable {{ valkey_sentinel_monitor_name }} and \n{{ api_interface_address }} {{ valkey_port }} instead of redis_master_address for reasons related to migration. ( this variable becomes undefined in migration scenarios)","commit_id":"8378d128419600b227e59c4644f116cd0f1ee7d0"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"f50640ca7c5f0bfe614ee40b3d3f893f1d3cd3fb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{% set valkey_master_address \u003d \u0027api\u0027 | kolla_address(groups[\u0027valkey\u0027][0]) %"},{"line_number":2,"context_line":"daemonize no"},{"line_number":3,"context_line":"pidfile \"/var/run/valkey/valkey-sentinel.pid\""},{"line_number":4,"context_line":"logfile \"/var/log/kolla/valkey/valkey-sentinel.log\""}],"source_content_type":"text/x-jinja2","patch_set":35,"id":"78619c92_f3962077","line":1,"updated":"2025-10-28 13:41:08.000000000","message":"```suggestion\n{% set valkey_master_address \u003d \u0027api\u0027 | kolla_address(groups[\u0027valkey\u0027][0]) %}\n```","commit_id":"6d5aefc630b0ed8c8b80b1473a19f1e62709f946"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"96609c16ac9a0af870f6a29c318e06f781ab4712","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set valkey_master_address \u003d \u0027api\u0027 | kolla_address(groups[\u0027valkey\u0027][0]) %"},{"line_number":2,"context_line":"daemonize no"},{"line_number":3,"context_line":"pidfile \"/var/run/valkey/valkey-sentinel.pid\""},{"line_number":4,"context_line":"logfile \"/var/log/kolla/valkey/valkey-sentinel.log\""}],"source_content_type":"text/x-jinja2","patch_set":35,"id":"7def4fdb_5a8d5def","line":1,"in_reply_to":"78619c92_f3962077","updated":"2025-10-29 11:56:08.000000000","message":"Done","commit_id":"6d5aefc630b0ed8c8b80b1473a19f1e62709f946"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"96609c16ac9a0af870f6a29c318e06f781ab4712","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set valkey_master_address \u003d \u0027api\u0027 | kolla_address(groups[\u0027valkey\u0027][0]) %"},{"line_number":2,"context_line":"daemonize no"},{"line_number":3,"context_line":"pidfile \"/var/run/valkey/valkey-sentinel.pid\""},{"line_number":4,"context_line":"logfile \"/var/log/kolla/valkey/valkey-sentinel.log\""}],"source_content_type":"text/x-jinja2","patch_set":35,"id":"99ccc23c_ad56899d","line":1,"in_reply_to":"78619c92_f3962077","updated":"2025-10-29 11:56:08.000000000","message":"Done","commit_id":"6d5aefc630b0ed8c8b80b1473a19f1e62709f946"}],"ansible/roles/valkey/templates/valkey-sentinel.json.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8b827d32cbdcb2620d901c0143b42d3455cfe529","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"valkey-sentinel {{ valkey_generated_conf_path }}\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/valkey.conf\","}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"3a37f682_6a8eae58","line":2,"updated":"2025-10-16 13:15:32.000000000","message":"Why it can\u0027t be just a hardcoded string or a default config path?","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c278d603544d8c0d4bfe49d7ecc25fa24df0ec67","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"valkey-sentinel {{ valkey_generated_conf_path }}\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/valkey.conf\","}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"1ee80099_49c993a9","line":2,"in_reply_to":"3a37f682_6a8eae58","updated":"2025-10-17 08:20:15.000000000","message":"https://github.com/openstack/kolla-ansible/commit/257ef9fae82dda82d3ef477919c14aa3a8915971","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"}],"ansible/roles/valkey/templates/valkey.conf.j2":[{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"931231ae9f7f09551b5d00cc6c1fb2fcd28fcf31","unresolved":true,"context_lines":[{"line_number":30,"context_line":"auto-aof-rewrite-min-size 64mb"},{"line_number":31,"context_line":"aof-load-truncated yes"},{"line_number":32,"context_line":"lua-time-limit 5000"},{"line_number":33,"context_line":"slowlog-log-slower-than 10000"},{"line_number":34,"context_line":"slowlog-max-len 128"},{"line_number":35,"context_line":"latency-monitor-threshold 0"},{"line_number":36,"context_line":"notify-keyspace-events \"\""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"f39bebb0_7fd21a17","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":23},"updated":"2025-09-05 09:07:57.000000000","message":"2000? - 10s to long. In a production environment, it\u0027s worth setting it lower, e.g., 2000 ms.","commit_id":"c1c157d62596dec649c418fd5fd04d591ea99f2c"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c6e784fcbe60d7241b5569cc46b719af96048d41","unresolved":false,"context_lines":[{"line_number":30,"context_line":"auto-aof-rewrite-min-size 64mb"},{"line_number":31,"context_line":"aof-load-truncated yes"},{"line_number":32,"context_line":"lua-time-limit 5000"},{"line_number":33,"context_line":"slowlog-log-slower-than 10000"},{"line_number":34,"context_line":"slowlog-max-len 128"},{"line_number":35,"context_line":"latency-monitor-threshold 0"},{"line_number":36,"context_line":"notify-keyspace-events \"\""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"bb13dbf9_ffc9b879","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":23},"in_reply_to":"f39bebb0_7fd21a17","updated":"2025-09-08 14:34:25.000000000","message":"Acknowledged","commit_id":"c1c157d62596dec649c418fd5fd04d591ea99f2c"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"931231ae9f7f09551b5d00cc6c1fb2fcd28fcf31","unresolved":true,"context_lines":[{"line_number":31,"context_line":"aof-load-truncated yes"},{"line_number":32,"context_line":"lua-time-limit 5000"},{"line_number":33,"context_line":"slowlog-log-slower-than 10000"},{"line_number":34,"context_line":"slowlog-max-len 128"},{"line_number":35,"context_line":"latency-monitor-threshold 0"},{"line_number":36,"context_line":"notify-keyspace-events \"\""},{"line_number":37,"context_line":"hash-max-ziplist-entries 512"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"9a8e1a72_8bebd21b","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":15},"updated":"2025-09-05 09:07:57.000000000","message":"512 or more - Increases the number of retained slowlog entries, which is useful for diagnosing issues under heavy load.","commit_id":"c1c157d62596dec649c418fd5fd04d591ea99f2c"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c6e784fcbe60d7241b5569cc46b719af96048d41","unresolved":false,"context_lines":[{"line_number":31,"context_line":"aof-load-truncated yes"},{"line_number":32,"context_line":"lua-time-limit 5000"},{"line_number":33,"context_line":"slowlog-log-slower-than 10000"},{"line_number":34,"context_line":"slowlog-max-len 128"},{"line_number":35,"context_line":"latency-monitor-threshold 0"},{"line_number":36,"context_line":"notify-keyspace-events \"\""},{"line_number":37,"context_line":"hash-max-ziplist-entries 512"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"aa58ed59_458dda03","line":34,"range":{"start_line":34,"start_character":0,"end_line":34,"end_character":15},"in_reply_to":"9a8e1a72_8bebd21b","updated":"2025-09-08 14:34:25.000000000","message":"Acknowledged","commit_id":"c1c157d62596dec649c418fd5fd04d591ea99f2c"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"931231ae9f7f09551b5d00cc6c1fb2fcd28fcf31","unresolved":true,"context_lines":[{"line_number":32,"context_line":"lua-time-limit 5000"},{"line_number":33,"context_line":"slowlog-log-slower-than 10000"},{"line_number":34,"context_line":"slowlog-max-len 128"},{"line_number":35,"context_line":"latency-monitor-threshold 0"},{"line_number":36,"context_line":"notify-keyspace-events \"\""},{"line_number":37,"context_line":"hash-max-ziplist-entries 512"},{"line_number":38,"context_line":"hash-max-ziplist-value 64"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"e9612c0d_511ec2fd","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":25},"updated":"2025-09-05 09:07:57.000000000","message":"100? - Activates latency monitoring, helping diagnose performance bottlenecks and detect slow operations or maybe a parameter with a default value","commit_id":"c1c157d62596dec649c418fd5fd04d591ea99f2c"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c6e784fcbe60d7241b5569cc46b719af96048d41","unresolved":false,"context_lines":[{"line_number":32,"context_line":"lua-time-limit 5000"},{"line_number":33,"context_line":"slowlog-log-slower-than 10000"},{"line_number":34,"context_line":"slowlog-max-len 128"},{"line_number":35,"context_line":"latency-monitor-threshold 0"},{"line_number":36,"context_line":"notify-keyspace-events \"\""},{"line_number":37,"context_line":"hash-max-ziplist-entries 512"},{"line_number":38,"context_line":"hash-max-ziplist-value 64"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"75e6178b_7e79fc08","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":25},"in_reply_to":"e9612c0d_511ec2fd","updated":"2025-09-08 14:34:25.000000000","message":"Acknowledged","commit_id":"c1c157d62596dec649c418fd5fd04d591ea99f2c"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"931231ae9f7f09551b5d00cc6c1fb2fcd28fcf31","unresolved":true,"context_lines":[{"line_number":33,"context_line":"slowlog-log-slower-than 10000"},{"line_number":34,"context_line":"slowlog-max-len 128"},{"line_number":35,"context_line":"latency-monitor-threshold 0"},{"line_number":36,"context_line":"notify-keyspace-events \"\""},{"line_number":37,"context_line":"hash-max-ziplist-entries 512"},{"line_number":38,"context_line":"hash-max-ziplist-value 64"},{"line_number":39,"context_line":"set-max-intset-entries 512"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"44d6f50b_0dcd860e","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":25},"updated":"2025-09-05 09:07:57.000000000","message":"KEA? - Enables keyspace notifications, which are essential for tools like Sentinel or monitoring systems to react to key events (e.g., expirations, evictions).","commit_id":"c1c157d62596dec649c418fd5fd04d591ea99f2c"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c6e784fcbe60d7241b5569cc46b719af96048d41","unresolved":false,"context_lines":[{"line_number":33,"context_line":"slowlog-log-slower-than 10000"},{"line_number":34,"context_line":"slowlog-max-len 128"},{"line_number":35,"context_line":"latency-monitor-threshold 0"},{"line_number":36,"context_line":"notify-keyspace-events \"\""},{"line_number":37,"context_line":"hash-max-ziplist-entries 512"},{"line_number":38,"context_line":"hash-max-ziplist-value 64"},{"line_number":39,"context_line":"set-max-intset-entries 512"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"e90c13a9_780b2544","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":25},"in_reply_to":"44d6f50b_0dcd860e","updated":"2025-09-08 14:34:25.000000000","message":"Acknowledged","commit_id":"c1c157d62596dec649c418fd5fd04d591ea99f2c"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"931231ae9f7f09551b5d00cc6c1fb2fcd28fcf31","unresolved":true,"context_lines":[{"line_number":41,"context_line":"zset-max-ziplist-value 64"},{"line_number":42,"context_line":"hll-sparse-max-bytes 3000"},{"line_number":43,"context_line":"activerehashing yes"},{"line_number":44,"context_line":"client-output-buffer-limit normal 0 0 0"},{"line_number":45,"context_line":"client-output-buffer-limit replica 256mb 64mb 60"},{"line_number":46,"context_line":"client-output-buffer-limit pubsub 32mb 8mb 60"},{"line_number":47,"context_line":"hz 10"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"184557e1_ff808ebf","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":33},"updated":"2025-09-05 09:07:57.000000000","message":"64mb 16mb 60 (or configurable)? In large deployments, defining sane defaults or making this tunable is critical.","commit_id":"c1c157d62596dec649c418fd5fd04d591ea99f2c"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"70aab94fa5782fc1c63c313a4083f5f4a8cbfca6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"zset-max-ziplist-value 64"},{"line_number":42,"context_line":"hll-sparse-max-bytes 3000"},{"line_number":43,"context_line":"activerehashing yes"},{"line_number":44,"context_line":"client-output-buffer-limit normal 0 0 0"},{"line_number":45,"context_line":"client-output-buffer-limit replica 256mb 64mb 60"},{"line_number":46,"context_line":"client-output-buffer-limit pubsub 32mb 8mb 60"},{"line_number":47,"context_line":"hz 10"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"8fab2baf_e772bb42","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":33},"in_reply_to":"184557e1_ff808ebf","updated":"2025-09-08 14:33:41.000000000","message":"Kolla-ansible comes in with some opinionated defaults, all the configuration options can be tuned to fit specific environments. \nPlease feel free to join the discussion on IRC.","commit_id":"c1c157d62596dec649c418fd5fd04d591ea99f2c"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"931231ae9f7f09551b5d00cc6c1fb2fcd28fcf31","unresolved":true,"context_lines":[{"line_number":44,"context_line":"client-output-buffer-limit normal 0 0 0"},{"line_number":45,"context_line":"client-output-buffer-limit replica 256mb 64mb 60"},{"line_number":46,"context_line":"client-output-buffer-limit pubsub 32mb 8mb 60"},{"line_number":47,"context_line":"hz 10"},{"line_number":48,"context_line":"aof-rewrite-incremental-fsync yes"},{"line_number":49,"context_line":"requirepass {{ valkey_master_password }}"},{"line_number":50,"context_line":"masterauth {{ valkey_master_password }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"f91d7ddc_9d6268ba","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":2},"updated":"2025-09-05 09:07:57.000000000","message":"100? - Increases the frequency of internal housekeeping tasks (e.g., eviction, replication checks), which is beneficial in high-throughput environments.","commit_id":"c1c157d62596dec649c418fd5fd04d591ea99f2c"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c6e784fcbe60d7241b5569cc46b719af96048d41","unresolved":false,"context_lines":[{"line_number":44,"context_line":"client-output-buffer-limit normal 0 0 0"},{"line_number":45,"context_line":"client-output-buffer-limit replica 256mb 64mb 60"},{"line_number":46,"context_line":"client-output-buffer-limit pubsub 32mb 8mb 60"},{"line_number":47,"context_line":"hz 10"},{"line_number":48,"context_line":"aof-rewrite-incremental-fsync yes"},{"line_number":49,"context_line":"requirepass {{ valkey_master_password }}"},{"line_number":50,"context_line":"masterauth {{ valkey_master_password }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"e4dd1a9f_4204c2e8","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":2},"in_reply_to":"27741296_72139845","updated":"2025-09-08 14:34:25.000000000","message":"Acknowledged","commit_id":"c1c157d62596dec649c418fd5fd04d591ea99f2c"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c99a4019ebec431f8c08e0a473d57cf1d596c6ee","unresolved":true,"context_lines":[{"line_number":44,"context_line":"client-output-buffer-limit normal 0 0 0"},{"line_number":45,"context_line":"client-output-buffer-limit replica 256mb 64mb 60"},{"line_number":46,"context_line":"client-output-buffer-limit pubsub 32mb 8mb 60"},{"line_number":47,"context_line":"hz 10"},{"line_number":48,"context_line":"aof-rewrite-incremental-fsync yes"},{"line_number":49,"context_line":"requirepass {{ valkey_master_password }}"},{"line_number":50,"context_line":"masterauth {{ valkey_master_password }}"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"27741296_72139845","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":2},"in_reply_to":"f91d7ddc_9d6268ba","updated":"2025-09-05 09:24:58.000000000","message":"Those are some good comments, however point of this PR was replacing redis with valkey, so all the values were carried over from redis configuration.\n\nI feel some of the comments you mention deserve a separate discussion on K/A IRC / weekly meeting. Would you mind joining in ?","commit_id":"c1c157d62596dec649c418fd5fd04d591ea99f2c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"78873ebe3340bdef5fd8e77c1595167580261dcf","unresolved":true,"context_lines":[{"line_number":14,"context_line":"protected-mode no"},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% if is_migration and is_primary %}"},{"line_number":18,"context_line":"# Migration mode: valkey[0] replicates from Redis"},{"line_number":19,"context_line":"{% set redis_master_ip \u003d \u0027api\u0027 | kolla_address(groups[\u0027redis\u0027][0]) %}"},{"line_number":20,"context_line":"replicaof {{ redis_master_ip }} {{ redis_port }}"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"3d39bbf0_cd8b614d","line":17,"updated":"2025-10-29 15:09:47.000000000","message":"_valkey_is_migration and _valkey_is_primary would be better names","commit_id":"93b2114d89f0c9749119bc0324c26570789849b6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1ae8037f42902406371b9701a78f9c4f3584f6cd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"protected-mode no"},{"line_number":15,"context_line":"{% endif %}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% if is_migration and is_primary %}"},{"line_number":18,"context_line":"# Migration mode: valkey[0] replicates from Redis"},{"line_number":19,"context_line":"{% set redis_master_ip \u003d \u0027api\u0027 | kolla_address(groups[\u0027redis\u0027][0]) %}"},{"line_number":20,"context_line":"replicaof {{ redis_master_ip }} {{ redis_port }}"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"be370560_0a48fd13","line":17,"in_reply_to":"3d39bbf0_cd8b614d","updated":"2025-10-30 12:34:02.000000000","message":"Done","commit_id":"93b2114d89f0c9749119bc0324c26570789849b6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"78873ebe3340bdef5fd8e77c1595167580261dcf","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% if is_migration and is_primary %}"},{"line_number":18,"context_line":"# Migration mode: valkey[0] replicates from Redis"},{"line_number":19,"context_line":"{% set redis_master_ip \u003d \u0027api\u0027 | kolla_address(groups[\u0027redis\u0027][0]) %}"},{"line_number":20,"context_line":"replicaof {{ redis_master_ip }} {{ redis_port }}"},{"line_number":21,"context_line":"masterauth {{ redis_master_password }}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"6b87faee_8569ebdf","line":19,"updated":"2025-10-29 15:09:47.000000000","message":"Why are you setting a variable you use only once?","commit_id":"93b2114d89f0c9749119bc0324c26570789849b6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1ae8037f42902406371b9701a78f9c4f3584f6cd","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% if is_migration and is_primary %}"},{"line_number":18,"context_line":"# Migration mode: valkey[0] replicates from Redis"},{"line_number":19,"context_line":"{% set redis_master_ip \u003d \u0027api\u0027 | kolla_address(groups[\u0027redis\u0027][0]) %}"},{"line_number":20,"context_line":"replicaof {{ redis_master_ip }} {{ redis_port }}"},{"line_number":21,"context_line":"masterauth {{ redis_master_password }}"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"0e7ad5a5_b8efbbb4","line":19,"in_reply_to":"6b87faee_8569ebdf","updated":"2025-10-30 12:34:02.000000000","message":"Done","commit_id":"93b2114d89f0c9749119bc0324c26570789849b6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"78873ebe3340bdef5fd8e77c1595167580261dcf","unresolved":true,"context_lines":[{"line_number":20,"context_line":"replicaof {{ redis_master_ip }} {{ redis_port }}"},{"line_number":21,"context_line":"masterauth {{ redis_master_password }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% elif not is_primary %}"},{"line_number":24,"context_line":"# Secondary valkey nodes replicate from valkey[0]"},{"line_number":25,"context_line":"{% set valkey_master_ip \u003d \u0027api\u0027 | kolla_address(groups[\u0027valkey\u0027][0]) %}"},{"line_number":26,"context_line":"replicaof {{ valkey_master_ip }} {{ valkey_port }}"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"b7c1f3b5_26280c5f","line":23,"updated":"2025-10-29 15:09:47.000000000","message":"ditto","commit_id":"93b2114d89f0c9749119bc0324c26570789849b6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1ae8037f42902406371b9701a78f9c4f3584f6cd","unresolved":false,"context_lines":[{"line_number":20,"context_line":"replicaof {{ redis_master_ip }} {{ redis_port }}"},{"line_number":21,"context_line":"masterauth {{ redis_master_password }}"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% elif not is_primary %}"},{"line_number":24,"context_line":"# Secondary valkey nodes replicate from valkey[0]"},{"line_number":25,"context_line":"{% set valkey_master_ip \u003d \u0027api\u0027 | kolla_address(groups[\u0027valkey\u0027][0]) %}"},{"line_number":26,"context_line":"replicaof {{ valkey_master_ip }} {{ valkey_port }}"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"ddb1188e_3d111945","line":23,"in_reply_to":"b7c1f3b5_26280c5f","updated":"2025-10-30 12:34:02.000000000","message":"Done","commit_id":"93b2114d89f0c9749119bc0324c26570789849b6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"78873ebe3340bdef5fd8e77c1595167580261dcf","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% elif not is_primary %}"},{"line_number":24,"context_line":"# Secondary valkey nodes replicate from valkey[0]"},{"line_number":25,"context_line":"{% set valkey_master_ip \u003d \u0027api\u0027 | kolla_address(groups[\u0027valkey\u0027][0]) %}"},{"line_number":26,"context_line":"replicaof {{ valkey_master_ip }} {{ valkey_port }}"},{"line_number":27,"context_line":"masterauth {{ valkey_master_password }}"},{"line_number":28,"context_line":"requirepass {{ valkey_master_password }}"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"dfbca389_36a63639","line":25,"updated":"2025-10-29 15:09:47.000000000","message":"ditto","commit_id":"93b2114d89f0c9749119bc0324c26570789849b6"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1ae8037f42902406371b9701a78f9c4f3584f6cd","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"{% elif not is_primary %}"},{"line_number":24,"context_line":"# Secondary valkey nodes replicate from valkey[0]"},{"line_number":25,"context_line":"{% set valkey_master_ip \u003d \u0027api\u0027 | kolla_address(groups[\u0027valkey\u0027][0]) %}"},{"line_number":26,"context_line":"replicaof {{ valkey_master_ip }} {{ valkey_port }}"},{"line_number":27,"context_line":"masterauth {{ valkey_master_password }}"},{"line_number":28,"context_line":"requirepass {{ valkey_master_password }}"}],"source_content_type":"text/x-jinja2","patch_set":40,"id":"d7c836e8_05c86901","line":25,"in_reply_to":"dfbca389_36a63639","updated":"2025-10-30 12:34:02.000000000","message":"Done","commit_id":"93b2114d89f0c9749119bc0324c26570789849b6"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"1e263699bb3309068b149140ad453f607e966b17","unresolved":true,"context_lines":[{"line_number":11,"context_line":"{% endif %}"},{"line_number":12,"context_line":"{% if valkey_migration | default(false) | bool and inventory_hostname \u003d\u003d groups[\u0027valkey\u0027][0] %}"},{"line_number":13,"context_line":"{# Migration mode: valkey[0] replicates from Redis #}"},{"line_number":14,"context_line":"replicaof {{ \u0027api\u0027 | kolla_address(groups[\u0027redis\u0027][0]) }} {{ redis_port }}"},{"line_number":15,"context_line":"masterauth {{ redis_master_password }}"},{"line_number":16,"context_line":"{% elif not inventory_hostname \u003d\u003d groups[\u0027valkey\u0027][0] %}"},{"line_number":17,"context_line":"{# Secondary valkey nodes replicate from valkey[0] #}"}],"source_content_type":"text/x-jinja2","patch_set":54,"id":"bd6bed19_ae7ef0fa","line":14,"updated":"2025-11-03 11:28:31.000000000","message":"redis_port is undefined now","commit_id":"ba8a8f719b596744272ee55daae28e89b6d3868c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b5d634383a6a7196ffd7d6cfc78d6c9a529c5f23","unresolved":false,"context_lines":[{"line_number":11,"context_line":"{% endif %}"},{"line_number":12,"context_line":"{% if valkey_migration | default(false) | bool and inventory_hostname \u003d\u003d groups[\u0027valkey\u0027][0] %}"},{"line_number":13,"context_line":"{# Migration mode: valkey[0] replicates from Redis #}"},{"line_number":14,"context_line":"replicaof {{ \u0027api\u0027 | kolla_address(groups[\u0027redis\u0027][0]) }} {{ redis_port }}"},{"line_number":15,"context_line":"masterauth {{ redis_master_password }}"},{"line_number":16,"context_line":"{% elif not inventory_hostname \u003d\u003d groups[\u0027valkey\u0027][0] %}"},{"line_number":17,"context_line":"{# Secondary valkey nodes replicate from valkey[0] #}"}],"source_content_type":"text/x-jinja2","patch_set":54,"id":"48673501_7cda7cc1","line":14,"in_reply_to":"bd6bed19_ae7ef0fa","updated":"2025-11-04 09:50:23.000000000","message":"Done","commit_id":"ba8a8f719b596744272ee55daae28e89b6d3868c"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"933cf2ba2df8959955697e2b02d553e2096f4734","unresolved":true,"context_lines":[{"line_number":14,"context_line":"masterauth {{ redis_master_password }}"},{"line_number":15,"context_line":"{% elif not inventory_hostname \u003d\u003d groups[\u0027valkey\u0027][0] %}"},{"line_number":16,"context_line":"{# Secondary valkey nodes replicate from valkey[0] #}"},{"line_number":17,"context_line":"replicaof {{ \u0027api\u0027 | kolla_address(groups[\u0027valkey\u0027][0]) }} {{ valkey_port }}"},{"line_number":18,"context_line":"masterauth {{ valkey_master_password }}"},{"line_number":19,"context_line":"requirepass {{ valkey_master_password }}"},{"line_number":20,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":66,"id":"50cb7c02_487fd9cf","line":17,"updated":"2025-11-05 11:20:21.000000000","message":"this will not trigger in normal mode. i.e. in not migration we won\u0027t have replicas","commit_id":"2f6eb1369c51bbfdc2d57c62f5a664423e4b0479"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b9d83ecfd610979ad4788b1e8b22e98423e7dff6","unresolved":true,"context_lines":[{"line_number":14,"context_line":"masterauth {{ redis_master_password }}"},{"line_number":15,"context_line":"{% elif not inventory_hostname \u003d\u003d groups[\u0027valkey\u0027][0] %}"},{"line_number":16,"context_line":"{# Secondary valkey nodes replicate from valkey[0] #}"},{"line_number":17,"context_line":"replicaof {{ \u0027api\u0027 | kolla_address(groups[\u0027valkey\u0027][0]) }} {{ valkey_port }}"},{"line_number":18,"context_line":"masterauth {{ valkey_master_password }}"},{"line_number":19,"context_line":"requirepass {{ valkey_master_password }}"},{"line_number":20,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":66,"id":"f133b588_62c4e833","line":17,"in_reply_to":"50cb7c02_487fd9cf","updated":"2025-11-05 11:31:08.000000000","message":"So we need to add it in line 23 ;-)","commit_id":"2f6eb1369c51bbfdc2d57c62f5a664423e4b0479"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"dd22271eb91fe30cc03971b3c46751525fd175b8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"masterauth {{ redis_master_password }}"},{"line_number":15,"context_line":"{% elif not inventory_hostname \u003d\u003d groups[\u0027valkey\u0027][0] %}"},{"line_number":16,"context_line":"{# Secondary valkey nodes replicate from valkey[0] #}"},{"line_number":17,"context_line":"replicaof {{ \u0027api\u0027 | kolla_address(groups[\u0027valkey\u0027][0]) }} {{ valkey_port }}"},{"line_number":18,"context_line":"masterauth {{ valkey_master_password }}"},{"line_number":19,"context_line":"requirepass {{ valkey_master_password }}"},{"line_number":20,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":66,"id":"b61a6628_5604667c","line":17,"in_reply_to":"f133b588_62c4e833","updated":"2025-11-05 11:44:02.000000000","message":"Done","commit_id":"2f6eb1369c51bbfdc2d57c62f5a664423e4b0479"}],"ansible/roles/valkey/templates/valkey.json.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8b827d32cbdcb2620d901c0143b42d3455cfe529","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"valkey-server {{ valkey_conf_path }}\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/valkey.conf\","}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"42bc610a_678e5c17","line":2,"updated":"2025-10-16 13:15:32.000000000","message":"ditto","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c278d603544d8c0d4bfe49d7ecc25fa24df0ec67","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"valkey-server {{ valkey_conf_path }}\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/valkey.conf\","}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"5af3411a_b9f39216","line":2,"in_reply_to":"42bc610a_678e5c17","updated":"2025-10-17 08:20:15.000000000","message":"https://github.com/openstack/kolla-ansible/commit/257ef9fae82dda82d3ef477919c14aa3a8915971","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"}],"etc/kolla/globals.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b3be2718dfae3ff19f98aac5d311da52d403901c","unresolved":true,"context_lines":[{"line_number":566,"context_line":"#cinder_backend_ceph: \"no\""},{"line_number":567,"context_line":"#cinder_volume_group: \"cinder-volumes\""},{"line_number":568,"context_line":"# Valid options are [ \u0027\u0027, valkey, etcd ]"},{"line_number":569,"context_line":"#cinder_coordination_backend: \"{{ \u0027valkey\u0027 if enable_valkey|bool else \u0027etcd\u0027 if enable_etcd|bool else \u0027\u0027 }}\""},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"# Valid options are [ nfs, ceph, s3 ]"},{"line_number":572,"context_line":"#cinder_backup_driver: \"ceph\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"6bb665ce_26ebb0ad","line":569,"range":{"start_line":569,"start_character":59,"end_line":569,"end_character":60},"updated":"2025-10-08 14:42:48.000000000","message":"spaces around |","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c6ad3b1d03e0c93e77bfcaf23d6b2610c50ac66b","unresolved":false,"context_lines":[{"line_number":566,"context_line":"#cinder_backend_ceph: \"no\""},{"line_number":567,"context_line":"#cinder_volume_group: \"cinder-volumes\""},{"line_number":568,"context_line":"# Valid options are [ \u0027\u0027, valkey, etcd ]"},{"line_number":569,"context_line":"#cinder_coordination_backend: \"{{ \u0027valkey\u0027 if enable_valkey|bool else \u0027etcd\u0027 if enable_etcd|bool else \u0027\u0027 }}\""},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"# Valid options are [ nfs, ceph, s3 ]"},{"line_number":572,"context_line":"#cinder_backup_driver: \"ceph\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"21dc98b8_350c15b0","line":569,"range":{"start_line":569,"start_character":59,"end_line":569,"end_character":60},"in_reply_to":"6bb665ce_26ebb0ad","updated":"2025-10-15 21:00:17.000000000","message":"Done","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b3be2718dfae3ff19f98aac5d311da52d403901c","unresolved":true,"context_lines":[{"line_number":660,"context_line":"#ironic_kernel_cmdline_extras: []"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"# Valid options are [ \u0027\u0027, valkey, etcd ]"},{"line_number":663,"context_line":"#ironic_coordination_backend: \"{{ \u0027valkey\u0027 if enable_valkey|bool else \u0027etcd\u0027 if enable_etcd|bool else \u0027\u0027 }}\""},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"######################################"},{"line_number":666,"context_line":"# Manila - Shared File Systems Options"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"19e35e99_c32af4e0","line":663,"range":{"start_line":663,"start_character":59,"end_line":663,"end_character":60},"updated":"2025-10-08 14:42:48.000000000","message":"ditto","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c6ad3b1d03e0c93e77bfcaf23d6b2610c50ac66b","unresolved":false,"context_lines":[{"line_number":660,"context_line":"#ironic_kernel_cmdline_extras: []"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"# Valid options are [ \u0027\u0027, valkey, etcd ]"},{"line_number":663,"context_line":"#ironic_coordination_backend: \"{{ \u0027valkey\u0027 if enable_valkey|bool else \u0027etcd\u0027 if enable_etcd|bool else \u0027\u0027 }}\""},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"######################################"},{"line_number":666,"context_line":"# Manila - Shared File Systems Options"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"021bb475_271bdec1","line":663,"range":{"start_line":663,"start_character":59,"end_line":663,"end_character":60},"in_reply_to":"19e35e99_c32af4e0","updated":"2025-10-15 21:00:17.000000000","message":"Done","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"}],"etc/kolla/passwords.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b3be2718dfae3ff19f98aac5d311da52d403901c","unresolved":true,"context_lines":[{"line_number":203,"context_line":"# valkey options"},{"line_number":204,"context_line":"####################"},{"line_number":205,"context_line":"valkey_master_password:"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"# Remove after G release"},{"line_number":208,"context_line":"redis_master_password:"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ba02449d_73f8d4e7","line":206,"updated":"2025-10-08 14:42:48.000000000","message":"unnecessary empty line","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c6ad3b1d03e0c93e77bfcaf23d6b2610c50ac66b","unresolved":false,"context_lines":[{"line_number":203,"context_line":"# valkey options"},{"line_number":204,"context_line":"####################"},{"line_number":205,"context_line":"valkey_master_password:"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"# Remove after G release"},{"line_number":208,"context_line":"redis_master_password:"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"25ad5c87_218dc115","line":206,"in_reply_to":"ba02449d_73f8d4e7","updated":"2025-10-15 21:00:17.000000000","message":"Done","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b3be2718dfae3ff19f98aac5d311da52d403901c","unresolved":true,"context_lines":[{"line_number":204,"context_line":"####################"},{"line_number":205,"context_line":"valkey_master_password:"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"# Remove after G release"},{"line_number":208,"context_line":"redis_master_password:"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"770e5fcc_ff0743ca","line":207,"updated":"2025-10-08 14:42:48.000000000","message":"```suggestion\n# TODO(coper): Remove after G/2026.1 release\n```","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c6ad3b1d03e0c93e77bfcaf23d6b2610c50ac66b","unresolved":false,"context_lines":[{"line_number":204,"context_line":"####################"},{"line_number":205,"context_line":"valkey_master_password:"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"# Remove after G release"},{"line_number":208,"context_line":"redis_master_password:"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"29af6598_f420219d","line":207,"in_reply_to":"770e5fcc_ff0743ca","updated":"2025-10-15 21:00:17.000000000","message":"Done","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"}],"tests/check-logs.sh":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d3be89568d504cea87d8aaace927de51f86643e3","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        /var/log/kolla/rabbitmq/*upgrade.log)"},{"line_number":92,"context_line":"            continue"},{"line_number":93,"context_line":"            ;;"},{"line_number":94,"context_line":"        /var/log/kolla/valkey/*)"},{"line_number":95,"context_line":"            continue"},{"line_number":96,"context_line":"            ;;"},{"line_number":97,"context_line":"        /var/log/kolla/skyline/skyline.log)"}],"source_content_type":"text/x-sh","patch_set":9,"id":"e2b53360_1272e19c","line":94,"updated":"2025-09-19 06:57:06.000000000","message":"Let\u0027s ingest these logs in fluentd this time?","commit_id":"e0bb62f352ce8a55a63fa25962b1a608d40de21f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1ae8037f42902406371b9701a78f9c4f3584f6cd","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        /var/log/kolla/rabbitmq/*upgrade.log)"},{"line_number":92,"context_line":"            continue"},{"line_number":93,"context_line":"            ;;"},{"line_number":94,"context_line":"        /var/log/kolla/valkey/*)"},{"line_number":95,"context_line":"            continue"},{"line_number":96,"context_line":"            ;;"},{"line_number":97,"context_line":"        /var/log/kolla/skyline/skyline.log)"}],"source_content_type":"text/x-sh","patch_set":9,"id":"a77e9cf4_9a300e41","line":94,"in_reply_to":"6a494326_21f99240","updated":"2025-10-30 12:34:02.000000000","message":"Done","commit_id":"e0bb62f352ce8a55a63fa25962b1a608d40de21f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"25cd82a001fd680e43dd85f5cfe95ae9ca101450","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        /var/log/kolla/rabbitmq/*upgrade.log)"},{"line_number":92,"context_line":"            continue"},{"line_number":93,"context_line":"            ;;"},{"line_number":94,"context_line":"        /var/log/kolla/valkey/*)"},{"line_number":95,"context_line":"            continue"},{"line_number":96,"context_line":"            ;;"},{"line_number":97,"context_line":"        /var/log/kolla/skyline/skyline.log)"}],"source_content_type":"text/x-sh","patch_set":9,"id":"6a494326_21f99240","line":94,"in_reply_to":"86443b3a_8f3fbfbb","updated":"2025-10-29 11:50:59.000000000","message":"Not done.","commit_id":"e0bb62f352ce8a55a63fa25962b1a608d40de21f"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"247ce6cc930c4d543f74c91004f7382e96313bd4","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        /var/log/kolla/rabbitmq/*upgrade.log)"},{"line_number":92,"context_line":"            continue"},{"line_number":93,"context_line":"            ;;"},{"line_number":94,"context_line":"        /var/log/kolla/valkey/*)"},{"line_number":95,"context_line":"            continue"},{"line_number":96,"context_line":"            ;;"},{"line_number":97,"context_line":"        /var/log/kolla/skyline/skyline.log)"}],"source_content_type":"text/x-sh","patch_set":9,"id":"86443b3a_8f3fbfbb","line":94,"in_reply_to":"e2b53360_1272e19c","updated":"2025-10-17 14:51:34.000000000","message":"Done","commit_id":"e0bb62f352ce8a55a63fa25962b1a608d40de21f"}],"tests/templates/globals-default.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8b827d32cbdcb2620d901c0143b42d3455cfe529","unresolved":true,"context_lines":[{"line_number":123,"context_line":"enable_heat: \"yes\""},{"line_number":124,"context_line":"# NOTE(yoctozepto): see https://bugs.launchpad.net/kolla-ansible/+bug/1906299"},{"line_number":125,"context_line":"enable_aodh: \"yes\""},{"line_number":126,"context_line":"# Needed for Redis-\u003eValkey migration. Remove later"},{"line_number":127,"context_line":"{% if is_upgrade %}"},{"line_number":128,"context_line":"enable_redis: \"yes\""},{"line_number":129,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"eae34074_0709bfbd","line":126,"updated":"2025-10-16 13:15:32.000000000","message":"When later? needs to a TODO","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c278d603544d8c0d4bfe49d7ecc25fa24df0ec67","unresolved":false,"context_lines":[{"line_number":123,"context_line":"enable_heat: \"yes\""},{"line_number":124,"context_line":"# NOTE(yoctozepto): see https://bugs.launchpad.net/kolla-ansible/+bug/1906299"},{"line_number":125,"context_line":"enable_aodh: \"yes\""},{"line_number":126,"context_line":"# Needed for Redis-\u003eValkey migration. Remove later"},{"line_number":127,"context_line":"{% if is_upgrade %}"},{"line_number":128,"context_line":"enable_redis: \"yes\""},{"line_number":129,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"437b8866_3ffdc6bc","line":126,"in_reply_to":"eae34074_0709bfbd","updated":"2025-10-17 08:20:15.000000000","message":"Done","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8b827d32cbdcb2620d901c0143b42d3455cfe529","unresolved":true,"context_lines":[{"line_number":169,"context_line":"rabbitmq_cluster_partition_handling: \"autoheal\""},{"line_number":170,"context_line":"rabbitmq_extra_config:"},{"line_number":171,"context_line":"  cluster_keepalive_interval: 50000"},{"line_number":172,"context_line":"# Needed for Redis-\u003eValkey migration. Remove later"},{"line_number":173,"context_line":"{% if is_upgrade %}"},{"line_number":174,"context_line":"enable_redis: \"yes\""},{"line_number":175,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"b252a3a1_d015311f","line":172,"updated":"2025-10-16 13:15:32.000000000","message":"ditto","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c278d603544d8c0d4bfe49d7ecc25fa24df0ec67","unresolved":false,"context_lines":[{"line_number":169,"context_line":"rabbitmq_cluster_partition_handling: \"autoheal\""},{"line_number":170,"context_line":"rabbitmq_extra_config:"},{"line_number":171,"context_line":"  cluster_keepalive_interval: 50000"},{"line_number":172,"context_line":"# Needed for Redis-\u003eValkey migration. Remove later"},{"line_number":173,"context_line":"{% if is_upgrade %}"},{"line_number":174,"context_line":"enable_redis: \"yes\""},{"line_number":175,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"9850911e_c5612e8e","line":172,"in_reply_to":"b252a3a1_d015311f","updated":"2025-10-17 08:20:15.000000000","message":"Done","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8b827d32cbdcb2620d901c0143b42d3455cfe529","unresolved":true,"context_lines":[{"line_number":208,"context_line":"octavia_provider_agents: \"ovn\""},{"line_number":209,"context_line":"enable_valkey: \"yes\""},{"line_number":210,"context_line":"neutron_dns_domain: \"example.org.\""},{"line_number":211,"context_line":"# Needed for Redis-\u003eValkey migration. Remove later"},{"line_number":212,"context_line":"{% if is_upgrade %}"},{"line_number":213,"context_line":"enable_redis: \"yes\""},{"line_number":214,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"3d0e190b_e5e19c3e","line":211,"updated":"2025-10-16 13:15:32.000000000","message":"ditto","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c278d603544d8c0d4bfe49d7ecc25fa24df0ec67","unresolved":false,"context_lines":[{"line_number":208,"context_line":"octavia_provider_agents: \"ovn\""},{"line_number":209,"context_line":"enable_valkey: \"yes\""},{"line_number":210,"context_line":"neutron_dns_domain: \"example.org.\""},{"line_number":211,"context_line":"# Needed for Redis-\u003eValkey migration. Remove later"},{"line_number":212,"context_line":"{% if is_upgrade %}"},{"line_number":213,"context_line":"enable_redis: \"yes\""},{"line_number":214,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"81387554_c5a506a0","line":211,"in_reply_to":"3d0e190b_e5e19c3e","updated":"2025-10-17 08:20:15.000000000","message":"Done","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8b827d32cbdcb2620d901c0143b42d3455cfe529","unresolved":true,"context_lines":[{"line_number":244,"context_line":"  disk: 5"},{"line_number":245,"context_line":"octavia_network_type: \"tenant\""},{"line_number":246,"context_line":"enable_valkey: \"yes\""},{"line_number":247,"context_line":"# Needed for Redis-\u003eValkey migration. Remove later"},{"line_number":248,"context_line":"{% if is_upgrade %}"},{"line_number":249,"context_line":"enable_redis: \"yes\""},{"line_number":250,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"69d6caf9_e8139765","line":247,"updated":"2025-10-16 13:15:32.000000000","message":"ditto","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c278d603544d8c0d4bfe49d7ecc25fa24df0ec67","unresolved":false,"context_lines":[{"line_number":244,"context_line":"  disk: 5"},{"line_number":245,"context_line":"octavia_network_type: \"tenant\""},{"line_number":246,"context_line":"enable_valkey: \"yes\""},{"line_number":247,"context_line":"# Needed for Redis-\u003eValkey migration. Remove later"},{"line_number":248,"context_line":"{% if is_upgrade %}"},{"line_number":249,"context_line":"enable_redis: \"yes\""},{"line_number":250,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"13be2ef0_fc26b3b2","line":247,"in_reply_to":"69d6caf9_e8139765","updated":"2025-10-17 08:20:15.000000000","message":"Done","commit_id":"7d13d1bd2ec0c46364493ddd44af6f71084abbb9"}],"tests/templates/inventory.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b3be2718dfae3ff19f98aac5d311da52d403901c","unresolved":true,"context_lines":[{"line_number":225,"context_line":"[zun:children]"},{"line_number":226,"context_line":"control"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"#Remove redis group in G release"},{"line_number":229,"context_line":"[redis:children]"},{"line_number":230,"context_line":"control"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"cec4bf28_e9fa979c","line":228,"updated":"2025-10-08 14:42:48.000000000","message":"```suggestion\n# TODO(koperg): Remove redis group after G/2026.1 release\n```","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"c6ad3b1d03e0c93e77bfcaf23d6b2610c50ac66b","unresolved":false,"context_lines":[{"line_number":225,"context_line":"[zun:children]"},{"line_number":226,"context_line":"control"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"#Remove redis group in G release"},{"line_number":229,"context_line":"[redis:children]"},{"line_number":230,"context_line":"control"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"bc2bcd8d_30a593fc","line":228,"in_reply_to":"cec4bf28_e9fa979c","updated":"2025-10-15 21:00:17.000000000","message":"Done","commit_id":"bc43936d72fc89d85041ca1025fb9cf234ccaa93"}],"zuul.d/scenarios/ovn.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"607034d32f724b87ad82e2f4290c6641603d4cc0","unresolved":true,"context_lines":[{"line_number":10,"context_line":"      scenario: ovn"},{"line_number":11,"context_line":"      scenario_images_extra:"},{"line_number":12,"context_line":"        - ^octavia"},{"line_number":13,"context_line":"        - ^ovn"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- job:"},{"line_number":16,"context_line":"    name: kolla-ansible-debian-bookworm-ovn"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"82f33395_570f3323","line":13,"updated":"2025-10-30 11:28:59.000000000","message":"valkey needs to be added here","commit_id":"557716e69eff361b405f7d0309fe7c0efce5958e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1ae8037f42902406371b9701a78f9c4f3584f6cd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      scenario: ovn"},{"line_number":11,"context_line":"      scenario_images_extra:"},{"line_number":12,"context_line":"        - ^octavia"},{"line_number":13,"context_line":"        - ^ovn"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- job:"},{"line_number":16,"context_line":"    name: kolla-ansible-debian-bookworm-ovn"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"d2a90a3e_04b11a4c","line":13,"in_reply_to":"82f33395_570f3323","updated":"2025-10-30 12:34:02.000000000","message":"Done","commit_id":"557716e69eff361b405f7d0309fe7c0efce5958e"}]}