)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"aab185ed46840ecd92c2647d0b1fd5f700dc2202","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"glance: enable privileged and /dev mount for PowerFlex backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When Glance uses Cinder (glance_store\u003dcinder) with the PowerFlex/ScaleIO"},{"line_number":10,"context_line":"backend, image upload fails after Antelope due to privsep not starting"},{"line_number":11,"context_line":"inside the container and os-brick being unable to access host devices."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Current defaults only enable `privileged` and `/dev:/dev` bind-mount"},{"line_number":14,"context_line":"when using iSCSI or Ceph. PowerFlex also relies on os-brick and needs"},{"line_number":15,"context_line":"both capabilities and device access."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change:"},{"line_number":18,"context_line":"* Adds `enable_cinder_backend_powerflex` (default: \"no\")"},{"line_number":19,"context_line":"* Extends the `privileged` condition to include PowerFlex"},{"line_number":20,"context_line":"* Extends the `/dev:/dev` bind-mount condition to include PowerFlex"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Without these, Glance shows errors such as:"},{"line_number":23,"context_line":"- `oslo_privsep.daemon.FailedToDropPrivileges: Privsep daemon failed to start`"},{"line_number":24,"context_line":"- `os_brick.exception.BrickException: ScaleIO volume \u003cid\u003e not found at expected path`"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"With this change, Glance can write to Cinder volumes on PowerFlex."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Defaults impact:"},{"line_number":29,"context_line":"* No behavioral change unless `enable_cinder_backend_powerflex: \"yes\"`"},{"line_number":30,"context_line":"  is set; iSCSI and Ceph paths remain unchanged."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Testing:"},{"line_number":33,"context_line":"* Antelope kolla-ansible deployment with Glance+Cinder(PowerFlex):"},{"line_number":34,"context_line":"  - Image upload succeeds; no privsep or ScaleIO path errors"},{"line_number":35,"context_line":"* Regression check with iSCSI and Ceph backends: unchanged behavior"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"DocImpact: document the new `enable_cinder_backend_powerflex` option."},{"line_number":38,"context_line":"Change-Id: I538bde4a316fd5a3f1e7576ab36c850d214b5a50"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b4c80c2b_d0bd2f12","line":35,"range":{"start_line":9,"start_character":0,"end_line":35,"end_character":67},"updated":"2025-09-15 22:23:44.000000000","message":"All this longread should be moved to the bugreport on launchpad and the issue should be attached to the commit message.","commit_id":"456cff3f9a86394585c96d18c09a12c55bcd2c4c"},{"author":{"_account_id":38392,"name":"KWAK JOONGKEE","display_name":"joongkeekwak","email":"kift23@gmail.com","username":"joongkeekwak"},"change_message_id":"ed491d073ed5ba731f8b1a5cf172871c02598c5f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"glance: enable privileged and /dev mount for PowerFlex backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When Glance uses Cinder (glance_store\u003dcinder) with the PowerFlex/ScaleIO"},{"line_number":10,"context_line":"backend, image upload fails after Antelope due to privsep not starting"},{"line_number":11,"context_line":"inside the container and os-brick being unable to access host devices."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Current defaults only enable `privileged` and `/dev:/dev` bind-mount"},{"line_number":14,"context_line":"when using iSCSI or Ceph. PowerFlex also relies on os-brick and needs"},{"line_number":15,"context_line":"both capabilities and device access."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change:"},{"line_number":18,"context_line":"* Adds `enable_cinder_backend_powerflex` (default: \"no\")"},{"line_number":19,"context_line":"* Extends the `privileged` condition to include PowerFlex"},{"line_number":20,"context_line":"* Extends the `/dev:/dev` bind-mount condition to include PowerFlex"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Without these, Glance shows errors such as:"},{"line_number":23,"context_line":"- `oslo_privsep.daemon.FailedToDropPrivileges: Privsep daemon failed to start`"},{"line_number":24,"context_line":"- `os_brick.exception.BrickException: ScaleIO volume \u003cid\u003e not found at expected path`"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"With this change, Glance can write to Cinder volumes on PowerFlex."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Defaults impact:"},{"line_number":29,"context_line":"* No behavioral change unless `enable_cinder_backend_powerflex: \"yes\"`"},{"line_number":30,"context_line":"  is set; iSCSI and Ceph paths remain unchanged."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Testing:"},{"line_number":33,"context_line":"* Antelope kolla-ansible deployment with Glance+Cinder(PowerFlex):"},{"line_number":34,"context_line":"  - Image upload succeeds; no privsep or ScaleIO path errors"},{"line_number":35,"context_line":"* Regression check with iSCSI and Ceph backends: unchanged behavior"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"DocImpact: document the new `enable_cinder_backend_powerflex` option."},{"line_number":38,"context_line":"Change-Id: I538bde4a316fd5a3f1e7576ab36c850d214b5a50"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"622386a5_0c688d82","line":35,"range":{"start_line":9,"start_character":0,"end_line":35,"end_character":67},"in_reply_to":"b4c80c2b_d0bd2f12","updated":"2025-09-16 05:29:22.000000000","message":"Moved the long problem description into a Launchpad bug and linked it in the commit message.\nAddressed, now commit message is concise and references the bug report.","commit_id":"456cff3f9a86394585c96d18c09a12c55bcd2c4c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"aab185ed46840ecd92c2647d0b1fd5f700dc2202","unresolved":true,"context_lines":[{"line_number":34,"context_line":"  - Image upload succeeds; no privsep or ScaleIO path errors"},{"line_number":35,"context_line":"* Regression check with iSCSI and Ceph backends: unchanged behavior"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"DocImpact: document the new `enable_cinder_backend_powerflex` option."},{"line_number":38,"context_line":"Change-Id: I538bde4a316fd5a3f1e7576ab36c850d214b5a50"},{"line_number":39,"context_line":"Signed-off-by: joongkeekwak \u003ckift23@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"12bed2c9_d467e3d5","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":69},"updated":"2025-09-15 22:23:44.000000000","message":"Please add the piece of documentation to the ``doc/source/reference/storage/`` the good start for the ``glance-guide.rst``","commit_id":"456cff3f9a86394585c96d18c09a12c55bcd2c4c"},{"author":{"_account_id":38392,"name":"KWAK JOONGKEE","display_name":"joongkeekwak","email":"kift23@gmail.com","username":"joongkeekwak"},"change_message_id":"ed491d073ed5ba731f8b1a5cf172871c02598c5f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  - Image upload succeeds; no privsep or ScaleIO path errors"},{"line_number":35,"context_line":"* Regression check with iSCSI and Ceph backends: unchanged behavior"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"DocImpact: document the new `enable_cinder_backend_powerflex` option."},{"line_number":38,"context_line":"Change-Id: I538bde4a316fd5a3f1e7576ab36c850d214b5a50"},{"line_number":39,"context_line":"Signed-off-by: joongkeekwak \u003ckift23@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d27f6ddb_89a77f42","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":69},"in_reply_to":"12bed2c9_d467e3d5","updated":"2025-09-16 05:29:22.000000000","message":"Thanks for pointing that out, added documentation in glance-guide.rst.\nAdded the doc section under Glance backends as suggested.","commit_id":"456cff3f9a86394585c96d18c09a12c55bcd2c4c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1eae673706d080212fc76cd467b51e67344b6add","unresolved":true,"context_lines":[{"line_number":17,"context_line":"are enabled, and \"no\" otherwise. Operators can override it to \"yes\""},{"line_number":18,"context_line":"for other Cinder backends that need os-brick access."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Additionally, since group_vars/all.yml was split into"},{"line_number":21,"context_line":"per-service files under group_vars/all/, the default for"},{"line_number":22,"context_line":"`enable_cinder_backend_privileged` is now defined in"},{"line_number":23,"context_line":"`cinder.yml` instead of the removed `all.yml`."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Effect:"},{"line_number":26,"context_line":"* glance-api runs with privileged: true"},{"line_number":27,"context_line":"* /dev is bind-mounted into the container"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bfbd497a_47c73f83","line":24,"range":{"start_line":20,"start_character":0,"end_line":24,"end_character":0},"updated":"2025-09-30 06:43:44.000000000","message":"not needed here\nanyway, LGTM","commit_id":"a72c7bb3b5919ad56e679202af88702f78977739"},{"author":{"_account_id":38392,"name":"KWAK JOONGKEE","display_name":"joongkeekwak","email":"kift23@gmail.com","username":"joongkeekwak"},"change_message_id":"85394d5e24ba3bf01625a78e44d8dede08e03e51","unresolved":false,"context_lines":[{"line_number":17,"context_line":"are enabled, and \"no\" otherwise. Operators can override it to \"yes\""},{"line_number":18,"context_line":"for other Cinder backends that need os-brick access."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Additionally, since group_vars/all.yml was split into"},{"line_number":21,"context_line":"per-service files under group_vars/all/, the default for"},{"line_number":22,"context_line":"`enable_cinder_backend_privileged` is now defined in"},{"line_number":23,"context_line":"`cinder.yml` instead of the removed `all.yml`."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Effect:"},{"line_number":26,"context_line":"* glance-api runs with privileged: true"},{"line_number":27,"context_line":"* /dev is bind-mounted into the container"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b27c009f_6a177ff6","line":24,"range":{"start_line":20,"start_character":0,"end_line":24,"end_character":0},"in_reply_to":"31588d57_57676136","updated":"2025-10-01 08:23:32.000000000","message":"Thanks, I’ve dropped the unnecessary note from the commit message. \nUploaded as Patchset 4. Marking this as resolved.","commit_id":"a72c7bb3b5919ad56e679202af88702f78977739"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"de80e30eda763086bd5300e8243a97e1b6dc7da5","unresolved":true,"context_lines":[{"line_number":17,"context_line":"are enabled, and \"no\" otherwise. Operators can override it to \"yes\""},{"line_number":18,"context_line":"for other Cinder backends that need os-brick access."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Additionally, since group_vars/all.yml was split into"},{"line_number":21,"context_line":"per-service files under group_vars/all/, the default for"},{"line_number":22,"context_line":"`enable_cinder_backend_privileged` is now defined in"},{"line_number":23,"context_line":"`cinder.yml` instead of the removed `all.yml`."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Effect:"},{"line_number":26,"context_line":"* glance-api runs with privileged: true"},{"line_number":27,"context_line":"* /dev is bind-mounted into the container"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"31588d57_57676136","line":24,"range":{"start_line":20,"start_character":0,"end_line":24,"end_character":0},"in_reply_to":"92cf9bd6_868b86c5","updated":"2025-10-01 07:37:14.000000000","message":"The merge conflicts were introduced multiple times during the development process. It is not necessary to mention all of the cases that you solved until the changes were merged. Some kind of note would be needed in the backport from this change because there would have been merge conflicts and the code would have differed from the original version.","commit_id":"a72c7bb3b5919ad56e679202af88702f78977739"},{"author":{"_account_id":38392,"name":"KWAK JOONGKEE","display_name":"joongkeekwak","email":"kift23@gmail.com","username":"joongkeekwak"},"change_message_id":"e78c8e99a87d08c908ce5a270108adbc9ea344d3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"are enabled, and \"no\" otherwise. Operators can override it to \"yes\""},{"line_number":18,"context_line":"for other Cinder backends that need os-brick access."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Additionally, since group_vars/all.yml was split into"},{"line_number":21,"context_line":"per-service files under group_vars/all/, the default for"},{"line_number":22,"context_line":"`enable_cinder_backend_privileged` is now defined in"},{"line_number":23,"context_line":"`cinder.yml` instead of the removed `all.yml`."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Effect:"},{"line_number":26,"context_line":"* glance-api runs with privileged: true"},{"line_number":27,"context_line":"* /dev is bind-mounted into the container"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"92cf9bd6_868b86c5","line":24,"range":{"start_line":20,"start_character":0,"end_line":24,"end_character":0},"in_reply_to":"bfbd497a_47c73f83","updated":"2025-10-01 01:46:14.000000000","message":"Thanks for the feedback! \nI agree this line is not strictly necessary. \nSince it\u0027s harmless and for clarification, I’ll leave it as is for now. \nMarking this as resolved.","commit_id":"a72c7bb3b5919ad56e679202af88702f78977739"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38392,"name":"KWAK JOONGKEE","display_name":"joongkeekwak","email":"kift23@gmail.com","username":"joongkeekwak"},"change_message_id":"ed491d073ed5ba731f8b1a5cf172871c02598c5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"359ee4f8_7ceffd95","updated":"2025-09-16 05:29:22.000000000","message":"All comments addressed in the latest patch set. Thanks a lot for your review!\nResolved as suggested, appreciate the thorough feedback.","commit_id":"6661729f7c8578fdcd62b291264bf3d6eb1e3b02"},{"author":{"_account_id":32688,"name":"Victor Chembaev","email":"chembervint@gmail.com","username":"chembervint"},"change_message_id":"7a5c9c6a0c94058d1dacf8dce9c0d723dec5eccb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9015d4eb_a0a54b6b","updated":"2025-09-23 12:08:26.000000000","message":"Do the same when enable_cinder_backend_iscsi enabled (c) https://review.opendev.org/c/openstack/kolla-ansible/+/854193","commit_id":"6661729f7c8578fdcd62b291264bf3d6eb1e3b02"},{"author":{"_account_id":38392,"name":"KWAK JOONGKEE","display_name":"joongkeekwak","email":"kift23@gmail.com","username":"joongkeekwak"},"change_message_id":"0e727f1f4c5c8956c159383ec77d96235a21863e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f331e349_10313105","updated":"2025-09-16 23:23:13.000000000","message":"Hi @mnasiadka,  \nall previous feedback from Maksim has been addressed and the patchset has been updated accordingly.  \nCould you please take a look and, if it looks good, provide +2 / Workflow approval?  \nThanks a lot for your time and review!","commit_id":"6661729f7c8578fdcd62b291264bf3d6eb1e3b02"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"daa7fdffbc7478a63d05e77aead90a66684f7f69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"98e60256_00eb3b60","updated":"2025-09-16 14:59:12.000000000","message":"nice. thanks.","commit_id":"6661729f7c8578fdcd62b291264bf3d6eb1e3b02"},{"author":{"_account_id":32688,"name":"Victor Chembaev","email":"chembervint@gmail.com","username":"chembervint"},"change_message_id":"3cb5bab6f35a4f4e9890dbc4a6d267c226a0e334","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"edfba63c_f3791459","in_reply_to":"2a48c965_a9547f56","updated":"2025-09-29 20:49:59.000000000","message":"Ok, LGTM","commit_id":"6661729f7c8578fdcd62b291264bf3d6eb1e3b02"},{"author":{"_account_id":38392,"name":"KWAK JOONGKEE","display_name":"joongkeekwak","email":"kift23@gmail.com","username":"joongkeekwak"},"change_message_id":"1f85eb19d2e0bec43d9fa12058571e734565ec85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2a48c965_a9547f56","in_reply_to":"9015d4eb_a0a54b6b","updated":"2025-09-24 11:13:48.000000000","message":"Thanks for the feedback, Victor.\n\nI understand your point — technically, enabling enable_cinder_backend_iscsi also results in the privileged container with /dev bind-mount, so it could work for other backends as well.\n\nHowever, the concern here is clarity and user experience for operators:\n\t•\tThe variable name enable_cinder_backend_iscsi strongly implies that it should only be used when an iSCSI backend is configured.\n\t•\tIn real deployments, we see other Cinder backends (PowerFlex/ScaleIO, FC, etc.) requiring the same privileged behavior via os-brick device access.\n\t•\tIf operators are forced to enable an iscsi option when they are actually deploying a non-iscsi backend, it introduces confusion and a high risk of misconfiguration.\n\nThat’s why I introduced a generic variable (enable_cinder_backend_privileged). It is more intuitive and covers all such backends in a consistent way.\n\nBy default, this variable is automatically set to yes when either iscsi or ceph backends are enabled, but it also allows operators to explicitly enable it for other backends without relying on an iscsi-named flag.\n\nSo the intent is not to duplicate the logic, but to provide a clearer and more generic option for operators.","commit_id":"6661729f7c8578fdcd62b291264bf3d6eb1e3b02"},{"author":{"_account_id":38392,"name":"KWAK JOONGKEE","display_name":"joongkeekwak","email":"kift23@gmail.com","username":"joongkeekwak"},"change_message_id":"1147d32632a715d5761443bdfa31722a1487cd53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"231ae74a_d3317c82","updated":"2025-09-30 00:31:42.000000000","message":"Hi, I\u0027ve rebased this change onto master and resolved the conflict caused by the\nsplit of group_vars/all.yml into per-service files.\n\nAs part of that, the default for `enable_cinder_backend_privileged` is now\ndefined in group_vars/all/cinder.yml instead of the removed all.yml.\n\nFunctionality is unchanged; this is only to follow the new group_vars structure.","commit_id":"a72c7bb3b5919ad56e679202af88702f78977739"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"aab185ed46840ecd92c2647d0b1fd5f700dc2202","unresolved":true,"context_lines":[{"line_number":1111,"context_line":"# Cinder options"},{"line_number":1112,"context_line":"#################################"},{"line_number":1113,"context_line":"cinder_backend_ceph: \"no\""},{"line_number":1114,"context_line":"enable_cinder_backend_powerflex : \"no\""},{"line_number":1115,"context_line":"cinder_backend_huawei: \"no\""},{"line_number":1116,"context_line":"cinder_backend_huawei_xml_files: []"},{"line_number":1117,"context_line":"cinder_volume_group: \"cinder-volumes\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1316295e_45661db6","line":1114,"updated":"2025-09-15 22:23:44.000000000","message":"The wrong place for this kind of variable, it should be placed near ``enable_cinder_backend_iscsi`` variable but alphabetically sorted.\nAnd, BTW, it\u0027s good to name it ``enable_cinder_backend_priveleged`` to attract means of usage instead of adding support for one more backend.\nDoing so it can be default to true if ``enable_cinder_backend_iscsi`` or ``cinder_backend_ceph`` enabled, this is also simplifies the code later.","commit_id":"456cff3f9a86394585c96d18c09a12c55bcd2c4c"},{"author":{"_account_id":38392,"name":"KWAK JOONGKEE","display_name":"joongkeekwak","email":"kift23@gmail.com","username":"joongkeekwak"},"change_message_id":"ed491d073ed5ba731f8b1a5cf172871c02598c5f","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"# Cinder options"},{"line_number":1112,"context_line":"#################################"},{"line_number":1113,"context_line":"cinder_backend_ceph: \"no\""},{"line_number":1114,"context_line":"enable_cinder_backend_powerflex : \"no\""},{"line_number":1115,"context_line":"cinder_backend_huawei: \"no\""},{"line_number":1116,"context_line":"cinder_backend_huawei_xml_files: []"},{"line_number":1117,"context_line":"cinder_volume_group: \"cinder-volumes\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"74470034_d6877140","line":1114,"in_reply_to":"1316295e_45661db6","updated":"2025-09-16 05:29:22.000000000","message":"Thanks, moved the new variable next to iscsi/nfs and aligned alphabetically.\nReordered according to your comment, now placed after nfs.","commit_id":"456cff3f9a86394585c96d18c09a12c55bcd2c4c"}],"ansible/roles/glance/defaults/main.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"aab185ed46840ecd92c2647d0b1fd5f700dc2202","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    enabled: true"},{"line_number":8,"context_line":"    image: \"{{ glance_api_image_full }}\""},{"line_number":9,"context_line":"    environment: \"{{ glance_api_container_proxy }}\""},{"line_number":10,"context_line":"    privileged: \"{{ enable_cinder | bool and (enable_cinder_backend_iscsi | bool or cinder_backend_ceph | bool or enable_cinder_backend_powerflex | bool) }}\""},{"line_number":11,"context_line":"    volumes: \"{{ glance_api_default_volumes + glance_api_extra_volumes }}\""},{"line_number":12,"context_line":"    dimensions: \"{{ glance_api_dimensions }}\""},{"line_number":13,"context_line":"    healthcheck: \"{{ glance_api_healthcheck }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5d16c483_102a8e71","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":157},"updated":"2025-09-15 22:23:44.000000000","message":"```suggestion\n    privileged: \"{{ enable_cinder | bool and enable_cinder_backend_priveleged | bool }}\"\n```","commit_id":"456cff3f9a86394585c96d18c09a12c55bcd2c4c"},{"author":{"_account_id":38392,"name":"KWAK JOONGKEE","display_name":"joongkeekwak","email":"kift23@gmail.com","username":"joongkeekwak"},"change_message_id":"ed491d073ed5ba731f8b1a5cf172871c02598c5f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    enabled: true"},{"line_number":8,"context_line":"    image: \"{{ glance_api_image_full }}\""},{"line_number":9,"context_line":"    environment: \"{{ glance_api_container_proxy }}\""},{"line_number":10,"context_line":"    privileged: \"{{ enable_cinder | bool and (enable_cinder_backend_iscsi | bool or cinder_backend_ceph | bool or enable_cinder_backend_powerflex | bool) }}\""},{"line_number":11,"context_line":"    volumes: \"{{ glance_api_default_volumes + glance_api_extra_volumes }}\""},{"line_number":12,"context_line":"    dimensions: \"{{ glance_api_dimensions }}\""},{"line_number":13,"context_line":"    healthcheck: \"{{ glance_api_healthcheck }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"32cff2dc_80a28a33","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":157},"in_reply_to":"5d16c483_102a8e71","updated":"2025-09-16 05:29:22.000000000","message":"Applied your suggestion to introduce a generic variable instead of backend-specific.\nUpdated to use enable_cinder_backend_privileged as recommended, much cleaner now.","commit_id":"456cff3f9a86394585c96d18c09a12c55bcd2c4c"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"aab185ed46840ecd92c2647d0b1fd5f700dc2202","unresolved":true,"context_lines":[{"line_number":207,"context_line":"  - \"{{ \u0027/dev/shm:/dev/shm\u0027 }}\""},{"line_number":208,"context_line":"  # NOTE(yoctozepto): below to support Cinder iSCSI backends"},{"line_number":209,"context_line":"  - \"{% if enable_cinder | bool and enable_cinder_backend_iscsi | bool %}iscsi_info:/etc/iscsi{% endif %}\""},{"line_number":210,"context_line":"  - \"{% if enable_cinder | bool and (enable_cinder_backend_iscsi | bool or enable_cinder_backend_powerflex | bool) %}/dev:/dev{% endif %}\""},{"line_number":211,"context_line":"glance_tls_proxy_default_volumes:"},{"line_number":212,"context_line":"  - \"{{ node_config_directory }}/glance-tls-proxy/:{{ container_config_directory }}/:ro\""},{"line_number":213,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9661098f_ac64c8e6","line":210,"range":{"start_line":210,"start_character":0,"end_line":210,"end_character":138},"updated":"2025-09-15 22:23:44.000000000","message":"```suggestion\n  - \"{% if enable_cinder | bool and enable_cinder_backend_priveleged | bool %}/dev:/dev{% endif %}\"\n```","commit_id":"456cff3f9a86394585c96d18c09a12c55bcd2c4c"},{"author":{"_account_id":38392,"name":"KWAK JOONGKEE","display_name":"joongkeekwak","email":"kift23@gmail.com","username":"joongkeekwak"},"change_message_id":"ed491d073ed5ba731f8b1a5cf172871c02598c5f","unresolved":false,"context_lines":[{"line_number":207,"context_line":"  - \"{{ \u0027/dev/shm:/dev/shm\u0027 }}\""},{"line_number":208,"context_line":"  # NOTE(yoctozepto): below to support Cinder iSCSI backends"},{"line_number":209,"context_line":"  - \"{% if enable_cinder | bool and enable_cinder_backend_iscsi | bool %}iscsi_info:/etc/iscsi{% endif %}\""},{"line_number":210,"context_line":"  - \"{% if enable_cinder | bool and (enable_cinder_backend_iscsi | bool or enable_cinder_backend_powerflex | bool) %}/dev:/dev{% endif %}\""},{"line_number":211,"context_line":"glance_tls_proxy_default_volumes:"},{"line_number":212,"context_line":"  - \"{{ node_config_directory }}/glance-tls-proxy/:{{ container_config_directory }}/:ro\""},{"line_number":213,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c5b97fbf_76d9bd84","line":210,"range":{"start_line":210,"start_character":0,"end_line":210,"end_character":138},"in_reply_to":"9661098f_ac64c8e6","updated":"2025-09-16 05:29:22.000000000","message":"Applied your suggestion to introduce a generic variable instead of backend-specific.\nUpdated to use enable_cinder_backend_privileged as recommended, much cleaner now.","commit_id":"456cff3f9a86394585c96d18c09a12c55bcd2c4c"}]}