)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"2b3538e7d8d5868fce7538c49e789ba6fa0b71fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f733d607_7827bfd1","updated":"2025-09-18 15:09:22.000000000","message":"Need backport to any branches that uses MariaDB 10","commit_id":"08f96332a472c6482cddbc1b90f6da28e7f468f8"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"0ea5c9168aa6e122ed9334f535d554d763d5c5eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a101600a_3daf895d","updated":"2025-09-24 16:07:49.000000000","message":"Thanks @seunghun@stackhpc.com - good bug report. The patch looks like it would work.\n\nI tried it out and hit another unrelated error starting the mariadb container relating to permissions. kolla_set_configs can\u0027t read config.json because of permissions, so the `Taking full database backup via Mariabackup` fails. Which makes we wonder if it\u0027s broken on master, or i\u0027m missing some patch.\n\nWould it be possible to add a basic CI scenario for backup/restore? Or I could propose something in another patch on top of this?","commit_id":"8f79f381a3ff32040f1c50f1dbc79041663697f2"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"c415774fe5f91c31e2ae9d480d77dff4bd5828e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bf2e2846_e46e304e","updated":"2025-09-19 11:18:27.000000000","message":"recheck","commit_id":"8f79f381a3ff32040f1c50f1dbc79041663697f2"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"2a55ace8e3e395434d2b0c01f00f0eeb91891ce3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"038d2282_6a278ac5","updated":"2025-09-23 09:35:45.000000000","message":"recheck suspecting inter-host connection problem","commit_id":"8f79f381a3ff32040f1c50f1dbc79041663697f2"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"16e08182472c26be7b6bf29c6375389a16e677b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"55b6c327_b2395349","in_reply_to":"0b70fb09_24a49a3b","updated":"2025-09-25 15:32:12.000000000","message":"Thank you","commit_id":"8f79f381a3ff32040f1c50f1dbc79041663697f2"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"9403aa31104592f08bf49dff61f3f9bb32409fa0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0b70fb09_24a49a3b","in_reply_to":"5e92525b_d67a7830","updated":"2025-09-25 12:38:40.000000000","message":"Yeah, not to worry, I filed a bug on it: https://bugs.launchpad.net/kolla-ansible/+bug/2125665\nI will fix in another patch.","commit_id":"8f79f381a3ff32040f1c50f1dbc79041663697f2"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"f61bcecd2528a1d4aab6df6c5616c8ea59ba5de7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5e92525b_d67a7830","in_reply_to":"a101600a_3daf895d","updated":"2025-09-25 09:40:00.000000000","message":"That backup failure sounds unrelated to this patch because ``kolla-ansible mariadb_backup`` does not use ``recover_cluster.yml``.\nHowever I agree we should have CI scenario that covers restoring DB from backup.\nI\u0027ll try adding that CI on this patch.","commit_id":"8f79f381a3ff32040f1c50f1dbc79041663697f2"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"2d1ac35d52b58a505fc1209647cfcd8d23cdc1b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"107f15d7_0ba19f06","updated":"2025-10-24 12:34:02.000000000","message":"recheck","commit_id":"d19b5cd78ad077cfda1b14f7dedff64ef2f21d9c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"b46972421f89ee0d73c914ad2ad9adc5d759340d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3de694c2_c652971a","updated":"2025-10-24 12:49:52.000000000","message":"recheck\n\n```\n       \"[00] 2025-10-24 12:04:30 Waiting for log copy thread to read lsn 80020\",\n        \"[00] 2025-10-24 12:04:31 Retrying read of log at LSN\u003d79906\",\n        \"[00] 2025-10-24 12:04:32 Retrying read of log at LSN\u003d79906\",\n        \"[00] 2025-10-24 12:04:33 Retrying read of log at LSN\u003d79906\",\n        \"[00] 2025-10-24 12:04:34 Retrying read of log at LSN\u003d79906\",\n        \"[00] 2025-10-24 12:04:35 Was only able to copy log from 71465 to 79906, not 80020; try increasing innodb_log_file_size\",\n        \"mariabackup: Stopping log copying thread.[00] 2025-10-24 12:04:36 Retrying read of log at LSN\u003d79906\",\n```\n\n^ It appears we may need to increase that. \n\nWe can try a patch like this in Kolla perhaps:\n\n```\ndiff --git a/docker/mariadb-server/backup_replica.sh b/docker/mariadb-server/backup_replica.sh\nindex ebdcbf6b0..bc15c94fe 100644\n--- a/docker/mariadb-server/backup_replica.sh\n+++ b/docker/mariadb-server/backup_replica.sh\n@@ -30,6 +30,7 @@ backup_full() {\n     mariabackup \\\n         --defaults-file\u003d\"${REPLICA_MY_CNF}\" \\\n         --backup \\\n+        --innodb-log-buffer-size\u003d1G\n         --stream\u003dmbstream \\\n         --history\u003d\"${LAST_FULL_DATE}\" \\\n         | gzip \u003e \"${BACKUP_PATH}/${BACKUP_FILE}\"\n@@ -59,6 +60,7 @@ backup_incremental() {\n     mariabackup \\\n         --defaults-file\u003d\"${REPLICA_MY_CNF}\" \\\n         --backup \\\n+        --innodb-log-buffer-size\u003d1G\n         --stream\u003dmbstream \\\n         --incremental-basedir\u003d\"${TMP_BASEDIR}\" \\\n         --history\u003d\"incr-${NOW}\" \\\n\n```","commit_id":"d19b5cd78ad077cfda1b14f7dedff64ef2f21d9c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"0ee8a4648a9146b86a070dfa3b27d8bbf6b177ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"118a7bf7_83278bf9","in_reply_to":"107f15d7_0ba19f06","updated":"2025-10-24 12:50:19.000000000","message":"sorry - missed that! I was looking at the failure","commit_id":"d19b5cd78ad077cfda1b14f7dedff64ef2f21d9c"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"5677445bb39ffcbb47e9b1e4c3731133ae984774","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"e5fba931_09d86637","in_reply_to":"3125c929_97d30670","updated":"2025-10-24 13:47:57.000000000","message":"Actually, based on the docs: https://mariadb.com/docs/server/server-usage/backup-and-restore/mariadb-backup/mariadb-backup-options#innodb-log-buffer-size the approach above at Kolla wouldn\u0027t work.\n\nLooks like we need to statically set the variable ``innodb_log_buffer_size`` under [mysqld] in ``galera.cnf`` in K-A instead.","commit_id":"d19b5cd78ad077cfda1b14f7dedff64ef2f21d9c"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"610118c3fff3adaa958e7bd00e42de220426a65c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3125c929_97d30670","in_reply_to":"3de694c2_c652971a","updated":"2025-10-24 13:05:12.000000000","message":"Yeah I noticed this problem. Until now, it didn\u0027t fail every time. But as the number of MariaDB test increased with Rocky 10, looks like it\u0027s now failing every time.\n\nI\u0027ll make a separate patch to increase the buffer size as you suggested.","commit_id":"d19b5cd78ad077cfda1b14f7dedff64ef2f21d9c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a796d67c5313655bb66cb8d1c2d723db86157696","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"dababbc7_9f2faa05","updated":"2025-10-24 15:51:19.000000000","message":"Nice work! just some minor tweaks.","commit_id":"6cd5b410e1cb297a761e50dd8b980a9baf3fb320"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"f1af204f05c8648d46f194d0ab960dccd199bd97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a452a2b9_a441547a","updated":"2025-10-27 11:54:41.000000000","message":"Looks good - great job Seunghun!\n\n\nSee the new test run here: https://zuul.opendev.org/t/openstack/build/b445d98a53b94f239da838081f11b076/log/primary/logs/ansible/test-mariadb#20157","commit_id":"151f6ccb21c32c0351fce53a4329700c6d3f80c1"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"851ee0f09354c152c606ba799097ecd8d9537695","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":14,"id":"6082744e_b5f22899","updated":"2025-10-27 12:24:44.000000000","message":"ps -a | grep mariadb can potentially catch some other container with that name, let\u0027s target directly mariadb container","commit_id":"151f6ccb21c32c0351fce53a4329700c6d3f80c1"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"bb44af5581885d3e1d0bc6eeaffe2f14d9da03e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"3b934dec_2d0a56b1","in_reply_to":"6082744e_b5f22899","updated":"2025-10-27 15:04:42.000000000","message":"Acknowledged","commit_id":"151f6ccb21c32c0351fce53a4329700c6d3f80c1"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"68feec8d471cfe0324a85a0ffa38f163bdecc048","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"b6e418fb_cedd4521","updated":"2025-10-29 16:08:35.000000000","message":"recheck","commit_id":"32318654b25b7b023362fb694d2f9184f18cc6a3"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"6999e73a9e7da1b6ef323cc611039305adf6437d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"e474e191_5fdbb8a5","updated":"2025-10-27 15:49:09.000000000","message":"recheck","commit_id":"32318654b25b7b023362fb694d2f9184f18cc6a3"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"9fca44e56ba1dcca0b75d9d77ced3f2a2cff0330","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c4bb0306_1922e92d","updated":"2025-10-27 16:38:16.000000000","message":"recheck\n\nThat\u0027s a pain, I see it\u0027s running with:\n\n```\ninnodb_buffer_pool_size \u003d 1024M\n```\n\nI guess there is more to do there.\n\nAnyway, not related to this patch","commit_id":"32318654b25b7b023362fb694d2f9184f18cc6a3"},{"author":{"_account_id":37313,"name":"MAILLET-CONTOZ Nicolas","display_name":"Nicolas MAILLET-CONTOZ","email":"nicolas.maillet-contoz@infomaniak.com","username":"nicolasmc","status":"Intern SRE at Infomaniak"},"change_message_id":"2cd47c097478bb55a8d707c9310f9ad532bdb372","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"389df207_0d3d97fd","updated":"2026-05-06 11:43:10.000000000","message":"recheck","commit_id":"afd49abfb86ebd145dfc11b70ebd307f44a54e7d"}],"ansible/roles/mariadb/tasks/recover_cluster.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"0ea5c9168aa6e122ed9334f535d554d763d5c5eb","unresolved":true,"context_lines":[{"line_number":152,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":153,"context_line":"    - \u0027\"You have to start server with --tc-heuristic-recover\" in latest_logs.stdout\u0027"},{"line_number":154,"context_line":"    - \u0027\"[ERROR] Aborting\" in latest_logs.stdout\u0027"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"- block:"},{"line_number":157,"context_line":"    - name: Boot first MariaDB container with --tc-heuristic-recover\u003drollback"},{"line_number":158,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"376f0ba0_42c6e1ce","line":155,"updated":"2025-09-24 16:07:49.000000000","message":"What do you think about stopping here, and telling the user that they have probably hit https://jira.mariadb.org/browse/MDEV-37663. If they want to continue, then they have to set `mariadb_attempt_tc_heuristic_recover\u003dtrue` and re-run the recover?\n\nIt would help keep track of the bug, and make it clear that a clean restore is not possible, and we must use crash recovery. There is potential for corruption.","commit_id":"8f79f381a3ff32040f1c50f1dbc79041663697f2"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"16e08182472c26be7b6bf29c6375389a16e677b5","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":153,"context_line":"    - \u0027\"You have to start server with --tc-heuristic-recover\" in latest_logs.stdout\u0027"},{"line_number":154,"context_line":"    - \u0027\"[ERROR] Aborting\" in latest_logs.stdout\u0027"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"- block:"},{"line_number":157,"context_line":"    - name: Boot first MariaDB container with --tc-heuristic-recover\u003drollback"},{"line_number":158,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"15d403d4_268af766","line":155,"in_reply_to":"235177b8_0b187e18","updated":"2025-09-25 15:32:12.000000000","message":"I see. Yeah that would work.\n\nIt would be nice if we can have pre-defined DB for each cases but the problem is I don\u0027t know how to reproduce it consistently. Maybe make DB busy while taking a backup would guarantee backup to have pending transaction?\n\nBut as you said, this is also a maintenance effort.","commit_id":"8f79f381a3ff32040f1c50f1dbc79041663697f2"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"2cb9bb118f5d26a7c1d24a12690e7efa06e9279a","unresolved":true,"context_lines":[{"line_number":152,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":153,"context_line":"    - \u0027\"You have to start server with --tc-heuristic-recover\" in latest_logs.stdout\u0027"},{"line_number":154,"context_line":"    - \u0027\"[ERROR] Aborting\" in latest_logs.stdout\u0027"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"- block:"},{"line_number":157,"context_line":"    - name: Boot first MariaDB container with --tc-heuristic-recover\u003drollback"},{"line_number":158,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b8dd1b8a_7c41b803","line":155,"in_reply_to":"34490cac_b77b8746","updated":"2025-09-25 11:02:40.000000000","message":"On a second thought related to your comment, if we split these steps, so operators need to run it manually twice, how should we implement CI?","commit_id":"8f79f381a3ff32040f1c50f1dbc79041663697f2"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"f61bcecd2528a1d4aab6df6c5616c8ea59ba5de7","unresolved":true,"context_lines":[{"line_number":152,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":153,"context_line":"    - \u0027\"You have to start server with --tc-heuristic-recover\" in latest_logs.stdout\u0027"},{"line_number":154,"context_line":"    - \u0027\"[ERROR] Aborting\" in latest_logs.stdout\u0027"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"- block:"},{"line_number":157,"context_line":"    - name: Boot first MariaDB container with --tc-heuristic-recover\u003drollback"},{"line_number":158,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"34490cac_b77b8746","line":155,"in_reply_to":"376f0ba0_42c6e1ce","updated":"2025-09-25 09:40:00.000000000","message":"Sounds good. That\u0027ll actually helpful for operators to track what went wrong.","commit_id":"8f79f381a3ff32040f1c50f1dbc79041663697f2"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"9403aa31104592f08bf49dff61f3f9bb32409fa0","unresolved":true,"context_lines":[{"line_number":152,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":153,"context_line":"    - \u0027\"You have to start server with --tc-heuristic-recover\" in latest_logs.stdout\u0027"},{"line_number":154,"context_line":"    - \u0027\"[ERROR] Aborting\" in latest_logs.stdout\u0027"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"- block:"},{"line_number":157,"context_line":"    - name: Boot first MariaDB container with --tc-heuristic-recover\u003drollback"},{"line_number":158,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"235177b8_0b187e18","line":155,"in_reply_to":"b8dd1b8a_7c41b803","updated":"2025-09-25 12:38:40.000000000","message":"A good question - you could set the override flag in CI, so if the issue happens, the recovery will automatically run? The task to stop the playbook continuing if the override flag is not set is simple enough to not need testing.\n\nIt would be nice to make the test fully reproducible. I was thinking you could have pre-prepared DB backups; one with pending transactions, and one without, but it will be an overhead to maintain those. Eg. when the DB schema gets updated. Probably not worth the effort.\n\nI think just running a simple backup/restore operation in CI would be enough?","commit_id":"8f79f381a3ff32040f1c50f1dbc79041663697f2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6c3e51dbd4c86f1bc552030edd587d387556606f","unresolved":true,"context_lines":[{"line_number":165,"context_line":"    msg: Your database is probably affected by MariaDB bug https://jira.mariadb.org/browse/MDEV-37663"},{"line_number":166,"context_line":"         and needs tc-heuristic-recovery first."},{"line_number":167,"context_line":"         To perform the recovery, run the database recovery command again with extra variable"},{"line_number":168,"context_line":"         ``mariadb_attempt_tc_heuristic_recover\u003dtrue`` set."},{"line_number":169,"context_line":"  when:"},{"line_number":170,"context_line":"    - bootstrap_host is defined"},{"line_number":171,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"26a57de5_7dd133cd","line":168,"updated":"2025-10-23 08:25:40.000000000","message":"I think we need to be more specific, some users might not know that they need to use -e ;-)\nWe might also want to add this to the docs - see https://docs.openstack.org/kolla-ansible/latest/admin/mariadb-backup-and-restore.html","commit_id":"7c14b37d95183c1b05598f48b12e1ce0176d51df"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"35ed6f303038fea47eee15acdf6d185ca652537c","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    msg: Your database is probably affected by MariaDB bug https://jira.mariadb.org/browse/MDEV-37663"},{"line_number":166,"context_line":"         and needs tc-heuristic-recovery first."},{"line_number":167,"context_line":"         To perform the recovery, run the database recovery command again with extra variable"},{"line_number":168,"context_line":"         ``mariadb_attempt_tc_heuristic_recover\u003dtrue`` set."},{"line_number":169,"context_line":"  when:"},{"line_number":170,"context_line":"    - bootstrap_host is defined"},{"line_number":171,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ea8ab221_9ae94b39","line":168,"in_reply_to":"26a57de5_7dd133cd","updated":"2025-10-24 11:43:03.000000000","message":"Done","commit_id":"7c14b37d95183c1b05598f48b12e1ce0176d51df"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a796d67c5313655bb66cb8d1c2d723db86157696","unresolved":true,"context_lines":[{"line_number":127,"context_line":"  when:"},{"line_number":128,"context_line":"    - bootstrap_host is defined"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"- name: \"Starting first MariaDB container {{ \u0027with tc-heuristic-recovery\u0027 if mariadb_attempt_tc_heuristic_recover is defined and mariadb_attempt_tc_heuristic_recover }}\""},{"line_number":131,"context_line":"  become: true"},{"line_number":132,"context_line":"  kolla_container:"},{"line_number":133,"context_line":"    action: \"start_container\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"abe3985e_0aa64eb8","line":130,"range":{"start_line":130,"start_character":129,"end_line":130,"end_character":165},"updated":"2025-10-24 15:51:19.000000000","message":"Please can  you amend this to avoid the implicit boolean conversion? This is useful for the upgrade to Ansible 12:\n\nhttps://docs.ansible.com/ansible/latest/porting_guides/porting_guide_12.html#example-implicit-boolean-conversion\n\nie. `mariadb_attempt_tc_heuristic_recover | bool`","commit_id":"6cd5b410e1cb297a761e50dd8b980a9baf3fb320"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"dfd5a2f4bf1a71cd70f5c82b004883e357ff148e","unresolved":false,"context_lines":[{"line_number":127,"context_line":"  when:"},{"line_number":128,"context_line":"    - bootstrap_host is defined"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"- name: \"Starting first MariaDB container {{ \u0027with tc-heuristic-recovery\u0027 if mariadb_attempt_tc_heuristic_recover is defined and mariadb_attempt_tc_heuristic_recover }}\""},{"line_number":131,"context_line":"  become: true"},{"line_number":132,"context_line":"  kolla_container:"},{"line_number":133,"context_line":"    action: \"start_container\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"9970ae0c_2e1892b9","line":130,"range":{"start_line":130,"start_character":129,"end_line":130,"end_character":165},"in_reply_to":"abe3985e_0aa64eb8","updated":"2025-10-24 15:56:36.000000000","message":"Done","commit_id":"6cd5b410e1cb297a761e50dd8b980a9baf3fb320"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a796d67c5313655bb66cb8d1c2d723db86157696","unresolved":true,"context_lines":[{"line_number":134,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":135,"context_line":"    environment:"},{"line_number":136,"context_line":"      KOLLA_CONFIG_STRATEGY: \"{{ config_strategy }}\""},{"line_number":137,"context_line":"      BOOTSTRAP_ARGS: \"--wsrep-new-cluster {% if mariadb_attempt_tc_heuristic_recover is defined and mariadb_attempt_tc_heuristic_recover %}--tc-heuristic-recover\u003drollback{% endif %}\""},{"line_number":138,"context_line":"    image: \"{{ mariadb_service.image }}\""},{"line_number":139,"context_line":"    labels:"},{"line_number":140,"context_line":"      BOOTSTRAP:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"6a215046_4d548385","line":137,"updated":"2025-10-24 15:51:19.000000000","message":"same here, please add `| bool`","commit_id":"6cd5b410e1cb297a761e50dd8b980a9baf3fb320"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"dfd5a2f4bf1a71cd70f5c82b004883e357ff148e","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":135,"context_line":"    environment:"},{"line_number":136,"context_line":"      KOLLA_CONFIG_STRATEGY: \"{{ config_strategy }}\""},{"line_number":137,"context_line":"      BOOTSTRAP_ARGS: \"--wsrep-new-cluster {% if mariadb_attempt_tc_heuristic_recover is defined and mariadb_attempt_tc_heuristic_recover %}--tc-heuristic-recover\u003drollback{% endif %}\""},{"line_number":138,"context_line":"    image: \"{{ mariadb_service.image }}\""},{"line_number":139,"context_line":"    labels:"},{"line_number":140,"context_line":"      BOOTSTRAP:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"2521c8a5_87f7fadb","line":137,"in_reply_to":"6a215046_4d548385","updated":"2025-10-24 15:56:36.000000000","message":"Done","commit_id":"6cd5b410e1cb297a761e50dd8b980a9baf3fb320"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a796d67c5313655bb66cb8d1c2d723db86157696","unresolved":true,"context_lines":[{"line_number":169,"context_line":"  when:"},{"line_number":170,"context_line":"    - bootstrap_host is defined"},{"line_number":171,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":172,"context_line":"    - not (mariadb_attempt_tc_heuristic_recover is defined and mariadb_attempt_tc_heuristic_recover)"},{"line_number":173,"context_line":"    - \u0027\"You have to start server with --tc-heuristic-recover\" in latest_logs.stdout\u0027"},{"line_number":174,"context_line":"    - \u0027\"[ERROR] Aborting\" in latest_logs.stdout\u0027"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"2029ecb7_f25ff556","line":172,"updated":"2025-10-24 15:51:19.000000000","message":"|bool here too","commit_id":"6cd5b410e1cb297a761e50dd8b980a9baf3fb320"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"dfd5a2f4bf1a71cd70f5c82b004883e357ff148e","unresolved":false,"context_lines":[{"line_number":169,"context_line":"  when:"},{"line_number":170,"context_line":"    - bootstrap_host is defined"},{"line_number":171,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":172,"context_line":"    - not (mariadb_attempt_tc_heuristic_recover is defined and mariadb_attempt_tc_heuristic_recover)"},{"line_number":173,"context_line":"    - \u0027\"You have to start server with --tc-heuristic-recover\" in latest_logs.stdout\u0027"},{"line_number":174,"context_line":"    - \u0027\"[ERROR] Aborting\" in latest_logs.stdout\u0027"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"35994c71_62285aee","line":172,"in_reply_to":"2029ecb7_f25ff556","updated":"2025-10-24 15:56:36.000000000","message":"Done","commit_id":"6cd5b410e1cb297a761e50dd8b980a9baf3fb320"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a796d67c5313655bb66cb8d1c2d723db86157696","unresolved":true,"context_lines":[{"line_number":195,"context_line":"        volumes: \"{{ mariadb_service.volumes }}\""},{"line_number":196,"context_line":"  when:"},{"line_number":197,"context_line":"    - mariadb_attempt_tc_heuristic_recover is defined"},{"line_number":198,"context_line":"    - mariadb_attempt_tc_heuristic_recover"},{"line_number":199,"context_line":"    - bootstrap_host is defined"},{"line_number":200,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"578f8782_662b0fec","line":198,"updated":"2025-10-24 15:51:19.000000000","message":"| bool","commit_id":"6cd5b410e1cb297a761e50dd8b980a9baf3fb320"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"dfd5a2f4bf1a71cd70f5c82b004883e357ff148e","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        volumes: \"{{ mariadb_service.volumes }}\""},{"line_number":196,"context_line":"  when:"},{"line_number":197,"context_line":"    - mariadb_attempt_tc_heuristic_recover is defined"},{"line_number":198,"context_line":"    - mariadb_attempt_tc_heuristic_recover"},{"line_number":199,"context_line":"    - bootstrap_host is defined"},{"line_number":200,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1b7c21e2_36a8baa5","line":198,"in_reply_to":"578f8782_662b0fec","updated":"2025-10-24 15:56:36.000000000","message":"Done","commit_id":"6cd5b410e1cb297a761e50dd8b980a9baf3fb320"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"2d8e197af4270d186342631df7b468fe0e3fea15","unresolved":true,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"- name: Get latest logs"},{"line_number":156,"context_line":"  become: true"},{"line_number":157,"context_line":"  command: tail -n 5 /var/log/kolla/mariadb/mariadb.log"},{"line_number":158,"context_line":"  register: latest_logs"},{"line_number":159,"context_line":"  when:"},{"line_number":160,"context_line":"    - bootstrap_host is defined"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"b5a3da5e_79a10231","line":157,"updated":"2025-10-27 12:32:23.000000000","message":"is 5 lines enough in all cases? for instance on busy nodes?","commit_id":"151f6ccb21c32c0351fce53a4329700c6d3f80c1"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"3c3566b9247054c5ee07c29a648a30b65e8bfea3","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"- name: Get latest logs"},{"line_number":156,"context_line":"  become: true"},{"line_number":157,"context_line":"  command: tail -n 5 /var/log/kolla/mariadb/mariadb.log"},{"line_number":158,"context_line":"  register: latest_logs"},{"line_number":159,"context_line":"  when:"},{"line_number":160,"context_line":"    - bootstrap_host is defined"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"de71323b_77249436","line":157,"in_reply_to":"5af4b2bd_d24b733b","updated":"2025-10-27 15:05:55.000000000","message":"Acknowledged","commit_id":"151f6ccb21c32c0351fce53a4329700c6d3f80c1"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"a14f8b4f5d0c3bf5f5eb7a9437be843edfb4bf45","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"- name: Get latest logs"},{"line_number":156,"context_line":"  become: true"},{"line_number":157,"context_line":"  command: tail -n 5 /var/log/kolla/mariadb/mariadb.log"},{"line_number":158,"context_line":"  register: latest_logs"},{"line_number":159,"context_line":"  when:"},{"line_number":160,"context_line":"    - bootstrap_host is defined"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"b219ae6d_5f6136d5","line":157,"in_reply_to":"6f2ccbe1_bc084a4f","updated":"2026-05-07 08:43:04.000000000","message":"Done","commit_id":"151f6ccb21c32c0351fce53a4329700c6d3f80c1"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"d44fadde53beeeefde0c6dd5d3b265ee2f768b0e","unresolved":true,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"- name: Get latest logs"},{"line_number":156,"context_line":"  become: true"},{"line_number":157,"context_line":"  command: tail -n 5 /var/log/kolla/mariadb/mariadb.log"},{"line_number":158,"context_line":"  register: latest_logs"},{"line_number":159,"context_line":"  when:"},{"line_number":160,"context_line":"    - bootstrap_host is defined"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"6f2ccbe1_bc084a4f","line":157,"in_reply_to":"8ec6d808_b9dbc538","updated":"2026-01-26 10:22:51.000000000","message":"10 seconds?","commit_id":"151f6ccb21c32c0351fce53a4329700c6d3f80c1"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"bb44af5581885d3e1d0bc6eeaffe2f14d9da03e1","unresolved":true,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"- name: Get latest logs"},{"line_number":156,"context_line":"  become: true"},{"line_number":157,"context_line":"  command: tail -n 5 /var/log/kolla/mariadb/mariadb.log"},{"line_number":158,"context_line":"  register: latest_logs"},{"line_number":159,"context_line":"  when:"},{"line_number":160,"context_line":"    - bootstrap_host is defined"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"5af4b2bd_d24b733b","line":157,"in_reply_to":"b5a3da5e_79a10231","updated":"2025-10-27 15:04:42.000000000","message":"If MariaDB detects the pending transaction problem, it immediately. No more messages are logged after \"[ERROR] Aborting\". So, I think it\u0027s enough.","commit_id":"151f6ccb21c32c0351fce53a4329700c6d3f80c1"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"5e2e2c3f9175a275d478703c90746e9089e4aea2","unresolved":true,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"- name: Get latest logs"},{"line_number":156,"context_line":"  become: true"},{"line_number":157,"context_line":"  command: tail -n 5 /var/log/kolla/mariadb/mariadb.log"},{"line_number":158,"context_line":"  register: latest_logs"},{"line_number":159,"context_line":"  when:"},{"line_number":160,"context_line":"    - bootstrap_host is defined"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"8ec6d808_b9dbc538","line":157,"in_reply_to":"de71323b_77249436","updated":"2026-01-26 10:21:27.000000000","message":"so if that log comes up immediately, maybe we don\u0027t need to wait 1 minute every time doing bootstrap?","commit_id":"151f6ccb21c32c0351fce53a4329700c6d3f80c1"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"2d8e197af4270d186342631df7b468fe0e3fea15","unresolved":true,"context_lines":[{"line_number":155,"context_line":"- name: Get latest logs"},{"line_number":156,"context_line":"  become: true"},{"line_number":157,"context_line":"  command: tail -n 5 /var/log/kolla/mariadb/mariadb.log"},{"line_number":158,"context_line":"  register: latest_logs"},{"line_number":159,"context_line":"  when:"},{"line_number":160,"context_line":"    - bootstrap_host is defined"},{"line_number":161,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"771eb95d_863d6b8b","line":158,"updated":"2025-10-27 12:32:23.000000000","message":"changed_when: false is nice on those raw commands","commit_id":"151f6ccb21c32c0351fce53a4329700c6d3f80c1"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"19b8084b03ba819fbedffa908eb5e1c567c7ac18","unresolved":false,"context_lines":[{"line_number":155,"context_line":"- name: Get latest logs"},{"line_number":156,"context_line":"  become: true"},{"line_number":157,"context_line":"  command: tail -n 5 /var/log/kolla/mariadb/mariadb.log"},{"line_number":158,"context_line":"  register: latest_logs"},{"line_number":159,"context_line":"  when:"},{"line_number":160,"context_line":"    - bootstrap_host is defined"},{"line_number":161,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3052ccf5_e112c281","line":158,"in_reply_to":"771eb95d_863d6b8b","updated":"2025-10-27 15:07:47.000000000","message":"Done","commit_id":"151f6ccb21c32c0351fce53a4329700c6d3f80c1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6206b8bf9cb85ca9a5003379cc2761bbae6f6d0e","unresolved":true,"context_lines":[{"line_number":145,"context_line":"    - bootstrap_host is defined"},{"line_number":146,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"- name: Wait 1 minute before checking logs"},{"line_number":149,"context_line":"  pause:"},{"line_number":150,"context_line":"    minutes: 1"},{"line_number":151,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"3d4d65b4_750e2a62","line":148,"updated":"2026-01-26 11:08:18.000000000","message":"This whole path looks extremely brittle, can we just document that issue and allow people to set some magic flag to get tc heuristic recovery?","commit_id":"eaa41528c21e14552cbf87e238425bc62528772f"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"2d11a7cda156d2bcfd0946fbc44aafc305c33d38","unresolved":true,"context_lines":[{"line_number":145,"context_line":"    - bootstrap_host is defined"},{"line_number":146,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"- name: Wait 1 minute before checking logs"},{"line_number":149,"context_line":"  pause:"},{"line_number":150,"context_line":"    minutes: 1"},{"line_number":151,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"a1aefa46_6ed7bdc6","line":148,"in_reply_to":"3d4d65b4_750e2a62","updated":"2026-03-06 16:09:35.000000000","message":"That actually sounds better. I\u0027ll make some changes","commit_id":"eaa41528c21e14552cbf87e238425bc62528772f"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"b1f262899d3b135e8b17021cd3bd7f76db5be9ec","unresolved":true,"context_lines":[{"line_number":145,"context_line":"    - bootstrap_host is defined"},{"line_number":146,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"- name: Wait 1 minute before checking logs"},{"line_number":149,"context_line":"  pause:"},{"line_number":150,"context_line":"    minutes: 1"},{"line_number":151,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"a9efd1b7_8b649af1","line":148,"in_reply_to":"77a7de7d_35f4f569","updated":"2026-03-12 17:00:00.000000000","message":"Split to https://review.opendev.org/c/openstack/kolla-ansible/+/980323","commit_id":"eaa41528c21e14552cbf87e238425bc62528772f"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"9803fccd383190a37994c483b3d41ef74da997fd","unresolved":true,"context_lines":[{"line_number":145,"context_line":"    - bootstrap_host is defined"},{"line_number":146,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"- name: Wait 1 minute before checking logs"},{"line_number":149,"context_line":"  pause:"},{"line_number":150,"context_line":"    minutes: 1"},{"line_number":151,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"77a7de7d_35f4f569","line":148,"in_reply_to":"a1aefa46_6ed7bdc6","updated":"2026-03-12 16:54:11.000000000","message":"As the heuristic recovery is no longer automatic, the CI test is going to fail with the flag on (This recovery needs one restart with the flag on then another without the flag). We don\u0027t know if this flag\u0027s gonna be needed or not. It depends on if the mariabackup did a good job on handling transactions during backup. So, I\u0027ll split the CI test part into separate patch.","commit_id":"eaa41528c21e14552cbf87e238425bc62528772f"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"a14f8b4f5d0c3bf5f5eb7a9437be843edfb4bf45","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    - bootstrap_host is defined"},{"line_number":146,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"- name: Wait 1 minute before checking logs"},{"line_number":149,"context_line":"  pause:"},{"line_number":150,"context_line":"    minutes: 1"},{"line_number":151,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"61a54802_5e8b9bb7","line":148,"in_reply_to":"a9efd1b7_8b649af1","updated":"2026-05-07 08:43:04.000000000","message":"Done","commit_id":"eaa41528c21e14552cbf87e238425bc62528772f"},{"author":{"_account_id":37313,"name":"MAILLET-CONTOZ Nicolas","display_name":"Nicolas MAILLET-CONTOZ","email":"nicolas.maillet-contoz@infomaniak.com","username":"nicolasmc","status":"Intern SRE at Infomaniak"},"change_message_id":"2cd47c097478bb55a8d707c9310f9ad532bdb372","unresolved":true,"context_lines":[{"line_number":194,"context_line":"             setting mariadb_tc_heuristic_recover\u003dtrue."},{"line_number":195,"context_line":"      run_once: true"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    - meta: end_play"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"- name: Wait for first MariaDB container"},{"line_number":200,"context_line":"  wait_for:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"d6214d4b_992a16b2","line":197,"updated":"2026-05-06 11:43:10.000000000","message":"`name` should be added here","commit_id":"afd49abfb86ebd145dfc11b70ebd307f44a54e7d"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"a14f8b4f5d0c3bf5f5eb7a9437be843edfb4bf45","unresolved":false,"context_lines":[{"line_number":194,"context_line":"             setting mariadb_tc_heuristic_recover\u003dtrue."},{"line_number":195,"context_line":"      run_once: true"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    - meta: end_play"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"- name: Wait for first MariaDB container"},{"line_number":200,"context_line":"  wait_for:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"15f45a0f_f840efe1","line":197,"in_reply_to":"d6214d4b_992a16b2","updated":"2026-05-07 08:43:04.000000000","message":"Done","commit_id":"afd49abfb86ebd145dfc11b70ebd307f44a54e7d"}],"tests/test-mariadb.sh":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"851ee0f09354c152c606ba799097ecd8d9537695","unresolved":true,"context_lines":[{"line_number":78,"context_line":"}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"function prepare_restore_backup {"},{"line_number":81,"context_line":"    MARIADB_IMAGE\u003d$(sudo $container_engine ps -a | grep mariadb | awk \u0027{print $2}\u0027)"},{"line_number":82,"context_line":"    sudo $container_engine run --rm -it --detach --volumes-from mariadb --name dbrestore \\"},{"line_number":83,"context_line":"    --volume mariadb_backup:/backup \\"},{"line_number":84,"context_line":"    $MARIADB_IMAGE \\"}],"source_content_type":"text/x-sh","patch_set":14,"id":"305be066_a0a97b3d","line":81,"updated":"2025-10-27 12:24:44.000000000","message":"```suggestion\n    MARIADB_IMAGE\u003d$(sudo $container_engine inspect --format \u0027{{.Config.Image}}\u0027 mariadb)\n```","commit_id":"151f6ccb21c32c0351fce53a4329700c6d3f80c1"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"19b8084b03ba819fbedffa908eb5e1c567c7ac18","unresolved":false,"context_lines":[{"line_number":78,"context_line":"}"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"function prepare_restore_backup {"},{"line_number":81,"context_line":"    MARIADB_IMAGE\u003d$(sudo $container_engine ps -a | grep mariadb | awk \u0027{print $2}\u0027)"},{"line_number":82,"context_line":"    sudo $container_engine run --rm -it --detach --volumes-from mariadb --name dbrestore \\"},{"line_number":83,"context_line":"    --volume mariadb_backup:/backup \\"},{"line_number":84,"context_line":"    $MARIADB_IMAGE \\"}],"source_content_type":"text/x-sh","patch_set":14,"id":"48a65b1d_7c165655","line":81,"in_reply_to":"305be066_a0a97b3d","updated":"2025-10-27 15:07:47.000000000","message":"Done","commit_id":"151f6ccb21c32c0351fce53a4329700c6d3f80c1"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"851ee0f09354c152c606ba799097ecd8d9537695","unresolved":true,"context_lines":[{"line_number":92,"context_line":"}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"function restore_backup {"},{"line_number":95,"context_line":"    MARIADB_IMAGE\u003d$(sudo $container_engine ps -a | grep mariadb | awk \u0027{print $2}\u0027)"},{"line_number":96,"context_line":"    sudo $container_engine run --rm -it --detach --volumes-from mariadb --name dbrestore \\"},{"line_number":97,"context_line":"    --volume mariadb_backup:/backup \\"},{"line_number":98,"context_line":"    $MARIADB_IMAGE \\"}],"source_content_type":"text/x-sh","patch_set":14,"id":"906f5fe5_1b137d84","line":95,"updated":"2025-10-27 12:24:44.000000000","message":"```suggestion\n    MARIADB_IMAGE\u003d$(sudo $container_engine inspect --format \u0027{{.Config.Image}}\u0027 mariadb)\n```","commit_id":"151f6ccb21c32c0351fce53a4329700c6d3f80c1"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"19b8084b03ba819fbedffa908eb5e1c567c7ac18","unresolved":false,"context_lines":[{"line_number":92,"context_line":"}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"function restore_backup {"},{"line_number":95,"context_line":"    MARIADB_IMAGE\u003d$(sudo $container_engine ps -a | grep mariadb | awk \u0027{print $2}\u0027)"},{"line_number":96,"context_line":"    sudo $container_engine run --rm -it --detach --volumes-from mariadb --name dbrestore \\"},{"line_number":97,"context_line":"    --volume mariadb_backup:/backup \\"},{"line_number":98,"context_line":"    $MARIADB_IMAGE \\"}],"source_content_type":"text/x-sh","patch_set":14,"id":"ebbdafd0_2cfe3c6e","line":95,"in_reply_to":"906f5fe5_1b137d84","updated":"2025-10-27 15:07:47.000000000","message":"Done","commit_id":"151f6ccb21c32c0351fce53a4329700c6d3f80c1"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"f1af204f05c8648d46f194d0ab960dccd199bd97","unresolved":true,"context_lines":[{"line_number":118,"context_line":"function test_mariadb_logged {"},{"line_number":119,"context_line":"    RAW_INVENTORY\u003d/etc/kolla/inventory"},{"line_number":120,"context_line":"    source $KOLLA_ANSIBLE_VENV_PATH/bin/activate"},{"line_number":121,"context_line":"    test_backup_with_retries"},{"line_number":122,"context_line":"    test_recovery"},{"line_number":123,"context_line":"    test_db_restore_from_backup"},{"line_number":124,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":14,"id":"76ce50b4_1889f0fb","line":121,"updated":"2025-10-27 11:54:41.000000000","message":"`test_db_restore_from_backup` is almost duplicating l121 and l122 now. I suppose we could consider removing them, but the job isn\u0027t taking that long at least.","commit_id":"151f6ccb21c32c0351fce53a4329700c6d3f80c1"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"67573786dc62e322e504a42d11249744f6acf821","unresolved":false,"context_lines":[{"line_number":118,"context_line":"function test_mariadb_logged {"},{"line_number":119,"context_line":"    RAW_INVENTORY\u003d/etc/kolla/inventory"},{"line_number":120,"context_line":"    source $KOLLA_ANSIBLE_VENV_PATH/bin/activate"},{"line_number":121,"context_line":"    test_backup_with_retries"},{"line_number":122,"context_line":"    test_recovery"},{"line_number":123,"context_line":"    test_db_restore_from_backup"},{"line_number":124,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":14,"id":"a131adac_2c379ec8","line":121,"in_reply_to":"76ce50b4_1889f0fb","updated":"2026-01-23 13:34:37.000000000","message":"Removed them","commit_id":"151f6ccb21c32c0351fce53a4329700c6d3f80c1"}]}