)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"84949d1e2f3e9690293860efefd9696e182c6144","unresolved":true,"context_lines":[{"line_number":9,"context_line":"MariaDB Clustercheck has not been updated for a long time and ProxySQL"},{"line_number":10,"context_line":"has been working well as the default."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Dropped DB Loadbalancing with HAProxy abd MariaDB clustercheck support and"},{"line_number":13,"context_line":"ProxySQL now gets enabled automatically when MariaDB is enabled."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Replaced MariaDB container healthcheck method with healthcheck.sh from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"4cd800d3_2a532ed1","line":12,"updated":"2025-10-08 12:32:19.000000000","message":"typo: and","commit_id":"bd6bf4eb3fbce58f4750390a5e70ecd337c123fb"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"be557664150a0a501e77d4f4227aaf952437a30e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"MariaDB Clustercheck has not been updated for a long time and ProxySQL"},{"line_number":10,"context_line":"has been working well as the default."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Dropped DB Loadbalancing with HAProxy abd MariaDB clustercheck support and"},{"line_number":13,"context_line":"ProxySQL now gets enabled automatically when MariaDB is enabled."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Replaced MariaDB container healthcheck method with healthcheck.sh from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"40bb1c0b_e7218086","line":12,"in_reply_to":"4cd800d3_2a532ed1","updated":"2025-10-08 13:12:25.000000000","message":"Done","commit_id":"bd6bf4eb3fbce58f4750390a5e70ecd337c123fb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7edd7cf31e4f3a364ceac9525b9326e1a3f7e490","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8975e904_3cf0d4b5","updated":"2025-09-29 10:28:50.000000000","message":"We need an upgrade task that will remove clustercheck container","commit_id":"77b9588defcb86ccc4c1c9afdb051da442b4529c"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"ce27031c4484621ded4607660f8110cfeda7b193","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d77063f1_6763bba4","in_reply_to":"5562fca2_bc84b550","updated":"2025-10-01 09:02:35.000000000","message":"Done","commit_id":"77b9588defcb86ccc4c1c9afdb051da442b4529c"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"16a20b6bb917ff798c8b5a8e9f58986c8fe82591","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5562fca2_bc84b550","in_reply_to":"8975e904_3cf0d4b5","updated":"2025-09-29 10:29:43.000000000","message":"Ah that\u0027s true. I\u0027ll add that too","commit_id":"77b9588defcb86ccc4c1c9afdb051da442b4529c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"db4890b82acf0258fd1e14d11bb0906c6bb3445b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d64ee622_4d704df2","updated":"2025-10-01 13:17:30.000000000","message":"Don\u0027t we need to remove any haproxy configs?","commit_id":"ff4c8a347dbb560f7e4a2607c1b07eac946834b8"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"85bfc21487d94b6e1fab853845d0f47c600a4d43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"094ba164_145c5db9","updated":"2025-10-01 11:13:39.000000000","message":"recheck","commit_id":"ff4c8a347dbb560f7e4a2607c1b07eac946834b8"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"109ed4692d3dc2b3655982ac5d1a3d3ca7478296","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8daf3f9f_c4f4d474","in_reply_to":"11d140b4_c98cc480","updated":"2025-10-06 14:12:27.000000000","message":"Ah right, missed that.","commit_id":"ff4c8a347dbb560f7e4a2607c1b07eac946834b8"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"dada18259785d564075f0c2f3969a312d39eed0c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"11d140b4_c98cc480","in_reply_to":"84550867_58a7f1da","updated":"2025-10-06 14:03:38.000000000","message":"Isn\u0027t that already handled by https://opendev.org/openstack/kolla-ansible/src/commit/59b8253fbe639709b10c666566ccb8092431161d/ansible/roles/loadbalancer/tasks/config.yml#L51-L60 ?","commit_id":"ff4c8a347dbb560f7e4a2607c1b07eac946834b8"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"ab0fc57f1d2c9e45073964c186e585425bc505d0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f6c6b9cc_76afd797","in_reply_to":"b3133f8d_c282f6e7","updated":"2025-10-03 11:19:52.000000000","message":"I think I removed all haproxy related variables of MariaDB","commit_id":"ff4c8a347dbb560f7e4a2607c1b07eac946834b8"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"d8e79b172f921292a17d41c5e0ea98c39da9330e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b3133f8d_c282f6e7","in_reply_to":"d64ee622_4d704df2","updated":"2025-10-01 16:37:39.000000000","message":"Do you mean the haproxy config for MariaDB that are copied to hosts?","commit_id":"ff4c8a347dbb560f7e4a2607c1b07eac946834b8"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ab3657365fb84f8f5207297cbea7a82ac4ba1f16","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"84550867_58a7f1da","in_reply_to":"f6c6b9cc_76afd797","updated":"2025-10-06 13:40:07.000000000","message":"Variables are fine, still if you enable clustercheck - there will be an haproxy entry in /etc/kolla/haproxy/services.d that load balances mariadb uses haproxy with clustercheck used for checking - which I\u0027d assume we need to delete.","commit_id":"ff4c8a347dbb560f7e4a2607c1b07eac946834b8"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"57f0598d5eb6a9f97b564ee8f2c869053ae9083d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"07363cda_74667b99","updated":"2025-10-03 10:33:23.000000000","message":"recheck dependency got update","commit_id":"e1fa52b17226174d8600a2e05ca90cbf22aae97e"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"53bc2f614aea71eda121f12eebb6ec0d3279e9fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"fd31bb70_e6a34c16","updated":"2025-10-06 08:23:40.000000000","message":"recheck","commit_id":"df32c5732e929d766979e0f99a91c3fb0b5af4ba"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f982b2a44f4638eb152829890f341428ae794e0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"98e9b952_9a7cbef3","updated":"2025-10-03 15:13:58.000000000","message":"recheck depends on changed","commit_id":"df32c5732e929d766979e0f99a91c3fb0b5af4ba"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"1f7f4420c8fe89bbf29afd3e495fc78c4a312645","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c9060f29_da191f53","updated":"2025-10-03 12:59:49.000000000","message":"recheck unrelated error","commit_id":"df32c5732e929d766979e0f99a91c3fb0b5af4ba"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"51b210cf840ccbf0db3c21c86f0bfa7a42a91ea8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"360f95c7_96af70ba","updated":"2025-10-07 14:58:51.000000000","message":"recheck","commit_id":"bd6bf4eb3fbce58f4750390a5e70ecd337c123fb"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"12151c07baf67e2647ebb07e81b3813f1e34e30b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"920d823e_9df3cd8a","updated":"2025-10-08 09:00:29.000000000","message":"recheck unrelated nova failure","commit_id":"bd6bf4eb3fbce58f4750390a5e70ecd337c123fb"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"1512c5f4d5eff52fa7757c80d66c4a8f37949f35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"f2b2ae16_e96116e1","updated":"2025-10-08 18:44:48.000000000","message":"recheck - get new logs","commit_id":"2c7dc67c98383cca56f1b0b49e3659f3a9d022de"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0f3fb0d2b17207b84e6ef3e40dba0483bcdabf0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e3f7f759_67021b21","updated":"2025-10-09 09:58:55.000000000","message":"t i","commit_id":"2c7dc67c98383cca56f1b0b49e3659f3a9d022de"}],"ansible/group_vars/all/mariadb.yml":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"84949d1e2f3e9690293860efefd9696e182c6144","unresolved":true,"context_lines":[{"line_number":18,"context_line":"mariadb_wsrep_port: \"4567\""},{"line_number":19,"context_line":"mariadb_ist_port: \"4568\""},{"line_number":20,"context_line":"mariadb_sst_port: \"4444\""},{"line_number":21,"context_line":"mariadb_clustercheck_port: \"4569\""},{"line_number":22,"context_line":"mariadb_enable_tls_backend: \"{{ database_enable_tls_backend }}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"mariadb_monitor_user: monitor"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7bf21fc3_7dba676a","line":21,"updated":"2025-10-08 12:32:19.000000000","message":"do we need still this var ?","commit_id":"bd6bf4eb3fbce58f4750390a5e70ecd337c123fb"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"be557664150a0a501e77d4f4227aaf952437a30e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"mariadb_wsrep_port: \"4567\""},{"line_number":19,"context_line":"mariadb_ist_port: \"4568\""},{"line_number":20,"context_line":"mariadb_sst_port: \"4444\""},{"line_number":21,"context_line":"mariadb_clustercheck_port: \"4569\""},{"line_number":22,"context_line":"mariadb_enable_tls_backend: \"{{ database_enable_tls_backend }}\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"mariadb_monitor_user: monitor"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"d95cc304_ca56810d","line":21,"in_reply_to":"7bf21fc3_7dba676a","updated":"2025-10-08 13:12:25.000000000","message":"Done","commit_id":"bd6bf4eb3fbce58f4750390a5e70ecd337c123fb"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5aefdb24f9ffc1b9e024c9cc7db72d0d76032f87","unresolved":true,"context_lines":[{"line_number":20,"context_line":"mariadb_sst_port: \"4444\""},{"line_number":21,"context_line":"mariadb_enable_tls_backend: \"{{ database_enable_tls_backend }}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"mariadb_monitor_user: monitor"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"mariadb_datadir_volume: \"mariadb\""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bdfd3c8d_c8e84bde","line":23,"updated":"2025-10-09 13:58:23.000000000","message":"in quotes, to make sure we don\u0027t extrapolate something","commit_id":"2c7dc67c98383cca56f1b0b49e3659f3a9d022de"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"7e38025401e252d12940d5ed1b02c8a873e5ee6f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"mariadb_sst_port: \"4444\""},{"line_number":21,"context_line":"mariadb_enable_tls_backend: \"{{ database_enable_tls_backend }}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"mariadb_monitor_user: monitor"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"mariadb_datadir_volume: \"mariadb\""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"27d5411f_ab3c02dd","line":23,"in_reply_to":"bdfd3c8d_c8e84bde","updated":"2025-10-09 14:00:46.000000000","message":"Done","commit_id":"2c7dc67c98383cca56f1b0b49e3659f3a9d022de"}],"ansible/roles/loadbalancer-config/defaults/main.yml":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"b9fea507c5ec8d7846caf34ae84a9d10c82a1885","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"haproxy_config_install: \"{{ project_name !\u003d \u0027mariadb\u0027 or not enable_proxysql | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"35049e1d_d76ac116","side":"PARENT","line":2,"updated":"2025-10-06 14:38:55.000000000","message":"it looks with that we will also drop support for enable_external_mariadb_load_balancer with that change - https://docs.openstack.org/kolla-ansible/latest/reference/databases/external-mariadb-guide.html#using-an-external-mariadb-cluster - If I\u0027m not mistaken","commit_id":"2b591fb097caa24e577714f6bd8c6b168fa652f1"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"ad9f2a13df2b34075e998b2e2a49c75ec5c7532d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"haproxy_config_install: \"{{ project_name !\u003d \u0027mariadb\u0027 or not enable_proxysql | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"c1006949_53536e61","side":"PARENT","line":2,"in_reply_to":"2bf43053_093a4be0","updated":"2025-10-08 13:41:35.000000000","message":"Let\u0027s just keep mariadb_external_lb in mariadb_services.mariadb.haproxy","commit_id":"2b591fb097caa24e577714f6bd8c6b168fa652f1"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"2c98e4415efeab03ccf0b106c508558d1af264d4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"haproxy_config_install: \"{{ project_name !\u003d \u0027mariadb\u0027 or not enable_proxysql | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"e5957a3e_49912c24","side":"PARENT","line":2,"in_reply_to":"35049e1d_d76ac116","updated":"2025-10-07 09:30:10.000000000","message":"Thanks for catching that. I think the original conditional expression still can be used because ``enable_proxysql`` will follow the value of ``enable_mariadb``. I\u0027ll revert this change","commit_id":"2b591fb097caa24e577714f6bd8c6b168fa652f1"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"84949d1e2f3e9690293860efefd9696e182c6144","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"haproxy_config_install: \"{{ project_name !\u003d \u0027mariadb\u0027 or not enable_proxysql | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":12,"id":"2bf43053_093a4be0","side":"PARENT","line":2,"in_reply_to":"e5957a3e_49912c24","updated":"2025-10-08 12:32:19.000000000","message":"well, in fact we\u0027re removing in this patch external lb management - mariadb_external_lb in ansible/roles/mariadb/defaults/main.yml\n\nso we may drop this feature whatsoever...","commit_id":"2b591fb097caa24e577714f6bd8c6b168fa652f1"}],"ansible/roles/mariadb/defaults/main.yml":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"84949d1e2f3e9690293860efefd9696e182c6144","unresolved":true,"context_lines":[{"line_number":32,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"mariadb_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":35,"context_line":"mariadb_clustercheck_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"mariadb_enable_healthchecks: \"{{ enable_container_healthchecks }}\""},{"line_number":38,"context_line":"mariadb_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"cdb1fbf3_3b0e6a1d","line":35,"updated":"2025-10-08 12:32:19.000000000","message":"not used var","commit_id":"bd6bf4eb3fbce58f4750390a5e70ecd337c123fb"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"be557664150a0a501e77d4f4227aaf952437a30e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"mariadb_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":35,"context_line":"mariadb_clustercheck_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"mariadb_enable_healthchecks: \"{{ enable_container_healthchecks }}\""},{"line_number":38,"context_line":"mariadb_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"0d40ac8b_485ee12a","line":35,"in_reply_to":"cdb1fbf3_3b0e6a1d","updated":"2025-10-08 13:12:25.000000000","message":"Done","commit_id":"bd6bf4eb3fbce58f4750390a5e70ecd337c123fb"}],"ansible/roles/mariadb/tasks/upgrade.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"db4890b82acf0258fd1e14d11bb0906c6bb3445b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- import_tasks: deploy.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- name: \"Stop and remove mariadb_clustercheck containers\""},{"line_number":5,"context_line":"  become: true"},{"line_number":6,"context_line":"  kolla_container:"},{"line_number":7,"context_line":"    action: \"stop_and_remove_container\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"992f225c_e3344bda","line":4,"updated":"2025-10-01 13:17:30.000000000","message":"Add a todo when this should be removed (after 2026.1)","commit_id":"ff4c8a347dbb560f7e4a2607c1b07eac946834b8"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"d8e79b172f921292a17d41c5e0ea98c39da9330e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- import_tasks: deploy.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- name: \"Stop and remove mariadb_clustercheck containers\""},{"line_number":5,"context_line":"  become: true"},{"line_number":6,"context_line":"  kolla_container:"},{"line_number":7,"context_line":"    action: \"stop_and_remove_container\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"beb86548_21f0853b","line":4,"in_reply_to":"992f225c_e3344bda","updated":"2025-10-01 16:37:39.000000000","message":"Done","commit_id":"ff4c8a347dbb560f7e4a2607c1b07eac946834b8"}],"ansible/roles/mariadb/templates/healthcheck.cnf.j2":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"bf62c2e6b94adf4d478484163b8c1abf26e88176","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[mariadb-client]"},{"line_number":2,"context_line":"user\u003d{{ mariadb_monitor_user }}"},{"line_number":3,"context_line":"password\u003d{{ mariadb_monitor_password }}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"23a7264f_287537ce","line":3,"updated":"2025-10-09 08:54:34.000000000","message":"this password is only set when enable_proxysql | bool\n\nansible/roles/mariadb/tasks/register.yml:32\nansible/roles/mariadb/tasks/loadbalancer.yml:33 \n\nbut this passwords is always used here. I think it may impact single node DBs without enable_proxysql ?\n\nwe may need to always create this password","commit_id":"2c7dc67c98383cca56f1b0b49e3659f3a9d022de"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"a9ad1b8585018c45deda0f9c2f8cbc0cc7dfbf05","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[mariadb-client]"},{"line_number":2,"context_line":"user\u003d{{ mariadb_monitor_user }}"},{"line_number":3,"context_line":"password\u003d{{ mariadb_monitor_password }}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"1f72b2ff_60ef2221","line":3,"in_reply_to":"1a8129d0_4ee100c5","updated":"2025-10-10 07:20:12.000000000","message":"on the other hand currently healtchedck will be always failing without proxysql, as there is no password in the db and we\u0027re trying to authenticate with it. So either always we should set the monitor user\u0027s password or stop writing it into healthcheck.cnf when ProxySQL is disabled. this is a regression","commit_id":"2c7dc67c98383cca56f1b0b49e3659f3a9d022de"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"e9eacf37def1273fa2061d276d489fb5ef9570ef","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[mariadb-client]"},{"line_number":2,"context_line":"user\u003d{{ mariadb_monitor_user }}"},{"line_number":3,"context_line":"password\u003d{{ mariadb_monitor_password }}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"41499d02_73fadf85","line":3,"in_reply_to":"1f72b2ff_60ef2221","updated":"2025-10-10 08:23:53.000000000","message":"Or use separate user, so we can decouple DB loadbalancing and container healthcheck?","commit_id":"2c7dc67c98383cca56f1b0b49e3659f3a9d022de"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"fb2070418985e67dd9b148dd4534ce9e6f04132c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[mariadb-client]"},{"line_number":2,"context_line":"user\u003d{{ mariadb_monitor_user }}"},{"line_number":3,"context_line":"password\u003d{{ mariadb_monitor_password }}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"b77877fa_fda54cc5","line":3,"in_reply_to":"23a7264f_287537ce","updated":"2025-10-09 09:36:08.000000000","message":"Should we create separate DB user? Like something called ``healthcheck``","commit_id":"2c7dc67c98383cca56f1b0b49e3659f3a9d022de"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"5b3ae5e6a53916b5d0ee540d235d9e71148cfca4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[mariadb-client]"},{"line_number":2,"context_line":"user\u003d{{ mariadb_monitor_user }}"},{"line_number":3,"context_line":"password\u003d{{ mariadb_monitor_password }}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"d2af919d_1dc72d08","line":3,"in_reply_to":"41499d02_73fadf85","updated":"2025-10-13 09:36:16.000000000","message":"I don\u0027t think that is necessary, let\u0027s remove those guards here to work in current password always model:\n\n./ansible/roles/mariadb/tasks/loadbalancer.yml:33:      password: \"{% if enable_proxysql | bool %}{{ mariadb_monitor_password }}{% endif %}\"\n./ansible/roles/mariadb/tasks/register.yml:32:      password: \"{% if enable_proxysql | bool %}{{ mariadb_monitor_password }}{% endif %}\"","commit_id":"2c7dc67c98383cca56f1b0b49e3659f3a9d022de"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"610be9f3ed1b698fde8a29e6c533f73836f5e67b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[mariadb-client]"},{"line_number":2,"context_line":"user\u003d{{ mariadb_monitor_user }}"},{"line_number":3,"context_line":"password\u003d{{ mariadb_monitor_password }}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"56c2b646_275be66d","line":3,"in_reply_to":"421295bc_338da3ea","updated":"2025-10-09 10:12:02.000000000","message":"@mnasiadka@gmail.com On a second thought, will the healthcheck actually be broken in that way? the `monitor` user is created without password if proxysql is not enabled.","commit_id":"2c7dc67c98383cca56f1b0b49e3659f3a9d022de"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"e5577e2fe2b6ebd2a4dcd7f89cd17eb43feeda7e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[mariadb-client]"},{"line_number":2,"context_line":"user\u003d{{ mariadb_monitor_user }}"},{"line_number":3,"context_line":"password\u003d{{ mariadb_monitor_password }}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"1a8129d0_4ee100c5","line":3,"in_reply_to":"56c2b646_275be66d","updated":"2025-10-09 10:14:06.000000000","message":"Ah sorry, you meant when both haproxy and proxysql is not used for MariaDB (The AIO deployment). Yeah than it makes sense to raise a bug.","commit_id":"2c7dc67c98383cca56f1b0b49e3659f3a9d022de"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"5c0cdbf7b836b4a8b745a1107aafbd0cd6baf152","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[mariadb-client]"},{"line_number":2,"context_line":"user\u003d{{ mariadb_monitor_user }}"},{"line_number":3,"context_line":"password\u003d{{ mariadb_monitor_password }}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"ebc61528_32f68a4f","line":3,"in_reply_to":"b77877fa_fda54cc5","updated":"2025-10-09 09:55:20.000000000","message":"I think we should just change those lines, remove those \"enable_proxysql\" ifs\n\n./ansible/roles/mariadb/tasks/loadbalancer.yml:33:      password: \"{% if enable_proxysql | bool %}{{ mariadb_monitor_password }}{% endif %}\"\n./ansible/roles/mariadb/tasks/register.yml:32:      password: \"{% if enable_proxysql | bool %}{{ mariadb_monitor_password }}{% endif %}\"","commit_id":"2c7dc67c98383cca56f1b0b49e3659f3a9d022de"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"a02bead11a27f15ff53b4c2112f5cb5eed1fd609","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[mariadb-client]"},{"line_number":2,"context_line":"user\u003d{{ mariadb_monitor_user }}"},{"line_number":3,"context_line":"password\u003d{{ mariadb_monitor_password }}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"d9b8e0d0_ebbed89d","line":3,"in_reply_to":"d2af919d_1dc72d08","updated":"2025-10-13 09:47:23.000000000","message":"Done","commit_id":"2c7dc67c98383cca56f1b0b49e3659f3a9d022de"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0f3fb0d2b17207b84e6ef3e40dba0483bcdabf0c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[mariadb-client]"},{"line_number":2,"context_line":"user\u003d{{ mariadb_monitor_user }}"},{"line_number":3,"context_line":"password\u003d{{ mariadb_monitor_password }}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"fe054579_d15c5d7d","line":3,"in_reply_to":"ebc61528_32f68a4f","updated":"2025-10-09 09:58:55.000000000","message":"It seems it has been broken looking at the old clustercheck implementation env variables in default/main.yml - I think it would make sense to raise a bug that if you disable proxysql and then deploy - mariadb health checks will be broken (and then fix it in a separate patch for backporting purposes).\nThe other thing is - in AIO dev deploy guide we\u0027re pointing that you can disable haproxy and you don\u0027t need the VIP IP - we should update it that you would need to also disable proxysql.","commit_id":"2c7dc67c98383cca56f1b0b49e3659f3a9d022de"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"fbb5f0e2a82cd6ecf3624e7974efb94384c71788","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[mariadb-client]"},{"line_number":2,"context_line":"user\u003d{{ mariadb_monitor_user }}"},{"line_number":3,"context_line":"password\u003d{{ mariadb_monitor_password }}"}],"source_content_type":"text/x-jinja2","patch_set":16,"id":"421295bc_338da3ea","line":3,"in_reply_to":"fe054579_d15c5d7d","updated":"2025-10-09 10:04:10.000000000","message":"Acknowledged on both","commit_id":"2c7dc67c98383cca56f1b0b49e3659f3a9d022de"}]}