)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6f2fc9e9f6f32afafe3cda926e8cc09c1533870b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add RabbitMQ management interface SSL"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change implements RabbitMQ management interface SSL configuration when ``rabbitmq_enable_tls`` is enabled."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Iaedad0e13f81b546af3a8e0c1e6ae7ca9da994a4"},{"line_number":12,"context_line":"Signed-off-by: fprzewozn \u003cprzewozny.franciszek@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"25db160c_4320cfc8","line":9,"range":{"start_line":9,"start_character":70,"end_line":9,"end_character":71},"updated":"2025-10-17 13:13:26.000000000","message":"nit: the long line should be wrapped here","commit_id":"57277c78830f1a6c1b7071dac55bceb0bccd58a4"},{"author":{"_account_id":34034,"name":"Franciszek Przewoźny","display_name":"Franciszek Przewozny","email":"przewozny.franciszek@gmail.com","username":"fprzewozn","status":"OpenStack Engineer / SRE @ Opera Software"},"change_message_id":"fb0cf173cc6977155fe30c3ad43c0f4f866ee054","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add RabbitMQ management interface SSL"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change implements RabbitMQ management interface SSL configuration when ``rabbitmq_enable_tls`` is enabled."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Iaedad0e13f81b546af3a8e0c1e6ae7ca9da994a4"},{"line_number":12,"context_line":"Signed-off-by: fprzewozn \u003cprzewozny.franciszek@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"c90d9211_d5b33152","line":9,"range":{"start_line":9,"start_character":70,"end_line":9,"end_character":71},"in_reply_to":"25db160c_4320cfc8","updated":"2025-10-17 13:18:58.000000000","message":"Done","commit_id":"57277c78830f1a6c1b7071dac55bceb0bccd58a4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34034,"name":"Franciszek Przewoźny","display_name":"Franciszek Przewozny","email":"przewozny.franciszek@gmail.com","username":"fprzewozn","status":"OpenStack Engineer / SRE @ Opera Software"},"change_message_id":"52cdfdc4a619a411531c62628c730759f420b909","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d5bfa2ac_dccf4112","updated":"2025-12-18 10:09:26.000000000","message":"@bartosz@stackhpc.com could you have a look?","commit_id":"d298c6091faa1bbb05a4a00dcc6d3675f5a18091"}],"ansible/roles/rabbitmq/defaults/main.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6f2fc9e9f6f32afafe3cda926e8cc09c1533870b","unresolved":true,"context_lines":[{"line_number":21,"context_line":"      rabbitmq_management:"},{"line_number":22,"context_line":"        enabled: \"{{ enable_rabbitmq }}\""},{"line_number":23,"context_line":"        mode: \"http\""},{"line_number":24,"context_line":"        external: false"},{"line_number":25,"context_line":"        tls_backend: \"{{ rabbitmq_enable_tls }}\""},{"line_number":26,"context_line":"        port: \"{{ rabbitmq_management_port }}\""},{"line_number":27,"context_line":"        host_group: \"rabbitmq\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c71326d0_5a5cc742","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":23},"updated":"2025-10-17 13:13:26.000000000","message":"lets trigger on rabbitmq_enable_tls too?","commit_id":"57277c78830f1a6c1b7071dac55bceb0bccd58a4"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c74e934d80eb9aeafb111041f67893da4819914a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      rabbitmq_management:"},{"line_number":22,"context_line":"        enabled: \"{{ enable_rabbitmq }}\""},{"line_number":23,"context_line":"        mode: \"http\""},{"line_number":24,"context_line":"        external: false"},{"line_number":25,"context_line":"        tls_backend: \"{{ rabbitmq_enable_tls }}\""},{"line_number":26,"context_line":"        port: \"{{ rabbitmq_management_port }}\""},{"line_number":27,"context_line":"        host_group: \"rabbitmq\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f8427275_b679d571","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":23},"in_reply_to":"4dda7fbb_73f17880","updated":"2025-10-17 17:27:38.000000000","message":"That\u0027s not an override, but a duplicate. Anyway, LGTM.","commit_id":"57277c78830f1a6c1b7071dac55bceb0bccd58a4"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"2b97e8a293d20db00c9fd2fc9b212f946688cd59","unresolved":true,"context_lines":[{"line_number":21,"context_line":"      rabbitmq_management:"},{"line_number":22,"context_line":"        enabled: \"{{ enable_rabbitmq }}\""},{"line_number":23,"context_line":"        mode: \"http\""},{"line_number":24,"context_line":"        external: false"},{"line_number":25,"context_line":"        tls_backend: \"{{ rabbitmq_enable_tls }}\""},{"line_number":26,"context_line":"        port: \"{{ rabbitmq_management_port }}\""},{"line_number":27,"context_line":"        host_group: \"rabbitmq\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"c3f7838a_0ec602c8","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":23},"in_reply_to":"8a94f5b8_375512ec","updated":"2025-10-17 13:24:54.000000000","message":"In some cases, an infrastructure needs a RabbitMQ management web-interface inside the infrastructure and doesn\u0027t expose it publicly, even with SSL","commit_id":"57277c78830f1a6c1b7071dac55bceb0bccd58a4"},{"author":{"_account_id":34034,"name":"Franciszek Przewoźny","display_name":"Franciszek Przewozny","email":"przewozny.franciszek@gmail.com","username":"fprzewozn","status":"OpenStack Engineer / SRE @ Opera Software"},"change_message_id":"1bbe37b65e1b7892e9acd150b846ba4d3cbc182d","unresolved":true,"context_lines":[{"line_number":21,"context_line":"      rabbitmq_management:"},{"line_number":22,"context_line":"        enabled: \"{{ enable_rabbitmq }}\""},{"line_number":23,"context_line":"        mode: \"http\""},{"line_number":24,"context_line":"        external: false"},{"line_number":25,"context_line":"        tls_backend: \"{{ rabbitmq_enable_tls }}\""},{"line_number":26,"context_line":"        port: \"{{ rabbitmq_management_port }}\""},{"line_number":27,"context_line":"        host_group: \"rabbitmq\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"4dda7fbb_73f17880","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":23},"in_reply_to":"8f1d3ca0_9096ab86","updated":"2025-10-17 17:21:05.000000000","message":"Other services like keystone [1] and nova-api [2] are configured exactly that way - override default with the same value\n\n[1] https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/keystone/defaults/main.yml#L16\n[2] https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/nova/defaults/main.yml#L17","commit_id":"57277c78830f1a6c1b7071dac55bceb0bccd58a4"},{"author":{"_account_id":34034,"name":"Franciszek Przewoźny","display_name":"Franciszek Przewozny","email":"przewozny.franciszek@gmail.com","username":"fprzewozn","status":"OpenStack Engineer / SRE @ Opera Software"},"change_message_id":"f05b05cdc083ff3a8e401604909c5a14f321b2dd","unresolved":true,"context_lines":[{"line_number":21,"context_line":"      rabbitmq_management:"},{"line_number":22,"context_line":"        enabled: \"{{ enable_rabbitmq }}\""},{"line_number":23,"context_line":"        mode: \"http\""},{"line_number":24,"context_line":"        external: false"},{"line_number":25,"context_line":"        tls_backend: \"{{ rabbitmq_enable_tls }}\""},{"line_number":26,"context_line":"        port: \"{{ rabbitmq_management_port }}\""},{"line_number":27,"context_line":"        host_group: \"rabbitmq\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"db934341_7969ce00","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":23},"in_reply_to":"c3f7838a_0ec602c8","updated":"2025-10-17 13:31:57.000000000","message":"Sure, but the thing here is that I\u0027m keeping the default variable: https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/haproxy-config/templates/haproxy_single_service_split.cfg.j2#L121 but now it\u0027s declared directly (as for all other services using HAproxy, f.e. [1], [2]) instead of leveraging default. \n\n[1] https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/keystone/defaults/main.yml#L16\n[2] https://github.com/openstack/kolla-ansible/blob/master/ansible/roles/nova/defaults/main.yml#L17","commit_id":"57277c78830f1a6c1b7071dac55bceb0bccd58a4"},{"author":{"_account_id":34034,"name":"Franciszek Przewoźny","display_name":"Franciszek Przewozny","email":"przewozny.franciszek@gmail.com","username":"fprzewozn","status":"OpenStack Engineer / SRE @ Opera Software"},"change_message_id":"fb0cf173cc6977155fe30c3ad43c0f4f866ee054","unresolved":true,"context_lines":[{"line_number":21,"context_line":"      rabbitmq_management:"},{"line_number":22,"context_line":"        enabled: \"{{ enable_rabbitmq }}\""},{"line_number":23,"context_line":"        mode: \"http\""},{"line_number":24,"context_line":"        external: false"},{"line_number":25,"context_line":"        tls_backend: \"{{ rabbitmq_enable_tls }}\""},{"line_number":26,"context_line":"        port: \"{{ rabbitmq_management_port }}\""},{"line_number":27,"context_line":"        host_group: \"rabbitmq\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8a94f5b8_375512ec","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":23},"in_reply_to":"c71326d0_5a5cc742","updated":"2025-10-17 13:18:58.000000000","message":"rabbitmq_management is an internal interface by design, this declaration just makes this clear. External interface for rabbitmq_management should be defined separately, but I\u0027m totally against it so I won\u0027t implement that.","commit_id":"57277c78830f1a6c1b7071dac55bceb0bccd58a4"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"946614fe685c619893daf9c17f8bf8d2b8b5df31","unresolved":true,"context_lines":[{"line_number":21,"context_line":"      rabbitmq_management:"},{"line_number":22,"context_line":"        enabled: \"{{ enable_rabbitmq }}\""},{"line_number":23,"context_line":"        mode: \"http\""},{"line_number":24,"context_line":"        external: false"},{"line_number":25,"context_line":"        tls_backend: \"{{ rabbitmq_enable_tls }}\""},{"line_number":26,"context_line":"        port: \"{{ rabbitmq_management_port }}\""},{"line_number":27,"context_line":"        host_group: \"rabbitmq\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"8f1d3ca0_9096ab86","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":23},"in_reply_to":"db934341_7969ce00","updated":"2025-10-17 17:01:19.000000000","message":"Oh, I thought you changed the default, so that line is useless anyway.","commit_id":"57277c78830f1a6c1b7071dac55bceb0bccd58a4"}]}