)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"74d740aaac078d2cd0d8ac8ddd6c41cce12a4a2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"61da8d18_c5406405","updated":"2025-12-02 09:26:18.000000000","message":"Can u please review this ?","commit_id":"3948c12b1a51f8ffa3d3e375e5c200f8c71667aa"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"9503fc2e71307f9fd04d4e0824c5579d87d6e4c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c987fa8a_7e08041a","updated":"2025-11-03 09:46:10.000000000","message":"This will break for people using a single variable to render the entire keyring I believe ?\n\nif keyring file looks like \n\n```yaml\n{{ lookup(...) }}\n```\n\nThey will need to switch to \n```yaml\n[client.XXX]\nkey \u003d {{ lookup(...) }} \n```\n\nWe use the latter, but I would assume there are deployments out there using a single value to render the entire file?\n\nI like the new approach however.","commit_id":"3948c12b1a51f8ffa3d3e375e5c200f8c71667aa"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4f9296a81817482fec323061adeac2cb1e0e91ee","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"54473e50_9610c6e8","updated":"2025-12-02 14:52:42.000000000","message":"lack of the reno","commit_id":"3948c12b1a51f8ffa3d3e375e5c200f8c71667aa"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"4dc39e468bdca98d3b48ec8f188d4f80d808390e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d5a396a5_e4017b93","in_reply_to":"0ba4e3bc_aa0198a9","updated":"2026-05-21 19:16:21.000000000","message":"thanks","commit_id":"3948c12b1a51f8ffa3d3e375e5c200f8c71667aa"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"56bae243d8e10cfb163dc6496fa90366cd185205","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4cf01f06_9e79284b","in_reply_to":"40c46a5b_92ece585","updated":"2025-11-03 12:51:02.000000000","message":"I didn\u0027t have this detail regarding documentation. This looks fine by me then.","commit_id":"3948c12b1a51f8ffa3d3e375e5c200f8c71667aa"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"305b46e8ad5d32c8869115afcc735ddfbdef4ea0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0ba4e3bc_aa0198a9","in_reply_to":"54473e50_9610c6e8","updated":"2026-05-21 17:40:19.000000000","message":"Reno added","commit_id":"3948c12b1a51f8ffa3d3e375e5c200f8c71667aa"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e98762f66524d343d429a75c1ef42bc544fd62d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"40c46a5b_92ece585","in_reply_to":"c987fa8a_7e08041a","updated":"2025-11-03 12:42:52.000000000","message":"Thanks Bertrand — according to Kolla documentation, the expected structure of Ceph keyrings is under /etc/kolla/config/{{ service }}/...key and follows the standard [client.X] + key \u003d ... format.\n\nUsing a single-variable template (like {{ lookup(...) }} for the entire file) is not a documented or supported pattern. The current change keeps compatibility with all documented and deployed cases, while also allowing the key itself to be stored securely in passwords.yml.\n\nEdge cases like rendering the whole file from a variable are effectively undefined behavior in Kolla and shouldn’t be relied upon. During upgrades, users are expected to run --check --diff first, so any custom deviations would be clearly visible.","commit_id":"3948c12b1a51f8ffa3d3e375e5c200f8c71667aa"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"11f03b204a0aa2f2cd6718e5fd58426c06d8d532","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c2672dce_2f1d957f","updated":"2026-01-18 13:59:47.000000000","message":"LGTM, once rebased","commit_id":"6e22b7dbb811e1597bf9e27f73cb68d3a56462e4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"593abef62171e1796135b3d63fd0596c2b1d25fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dfac0426_40739cf8","updated":"2026-01-21 09:42:04.000000000","message":"recheck debian upgrade","commit_id":"7366f449ab3ae290747404bec9955340f6b7fd4a"},{"author":{"_account_id":34034,"name":"Franciszek Przewoźny","display_name":"Franciszek Przewozny","email":"przewozny.franciszek@gmail.com","username":"fprzewozn","status":"OpenStack Engineer / SRE @ Opera Software"},"change_message_id":"7901e03aede2ec714d32a013b0e01b99adc5d0ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ae9998f1_e0686b32","updated":"2026-09-10 13:11:16.000000000","message":"1. Templating of keyring files work without this change, please re-verify on the environment it was developed/tested\n2. If @bertrand.lanson@infomaniak.com comment is correct then it\u0027s a breaking change, it should be -1 on backport","commit_id":"9f2c897bca89f61e436816bf2a3c0d0c254ba986"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"dfce46a6c7df688815c0bb60001de3ae362e8a15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7fb44433_f2ed680c","updated":"2026-08-05 21:39:32.000000000","message":"@bertrand.lanson@infomaniak.com thanks","commit_id":"9f2c897bca89f61e436816bf2a3c0d0c254ba986"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3d4e320e114dac585ccb3dfe3eed4edba2fd25f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d6fbc622_b587ee5e","updated":"2026-08-10 21:01:57.000000000","message":"Another +2 and approve for this patch ? Thanks","commit_id":"9f2c897bca89f61e436816bf2a3c0d0c254ba986"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"09a972f68fff8df3e4818ded239cc81d77b5a228","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ab2aea5f_14c28c79","updated":"2026-07-15 12:25:28.000000000","message":"any comments ?","commit_id":"9f2c897bca89f61e436816bf2a3c0d0c254ba986"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"45386d5fb561b2906067226a77676918f81ca6e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9d24db4d_e1aea458","updated":"2026-06-10 14:17:25.000000000","message":"what about this ? Any comments ? Thanks","commit_id":"9f2c897bca89f61e436816bf2a3c0d0c254ba986"}]}