)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d5fd4e44a70d8f8a91d8c9676f0d5f28660e993a","unresolved":true,"context_lines":[{"line_number":16,"context_line":"upgrades (e.g., 4.1.x -\u003e 4.2.x)."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This enhancement improves the maintainability of Kolla Ansible by allowing"},{"line_number":19,"context_line":"operators to update the list of supported version jumps for future RabbitMQ"},{"line_number":20,"context_line":"releases without the need to modify the core logic in the Ansible task file."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"The version validation logic now works as follows:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"f0551dea_2eea508a","line":19,"updated":"2026-03-17 09:49:18.000000000","message":"If it\u0027s in vars/ operators can\u0027t easily override it - they can only use globals.yml which is imported as extra var (-e) - we usually put things that can be overridable in defaults/","commit_id":"79b7a06ef46a093a4a9d5945cb22e6cba616c80b"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"3f03e9a773836a7905894f2f4003ae5ee254bc99","unresolved":false,"context_lines":[{"line_number":16,"context_line":"upgrades (e.g., 4.1.x -\u003e 4.2.x)."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This enhancement improves the maintainability of Kolla Ansible by allowing"},{"line_number":19,"context_line":"operators to update the list of supported version jumps for future RabbitMQ"},{"line_number":20,"context_line":"releases without the need to modify the core logic in the Ansible task file."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"The version validation logic now works as follows:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"e188c3d7_2e9fd74c","line":19,"in_reply_to":"f0551dea_2eea508a","updated":"2026-03-17 10:20:06.000000000","message":"Acknowledged","commit_id":"79b7a06ef46a093a4a9d5945cb22e6cba616c80b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"650b9214974dc9c15d6259d2081a68f5ae7485d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ee9dcbfc_cba52876","updated":"2025-11-25 10:51:29.000000000","message":"Thanks @vurmil@gmail.com! This looks like a very useful change. I\u0027ve just got a couple of suggestions.","commit_id":"40af895c51e19d4ac5518ccc1f93c76898048c98"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"92a28e0a60190f57d3fcde7745b7b2a9003c7e15","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"65747977_dea5b8db","updated":"2025-11-04 10:32:31.000000000","message":"feature freeze","commit_id":"40af895c51e19d4ac5518ccc1f93c76898048c98"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7f18d24a67da0b8de564af42442eaa79caf3c5e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2b7895c5_4f020921","in_reply_to":"65747977_dea5b8db","updated":"2026-03-27 10:59:49.000000000","message":"Done","commit_id":"40af895c51e19d4ac5518ccc1f93c76898048c98"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"321262032f203a63f84066592cb19a79dea71c5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"6777774e_d2638a51","updated":"2026-02-10 11:58:32.000000000","message":"@vurmil@gmail.com Can you rebase/fix the merge conflict on this one?","commit_id":"30b82da4fb46edd3557467b06faa37d088bdb79b"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"49533705c94a743d51f92b95fedaffe6dd24a7ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"0960efcb_34374415","updated":"2026-02-10 15:33:36.000000000","message":"recheck - tempest","commit_id":"7eff3aa7fc7dc4d9056c392bad063211cf954834"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"28079cf75a95fe010deafce5faf9e4abf63a8fab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"bd3aca4a_3b9f7a1a","updated":"2026-03-27 13:00:18.000000000","message":"++ job SLURP broken\nhttps://zuul.opendev.org/t/openstack/build/5825f239ef614b639df92d4451957dca\n\n\n[ERROR]: Task failed: Action failed: Looks like you\u0027re trying to run a skip-release upgrade! RabbitMQ must be at most one version behind the target release version (4.2.4) to run this upgrade. You are running 4.0.9. Please first upgrade to 4.1 with the command ``kolla-ansible rabbitmq-upgrade 4.1``. See these docs for more details: https://docs.openstack.org/kolla-ansible/latest/reference/message-queues/rabbitmq.html#slurp\n\nOrigin: /home/zuul/kolla-ansible-venv/share/kolla-ansible/ansible/roles/rabbitmq/tasks/version-check.yml:55:11\n\n53         # And if the current RabbitMQ version is 3.11.28:\n54         # upgrade_version \u003d 3.12\n55         - name: Check if running RabbitMQ is at most one version behind\n             ^ column 11","commit_id":"5e18d6803fd8a725dc7411017bccea63826b32fe"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"2e8126ebb199f6216e96ccac0167eea2e9478a9d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":29,"id":"1e1229a0_5220110a","updated":"2026-03-27 13:50:51.000000000","message":"linters are failing: https://zuul.opendev.org/t/openstack/build/661e5f9a1b9d460b8705d8a63dceebe1","commit_id":"5e18d6803fd8a725dc7411017bccea63826b32fe"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a392a57884d8bbd7eacc65b1dec90cf4fa0d4117","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"685a7f9c_f55d8335","in_reply_to":"1e1229a0_5220110a","updated":"2026-03-27 17:37:09.000000000","message":"Done","commit_id":"5e18d6803fd8a725dc7411017bccea63826b32fe"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a392a57884d8bbd7eacc65b1dec90cf4fa0d4117","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"41b71bd0_411d88e6","updated":"2026-03-27 17:37:09.000000000","message":"Merging to unblock slurp CI","commit_id":"04f1276d652afbe6eb03b184902594666117d631"}],"ansible/roles/rabbitmq/tasks/version-check.yml":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"650b9214974dc9c15d6259d2081a68f5ae7485d1","unresolved":true,"context_lines":[{"line_number":15,"context_line":"          command: \"{{ kolla_container_engine }} exec {{ service.container_name }} rabbitmqctl --version\""},{"line_number":16,"context_line":"          register: rabbitmq_version_current"},{"line_number":17,"context_line":"          changed_when: false"},{"line_number":18,"context_line":"          failed_when: rabbitmq_version_current.rc !\u003d 0"},{"line_number":19,"context_line":"          retries: 3"},{"line_number":20,"context_line":"          delay: 5"},{"line_number":21,"context_line":"          until: rabbitmq_version_current.rc \u003d\u003d 0"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        - name: Get new RabbitMQ version"},{"line_number":24,"context_line":"          become: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ff260c55_c25cfa63","line":21,"range":{"start_line":18,"start_character":0,"end_line":21,"end_character":49},"updated":"2025-11-25 10:51:29.000000000","message":"Out of curiosity, why do you include retries here? Do you often see this lookup fail?","commit_id":"40af895c51e19d4ac5518ccc1f93c76898048c98"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"db4ac77e73541c8754fbd15309371d9db04d3fe7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"          command: \"{{ kolla_container_engine }} exec {{ service.container_name }} rabbitmqctl --version\""},{"line_number":16,"context_line":"          register: rabbitmq_version_current"},{"line_number":17,"context_line":"          changed_when: false"},{"line_number":18,"context_line":"          failed_when: rabbitmq_version_current.rc !\u003d 0"},{"line_number":19,"context_line":"          retries: 3"},{"line_number":20,"context_line":"          delay: 5"},{"line_number":21,"context_line":"          until: rabbitmq_version_current.rc \u003d\u003d 0"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        - name: Get new RabbitMQ version"},{"line_number":24,"context_line":"          become: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fd5d8185_77662d07","line":21,"range":{"start_line":18,"start_character":0,"end_line":21,"end_character":49},"in_reply_to":"ff260c55_c25cfa63","updated":"2025-11-25 14:55:36.000000000","message":"normal security if the service wasn\u0027t too fast :), it can be done without it","commit_id":"40af895c51e19d4ac5518ccc1f93c76898048c98"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"650b9214974dc9c15d6259d2081a68f5ae7485d1","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            new_major: \"{{ new_version.split(\u0027.\u0027)[0] | int }}\""},{"line_number":55,"context_line":"            new_minor: \"{{ new_version.split(\u0027.\u0027)[1] | int }}\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"            allowed_upgrades: \"{{ upgrade_config.rabbitmq_allowed_upgrades | default({}) }}\""},{"line_number":58,"context_line":"            valid_next_versions: \"{{ allowed_upgrades.get(current_version, [current_major|string + \u0027.\u0027 + (current_minor + 1)|string]) }}\""},{"line_number":59,"context_line":"          assert:"},{"line_number":60,"context_line":"            that:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c1201627_88a9257f","line":57,"updated":"2025-11-25 10:51:29.000000000","message":"```suggestion\n            allowed_upgrades: \"{{ rabbitmq_allowed_upgrades | default({}) }}\"\n```\nI don\u0027t see where upgrade_config is defined, is this an old bit of code?","commit_id":"40af895c51e19d4ac5518ccc1f93c76898048c98"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"db4ac77e73541c8754fbd15309371d9db04d3fe7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            new_major: \"{{ new_version.split(\u0027.\u0027)[0] | int }}\""},{"line_number":55,"context_line":"            new_minor: \"{{ new_version.split(\u0027.\u0027)[1] | int }}\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"            allowed_upgrades: \"{{ upgrade_config.rabbitmq_allowed_upgrades | default({}) }}\""},{"line_number":58,"context_line":"            valid_next_versions: \"{{ allowed_upgrades.get(current_version, [current_major|string + \u0027.\u0027 + (current_minor + 1)|string]) }}\""},{"line_number":59,"context_line":"          assert:"},{"line_number":60,"context_line":"            that:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ca1692d4_701d6074","line":57,"in_reply_to":"c1201627_88a9257f","updated":"2025-11-25 14:55:36.000000000","message":"Acknowledged","commit_id":"40af895c51e19d4ac5518ccc1f93c76898048c98"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"650b9214974dc9c15d6259d2081a68f5ae7485d1","unresolved":true,"context_lines":[{"line_number":55,"context_line":"            new_minor: \"{{ new_version.split(\u0027.\u0027)[1] | int }}\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"            allowed_upgrades: \"{{ upgrade_config.rabbitmq_allowed_upgrades | default({}) }}\""},{"line_number":58,"context_line":"            valid_next_versions: \"{{ allowed_upgrades.get(current_version, [current_major|string + \u0027.\u0027 + (current_minor + 1)|string]) }}\""},{"line_number":59,"context_line":"          assert:"},{"line_number":60,"context_line":"            that:"},{"line_number":61,"context_line":"              - new_version is defined"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0491b894_e273056a","line":58,"updated":"2025-11-25 10:51:29.000000000","message":"```suggestion\n            valid_next_versions: \"{{ allowed_upgrades.get(current_version, [current_major | string + \u0027.\u0027 + (current_minor | int + 1) | string]) }}\"\n```\ncurrent_minor needs to be converted to an int for the addition. \n(Plus, I\u0027ve suggested whitespace to match how KA usually formats filters)","commit_id":"40af895c51e19d4ac5518ccc1f93c76898048c98"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"db4ac77e73541c8754fbd15309371d9db04d3fe7","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            new_minor: \"{{ new_version.split(\u0027.\u0027)[1] | int }}\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"            allowed_upgrades: \"{{ upgrade_config.rabbitmq_allowed_upgrades | default({}) }}\""},{"line_number":58,"context_line":"            valid_next_versions: \"{{ allowed_upgrades.get(current_version, [current_major|string + \u0027.\u0027 + (current_minor + 1)|string]) }}\""},{"line_number":59,"context_line":"          assert:"},{"line_number":60,"context_line":"            that:"},{"line_number":61,"context_line":"              - new_version is defined"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"be06981b_5f5e4033","line":58,"in_reply_to":"0491b894_e273056a","updated":"2025-11-25 14:55:36.000000000","message":"Acknowledged","commit_id":"40af895c51e19d4ac5518ccc1f93c76898048c98"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ec1a14d511b94f8326339fa4c8d3133edef4fb9b","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  block:"},{"line_number":9,"context_line":"    - name: Load allowed upgrade paths"},{"line_number":10,"context_line":"      include_vars:"},{"line_number":11,"context_line":"        file: vars/rabbitmq-upgrade-paths.yml"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    - name: Get container facts"},{"line_number":14,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"1772847d_405ab6c6","line":11,"updated":"2025-11-28 19:00:10.000000000","message":"Just rename the file to ansible/roles/rabbitmq/vars/main/upgrade-paths.yml instead of including it here\n\nSee https://docs.ansible.com/projects/ansible/latest/playbook_guide/playbooks_reuse_roles.html#role-directory-structure","commit_id":"27280ea0467b7f30d64971d09cdb3137dfeaa710"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"49c5115ee75e7cfc69471f144d4675e2501fc67c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  block:"},{"line_number":9,"context_line":"    - name: Load allowed upgrade paths"},{"line_number":10,"context_line":"      include_vars:"},{"line_number":11,"context_line":"        file: vars/rabbitmq-upgrade-paths.yml"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    - name: Get container facts"},{"line_number":14,"context_line":"      become: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"19536883_8743f5e5","line":11,"in_reply_to":"1772847d_405ab6c6","updated":"2025-11-28 19:20:03.000000000","message":"Acknowledged","commit_id":"27280ea0467b7f30d64971d09cdb3137dfeaa710"}],"ansible/roles/rabbitmq/vars/rabbitmq-upgrade-paths.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"564f73f93a1df0e29a0a08598845e9fbb3cba0ec","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"rabbitmq_allowed_upgrades:"},{"line_number":3,"context_line":"  \"3.13\": [\"4.0\", \"4.1\", \"4.2\"]"},{"line_number":4,"context_line":"  \"4.0\": [\"4.1\", \"4.2\"]"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"8ae73db3_0b26c01b","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":23},"updated":"2025-11-28 19:01:26.000000000","message":"```suggestion\n  \"3.13\":\n    - \"4.0\"\n    - \"4.1\"\n    - \"4.2\"\n  \"4.0\":\n    - \"4.1\"\n    - \"4.2\"\n```","commit_id":"27280ea0467b7f30d64971d09cdb3137dfeaa710"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"49c5115ee75e7cfc69471f144d4675e2501fc67c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"rabbitmq_allowed_upgrades:"},{"line_number":3,"context_line":"  \"3.13\": [\"4.0\", \"4.1\", \"4.2\"]"},{"line_number":4,"context_line":"  \"4.0\": [\"4.1\", \"4.2\"]"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"a87bc37d_49eb2bce","line":4,"range":{"start_line":3,"start_character":0,"end_line":4,"end_character":23},"in_reply_to":"8ae73db3_0b26c01b","updated":"2025-11-28 19:20:03.000000000","message":"Acknowledged","commit_id":"27280ea0467b7f30d64971d09cdb3137dfeaa710"}]}