)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7ba3b3a41294b53dd228b1f73127e9be7f93b05b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"6ac18bab_71ce8982","updated":"2026-07-29 13:40:39.000000000","message":"Functionally it looks fine, just one nit.\n\nIt would be better if `kolla_container` could support waiting instead, since this race exists in other places. What do you think?","commit_id":"40511b7bd09c50575338942f2f367da0cba664e5"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4b9f9236bf7a8a450208e04a69b9acbf5cb07e50","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":37,"id":"ed86944c_a64d19db","updated":"2026-07-29 14:35:21.000000000","message":"I have more general question, do we really need this?, as we can see it adds more complexity for checking state, and there were already fixes after this patch was proposed, namely:\n\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/985324\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/992443\n\nso those patches would have fixed the initial bug report, as they are now waiting for it, so if it don\u0027t exist it would fail as well, so it is doing basically the same already","commit_id":"40511b7bd09c50575338942f2f367da0cba664e5"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"c7398558ee7248d960e6819e9430ced4625f140e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"4b3de11e_be46f4a1","updated":"2026-07-29 15:23:48.000000000","message":"OK, abandoning this in that case.","commit_id":"40511b7bd09c50575338942f2f367da0cba664e5"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"34c0d357114d8de4723b3e5710ae5ef7625272bc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":37,"id":"7ee99159_63e80ee7","in_reply_to":"6bfc346c_d289e919","updated":"2026-07-29 14:53:00.000000000","message":"Another one! https://review.opendev.org/c/openstack/kolla-ansible/+/986237","commit_id":"40511b7bd09c50575338942f2f367da0cba664e5"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a0804b93b1de6e2f3c8df8f296c15aac5d578aa5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":37,"id":"6bfc346c_d289e919","in_reply_to":"ed86944c_a64d19db","updated":"2026-07-29 14:50:23.000000000","message":"I didn\u0027t see these - good point","commit_id":"40511b7bd09c50575338942f2f367da0cba664e5"}],"ansible/roles/common/handlers/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cc0740719afe602a0a1c0a51828ff8d729b5c5cf","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  notify:"},{"line_number":17,"context_line":"    - Check kolla-toolbox container status"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Check kolla-toolbox container status"},{"line_number":20,"context_line":"  become: true"},{"line_number":21,"context_line":"  kolla_container_facts:"},{"line_number":22,"context_line":"    action: \"get_container_state\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3c2429cf_4d459472","line":19,"updated":"2025-12-03 12:13:43.000000000","message":"It\u0027s probably fine, but maybe it would be better to add ,,wait\u0027\u0027 functionality in kolla_container?","commit_id":"cdcb6d9952e3b349dfd8d9ca0bd4712e05bfe97f"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"6ea7dc107b5c0d47564d8745120f39ae113de5a6","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  notify:"},{"line_number":17,"context_line":"    - Check kolla-toolbox container status"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Check kolla-toolbox container status"},{"line_number":20,"context_line":"  become: true"},{"line_number":21,"context_line":"  kolla_container_facts:"},{"line_number":22,"context_line":"    action: \"get_container_state\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"89ac2eb8_ff30f39e","line":19,"in_reply_to":"3c2429cf_4d459472","updated":"2026-07-16 13:58:20.000000000","message":"If that is fine with you I would like to go with it as is.","commit_id":"cdcb6d9952e3b349dfd8d9ca0bd4712e05bfe97f"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"4b024ea2883a3e7145c55acd2749dbab84e0da69","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  notify:"},{"line_number":17,"context_line":"    - Check kolla-toolbox container status"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Check kolla-toolbox container status"},{"line_number":20,"context_line":"  become: true"},{"line_number":21,"context_line":"  kolla_container_facts:"},{"line_number":22,"context_line":"    action: \"get_container_state\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"63f4dc43_d0e37d82","line":19,"in_reply_to":"89ac2eb8_ff30f39e","updated":"2026-07-17 10:24:52.000000000","message":"Acknowledged","commit_id":"cdcb6d9952e3b349dfd8d9ca0bd4712e05bfe97f"}],"ansible/roles/kolla_toolbox/handlers/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d43db02793eba717fd7ccb0dc4600ca5e4629bc6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    environment: \"{{ service.environment }}\""},{"line_number":15,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":16,"context_line":"  notify:"},{"line_number":17,"context_line":"    - Check kolla-toolbox container status"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Check kolla-toolbox container status"},{"line_number":20,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"a7363570_8bd20318","line":17,"updated":"2026-07-17 10:29:15.000000000","message":"kolla_container seems to be handling changed property correctly, so that might work.","commit_id":"b2d906d6090914ec09ca343935fb9a0f51badbc8"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"298a8b54ce4aee238560a32379b616ac218e3f23","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  retries: 5"},{"line_number":42,"context_line":"  delay: 5"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- debug:"},{"line_number":45,"context_line":"    var: results"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"c918e7e8_32ad81f8","line":44,"updated":"2026-07-22 12:18:21.000000000","message":"linters: fqcn[action-core]: Use FQCN for builtin module actions (debug).","commit_id":"e8e2e37a77a99284cb9d4b0cb3778074a6a78410"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"cb6e837cc54ba074b4d2954ae5674040814903a4","unresolved":true,"context_lines":[{"line_number":41,"context_line":"  retries: 5"},{"line_number":42,"context_line":"  delay: 5"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- debug:"},{"line_number":45,"context_line":"    var: results"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"583c97b0_d866a50c","line":45,"range":{"start_line":44,"start_character":1,"end_line":45,"end_character":16},"updated":"2026-07-22 11:36:20.000000000","message":"Should this change be marked as WIP?","commit_id":"e8e2e37a77a99284cb9d4b0cb3778074a6a78410"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"ef7608b9e5fb2450f8781529c2faea024294162d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  retries: 5"},{"line_number":42,"context_line":"  delay: 5"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- debug:"},{"line_number":45,"context_line":"    var: results"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"3b740382_42193432","line":45,"range":{"start_line":44,"start_character":1,"end_line":45,"end_character":16},"in_reply_to":"583c97b0_d866a50c","updated":"2026-07-22 11:42:23.000000000","message":"Done","commit_id":"e8e2e37a77a99284cb9d4b0cb3778074a6a78410"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7ba3b3a41294b53dd228b1f73127e9be7f93b05b","unresolved":true,"context_lines":[{"line_number":19,"context_line":"- name: Check kolla-toolbox container status"},{"line_number":20,"context_line":"  become: true"},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    toolbox_container: \"kolla_toolbox\""},{"line_number":23,"context_line":"  kolla_container_facts:"},{"line_number":24,"context_line":"    name: \"{{ toolbox_container }}\""},{"line_number":25,"context_line":"    action: \"get_containers\""}],"source_content_type":"text/x-yaml","patch_set":37,"id":"8bcc4759_ef900719","line":22,"updated":"2026-07-29 13:40:39.000000000","message":"nit: it would be better to be consistent with the other tasks and use the service/service_name vars","commit_id":"40511b7bd09c50575338942f2f367da0cba664e5"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"34c0d357114d8de4723b3e5710ae5ef7625272bc","unresolved":false,"context_lines":[{"line_number":19,"context_line":"- name: Check kolla-toolbox container status"},{"line_number":20,"context_line":"  become: true"},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    toolbox_container: \"kolla_toolbox\""},{"line_number":23,"context_line":"  kolla_container_facts:"},{"line_number":24,"context_line":"    name: \"{{ toolbox_container }}\""},{"line_number":25,"context_line":"    action: \"get_containers\""}],"source_content_type":"text/x-yaml","patch_set":37,"id":"ac232890_2741b558","line":22,"in_reply_to":"8bcc4759_ef900719","updated":"2026-07-29 14:53:00.000000000","message":"Addressed by this: https://review.opendev.org/c/openstack/kolla-ansible/+/986237","commit_id":"40511b7bd09c50575338942f2f367da0cba664e5"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4b9f9236bf7a8a450208e04a69b9acbf5cb07e50","unresolved":true,"context_lines":[{"line_number":28,"context_line":"  until: results.containers[toolbox_container].State.Status \u003d\u003d \"running\""},{"line_number":29,"context_line":"  retries: 10"},{"line_number":30,"context_line":"  delay: 3"},{"line_number":31,"context_line":"  notify:"},{"line_number":32,"context_line":"    - Initializing toolbox container using normal user"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Initializing toolbox container using normal user"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"e26c3893_7d09054d","line":31,"updated":"2026-07-29 14:35:21.000000000","message":"kolla_container_facts always does changed_false, so it won\u0027t emit notification - https://github.com/openstack/kolla-ansible/blob/ede11e81691e6a0a087e103e11100244d76dbb55/ansible/library/kolla_container_facts.py#L131\n\nhandler run but didn\u0027t do notify and Initializing toolbox container didn\u0027t run - https://zuul.opendev.org/t/openstack/build/1ed20ec3d075400fa153be66edc47d0e/log/primary/logs/ansible/deploy#1579\n\nneutron role is using listen for that module, so we may need to adapt the handlers flow - https://github.com/openstack/kolla-ansible/blob/ede11e81691e6a0a087e103e11100244d76dbb55/ansible/roles/neutron/handlers/main.yml#L112","commit_id":"40511b7bd09c50575338942f2f367da0cba664e5"}],"releasenotes/notes/bug-2106001-kolla_toolbox_restart_state_check-e6f7e4855fde22a2.yaml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4a1dd6d01c21f3b12014208a7ad473835f9b20d4","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes kolla_toolbox container restart task by adding check for running"},{"line_number":5,"context_line":"    state so that initialization task does not run before the container is"},{"line_number":6,"context_line":"    fully started."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f180d6be_1c149f91","line":6,"updated":"2025-12-01 13:38:44.000000000","message":"LP link in reno?","commit_id":"947d4bf1edf90fc15b6cd57289a10b0b565a3f9a"},{"author":{"_account_id":34940,"name":"Rafal Lewandowski","display_name":"Rafal Lewandowski","email":"rafal@stackhpc.com","username":"rav"},"change_message_id":"60e51101cee28aa5fd29a72422ad22f155eeb1ca","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixes kolla_toolbox container restart task by adding check for running"},{"line_number":5,"context_line":"    state so that initialization task does not run before the container is"},{"line_number":6,"context_line":"    fully started."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ddf65e57_a352c2cd","line":6,"in_reply_to":"f180d6be_1c149f91","updated":"2025-12-02 21:14:53.000000000","message":"Done","commit_id":"947d4bf1edf90fc15b6cd57289a10b0b565a3f9a"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"4b9f9236bf7a8a450208e04a69b9acbf5cb07e50","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 2106001 \u003chttps://bugs.launchpad.net/designate/+bug/2106001\u003e`_]"},{"line_number":5,"context_line":"    Fixes kolla_toolbox container restart task by adding check for running"},{"line_number":6,"context_line":"    state so that initialization task does not run before the container is"},{"line_number":7,"context_line":"    fully started."}],"source_content_type":"text/x-yaml","patch_set":37,"id":"7aa4864c_86d46bfd","line":4,"updated":"2026-07-29 14:35:21.000000000","message":"```suggestion\n    [`bug 2106001 \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/2106001\u003e`_]\n```","commit_id":"40511b7bd09c50575338942f2f367da0cba664e5"}]}