)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"fe869d1da45bbeab2b15366ef65d8a425c711ef4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"df020f3d_3121b725","updated":"2025-12-09 11:47:31.000000000","message":"LGTM now, thanks!","commit_id":"d16855990386d7e74caaa2558e9641bc41f662fc"}],"roles/kolla-ansible-tempest/tasks/main.yml":[{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"05fadc6fb496b807fbd16d0084987c6e4d044898","unresolved":true,"context_lines":[{"line_number":2,"context_line":"- name: Install required packages"},{"line_number":3,"context_line":"  ansible.builtin.pip:"},{"line_number":4,"context_line":"    name: \"{{ kolla_ansible_tempest_packages + kolla_ansible_tempest_packages_extra }}\""},{"line_number":5,"context_line":"    extra_args: \"-c {{ kolla_ansible_tempest_upper_constraints if kolla_ansible_tempest_upper_constraints | length \u003e 0 }}\""},{"line_number":6,"context_line":"    virtualenv: \"{{ kolla_ansible_venv_path }}\""},{"line_number":7,"context_line":"    virtualenv_command: \"python3 -m venv\""},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"38271c8e_d9bed70b","line":5,"updated":"2025-12-09 10:23:03.000000000","message":"I think we\u0027ll end up with `-c` without any value if `kolla_ansible_tempest_upper_constraints` is not set. Should we instead have this?\n\n```suggestion\n    extra_args: \"{{ (\u0027-c\u0027 + kolla_ansible_tempest_upper_constraints) if kolla_ansible_tempest_upper_constraints | length \u003e 0 }}\"\n```","commit_id":"fa48449e8b11072092f125311c84c5b727876536"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"fe869d1da45bbeab2b15366ef65d8a425c711ef4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Install required packages"},{"line_number":3,"context_line":"  ansible.builtin.pip:"},{"line_number":4,"context_line":"    name: \"{{ kolla_ansible_tempest_packages + kolla_ansible_tempest_packages_extra }}\""},{"line_number":5,"context_line":"    extra_args: \"-c {{ kolla_ansible_tempest_upper_constraints if kolla_ansible_tempest_upper_constraints | length \u003e 0 }}\""},{"line_number":6,"context_line":"    virtualenv: \"{{ kolla_ansible_venv_path }}\""},{"line_number":7,"context_line":"    virtualenv_command: \"python3 -m venv\""},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"baa7f1c8_0bf73847","line":5,"in_reply_to":"38271c8e_d9bed70b","updated":"2025-12-09 11:47:31.000000000","message":"Done","commit_id":"fa48449e8b11072092f125311c84c5b727876536"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"639cd12dd9b1e91c308f27e19bbe5940d30f01bc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Install required packages"},{"line_number":3,"context_line":"  ansible.builtin.pip:"},{"line_number":4,"context_line":"    name: \"{{ kolla_ansible_tempest_packages + kolla_ansible_tempest_packages_extra }}\""},{"line_number":5,"context_line":"    extra_args: \"-c {{ kolla_ansible_tempest_upper_constraints if kolla_ansible_tempest_upper_constraints | length \u003e 0 }}\""},{"line_number":6,"context_line":"    virtualenv: \"{{ kolla_ansible_venv_path }}\""},{"line_number":7,"context_line":"    virtualenv_command: \"python3 -m venv\""},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3d6ee77a_913f2676","line":5,"in_reply_to":"38271c8e_d9bed70b","updated":"2025-12-10 08:51:32.000000000","message":"Fix applied.","commit_id":"fa48449e8b11072092f125311c84c5b727876536"}]}