)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"1bd0484b9b2183beba3eb1e6c6816e461bbf811a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8968a515_82d6a7db","updated":"2026-02-05 08:48:02.000000000","message":"@sahahmadi96@gmail.com you like your code?)","commit_id":"62d754bd6f6b7f52cb1c0563cd118fc7025f4435"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"314323210a0d4c7a6e53807384ea8711e8ffb5e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7819e512_61fab875","updated":"2026-02-05 09:09:52.000000000","message":"This LGTM on the podman side (for documentation only since it\u0027s ignored)\n\nDocker side I would assume works just as well with similar ulimits","commit_id":"62d754bd6f6b7f52cb1c0563cd118fc7025f4435"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4c7e2cd9c78c230cf01dc773d0597c8343988bcf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6d3e33ba_f11424fb","updated":"2026-02-05 15:39:17.000000000","message":"This is changing so fundamental things, that we need a reno for this.","commit_id":"62d754bd6f6b7f52cb1c0563cd118fc7025f4435"},{"author":{"_account_id":37855,"name":"Amir Hossein Ahmadi","display_name":"Amir Hossein","email":"sahahmadi96@gmail.com","username":"amir58118"},"change_message_id":"0b8decb685fec95ab0d3a84940545e8971c2de49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bb7a9c99_2581753c","in_reply_to":"6d3e33ba_f11424fb","updated":"2026-02-05 16:05:41.000000000","message":"Acknowledged","commit_id":"62d754bd6f6b7f52cb1c0563cd118fc7025f4435"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"dcb24190e1d2884784cd92e53a110180efca0d75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"33dee392_91ed069c","updated":"2026-02-11 09:25:49.000000000","message":"Amir, your code is good for you? or what the reason +1 yourself? ;)","commit_id":"e7a2583ce98041dde525b112994484ac4a853231"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"471c3fffd9143869ffaa3dcb8f0ad8f802f12878","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"43f92dd0_bb10e715","updated":"2026-03-24 21:34:16.000000000","message":"I can send +2 now hehe","commit_id":"7504e8f9810de5818c518bd1a33831b6e863bff8"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"376ff31d32dfadd3ff17d5e044c863747949f548","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"15c137c9_49d2787d","updated":"2026-03-02 19:05:21.000000000","message":"LGTM, I think I will try to figure out why podman drops those ulimits next, cause I\u0027m confusedas to why it\u0027s doing it","commit_id":"7504e8f9810de5818c518bd1a33831b6e863bff8"}],"ansible/group_vars/all/common.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d9bdc4bf139a208848fb35b9a1363f31fb12a6a4","unresolved":true,"context_lines":[{"line_number":143,"context_line":"default_docker_dimensions_debian:"},{"line_number":144,"context_line":"  ulimits:"},{"line_number":145,"context_line":"    nofile:"},{"line_number":146,"context_line":"      soft: 65536"},{"line_number":147,"context_line":"      hard: 1048576"},{"line_number":148,"context_line":"    nproc:"},{"line_number":149,"context_line":"      soft: 65536"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"4fd0f90c_e1a08852","line":146,"updated":"2026-01-13 17:39:22.000000000","message":"Why not stick to what we have for RHEL clones? https://www.rabbitmq.com/docs/production-checklist#resource-limits-file-handle-limit states 500k is not inadequate, so 1M is not going to hurt?\n\nIf you are going to go that way - I think this could be refactored into just one variable (or two one for Docker other for Podman)","commit_id":"f098643666ba9d7cea323510ce1e9391a9d7ff5c"},{"author":{"_account_id":37855,"name":"Amir Hossein Ahmadi","display_name":"Amir Hossein","email":"sahahmadi96@gmail.com","username":"amir58118"},"change_message_id":"f581bc5e6e73fab83177cd63dd5d0975abdce760","unresolved":false,"context_lines":[{"line_number":143,"context_line":"default_docker_dimensions_debian:"},{"line_number":144,"context_line":"  ulimits:"},{"line_number":145,"context_line":"    nofile:"},{"line_number":146,"context_line":"      soft: 65536"},{"line_number":147,"context_line":"      hard: 1048576"},{"line_number":148,"context_line":"    nproc:"},{"line_number":149,"context_line":"      soft: 65536"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"24b95111_e4e9bdbf","line":146,"in_reply_to":"4fd0f90c_e1a08852","updated":"2026-01-28 06:23:30.000000000","message":"Thanks, that makes sense.\n\nI agree that OS-based branching is unnecessary here. Refactoring this into runtime-based defaults (Docker vs Podman) with a single, common set of limits would be cleaner and easier to maintain. I’ll update the patch accordingly.","commit_id":"f098643666ba9d7cea323510ce1e9391a9d7ff5c"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"03d8968dde47ca8cae38706fe1a00876a88c7e78","unresolved":true,"context_lines":[{"line_number":115,"context_line":"      soft: 65536"},{"line_number":116,"context_line":"      hard: 1048576"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"default_container_dimensions_podman:"},{"line_number":119,"context_line":"  ulimits:"},{"line_number":120,"context_line":"    RLIMIT_NOFILE:"},{"line_number":121,"context_line":"      soft: 65536"},{"line_number":122,"context_line":"      hard: 1048576"},{"line_number":123,"context_line":"    RLIMIT_NPROC:"},{"line_number":124,"context_line":"      soft: 65536"},{"line_number":125,"context_line":"      hard: 1048576"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"#####################"},{"line_number":128,"context_line":"# Healthcheck options"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9c618e71_d12a5ef1","line":125,"range":{"start_line":118,"start_character":0,"end_line":125,"end_character":19},"updated":"2026-01-29 14:39:28.000000000","message":"ulimits are currently dropped on podman (see https://opendev.org/openstack/kolla-ansible/src/branch/master/ansible/module_utils/kolla_podman_worker.py#L206-L230 and https://opendev.org/openstack/kolla-ansible/src/branch/master/ansible/module_utils/kolla_podman_worker.py#L450-L522) \n\nso I\u0027m not sure we actually need those ? they will be ignored regardless.","commit_id":"818464bc3c553a7ba34131436a0766fb8e02d212"},{"author":{"_account_id":37855,"name":"Amir Hossein Ahmadi","display_name":"Amir Hossein","email":"sahahmadi96@gmail.com","username":"amir58118"},"change_message_id":"5acaf46630dc62a7d6f687f5e8dd25a0472bb99c","unresolved":false,"context_lines":[{"line_number":115,"context_line":"      soft: 65536"},{"line_number":116,"context_line":"      hard: 1048576"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"default_container_dimensions_podman:"},{"line_number":119,"context_line":"  ulimits:"},{"line_number":120,"context_line":"    RLIMIT_NOFILE:"},{"line_number":121,"context_line":"      soft: 65536"},{"line_number":122,"context_line":"      hard: 1048576"},{"line_number":123,"context_line":"    RLIMIT_NPROC:"},{"line_number":124,"context_line":"      soft: 65536"},{"line_number":125,"context_line":"      hard: 1048576"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"#####################"},{"line_number":128,"context_line":"# Healthcheck options"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"8621bf56_f13049ec","line":125,"range":{"start_line":118,"start_character":0,"end_line":125,"end_character":19},"in_reply_to":"594cc8be_1fdda62a","updated":"2026-02-04 11:01:27.000000000","message":"Agreed, Podman currently drops these ulimits.\nI’ve added a comment to document this and kept them intentionally for future compatibility.","commit_id":"818464bc3c553a7ba34131436a0766fb8e02d212"},{"author":{"_account_id":37855,"name":"Amir Hossein Ahmadi","display_name":"Amir Hossein","email":"sahahmadi96@gmail.com","username":"amir58118"},"change_message_id":"81bc585afd7b99c0eb1844be6b8d0a12670e5828","unresolved":true,"context_lines":[{"line_number":115,"context_line":"      soft: 65536"},{"line_number":116,"context_line":"      hard: 1048576"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"default_container_dimensions_podman:"},{"line_number":119,"context_line":"  ulimits:"},{"line_number":120,"context_line":"    RLIMIT_NOFILE:"},{"line_number":121,"context_line":"      soft: 65536"},{"line_number":122,"context_line":"      hard: 1048576"},{"line_number":123,"context_line":"    RLIMIT_NPROC:"},{"line_number":124,"context_line":"      soft: 65536"},{"line_number":125,"context_line":"      hard: 1048576"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"#####################"},{"line_number":128,"context_line":"# Healthcheck options"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"594cc8be_1fdda62a","line":125,"range":{"start_line":118,"start_character":0,"end_line":125,"end_character":19},"in_reply_to":"9c618e71_d12a5ef1","updated":"2026-01-29 18:25:14.000000000","message":"Thanks, I\u0027ll check those links.","commit_id":"818464bc3c553a7ba34131436a0766fb8e02d212"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"6b17653230db2ce4fc8debe96f1bfa811942cd06","unresolved":true,"context_lines":[{"line_number":99,"context_line":"#                  and databases)."},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"default_container_dimensions: \u003e-"},{"line_number":103,"context_line":"  {{"},{"line_number":104,"context_line":"    default_container_dimensions_docker"},{"line_number":105,"context_line":"    if kolla_container_engine \u003d\u003d \u0027docker\u0027"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"558f032d_4e7d93cd","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":32},"updated":"2026-02-17 14:45:38.000000000","message":"While the final decision isn\u0027t up to me, I have serious reservations about this approach. This change effectively forces the same limits on all distributions (Ubuntu, Debian, CentOS, Rocky), which is a significant architectural shift for Kolla Ansible. We are moving away from OS-specific tuning to a \"one size fits all\" model without a clear justification for why these specific values are optimal for everyone.","commit_id":"e7a2583ce98041dde525b112994484ac4a853231"},{"author":{"_account_id":37855,"name":"Amir Hossein Ahmadi","display_name":"Amir Hossein","email":"sahahmadi96@gmail.com","username":"amir58118"},"change_message_id":"13515cbf4b8c1e8ffb8b4d8c2f7fbf298b3605b7","unresolved":true,"context_lines":[{"line_number":99,"context_line":"#                  and databases)."},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"default_container_dimensions: \u003e-"},{"line_number":103,"context_line":"  {{"},{"line_number":104,"context_line":"    default_container_dimensions_docker"},{"line_number":105,"context_line":"    if kolla_container_engine \u003d\u003d \u0027docker\u0027"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"daf696c1_b2d15e04","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":32},"in_reply_to":"558f032d_4e7d93cd","updated":"2026-02-18 12:02:10.000000000","message":"These values are not new. They reuse the existing EL9 ulimit defaults already\nused in Kolla Ansible, avoiding the introduction of new tuning parameters.","commit_id":"e7a2583ce98041dde525b112994484ac4a853231"},{"author":{"_account_id":37855,"name":"Amir Hossein Ahmadi","display_name":"Amir Hossein","email":"sahahmadi96@gmail.com","username":"amir58118"},"change_message_id":"c688544530e9a8539ab7793269bd27f7c52db1fb","unresolved":false,"context_lines":[{"line_number":99,"context_line":"#                  and databases)."},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"default_container_dimensions: \u003e-"},{"line_number":103,"context_line":"  {{"},{"line_number":104,"context_line":"    default_container_dimensions_docker"},{"line_number":105,"context_line":"    if kolla_container_engine \u003d\u003d \u0027docker\u0027"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bcd4666c_8bccab63","line":102,"range":{"start_line":102,"start_character":0,"end_line":102,"end_character":32},"in_reply_to":"daf696c1_b2d15e04","updated":"2026-02-19 15:03:09.000000000","message":"Acknowledged","commit_id":"e7a2583ce98041dde525b112994484ac4a853231"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f65f7ff80e72e30078848f56c9acd8f68aeb9ed4","unresolved":true,"context_lines":[{"line_number":109,"context_line":"default_container_dimensions_docker:"},{"line_number":110,"context_line":"  ulimits:"},{"line_number":111,"context_line":"    nofile:"},{"line_number":112,"context_line":"      soft: 65536"},{"line_number":113,"context_line":"      hard: 1048576"},{"line_number":114,"context_line":"    nproc:"},{"line_number":115,"context_line":"      soft: 65536"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"a4388b5b_a1a9ae38","line":112,"updated":"2026-02-17 09:54:49.000000000","message":"Why?","commit_id":"e7a2583ce98041dde525b112994484ac4a853231"},{"author":{"_account_id":37855,"name":"Amir Hossein Ahmadi","display_name":"Amir Hossein","email":"sahahmadi96@gmail.com","username":"amir58118"},"change_message_id":"13515cbf4b8c1e8ffb8b4d8c2f7fbf298b3605b7","unresolved":true,"context_lines":[{"line_number":109,"context_line":"default_container_dimensions_docker:"},{"line_number":110,"context_line":"  ulimits:"},{"line_number":111,"context_line":"    nofile:"},{"line_number":112,"context_line":"      soft: 65536"},{"line_number":113,"context_line":"      hard: 1048576"},{"line_number":114,"context_line":"    nproc:"},{"line_number":115,"context_line":"      soft: 65536"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"ed3a997d_59289572","line":112,"in_reply_to":"a4388b5b_a1a9ae38","updated":"2026-02-18 12:02:10.000000000","message":"Thanks for the feedback. This change does not introduce new limits; it reuses\nexisting EL9 defaults and applies them only where ulimits are missing to keep\nbehavior consistent.","commit_id":"e7a2583ce98041dde525b112994484ac4a853231"},{"author":{"_account_id":37855,"name":"Amir Hossein Ahmadi","display_name":"Amir Hossein","email":"sahahmadi96@gmail.com","username":"amir58118"},"change_message_id":"c688544530e9a8539ab7793269bd27f7c52db1fb","unresolved":false,"context_lines":[{"line_number":109,"context_line":"default_container_dimensions_docker:"},{"line_number":110,"context_line":"  ulimits:"},{"line_number":111,"context_line":"    nofile:"},{"line_number":112,"context_line":"      soft: 65536"},{"line_number":113,"context_line":"      hard: 1048576"},{"line_number":114,"context_line":"    nproc:"},{"line_number":115,"context_line":"      soft: 65536"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5a5c00c9_33c6dfc8","line":112,"in_reply_to":"ed3a997d_59289572","updated":"2026-02-19 15:03:09.000000000","message":"Acknowledged","commit_id":"e7a2583ce98041dde525b112994484ac4a853231"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f65f7ff80e72e30078848f56c9acd8f68aeb9ed4","unresolved":true,"context_lines":[{"line_number":111,"context_line":"    nofile:"},{"line_number":112,"context_line":"      soft: 65536"},{"line_number":113,"context_line":"      hard: 1048576"},{"line_number":114,"context_line":"    nproc:"},{"line_number":115,"context_line":"      soft: 65536"},{"line_number":116,"context_line":"      hard: 1048576"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"870b6722_16874d81","line":114,"updated":"2026-02-17 09:54:49.000000000","message":"Why?","commit_id":"e7a2583ce98041dde525b112994484ac4a853231"},{"author":{"_account_id":37855,"name":"Amir Hossein Ahmadi","display_name":"Amir Hossein","email":"sahahmadi96@gmail.com","username":"amir58118"},"change_message_id":"c688544530e9a8539ab7793269bd27f7c52db1fb","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    nofile:"},{"line_number":112,"context_line":"      soft: 65536"},{"line_number":113,"context_line":"      hard: 1048576"},{"line_number":114,"context_line":"    nproc:"},{"line_number":115,"context_line":"      soft: 65536"},{"line_number":116,"context_line":"      hard: 1048576"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"8cfe6f2b_cb605004","line":114,"in_reply_to":"52bfc943_bec4013e","updated":"2026-02-19 15:03:09.000000000","message":"Acknowledged","commit_id":"e7a2583ce98041dde525b112994484ac4a853231"},{"author":{"_account_id":37855,"name":"Amir Hossein Ahmadi","display_name":"Amir Hossein","email":"sahahmadi96@gmail.com","username":"amir58118"},"change_message_id":"13515cbf4b8c1e8ffb8b4d8c2f7fbf298b3605b7","unresolved":true,"context_lines":[{"line_number":111,"context_line":"    nofile:"},{"line_number":112,"context_line":"      soft: 65536"},{"line_number":113,"context_line":"      hard: 1048576"},{"line_number":114,"context_line":"    nproc:"},{"line_number":115,"context_line":"      soft: 65536"},{"line_number":116,"context_line":"      hard: 1048576"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"52bfc943_bec4013e","line":114,"in_reply_to":"870b6722_16874d81","updated":"2026-02-18 12:02:10.000000000","message":"Same!","commit_id":"e7a2583ce98041dde525b112994484ac4a853231"}]}