)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37855,"name":"Amir Hossein Ahmadi","display_name":"Amir Hossein","email":"sahahmadi96@gmail.com","username":"amir58118"},"change_message_id":"c8e418ae34eb549d4ebbbfdc62445ed82eda83c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7c155bcb_754781bf","updated":"2026-02-11 09:00:20.000000000","message":"This enhances security and aligns well with best practices for containerized services. LGTM.","commit_id":"b3fcfed0cee278fe7c450a3c7525d3b1cf8dfb11"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e4ce463d62e9684522165a639037611d8ebf6cb9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"843970dd_e44d2381","updated":"2026-02-18 09:36:32.000000000","message":"LGTM, but needs a reno","commit_id":"3221934ace0656f97b612f2972c7b859e5edd5a8"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bd6b90f6dba000cbe6b7d85a4ae317dc3778bdc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"43cb3998_fddfe221","in_reply_to":"843970dd_e44d2381","updated":"2026-03-25 07:12:53.000000000","message":"Done","commit_id":"3221934ace0656f97b612f2972c7b859e5edd5a8"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"2e5fb87c639230be50910df4ad6de22a687dbf8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7ebad15b_ee80fbf3","updated":"2026-02-18 17:27:26.000000000","message":"recheck - ci should be fixed","commit_id":"d153fda20d08a7fbcf6a57597d41dafa85b65660"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"0d9551be1bdc71c44877acddd44b5ecf561fde99","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2828d828_fd20af2e","updated":"2026-03-25 08:07:23.000000000","message":"Why ignore podman for this ? I\u0027d say it equally needs it (as well as test coverage)","commit_id":"b8354dde1ea8e35e8aa13912478e0355c44684a9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"0d57f8af0964423c4a1908dac937c1b19e8df203","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c971ba25_44ddc690","updated":"2026-03-25 09:35:43.000000000","message":"adding Podman here will make this review is more bigger and harder to review and maintain","commit_id":"b8354dde1ea8e35e8aa13912478e0355c44684a9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"325c9d51bcd3f41c9bce3c0d80c8055ab6fff2be","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b97b1ece_821fdb20","updated":"2026-03-25 09:34:30.000000000","message":"may be add support for Podman in the followup?","commit_id":"b8354dde1ea8e35e8aa13912478e0355c44684a9"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"2d006b259e1b1ce4d4f151d289681eb92ddf19c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b4118030_56927811","in_reply_to":"0e4a3f90_1d057967","updated":"2026-03-30 10:21:15.000000000","message":"Acknowledged","commit_id":"b8354dde1ea8e35e8aa13912478e0355c44684a9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6c98c151d8b94aad7dbab4afedeb427d299ee096","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0e4a3f90_1d057967","in_reply_to":"2828d828_fd20af2e","updated":"2026-03-25 09:26:53.000000000","message":"Right, I live in Docker world, completely forgot about this :-)","commit_id":"b8354dde1ea8e35e8aa13912478e0355c44684a9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f6d70d59c68d0a399fad37a40f830f0de2933098","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"eb808c4d_74acbda3","in_reply_to":"6e8d0ba3_36bd248c","updated":"2026-03-25 09:56:49.000000000","message":"So either this patch, or a followup patch stacked on top of this - but we can merge both once we have podman in here.","commit_id":"b8354dde1ea8e35e8aa13912478e0355c44684a9"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"2d006b259e1b1ce4d4f151d289681eb92ddf19c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5f02d0ba_6c7bfe53","in_reply_to":"b97b1ece_821fdb20","updated":"2026-03-30 10:21:15.000000000","message":"Acknowledged","commit_id":"b8354dde1ea8e35e8aa13912478e0355c44684a9"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"d3f34242b5c9e5f9da91266b0b53e52b646b76a4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6e8d0ba3_36bd248c","in_reply_to":"c971ba25_44ddc690","updated":"2026-03-25 09:49:12.000000000","message":"or this indeed, maybe create a chained patch for podman ?","commit_id":"b8354dde1ea8e35e8aa13912478e0355c44684a9"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"2d006b259e1b1ce4d4f151d289681eb92ddf19c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2857101f_b03d973e","in_reply_to":"eb808c4d_74acbda3","updated":"2026-03-30 10:21:15.000000000","message":"Acknowledged","commit_id":"b8354dde1ea8e35e8aa13912478e0355c44684a9"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"a069dd197faa5a201d0a19fb1512e142f424308a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"54cace0c_8bd7c7df","updated":"2026-03-25 09:55:39.000000000","message":"I also forgot about Podman :)\nI did as much testing as I could, mostly based on how others approached it, but overall the Podman test feels kinda “meh” 🙂","commit_id":"2ffc6ac262e7cbf59983ecfe385db48b7755f797"}],"ansible/library/kolla_container.py":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"08e667a555bd4066a8e534568feeba4ae4559263","unresolved":true,"context_lines":[{"line_number":166,"context_line":"    type: bool"},{"line_number":167,"context_line":"  user:"},{"line_number":168,"context_line":"    description:"},{"line_number":169,"context_line":"      - Username or UID to use of the container"},{"line_number":170,"context_line":"    required: False"},{"line_number":171,"context_line":"    type: str"},{"line_number":172,"context_line":"  remove_on_exit:"}],"source_content_type":"text/x-python","patch_set":6,"id":"2a3ae594_647814d7","line":169,"updated":"2026-03-25 07:12:42.000000000","message":"```suggestion\n      - Username or UID to use in the container\n```","commit_id":"d153fda20d08a7fbcf6a57597d41dafa85b65660"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"042551209ec873f70744ca2fb5b545719f9e53d2","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    type: bool"},{"line_number":167,"context_line":"  user:"},{"line_number":168,"context_line":"    description:"},{"line_number":169,"context_line":"      - Username or UID to use of the container"},{"line_number":170,"context_line":"    required: False"},{"line_number":171,"context_line":"    type: str"},{"line_number":172,"context_line":"  remove_on_exit:"}],"source_content_type":"text/x-python","patch_set":6,"id":"facf4e4d_ae83cf59","line":169,"in_reply_to":"2a3ae594_647814d7","updated":"2026-03-25 07:13:00.000000000","message":"Fix applied.","commit_id":"d153fda20d08a7fbcf6a57597d41dafa85b65660"}],"ansible/module_utils/kolla_docker_worker.py":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e87c3f171a52919257e43382a0417d60348241f8","unresolved":true,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def build_host_config(self, binds):"},{"line_number":278,"context_line":"        options \u003d {"},{"line_number":279,"context_line":"            \u0027cap_add\u0027: self.params.get(\u0027cap_add\u0027),"},{"line_number":280,"context_line":"            \u0027network_mode\u0027: \u0027host\u0027,"},{"line_number":281,"context_line":"            \u0027ipc_mode\u0027: self.params.get(\u0027ipc_mode\u0027),"},{"line_number":282,"context_line":"            \u0027security_opt\u0027: self.params.get(\u0027security_opt\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"6afdf68b_1c5e4662","line":279,"updated":"2026-01-28 20:13:59.000000000","message":"I don’t think moving this is required, unless you want to have a go at making this sorted alphabetically","commit_id":"8d7f98513db44ecc462bc782669277dc62523416"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"a1e139309b7eadf469425808a06b571a108fae34","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def build_host_config(self, binds):"},{"line_number":278,"context_line":"        options \u003d {"},{"line_number":279,"context_line":"            \u0027cap_add\u0027: self.params.get(\u0027cap_add\u0027),"},{"line_number":280,"context_line":"            \u0027network_mode\u0027: \u0027host\u0027,"},{"line_number":281,"context_line":"            \u0027ipc_mode\u0027: self.params.get(\u0027ipc_mode\u0027),"},{"line_number":282,"context_line":"            \u0027security_opt\u0027: self.params.get(\u0027security_opt\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"90882359_6d5492ed","line":279,"in_reply_to":"6afdf68b_1c5e4662","updated":"2026-02-02 18:40:54.000000000","message":"Acknowledged","commit_id":"8d7f98513db44ecc462bc782669277dc62523416"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e87c3f171a52919257e43382a0417d60348241f8","unresolved":true,"context_lines":[{"line_number":322,"context_line":"            \u0027image\u0027: self.params.get(\u0027image\u0027),"},{"line_number":323,"context_line":"            \u0027name\u0027: self.params.get(\u0027name\u0027),"},{"line_number":324,"context_line":"            \u0027volumes\u0027: volumes,"},{"line_number":325,"context_line":"            \u0027user\u0027: self.params.get(\u0027user\u0027),"},{"line_number":326,"context_line":"            \u0027tty\u0027: self.params.get(\u0027tty\u0027),"},{"line_number":327,"context_line":"        }"},{"line_number":328,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a17a85b_c2c7b9ef","line":325,"updated":"2026-01-28 20:13:59.000000000","message":"Let’s sort this alphabetically as well","commit_id":"8d7f98513db44ecc462bc782669277dc62523416"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"a1e139309b7eadf469425808a06b571a108fae34","unresolved":false,"context_lines":[{"line_number":322,"context_line":"            \u0027image\u0027: self.params.get(\u0027image\u0027),"},{"line_number":323,"context_line":"            \u0027name\u0027: self.params.get(\u0027name\u0027),"},{"line_number":324,"context_line":"            \u0027volumes\u0027: volumes,"},{"line_number":325,"context_line":"            \u0027user\u0027: self.params.get(\u0027user\u0027),"},{"line_number":326,"context_line":"            \u0027tty\u0027: self.params.get(\u0027tty\u0027),"},{"line_number":327,"context_line":"        }"},{"line_number":328,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fe42da50_1d114573","line":325,"in_reply_to":"9a17a85b_c2c7b9ef","updated":"2026-02-02 18:40:54.000000000","message":"Acknowledged","commit_id":"8d7f98513db44ecc462bc782669277dc62523416"}]}
