)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"6bfb22a83356e179ad7b1fbea390ad39092c23c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"60cf691d_93bdf49f","updated":"2026-06-09 07:02:18.000000000","message":"recheck\nCI fixes landed","commit_id":"caba6d355a7fdaf79cc1aba565532c49587076c4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b0b483e2e473748e0c3bd0116f8d9eb98393a400","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"3596761c_af5cb79c","updated":"2026-06-10 16:59:05.000000000","message":"This overall looks good, but I have two comments:\n- please remove legacy upgrade logic first in a separate commit\n- I think it would make sense to have neutron-agents-ovs, neutron-agents-ovn, neutron-agents-shared-compute and neutron-agents-shared-network to get rid of the massive when: neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 repetition and it will make it easier to remove ML2/OVS at some point in time and last but not least - will improve performance because roles would be targeted to smaller amount of hosts\n\nOne of the awkward agents is neutron-dhcp-agent, which has an optional knob of being run in ML2/OVN scenario for bare metal - but I think the considerations of running this instead of the native OVN DHCP are no longer there - so we could drop it (in a separate patch)","commit_id":"f5ae434a0ab55b7d9231458930e02287011e2ca4"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"8530d3bc2ff8fe269493e839be57126fb438caf5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"7c579728_d7ea7cee","in_reply_to":"3596761c_af5cb79c","updated":"2026-06-11 10:39:45.000000000","message":"Agreed on the split. I\u0027d rather do it as a follow-up  on top of this one so this stays reviewable, unless you want it squashed in here? \nLegacy upgrade removal is now a separate change below this one. \n+1 on dropping neutron-dhcp-agent for OVN baremetal in a separate patch. (coming soon)","commit_id":"f5ae434a0ab55b7d9231458930e02287011e2ca4"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"e00e671fe0781b8230be31fc483fdbd90902c189","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"ac560d20_875fca96","in_reply_to":"7c579728_d7ea7cee","updated":"2026-06-11 11:15:30.000000000","message":"https://review.opendev.org/c/openstack/kolla-ansible/+/992880\n\nhttps://review.opendev.org/c/openstack/kolla-ansible/+/992881","commit_id":"f5ae434a0ab55b7d9231458930e02287011e2ca4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b00cdf7f00ce2b1f8841bdfbd8f388932c3d2f4c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"2d5e0207_5db8faef","in_reply_to":"ac560d20_875fca96","updated":"2026-07-07 16:50:31.000000000","message":"So, I still think the order should be:\n1. Drop legacy upgrade logic\n2. Drop dhcp-agent for bare metal in ML2/OVN\n3. Split out neutron-agents-ovs neutron-agents-ovn neutron-agents-shared-compute and neutron-agents-shared-network (can be 4 separate patches)","commit_id":"f5ae434a0ab55b7d9231458930e02287011e2ca4"}],"ansible/roles/neutron-agents/templates/neutron.conf.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b0b483e2e473748e0c3bd0116f8d9eb98393a400","unresolved":true,"context_lines":[{"line_number":2,"context_line":"[DEFAULT]"},{"line_number":3,"context_line":"debug \u003d {{ neutron_logging_debug }}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% if service_name \u003d\u003d \"neutron-server\" %}"},{"line_number":6,"context_line":"log_file \u003d /var/log/kolla/neutron/neutron-server.log"},{"line_number":7,"context_line":"{% else %}"},{"line_number":8,"context_line":"log_dir \u003d /var/log/kolla/neutron"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"94b50102_390bb48c","line":5,"updated":"2026-06-10 16:59:05.000000000","message":"dead end?","commit_id":"f5ae434a0ab55b7d9231458930e02287011e2ca4"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"8530d3bc2ff8fe269493e839be57126fb438caf5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"[DEFAULT]"},{"line_number":3,"context_line":"debug \u003d {{ neutron_logging_debug }}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% if service_name \u003d\u003d \"neutron-server\" %}"},{"line_number":6,"context_line":"log_file \u003d /var/log/kolla/neutron/neutron-server.log"},{"line_number":7,"context_line":"{% else %}"},{"line_number":8,"context_line":"log_dir \u003d /var/log/kolla/neutron"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"860b708d_aad9f033","line":5,"in_reply_to":"94b50102_390bb48c","updated":"2026-06-11 10:39:45.000000000","message":"Done","commit_id":"f5ae434a0ab55b7d9231458930e02287011e2ca4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"b0b483e2e473748e0c3bd0116f8d9eb98393a400","unresolved":true,"context_lines":[{"line_number":8,"context_line":"log_dir \u003d /var/log/kolla/neutron"},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# NOTE(elemoine): set use_stderr to false or the logs will also be sent to"},{"line_number":12,"context_line":"# stderr and collected by Docker"},{"line_number":13,"context_line":"use_stderr \u003d false"},{"line_number":14,"context_line":"bind_host \u003d {{ api_interface_address }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"bind_port \u003d {{ neutron_server_listen_port }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"api_paste_config \u003d /etc/neutron/api-paste.ini"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"api_workers \u003d {{ neutron_api_workers }}"},{"line_number":21,"context_line":"rpc_workers \u003d {{ openstack_service_rpc_workers }}"},{"line_number":22,"context_line":"rpc_state_report_workers \u003d {{ openstack_service_rpc_workers }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"state_path \u003d /var/lib/neutron/kolla"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"c7b60ae3_67daa13e","line":22,"range":{"start_line":11,"start_character":0,"end_line":22,"end_character":62},"updated":"2026-06-10 16:59:05.000000000","message":"I think this is not required in agents neutron.conf","commit_id":"f5ae434a0ab55b7d9231458930e02287011e2ca4"},{"author":{"_account_id":35345,"name":"Grzegorz Koper","email":"grzegorzk@stackhpc.com","username":"gkoper"},"change_message_id":"8530d3bc2ff8fe269493e839be57126fb438caf5","unresolved":false,"context_lines":[{"line_number":8,"context_line":"log_dir \u003d /var/log/kolla/neutron"},{"line_number":9,"context_line":"{% endif %}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# NOTE(elemoine): set use_stderr to false or the logs will also be sent to"},{"line_number":12,"context_line":"# stderr and collected by Docker"},{"line_number":13,"context_line":"use_stderr \u003d false"},{"line_number":14,"context_line":"bind_host \u003d {{ api_interface_address }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"bind_port \u003d {{ neutron_server_listen_port }}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"api_paste_config \u003d /etc/neutron/api-paste.ini"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"api_workers \u003d {{ neutron_api_workers }}"},{"line_number":21,"context_line":"rpc_workers \u003d {{ openstack_service_rpc_workers }}"},{"line_number":22,"context_line":"rpc_state_report_workers \u003d {{ openstack_service_rpc_workers }}"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"state_path \u003d /var/lib/neutron/kolla"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"e3690388_a0bb5f44","line":22,"range":{"start_line":11,"start_character":0,"end_line":22,"end_character":62},"in_reply_to":"c7b60ae3_67daa13e","updated":"2026-06-11 10:39:45.000000000","message":"Done","commit_id":"f5ae434a0ab55b7d9231458930e02287011e2ca4"}]}