)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"0006cd263729582eb48b6d25f84a25c4e9fd37b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a8a433c3_0dd16329","updated":"2026-02-10 17:46:16.000000000","message":"This LGTM, failures are because of pkg_resources","commit_id":"427202af659746a6e1bf4285c4f6156eefd4315c"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"ba6afdd813817c2cab8df389c1e6a7779b2152c6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c68373a3_0052e271","updated":"2026-02-10 15:18:42.000000000","message":"will need to decouple the permission bits to be able to backport it","commit_id":"427202af659746a6e1bf4285c4f6156eefd4315c"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"fcb15687530e060ff43410cf6b68157d6f4f8f1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"69e8924c_76bcc75e","in_reply_to":"c68373a3_0052e271","updated":"2026-02-11 15:42:41.000000000","message":"Done","commit_id":"427202af659746a6e1bf4285c4f6156eefd4315c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5eae1bb0ef788305587dda5005d43bee6f7276a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"18e9d521_eb08fb01","updated":"2026-02-11 16:42:19.000000000","message":"Lgtm","commit_id":"be29193b5e413d061b6f8b8307f244657134ac48"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"35b5ed5b2e8d34e5a6037a31616e36b3acde7842","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cd5f8b9b_1d5901d4","updated":"2026-02-11 18:07:36.000000000","message":"Thanks for this. I\u0027m fine if we don\u0027t handle the issue below in this patch.","commit_id":"be29193b5e413d061b6f8b8307f244657134ac48"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5a57990ecda2f2bce87f63378cb978d795c5a88a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d18dd325_fdd478dd","updated":"2026-02-11 19:42:35.000000000","message":"recheck unrelated podman failure, might be a race condition","commit_id":"be29193b5e413d061b6f8b8307f244657134ac48"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"5fcdf337271a5beb18c00c0e6add45b631f7abcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8811e041_b78b8a16","in_reply_to":"d18dd325_fdd478dd","updated":"2026-02-11 22:00:48.000000000","message":"Done","commit_id":"be29193b5e413d061b6f8b8307f244657134ac48"}],"ansible/roles/service-check-containers/tasks/iterated.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"35b5ed5b2e8d34e5a6037a31616e36b3acde7842","unresolved":true,"context_lines":[{"line_number":30,"context_line":"# For details see https://github.com/ansible/ansible/issues/22579"},{"line_number":31,"context_line":"- name: \"Notify handlers to restart containers for {{ kolla_role_name | default(project_name) }}\""},{"line_number":32,"context_line":"  vars:"},{"line_number":33,"context_line":"    handler: \"{{ [\u0027Restart \u0027 + outer_item.key + \u0027 container\u0027] if container_check is changed else [] }}\""},{"line_number":34,"context_line":"  debug:"},{"line_number":35,"context_line":"    msg: \"{{ (\u0027Notifying handlers: \u0027 + handler | join(\u0027,\u0027)) if container_check is changed else \u0027Nothing changed - not notifying handlers\u0027 }}\""},{"line_number":36,"context_line":"  changed_when: container_check is changed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dc8f3977_18b54420","line":33,"updated":"2026-02-11 18:07:36.000000000","message":"This task really needs to loop over each result in ``container_check`` and then notify the handler to restart only containers that have changed, via a var or something.\n\nCurrently, this will restart /all/ of the service containers even if only one instance has changed.\n\nEg.\n- iterate_count \u003d 3\n- service_foo_2 gets deleted on a single host for some reason\n- service_foo_1/2/3 all get restarted on all hosts\n\nIt is better than before at least. I think the overall \u0027changed\u0027 status should stop restarting everything all of the time.","commit_id":"427202af659746a6e1bf4285c4f6156eefd4315c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"45ed2bf73133b53d0886c547dbe8306f6ac17190","unresolved":true,"context_lines":[{"line_number":30,"context_line":"# For details see https://github.com/ansible/ansible/issues/22579"},{"line_number":31,"context_line":"- name: \"Notify handlers to restart containers for {{ kolla_role_name | default(project_name) }}\""},{"line_number":32,"context_line":"  vars:"},{"line_number":33,"context_line":"    handler: \"{{ [\u0027Restart \u0027 + outer_item.key + \u0027 container\u0027] if container_check is changed else [] }}\""},{"line_number":34,"context_line":"  debug:"},{"line_number":35,"context_line":"    msg: \"{{ (\u0027Notifying handlers: \u0027 + handler | join(\u0027,\u0027)) if container_check is changed else \u0027Nothing changed - not notifying handlers\u0027 }}\""},{"line_number":36,"context_line":"  changed_when: container_check is changed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3bce1076_2d1c2299","line":33,"in_reply_to":"3185dc9a_d4418e73","updated":"2026-02-12 17:04:34.000000000","message":"Something like this perhaps: https://review.opendev.org/c/openstack/kolla-ansible/+/976659","commit_id":"427202af659746a6e1bf4285c4f6156eefd4315c"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"d59266f2553c3eb20a0365b2e5bd6cb9d3a45d19","unresolved":true,"context_lines":[{"line_number":30,"context_line":"# For details see https://github.com/ansible/ansible/issues/22579"},{"line_number":31,"context_line":"- name: \"Notify handlers to restart containers for {{ kolla_role_name | default(project_name) }}\""},{"line_number":32,"context_line":"  vars:"},{"line_number":33,"context_line":"    handler: \"{{ [\u0027Restart \u0027 + outer_item.key + \u0027 container\u0027] if container_check is changed else [] }}\""},{"line_number":34,"context_line":"  debug:"},{"line_number":35,"context_line":"    msg: \"{{ (\u0027Notifying handlers: \u0027 + handler | join(\u0027,\u0027)) if container_check is changed else \u0027Nothing changed - not notifying handlers\u0027 }}\""},{"line_number":36,"context_line":"  changed_when: container_check is changed"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3185dc9a_d4418e73","line":33,"in_reply_to":"dc8f3977_18b54420","updated":"2026-02-12 09:22:17.000000000","message":"I\u0027ll take a look into that","commit_id":"427202af659746a6e1bf4285c4f6156eefd4315c"}]}