)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11915,"name":"Jan Klare","email":"klare@osism.tech","username":"jklare"},"change_message_id":"9546b5efb91af0b105e114bb24960be2b278b003","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0920e0e2_aa3df312","updated":"2026-02-13 07:32:27.000000000","message":"Hi, thanks for the PR. I have two comments here:\n1) In addition to adding code for the new exporter, this commit also seems to remove the endpoints line for rabbitmq. Is this intendend? If so, this should be mentioned in the commit message.\n2) Although the exporter can export valkey and redis metrics, the upstream image that is imported here is called redis_exporter, so i think we probably should not change/overwrite that here.","commit_id":"1781658bde4f7d6ef0b0d985135cb3a27bb7cfa4"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"8ea54485dc517063c9be12a26ab75d728804f742","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"de65866b_5f138d1e","in_reply_to":"0920e0e2_aa3df312","updated":"2026-02-13 09:18:45.000000000","message":"In my opinion, keeping the Valkey endpoints in the blackbox_exporter configuration is redundant and unnecessary once the dedicated prometheus-valkey-exporter is introduced.\n\nCurrently, the blackbox exporter is used to monitor generic endpoints and basic TCP connectivity, like this:\n\nYAML\n  - job_name: blackbox_exporter\n    ...\n    static_configs:\n    - targets:\n      - skyline_apiserver:os_endpoint:https://\u003cinternal-url\u003e:9998\n      - valkey_\u003cHOST-IP\u003e:tcp_connect:\u003cinternal-ip\u003e:6379\n      - nova:os_endpoint:https://\u003cinternal-url\u003e:8774\n      - neutron:os_endpoint:https://\u003cinternal-url\u003e:9696\n      ...\nThe new prometheus-valkey-exporter provides much deeper insights into the service status than a simple TCP check. Keeping both creates duplicate alerts and unnecessary noise in the configuration.\n\nI believe switching to valkey naming improves code clarity and consistency following the migration from Redis, making variable management easier across the project. However, I leave the final decision on this convention to the core reviewers.","commit_id":"1781658bde4f7d6ef0b0d985135cb3a27bb7cfa4"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"4c5e0e6ff11295f133a29638f98ac94888da6969","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"449a4c6e_ce3222a3","in_reply_to":"9fa786e8_60b151c9","updated":"2026-02-18 09:49:03.000000000","message":"Acknowledged","commit_id":"1781658bde4f7d6ef0b0d985135cb3a27bb7cfa4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"14072bd90697d2df9153c45561a18f3780b063a2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fa786e8_60b151c9","in_reply_to":"de65866b_5f138d1e","updated":"2026-02-17 20:39:03.000000000","message":"I understand the concern about renaming something we take from some upstream, but: it seems reasonable the variables should be named `*_valkey_*` because that is what we deploy and we want to have it consistent with the `enable_valkey` var. and then naming the service and the container image accordingly also makes sense. I would suggest to go even one step further and also rename the binary in the container to match this","commit_id":"1781658bde4f7d6ef0b0d985135cb3a27bb7cfa4"}],"ansible/roles/prometheus/defaults/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"14072bd90697d2df9153c45561a18f3780b063a2","unresolved":true,"context_lines":[{"line_number":319,"context_line":"  - endpoints: \"{% set rabbitmq_endpoints \u003d [] %}{% for host in groups.get(\u0027rabbitmq\u0027, []) %}{{ rabbitmq_endpoints.append(\u0027rabbitmq_\u0027 + host + (\u0027:tls_connect:\u0027 if rabbitmq_enable_tls | bool else \u0027:tcp_connect:\u0027) + (\u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027)) + \u0027:\u0027 + hostvars[host][\u0027rabbitmq_port\u0027]) }}{% endfor %}{{ rabbitmq_endpoints }}\""},{"line_number":320,"context_line":"    enabled: \"{{ enable_rabbitmq | bool }}\""},{"line_number":321,"context_line":"  - endpoints: \"{% set valkey_endpoints \u003d [] %}{% for host in groups.get(\u0027valkey\u0027, []) %}{{ valkey_endpoints.append(\u0027valkey_\u0027 + host + \u0027:tcp_connect:\u0027 + (\u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027)) + \u0027:\u0027 + hostvars[host][\u0027valkey_server_port\u0027]) }}{% endfor %}{{ valkey_endpoints }}\""},{"line_number":322,"context_line":"    enabled: \"{{ enable_valkey | bool }}\""},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"prometheus_blackbox_exporter_endpoints_custom: []"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f1e5a69f_2dbb81ca","side":"PARENT","line":322,"updated":"2026-02-17 20:39:03.000000000","message":"I think I would leave this in for now in order not to break monitoring that may already be in place. maybe instead add a comment that this can be dropped in 2026.2 or so?","commit_id":"7ef19dd9964075b3bbd12c31b4a2cada97383180"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"4c5e0e6ff11295f133a29638f98ac94888da6969","unresolved":false,"context_lines":[{"line_number":319,"context_line":"  - endpoints: \"{% set rabbitmq_endpoints \u003d [] %}{% for host in groups.get(\u0027rabbitmq\u0027, []) %}{{ rabbitmq_endpoints.append(\u0027rabbitmq_\u0027 + host + (\u0027:tls_connect:\u0027 if rabbitmq_enable_tls | bool else \u0027:tcp_connect:\u0027) + (\u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027)) + \u0027:\u0027 + hostvars[host][\u0027rabbitmq_port\u0027]) }}{% endfor %}{{ rabbitmq_endpoints }}\""},{"line_number":320,"context_line":"    enabled: \"{{ enable_rabbitmq | bool }}\""},{"line_number":321,"context_line":"  - endpoints: \"{% set valkey_endpoints \u003d [] %}{% for host in groups.get(\u0027valkey\u0027, []) %}{{ valkey_endpoints.append(\u0027valkey_\u0027 + host + \u0027:tcp_connect:\u0027 + (\u0027api\u0027 | kolla_address(host) | put_address_in_context(\u0027url\u0027)) + \u0027:\u0027 + hostvars[host][\u0027valkey_server_port\u0027]) }}{% endfor %}{{ valkey_endpoints }}\""},{"line_number":322,"context_line":"    enabled: \"{{ enable_valkey | bool }}\""},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"prometheus_blackbox_exporter_endpoints_custom: []"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a4c0e1e_041cbfa8","side":"PARENT","line":322,"in_reply_to":"f1e5a69f_2dbb81ca","updated":"2026-02-18 09:49:03.000000000","message":"Acknowledged","commit_id":"7ef19dd9964075b3bbd12c31b4a2cada97383180"}],"ansible/roles/prometheus/templates/prometheus-valkey-exporter.json.j2":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"14072bd90697d2df9153c45561a18f3780b063a2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/redis-exporter -redis.addr\u003dredis://{{ api_interface_address }}:{{ valkey_server_port }} -redis.password\u003d{{ valkey_master_password }} -web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_valkey_exporter_port }}\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {% if kolla_copy_ca_into_containers | bool %}"},{"line_number":5,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3292c0ac_52264891","line":2,"range":{"start_line":2,"start_character":59,"end_line":2,"end_character":80},"updated":"2026-02-17 20:39:03.000000000","message":"doesn\u0027t this also need\n```suggestion\n    \"command\": \"/opt/redis-exporter -redis.addr\u003dredis://{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ valkey_server_port }} -redis.password\u003d{{ valkey_master_password }} -web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_valkey_exporter_port }}\",\n```\n?","commit_id":"1781658bde4f7d6ef0b0d985135cb3a27bb7cfa4"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"4c5e0e6ff11295f133a29638f98ac94888da6969","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/opt/redis-exporter -redis.addr\u003dredis://{{ api_interface_address }}:{{ valkey_server_port }} -redis.password\u003d{{ valkey_master_password }} -web.listen-address\u003d{{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ prometheus_valkey_exporter_port }}\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {% if kolla_copy_ca_into_containers | bool %}"},{"line_number":5,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"c0621501_3fdcaf2f","line":2,"range":{"start_line":2,"start_character":59,"end_line":2,"end_character":80},"in_reply_to":"3292c0ac_52264891","updated":"2026-02-18 09:49:03.000000000","message":"Acknowledged","commit_id":"1781658bde4f7d6ef0b0d985135cb3a27bb7cfa4"}]}