)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"0cca35746880e41560baf4f17eb83e495c673091","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cbe0931b_e33837b3","updated":"2026-02-19 18:19:16.000000000","message":"There looks to be an issue with this - the iterated container config directory is not being mounted into the sb relay containers, which means that config.json is not found and the container fails to start.","commit_id":"33a8035f08c5ae4a5eeb2e46060d3bcf7843ff25"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"2f4e744adfb3b76632c5fb1d34f995867780d83a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b465b749_5f66e216","updated":"2026-02-23 14:12:50.000000000","message":"Need to resolve this in another patch:\n```\nThe conflict is caused by:\n    kolla-ansible 21.1.0.dev447 depends on bcrypt\u003c5 and \u003e\u003d4.3.0\n    The user requested (constraint) bcrypt\u003d\u003d\u003d5.0.0\n```","commit_id":"aa9c2da444c046bda76d645a8d5ae5263925eb16"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"8bc81b2783199bcd627e418d2f431a3f914d1e44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0b686981_c70890d2","updated":"2026-02-23 12:40:17.000000000","message":"recheck - failure unrelated, results from 2026-02-20 should be current I think","commit_id":"aa9c2da444c046bda76d645a8d5ae5263925eb16"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"d3024803bfeb90390042bfc8d1dc295fb54f87b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"88141085_1996e00d","updated":"2026-02-23 09:45:52.000000000","message":"recheck - get new logs","commit_id":"aa9c2da444c046bda76d645a8d5ae5263925eb16"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a68e96170c10c02e870f89b48f03cf9c20049798","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b8ed72bd_3b6a0e47","updated":"2026-03-19 14:41:17.000000000","message":"Another manual test:\n\n1. Deploy 1 relay per host\n2. Reconfigure to 3 relays per host\n\nOnly the additional relays are restarted now:\n\n```\nRUNNING HANDLER [ovn-db : Restart ovn-sb-db-relay container] *****************************************************************************************************************************************************************************************************************************\nThursday 19 March 2026  14:31:01 +0000 (0:00:00.007)       0:02:00.321 ********\nchanged: [doug-controller-03] \u003d\u003e (item\u003d{\u0027changed\u0027: True, \u0027result\u0027: True, \u0027invocation\u0027: {\u0027module_args\u0027: {\u0027auth_email\u0027: None, \u0027auth_password\u0027: \u0027rPFCmh2XaR7mKZQYhtVkqFtEE89waA\u0027, \u0027auth_registry\u0027: \u0027ark.stackhpc.com\u0027, \u0027auth_username\u0027: \u0027skc-ci-aio\u0027, \u0027restart_policy\u0027: \u0027unless-stopped\u0027, \u0027restart_retries\u0027: 10, \u0027graceful_timeout\u0027: 60, \u0027client_timeout\u0027: 120, \u0027container_engine\u0027: \u0027docker\u0027, \u0027action\u0027: \u0027compare_container\u0027, \u0027name\u0027: \u0027ovn_sb_db_relay_2\u0027, \u0027image\u0027: \u0027ark.stackhpc.com/stackhpc-dev/ovn-sb-db-relay:2025.1-rocky-9-20260123T132550\u0027, \u0027volumes\u0027: [\u0027/etc/kolla/ovn-sb-db-relay-2/:/var/lib/kolla/config_files/:ro\u0027, \u0027/etc/localtime:/etc/localtime:ro\u0027, \u0027kolla_logs:/var/log/kolla/\u0027], \u0027dimensions\u0027: {\u0027ulimits\u0027: {\u0027nofile\u0027: {\u0027soft\u0027: 1048576, \u0027hard\u0027: 1048576}}}, \u0027detach\u0027: True, \u0027labels\u0027: {}, \u0027cap_add\u0027: [], \u0027security_opt\u0027: [], \u0027privileged\u0027: False, \u0027remove_on_exit\u0027: True, \u0027state\u0027: \u0027running\u0027, \u0027tls_verify\u0027: False, \u0027tty\u0027: False, \u0027ignore_missing\u0027: False, \u0027api_version\u0027: \u0027auto\u0027, \u0027environment\u0027: {\u0027KOLLA_CONFIG_STRATEGY\u0027: \u0027COPY_ALWAYS\u0027, \u0027RELAY_ID\u0027: \u00271\u0027}}}, \u0027failed\u0027: False, \u0027item\u0027: 2, \u0027ansible_loop_var\u0027: \u0027item\u0027})\nchanged: [doug-controller-01] \u003d\u003e (item\u003d{\u0027changed\u0027: True, \u0027result\u0027: True, \u0027invocation\u0027: {\u0027module_args\u0027: {\u0027auth_email\u0027: None, \u0027auth_password\u0027: \u0027rPFCmh2XaR7mKZQYhtVkqFtEE89waA\u0027, \u0027auth_registry\u0027: \u0027ark.stackhpc.com\u0027, \u0027auth_username\u0027: \u0027skc-ci-aio\u0027, \u0027restart_policy\u0027: \u0027unless-stopped\u0027, \u0027restart_retries\u0027: 10, \u0027graceful_timeout\u0027: 60, \u0027client_timeout\u0027: 120, \u0027container_engine\u0027: \u0027docker\u0027, \u0027action\u0027: \u0027compare_container\u0027, \u0027name\u0027: \u0027ovn_sb_db_relay_2\u0027, \u0027image\u0027: \u0027ark.stackhpc.com/stackhpc-dev/ovn-sb-db-relay:2025.1-rocky-9-20260123T132550\u0027, \u0027volumes\u0027: [\u0027/etc/kolla/ovn-sb-db-relay-2/:/var/lib/kolla/config_files/:ro\u0027, \u0027/etc/localtime:/etc/localtime:ro\u0027, \u0027kolla_logs:/var/log/kolla/\u0027], \u0027dimensions\u0027: {\u0027ulimits\u0027: {\u0027nofile\u0027: {\u0027soft\u0027: 1048576, \u0027hard\u0027: 1048576}}}, \u0027detach\u0027: True, \u0027labels\u0027: {}, \u0027cap_add\u0027: [], \u0027security_opt\u0027: [], \u0027privileged\u0027: False, \u0027remove_on_exit\u0027: True, \u0027state\u0027: \u0027running\u0027, \u0027tls_verify\u0027: False, \u0027tty\u0027: False, \u0027ignore_missing\u0027: False, \u0027api_version\u0027: \u0027auto\u0027, \u0027environment\u0027: {\u0027KOLLA_CONFIG_STRATEGY\u0027: \u0027COPY_ALWAYS\u0027, \u0027RELAY_ID\u0027: \u00271\u0027}}}, \u0027failed\u0027: False, \u0027item\u0027: 2, \u0027ansible_loop_var\u0027: \u0027item\u0027})\nchanged: [doug-controller-02] \u003d\u003e (item\u003d{\u0027changed\u0027: True, \u0027result\u0027: True, \u0027invocation\u0027: {\u0027module_args\u0027: {\u0027auth_email\u0027: None, \u0027auth_password\u0027: \u0027rPFCmh2XaR7mKZQYhtVkqFtEE89waA\u0027, \u0027auth_registry\u0027: \u0027ark.stackhpc.com\u0027, \u0027auth_username\u0027: \u0027skc-ci-aio\u0027, \u0027restart_policy\u0027: \u0027unless-stopped\u0027, \u0027restart_retries\u0027: 10, \u0027graceful_timeout\u0027: 60, \u0027client_timeout\u0027: 120, \u0027container_engine\u0027: \u0027docker\u0027, \u0027action\u0027: \u0027compare_container\u0027, \u0027name\u0027: \u0027ovn_sb_db_relay_2\u0027, \u0027image\u0027: \u0027ark.stackhpc.com/stackhpc-dev/ovn-sb-db-relay:2025.1-rocky-9-20260123T132550\u0027, \u0027volumes\u0027: [\u0027/etc/kolla/ovn-sb-db-relay-2/:/var/lib/kolla/config_files/:ro\u0027, \u0027/etc/localtime:/etc/localtime:ro\u0027, \u0027kolla_logs:/var/log/kolla/\u0027], \u0027dimensions\u0027: {\u0027ulimits\u0027: {\u0027nofile\u0027: {\u0027soft\u0027: 1048576, \u0027hard\u0027: 1048576}}}, \u0027detach\u0027: True, \u0027labels\u0027: {}, \u0027cap_add\u0027: [], \u0027security_opt\u0027: [], \u0027privileged\u0027: False, \u0027remove_on_exit\u0027: True, \u0027state\u0027: \u0027running\u0027, \u0027tls_verify\u0027: False, \u0027tty\u0027: False, \u0027ignore_missing\u0027: False, \u0027api_version\u0027: \u0027auto\u0027, \u0027environment\u0027: {\u0027KOLLA_CONFIG_STRATEGY\u0027: \u0027COPY_ALWAYS\u0027, \u0027RELAY_ID\u0027: \u00271\u0027}}}, \u0027failed\u0027: False, \u0027item\u0027: 2, \u0027ansible_loop_var\u0027: \u0027item\u0027})\nchanged: [doug-controller-03] \u003d\u003e (item\u003d{\u0027changed\u0027: True, \u0027result\u0027: True, \u0027invocation\u0027: {\u0027module_args\u0027: {\u0027auth_email\u0027: None, \u0027auth_password\u0027: \u0027rPFCmh2XaR7mKZQYhtVkqFtEE89waA\u0027, \u0027auth_registry\u0027: \u0027ark.stackhpc.com\u0027, \u0027auth_username\u0027: \u0027skc-ci-aio\u0027, \u0027restart_policy\u0027: \u0027unless-stopped\u0027, \u0027restart_retries\u0027: 10, \u0027graceful_timeout\u0027: 60, \u0027client_timeout\u0027: 120, \u0027container_engine\u0027: \u0027docker\u0027, \u0027action\u0027: \u0027compare_container\u0027, \u0027name\u0027: \u0027ovn_sb_db_relay_3\u0027, \u0027image\u0027: \u0027ark.stackhpc.com/stackhpc-dev/ovn-sb-db-relay:2025.1-rocky-9-20260123T132550\u0027, \u0027volumes\u0027: [\u0027/etc/kolla/ovn-sb-db-relay-3/:/var/lib/kolla/config_files/:ro\u0027, \u0027/etc/localtime:/etc/localtime:ro\u0027, \u0027kolla_logs:/var/log/kolla/\u0027], \u0027dimensions\u0027: {\u0027ulimits\u0027: {\u0027nofile\u0027: {\u0027soft\u0027: 1048576, \u0027hard\u0027: 1048576}}}, \u0027detach\u0027: True, \u0027labels\u0027: {}, \u0027cap_add\u0027: [], \u0027security_opt\u0027: [], \u0027privileged\u0027: False, \u0027remove_on_exit\u0027: True, \u0027state\u0027: \u0027running\u0027, \u0027tls_verify\u0027: False, \u0027tty\u0027: False, \u0027ignore_missing\u0027: False, \u0027api_version\u0027: \u0027auto\u0027, \u0027environment\u0027: {\u0027KOLLA_CONFIG_STRATEGY\u0027: \u0027COPY_ALWAYS\u0027, \u0027RELAY_ID\u0027: \u00271\u0027}}}, \u0027failed\u0027: False, \u0027item\u0027: 3, \u0027ansible_loop_var\u0027: \u0027item\u0027})\nchanged: [doug-controller-01] \u003d\u003e (item\u003d{\u0027changed\u0027: True, \u0027result\u0027: True, \u0027invocation\u0027: {\u0027module_args\u0027: {\u0027auth_email\u0027: None, \u0027auth_password\u0027: \u0027rPFCmh2XaR7mKZQYhtVkqFtEE89waA\u0027, \u0027auth_registry\u0027: \u0027ark.stackhpc.com\u0027, \u0027auth_username\u0027: \u0027skc-ci-aio\u0027, \u0027restart_policy\u0027: \u0027unless-stopped\u0027, \u0027restart_retries\u0027: 10, \u0027graceful_timeout\u0027: 60, \u0027client_timeout\u0027: 120, \u0027container_engine\u0027: \u0027docker\u0027, \u0027action\u0027: \u0027compare_container\u0027, \u0027name\u0027: \u0027ovn_sb_db_relay_3\u0027, \u0027image\u0027: \u0027ark.stackhpc.com/stackhpc-dev/ovn-sb-db-relay:2025.1-rocky-9-20260123T132550\u0027, \u0027volumes\u0027: [\u0027/etc/kolla/ovn-sb-db-relay-3/:/var/lib/kolla/config_files/:ro\u0027, \u0027/etc/localtime:/etc/localtime:ro\u0027, \u0027kolla_logs:/var/log/kolla/\u0027], \u0027dimensions\u0027: {\u0027ulimits\u0027: {\u0027nofile\u0027: {\u0027soft\u0027: 1048576, \u0027hard\u0027: 1048576}}}, \u0027detach\u0027: True, \u0027labels\u0027: {}, \u0027cap_add\u0027: [], \u0027security_opt\u0027: [], \u0027privileged\u0027: False, \u0027remove_on_exit\u0027: True, \u0027state\u0027: \u0027running\u0027, \u0027tls_verify\u0027: False, \u0027tty\u0027: False, \u0027ignore_missing\u0027: False, \u0027api_version\u0027: \u0027auto\u0027, \u0027environment\u0027: {\u0027KOLLA_CONFIG_STRATEGY\u0027: \u0027COPY_ALWAYS\u0027, \u0027RELAY_ID\u0027: \u00271\u0027}}}, \u0027failed\u0027: False, \u0027item\u0027: 3, \u0027ansible_loop_var\u0027: \u0027item\u0027})\nchanged: [doug-controller-02] \u003d\u003e (item\u003d{\u0027changed\u0027: True, \u0027result\u0027: True, \u0027invocation\u0027: {\u0027module_args\u0027: {\u0027auth_email\u0027: None, \u0027auth_password\u0027: \u0027rPFCmh2XaR7mKZQYhtVkqFtEE89waA\u0027, \u0027auth_registry\u0027: \u0027ark.stackhpc.com\u0027, \u0027auth_username\u0027: \u0027skc-ci-aio\u0027, \u0027restart_policy\u0027: \u0027unless-stopped\u0027, \u0027restart_retries\u0027: 10, \u0027graceful_timeout\u0027: 60, \u0027client_timeout\u0027: 120, \u0027container_engine\u0027: \u0027docker\u0027, \u0027action\u0027: \u0027compare_container\u0027, \u0027name\u0027: \u0027ovn_sb_db_relay_3\u0027, \u0027image\u0027: \u0027ark.stackhpc.com/stackhpc-dev/ovn-sb-db-relay:2025.1-rocky-9-20260123T132550\u0027, \u0027volumes\u0027: [\u0027/etc/kolla/ovn-sb-db-relay-3/:/var/lib/kolla/config_files/:ro\u0027, \u0027/etc/localtime:/etc/localtime:ro\u0027, \u0027kolla_logs:/var/log/kolla/\u0027], \u0027dimensions\u0027: {\u0027ulimits\u0027: {\u0027nofile\u0027: {\u0027soft\u0027: 1048576, \u0027hard\u0027: 1048576}}}, \u0027detach\u0027: True, \u0027labels\u0027: {}, \u0027cap_add\u0027: [], \u0027security_opt\u0027: [], \u0027privileged\u0027: False, \u0027remove_on_exit\u0027: True, \u0027state\u0027: \u0027running\u0027, \u0027tls_verify\u0027: False, \u0027tty\u0027: False, \u0027ignore_missing\u0027: False, \u0027api_version\u0027: \u0027auto\u0027, \u0027environment\u0027: {\u0027KOLLA_CONFIG_STRATEGY\u0027: \u0027COPY_ALWAYS\u0027, \u0027RELAY_ID\u0027: \u00271\u0027}}}, \u0027failed\u0027: False, \u0027item\u0027: 3, \u0027ansible_loop_var\u0027: \u0027item\u0027})\n```","commit_id":"6923e335c06be0e5bb8570ddea64e6116da8007a"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a679956e6eb1516d3b02a3036848a3f99602a62e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7307c86d_2e780c6c","updated":"2026-03-19 14:20:54.000000000","message":"I\u0027ve manually verified that if I stop a single relay container, it only restarts that container. The previous behaviour was to restart all of them.\n\n```\nTASK [service-check-containers : Notify handlers to restart containers for ovn_db] *******************************************************************************************************************************************************************************************************\nThursday 19 March 2026  14:15:50 +0000 (0:00:00.207)       0:01:23.321 ********\nchanged: [doug-controller-01] \u003d\u003e \n    msg: \u0027Notifying handlers: Restart ovn-sb-db-relay container\u0027\nok: [doug-controller-02] \u003d\u003e \n    msg: Nothing changed - not notifying handlers\nok: [doug-controller-03] \u003d\u003e \n    msg: Nothing changed - not notifying handlers\n\n```","commit_id":"6923e335c06be0e5bb8570ddea64e6116da8007a"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"fb2107f1f846ee92c5edd208d6f9b4d379cdf94e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ff453f60_b4c83a06","updated":"2026-03-23 09:35:58.000000000","message":"recheck","commit_id":"61bef7cf9da59e72aa2ca1394169d08c2b58ed77"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"8d2c362a65165454cd274d2d9816f4c4b0d3deba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5c5553ba_290df898","updated":"2026-03-20 10:29:30.000000000","message":"thanks both","commit_id":"61bef7cf9da59e72aa2ca1394169d08c2b58ed77"}],"ansible/roles/service-check-containers/tasks/iterated.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"078af59eb1c2e0a6490bcc5cc080ce97a6dbf877","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: \"Store changed containers to pass to the handler\""},{"line_number":29,"context_line":"  set_fact:"},{"line_number":30,"context_line":"    changed_containers: \"{{ container_check.results | selectattr(\u0027changed\u0027) | default([]) }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# NOTE(yoctozepto): Must be a separate task because one cannot see the whole"},{"line_number":33,"context_line":"# result in the previous task and Ansible has a quirk regarding notifiers."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4d054ff2_c711a465","line":30,"updated":"2026-02-12 17:03:30.000000000","message":"I\u0027ll namespace this to avoid the possibility of it getting overwritten if multiple services in a role become iterable","commit_id":"629201541abeb0ce4c411e267e915e3591e26275"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"37f4515baf188de3dff2b1379dda5ce08cfab462","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: \"Store changed containers to pass to the handler\""},{"line_number":29,"context_line":"  set_fact:"},{"line_number":30,"context_line":"    changed_containers: \"{{ container_check.results | selectattr(\u0027changed\u0027) | default([]) }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# NOTE(yoctozepto): Must be a separate task because one cannot see the whole"},{"line_number":33,"context_line":"# result in the previous task and Ansible has a quirk regarding notifiers."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e2e8cc8a_5e5d33d6","line":30,"in_reply_to":"4d054ff2_c711a465","updated":"2026-02-12 17:39:37.000000000","message":"Done","commit_id":"629201541abeb0ce4c411e267e915e3591e26275"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"90cff40cb01db3ad1b3e57a0c09036697843af28","unresolved":true,"context_lines":[{"line_number":26,"context_line":"  register: container_check"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: \"Store changed containers to pass to the handler\""},{"line_number":29,"context_line":"  set_fact:"},{"line_number":30,"context_line":"    \"{{ service_name | replace(\u0027-\u0027, \u0027_\u0027) }}_changed_containers\": \"{{ container_check.results | selectattr(\u0027changed\u0027) | default([]) }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# NOTE(yoctozepto): Must be a separate task because one cannot see the whole"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"cfda8b7b_d293031e","line":29,"updated":"2026-03-16 13:36:09.000000000","message":"I\u0027ve looked through logs and it looks like it is regressing the idempotency as it is running restart handler and then the list is empty:\n\nchanged: [primary] \u003d\u003e { \"msg\": \"Notifying handlers: Restart ovn-sb-db-relay container\" }\n...\nRUNNING HANDLER [ovn-db : Restart ovn-sb-db-relay container]\n...\nskipping: [primary] \u003d\u003e { \"changed\": false, \"skipped_reason\": \"No items in the list\" }\n\nnot sure why, but maybe changed_containers is a variable name string and not the stored fact value\n\nkolla-ansible-rocky-10-ovn and kolla-ansible-ubuntu-noble-ovn:\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_1eb/openstack/1ebbe611183a46998f8431d73124c462/primary/logs/ansible/reconfigure\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_c52/openstack/c52d64d75969419e8a87006ba054aa6c/primary/logs/ansible/reconfigure","commit_id":"da4c32a5863f2df9a5131e5e385353f9be85142b"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a679956e6eb1516d3b02a3036848a3f99602a62e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  register: container_check"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: \"Store changed containers to pass to the handler\""},{"line_number":29,"context_line":"  set_fact:"},{"line_number":30,"context_line":"    \"{{ service_name | replace(\u0027-\u0027, \u0027_\u0027) }}_changed_containers\": \"{{ container_check.results | selectattr(\u0027changed\u0027) | default([]) }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# NOTE(yoctozepto): Must be a separate task because one cannot see the whole"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"be1e0d7c_dfb2114a","line":29,"in_reply_to":"325ba2d6_f0f4ee86","updated":"2026-03-19 14:20:54.000000000","message":"Done","commit_id":"da4c32a5863f2df9a5131e5e385353f9be85142b"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"d7d38c465a2e87229cb44b988982dd5add71492f","unresolved":true,"context_lines":[{"line_number":26,"context_line":"  register: container_check"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: \"Store changed containers to pass to the handler\""},{"line_number":29,"context_line":"  set_fact:"},{"line_number":30,"context_line":"    \"{{ service_name | replace(\u0027-\u0027, \u0027_\u0027) }}_changed_containers\": \"{{ container_check.results | selectattr(\u0027changed\u0027) | default([]) }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# NOTE(yoctozepto): Must be a separate task because one cannot see the whole"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"325ba2d6_f0f4ee86","line":29,"in_reply_to":"cfda8b7b_d293031e","updated":"2026-03-19 14:06:54.000000000","message":"Hmm, thanks, good spot. I think I\u0027ve fixed that - your analysis was correct.","commit_id":"da4c32a5863f2df9a5131e5e385353f9be85142b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"87d813052f541113a3ec5af72753f03f57f328bc","unresolved":true,"context_lines":[{"line_number":26,"context_line":"  register: container_check"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: \"Store changed containers to pass to the handler\""},{"line_number":29,"context_line":"  set_fact:"},{"line_number":30,"context_line":"    \"{{ service_name | replace(\u0027-\u0027, \u0027_\u0027) }}_changed_containers\": \"{{ container_check.results | selectattr(\u0027changed\u0027) | default([]) }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# NOTE(yoctozepto): Must be a separate task because one cannot see the whole"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"f067b966_213f74c8","line":29,"updated":"2026-03-20 08:13:28.000000000","message":"ansible.builtin.set_fact - because we\u0027re merging a chain to use FQCNs for ansible builtins","commit_id":"18de73f7f3c58105e48a72ef4d88517a29043116"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"807556f1caf84d98eda3532e90c09ec55197ae02","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  register: container_check"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"- name: \"Store changed containers to pass to the handler\""},{"line_number":29,"context_line":"  set_fact:"},{"line_number":30,"context_line":"    \"{{ service_name | replace(\u0027-\u0027, \u0027_\u0027) }}_changed_containers\": \"{{ container_check.results | selectattr(\u0027changed\u0027) | default([]) }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# NOTE(yoctozepto): Must be a separate task because one cannot see the whole"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"f8ebce1d_3e4373d0","line":29,"in_reply_to":"f067b966_213f74c8","updated":"2026-03-20 10:15:40.000000000","message":"ah yes, I saw those","commit_id":"18de73f7f3c58105e48a72ef4d88517a29043116"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"87d813052f541113a3ec5af72753f03f57f328bc","unresolved":true,"context_lines":[{"line_number":36,"context_line":"  vars:"},{"line_number":37,"context_line":"    handler: \"{{ [\u0027Restart \u0027 + outer_item.key + \u0027 container\u0027] if changed_containers | length \u003e 0 else [] }}\""},{"line_number":38,"context_line":"    changed_containers: \"{{ lookup(\u0027vars\u0027, service_name | replace(\u0027-\u0027, \u0027_\u0027) + \u0027_changed_containers\u0027) }}\""},{"line_number":39,"context_line":"  debug:"},{"line_number":40,"context_line":"    msg: \"{{ (\u0027Notifying handlers: \u0027 + handler | join(\u0027,\u0027)) if changed_containers | length \u003e 0 else \u0027Nothing changed - not notifying handlers\u0027 }}\""},{"line_number":41,"context_line":"  changed_when: changed_containers | length \u003e 0"},{"line_number":42,"context_line":"  notify: \"{{ handler }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"c842c29e_9587f1b0","line":39,"updated":"2026-03-20 08:13:28.000000000","message":"ditto","commit_id":"18de73f7f3c58105e48a72ef4d88517a29043116"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"807556f1caf84d98eda3532e90c09ec55197ae02","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  vars:"},{"line_number":37,"context_line":"    handler: \"{{ [\u0027Restart \u0027 + outer_item.key + \u0027 container\u0027] if changed_containers | length \u003e 0 else [] }}\""},{"line_number":38,"context_line":"    changed_containers: \"{{ lookup(\u0027vars\u0027, service_name | replace(\u0027-\u0027, \u0027_\u0027) + \u0027_changed_containers\u0027) }}\""},{"line_number":39,"context_line":"  debug:"},{"line_number":40,"context_line":"    msg: \"{{ (\u0027Notifying handlers: \u0027 + handler | join(\u0027,\u0027)) if changed_containers | length \u003e 0 else \u0027Nothing changed - not notifying handlers\u0027 }}\""},{"line_number":41,"context_line":"  changed_when: changed_containers | length \u003e 0"},{"line_number":42,"context_line":"  notify: \"{{ handler }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1d94a992_88a07e9e","line":39,"in_reply_to":"c842c29e_9587f1b0","updated":"2026-03-20 10:15:40.000000000","message":"Done","commit_id":"18de73f7f3c58105e48a72ef4d88517a29043116"}]}
