)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7a9828afa2be4a8bb0954720c8d8f6af68730fd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e76c53e5_6c6c9386","updated":"2026-04-19 09:50:51.000000000","message":"recheck not related","commit_id":"3fdce355a858bf35c2cd69cee65c5c33eb44f30c"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7877976dae5de83ef936e49a3e843262a05f71fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"70f2f2d4_29ae63a6","updated":"2026-04-20 14:52:52.000000000","message":"Looks useful potentially, mostly just some questions","commit_id":"02af4aa02b50da17c6093e033690e02861914c8a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"36e85d645fdfc316269e1cc998deb324079940c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c2e10e71_a78cc3b8","updated":"2026-04-21 00:06:41.000000000","message":"recheck new images","commit_id":"ba6c9edca8890b332f7581cb36d8d28fc6435e18"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3718e2d2f921d82a429472ea7785bc6dcbda7777","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"822125d5_278a08dc","updated":"2026-05-15 10:46:34.000000000","message":"recheck","commit_id":"68ac9343adea78dcf509995e1bb579f84dbd84d0"}],"ansible/roles/fluentd/tasks/config.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7877976dae5de83ef936e49a3e843262a05f71fb","unresolved":true,"context_lines":[{"line_number":73,"context_line":"    log_direct_to_opensearch: \u003e-"},{"line_number":74,"context_line":"      {{ enable_opensearch | bool or"},{"line_number":75,"context_line":"           ( opensearch_address !\u003d kolla_internal_fqdn ) }}"},{"line_number":76,"context_line":"    log_direct_to_rsyslog: \"{{ rsyslog_address is defined and rsyslog_address | length \u003e 0 }}\""},{"line_number":77,"context_line":"    # Inputs"},{"line_number":78,"context_line":"    fluentd_input_files: \"{{ default_input_files_enabled | customise_fluentd(customised_input_files) }}\""},{"line_number":79,"context_line":"    default_input_files_enabled: \"{{ default_input_files | selectattr(\u0027enabled\u0027) | map(attribute\u003d\u0027name\u0027) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3e1886f9_cba2f9d5","line":76,"updated":"2026-04-20 14:52:52.000000000","message":"nit: `rsyslog_address` is always defined since it\u0027s in the role defaults\n```suggestion\n    log_direct_to_rsyslog: \"{{ rsyslog_address | length \u003e 0 }}\"\n```","commit_id":"02af4aa02b50da17c6093e033690e02861914c8a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"65f0002d59fbae3b0b60ff285b7829b0f83f075e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    log_direct_to_opensearch: \u003e-"},{"line_number":74,"context_line":"      {{ enable_opensearch | bool or"},{"line_number":75,"context_line":"           ( opensearch_address !\u003d kolla_internal_fqdn ) }}"},{"line_number":76,"context_line":"    log_direct_to_rsyslog: \"{{ rsyslog_address is defined and rsyslog_address | length \u003e 0 }}\""},{"line_number":77,"context_line":"    # Inputs"},{"line_number":78,"context_line":"    fluentd_input_files: \"{{ default_input_files_enabled | customise_fluentd(customised_input_files) }}\""},{"line_number":79,"context_line":"    default_input_files_enabled: \"{{ default_input_files | selectattr(\u0027enabled\u0027) | map(attribute\u003d\u0027name\u0027) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1afec6d8_5ff647bf","line":76,"in_reply_to":"3e1886f9_cba2f9d5","updated":"2026-05-14 19:52:45.000000000","message":"Done","commit_id":"02af4aa02b50da17c6093e033690e02861914c8a"}],"ansible/roles/fluentd/templates/conf/filter/01-rewrite.conf.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7877976dae5de83ef936e49a3e843262a05f71fb","unresolved":true,"context_lines":[{"line_number":2,"context_line":"\u003cmatch infra.mariadb\u003e"},{"line_number":3,"context_line":"  @type rewrite_tag_filter"},{"line_number":4,"context_line":"  \u003crule\u003e"},{"line_number":5,"context_line":"    key message"},{"line_number":6,"context_line":"    pattern /^\\d{6}/"},{"line_number":7,"context_line":"    tag infra.mariadb.mysqld_safe"},{"line_number":8,"context_line":"  \u003c/rule\u003e"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"011a303b_d117d42a","line":5,"updated":"2026-04-20 14:52:52.000000000","message":"What\u0027s the reasoning for changing this?\n\nThe issue I see is that it will break peoples downstream dashboards. It shouldn\u0027t be required for this feature?","commit_id":"02af4aa02b50da17c6093e033690e02861914c8a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8022d830de4f26c565379ae0559dbe37c0908de4","unresolved":true,"context_lines":[{"line_number":2,"context_line":"\u003cmatch infra.mariadb\u003e"},{"line_number":3,"context_line":"  @type rewrite_tag_filter"},{"line_number":4,"context_line":"  \u003crule\u003e"},{"line_number":5,"context_line":"    key message"},{"line_number":6,"context_line":"    pattern /^\\d{6}/"},{"line_number":7,"context_line":"    tag infra.mariadb.mysqld_safe"},{"line_number":8,"context_line":"  \u003c/rule\u003e"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"8adb8d6d_a521d5dd","line":5,"in_reply_to":"011a303b_d117d42a","updated":"2026-04-20 22:01:31.000000000","message":"Yes, I’m aware of that - I know about it. In the end, I’ll wrap the payload message and remove the message before sending it to Elasticsearch, while keeping it when sending to rsyslog. I’m aware of these small details. For now, I want to get the whole stack into a working state with a +1 vote in Zuul. It should already be OK in terms of voting now. After that, I’ll take a look at these small details.\n\nFor now, of course leaving this comment open.","commit_id":"02af4aa02b50da17c6093e033690e02861914c8a"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"65f0002d59fbae3b0b60ff285b7829b0f83f075e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"\u003cmatch infra.mariadb\u003e"},{"line_number":3,"context_line":"  @type rewrite_tag_filter"},{"line_number":4,"context_line":"  \u003crule\u003e"},{"line_number":5,"context_line":"    key message"},{"line_number":6,"context_line":"    pattern /^\\d{6}/"},{"line_number":7,"context_line":"    tag infra.mariadb.mysqld_safe"},{"line_number":8,"context_line":"  \u003c/rule\u003e"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"a90cee3f_eb65ca35","line":5,"in_reply_to":"8adb8d6d_a521d5dd","updated":"2026-05-14 19:52:45.000000000","message":"@doug@stackhpc.com Now fixed, users are not affected. Please, reopen if you not agree with solution.","commit_id":"02af4aa02b50da17c6093e033690e02861914c8a"}],"ansible/roles/fluentd/templates/conf/output/01-es.conf.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"7877976dae5de83ef936e49a3e843262a05f71fb","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{% for match_pattern in [\u0027retry_es\u0027, \u0027**\u0027,] %}"},{"line_number":2,"context_line":"\u003cmatch {{ match_pattern }}\u003e"},{"line_number":3,"context_line":"    @type copy"},{"line_number":4,"context_line":"    \u003cstore\u003e"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"bc0f93e8_eda5fecb","side":"PARENT","line":1,"updated":"2026-04-20 14:52:52.000000000","message":"The retry mechanism is important and it looks like we\u0027ve lost it?\n\nThe reason is that the pipeline is not idempotent for all logs. Eg if a log submission is retried, you need to stop it being re-processed. There is a bug somewhere about this.","commit_id":"8af293dd55096fd19bb5869d3429cf9d3e6d9c80"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8022d830de4f26c565379ae0559dbe37c0908de4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% for match_pattern in [\u0027retry_es\u0027, \u0027**\u0027,] %}"},{"line_number":2,"context_line":"\u003cmatch {{ match_pattern }}\u003e"},{"line_number":3,"context_line":"    @type copy"},{"line_number":4,"context_line":"    \u003cstore\u003e"}],"source_content_type":"text/x-jinja2","patch_set":7,"id":"02ce9464_80ab2b3c","side":"PARENT","line":1,"in_reply_to":"bc0f93e8_eda5fecb","updated":"2026-04-20 22:01:31.000000000","message":"Yeah, you are right, i\u0027ve forgot to add one line - @label ELASTICSEARCH_OUTPUT and @label OPENSEARCH_OUTPUT ... new revision fixed. \n\nMarking as resolved, please reopen if you don\u0027t agree.\n\nhttps://richm.github.io/fluent-plugin-elasticsearch-retry.html","commit_id":"8af293dd55096fd19bb5869d3429cf9d3e6d9c80"}]}