)]}' {"/PATCHSET_LEVEL":[{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"4539fc3eeb147cefda4fe26ce6d3ee8d192a206f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d563edce_b9bdf36c","updated":"2026-05-05 08:15:59.000000000","message":"Iā€™m wondering if relying strictly on the registry/namespace string is the most robust approach.\n\nA lot of users mirror repositories locally (internal-registry.local/openstack.kolla/). In those cases, someone might still unknowingly pull test images into their environment, and this precheck wouldn\u0027t catch it because the docker_registry wouldn\u0027t be quay.io.\n\nWhat do you think about using an OCI label instead? https://review.opendev.org/c/openstack/kolla/+/971681.\n\nIf we had a specific label baked into the test images (like org.openstack.kolla.test\u003dtrue), the precheck could inspect the image metadata regardless of the registry name. It might be a more \u0027future-proof\u0027 way to identify these images than hardcoding strings.","commit_id":"2ffe7f6fd7f6ed4800177c24b36169d04c6a2e07"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"bd881eaeb3cc8b1ed800bf39d7bba62573358366","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"917a4e73_fd2a0253","in_reply_to":"d563edce_b9bdf36c","updated":"2026-05-05 08:23:15.000000000","message":"You would need to download an image to check its labels, and we don\u0027t do that in prechecks normally. I think we want a simple precheck, not an overkill.","commit_id":"2ffe7f6fd7f6ed4800177c24b36169d04c6a2e07"}],"ansible/roles/prechecks/tasks/registry_checks.yml":[{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"99f7778def663eeab12bf753cf0a372f010e8d6d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check if using quay.io/openstack.kolla images"},{"line_number":3,"context_line":" ansible.builtin.assert:"},{"line_number":4,"context_line":" that: docker_registry !\u003d \"quay.io\" and docker_namespace !\u003d \"openstack.kolla\""},{"line_number":5,"context_line":" fail_msg: \u003e-"},{"line_number":6,"context_line":" Kolla images from quay.io/openstack.kolla namespace are meant only for testing purposes,"},{"line_number":7,"context_line":" if you want to continue using them please use --use-test-images CLI argument"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f2b68f8_b93da1f1","line":4,"updated":"2026-05-05 07:35:10.000000000","message":"```suggestion\n that: docker_registry !\u003d \"quay.io\" or docker_namespace !\u003d \"openstack.kolla\"\n```","commit_id":"50781cfeb524315dce6f5595e867b27a17fd0fff"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"8b479512479206608be8b672e8fd6b147fc4198e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check if using quay.io/openstack.kolla images"},{"line_number":3,"context_line":" ansible.builtin.assert:"},{"line_number":4,"context_line":" that: docker_registry !\u003d \"quay.io\" and docker_namespace !\u003d \"openstack.kolla\""},{"line_number":5,"context_line":" fail_msg: \u003e-"},{"line_number":6,"context_line":" Kolla images from quay.io/openstack.kolla namespace are meant only for testing purposes,"},{"line_number":7,"context_line":" if you want to continue using them please use --use-test-images CLI argument"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7716956b_6faff386","line":4,"in_reply_to":"1f2b68f8_b93da1f1","updated":"2026-05-05 07:36:08.000000000","message":"if one has openstack.kolla in private registry it would fail that assert","commit_id":"50781cfeb524315dce6f5595e867b27a17fd0fff"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4dffee8256b1fbb4e770574a3b9c9515fa51c21c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check if using quay.io/openstack.kolla images"},{"line_number":3,"context_line":" ansible.builtin.assert:"},{"line_number":4,"context_line":" that: docker_registry !\u003d \"quay.io\" and docker_namespace !\u003d \"openstack.kolla\""},{"line_number":5,"context_line":" fail_msg: \u003e-"},{"line_number":6,"context_line":" Kolla images from quay.io/openstack.kolla namespace are meant only for testing purposes,"},{"line_number":7,"context_line":" if you want to continue using them please use --use-test-images CLI argument"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"c1720108_d3637924","line":4,"in_reply_to":"58a36303_74d82e3c","updated":"2026-05-05 07:45:50.000000000","message":"Done","commit_id":"50781cfeb524315dce6f5595e867b27a17fd0fff"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"671327e1bc654fad694696d7bff9856077a19aae","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check if using quay.io/openstack.kolla images"},{"line_number":3,"context_line":" ansible.builtin.assert:"},{"line_number":4,"context_line":" that: docker_registry !\u003d \"quay.io\" and docker_namespace !\u003d \"openstack.kolla\""},{"line_number":5,"context_line":" fail_msg: \u003e-"},{"line_number":6,"context_line":" Kolla images from quay.io/openstack.kolla namespace are meant only for testing purposes,"},{"line_number":7,"context_line":" if you want to continue using them please use --use-test-images CLI argument"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"d8d2cc8a_dac5b189","line":4,"in_reply_to":"58a36303_74d82e3c","updated":"2026-05-05 07:49:29.000000000","message":"well, it will assert the docker_namespace, as docker_registry !\u003d \"quay.io\" will be true for private registry","commit_id":"50781cfeb524315dce6f5595e867b27a17fd0fff"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"93cae961f57a1142188157047df5eb48e935ed2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check if using quay.io/openstack.kolla images"},{"line_number":3,"context_line":" ansible.builtin.assert:"},{"line_number":4,"context_line":" that: docker_registry !\u003d \"quay.io\" and docker_namespace !\u003d \"openstack.kolla\""},{"line_number":5,"context_line":" fail_msg: \u003e-"},{"line_number":6,"context_line":" Kolla images from quay.io/openstack.kolla namespace are meant only for testing purposes,"},{"line_number":7,"context_line":" if you want to continue using them please use --use-test-images CLI argument"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"92e11611_4aefc804","line":4,"in_reply_to":"70214575_bf484a0a","updated":"2026-05-05 08:19:01.000000000","message":"another way to do it might be to assert a negation on the whole thing being equal to default values ? I think this would be edge-case proof ? \n\n\n\n```suggestion\n that: not (docker_registry \u003d\u003d \"quay.io\" and docker_namespace \u003d\u003d \"openstack.kolla\")\n```","commit_id":"50781cfeb524315dce6f5595e867b27a17fd0fff"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"79152b29d2ec2a6053ae2523a6e5149c73e9d072","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check if using quay.io/openstack.kolla images"},{"line_number":3,"context_line":" ansible.builtin.assert:"},{"line_number":4,"context_line":" that: docker_registry !\u003d \"quay.io\" and docker_namespace !\u003d \"openstack.kolla\""},{"line_number":5,"context_line":" fail_msg: \u003e-"},{"line_number":6,"context_line":" Kolla images from quay.io/openstack.kolla namespace are meant only for testing purposes,"},{"line_number":7,"context_line":" if you want to continue using them please use --use-test-images CLI argument"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"58a36303_74d82e3c","line":4,"in_reply_to":"7716956b_6faff386","updated":"2026-05-05 07:42:28.000000000","message":"`and` operator should exit early and not assert `docker_namespace !\u003d \"openstack.kolla\"` if the registry is private, and I don\u0027t think someone can have an openstack.kolla private registry on quay as it\u0027s supposedly unique ?","commit_id":"50781cfeb524315dce6f5595e867b27a17fd0fff"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"9744212b7ae699249231cedf3b0464404787447a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check if using quay.io/openstack.kolla images"},{"line_number":3,"context_line":" ansible.builtin.assert:"},{"line_number":4,"context_line":" that: docker_registry !\u003d \"quay.io\" and docker_namespace !\u003d \"openstack.kolla\""},{"line_number":5,"context_line":" fail_msg: \u003e-"},{"line_number":6,"context_line":" Kolla images from quay.io/openstack.kolla namespace are meant only for testing purposes,"},{"line_number":7,"context_line":" if you want to continue using them please use --use-test-images CLI argument"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"dcb078a2_59757944","line":4,"in_reply_to":"92e11611_4aefc804","updated":"2026-05-05 08:21:20.000000000","message":"yes, this is equivalent, and Michal already did just that šŸ˜‰","commit_id":"50781cfeb524315dce6f5595e867b27a17fd0fff"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"33d90acd51141d3dd85f57f540587bc7615933ee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check if using quay.io/openstack.kolla images"},{"line_number":3,"context_line":" ansible.builtin.assert:"},{"line_number":4,"context_line":" that: docker_registry !\u003d \"quay.io\" and docker_namespace !\u003d \"openstack.kolla\""},{"line_number":5,"context_line":" fail_msg: \u003e-"},{"line_number":6,"context_line":" Kolla images from quay.io/openstack.kolla namespace are meant only for testing purposes,"},{"line_number":7,"context_line":" if you want to continue using them please use --use-test-images CLI argument"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"70214575_bf484a0a","line":4,"in_reply_to":"d8d2cc8a_dac5b189","updated":"2026-05-05 07:49:36.000000000","message":"Done","commit_id":"50781cfeb524315dce6f5595e867b27a17fd0fff"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"7e408a6de06e1866cfd16d378c4d31634a115323","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Check if using quay.io/openstack.kolla images"},{"line_number":3,"context_line":" ansible.builtin.assert:"},{"line_number":4,"context_line":" that: docker_registry !\u003d \"quay.io\" and docker_namespace !\u003d \"openstack.kolla\""},{"line_number":5,"context_line":" fail_msg: \u003e-"},{"line_number":6,"context_line":" Kolla images from quay.io/openstack.kolla namespace are meant only for testing purposes,"},{"line_number":7,"context_line":" if you want to continue using them please use --use-test-images CLI argument"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f82ea276_8102e43a","line":4,"in_reply_to":"dcb078a2_59757944","updated":"2026-05-05 08:27:08.000000000","message":"oh I missed the new patchset silly me","commit_id":"50781cfeb524315dce6f5595e867b27a17fd0fff"},{"author":{"_account_id":37306,"name":"Piotr Milewski","display_name":"Piotr Milewski","email":"vurmil@gmail.com","username":"vurmil"},"change_message_id":"782b0c3dd495e563a03f9590aa5503565a31b544","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"cb49e764_4230f611","line":9,"updated":"2026-05-05 08:41:52.000000000","message":"meaybe extend? 2 step\n\n- name: Warning if a potential mirror of test images is detected\n ansible.builtin.debug:\n msg: \u003e-\n WARNING: You are using the \u0027openstack.kolla\u0027 namespace on a custom registry ({{ docker_registry }}).\n If this is a mirror of quay.io/openstack.kolla, these images are meant for testing only.\n when:\n - not kolla_test_images | bool\n - docker_registry !\u003d \"quay.io\"\n - docker_namespace \u003d\u003d \"openstack.kolla\"","commit_id":"2ffe7f6fd7f6ed4800177c24b36169d04c6a2e07"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"df7f62ada66d5ce1c78d07a6c4e346e61ca0267b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6fe87d32_cfbc19a6","line":9,"in_reply_to":"0f0e40fa_035520d5","updated":"2026-05-06 10:59:05.000000000","message":"I\u0027m not planning to add this, but feel free to follow up.","commit_id":"2ffe7f6fd7f6ed4800177c24b36169d04c6a2e07"},{"author":{"_account_id":37313,"name":"MAILLET-CONTOZ Nicolas","display_name":"Nicolas MAILLET-CONTOZ","email":"nicolas.maillet-contoz@infomaniak.com","username":"nicolasmc","status":"Intern SRE at Infomaniak"},"change_message_id":"aeb06b15e6bdaf9d0c0d8bd0a176ca51b0f797a2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0f0e40fa_035520d5","line":9,"in_reply_to":"cb49e764_4230f611","updated":"2026-05-06 09:02:21.000000000","message":"Could be revelant. But may be a bit invasive. Not needed imo. We could add this later if necessary ?","commit_id":"2ffe7f6fd7f6ed4800177c24b36169d04c6a2e07"}]}