)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a1f14aac78d5caf6345db3297dd8f4c3471c95b2","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Merge note:"},{"line_number":19,"context_line":"This patch needs to be merged first."},{"line_number":20,"context_line":"Immediately after that, merge the kolla\u0027s Depends-On patch."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ia9312f247d20e4233c669599804a51bacf15a75c"},{"line_number":23,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla/+/989849"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"1bbe3588_2b3c18f0","line":20,"updated":"2026-05-28 05:55:19.000000000","message":"It\u0027s not how Depends-On in Zuul works","commit_id":"3061ad88c84ac27a7abaa4cb42dba947c56fb7da"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"3485b992c79eb643822c16e1eb0dcd65f7450793","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Merge note:"},{"line_number":19,"context_line":"This patch needs to be merged first."},{"line_number":20,"context_line":"Immediately after that, merge the kolla\u0027s Depends-On patch."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ia9312f247d20e4233c669599804a51bacf15a75c"},{"line_number":23,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla/+/989849"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"b8d0f081_865741ce","line":20,"in_reply_to":"1bbe3588_2b3c18f0","updated":"2026-05-28 07:40:29.000000000","message":"This is one of those cross-repo dependency cases where the passing change\nneeds to be merged first.\nAnd actually, this is exactly how Depends-On works in Zuul, as described in the documentation:\n\nhttps://zuul-ci.org/docs/zuul/latest/gating.html?#cross-project-dependencies\nhttps://zuul-ci.org/docs/zuul/11.0.0/developer/specs/circular-dependencies.html\n\nSo what exactly did you mean by saying Zuul does not work like this?\n\nWas the -1 about the wording of the merge note, or do you disagree with what ?","commit_id":"3061ad88c84ac27a7abaa4cb42dba947c56fb7da"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e9f7aa4613e7b41bca89931fe031b0590ac68a1a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Merge note:"},{"line_number":19,"context_line":"This patch needs to be merged first."},{"line_number":20,"context_line":"Immediately after that, merge the kolla\u0027s Depends-On patch."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ia9312f247d20e4233c669599804a51bacf15a75c"},{"line_number":23,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla/+/989849"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"bfe3b93f_c039f03b","line":20,"in_reply_to":"b8d0f081_865741ce","updated":"2026-05-29 16:57:06.000000000","message":"Done","commit_id":"3061ad88c84ac27a7abaa4cb42dba947c56fb7da"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"c5b04f6a5e370718a904cebd91f4b86ea0f2a11d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"SGID permissions for shared logging with fluentd."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia9312f247d20e4233c669599804a51bacf15a75c"},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla/+/989849"},{"line_number":20,"context_line":"Signed-off-by: Michal Arbet \u003cmichal.arbet@ultimum.io\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"100c01c4_43fd9ca1","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":65},"updated":"2026-07-11 11:01:52.000000000","message":"We can\u0027t depend on the kolla patch being merged first.\n\nWhy?\n\nBecause if the first Kolla patch is merged as a dependency, we\u0027ll end up in a state where the images no longer touch files, create directories, or perform similar tasks, since that functionality is removed by the patch right ? .... At the same time, this Kolla-Ansible patch won\u0027t have merged yet, so nothing will perform those operations during that window.\n\nThat\u0027s why there were actual dependencies on:\n\nhttps://review.opendev.org/c/openstack/kolla/+/988849\nhttps://review.opendev.org/c/openstack/kolla/+/989936\n\nIn reality, it\u0027s perfectly fine if, immediately after this kolla-ansible patch merges, both sides perform the same work (1. the image side, and 2. kolla-ansible\u0027s config.json after the merge). Shortly afterwards, the Kolla patch will merge and remove the image-side implementation [1.].\n\nFor that reason, this patch must not have a Depends-On for https://review.opendev.org/c/openstack/kolla/+/989849.","commit_id":"f59726c0051948090c70a71e797abbf959d13a01"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"f422bc2042be48075f14bf3043eee725983deb95","unresolved":false,"context_lines":[{"line_number":16,"context_line":"SGID permissions for shared logging with fluentd."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia9312f247d20e4233c669599804a51bacf15a75c"},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla/+/989849"},{"line_number":20,"context_line":"Signed-off-by: Michal Arbet \u003cmichal.arbet@ultimum.io\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"69f41de3_3735658f","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":65},"in_reply_to":"100c01c4_43fd9ca1","updated":"2026-07-13 08:44:13.000000000","message":"There are some inconsistencies between the two approaches. For example in `letsencrypt`, the directory ownership has changed. If we merge this first without merging the Kolla patch, the container is going to start, change the ownership, and then change it back every time is starts. \n\nI think we should have both patches approved and ready to merge, and then merge the Kolla one first, which then forces us to merge this one straight away to avoid the window where there are two mechanisms managing the log files.","commit_id":"f59726c0051948090c70a71e797abbf959d13a01"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6d33d217c8379459cf77cf3b658525267e0b00ef","unresolved":false,"context_lines":[{"line_number":16,"context_line":"SGID permissions for shared logging with fluentd."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia9312f247d20e4233c669599804a51bacf15a75c"},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla/+/989849"},{"line_number":20,"context_line":"Signed-off-by: Michal Arbet \u003cmichal.arbet@ultimum.io\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"45c9f2fc_161639db","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":65},"in_reply_to":"343aa793_2da2254e","updated":"2026-07-15 08:38:55.000000000","message":"kolla patch ready","commit_id":"f59726c0051948090c70a71e797abbf959d13a01"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9b3dc761913c2abbeccb3a65fcbdbcf911118564","unresolved":false,"context_lines":[{"line_number":16,"context_line":"SGID permissions for shared logging with fluentd."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia9312f247d20e4233c669599804a51bacf15a75c"},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla/+/989849"},{"line_number":20,"context_line":"Signed-off-by: Michal Arbet \u003cmichal.arbet@ultimum.io\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"972fc525_b4d243f6","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":65},"in_reply_to":"69f41de3_3735658f","updated":"2026-07-13 09:42:17.000000000","message":"I didn\u0027t want to mix logging perms with others, but letsencrypt is resolved in https://review.opendev.org/c/openstack/kolla-ansible/+/988728 ...","commit_id":"f59726c0051948090c70a71e797abbf959d13a01"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0c50f79218f584462bc3ff14897e0ed12b70a87e","unresolved":true,"context_lines":[{"line_number":16,"context_line":"SGID permissions for shared logging with fluentd."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia9312f247d20e4233c669599804a51bacf15a75c"},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla/+/989849"},{"line_number":20,"context_line":"Signed-off-by: Michal Arbet \u003cmichal.arbet@ultimum.io\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"fad28c3f_dd03c293","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":65},"in_reply_to":"972fc525_b4d243f6","updated":"2026-07-13 12:04:10.000000000","message":"@doug@stackhpc.com You are simply saying that you are OK that between kolla patch merge and kolla-ansible patch ( this ) , the situation will be as zuul results here https://review.opendev.org/c/openstack/kolla-ansible/+/996994 - everything failing.\n\nI am saying that  if we firstly merge this patch, the situation will be:\n\n1. mkdir /var/log/whatever, chown whatever:whatever /var/log/whatever, chmod 0XXX /var/log/whatever ( based on image scripts )\n2. SAME stuff or compatible settings regarding ownership and perms... ( based on set_configs which actually means based on this kolla-ansible patch)\n\nand I am totally OK with it. \n\nAfter kolla merge 1. will be dropped and whole change will be completed.\n\nOn the end ...from the autho point of view, I really don\u0027t care what will be merged, from the core reviewer I think my approach is the right one. \n\nWDYT ?","commit_id":"f59726c0051948090c70a71e797abbf959d13a01"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"8091142266203a0731aafe55080e52ffed620b4e","unresolved":true,"context_lines":[{"line_number":16,"context_line":"SGID permissions for shared logging with fluentd."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ia9312f247d20e4233c669599804a51bacf15a75c"},{"line_number":19,"context_line":"Depends-On: https://review.opendev.org/c/openstack/kolla/+/989849"},{"line_number":20,"context_line":"Signed-off-by: Michal Arbet \u003cmichal.arbet@ultimum.io\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"343aa793_2da2254e","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":65},"in_reply_to":"fad28c3f_dd03c293","updated":"2026-07-13 14:29:40.000000000","message":"I think we should get the Kolla patch ready, so they are both approved, and then I don\u0027t have a strong opinion on the order in which they are merged, so long as they merged around the same time.\n\nI agree you will need to remove the depends-on from this if you do it the way you suggest above. It was worth adding to get CI results on this patch using the Kolla change.","commit_id":"f59726c0051948090c70a71e797abbf959d13a01"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"bf67b921425533c0b0018822dfcf390673ab76e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2a31cd0b_86e114c5","updated":"2026-05-25 19:30:54.000000000","message":"recheck new set of images","commit_id":"bd907bb733015675df632e9baf9211181c1c93c0"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4db0c1b0bb85c57ecd97d41584d72bb693777f9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"be133365_1365b9eb","updated":"2026-05-26 09:06:48.000000000","message":"recheck unrelated","commit_id":"35b1ebfc2bb15f6c1b42170d721e1aa254387296"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"449942d620141da255d035def2b9acf534be812b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"9682dcc0_d9859223","updated":"2026-05-28 07:46:58.000000000","message":"Hmm, maybe I see on the kolla side there are probably patches which needs to be squashed together and depends-on against that squashed only one commit...\n\nIs it that ?","commit_id":"3061ad88c84ac27a7abaa4cb42dba947c56fb7da"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2ddec1ea3a442f44402d8d9b6a14c4cfa1ddb726","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"a76b76ca_2655f37c","updated":"2026-05-28 09:29:50.000000000","message":"Maybe a short summary to clarify the situation. This kolla-ansible patch relies on two key changes in kolla itself:\n\n1. - perm: \"2775\" / perm: \"2557\" support (SGID bit handling)\n   - Fixed in kolla: https://review.opendev.org/c/openstack/kolla/+/988849\n   - Since it\u0027s only a fix in kolla, this can be merged independently right now\n   \n\n2. - files: [] feature\n   - Adds the ability to create/touch specific files and set ownership/permissions via config.json.\n   - Proposed in kolla: https://review.opendev.org/c/openstack/kolla/+/989936\n   - Since it\u0027s only a feature in kolla,  this can be merged independently right now alo\n\n\nSo, my question is - should I add both of these as Depends-On for this kolla-ansible patch?\n\n\n\n\nNow to the problematic part:\n\n3. - Removal of /var/log/kolla creation logic from container images\nhttps://review.opendev.org/c/openstack/kolla/+/989849\n\nThat change will naturally fail in CI until the related kolla-ansible patch is merged, because it removes the existing image-side directory and files creation logic while tests are still using the old kolla-ansible behavior (without the new config.json-based directory handling).\n\nAccording to Zuul documentation, cross-repository circular Depends-On relationships between are not supported, Because of that, I added a note in the commit message explaining that the kolla-ansible patch must be merged first before patch [3] can be properly verified by Zuul.\n\nIs it clearer now what workflow/proposal I was trying to describe?\n\n\nMaybe there is a question what will happen if i remove current depends-on ? \nWell, zuul will test \n\n- This revision of kolla-ansible\n- with kolla-images creation logic\n\nSo, on the end kolla-ansible config.json will work, but in second step kolla-extend-start in all of those files will rewrite sometimes owner, sometimes permissions ...etc which will cause fail of other patches stacked in this relation chain...\n\nSo, as I said, the best is:\n\n1. Merge https://review.opendev.org/c/openstack/kolla/+/988849\n2. Merge https://review.opendev.org/c/openstack/kolla/+/989936 \n3. Merge this kolla-ansible patch which handling directories and files https://review.opendev.org/c/openstack/kolla-ansible/+/989850\n4. Recheck and merge kolla patch (which will start to pass as kolla-ansible now handle all of those files/dirs) https://review.opendev.org/c/openstack/kolla/+/989849","commit_id":"3061ad88c84ac27a7abaa4cb42dba947c56fb7da"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ad337a46db7fd092da4335d67cbae301448f50b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"a5edd9a0_7cd937ef","in_reply_to":"9682dcc0_d9859223","updated":"2026-05-28 07:57:14.000000000","message":"Or what ?","commit_id":"3061ad88c84ac27a7abaa4cb42dba947c56fb7da"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"32c39046d792265babd2665a91971d3312e5a3ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"002b555e_d25b6c54","updated":"2026-06-03 06:39:27.000000000","message":"recheck not related","commit_id":"165015cb6158866603bd63c8f43cdf7b33e24246"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"693194b483b339638250c635953f66502d00369c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"0ef72474_a0bb399c","updated":"2026-05-31 09:19:07.000000000","message":"recheck not related","commit_id":"165015cb6158866603bd63c8f43cdf7b33e24246"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0c40e7ffdc3dce3a1e15456bf0ce1f87655eb69f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"08c78947_58c14ba1","updated":"2026-05-31 19:27:42.000000000","message":"recheck not-related","commit_id":"165015cb6158866603bd63c8f43cdf7b33e24246"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"039587b4c18cfcbefa55256356b881caa582c812","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"8ca908c6_37fe5323","updated":"2026-06-04 09:36:50.000000000","message":"recheck not-related","commit_id":"165015cb6158866603bd63c8f43cdf7b33e24246"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0434cffcdbd78c8925505c8f44dddecafe23543e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"5a5820fd_d382b9f0","updated":"2026-06-01 04:21:08.000000000","message":"recheck unrelated","commit_id":"165015cb6158866603bd63c8f43cdf7b33e24246"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"59436a2b277710e1b2465bc465390eeec38797a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"9102173b_c2af2ea2","updated":"2026-05-30 10:05:12.000000000","message":"recheck unrelated","commit_id":"165015cb6158866603bd63c8f43cdf7b33e24246"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"9ce8aee303663a1d9d20e2f0ef633966af521c80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"f3eb2224_5c4fae01","updated":"2026-06-02 08:26:42.000000000","message":"recheck unrelated mariadb fail","commit_id":"165015cb6158866603bd63c8f43cdf7b33e24246"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1049be7a518a310ed381b2fc7a51f9325b6202c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"01320b45_37e2cedc","updated":"2026-06-08 11:25:14.000000000","message":"recheck","commit_id":"e64ecf944c1af69f9589697132cbf3396c7706f2"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ea4a38dda6ed66cb7ed70c54e443bf71630d5297","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"3b4332af_ba99b067","updated":"2026-06-08 21:26:51.000000000","message":"recheck image download failed","commit_id":"e64ecf944c1af69f9589697132cbf3396c7706f2"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"91bf779a805582e204dbdbe9ebc46a0d611b73ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"b0b54f1e_6bb7847b","updated":"2026-06-11 04:36:35.000000000","message":"recheck rocky new images with openstacksdk","commit_id":"8f13609db1ce34703f719c8af47727904811632f"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"01cde9e3bd6448f16be85b609f1fed84326531a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"c0cd440c_52c36ba3","updated":"2026-07-02 13:16:25.000000000","message":"Looks good in general","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"f3111823978cc6676a1c8a53341289211394d3a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"84c3e41d_a4993638","updated":"2026-07-08 14:16:18.000000000","message":"Thanks for updating.\n\nPlease can we make it depend on a patch in Kolla to remove all the log creation logic from the startup scripts?\n\nEg. delete stuff like:\nhttps://github.com/openstack/kolla/blob/master/docker/cinder/cinder-base/extend_start.sh#L4","commit_id":"ebe4005d0950f855dd16e199d513f2f18c812f13"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5c5eb91cb7bdfec10c542dff27f600a0b8c3d219","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"5c1832d3_2f7760c8","in_reply_to":"042afdb4_f5d0c5ae","updated":"2026-07-08 14:48:00.000000000","message":"Check patch 16 and comment from @mnasiadka@gmail.com","commit_id":"ebe4005d0950f855dd16e199d513f2f18c812f13"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"db6396b29a4cb392d79557e04747186cabfc0a84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"042afdb4_f5d0c5ae","in_reply_to":"84c3e41d_a4993638","updated":"2026-07-08 14:46:56.000000000","message":"@doug@stackhpc.com It can\u0027t be dependent against kolla patch ...Why ? because firstly there need to be kolla-ansible (this) patch landed so kolla patch start to pass ( tested locally ). It\u0027s classic egg or chicken problem, kolla vs kolla-ansible. So after this will be merged .. then https://review.opendev.org/c/openstack/kolla/+/989849 can be merged. \n\nOn the end we will have images clean and driven by config.json from kolla-ansible as it should be.","commit_id":"ebe4005d0950f855dd16e199d513f2f18c812f13"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"1ebcd08e74701b2c03aae5565bbc844806b0fd83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"9e2c485b_76252c57","updated":"2026-07-08 16:45:05.000000000","message":"recheck","commit_id":"c261a90643e71b1565a269c83834e1f3e8c0a112"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"a7921a64e1c6b3859f7fd7a65add26e875e3603d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"489440ea_9800ee9a","updated":"2026-07-09 14:56:27.000000000","message":"I *think* it looks good","commit_id":"f59726c0051948090c70a71e797abbf959d13a01"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"57809a47589fb94e3583ec8ece58d98ef1e66a2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"dfaa997f_bb41178f","updated":"2026-07-09 14:30:47.000000000","message":"rebased to fix linter","commit_id":"f59726c0051948090c70a71e797abbf959d13a01"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7205ce248ca0eb37736c894e5239bd30a62c4317","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"1c86ce9e_7752b583","in_reply_to":"489440ea_9800ee9a","updated":"2026-07-09 14:59:05.000000000","message":"Thank you :), i tested from up to down, after this it will be cleaner and no more need to hack/write bashes in containers.","commit_id":"f59726c0051948090c70a71e797abbf959d13a01"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"99b5c2c1408b3a4d3af5c4d6a30f80f1c546f347","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"e60db7a2_ccd07b94","updated":"2026-07-24 10:42:20.000000000","message":"@doug@stackhpc.com cam u please readd +2 ? and merge ? Thanks","commit_id":"b5e7ebe33d7b872c2887aaa1f16ed1a859383fff"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"19205d49bbe8de8921371ea0a6618271d39d266f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"8572ff46_7fb1b2c9","updated":"2026-07-24 16:40:05.000000000","message":"Thank you !","commit_id":"b5e7ebe33d7b872c2887aaa1f16ed1a859383fff"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"ac4154c1ff192cf03781c7181bdf0394d1e97f8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"3843a90d_ca517244","updated":"2026-07-20 20:31:07.000000000","message":"this LGTM.","commit_id":"b5e7ebe33d7b872c2887aaa1f16ed1a859383fff"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"eb954c2934a0a9144b033797e3a45ed50cdb4e98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"4b231b0d_18d33548","in_reply_to":"e60db7a2_ccd07b94","updated":"2026-07-24 13:43:46.000000000","message":"indeed, let\u0027s try and get the kolla one merged next week","commit_id":"b5e7ebe33d7b872c2887aaa1f16ed1a859383fff"}],"ansible/roles/aodh/templates/aodh-api.json.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"01cde9e3bd6448f16be85b609f1fed84326531a0","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    ],"},{"line_number":29,"context_line":"    \"directories\": ["},{"line_number":30,"context_line":"        {"},{"line_number":31,"context_line":"            \"path\": \"/var/log/kolla\","},{"line_number":32,"context_line":"            \"owner\": \"fluentd:kolla\","},{"line_number":33,"context_line":"            \"perm\": \"2775\""},{"line_number":34,"context_line":"        },"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"8e004481_b0d057af","line":31,"updated":"2026-07-02 13:16:25.000000000","message":"Can\u0027t we just rely on `fluentd.json.j2` to set the owner / permissions rather than putting this in every service? Maybe I\u0027ve missed something?","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b627efdfa063ecde290ebb5c9c11a65729f1c1d7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    ],"},{"line_number":29,"context_line":"    \"directories\": ["},{"line_number":30,"context_line":"        {"},{"line_number":31,"context_line":"            \"path\": \"/var/log/kolla\","},{"line_number":32,"context_line":"            \"owner\": \"fluentd:kolla\","},{"line_number":33,"context_line":"            \"perm\": \"2775\""},{"line_number":34,"context_line":"        },"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"b4ccf9b4_f35696a7","line":31,"in_reply_to":"8e004481_b0d057af","updated":"2026-07-06 23:01:35.000000000","message":"@doug@stackhpc.com, this patch is also specifically intended to ensure that each service creates its own logging directory structure via set_configs.py before it starts, based on what is defined in config.json.\n\nThat\u0027s why it explicitly defines that both /var/log/kolla and /var/log/kolla/{{ service }} must exist. One of the reasons is that users can set enable_fluentd: false, so a service cannot rely on some other component to create its log directory. The idea is that config.json serves as the single source of truth for each individual service, and each service is responsible for creating the directory structure it requires.\n\nMaybe we can discuss reusing owner: fluentd:kolla and moving it to group_vars/all.yml so it\u0027s defined consistently across the project. However, by its very nature, this probably shouldn\u0027t be configurable at all, because changing it on an existing cloud could easily break file permissions.\n\nMarking this as resolved for now. Please feel free to reopen this comment if my explanation didn\u0027t address your concern.","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"f3111823978cc6676a1c8a53341289211394d3a8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    ],"},{"line_number":29,"context_line":"    \"directories\": ["},{"line_number":30,"context_line":"        {"},{"line_number":31,"context_line":"            \"path\": \"/var/log/kolla\","},{"line_number":32,"context_line":"            \"owner\": \"fluentd:kolla\","},{"line_number":33,"context_line":"            \"perm\": \"2775\""},{"line_number":34,"context_line":"        },"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"ebc8f619_75066240","line":31,"in_reply_to":"b4ccf9b4_f35696a7","updated":"2026-07-08 14:16:18.000000000","message":"Thanks, fair point about the not using Fluentd case.","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"}],"ansible/roles/blazar/templates/blazar-manager.json.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"01cde9e3bd6448f16be85b609f1fed84326531a0","unresolved":true,"context_lines":[{"line_number":21,"context_line":"        }{% endif %}"},{"line_number":22,"context_line":"    ],"},{"line_number":23,"context_line":"    \"directories\": ["},{"line_number":24,"context_line":"        {"},{"line_number":25,"context_line":"            \"path\": \"/var/log/kolla\","},{"line_number":26,"context_line":"            \"owner\": \"fluentd:kolla\","},{"line_number":27,"context_line":"            \"perm\": \"2775\""}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"57f70fb4_a891b46a","line":24,"updated":"2026-07-02 13:16:25.000000000","message":"Maybe I\u0027ve missed something, but why can\u0027t we rely on the Fluentd to perform this?","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b627efdfa063ecde290ebb5c9c11a65729f1c1d7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        }{% endif %}"},{"line_number":22,"context_line":"    ],"},{"line_number":23,"context_line":"    \"directories\": ["},{"line_number":24,"context_line":"        {"},{"line_number":25,"context_line":"            \"path\": \"/var/log/kolla\","},{"line_number":26,"context_line":"            \"owner\": \"fluentd:kolla\","},{"line_number":27,"context_line":"            \"perm\": \"2775\""}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"ae10c329_459807be","line":24,"in_reply_to":"57f70fb4_a891b46a","updated":"2026-07-06 23:01:35.000000000","message":"This is the same answer I gave in more detail in another comment. In short, we can\u0027t force users to use fluentd ....they are free to disable it. The fact that it\u0027s enabled by default doesn\u0027t change that..\n\nMarking this as resolved for now. Please feel free to reopen this comment if my explanation didn\u0027t address your concern.","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"}],"ansible/roles/iscsi/templates/iscsid.json.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"01cde9e3bd6448f16be85b609f1fed84326531a0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"iscsid -d 8 -f\","},{"line_number":3,"context_line":"    \"config_files\": [],"},{"line_number":4,"context_line":"    \"directories\": ["},{"line_number":5,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"766729e1_61b632ea","line":2,"updated":"2026-07-02 13:16:25.000000000","message":"If I understand correctly, this is logging to stdout, and will end up in the Docker logs, therefore we don\u0027t need the new config below?","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"338f2a126db404a13965cc401a1b17644e62a88e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"iscsid -d 8 -f\","},{"line_number":3,"context_line":"    \"config_files\": [],"},{"line_number":4,"context_line":"    \"directories\": ["},{"line_number":5,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"88dcd9e4_460a174a","line":2,"in_reply_to":"20146075_64e16c25","updated":"2026-07-07 11:03:07.000000000","message":"Removed","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b627efdfa063ecde290ebb5c9c11a65729f1c1d7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"iscsid -d 8 -f\","},{"line_number":3,"context_line":"    \"config_files\": [],"},{"line_number":4,"context_line":"    \"directories\": ["},{"line_number":5,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"20146075_64e16c25","line":2,"in_reply_to":"766729e1_61b632ea","updated":"2026-07-06 23:01:35.000000000","message":"Yeah, you are probably right ( I didn\u0027t have a stack to test this actually), and was added by bash script following idea \ndirs:\n- /var/log/kolla\n- /var/log/service \npermissions:\n- moreover fix everything until this patch in /var/log/service/*.log\n\nBut still, I think everything should be in file/syslog/gathered by fluentd, no in docker logs.\n\nLeave opened.","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"}],"ansible/roles/iscsi/templates/tgtd.json.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"01cde9e3bd6448f16be85b609f1fed84326531a0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"tgtd -d 1 -f --iscsi portal\u003d{{ tgtd_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ iscsi_port }}\","},{"line_number":3,"context_line":"    \"config_files\": [],"},{"line_number":4,"context_line":"    \"directories\": ["},{"line_number":5,"context_line":"        {"},{"line_number":6,"context_line":"            \"path\": \"/var/log/kolla\","},{"line_number":7,"context_line":"            \"owner\": \"fluentd:kolla\","}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"e9638c86_c65d8d6f","line":4,"updated":"2026-07-02 13:16:25.000000000","message":"same for iscsid - I suppose ideally we would configure these services to log to file in the future, so I\u0027m ok with leaving it in. Might be worth adding a TODO?","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"338f2a126db404a13965cc401a1b17644e62a88e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"tgtd -d 1 -f --iscsi portal\u003d{{ tgtd_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ iscsi_port }}\","},{"line_number":3,"context_line":"    \"config_files\": [],"},{"line_number":4,"context_line":"    \"directories\": ["},{"line_number":5,"context_line":"        {"},{"line_number":6,"context_line":"            \"path\": \"/var/log/kolla\","},{"line_number":7,"context_line":"            \"owner\": \"fluentd:kolla\","}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"2301e2da_8fe12cc4","line":4,"in_reply_to":"d28d58a0_a892700f","updated":"2026-07-07 11:03:07.000000000","message":"Removed.","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b627efdfa063ecde290ebb5c9c11a65729f1c1d7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"tgtd -d 1 -f --iscsi portal\u003d{{ tgtd_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ iscsi_port }}\","},{"line_number":3,"context_line":"    \"config_files\": [],"},{"line_number":4,"context_line":"    \"directories\": ["},{"line_number":5,"context_line":"        {"},{"line_number":6,"context_line":"            \"path\": \"/var/log/kolla\","},{"line_number":7,"context_line":"            \"owner\": \"fluentd:kolla\","}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"d28d58a0_a892700f","line":4,"in_reply_to":"e9638c86_c65d8d6f","updated":"2026-07-06 23:01:35.000000000","message":"Same as for iscsi, yeah let\u0027s say it\u0027s preparation for the future. 🙂","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"}],"ansible/roles/keystone/templates/keystone-httpd.json.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"01cde9e3bd6448f16be85b609f1fed84326531a0","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        {"},{"line_number":55,"context_line":"            \"path\": \"/var/log/kolla/keystone\","},{"line_number":56,"context_line":"            \"owner\": \"keystone:kolla\""},{"line_number":57,"context_line":"        }{% if keystone_enable_federation_openid | bool %},"},{"line_number":58,"context_line":"        {"},{"line_number":59,"context_line":"            \"path\": \"{{ keystone_container_federation_oidc_metadata_folder }}\","},{"line_number":60,"context_line":"            \"owner\": \"{{ apache_user }}:{{ apache_user }}\","}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"1c89f237_8f00b742","side":"PARENT","line":57,"updated":"2026-07-02 13:16:25.000000000","message":"why remove this for the oidc folders? does the path always exist or will the chown fail if it\u0027s not there?","commit_id":"fc2e8055c7678cd483e1b4fca587dd3243218ff5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b627efdfa063ecde290ebb5c9c11a65729f1c1d7","unresolved":true,"context_lines":[{"line_number":54,"context_line":"        {"},{"line_number":55,"context_line":"            \"path\": \"/var/log/kolla/keystone\","},{"line_number":56,"context_line":"            \"owner\": \"keystone:kolla\""},{"line_number":57,"context_line":"        }{% if keystone_enable_federation_openid | bool %},"},{"line_number":58,"context_line":"        {"},{"line_number":59,"context_line":"            \"path\": \"{{ keystone_container_federation_oidc_metadata_folder }}\","},{"line_number":60,"context_line":"            \"owner\": \"{{ apache_user }}:{{ apache_user }}\","}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"630c1c46_142b8b62","side":"PARENT","line":57,"in_reply_to":"1c89f237_8f00b742","updated":"2026-07-06 23:01:35.000000000","message":"Will check, leave open.","commit_id":"fc2e8055c7678cd483e1b4fca587dd3243218ff5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"338f2a126db404a13965cc401a1b17644e62a88e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        {"},{"line_number":55,"context_line":"            \"path\": \"/var/log/kolla/keystone\","},{"line_number":56,"context_line":"            \"owner\": \"keystone:kolla\""},{"line_number":57,"context_line":"        }{% if keystone_enable_federation_openid | bool %},"},{"line_number":58,"context_line":"        {"},{"line_number":59,"context_line":"            \"path\": \"{{ keystone_container_federation_oidc_metadata_folder }}\","},{"line_number":60,"context_line":"            \"owner\": \"{{ apache_user }}:{{ apache_user }}\","}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"5d1fe0ff_a0f7a31c","side":"PARENT","line":57,"in_reply_to":"630c1c46_142b8b62","updated":"2026-07-07 11:03:07.000000000","message":"Fixed","commit_id":"fc2e8055c7678cd483e1b4fca587dd3243218ff5"}],"ansible/roles/letsencrypt/templates/letsencrypt-webserver.json.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"01cde9e3bd6448f16be85b609f1fed84326531a0","unresolved":true,"context_lines":[{"line_number":25,"context_line":"        },"},{"line_number":26,"context_line":"        {"},{"line_number":27,"context_line":"            \"path\": \"/var/log/kolla/letsencrypt\","},{"line_number":28,"context_line":"            \"owner\": \"letsencrypt:kolla\","},{"line_number":29,"context_line":"            \"perm\": \"2775\""},{"line_number":30,"context_line":"        }"},{"line_number":31,"context_line":"    ],"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"8126f5fd_5dbc2746","line":28,"updated":"2026-07-02 13:16:25.000000000","message":"Does this not need to remain as the``apache_user`` so that apache can write logs here?","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b627efdfa063ecde290ebb5c9c11a65729f1c1d7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        },"},{"line_number":26,"context_line":"        {"},{"line_number":27,"context_line":"            \"path\": \"/var/log/kolla/letsencrypt\","},{"line_number":28,"context_line":"            \"owner\": \"letsencrypt:kolla\","},{"line_number":29,"context_line":"            \"perm\": \"2775\""},{"line_number":30,"context_line":"        }"},{"line_number":31,"context_line":"    ],"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"13a3f525_7e130b74","line":28,"in_reply_to":"8126f5fd_5dbc2746","updated":"2026-07-06 23:01:35.000000000","message":"Nope, https://69a80b519508dfea5e2b-c162fa8e75cb459a7d10e69223bc94c7.ssl.cf5.rackcdn.com/openstack/915e85470b4d405b8c48b58529ed0d36/primary/logs/kolla/letsencrypt/index.html","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"}],"ansible/roles/loadbalancer/templates/haproxy-ssh/haproxy-ssh.json.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"01cde9e3bd6448f16be85b609f1fed84326531a0","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    ],"},{"line_number":23,"context_line":"    \"directories\": ["},{"line_number":24,"context_line":"        {"},{"line_number":25,"context_line":"            \"path\": \"/var/log/kolla\","},{"line_number":26,"context_line":"            \"owner\": \"fluentd:kolla\","},{"line_number":27,"context_line":"            \"perm\": \"2775\""},{"line_number":28,"context_line":"        },"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"ebf3cfb6_4684620b","line":25,"updated":"2026-07-02 13:16:25.000000000","message":"again, not required unless sshd is configured to log here","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b627efdfa063ecde290ebb5c9c11a65729f1c1d7","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    ],"},{"line_number":23,"context_line":"    \"directories\": ["},{"line_number":24,"context_line":"        {"},{"line_number":25,"context_line":"            \"path\": \"/var/log/kolla\","},{"line_number":26,"context_line":"            \"owner\": \"fluentd:kolla\","},{"line_number":27,"context_line":"            \"perm\": \"2775\""},{"line_number":28,"context_line":"        },"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"f1f49867_64e2023e","line":25,"in_reply_to":"ebf3cfb6_4684620b","updated":"2026-07-06 23:01:35.000000000","message":"True, will remove, leaving open.","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"338f2a126db404a13965cc401a1b17644e62a88e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    ],"},{"line_number":23,"context_line":"    \"directories\": ["},{"line_number":24,"context_line":"        {"},{"line_number":25,"context_line":"            \"path\": \"/var/log/kolla\","},{"line_number":26,"context_line":"            \"owner\": \"fluentd:kolla\","},{"line_number":27,"context_line":"            \"perm\": \"2775\""},{"line_number":28,"context_line":"        },"}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"192cf238_e753bbbd","line":25,"in_reply_to":"f1f49867_64e2023e","updated":"2026-07-07 11:03:07.000000000","message":"Renmoved","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"}],"ansible/roles/loadbalancer/templates/keepalived/keepalived.json.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"01cde9e3bd6448f16be85b609f1fed84326531a0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/usr/sbin/keepalived -nld -p /run/keepalived.pid\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/keepalived.conf\","}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"a6041f47_d41b88c7","line":2,"updated":"2026-07-02 13:16:25.000000000","message":"-l is log to console - no need for below again","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b627efdfa063ecde290ebb5c9c11a65729f1c1d7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/usr/sbin/keepalived -nld -p /run/keepalived.pid\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/keepalived.conf\","}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"ae236968_c6a32494","line":2,"in_reply_to":"a6041f47_d41b88c7","updated":"2026-07-06 23:01:35.000000000","message":"Again, preparation to the future.","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"338f2a126db404a13965cc401a1b17644e62a88e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/usr/sbin/keepalived -nld -p /run/keepalived.pid\","},{"line_number":3,"context_line":"    \"config_files\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/keepalived.conf\","}],"source_content_type":"text/x-jinja2","patch_set":30,"id":"6c0ab170_2b64ed95","line":2,"in_reply_to":"ae236968_c6a32494","updated":"2026-07-07 11:03:07.000000000","message":"Okay, removed.","commit_id":"e760a865d8668d29fb28a4b90fbdc9efe9dac54b"}]}
