)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c7dcb72ac3d8a3ca76bba8e5804cd407aeacb1d6","unresolved":true,"context_lines":[{"line_number":15,"context_line":"and replace the VIP based readiness check with direct Galera"},{"line_number":16,"context_line":"status validation."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Galera status validation:"},{"line_number":19,"context_line":" - wsrep_cluster_status"},{"line_number":20,"context_line":" - wsrep_local_state_comment"},{"line_number":21,"context_line":" - wsrep_ready"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"cf28c844_3e22f4d4","line":18,"updated":"2026-06-15 13:36:45.000000000","message":"I don\u0027t understand why is it in the commit message without any context.","commit_id":"a3480865d2dbfd70b321b6ff329320de3d677fb1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2aba44bb102a60d72275bcd5c8ee33ffd91e7830","unresolved":false,"context_lines":[{"line_number":15,"context_line":"and replace the VIP based readiness check with direct Galera"},{"line_number":16,"context_line":"status validation."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Galera status validation:"},{"line_number":19,"context_line":" - wsrep_cluster_status"},{"line_number":20,"context_line":" - wsrep_local_state_comment"},{"line_number":21,"context_line":" - wsrep_ready"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"0fbf3b43_ba00fbee","line":18,"in_reply_to":"5455da34_b40c74cd","updated":"2026-06-16 07:24:04.000000000","message":"Okay, now it is simple I think\n\n- Reason why role is moved before proxysql\n- Why VIP Read select was replaced by cluster validation\n\nMarking as resolved, please, reopen if you are not satisfied.","commit_id":"a3480865d2dbfd70b321b6ff329320de3d677fb1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3473b493f67dd0d110abb96ff8b2b84d1065ea3b","unresolved":true,"context_lines":[{"line_number":15,"context_line":"and replace the VIP based readiness check with direct Galera"},{"line_number":16,"context_line":"status validation."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Galera status validation:"},{"line_number":19,"context_line":" - wsrep_cluster_status"},{"line_number":20,"context_line":" - wsrep_local_state_comment"},{"line_number":21,"context_line":" - wsrep_ready"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5455da34_b40c74cd","line":18,"in_reply_to":"9141b662_c1b642ac","updated":"2026-06-15 13:57:47.000000000","message":"I prefer simple commit messages, not the convoluted versions hallucinated by AI - so yes, it will.","commit_id":"a3480865d2dbfd70b321b6ff329320de3d677fb1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5f0e4eee92adee819400d30d8a07958e6ceca015","unresolved":true,"context_lines":[{"line_number":15,"context_line":"and replace the VIP based readiness check with direct Galera"},{"line_number":16,"context_line":"status validation."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Galera status validation:"},{"line_number":19,"context_line":" - wsrep_cluster_status"},{"line_number":20,"context_line":" - wsrep_local_state_comment"},{"line_number":21,"context_line":" - wsrep_ready"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9141b662_c1b642ac","line":18,"in_reply_to":"cf28c844_3e22f4d4","updated":"2026-06-15 13:51:04.000000000","message":"Without context? The line you\u0027re currently commenting on is explicitly described right above it \n\n\"This patch is moving MariaDB deployment before the loadbalancer\nand replace the VIP based readiness check with direct Galera\nstatus validation.\"\n\nI agree that it does not explicitly state that, because the MariaDB role is now executed before the load balancer role, the readiness check can no longer rely on the VIP and therefore had to be replaced with a direct check (Galera check in this case).\n\nIf I rephrase the commit message to make that relationship explicit, would that address your concern?","commit_id":"a3480865d2dbfd70b321b6ff329320de3d677fb1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"52c558a9dff34d2caf86d372bcdc6dfb3b1e94b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"82069c43_e4b76684","updated":"2026-06-10 21:48:32.000000000","message":"This reduces the number of false-positive deployment failures in CI, and it is also a more sensible approach ...","commit_id":"99e1bfa6d8c3955b6e196f08eedff57724aa2efd"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5c466bdf24c96423b6fb692ace62635eafa5a437","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6e40eab3_d6fe78ec","updated":"2026-06-11 04:36:00.000000000","message":"recheck rocky new images","commit_id":"a3480865d2dbfd70b321b6ff329320de3d677fb1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7cdbd20dffbc725521c5bf83a2a3345390eec819","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c68ef5f0_d26bf2d4","updated":"2026-06-15 13:16:12.000000000","message":"three patches in one, no thanks - split that so we have more clarity and the option to partially revert it","commit_id":"a3480865d2dbfd70b321b6ff329320de3d677fb1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"133e3427c740a5646ebae3f09398238b3c0921e2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f08aeee2_eae92a47","in_reply_to":"c68ef5f0_d26bf2d4","updated":"2026-06-15 13:28:36.000000000","message":"It\u0027s not three in one - it\u0027s changes related to role movement. Check the comments, maybe it will be more clear.","commit_id":"a3480865d2dbfd70b321b6ff329320de3d677fb1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"711b3fa5eb03aca47b27c1d971fea5061b1367f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6cbe509a_3a998435","in_reply_to":"f08aeee2_eae92a47","updated":"2026-06-15 17:05:41.000000000","message":"Marking as resolved while keeping open other comments where the same is discussed/reviewed.","commit_id":"a3480865d2dbfd70b321b6ff329320de3d677fb1"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"29a0078789682c8f937c12177780519daefc9288","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"722ce86d_48789004","updated":"2026-06-16 07:31:30.000000000","message":"@mnasiadka@gmail.com You were faster, sorry, I\u0027ve added forgot retry as it was before and removed become. I expect it will pass, but let\u0027s see.","commit_id":"1e9342f77fa79c7a87dd4f34de13494c54455d24"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4ed59de95bdc549acb0314ca6e744ebe350ee39e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ad29c76f_ae242701","updated":"2026-06-16 11:10:01.000000000","message":"recheck is zull working ?","commit_id":"1e9342f77fa79c7a87dd4f34de13494c54455d24"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0a70f9d4726398d220edb453a8b3c547690cedbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f310d5f6_42ae49d6","updated":"2026-06-16 07:46:35.000000000","message":"recheck zuul not-trigerred","commit_id":"1e9342f77fa79c7a87dd4f34de13494c54455d24"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"4e72e1dfbb914815ee699c7663174ee65c460cc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4cc572fe_b878b92d","updated":"2026-06-16 11:11:44.000000000","message":"aaa, rebase worked ..weird ..rechecks not","commit_id":"b437c8efd4701599978d2a1e104a4777bd9e0931"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d901144ada2bdcedfa9e7426cd129d2c7989c0b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bfa7bec8_2f4a16c7","updated":"2026-06-16 11:11:27.000000000","message":"hmm,it seems zuul don\u0027t run check ...","commit_id":"b437c8efd4701599978d2a1e104a4777bd9e0931"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b29f5f53798c8875aebe96346a148960fc76c828","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4f436702_461e9945","updated":"2026-06-19 13:33:23.000000000","message":"recheck non-related","commit_id":"8e1b4bf8e86d9e5fcd0faca58bc9e5c0871cc057"},{"author":{"_account_id":36765,"name":"Seunghun Lee","display_name":"Seunghun Lee","email":"seunghun@stackhpc.com","username":"seunghun1ee","status":"Cloud Engineer at StackHPC"},"change_message_id":"0ccb9d96ce9522b08fc4478db80b93861b9488bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"58020811_b87cd414","updated":"2026-07-02 14:59:35.000000000","message":"I think we need to move database status check through VIP to loadbalancer role but that can be another patch.","commit_id":"fc2e8055c7678cd483e1b4fca587dd3243218ff5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2b1c4a18a066c56f2377b37bf7aade8ea0ab587f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"77d48b4e_cfcc9677","updated":"2026-07-06 20:13:37.000000000","message":"recheck podman not related","commit_id":"0f5b9ad4c07b07af0336d8f6131c8fcbffc266ac"},{"author":{"_account_id":37203,"name":"Bertrand Lanson","display_name":"Bertrand Lanson","email":"bertrand.lanson@infomaniak.com","username":"lanson","status":"Infomaniak Network SA"},"change_message_id":"27d9d3ac5208631a3338ac747befa5124c4ccc93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"333422bb_00c1637f","updated":"2026-07-07 13:08:49.000000000","message":"LGTM, wass hesitant if this needed a reno but ultimately I think not.","commit_id":"aed9d89023e752c38972c9d389cb6a916c1b50f0"}],"ansible/roles/mariadb/tasks/check.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7cdbd20dffbc725521c5bf83a2a3345390eec819","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Checking Mariadb containers"},{"line_number":3,"context_line":"  ansible.builtin.import_role:"},{"line_number":4,"context_line":"    role: service-check"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"0693c8a5_09514a91","side":"PARENT","line":1,"updated":"2026-06-15 13:16:12.000000000","message":"Why are you removing this?","commit_id":"971e71405e640e1b4f7679bac3fea26a881b71bf"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"315e5ca3c458676118c8b9b2215df6a1f70a2460","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Checking Mariadb containers"},{"line_number":3,"context_line":"  ansible.builtin.import_role:"},{"line_number":4,"context_line":"    role: service-check"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"b92dda8a_477bff73","side":"PARENT","line":1,"in_reply_to":"0693c8a5_09514a91","updated":"2026-06-15 13:27:06.000000000","message":"Accident, ack.","commit_id":"971e71405e640e1b4f7679bac3fea26a881b71bf"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c7dcb72ac3d8a3ca76bba8e5804cd407aeacb1d6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Checking Mariadb containers"},{"line_number":3,"context_line":"  ansible.builtin.import_role:"},{"line_number":4,"context_line":"    role: service-check"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"948853cb_f5f3d44b","side":"PARENT","line":1,"in_reply_to":"b92dda8a_477bff73","updated":"2026-06-15 13:36:45.000000000","message":"Done","commit_id":"971e71405e640e1b4f7679bac3fea26a881b71bf"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7cdbd20dffbc725521c5bf83a2a3345390eec819","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  ansible.builtin.import_role:"},{"line_number":4,"context_line":"    role: service-check"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Wait for MariaDB service to be ready through VIP"},{"line_number":7,"context_line":"  kolla_toolbox:"},{"line_number":8,"context_line":"    container_engine: \"{{ kolla_container_engine }}\""},{"line_number":9,"context_line":"    module_name: mysql_query"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dc75ddac_ba78bd08","side":"PARENT","line":6,"updated":"2026-06-15 13:16:12.000000000","message":"Split that out to a different patch? Doesn\u0027t look related.","commit_id":"971e71405e640e1b4f7679bac3fea26a881b71bf"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"40e0d052fb11cbb5f908a26b3bc78e17b3fa6bdb","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  ansible.builtin.import_role:"},{"line_number":4,"context_line":"    role: service-check"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Wait for MariaDB service to be ready through VIP"},{"line_number":7,"context_line":"  kolla_toolbox:"},{"line_number":8,"context_line":"    container_engine: \"{{ kolla_container_engine }}\""},{"line_number":9,"context_line":"    module_name: mysql_query"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ad3ea90e_6cb1fc89","side":"PARENT","line":6,"in_reply_to":"5c04d912_936767f1","updated":"2026-06-15 13:59:04.000000000","message":"Okay, totally understand.\n\nSince MariaDB was always deployed after the load balancer, it made sense to verify readiness through the VIP because the load balancer was already configured.\n\nNow that MariaDB is being moved before the load balancer, there are a few options:\n\nRemove this check entirely.\nPerform the readiness check directly against the node/s.\nPerform a readiness check combined with a Galera status check.\n\nWhich approach would you prefer?","commit_id":"971e71405e640e1b4f7679bac3fea26a881b71bf"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2aba44bb102a60d72275bcd5c8ee33ffd91e7830","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  ansible.builtin.import_role:"},{"line_number":4,"context_line":"    role: service-check"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Wait for MariaDB service to be ready through VIP"},{"line_number":7,"context_line":"  kolla_toolbox:"},{"line_number":8,"context_line":"    container_engine: \"{{ kolla_container_engine }}\""},{"line_number":9,"context_line":"    module_name: mysql_query"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"85869a70_019b290e","side":"PARENT","line":6,"in_reply_to":"ad3ea90e_6cb1fc89","updated":"2026-06-16 07:24:04.000000000","message":"Marking as resolved. Check replacement is directly related to the change and is explicitly mentioned in the commit message now. Please, reopen if not satisfied.","commit_id":"971e71405e640e1b4f7679bac3fea26a881b71bf"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c7dcb72ac3d8a3ca76bba8e5804cd407aeacb1d6","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  ansible.builtin.import_role:"},{"line_number":4,"context_line":"    role: service-check"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Wait for MariaDB service to be ready through VIP"},{"line_number":7,"context_line":"  kolla_toolbox:"},{"line_number":8,"context_line":"    container_engine: \"{{ kolla_container_engine }}\""},{"line_number":9,"context_line":"    module_name: mysql_query"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5c04d912_936767f1","side":"PARENT","line":6,"in_reply_to":"c7164e6b_27c056b5","updated":"2026-06-15 13:36:45.000000000","message":"You\u0027re switching from listing databases to checking Galera status, no mention anywhere why we\u0027re doing this like that. Reviewers without context will don\u0027t know why are we doing this - the commit message also doesn\u0027t mention the reason.","commit_id":"971e71405e640e1b4f7679bac3fea26a881b71bf"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"315e5ca3c458676118c8b9b2215df6a1f70a2460","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  ansible.builtin.import_role:"},{"line_number":4,"context_line":"    role: service-check"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Wait for MariaDB service to be ready through VIP"},{"line_number":7,"context_line":"  kolla_toolbox:"},{"line_number":8,"context_line":"    container_engine: \"{{ kolla_container_engine }}\""},{"line_number":9,"context_line":"    module_name: mysql_query"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c7164e6b_27c056b5","side":"PARENT","line":6,"in_reply_to":"dc75ddac_ba78bd08","updated":"2026-06-15 13:27:06.000000000","message":"Of course it\u0027s related, reason is that mariadb role is deployed now before VIP is alive - as a loadbalancer role is not installed yet. Because of this I am replacing VIP check by another check (check if cluster is ready ) - are u sure that I should completly remove this check and add it (same one) again in another review ? That doesn\u0027t make sense to me.","commit_id":"971e71405e640e1b4f7679bac3fea26a881b71bf"},{"author":{"_account_id":35263,"name":"Matt Crees","email":"mattc@stackhpc.com","username":"mattcrees"},"change_message_id":"1b2e30e24eef1a88a4e021f5396478479fc64931","unresolved":true,"context_lines":[{"line_number":16,"context_line":"  register: result"},{"line_number":17,"context_line":"  until: result is success"},{"line_number":18,"context_line":"  changed_when: false"},{"line_number":19,"context_line":"  retries: 6"},{"line_number":20,"context_line":"  delay: 10"},{"line_number":21,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"f6276b61_d15257b1","side":"PARENT","line":19,"updated":"2026-06-23 08:08:44.000000000","message":"Would it make sense to keep the retries here, in case the cluster doesn\u0027t reach the healthy states right away?","commit_id":"d75cfb9d75719d68ae346da0f0132eb178938e68"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"799f1249f1fc34c5e3c5d44598869ff9da265fce","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  register: result"},{"line_number":17,"context_line":"  until: result is success"},{"line_number":18,"context_line":"  changed_when: false"},{"line_number":19,"context_line":"  retries: 6"},{"line_number":20,"context_line":"  delay: 10"},{"line_number":21,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"ccbc95f5_22cc3d32","side":"PARENT","line":19,"in_reply_to":"f6276b61_d15257b1","updated":"2026-06-23 08:47:05.000000000","message":"Yep, I had it somewhere else in my notebook ... here it is.","commit_id":"d75cfb9d75719d68ae346da0f0132eb178938e68"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8384d63d0fa2715effa03b5120f7660c4fdf8496","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Check MariaDB Galera cluster status"},{"line_number":7,"context_line":"  vars:"},{"line_number":8,"context_line":"    galera_status: \"{{ mariadb_cluster_status.query_result[0] | items2dict(key_name\u003d\u0027Variable_name\u0027, value_name\u003d\u0027Value\u0027) }}\""},{"line_number":9,"context_line":"  kolla_toolbox:"},{"line_number":10,"context_line":"    container_engine: \"{{ kolla_container_engine }}\""},{"line_number":11,"context_line":"    module_name: mysql_query"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3763dbb2_d792ed45","line":8,"range":{"start_line":8,"start_character":23,"end_line":8,"end_character":58},"updated":"2026-07-06 11:38:07.000000000","message":"What if for some reason query_result is not populated? Will this fail miserably without any normal message to the user?","commit_id":"fc2e8055c7678cd483e1b4fca587dd3243218ff5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e28b4e1653253a1e341d1f045002c62f49684ea3","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Check MariaDB Galera cluster status"},{"line_number":7,"context_line":"  vars:"},{"line_number":8,"context_line":"    galera_status: \"{{ mariadb_cluster_status.query_result[0] | items2dict(key_name\u003d\u0027Variable_name\u0027, value_name\u003d\u0027Value\u0027) }}\""},{"line_number":9,"context_line":"  kolla_toolbox:"},{"line_number":10,"context_line":"    container_engine: \"{{ kolla_container_engine }}\""},{"line_number":11,"context_line":"    module_name: mysql_query"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ab1ec22a_e1b8bc33","line":8,"range":{"start_line":8,"start_character":23,"end_line":8,"end_character":58},"in_reply_to":"3763dbb2_d792ed45","updated":"2026-07-06 14:12:43.000000000","message":"It will of course fail, because there is retry and until ...","commit_id":"fc2e8055c7678cd483e1b4fca587dd3243218ff5"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"58537be540577dac0e8612537302c884b4fc3b47","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Check MariaDB Galera cluster status"},{"line_number":7,"context_line":"  vars:"},{"line_number":8,"context_line":"    galera_status: \"{{ mariadb_cluster_status.query_result[0] | items2dict(key_name\u003d\u0027Variable_name\u0027, value_name\u003d\u0027Value\u0027) }}\""},{"line_number":9,"context_line":"  kolla_toolbox:"},{"line_number":10,"context_line":"    container_engine: \"{{ kolla_container_engine }}\""},{"line_number":11,"context_line":"    module_name: mysql_query"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"5c7d7146_89120d7f","line":8,"range":{"start_line":8,"start_character":23,"end_line":8,"end_character":58},"in_reply_to":"ab1ec22a_e1b8bc33","updated":"2026-07-06 21:59:39.000000000","message":"Okay, I rework so now user will see what\u0027s going on...","commit_id":"fc2e8055c7678cd483e1b4fca587dd3243218ff5"}],"ansible/roles/mariadb/tasks/loadbalancer.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7cdbd20dffbc725521c5bf83a2a3345390eec819","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# NOTE(kevko): We have to ignore errors"},{"line_number":3,"context_line":"# as new deployments have no galera"},{"line_number":4,"context_line":"# running. In that case, user will be created"},{"line_number":5,"context_line":"# in mariadb role."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c45aaf42_fc0732d6","side":"PARENT","line":2,"updated":"2026-06-15 13:16:12.000000000","message":"That should be a separate patch for clarity?","commit_id":"971e71405e640e1b4f7679bac3fea26a881b71bf"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"40e0d052fb11cbb5f908a26b3bc78e17b3fa6bdb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# NOTE(kevko): We have to ignore errors"},{"line_number":3,"context_line":"# as new deployments have no galera"},{"line_number":4,"context_line":"# running. In that case, user will be created"},{"line_number":5,"context_line":"# in mariadb role."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"aa7fea3b_a30b8120","side":"PARENT","line":2,"in_reply_to":"4e49a7a9_8266eec4","updated":"2026-06-15 13:59:04.000000000","message":"You are right, we can.","commit_id":"971e71405e640e1b4f7679bac3fea26a881b71bf"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"315e5ca3c458676118c8b9b2215df6a1f70a2460","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# NOTE(kevko): We have to ignore errors"},{"line_number":3,"context_line":"# as new deployments have no galera"},{"line_number":4,"context_line":"# running. In that case, user will be created"},{"line_number":5,"context_line":"# in mariadb role."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f8077cca_bdb434af","side":"PARENT","line":2,"in_reply_to":"c45aaf42_fc0732d6","updated":"2026-06-15 13:27:06.000000000","message":"Again, this is also related for role movement in site.yml. Why ? Because monitor user is already created in ansible/roles/mariadb/tasks/register.yml. This task is here only historically when haproxy/proxysql switch was possible - another option is to leave it as is and don\u0027t remove this task. So what\u0027s your opinion ?","commit_id":"971e71405e640e1b4f7679bac3fea26a881b71bf"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c7dcb72ac3d8a3ca76bba8e5804cd407aeacb1d6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# NOTE(kevko): We have to ignore errors"},{"line_number":3,"context_line":"# as new deployments have no galera"},{"line_number":4,"context_line":"# running. In that case, user will be created"},{"line_number":5,"context_line":"# in mariadb role."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4e49a7a9_8266eec4","side":"PARENT","line":2,"in_reply_to":"f8077cca_bdb434af","updated":"2026-06-15 13:36:45.000000000","message":"Well, you claim it\u0027s here only historically for switching purposes - switching is no longer possible - so why can\u0027t we remove it in a separate patch?","commit_id":"971e71405e640e1b4f7679bac3fea26a881b71bf"}]}