)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0de65d099610c1176c557ab3350c4600298bc046","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c14983ce_c362ccae","updated":"2026-06-23 08:48:46.000000000","message":"This is not going to work, because that role is imported from e.g. blazer role tasks, if you disable nova - these tasks will not run","commit_id":"b254ba583fe498009e94329bb24d742195116230"},{"author":{"_account_id":39224,"name":"Bhavana S","display_name":"Bhavana","email":"bhavanas@cdac.in","username":"bhavana-s"},"change_message_id":"296eb8eb807dc6ece1b0f368ee14f66f6ec4b4d3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"cdd6c231_70e70961","in_reply_to":"c14983ce_c362ccae","updated":"2026-06-23 09:16:31.000000000","message":"Good catch, @MichalNasiadka . You are completely right—if the top-level enable_\u003cproject\u003e toggle is set to false, site.yml skips the project role entirely, so service-check-containers is never imported for that disabled service.\n\nThe logic to stop/remove enabled: False containers is passing lint/syntax, but it clearly needs to live in a role that executes globally on the nodes regardless of the enable_* flags.\n\nFrom an architectural standpoint, where would you prefer this cleanup loop to live? Should this be appended to an always-run role like common, or does this warrant a dedicated cleanup-disabled-services role imported at the beginning/end of site.yml? Happy to move the tasks wherever makes the most sense.","commit_id":"b254ba583fe498009e94329bb24d742195116230"},{"author":{"_account_id":39224,"name":"Bhavana S","display_name":"Bhavana","email":"bhavanas@cdac.in","username":"bhavana-s"},"change_message_id":"fe97e3a4f0c7e1bc0071bf9947eb196ecae53a7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fdaef6a2_3864d72a","in_reply_to":"cdd6c231_70e70961","updated":"2026-06-24 08:49:42.000000000","message":"Done","commit_id":"b254ba583fe498009e94329bb24d742195116230"}],"ansible/roles/service-check-containers/tasks/main.yml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"9484f6b35a877e8a376369a9ba30151ab7b86492","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d---"},{"line_number":2,"context_line":"# NOTE(r-krcek): List of arguments should follow argument_spec in"},{"line_number":3,"context_line":"# kolla_container module"},{"line_number":4,"context_line":"- name: \"Check containers for {{ kolla_role_name | default(project_name) }}\""},{"line_number":5,"context_line":"  become: true"},{"line_number":6,"context_line":"  vars:"},{"line_number":7,"context_line":"    service: \"{{ item.value }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d7243f1b_a70b6cc4","line":4,"updated":"2026-06-21 05:30:44.000000000","message":"linters: load-failure[yaml][/]: Failed to load YAML file (warning)","commit_id":"d06da356c35b3e8058a3cd14a2d84241c04c254c"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"9484f6b35a877e8a376369a9ba30151ab7b86492","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d---"},{"line_number":2,"context_line":"# NOTE(r-krcek): List of arguments should follow argument_spec in"},{"line_number":3,"context_line":"# kolla_container module"},{"line_number":4,"context_line":"- name: \"Check containers for {{ kolla_role_name | default(project_name) }}\""},{"line_number":5,"context_line":"  become: true"},{"line_number":6,"context_line":"  vars:"},{"line_number":7,"context_line":"    service: \"{{ item.value }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"34b72a29_b9dbd0dc","line":4,"updated":"2026-06-21 05:30:44.000000000","message":"linters: syntax-check[specific][/]: YAML parsing failed: Did not find expected \u003cdocument start\u003e.","commit_id":"d06da356c35b3e8058a3cd14a2d84241c04c254c"}]}
