)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37313,"name":"Alma MAILLET-CONTOZ","display_name":"Alma MAILLET-CONTOZ","email":"alma.maillet-contoz@infomaniak.com","username":"nicolasmc","status":"Intern SRE at Infomaniak"},"change_message_id":"13db1ca8b42bb0932b4393fa16a0eebcfbaeefc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1e28957a_58751e5d","updated":"2026-07-16 16:32:52.000000000","message":"As it\u0027s already present in Horizon, it\u0027s ok for me","commit_id":"49df3aabbb719f443a1e436c96bbc85fe4038d90"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"98a8b1bff8390f6e329d9f20599993f23373eb2d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4314c026_518eccdb","updated":"2026-07-16 17:11:51.000000000","message":"Lack of the reno. Users should know about a new variable.","commit_id":"49df3aabbb719f443a1e436c96bbc85fe4038d90"},{"author":{"_account_id":39303,"name":"Sean Butler-Lee","display_name":"seanblee","email":"seanblee@gmail.com","username":"seanblee"},"change_message_id":"cec0d9fd0eafd8050aedabcf35370f2cc3f9a661","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f4c40660_d20c086f","in_reply_to":"4314c026_518eccdb","updated":"2026-07-16 18:35:48.000000000","message":"Thanks, added","commit_id":"49df3aabbb719f443a1e436c96bbc85fe4038d90"}],"ansible/roles/skyline/defaults/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d6831b5efe2868b546fa20cddbcd19891699a9e2","unresolved":true,"context_lines":[{"line_number":169,"context_line":"  - admin"},{"line_number":170,"context_line":"skyline_system_reader_roles:"},{"line_number":171,"context_line":"  - system_reader"},{"line_number":172,"context_line":"skyline_keystone_url: \"{{ keystone_public_url if skyline_use_keystone_public_url | bool else keystone_internal_url }}/v3/\""},{"line_number":173,"context_line":"skyline_session_name: session"},{"line_number":174,"context_line":"skyline_reclaim_instance_interval: 604800"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"4fb57941_cc3ccb9a","line":172,"updated":"2026-07-16 18:48:25.000000000","message":"to me this is making things unnecessarily complicated. having\n\n```\nskyline_keystone_url: \"{{ keystone_public_url }}/v3/\"\n```\n\nisn\u0027t much worse than setting `skyline_use_keystone_public_url: true`","commit_id":"c9edccea8837cf934f928b91556bdbf8fdb187d9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"82070fcda95402276f96cc589d7d07dc7cd22a88","unresolved":true,"context_lines":[{"line_number":169,"context_line":"  - admin"},{"line_number":170,"context_line":"skyline_system_reader_roles:"},{"line_number":171,"context_line":"  - system_reader"},{"line_number":172,"context_line":"skyline_keystone_url: \"{{ keystone_public_url if skyline_use_keystone_public_url | bool else keystone_internal_url }}/v3/\""},{"line_number":173,"context_line":"skyline_session_name: session"},{"line_number":174,"context_line":"skyline_reclaim_instance_interval: 604800"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3a27628a_ee0062a8","line":172,"in_reply_to":"2ae468e3_923f1bd1","updated":"2026-07-17 13:45:26.000000000","message":"it is defined in ansible/group_vars/all/keystone.yml, if it wasn\u0027t, you couldn\u0027t use it here, either? IMO introducing horizon_use_keystone_public_url was a mistake, too, but that was a long time ago and we cannot easily revert it now. but that\u0027s not enough of a reason for me to now duplicate this mistake","commit_id":"c9edccea8837cf934f928b91556bdbf8fdb187d9"},{"author":{"_account_id":37313,"name":"Alma MAILLET-CONTOZ","display_name":"Alma MAILLET-CONTOZ","email":"alma.maillet-contoz@infomaniak.com","username":"nicolasmc","status":"Intern SRE at Infomaniak"},"change_message_id":"afc709e6eeb1a83e0c092590f1c1c0400fe3d275","unresolved":true,"context_lines":[{"line_number":169,"context_line":"  - admin"},{"line_number":170,"context_line":"skyline_system_reader_roles:"},{"line_number":171,"context_line":"  - system_reader"},{"line_number":172,"context_line":"skyline_keystone_url: \"{{ keystone_public_url if skyline_use_keystone_public_url | bool else keystone_internal_url }}/v3/\""},{"line_number":173,"context_line":"skyline_session_name: session"},{"line_number":174,"context_line":"skyline_reclaim_instance_interval: 604800"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"10dd6e55_c05ea8d6","line":172,"in_reply_to":"3a27628a_ee0062a8","updated":"2026-07-17 20:56:15.000000000","message":"I +1ed because I saw it was pushed in Horizon. However I agree. If you want to use the public URL, you can just override the right var IMO.","commit_id":"c9edccea8837cf934f928b91556bdbf8fdb187d9"},{"author":{"_account_id":39303,"name":"Sean Butler-Lee","display_name":"seanblee","email":"seanblee@gmail.com","username":"seanblee"},"change_message_id":"60c800f6ce030f72eb2e260afcb6567d71baef48","unresolved":true,"context_lines":[{"line_number":169,"context_line":"  - admin"},{"line_number":170,"context_line":"skyline_system_reader_roles:"},{"line_number":171,"context_line":"  - system_reader"},{"line_number":172,"context_line":"skyline_keystone_url: \"{{ keystone_public_url if skyline_use_keystone_public_url | bool else keystone_internal_url }}/v3/\""},{"line_number":173,"context_line":"skyline_session_name: session"},{"line_number":174,"context_line":"skyline_reclaim_instance_interval: 604800"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2ae468e3_923f1bd1","line":172,"in_reply_to":"4fb57941_cc3ccb9a","updated":"2026-07-16 19:28:18.000000000","message":"But I don\u0027t think ``keystone_public_url`` is defined e.g. in globals.yml, so can\u0027t be used in an override - my proposal here mirrors near identical existing code in Horizon.","commit_id":"c9edccea8837cf934f928b91556bdbf8fdb187d9"}]}