)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"8c712a883cabf51cedcebfaf037a451736844dc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d3af5059_59562cf4","updated":"2026-07-28 01:36:12.000000000","message":"Finally fixes race .... please review","commit_id":"b24aae1723495eafc9e254a08ecdf4fd7e439408"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"84a884eb0b9215dccad5cf2d8d0082c8673b1aa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e2c12e1b_4833ca03","updated":"2026-07-28 05:55:39.000000000","message":"Found that race was not resolved by previous patch while checking zuul test results for https://review.opendev.org/c/openstack/kolla/+/989849?tab\u003dchange-view-tab-header-zuul-results-summary where it failed https://zuul.opendev.org/t/openstack/build/ea3e6f0115ba4431857337e2289a60d2 .\n\nNow, it should be finally fixed...","commit_id":"b24aae1723495eafc9e254a08ecdf4fd7e439408"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"bfd322d83b21712bfc532c097bead88846d38613","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1af11180_9ee1a77b","updated":"2026-07-28 09:36:15.000000000","message":"recheck fresh results","commit_id":"b24aae1723495eafc9e254a08ecdf4fd7e439408"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8ceeb7bfbed270f0a413a5579655ceec8a3b3477","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"08976a43_6018a790","updated":"2026-07-28 18:03:54.000000000","message":"Could the commit message explain why the previous fix (cb259a391) didn\u0027t resolve this? Right now it describes what the patch does, but not the root cause.","commit_id":"4cf841a285623cb7df2c7219f92b8799fb76205b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ac1516a50ed81defb167bb4f1e1e1d9fa73f437f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6880743b_994fcdb2","in_reply_to":"08976a43_6018a790","updated":"2026-07-28 18:14:31.000000000","message":"well the  previous fix reduced the chance of the issue but did not eliminate the race completely...slave nodes could still be restarted while a previously started node was still rejoining the cluster...so if the earlier node had not yet reached the Synced state, the next restart could interrupt or destabilizate the state transfer, resulting in an incomplete IST and leaving the node outside the primary component...\n\nThis change simply ensures that each slave node is fully synchronized before proceeding with the next one... previous patch waited for synced ..but actually restarted slaves at once ..sometimes it\u0027s working sometimes it is not...","commit_id":"4cf841a285623cb7df2c7219f92b8799fb76205b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"13b75b0252012cdebbb2ca3d07c5af500fd77671","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6b2c3385_cc1a28a1","in_reply_to":"6880743b_994fcdb2","updated":"2026-07-28 18:24:27.000000000","message":"Please, reopen if needed.","commit_id":"4cf841a285623cb7df2c7219f92b8799fb76205b"}],"ansible/roles/mariadb/tasks/recover_cluster.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8ceeb7bfbed270f0a413a5579655ceec8a3b3477","unresolved":true,"context_lines":[{"line_number":215,"context_line":"    - bootstrap_host is defined"},{"line_number":216,"context_line":"    - bootstrap_host !\u003d inventory_hostname"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"# The master restart below is a Galera cluster membership change. If it"},{"line_number":219,"context_line":"# happens while a slave is still receiving its IST, the joiner aborts with"},{"line_number":220,"context_line":"# \"IST didn\u0027t contain all write sets ... node restart required\" and stays"},{"line_number":221,"context_line":"# permanently disconnected, so wait for every slave to finish syncing first."},{"line_number":222,"context_line":"- name: Wait for slave MariaDB to sync WSREP"},{"line_number":223,"context_line":"  become: true"},{"line_number":224,"context_line":"  kolla_toolbox:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"32c366d5_53f6c0cd","side":"PARENT","line":221,"range":{"start_line":218,"start_character":0,"end_line":221,"end_character":76},"updated":"2026-07-28 18:03:54.000000000","message":"We lost that comment","commit_id":"0484f7b66d1541710bc820e8af88d6d9117c5f63"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"282de0ba7ce21cd8d362b53abd8f86c533771644","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    - bootstrap_host is defined"},{"line_number":216,"context_line":"    - bootstrap_host !\u003d inventory_hostname"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"# The master restart below is a Galera cluster membership change. If it"},{"line_number":219,"context_line":"# happens while a slave is still receiving its IST, the joiner aborts with"},{"line_number":220,"context_line":"# \"IST didn\u0027t contain all write sets ... node restart required\" and stays"},{"line_number":221,"context_line":"# permanently disconnected, so wait for every slave to finish syncing first."},{"line_number":222,"context_line":"- name: Wait for slave MariaDB to sync WSREP"},{"line_number":223,"context_line":"  become: true"},{"line_number":224,"context_line":"  kolla_toolbox:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"387ab43b_4f033898","side":"PARENT","line":221,"range":{"start_line":218,"start_character":0,"end_line":221,"end_character":76},"in_reply_to":"32c366d5_53f6c0cd","updated":"2026-07-28 18:19:32.000000000","message":"yeah ... I removed the comment because, after moving the slave recovery into a separate sequential task file, it was no longer describing the task directly below it.","commit_id":"0484f7b66d1541710bc820e8af88d6d9117c5f63"}]}
