)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f2152aad2ab053af1c01d42376855a8b1bf69b2c","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, in the loadbalancer role has"},{"line_number":10,"context_line":"`enable_haproxy: true`, always installing haproxy,"},{"line_number":11,"context_line":"even when `enable_haproxy: \"no\"` is set in globals.yml`."},{"line_number":12,"context_line":"This sets the vale to respect the globals.yml override."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This tripped me up when I had to disable haproxy to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"21b324d3_b237a2bb","line":11,"range":{"start_line":11,"start_character":43,"end_line":11,"end_character":56},"updated":"2026-08-04 16:00:46.000000000","message":"Missing opening backtick","commit_id":"7dd62f85c031b20e0e945d43b2c8ab00dcea5b63"},{"author":{"_account_id":38857,"name":"Kurt Bendl","display_name":"kbendl","email":"kbendl@tool.net","username":"kbendl"},"change_message_id":"4ae53a2ec36d5e751db05dcfcf3aa43e2b06b58e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, in the loadbalancer role has"},{"line_number":10,"context_line":"`enable_haproxy: true`, always installing haproxy,"},{"line_number":11,"context_line":"even when `enable_haproxy: \"no\"` is set in globals.yml`."},{"line_number":12,"context_line":"This sets the vale to respect the globals.yml override."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This tripped me up when I had to disable haproxy to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f928b4fd_d124d816","line":11,"range":{"start_line":11,"start_character":43,"end_line":11,"end_character":56},"in_reply_to":"21b324d3_b237a2bb","updated":"2026-08-04 18:50:52.000000000","message":"Done","commit_id":"7dd62f85c031b20e0e945d43b2c8ab00dcea5b63"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f2152aad2ab053af1c01d42376855a8b1bf69b2c","unresolved":true,"context_lines":[{"line_number":10,"context_line":"`enable_haproxy: true`, always installing haproxy,"},{"line_number":11,"context_line":"even when `enable_haproxy: \"no\"` is set in globals.yml`."},{"line_number":12,"context_line":"This sets the vale to respect the globals.yml override."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This tripped me up when I had to disable haproxy to"},{"line_number":15,"context_line":"get some testing/development done when deploying the"},{"line_number":16,"context_line":"kolla-ansible aio install."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Updated change to set default\u003dtrue if no value set:"},{"line_number":19,"context_line":"`enable_haproxy: \"{{ enable_haproxy | default(true) | bool }}\"`"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"679e60df_06e73c76","line":16,"range":{"start_line":13,"start_character":0,"end_line":16,"end_character":26},"updated":"2026-08-04 16:00:46.000000000","message":"You can remove this part","commit_id":"7dd62f85c031b20e0e945d43b2c8ab00dcea5b63"},{"author":{"_account_id":38857,"name":"Kurt Bendl","display_name":"kbendl","email":"kbendl@tool.net","username":"kbendl"},"change_message_id":"4ae53a2ec36d5e751db05dcfcf3aa43e2b06b58e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"`enable_haproxy: true`, always installing haproxy,"},{"line_number":11,"context_line":"even when `enable_haproxy: \"no\"` is set in globals.yml`."},{"line_number":12,"context_line":"This sets the vale to respect the globals.yml override."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This tripped me up when I had to disable haproxy to"},{"line_number":15,"context_line":"get some testing/development done when deploying the"},{"line_number":16,"context_line":"kolla-ansible aio install."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Updated change to set default\u003dtrue if no value set:"},{"line_number":19,"context_line":"`enable_haproxy: \"{{ enable_haproxy | default(true) | bool }}\"`"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9b257343_86dce423","line":16,"range":{"start_line":13,"start_character":0,"end_line":16,"end_character":26},"in_reply_to":"679e60df_06e73c76","updated":"2026-08-04 18:50:52.000000000","message":"Done","commit_id":"7dd62f85c031b20e0e945d43b2c8ab00dcea5b63"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"cec95c81a520a1a52ce383c18fdec5dc1715fd66","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Kurt Bendl \u003ckbendl@tool.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-08-04 18:33:57 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix hard-coded value for enable_haproxy."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, the loadbalancer role has"},{"line_number":10,"context_line":"`enable_haproxy: true`, causing haproxy to always install on deploy,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1df8f367_c41409e8","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":40},"updated":"2026-08-05 08:41:59.000000000","message":"Style nit: we don\u0027t put a final dot at the end of the first line","commit_id":"82fecc23698d22af283e5d4ddde60e9a44af13d9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38857,"name":"Kurt Bendl","display_name":"kbendl","email":"kbendl@tool.net","username":"kbendl"},"change_message_id":"81b9d32040cb57d2879f2e660d103b6bf1b627f8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1c31f2ce_04408ebe","updated":"2026-08-04 18:08:10.000000000","message":"Simple tweak to allow `enable_haproxy: \"no\"` to work when added to `globals.yml`.","commit_id":"7dd62f85c031b20e0e945d43b2c8ab00dcea5b63"},{"author":{"_account_id":38857,"name":"Kurt Bendl","display_name":"kbendl","email":"kbendl@tool.net","username":"kbendl"},"change_message_id":"68798c89c9f77fa5328733064bacc7eb7dde9b6e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f82384f0_96220d09","updated":"2026-08-04 18:24:44.000000000","message":"Yeah, setting a default(true) for enable_haproxy may be redundant, but it\u0027s kind of a safety net if, in case for some reason it doesn\u0027t get defined in group_vars or elsewhere. I\u0027m happy to remove the default here if that\u0027s preferred.","commit_id":"7dd62f85c031b20e0e945d43b2c8ab00dcea5b63"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9b622a081e682f9eb6e718d00574433bc3b8b218","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3e9efc7c_0810fdda","in_reply_to":"1c31f2ce_04408ebe","updated":"2026-08-04 18:15:14.000000000","message":"Any reason for disabling haproxy, but not proxysql?","commit_id":"7dd62f85c031b20e0e945d43b2c8ab00dcea5b63"},{"author":{"_account_id":38857,"name":"Kurt Bendl","display_name":"kbendl","email":"kbendl@tool.net","username":"kbendl"},"change_message_id":"7686ae03359e0c74434ddeaafb7b1f21d1c07f60","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"71f2ea40_07a1454a","in_reply_to":"3e9efc7c_0810fdda","updated":"2026-08-04 18:28:42.000000000","message":"haproxy was colliding with a few other services\u0027 network ports on the aio build. proxysql and mariadb were not a problem.","commit_id":"7dd62f85c031b20e0e945d43b2c8ab00dcea5b63"},{"author":{"_account_id":38857,"name":"Kurt Bendl","display_name":"kbendl","email":"kbendl@tool.net","username":"kbendl"},"change_message_id":"4ae53a2ec36d5e751db05dcfcf3aa43e2b06b58e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2a7656d4_a00957fc","in_reply_to":"71f2ea40_07a1454a","updated":"2026-08-04 18:50:52.000000000","message":"Acknowledged","commit_id":"7dd62f85c031b20e0e945d43b2c8ab00dcea5b63"}],"ansible/roles/loadbalancer/defaults/main.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"f2152aad2ab053af1c01d42376855a8b1bf69b2c","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  haproxy:"},{"line_number":4,"context_line":"    container_name: haproxy"},{"line_number":5,"context_line":"    group: loadbalancer"},{"line_number":6,"context_line":"    enabled: \"{{ enable_haproxy | default(true) | bool }}\""},{"line_number":7,"context_line":"    image: \"{{ haproxy_image_full }}\""},{"line_number":8,"context_line":"    privileged: true"},{"line_number":9,"context_line":"    volumes: \"{{ haproxy_default_volumes + haproxy_extra_volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c919f435_18016cad","line":6,"updated":"2026-08-04 16:00:46.000000000","message":"enable_haproxy is already set in ansible/group_vars/all/haproxy.yml, so you probably don\u0027t need a default?","commit_id":"7dd62f85c031b20e0e945d43b2c8ab00dcea5b63"},{"author":{"_account_id":38857,"name":"Kurt Bendl","display_name":"kbendl","email":"kbendl@tool.net","username":"kbendl"},"change_message_id":"4ae53a2ec36d5e751db05dcfcf3aa43e2b06b58e","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  haproxy:"},{"line_number":4,"context_line":"    container_name: haproxy"},{"line_number":5,"context_line":"    group: loadbalancer"},{"line_number":6,"context_line":"    enabled: \"{{ enable_haproxy | default(true) | bool }}\""},{"line_number":7,"context_line":"    image: \"{{ haproxy_image_full }}\""},{"line_number":8,"context_line":"    privileged: true"},{"line_number":9,"context_line":"    volumes: \"{{ haproxy_default_volumes + haproxy_extra_volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d9c68996_ebca3482","line":6,"in_reply_to":"7636d9c1_b6554880","updated":"2026-08-04 18:50:52.000000000","message":"Just checking how other container/service handle setting the *_enabled value, a few do and some don\u0027t set a default value. [neutron, fluentd, glance, horizon, ironic] among other set a default setting. I assumed that was the more preferred method. Example:\n```\nneutron_sriov_agent:\n  enabled: \"{{ enable_neutron_sriov | default(false) | bool }}\"\n```","commit_id":"7dd62f85c031b20e0e945d43b2c8ab00dcea5b63"},{"author":{"_account_id":38857,"name":"Kurt Bendl","display_name":"kbendl","email":"kbendl@tool.net","username":"kbendl"},"change_message_id":"7686ae03359e0c74434ddeaafb7b1f21d1c07f60","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  haproxy:"},{"line_number":4,"context_line":"    container_name: haproxy"},{"line_number":5,"context_line":"    group: loadbalancer"},{"line_number":6,"context_line":"    enabled: \"{{ enable_haproxy | default(true) | bool }}\""},{"line_number":7,"context_line":"    image: \"{{ haproxy_image_full }}\""},{"line_number":8,"context_line":"    privileged: true"},{"line_number":9,"context_line":"    volumes: \"{{ haproxy_default_volumes + haproxy_extra_volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7636d9c1_b6554880","line":6,"in_reply_to":"c919f435_18016cad","updated":"2026-08-04 18:28:42.000000000","message":"Acknowledged","commit_id":"7dd62f85c031b20e0e945d43b2c8ab00dcea5b63"}]}