)]}'
{"kolla_cli/common/ansible/playbook.py":[{"author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"change_message_id":"7043aa64abe2973f8ed341c0a84f4e6df1a82f31","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        except Exception:"},{"line_number":58,"context_line":"            raise Exception(traceback.format_exc())"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _check_for_plugin(self):"},{"line_number":61,"context_line":"        \"\"\"check that plug-in is properly installed\"\"\""},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        pi_dir \u003d get_ansible_plugin_dir()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f6a8fd7_b4e63016","line":60,"updated":"2018-04-17 15:25:40.000000000","message":"Can this be removed since the callback is now gone?","commit_id":"46e9ebdf26ed46c76527108b9861b8f5579dea62"},{"author":{"_account_id":16520,"name":"Borne Mace","email":"borne.mace@oracle.com","username":"bmace"},"change_message_id":"7548b722a638d6d74c53431d6ddaa1f52863d00c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        except Exception:"},{"line_number":58,"context_line":"            raise Exception(traceback.format_exc())"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _check_for_plugin(self):"},{"line_number":61,"context_line":"        \"\"\"check that plug-in is properly installed\"\"\""},{"line_number":62,"context_line":"        \"\"\""},{"line_number":63,"context_line":"        pi_dir \u003d get_ansible_plugin_dir()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f6a8fd7_31d22d5e","line":60,"in_reply_to":"9f6a8fd7_b4e63016","updated":"2018-04-17 16:49:34.000000000","message":"Done","commit_id":"46e9ebdf26ed46c76527108b9861b8f5579dea62"}],"kolla_cli/common/sshutils.py":[{"author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"change_message_id":"45c48948fcb3c78e1028c05a2d86446601ed3736","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        # TODO(bmace) pre / post checks should be done with ansible"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # populate authorized keys file w/ public key"},{"line_number":57,"context_line":"        key_dir \u003d os.path.join(os.path.expanduser(\u0027~\u0027),"},{"line_number":58,"context_line":"                               \u0027.ssh\u0027, \u0027authorized_keys\u0027)"},{"line_number":59,"context_line":"        cmd \u003d (\u0027echo \\\u0027%s\\\u0027 \u003e\u003e %s\u0027"},{"line_number":60,"context_line":"               % (public_key, key_dir))"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_ac49e960","line":57,"updated":"2018-04-09 14:45:23.000000000","message":"I\u0027m not sure I understand how you intend this to be run (what user account).  By default it looks like get_admin_user() still returns kolla, but with this change you\u0027re editing the setup_user\u0027s authorized_keys file, not the admin_user.  get_setup_user defaults to root which would require root ssh login to the other host. Default ssh config (and best security practices) generally disallows root ssh login.","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"},{"author":{"_account_id":16520,"name":"Borne Mace","email":"borne.mace@oracle.com","username":"bmace"},"change_message_id":"52748ba978350f3eb9cf2b032cb2ff7e66deea43","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        # TODO(bmace) pre / post checks should be done with ansible"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # populate authorized keys file w/ public key"},{"line_number":57,"context_line":"        key_dir \u003d os.path.join(os.path.expanduser(\u0027~\u0027),"},{"line_number":58,"context_line":"                               \u0027.ssh\u0027, \u0027authorized_keys\u0027)"},{"line_number":59,"context_line":"        cmd \u003d (\u0027echo \\\u0027%s\\\u0027 \u003e\u003e %s\u0027"},{"line_number":60,"context_line":"               % (public_key, key_dir))"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_9fd51be8","line":57,"in_reply_to":"bf659307_ac49e960","updated":"2018-04-10 21:55:15.000000000","message":"with this change both the default admin and setup user will be root.  until we add some code to automatically create some other users / groups on all supported platforms it will be up to end users to create different groups / users if they don\u0027t want to run as root, and once they do they can just change the environment variable.  we can also consider changing this from an environment variable to something we actually store in the inventory.","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"},{"author":{"_account_id":16520,"name":"Borne Mace","email":"borne.mace@oracle.com","username":"bmace"},"change_message_id":"52748ba978350f3eb9cf2b032cb2ff7e66deea43","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # populate authorized keys file w/ public key"},{"line_number":57,"context_line":"        key_dir \u003d os.path.join(os.path.expanduser(\u0027~\u0027),"},{"line_number":58,"context_line":"                               \u0027.ssh\u0027, \u0027authorized_keys\u0027)"},{"line_number":59,"context_line":"        cmd \u003d (\u0027echo \\\u0027%s\\\u0027 \u003e\u003e %s\u0027"},{"line_number":60,"context_line":"               % (public_key, key_dir))"},{"line_number":61,"context_line":"        _exec_ssh_cmd(cmd, ssh_client)"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_6202ee0b","line":59,"updated":"2018-04-10 21:55:15.000000000","message":"i\u0027m actually going to revert this change, because without it after we will need to chown the auth keys file.  as we are doing this as root, doing a remote sudo without a password should be fine.  if this is to work as a non-root user that would also be required.\n\nall of this could be done differently if someone wants to clean it up.","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"},{"author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"change_message_id":"c411f27186ed35b99f76ae3ace375673fd6ea8a4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # populate authorized keys file w/ public key"},{"line_number":57,"context_line":"        key_dir \u003d os.path.join(os.path.expanduser(\u0027~\u0027),"},{"line_number":58,"context_line":"                               \u0027.ssh\u0027, \u0027authorized_keys\u0027)"},{"line_number":59,"context_line":"        cmd \u003d (\u0027echo \\\u0027%s\\\u0027 \u003e\u003e %s\u0027"},{"line_number":60,"context_line":"               % (public_key, key_dir))"},{"line_number":61,"context_line":"        _exec_ssh_cmd(cmd, ssh_client)"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_8d9a9511","line":59,"in_reply_to":"bf659307_07718476","updated":"2018-04-11 23:17:11.000000000","message":"Ok.  That makes sense.  I still think there might be some room for simplification here, but we can address that in a separate ps.  thanks for the explanation.","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"},{"author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"change_message_id":"bd54f9d52564e40c0b8008e37aa4e05943cf2d58","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # populate authorized keys file w/ public key"},{"line_number":57,"context_line":"        key_dir \u003d os.path.join(os.path.expanduser(\u0027~\u0027),"},{"line_number":58,"context_line":"                               \u0027.ssh\u0027, \u0027authorized_keys\u0027)"},{"line_number":59,"context_line":"        cmd \u003d (\u0027echo \\\u0027%s\\\u0027 \u003e\u003e %s\u0027"},{"line_number":60,"context_line":"               % (public_key, key_dir))"},{"line_number":61,"context_line":"        _exec_ssh_cmd(cmd, ssh_client)"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_c0cdc485","line":59,"in_reply_to":"bf659307_6202ee0b","updated":"2018-04-11 12:21:18.000000000","message":"I don\u0027t understand your reasoning here.  You are creating the file as a given user in the user\u0027s home directory.  There should be no need for a chown, as long as you don\u0027t use sudo.  If you do use sudo then it\u0027ll be owned by root and that would cause problems without a chown.  In short, I think removing the sudo was the correct thing to do.","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"},{"author":{"_account_id":16520,"name":"Borne Mace","email":"borne.mace@oracle.com","username":"bmace"},"change_message_id":"8d85defd8700f64238299f16e1f813b85deaaa6c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # populate authorized keys file w/ public key"},{"line_number":57,"context_line":"        key_dir \u003d os.path.join(os.path.expanduser(\u0027~\u0027),"},{"line_number":58,"context_line":"                               \u0027.ssh\u0027, \u0027authorized_keys\u0027)"},{"line_number":59,"context_line":"        cmd \u003d (\u0027echo \\\u0027%s\\\u0027 \u003e\u003e %s\u0027"},{"line_number":60,"context_line":"               % (public_key, key_dir))"},{"line_number":61,"context_line":"        _exec_ssh_cmd(cmd, ssh_client)"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_07718476","line":59,"in_reply_to":"bf659307_c0cdc485","updated":"2018-04-11 20:57:22.000000000","message":"you ssh in as the setup_user, not the admin_user.  this is why if you look at the latest code we sudo to the admin_user before doing the echo, like the old code did.  if you don\u0027t do that, the file will be created and owned by the setup_user, which is by default root.","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"}],"kolla_cli/common/utils.py":[{"author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"change_message_id":"45c48948fcb3c78e1028c05a2d86446601ed3736","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def get_kolla_home():"},{"line_number":54,"context_line":"    return os.environ.get(\"KOLLA_HOME\", \"/usr/share/kolla-ansible/\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def get_kolla_etc():"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_a66268d7","line":54,"updated":"2018-04-09 14:45:23.000000000","message":"The naming of this function is a bit misleading.  Should perhaps be get_kolla_ansible_home()","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"},{"author":{"_account_id":16520,"name":"Borne Mace","email":"borne.mace@oracle.com","username":"bmace"},"change_message_id":"52748ba978350f3eb9cf2b032cb2ff7e66deea43","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def get_kolla_home():"},{"line_number":54,"context_line":"    return os.environ.get(\"KOLLA_HOME\", \"/usr/share/kolla-ansible/\")"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def get_kolla_etc():"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_3f796ffb","line":54,"in_reply_to":"bf659307_a66268d7","updated":"2018-04-10 21:55:15.000000000","message":"Done","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"},{"author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"change_message_id":"45c48948fcb3c78e1028c05a2d86446601ed3736","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    return os.environ.get(\"KOLLA_ETC\", \"/etc/kolla/\")"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def get_kollacli_home():"},{"line_number":62,"context_line":"    return os.environ.get(\"KOLLA_CLI_HOME\", \"/usr/share/kolla-ansible/kolla-cli/\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_26f2d807","line":61,"updated":"2018-04-09 14:45:23.000000000","message":"For consistency, should this be get_kolla_cli_home()","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"},{"author":{"_account_id":16520,"name":"Borne Mace","email":"borne.mace@oracle.com","username":"bmace"},"change_message_id":"52748ba978350f3eb9cf2b032cb2ff7e66deea43","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    return os.environ.get(\"KOLLA_ETC\", \"/etc/kolla/\")"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def get_kollacli_home():"},{"line_number":62,"context_line":"    return os.environ.get(\"KOLLA_CLI_HOME\", \"/usr/share/kolla-ansible/kolla-cli/\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_3f62cf3f","line":61,"in_reply_to":"bf659307_26f2d807","updated":"2018-04-10 21:55:15.000000000","message":"Done","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"},{"author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"change_message_id":"45c48948fcb3c78e1028c05a2d86446601ed3736","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def get_kollacli_home():"},{"line_number":62,"context_line":"    return os.environ.get(\"KOLLA_CLI_HOME\", \"/usr/share/kolla-ansible/kolla-cli/\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def get_kollacli_etc():"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_e6c4e094","line":62,"updated":"2018-04-09 14:45:23.000000000","message":"Is the intent that this is installed under kolla-ansible directory or should it be installed in /usr/share/kolla-cli ?","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"},{"author":{"_account_id":16520,"name":"Borne Mace","email":"borne.mace@oracle.com","username":"bmace"},"change_message_id":"52748ba978350f3eb9cf2b032cb2ff7e66deea43","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"def get_kollacli_home():"},{"line_number":62,"context_line":"    return os.environ.get(\"KOLLA_CLI_HOME\", \"/usr/share/kolla-ansible/kolla-cli/\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def get_kollacli_etc():"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_7f4fe7bc","line":62,"in_reply_to":"bf659307_e6c4e094","updated":"2018-04-10 21:55:15.000000000","message":"the cli functioning properly is always dependent on kolla-ansible being available, so i think this is fine.  if people end up wanting it moved out that is fine, but as the cli, at this point, can\u0027t run without this dependency being met i feel it is reasonable.","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"},{"author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"change_message_id":"45c48948fcb3c78e1028c05a2d86446601ed3736","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    return os.environ.get(\"KOLLA_CLI_HOME\", \"/usr/share/kolla-ansible/kolla-cli/\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def get_kollacli_etc():"},{"line_number":66,"context_line":"    return os.environ.get(\"KOLLA_CLI_ETC\", \"/etc/kolla/kolla-cli/\")"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_06c0f47b","line":65,"updated":"2018-04-09 14:45:23.000000000","message":"s/kollacli/kolla_cli/","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"},{"author":{"_account_id":16520,"name":"Borne Mace","email":"borne.mace@oracle.com","username":"bmace"},"change_message_id":"52748ba978350f3eb9cf2b032cb2ff7e66deea43","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    return os.environ.get(\"KOLLA_CLI_HOME\", \"/usr/share/kolla-ansible/kolla-cli/\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def get_kollacli_etc():"},{"line_number":66,"context_line":"    return os.environ.get(\"KOLLA_CLI_ETC\", \"/etc/kolla/kolla-cli/\")"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_bfda5fe6","line":65,"in_reply_to":"bf659307_06c0f47b","updated":"2018-04-10 21:55:15.000000000","message":"nope, this is an installed / runtime directory, just like /usr/share/kolla-ansible.  the internal / project directory names are _ but it seems like the in file system / deployed kolla-ansible stuff sticks usually with dashes, which is why I have done similarly with the cli.\n\ngroup_vars / hosts_vars is an ansible specific naming convention, which is why i expect that _ is still seen here and there under /usr/share/kolla-ansible","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"},{"author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"change_message_id":"bd54f9d52564e40c0b8008e37aa4e05943cf2d58","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    return os.environ.get(\"KOLLA_CLI_HOME\", \"/usr/share/kolla-ansible/kolla-cli/\")"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def get_kollacli_etc():"},{"line_number":66,"context_line":"    return os.environ.get(\"KOLLA_CLI_ETC\", \"/etc/kolla/kolla-cli/\")"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_a07e9016","line":65,"in_reply_to":"bf659307_bfda5fe6","updated":"2018-04-11 12:21:18.000000000","message":"My comment was with regards to the function name, not the directory name.  Sorry for the confusion.  I agree with your reasoning to make the dir name use a hyphen.","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"},{"author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"change_message_id":"45c48948fcb3c78e1028c05a2d86446601ed3736","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def get_kolla_log_dir():"},{"line_number":78,"context_line":"    return \u0027/var/log/kolla-ansible/\u0027"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def get_ansible_lock_path():"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_c6675cb7","line":78,"updated":"2018-04-09 14:45:23.000000000","message":"I\u0027m not sure this is correct.  At least in my deployment, no such directory exists.","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"},{"author":{"_account_id":16520,"name":"Borne Mace","email":"borne.mace@oracle.com","username":"bmace"},"change_message_id":"52748ba978350f3eb9cf2b032cb2ff7e66deea43","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def get_kolla_log_dir():"},{"line_number":78,"context_line":"    return \u0027/var/log/kolla-ansible/\u0027"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def get_ansible_lock_path():"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_bf033f42","line":78,"in_reply_to":"bf659307_c6675cb7","updated":"2018-04-10 21:55:15.000000000","message":"i have seen the same thing, and i made the dir myself.  i don\u0027t know if there is some difference in some way that we log internally, or just some remnant of how logging used to work a long time ago.  i may just change this to kolla-cli for the time being as it seems those are the only logs that will be there.","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"}],"tests/common.py":[{"author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"change_message_id":"7043aa64abe2973f8ed341c0a84f4e6df1a82f31","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                return"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        self.assertEqual(0, 1,"},{"line_number":281,"context_line":"                         \u0027no kolla_cli shell command found. Aborting tests\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f6a8fd7_14b7dcd7","line":281,"range":{"start_line":281,"start_character":29,"end_line":281,"end_character":38},"updated":"2018-04-17 15:25:40.000000000","message":"nit: should probably be kolla-cli to be consistent with debug message above.","commit_id":"46e9ebdf26ed46c76527108b9861b8f5579dea62"},{"author":{"_account_id":16520,"name":"Borne Mace","email":"borne.mace@oracle.com","username":"bmace"},"change_message_id":"7548b722a638d6d74c53431d6ddaa1f52863d00c","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                return"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        self.assertEqual(0, 1,"},{"line_number":281,"context_line":"                         \u0027no kolla_cli shell command found. Aborting tests\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f6a8fd7_d1d97183","line":281,"range":{"start_line":281,"start_character":29,"end_line":281,"end_character":38},"in_reply_to":"9f6a8fd7_14b7dcd7","updated":"2018-04-17 16:49:34.000000000","message":"Done","commit_id":"46e9ebdf26ed46c76527108b9861b8f5579dea62"}],"tests/support.py":[{"author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"change_message_id":"45c48948fcb3c78e1028c05a2d86446601ed3736","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_dump(self):"},{"line_number":80,"context_line":"        check_files \u003d ["},{"line_number":81,"context_line":"            \u0027var/log/kolla/kolla.log\u0027,"},{"line_number":82,"context_line":"            \u0027kolla/etc/kolla-cli/ansible/inventory.json\u0027,"},{"line_number":83,"context_line":"            \u0027kolla/share/ansible/site.yml\u0027,"},{"line_number":84,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_0678f428","line":81,"updated":"2018-04-09 14:45:23.000000000","message":"in common/utils.py you specify the log dir as /var/log/kolla-ansible so I don\u0027t think var/log/kolla will exist here (as already mentioned I\u0027m not sure that log directory is correct in any case)","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"},{"author":{"_account_id":16520,"name":"Borne Mace","email":"borne.mace@oracle.com","username":"bmace"},"change_message_id":"52748ba978350f3eb9cf2b032cb2ff7e66deea43","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_dump(self):"},{"line_number":80,"context_line":"        check_files \u003d ["},{"line_number":81,"context_line":"            \u0027var/log/kolla/kolla.log\u0027,"},{"line_number":82,"context_line":"            \u0027kolla/etc/kolla-cli/ansible/inventory.json\u0027,"},{"line_number":83,"context_line":"            \u0027kolla/share/ansible/site.yml\u0027,"},{"line_number":84,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_ff3a17e5","line":81,"in_reply_to":"bf659307_0678f428","updated":"2018-04-10 21:55:15.000000000","message":"Done","commit_id":"0c08d3df2d2015b18192edf000943e6b314fd769"}]}