)]}'
{"kolla_cli/common/utils.py":[{"author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"change_message_id":"e362ea977282bbd957f2d1544ee1ba118e2d5584","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    If key is not found, an error is returned."},{"line_number":174,"context_line":"    If clear, and password exists, remove password."},{"line_number":175,"context_line":"    If clear, and password doesn\u0027t exists, nothing is done."},{"line_number":176,"context_line":"    If not clear, and key is not found, an error is returned."},{"line_number":177,"context_line":"    If not clear, and key is found, edit password in place."},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_fd9bd2c5","line":175,"range":{"start_line":175,"start_character":40,"end_line":175,"end_character":41},"updated":"2018-05-25 16:50:06.000000000","message":"nit: s/exists/exist/","commit_id":"31bd25e8e7abb9c02a23524f0ad3d4bc164b14f6"},{"author":{"_account_id":16520,"name":"Borne Mace","email":"borne.mace@oracle.com","username":"bmace"},"change_message_id":"78badde05723dbb3b22aad99a6d4fb14a4b92f51","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    If key is not found, an error is returned."},{"line_number":174,"context_line":"    If clear, and password exists, remove password."},{"line_number":175,"context_line":"    If clear, and password doesn\u0027t exists, nothing is done."},{"line_number":176,"context_line":"    If not clear, and key is not found, an error is returned."},{"line_number":177,"context_line":"    If not clear, and key is found, edit password in place."},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_f87680a4","line":175,"range":{"start_line":175,"start_character":40,"end_line":175,"end_character":41},"in_reply_to":"5f7c97a3_fd9bd2c5","updated":"2018-05-25 18:01:52.000000000","message":"this was a pre-existing issue, but i\u0027ll fix it :)","commit_id":"31bd25e8e7abb9c02a23524f0ad3d4bc164b14f6"},{"author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"change_message_id":"e362ea977282bbd957f2d1544ee1ba118e2d5584","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    if pname not in file_pwds.keys():"},{"line_number":190,"context_line":"        raise Exception("},{"line_number":191,"context_line":"            u._(\u0027unable to clear password as it does not exist: {pname}\u0027)"},{"line_number":192,"context_line":"            .format(pname\u003dpname))"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    ssh_password_type \u003d is_ssh_password(file_pwds[pname])"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_5d5d2613","line":191,"updated":"2018-05-25 16:50:06.000000000","message":"This error message is misleading since the user may be attempting to set the password, not clear it.  Also, the behavior seems to contradict the function description which says that if the key is not found, an error is only returned if not clearing.","commit_id":"31bd25e8e7abb9c02a23524f0ad3d4bc164b14f6"},{"author":{"_account_id":16520,"name":"Borne Mace","email":"borne.mace@oracle.com","username":"bmace"},"change_message_id":"78badde05723dbb3b22aad99a6d4fb14a4b92f51","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    if pname not in file_pwds.keys():"},{"line_number":190,"context_line":"        raise Exception("},{"line_number":191,"context_line":"            u._(\u0027unable to clear password as it does not exist: {pname}\u0027)"},{"line_number":192,"context_line":"            .format(pname\u003dpname))"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    ssh_password_type \u003d is_ssh_password(file_pwds[pname])"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_983e6cb6","line":191,"in_reply_to":"5f7c97a3_5d5d2613","updated":"2018-05-25 18:01:52.000000000","message":"changing the message a little so say \"clear or change\", and tweaking the method description a little, but i don\u0027t believe if conflicts with the current nomenclature.  it says if the key is not found, an error is returned, period.  if doing a clear and there is no current password, that is when nothing is done.  i am yanking out the line about if not clear and key is not found, since that is redundant, as we already state that if the key is not found, no matter if clear or not clear mode, an error is returned.","commit_id":"31bd25e8e7abb9c02a23524f0ad3d4bc164b14f6"},{"author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"change_message_id":"e362ea977282bbd957f2d1544ee1ba118e2d5584","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        # clear"},{"line_number":198,"context_line":"        if pname in file_pwds:"},{"line_number":199,"context_line":"            if ssh_password_type:"},{"line_number":200,"context_line":"                file_pwds[pname] \u003d {\u0027private_key\u0027: None,"},{"line_number":201,"context_line":"                                    \u0027public_key\u0027: None}"},{"line_number":202,"context_line":"            else:"},{"line_number":203,"context_line":"                file_pwds[pname] \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_1d66cec2","line":200,"range":{"start_line":200,"start_character":36,"end_line":200,"end_character":49},"updated":"2018-05-25 16:50:06.000000000","message":"These key names seem to be repeated several places.  You might consider defining these in a variable to avoid potential future errors due to typos.","commit_id":"31bd25e8e7abb9c02a23524f0ad3d4bc164b14f6"},{"author":{"_account_id":16520,"name":"Borne Mace","email":"borne.mace@oracle.com","username":"bmace"},"change_message_id":"78badde05723dbb3b22aad99a6d4fb14a4b92f51","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        # clear"},{"line_number":198,"context_line":"        if pname in file_pwds:"},{"line_number":199,"context_line":"            if ssh_password_type:"},{"line_number":200,"context_line":"                file_pwds[pname] \u003d {\u0027private_key\u0027: None,"},{"line_number":201,"context_line":"                                    \u0027public_key\u0027: None}"},{"line_number":202,"context_line":"            else:"},{"line_number":203,"context_line":"                file_pwds[pname] \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_386078cf","line":200,"range":{"start_line":200,"start_character":36,"end_line":200,"end_character":49},"in_reply_to":"5f7c97a3_1d66cec2","updated":"2018-05-25 18:01:52.000000000","message":"sure, this is used in a bunch of places so i\u0027ll do that.","commit_id":"31bd25e8e7abb9c02a23524f0ad3d4bc164b14f6"},{"author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"change_message_id":"e362ea977282bbd957f2d1544ee1ba118e2d5584","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    # it looks when we read it.  also, this will not work with safe_dump"},{"line_number":222,"context_line":"    yaml.add_representer(type(None), _empty_is_none)"},{"line_number":223,"context_line":"    write_data \u003d yaml.dump(file_pwds, default_flow_style\u003dFalse)"},{"line_number":224,"context_line":"    sync_write_file(file_path, write_data)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"def clear_all_passwords():"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_9dc3be89","line":224,"updated":"2018-05-25 16:50:06.000000000","message":"You might consider pulling this block of code out to a function rather than repeat it both here and in clear_all_passwords.","commit_id":"31bd25e8e7abb9c02a23524f0ad3d4bc164b14f6"},{"author":{"_account_id":16520,"name":"Borne Mace","email":"borne.mace@oracle.com","username":"bmace"},"change_message_id":"78badde05723dbb3b22aad99a6d4fb14a4b92f51","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    # it looks when we read it.  also, this will not work with safe_dump"},{"line_number":222,"context_line":"    yaml.add_representer(type(None), _empty_is_none)"},{"line_number":223,"context_line":"    write_data \u003d yaml.dump(file_pwds, default_flow_style\u003dFalse)"},{"line_number":224,"context_line":"    sync_write_file(file_path, write_data)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"def clear_all_passwords():"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_786a70b3","line":224,"in_reply_to":"5f7c97a3_9dc3be89","updated":"2018-05-25 18:01:52.000000000","message":"it is minimal enough code and only used in two places so I am a little dubious of the real value of breaking it out at this point.","commit_id":"31bd25e8e7abb9c02a23524f0ad3d4bc164b14f6"}]}