)]}'
{"kolla_cli/common/ansible_inventory.py":[{"author":{"_account_id":16520,"name":"Borne Mace","email":"borne.mace@oracle.com","username":"bmace"},"change_message_id":"0e3dd4e1a2b36364b30ae3e5e06b5fb65431d51b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            if not line.startswith(\u0027[\u0027):"},{"line_number":69,"context_line":"                continue"},{"line_number":70,"context_line":"            line.strip()"},{"line_number":71,"context_line":"            if \u0027:vars\u0027 in line:"},{"line_number":72,"context_line":"                # this is defining a set of group vars in the next set"},{"line_number":73,"context_line":"                # of lines."},{"line_number":74,"context_line":"                groupname \u003d line.split(\u0027:\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9b61afd6","line":71,"updated":"2018-06-19 23:51:37.000000000","message":"we can definitely just do this as a skip, but if we are doing this, how hard would it be just to add these group properties while we are in this process?","commit_id":"c6632efa75a6dfd0d7101d303de3f814f53bec29"},{"author":{"_account_id":17386,"name":"Steve Noyes","email":"steve.noyes@oracle.com","username":"ssn1ssn"},"change_message_id":"47245763a6beb24dfdd0a3174526890e2ae6da85","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            if not line.startswith(\u0027[\u0027):"},{"line_number":69,"context_line":"                continue"},{"line_number":70,"context_line":"            line.strip()"},{"line_number":71,"context_line":"            if \u0027:vars\u0027 in line:"},{"line_number":72,"context_line":"                # this is defining a set of group vars in the next set"},{"line_number":73,"context_line":"                # of lines."},{"line_number":74,"context_line":"                groupname \u003d line.split(\u0027:\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_9e6f4ff9","line":71,"in_reply_to":"5f7c97a3_9b61afd6","updated":"2018-06-20 13:23:46.000000000","message":"I started down that path but hit a recursive import issue. To set properties, you will need to import Properties, which imports Inventory. And currently Inventory is calling this. So you\u0027ll hit import loop errors.\n\nIt is all fixable, but requires more code restructuring than probably should be in this review. That can be done on a subsequent review when its decided to get the group (and host) variables. \n\nAlso, group vars can also be set inside groups via vars: (not :vars) so that case should also be handled when group vars are supported in inventory files.","commit_id":"c6632efa75a6dfd0d7101d303de3f814f53bec29"},{"author":{"_account_id":16520,"name":"Borne Mace","email":"borne.mace@oracle.com","username":"bmace"},"change_message_id":"cbff5f43515cac2a04c85ebfb446182fec49b032","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            if not line.startswith(\u0027[\u0027):"},{"line_number":69,"context_line":"                continue"},{"line_number":70,"context_line":"            line.strip()"},{"line_number":71,"context_line":"            if \u0027:vars\u0027 in line:"},{"line_number":72,"context_line":"                # this is defining a set of group vars in the next set"},{"line_number":73,"context_line":"                # of lines."},{"line_number":74,"context_line":"                groupname \u003d line.split(\u0027:\u0027)[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4eb82010","line":71,"in_reply_to":"5f7c97a3_9e6f4ff9","updated":"2018-06-20 16:14:18.000000000","message":"How about making the calls through the api rather than directly through the property library?","commit_id":"c6632efa75a6dfd0d7101d303de3f814f53bec29"}]}