)]}'
{"kolla_kubernetes/service.py":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"8230dd2a9a36895d9a874efed7152c033b2d4e4c","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    cmd \u003d [CONF.kolla_kubernetes.kubectl_path, server, \"create\", \"configmap\","},{"line_number":165,"context_line":"           \u0027%s-configmap\u0027 % service_name]"},{"line_number":166,"context_line":"    cmd \u003d cmd + [\u0027--from-file\u003d%s\u0027 % f"},{"line_number":167,"context_line":"                 for f in file_utils.get_service_config_files(service_name)]"},{"line_number":168,"context_line":"    LOG.info(\u0027Command : %r\u0027 % cmd)"},{"line_number":169,"context_line":"    subprocess.call(cmd)"},{"line_number":170,"context_line":"    cmd \u003d [CONF.kolla_kubernetes.kubectl_path, server, \"create\", \"-f\","}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_79dd60df","line":167,"range":{"start_line":166,"start_character":4,"end_line":167,"end_character":76},"updated":"2016-05-11 03:07:37.000000000","message":"Would it not be more efficient and flexible to specify a folder instead of individual names for config files? Same approach can be leveraged later for reconfiguration, since the number of config files may vary.","commit_id":"dc57c47b91c9bf0d24d37f9e8642728256d0ffc9"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"e4fb96efd8e93ea0ac2815b1fe5cbef18ae74900","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    cmd \u003d [CONF.kolla_kubernetes.kubectl_path, server, \"create\", \"configmap\","},{"line_number":165,"context_line":"           \u0027%s-configmap\u0027 % service_name]"},{"line_number":166,"context_line":"    cmd \u003d cmd + [\u0027--from-file\u003d%s\u0027 % f"},{"line_number":167,"context_line":"                 for f in file_utils.get_service_config_files(service_name)]"},{"line_number":168,"context_line":"    LOG.info(\u0027Command : %r\u0027 % cmd)"},{"line_number":169,"context_line":"    subprocess.call(cmd)"},{"line_number":170,"context_line":"    cmd \u003d [CONF.kolla_kubernetes.kubectl_path, server, \"create\", \"-f\","}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_51714743","line":167,"range":{"start_line":166,"start_character":4,"end_line":167,"end_character":76},"in_reply_to":"dab17558_79dd60df","updated":"2016-05-11 10:27:47.000000000","message":"Thanks for the suggestion Serguei, i added some rationale for the choice in the commit message","commit_id":"dc57c47b91c9bf0d24d37f9e8642728256d0ffc9"}]}