)]}'
{"helm/all_values.yaml":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"2599969390b095025b7ac0d8a7810f0da8f9356c","unresolved":false,"context_lines":[{"line_number":571,"context_line":"                        port_external: false"},{"line_number":572,"context_line":"                        node_port_enabled: false"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"horizon-frontend-configmap:"},{"line_number":575,"context_line":"        global:"},{"line_number":576,"context_line":"            kolla:"},{"line_number":577,"context_line":"                horizon:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3a461143_852398a6","line":574,"range":{"start_line":574,"start_character":0,"end_line":574,"end_character":13},"updated":"2017-01-27 22:57:42.000000000","message":"hopefully a user will not need to look here as it looks kind of scary. hopefully intro of the script will hide all this.","commit_id":"e57ad3d78a81d134bfa3fafe2672d6e698954514"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a3881bab4efaf989644721177800847213bbcc8b","unresolved":false,"context_lines":[{"line_number":571,"context_line":"                        port_external: false"},{"line_number":572,"context_line":"                        node_port_enabled: false"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"horizon-frontend-configmap:"},{"line_number":575,"context_line":"        global:"},{"line_number":576,"context_line":"            kolla:"},{"line_number":577,"context_line":"                horizon:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3a461143_abdf8567","line":574,"range":{"start_line":574,"start_character":0,"end_line":574,"end_character":13},"in_reply_to":"3a461143_852398a6","updated":"2017-01-28 00:24:51.000000000","message":"yeah, a shell script could hide the whole procedure.","commit_id":"e57ad3d78a81d134bfa3fafe2672d6e698954514"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"2599969390b095025b7ac0d8a7810f0da8f9356c","unresolved":false,"context_lines":[{"line_number":577,"context_line":"                horizon:"},{"line_number":578,"context_line":"                    all:"},{"line_number":579,"context_line":"                        port: 80"},{"line_number":580,"context_line":"                        version: \"1\""},{"line_number":581,"context_line":"                        default_version: \"1\""},{"line_number":582,"context_line":"                        versions:"},{"line_number":583,"context_line":"                        - \"1\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3a461143_4506101e","line":580,"range":{"start_line":580,"start_character":31,"end_line":580,"end_character":36},"updated":"2017-01-27 22:57:42.000000000","message":"versions here do they have any relation to the image version or it is configmap version? just to indicate reconfiguration?","commit_id":"e57ad3d78a81d134bfa3fafe2672d6e698954514"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a3881bab4efaf989644721177800847213bbcc8b","unresolved":false,"context_lines":[{"line_number":577,"context_line":"                horizon:"},{"line_number":578,"context_line":"                    all:"},{"line_number":579,"context_line":"                        port: 80"},{"line_number":580,"context_line":"                        version: \"1\""},{"line_number":581,"context_line":"                        default_version: \"1\""},{"line_number":582,"context_line":"                        versions:"},{"line_number":583,"context_line":"                        - \"1\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3a461143_6bf11d01","line":580,"range":{"start_line":580,"start_character":31,"end_line":580,"end_character":36},"in_reply_to":"3a461143_4506101e","updated":"2017-01-28 00:24:51.000000000","message":"This one is version of the configmap.\nMaybe should be renamed configmap_version?\n\nThe rest of the versions below refer to \u0027horizon_backend\u0027 instance versions.","commit_id":"e57ad3d78a81d134bfa3fafe2672d6e698954514"}],"helm/microservice/horizon-backend-deployment/templates/horizon-backend-deployment.yaml":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"2599969390b095025b7ac0d8a7810f0da8f9356c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"{{- $resourceName :\u003d \"horizon-backend\" }}"},{"line_number":14,"context_line":"{{- $netHostTrue :\u003d false }}"},{"line_number":15,"context_line":"{{- $podTypeBootstrap :\u003d false }}"},{"line_number":16,"context_line":"{{- $elementName :\u003d .Values.element_name | default $resourceName }}"},{"line_number":17,"context_line":"{{- with $env :\u003d dict \"netHostTrue\" $netHostTrue \"podTypeBootstrap\" $podTypeBootstrap \"resourceName\" $resourceName \"Values\" .Values \"Release\" .Release \"searchPath\" $searchPath }}"},{"line_number":18,"context_line":"apiVersion: extensions/v1beta1"},{"line_number":19,"context_line":"kind: Deployment"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3a461143_8512b807","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":19},"updated":"2017-01-27 22:57:42.000000000","message":"same comment, maybe safer to use search than .Values?","commit_id":"e57ad3d78a81d134bfa3fafe2672d6e698954514"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a3881bab4efaf989644721177800847213bbcc8b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"{{- $resourceName :\u003d \"horizon-backend\" }}"},{"line_number":14,"context_line":"{{- $netHostTrue :\u003d false }}"},{"line_number":15,"context_line":"{{- $podTypeBootstrap :\u003d false }}"},{"line_number":16,"context_line":"{{- $elementName :\u003d .Values.element_name | default $resourceName }}"},{"line_number":17,"context_line":"{{- with $env :\u003d dict \"netHostTrue\" $netHostTrue \"podTypeBootstrap\" $podTypeBootstrap \"resourceName\" $resourceName \"Values\" .Values \"Release\" .Release \"searchPath\" $searchPath }}"},{"line_number":18,"context_line":"apiVersion: extensions/v1beta1"},{"line_number":19,"context_line":"kind: Deployment"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3a461143_4bd7014b","line":16,"range":{"start_line":16,"start_character":4,"end_line":16,"end_character":19},"in_reply_to":"3a461143_8512b807","updated":"2017-01-28 00:24:51.000000000","message":"this was unchanged from before. in general elementNames on non mariadb/rabbitmq/memcached are kind of broken all around right now.","commit_id":"e57ad3d78a81d134bfa3fafe2672d6e698954514"}],"helm/microservice/horizon-backend-svc/templates/horizon-backend-svc.yaml":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"2599969390b095025b7ac0d8a7810f0da8f9356c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- $searchPath :\u003d \":global.kolla.horizon.backend.svc:global.kolla.horizon.backend.all:global.kolla.horizon.all:.global.kolla.all\" }}"},{"line_number":2,"context_line":"{{- $elementPort :\u003d include \"kolla_val_get_str\" (dict \"key\" \"port\" \"searchPath\" $searchPath \"Values\" .Values) }}"},{"line_number":3,"context_line":"{{- $version :\u003d include \"kolla_val_get_str\" (dict \"key\" \"version\" \"searchPath\" $searchPath \"Values\" .Values ) }}"},{"line_number":4,"context_line":"{{- $elementName :\u003d .Values.element_name | default (printf \"horizon-backend-%s\" $version) }}"},{"line_number":5,"context_line":"{{- $elementService :\u003d .Values.element_name | default \"horizon-backend\" }}"},{"line_number":6,"context_line":"{{- $elementServiceType :\u003d $version }}"},{"line_number":7,"context_line":"{{- with $env :\u003d dict \"element_port\" $elementPort \"element_name\" $elementName \"element_service\" $elementService \"element_service_type\" $elementServiceType \"Values\" .Values \"Release\" .Release \"searchPath\" $searchPath }}"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3a461143_6524ec5f","line":4,"updated":"2017-01-27 22:57:42.000000000","message":"same comment about search?","commit_id":"e57ad3d78a81d134bfa3fafe2672d6e698954514"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a3881bab4efaf989644721177800847213bbcc8b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- $searchPath :\u003d \":global.kolla.horizon.backend.svc:global.kolla.horizon.backend.all:global.kolla.horizon.all:.global.kolla.all\" }}"},{"line_number":2,"context_line":"{{- $elementPort :\u003d include \"kolla_val_get_str\" (dict \"key\" \"port\" \"searchPath\" $searchPath \"Values\" .Values) }}"},{"line_number":3,"context_line":"{{- $version :\u003d include \"kolla_val_get_str\" (dict \"key\" \"version\" \"searchPath\" $searchPath \"Values\" .Values ) }}"},{"line_number":4,"context_line":"{{- $elementName :\u003d .Values.element_name | default (printf \"horizon-backend-%s\" $version) }}"},{"line_number":5,"context_line":"{{- $elementService :\u003d .Values.element_name | default \"horizon-backend\" }}"},{"line_number":6,"context_line":"{{- $elementServiceType :\u003d $version }}"},{"line_number":7,"context_line":"{{- with $env :\u003d dict \"element_port\" $elementPort \"element_name\" $elementName \"element_service\" $elementService \"element_service_type\" $elementServiceType \"Values\" .Values \"Release\" .Release \"searchPath\" $searchPath }}"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3a461143_cbc3f187","line":4,"in_reply_to":"3a461143_6524ec5f","updated":"2017-01-28 00:24:51.000000000","message":"k","commit_id":"e57ad3d78a81d134bfa3fafe2672d6e698954514"}],"helm/microservice/horizon-frontend-configmap/templates/horizon-frontend-configmap.yaml":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"2599969390b095025b7ac0d8a7810f0da8f9356c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"metadata:"},{"line_number":11,"context_line":"  name: horizon-frontend-{{ $version }}"},{"line_number":12,"context_line":"data:"},{"line_number":13,"context_line":"  haproxy.cfg: |"},{"line_number":14,"context_line":"    global"},{"line_number":15,"context_line":"      chroot /var/lib/haproxy"},{"line_number":16,"context_line":"      user haproxy"},{"line_number":17,"context_line":"      group haproxy"},{"line_number":18,"context_line":"      daemon"},{"line_number":19,"context_line":"      log /var/lib/kolla/heka/log local0"},{"line_number":20,"context_line":"      maxconn 4000"},{"line_number":21,"context_line":"      #stats socket /var/lib/kolla/haproxy/haproxy.sock"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    defaults"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3a461143_65a30c01","line":20,"range":{"start_line":13,"start_character":1,"end_line":20,"end_character":18},"updated":"2017-01-27 22:57:42.000000000","message":"I thought we do not want keep configmaps in charts?? or you do not expect any changes here?","commit_id":"e57ad3d78a81d134bfa3fafe2672d6e698954514"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a3881bab4efaf989644721177800847213bbcc8b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"metadata:"},{"line_number":11,"context_line":"  name: horizon-frontend-{{ $version }}"},{"line_number":12,"context_line":"data:"},{"line_number":13,"context_line":"  haproxy.cfg: |"},{"line_number":14,"context_line":"    global"},{"line_number":15,"context_line":"      chroot /var/lib/haproxy"},{"line_number":16,"context_line":"      user haproxy"},{"line_number":17,"context_line":"      group haproxy"},{"line_number":18,"context_line":"      daemon"},{"line_number":19,"context_line":"      log /var/lib/kolla/heka/log local0"},{"line_number":20,"context_line":"      maxconn 4000"},{"line_number":21,"context_line":"      #stats socket /var/lib/kolla/haproxy/haproxy.sock"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    defaults"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3a461143_2b60f5a4","line":20,"range":{"start_line":13,"start_character":1,"end_line":20,"end_character":18},"in_reply_to":"3a461143_65a30c01","updated":"2017-01-28 00:24:51.000000000","message":"This one is pretty static and very particular to this use case.\n\nI think maybe this is the first of many things to be converted to a configmap package though. so kind of trailblazing/prototyping here.\n\nI\u0027m not philosophically against having packages that provide configmaps, but more so against mixing them with other k8s objects in the same package. If the user wants to generate their configmaps via a helm micro package, great. if they want to provide it themselves, thats great too.\n\nWhich raises another question. If we are going to start making some things configmap packages, should we put them in microservices, or should we make a helm/configmaps/ dir for them, or something else?","commit_id":"e57ad3d78a81d134bfa3fafe2672d6e698954514"}],"helm/microservice/horizon-frontend-deployment/templates/horizon-frontend-deployment.yaml":[{"author":{"_account_id":22525,"name":"Qin Wang (qwang)","email":"qin.wang@intel.com","username":"qwang"},"change_message_id":"601b7061c094ce8e493364bf2ba1891d9242efd6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    rollingUpdate:"},{"line_number":21,"context_line":"      maxSurge: 1"},{"line_number":22,"context_line":"      maxUnavailable: 1"},{"line_number":23,"context_line":"    type: RollingUpdate "},{"line_number":24,"context_line":"  template:"},{"line_number":25,"context_line":"    metadata:"},{"line_number":26,"context_line":"      labels:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"5a3905b3_9b0bbb7c","line":23,"updated":"2017-01-23 18:39:34.000000000","message":"ws","commit_id":"140feb533f0946013d8c52fce073d33f048b23fe"}],"helm/microservice/horizon-frontend-svc/templates/horizon-frontend-svc.yaml":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"2599969390b095025b7ac0d8a7810f0da8f9356c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- $searchPath :\u003d \":global.kolla.horizon.frontend.svc:global.kolla.horizon.frontend.all:global.kolla.horizon.all:global.kolla.all\" }}"},{"line_number":2,"context_line":"{{- $elementPort :\u003d include \"kolla_val_get_str\" (dict \"key\" \"port\" \"searchPath\" $searchPath \"Values\" .Values) }}"},{"line_number":3,"context_line":"{{- $elementName :\u003d .Values.element_name | default \"horizon-frontend\" }}"},{"line_number":4,"context_line":"{{- $elementService :\u003d .Values.element_name | default \"horizon-frontend\" }}"},{"line_number":5,"context_line":"{{- with $env :\u003d dict \"element_port\" $elementPort \"element_name\" $elementName \"element_service\" $elementService \"Values\" .Values \"Release\" .Release \"searchPath\" $searchPath }}"},{"line_number":6,"context_line":"{{- include \"common_svc\" $env }}"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3a461143_8544781b","line":3,"range":{"start_line":3,"start_character":20,"end_line":3,"end_character":40},"updated":"2017-01-27 22:57:42.000000000","message":"Using this will be a problem for service level, maybe search for element_value?","commit_id":"e57ad3d78a81d134bfa3fafe2672d6e698954514"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a3881bab4efaf989644721177800847213bbcc8b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- $searchPath :\u003d \":global.kolla.horizon.frontend.svc:global.kolla.horizon.frontend.all:global.kolla.horizon.all:global.kolla.all\" }}"},{"line_number":2,"context_line":"{{- $elementPort :\u003d include \"kolla_val_get_str\" (dict \"key\" \"port\" \"searchPath\" $searchPath \"Values\" .Values) }}"},{"line_number":3,"context_line":"{{- $elementName :\u003d .Values.element_name | default \"horizon-frontend\" }}"},{"line_number":4,"context_line":"{{- $elementService :\u003d .Values.element_name | default \"horizon-frontend\" }}"},{"line_number":5,"context_line":"{{- with $env :\u003d dict \"element_port\" $elementPort \"element_name\" $elementName \"element_service\" $elementService \"Values\" .Values \"Release\" .Release \"searchPath\" $searchPath }}"},{"line_number":6,"context_line":"{{- include \"common_svc\" $env }}"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3a461143_0bc4195d","line":3,"range":{"start_line":3,"start_character":20,"end_line":3,"end_character":40},"in_reply_to":"3a461143_8544781b","updated":"2017-01-28 00:24:51.000000000","message":"The \"element\" use case for things with both a name and a type really has not been fleshed out. we only have elements working with mariadb/memcached/rabbitmq, none of which have types. So, my vote would be to strip this out/hard code it until we come up with a pattern for element\u0027s with the two levels of naming. This was just copied from horizon-svc when it was forked to frontend/backend. The feature never really worked though.","commit_id":"e57ad3d78a81d134bfa3fafe2672d6e698954514"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"2599969390b095025b7ac0d8a7810f0da8f9356c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- $searchPath :\u003d \":global.kolla.horizon.frontend.svc:global.kolla.horizon.frontend.all:global.kolla.horizon.all:global.kolla.all\" }}"},{"line_number":2,"context_line":"{{- $elementPort :\u003d include \"kolla_val_get_str\" (dict \"key\" \"port\" \"searchPath\" $searchPath \"Values\" .Values) }}"},{"line_number":3,"context_line":"{{- $elementName :\u003d .Values.element_name | default \"horizon-frontend\" }}"},{"line_number":4,"context_line":"{{- $elementService :\u003d .Values.element_name | default \"horizon-frontend\" }}"},{"line_number":5,"context_line":"{{- with $env :\u003d dict \"element_port\" $elementPort \"element_name\" $elementName \"element_service\" $elementService \"Values\" .Values \"Release\" .Release \"searchPath\" $searchPath }}"},{"line_number":6,"context_line":"{{- include \"common_svc\" $env }}"},{"line_number":7,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3a461143_c54a0026","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":20},"updated":"2017-01-27 22:57:42.000000000","message":"ditto","commit_id":"e57ad3d78a81d134bfa3fafe2672d6e698954514"}],"tests/bin/ceph_workflow_service.sh":[{"author":{"_account_id":22525,"name":"Qin Wang (qwang)","email":"qin.wang@intel.com","username":"qwang"},"change_message_id":"601b7061c094ce8e493364bf2ba1891d9242efd6","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    --values \u003c(helm_entrypoint_general $1)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"helm install kolla/horizon-frontend --version $VERSION \\"},{"line_number":279,"context_line":"    --namespace kolla --name horizon-backend \\"},{"line_number":280,"context_line":"    --set \"$common_vars\" \\"},{"line_number":281,"context_line":"    --values \u003c(helm_entrypoint_general $1)"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-sh","patch_set":24,"id":"5a3905b3_4fbfc9a9","line":279,"range":{"start_line":279,"start_character":29,"end_line":279,"end_character":44},"updated":"2017-01-23 18:39:34.000000000","message":"horizon-frontend","commit_id":"140feb533f0946013d8c52fce073d33f048b23fe"}]}