)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":22143,"name":"David Wang","email":"dcwangmit01@gmail.com","username":"dcwangmit01"},"change_message_id":"cbb15d5862747dabc7c6cc264c50f153d50f36d9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"enable_kubernetes: yes"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"kubernetes_endpoint: \"127.0.0.1:8080\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_5e3aa8e8","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":37},"updated":"2016-06-27 19:29:40.000000000","message":"Hey Ryan,\n\nI\u0027ve seen this pattern of specifying the kubernetes-endpoint within the kolla-kubernetes CLI tool as well.  I\u0027m of the opinion that it is unnecessary, and adds confusion.  I was actually thinking about removing it from the CLI tool.\n\nReason is any of our automation, whether these ansible scripts or the CLI tool, should probably best use the currently set context that kubectl  is already configured to use.  You can check this with \"kubectl config current-context\" and \"kubectl cluster-info\".\n\nThe CLI tool ends up system-calling kubectl on the command line anyway.\n\nAlright, let me know what you think, or if I\u0027m missing the point.\n\nThanks!\n-dave","commit_id":"bf4390dd7bd62e808b876f2227078c0a421405a0"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"4d9d51e5b4615c5d8eef1f5ae5077e0f0a0d5666","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"enable_kubernetes: yes"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"kubernetes_endpoint: \"127.0.0.1:8080\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_99019507","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":37},"in_reply_to":"3aaa91ec_5e3aa8e8","updated":"2016-06-28 15:57:25.000000000","message":"This variable is configurable by the user. So the user can do `kubectl cluster-info` and write it in here.  \n\nThis is the default as we can expect that the deployment will be done from the node with the kube master on it.\n\nGood documentation should address this.","commit_id":"bf4390dd7bd62e808b876f2227078c0a421405a0"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"99ddf180258e971ae5632626a0cb844d4339faea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"enable_kubernetes: yes"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"kubernetes_endpoint: \"127.0.0.1:8080\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_009b1a67","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":37},"in_reply_to":"3aaa91ec_95c2b1e7","updated":"2016-06-29 21:54:12.000000000","message":"I think this parameter needs to be moved to an equivalent of kolla\u0027s globals.yml and there should not be a value by default. I think user must specify it before deploying kolla-kubernetes.","commit_id":"bf4390dd7bd62e808b876f2227078c0a421405a0"},{"author":{"_account_id":21996,"name":"Ken Wronkiewicz","email":"wh-openstack@wirewd.com","username":"bowtie"},"change_message_id":"0e6fc2cd8c65a0b4e9320c8a7e865d9cf35dc185","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"enable_kubernetes: yes"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"kubernetes_endpoint: \"127.0.0.1:8080\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_95c2b1e7","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":37},"in_reply_to":"3aaa91ec_99019507","updated":"2016-06-29 18:58:46.000000000","message":"I\u0027ve been hacking on Kolla-Kubernetes for about a month now, looking at my patch history, and on Kubernetes since last year and I got bitten yesterday by this exact thing despite my knowledge.  I had kubectl looking at one cluster and kolla-kubernetes looking at the other and it confused the heck out of me, so I can only imagine how our first set of new users are going to feel when they encounter this issue.\n\nWe really need to set the cluster once and only once.","commit_id":"bf4390dd7bd62e808b876f2227078c0a421405a0"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"9ea295bdaab75e01cd5257072224928074ee1cee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"enable_kubernetes: yes"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"kubernetes_endpoint: \"127.0.0.1:8080\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3aaa91ec_144fbc34","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":37},"updated":"2016-06-30 12:59:51.000000000","message":"kube api server can be accessed insecurely to port 8080 and securely to port 6443. I suggest to remove 8080 from kubernetes_endpoint and add a new variable kubernetes_endpoint_secure: yes/no. Based on its value then build the access URL to port 8080 if \"no\" or to port 6443 if \"yes\".","commit_id":"33c743caff00c136d0d30d742ac6ff95b950072e"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"f0e1332dc6272ddf0edb89dda2755f4ace2af3dc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"enable_kubernetes: yes"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"kubernetes_endpoint: \"127.0.0.1:8080\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3aaa91ec_5ef14100","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":37},"in_reply_to":"3aaa91ec_144fbc34","updated":"2016-07-01 01:03:18.000000000","message":"There is a skydns review here: https://review.openstack.org/#/c/335677/. I think the plan is to depend on skydns? If so, the service should show up with a dns name, and shouldn\u0027t need to be hardcoded here.","commit_id":"33c743caff00c136d0d30d742ac6ff95b950072e"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"8f58fbd22a5f11428adf9d1c954494ade355c166","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"enable_kubernetes: yes"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"kubernetes_endpoint: \"127.0.0.1:8080\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3aaa91ec_a1b12849","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":37},"in_reply_to":"3aaa91ec_5ef14100","updated":"2016-07-01 01:43:38.000000000","message":"kubernetes_endpoints here is used to create kubernetes objects, skydns will provide dns services only to openstack services to discover each other.","commit_id":"33c743caff00c136d0d30d742ac6ff95b950072e"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"8349169ecf84d27707dc40e412aca651fddc36e7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"enable_kubernetes: yes"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"kubernetes_endpoint: \"127.0.0.1:8080\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1aa78d24_ca5a19f2","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":37},"in_reply_to":"3aaa91ec_a1b12849","updated":"2016-07-10 17:22:07.000000000","message":"I\u0027ll revisit this in another patch. Thanks Sergui.","commit_id":"33c743caff00c136d0d30d742ac6ff95b950072e"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"c65a86836d3219d523a955cae81c9694f920b01a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"enable_kubernetes: yes"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# TODO: Give the option to use the secure port (6443)"},{"line_number":5,"context_line":"kubernetes_endpoint: \"127.0.0.1:8080\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_6adb251c","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":37},"updated":"2016-07-10 18:00:16.000000000","message":"Since we are going towards using context set by kubectl, I would suggest to get api endpoint from the output of this command:\nkubectl config view\napiVersion: v1\nclusters:\n- cluster:\n    server: http://10.57.120.254:8080\n  name: kolla\ncontexts:\n- context:\n    cluster: kolla \n\nwe can extract all required information instead of hard coding it.","commit_id":"35c0d6d267fd67e86edd60b2107dbd107a27e6fa"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"767f2c90f1a48c4dee213fb25477e113ca5b173e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"enable_kubernetes: yes"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# TODO: Give the option to use the secure port (6443)"},{"line_number":5,"context_line":"kubernetes_endpoint: \"127.0.0.1:8080\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dada55a8_72a67354","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":37},"in_reply_to":"1aa78d24_0ddfe369","updated":"2016-07-19 14:09:51.000000000","message":"We already added function which is accessible in jinja2 to get API server url, we could easily add a version to get API server just IP. In this case it will be automatic and consistent with what kolla-kubernetes cli is using.","commit_id":"35c0d6d267fd67e86edd60b2107dbd107a27e6fa"},{"author":{"_account_id":22143,"name":"David Wang","email":"dcwangmit01@gmail.com","username":"dcwangmit01"},"change_message_id":"39ca0816e59e656858fb7dfc02680ae991ab2891","unresolved":false,"context_lines":[{"line_number":2,"context_line":"enable_kubernetes: yes"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# TODO: Give the option to use the secure port (6443)"},{"line_number":5,"context_line":"kubernetes_endpoint: \"127.0.0.1:8080\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_0ddfe369","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":37},"in_reply_to":"1aa78d24_6a068521","updated":"2016-07-12 00:05:00.000000000","message":"I think we should make this automatic.  We should should respect the kube config and current context as is determined in ~/.kube/config.\n\nLet\u0027s not hit the kube api until this is automatic.  Adding manual steps seems like a regression.  Also, having different configs between kolla-kube and kubectl will just confuse the operator.","commit_id":"35c0d6d267fd67e86edd60b2107dbd107a27e6fa"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"060bf8a1b56b7c136f28e7c3fdc21b686244be60","unresolved":false,"context_lines":[{"line_number":2,"context_line":"enable_kubernetes: yes"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# TODO: Give the option to use the secure port (6443)"},{"line_number":5,"context_line":"kubernetes_endpoint: \"127.0.0.1:8080\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1aa78d24_6a068521","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":37},"in_reply_to":"1aa78d24_6adb251c","updated":"2016-07-10 19:24:29.000000000","message":"This doesn\u0027t necessarily need to be automatic.  The operator needs to set the endpoint to the ip of the kube master or run on the kube master with localhost.  This can be solved with docs.","commit_id":"35c0d6d267fd67e86edd60b2107dbd107a27e6fa"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"fd320012c7a348478f6c1a21686fa18d62b94f1b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"enable_kubernetes: yes"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# TODO: Give the option to use the secure port (6443)"},{"line_number":5,"context_line":"kubernetes_endpoint: \"127.0.0.1:8080\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dada55a8_abfbc345","line":5,"updated":"2016-07-21 20:59:07.000000000","message":"this will be automatic.  The reason it wasn\u0027t was because of pure ansible approach.  Using the CLI + kubectl on the localhost, we can get the location of Kubernetes from there.","commit_id":"3daae013e45848d514553fe26bd56c0c9697a15e"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"36a3e923435ff6b6b80947f407932cd1a15235ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# The options in this file can be overridden in \u0027kolla-kubernetes.yml\u0027"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# The \"temp\" files that are created before merge need to stay persistent due"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a98d1f4_edc9a35a","line":1,"updated":"2016-09-30 15:45:49.000000000","message":"what is this file for? kolla-kubernetes.yml is the config file. I don\u0027t think we want to depend on ansible for defaults.","commit_id":"203f6647c95826a6c79b2b6e33591c5a3e0cf72c"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"a5c7a464ef0f3e18117d6e05f21b8c775fd5fe64","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# The options in this file can be overridden in \u0027kolla-kubernetes.yml\u0027"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# The \"temp\" files that are created before merge need to stay persistent due"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a98d1f4_f3aee0e4","line":1,"in_reply_to":"3a98d1f4_edc9a35a","updated":"2016-09-30 16:05:22.000000000","message":"kolla-kubernetes.yml and service_resource.yml would be broken up into this file and defaults for the services.","commit_id":"203f6647c95826a6c79b2b6e33591c5a3e0cf72c"}],"ansible/inventory/all-in-one":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"36a3e923435ff6b6b80947f407932cd1a15235ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3a98d1f4_4d061787","line":6,"updated":"2016-09-30 15:45:49.000000000","message":"Can we move this to be under workflow/ansible ?","commit_id":"203f6647c95826a6c79b2b6e33591c5a3e0cf72c"}],"ansible/roles/mariadb/tasks/bootstrap.yml":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"aabf2923371665523ba3e5a3a2083360f02e711b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"- name: Bootstrapping MariaDB"},{"line_number":6,"context_line":"  command: kolla-kubernetes resource status pod mariadb"},{"line_number":7,"context_line":"  register: result"},{"line_number":8,"context_line":"  until: result.results.status \u003d\u003d \"Succeeded\""},{"line_number":9,"context_line":"  retries: 10"},{"line_number":10,"context_line":"  delay: 4"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9ad45d7e_62442974","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":45},"updated":"2016-08-08 15:57:10.000000000","message":"Here is how it got checked with current implementation of kubectl:\n\nuntil: (result.stdout|from_yaml)[\u0027results\u0027][\u0027status\u0027] \u003d\u003d \u0027ok\u0027","commit_id":"5676feecbc173a4c555a49bf0b9397ce7a726b98"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"862fd6a7adc97d9eaa5e2e161379704fa8d45906","unresolved":false,"context_lines":[{"line_number":5,"context_line":"- name: Bootstrapping MariaDB"},{"line_number":6,"context_line":"  command: kolla-kubernetes resource status pod mariadb"},{"line_number":7,"context_line":"  register: result"},{"line_number":8,"context_line":"  until: result.results.status \u003d\u003d \"Succeeded\""},{"line_number":9,"context_line":"  retries: 10"},{"line_number":10,"context_line":"  delay: 4"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9ad45d7e_65ca73a3","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":45},"in_reply_to":"9ad45d7e_62442974","updated":"2016-08-08 16:02:24.000000000","message":"that bit is WIP.  We have to be 100% sure we\u0027re checking the correct pod and all the pods","commit_id":"5676feecbc173a4c555a49bf0b9397ce7a726b98"},{"author":{"_account_id":22143,"name":"David Wang","email":"dcwangmit01@gmail.com","username":"dcwangmit01"},"change_message_id":"ba7b6fb025ac612f7582cbb78ef0cddb803bcc23","unresolved":false,"context_lines":[{"line_number":5,"context_line":"- name: Bootstrapping MariaDB"},{"line_number":6,"context_line":"  command: kolla-kubernetes resource status pod mariadb"},{"line_number":7,"context_line":"  register: result"},{"line_number":8,"context_line":"  until: result.results.status \u003d\u003d \"Succeeded\""},{"line_number":9,"context_line":"  retries: 10"},{"line_number":10,"context_line":"  delay: 4"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9ad45d7e_6c3a5338","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":45},"in_reply_to":"9ad45d7e_65ca73a3","updated":"2016-08-08 19:52:02.000000000","message":"Serguei\u0027s snippet should work in the common case, for each service.  It does all of the resources under service\u003d\u003dmariadb resource_type\u003d\u003ddisk according to the command.\n\n-dave","commit_id":"5676feecbc173a4c555a49bf0b9397ce7a726b98"}],"ansible/roles/mariadb/tasks/config.yml":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"36a3e923435ff6b6b80947f407932cd1a15235ea","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  failed_when: result.stat.exists !\u003d true"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Creating MariaDB configmap"},{"line_number":8,"context_line":"  command: kolla-kubernetes resource create configmap mariadb"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Creating MariaDB pv"},{"line_number":11,"context_line":"  command: kolla-kubernetes resource create pv mariadb"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a98d1f4_ed6c4337","line":8,"updated":"2016-09-30 15:45:49.000000000","message":"can you change these all from \u0027kolla-kubernetes resource\u0027 to \u0027kollakube res\u0027 please?","commit_id":"203f6647c95826a6c79b2b6e33591c5a3e0cf72c"}],"ansible/roles/mariadb/tasks/start.yml":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"0818f3a258f4f6d08081e731a865c8879e920a44","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- template:"},{"line_number":3,"context_line":"    src\u003d\"{{ playbook_dir }}/../services/mariadb/mariadb-service.yml.j2\""},{"line_number":4,"context_line":"    dest\u003d\"{{ mariadb_service_template }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Starting MariaDB service"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_ba287434","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":71},"updated":"2016-06-29 21:25:49.000000000","message":"Why do you source service template from this location and not from mariadb/templates? Espicially since you have added service template in templates folder?","commit_id":"bf4390dd7bd62e808b876f2227078c0a421405a0"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"275d1a5735fa951a7be2a71058a2e81e9efc9828","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- template:"},{"line_number":3,"context_line":"    src\u003d\"{{ playbook_dir }}/../services/mariadb/mariadb-service.yml.j2\""},{"line_number":4,"context_line":"    dest\u003d\"{{ mariadb_service_template }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Starting MariaDB service"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_1c5fece5","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":71},"in_reply_to":"3aaa91ec_ba287434","updated":"2016-06-30 11:05:09.000000000","message":"I added the file in templates/* by accident.  That\u0027s the location where the j2 is rendered.","commit_id":"bf4390dd7bd62e808b876f2227078c0a421405a0"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"0818f3a258f4f6d08081e731a865c8879e920a44","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    state: present"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- template:"},{"line_number":14,"context_line":"    src\u003d\"{{ playbook_dir }}/../services/mariadb/mariadb-pod.yml.j2\""},{"line_number":15,"context_line":"    dest\u003d\"{{ mariadb_rc_template }}\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: Starting MariaDB replication controller"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_9ad49820","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":67},"updated":"2016-06-29 21:25:49.000000000","message":"ditto","commit_id":"bf4390dd7bd62e808b876f2227078c0a421405a0"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"2ff09e925f7d879f58e4e76f01f14ffb6afb96b4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#    file_reference: \"{{ mariadb_service_template }}\""},{"line_number":8,"context_line":"#    state: present"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Starting MariaDB replication controller"},{"line_number":11,"context_line":"  command: kolla-kubernetes run mariadb"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1aa78d24_8ad5b11c","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":39},"updated":"2016-07-10 17:31:59.000000000","message":"Here we just start mariadb, should we not add a task to check the status of mariadb rc/pod, same way it is done for mariadb bootstrap?","commit_id":"4b33638b393ca3d4d58d1a174c47e1afcf56553f"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"cf8aabf522754bd3a30c179c3efba3f546b7d8c8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#    file_reference: \"{{ mariadb_service_template }}\""},{"line_number":8,"context_line":"#    state: present"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Starting MariaDB replication controller"},{"line_number":11,"context_line":"  command: kolla-kubernetes run mariadb"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1aa78d24_ca84d90c","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":39},"in_reply_to":"1aa78d24_8ad5b11c","updated":"2016-07-10 17:45:38.000000000","message":"yes it would be very similar to bootstrap.yml.","commit_id":"4b33638b393ca3d4d58d1a174c47e1afcf56553f"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"0deddaf716c5bf89088fe132a35c695ba5af8716","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#    file_reference: \"{{ mariadb_service_template }}\""},{"line_number":8,"context_line":"#    state: present"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Starting MariaDB replication controller"},{"line_number":11,"context_line":"  command: kolla-kubernetes run mariadb"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1aa78d24_aa8ead24","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":39},"in_reply_to":"1aa78d24_ca84d90c","updated":"2016-07-10 17:47:15.000000000","message":"Assuming we choose to query via Ansible module and not through the CLI. Personally I think we should just query with the module that way we don\u0027t end up rewriting kubectl.","commit_id":"4b33638b393ca3d4d58d1a174c47e1afcf56553f"},{"author":{"_account_id":22143,"name":"David Wang","email":"dcwangmit01@gmail.com","username":"dcwangmit01"},"change_message_id":"aba26085f69e1f05216efccfae602b061c54c77a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"- name: Checking if MariaDB service is running"},{"line_number":6,"context_line":"  command: kolla-kubernetes resource status pod mariadb"},{"line_number":7,"context_line":"  register: result"},{"line_number":8,"context_line":"  until: result.api_response.0.status.phase \u003d\u003d \"Succeeded\""},{"line_number":9,"context_line":"  retries: 10"},{"line_number":10,"context_line":"  delay: 4"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9ad45d7e_4c4aef84","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":58},"updated":"2016-08-08 20:10:19.000000000","message":"This might not work.  The current yaml output for \"kolla-kubernetes resource status pod mariadb\" doesn\u0027t have api_response.\n\nAlso, the current kolla-kube resource status command generically checks kube resources only.  We need to create a \"kolla-kube resource health \u003cservice\u003e\" command to do app-specific checks, like port checks. \n\n\nYAML OUPUT: kolla-kubernetes resource status pod mariad\nmeta:\n  resource_type: pod\n  service_name: mariadb\nresults:\n  status: ok\nxdetails:\n  templates:\n  - meta:\n      template: /home/vagrant/Dev/kolla-kubernetes/services/mariadb/mariadb-pod.yml.j2\n    results:\n      errors: []\n      oks: []\n      status: ok\n    xdetails:\n      segments:\n      - meta:\n          kind: ReplicationController\n          name: mariadb\n        results:\n          errors: []\n          oks:\n          - Verified resource with name mariadb exists\n          - ReplicationController replicas found\n          - \u0027current \u003d\u003d desired: 1 current / 1 desired\u0027\n          - ReplicationController pod_status found\n          - \u0027pod_status has no errors: 1 Running / 0 Waiting / 0 Succeeded / 0 Failed\u0027\n          status: ok","commit_id":"5676feecbc173a4c555a49bf0b9397ce7a726b98"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"9d8c00efa778bab714f4084521f6b33ad63800c4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"- name: Checking if MariaDB service is running"},{"line_number":6,"context_line":"  command: kolla-kubernetes resource status pod mariadb"},{"line_number":7,"context_line":"  register: result"},{"line_number":8,"context_line":"  until: result.api_response.0.status.phase \u003d\u003d \"Succeeded\""},{"line_number":9,"context_line":"  retries: 10"},{"line_number":10,"context_line":"  delay: 4"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9ad45d7e_b248222f","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":58},"in_reply_to":"9ad45d7e_4c4aef84","updated":"2016-08-08 20:34:57.000000000","message":"I didn\u0027t change that piece yet because it isn\u0027t going to work.  We have to look at that status of a pod for a resource which will require an additional check in the CLI.  Kubernetes thinks the rc/job are healthy beacuse it created it. Only the pod resource will return the status","commit_id":"5676feecbc173a4c555a49bf0b9397ce7a726b98"},{"author":{"_account_id":22143,"name":"David Wang","email":"dcwangmit01@gmail.com","username":"dcwangmit01"},"change_message_id":"57998b1f3c13ae39e19e0e50d6486920c31b179c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"- name: Checking if MariaDB service is running"},{"line_number":6,"context_line":"  command: kolla-kubernetes resource status pod mariadb"},{"line_number":7,"context_line":"  register: result"},{"line_number":8,"context_line":"  until: result.api_response.0.status.phase \u003d\u003d \"Succeeded\""},{"line_number":9,"context_line":"  retries: 10"},{"line_number":10,"context_line":"  delay: 4"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9ad45d7e_b2cb0272","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":58},"in_reply_to":"9ad45d7e_b248222f","updated":"2016-08-08 20:38:29.000000000","message":"See if the way Serguei is using the status command might work.  That will check the RC, which checks that the actual\u003d\u003ddesired pods are up and running.  That may be a minimal check.","commit_id":"5676feecbc173a4c555a49bf0b9397ce7a726b98"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"36a3e923435ff6b6b80947f407932cd1a15235ea","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  command: kolla-kubernetes run mariadb"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Checking if MariaDB service is running"},{"line_number":6,"context_line":"  command: kubectl get petsets mariadb-bootstrap -o json"},{"line_number":7,"context_line":"  register: result"},{"line_number":8,"context_line":"  until: \"{{ (result.stdout | from_json).status.succeeded }} \u003d\u003d 1\""},{"line_number":9,"context_line":"  retries: 10"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a98d1f4_add4fbbc","line":6,"updated":"2016-09-30 15:45:49.000000000","message":"bootstrap\u0027s a job","commit_id":"203f6647c95826a6c79b2b6e33591c5a3e0cf72c"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"a5c7a464ef0f3e18117d6e05f21b8c775fd5fe64","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  command: kolla-kubernetes run mariadb"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Checking if MariaDB service is running"},{"line_number":6,"context_line":"  command: kubectl get petsets mariadb-bootstrap -o json"},{"line_number":7,"context_line":"  register: result"},{"line_number":8,"context_line":"  until: \"{{ (result.stdout | from_json).status.succeeded }} \u003d\u003d 1\""},{"line_number":9,"context_line":"  retries: 10"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a98d1f4_b3cd38b9","line":6,"in_reply_to":"3a98d1f4_add4fbbc","updated":"2016-09-30 16:05:22.000000000","message":"I just copied and pasted this.  I\u0027m fixing my env at the moment to fully test this piece","commit_id":"203f6647c95826a6c79b2b6e33591c5a3e0cf72c"}],"ansible/roles/mariadb/templates/mariadb-job.yml":[{"author":{"_account_id":22143,"name":"David Wang","email":"dcwangmit01@gmail.com","username":"dcwangmit01"},"change_message_id":"cbb15d5862747dabc7c6cc264c50f153d50f36d9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"          configMap:"},{"line_number":33,"context_line":"            name: mariadb-configmap"},{"line_number":34,"context_line":"        - name: mariadb-persistent-storage"},{"line_number":35,"context_line":"          hostPath:"},{"line_number":36,"context_line":"            path: /var/lib/mysql"},{"line_number":37,"context_line":"        - name: kolla-logs"},{"line_number":38,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_7947be1d","line":35,"range":{"start_line":35,"start_character":10,"end_line":35,"end_character":18},"updated":"2016-06-27 19:29:40.000000000","message":"Ryan,\n\nThis issue may be aside from the current pull request, but you seem to be refactoring all of this anyway so perhaps we should discuss this now.\n\nHopefully, there is room in the design for the ansible scripts to specify network volume mounts from different sources, depending on the provider.  Most importantly GKE disks, AWS EBS, and Ceph RBD volumes.\n\nIt would be great to integrate what I just mentioned into this POC.  Right now, bootstrapping and running Mariadb does not work well on multi-node kubernetes clusters, because there\u0027s no guarantee you will bootstrap and run on the same node.  I would prefer us to to show how that will work with this proof of concept.  I think it\u0027s core to support this from the start.\n\nThanks!\n-dave","commit_id":"bf4390dd7bd62e808b876f2227078c0a421405a0"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"4d9d51e5b4615c5d8eef1f5ae5077e0f0a0d5666","unresolved":false,"context_lines":[{"line_number":32,"context_line":"          configMap:"},{"line_number":33,"context_line":"            name: mariadb-configmap"},{"line_number":34,"context_line":"        - name: mariadb-persistent-storage"},{"line_number":35,"context_line":"          hostPath:"},{"line_number":36,"context_line":"            path: /var/lib/mysql"},{"line_number":37,"context_line":"        - name: kolla-logs"},{"line_number":38,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_f9c9b9ad","line":35,"range":{"start_line":35,"start_character":10,"end_line":35,"end_character":18},"in_reply_to":"3aaa91ec_7947be1d","updated":"2016-06-28 15:57:25.000000000","message":"To solve the issue with hostPath and multinode we need shared storage.  We can document how you can hook up an existing shared storage into the template. \n\nWe could also template for what type of shared storage is available.  First, let\u0027s start with ceph.","commit_id":"bf4390dd7bd62e808b876f2227078c0a421405a0"}],"ansible/roles/mariadb/templates/mariadb-pod.yml":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"306aee5daf1fb5bc67ccb34ef16211a5e1557880","unresolved":false,"context_lines":[{"line_number":32,"context_line":"          configMap:"},{"line_number":33,"context_line":"            name: mariadb-configmap"},{"line_number":34,"context_line":"        - name: mariadb-persistent-storage"},{"line_number":35,"context_line":"          hostPath:"},{"line_number":36,"context_line":"            path: /var/lib/mysql"},{"line_number":37,"context_line":"        - name: kolla-logs"},{"line_number":38,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_d5306758","line":35,"updated":"2016-06-26 22:53:58.000000000","message":"Instead of hostPath:\n      persistentVolumeClaim:\n        claimName: mariadb\n--------------- and a new file (mariadb-claim.yml) needed at mariadb bootstrap time:\nkind: PersistentVolumeClaim\napiVersion: v1\nmetadata:\n  name: mariadb\nspec:\n  accessModes:\n    - ReadWriteOnce\n  resources:\n    requests:\n      storage: 1Gi\n---------------- And if you want to test it locally, before doing anything (pv1-volume.yml):\nkind: PersistentVolume\napiVersion: v1\nmetadata:\n  name: pv1\n  labels:\n    type: local\nspec:\n  capacity:\n    storage: 1Gi\n  accessModes:\n    - ReadWriteOnce\n  hostPath:\n    path: \"/var/lib/kolla-volumes/pv1\"\n\n---------------- Or with Ceph, run this command\nrbd create --size 1024 pv1\n----------------and create pv1-volume.yml like this:\napiVersion: v1\nkind: PersistentVolume\nmetadata:\n  name: pv1\nspec:\n  capacity:\n    storage: 1Gi\n  accessModes:\n    - ReadWriteOnce\n  persistentVolumeReclaimPolicy: Recycle\n  rbd:\n    monitors:\n    - 172.17.42.1:6789\n    pool: rbd\n    image: pv1\n    user: admin\n    keyring: /etc/ceph/ceph.client.admin.keyring\n    fsType: ext4","commit_id":"bf4390dd7bd62e808b876f2227078c0a421405a0"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"6f9dc870e651b92b05f7c757e10027d520e66f60","unresolved":false,"context_lines":[{"line_number":32,"context_line":"          configMap:"},{"line_number":33,"context_line":"            name: mariadb-configmap"},{"line_number":34,"context_line":"        - name: mariadb-persistent-storage"},{"line_number":35,"context_line":"          hostPath:"},{"line_number":36,"context_line":"            path: /var/lib/mysql"},{"line_number":37,"context_line":"        - name: kolla-logs"},{"line_number":38,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_88785a2d","line":35,"in_reply_to":"3aaa91ec_6581d7fb","updated":"2016-06-27 18:30:12.000000000","message":"One more idea, what if we introduce k8s-storage-type variable, and populate it depending on the type of stoage used by the cluster. If you have all in one, it will be \"local\" as a result mapping will be done to local folder, if cluster uses ceph, then required parameters for the volume must be provided. in this case the deployment will be more flexible to different type of cluster configs.\nThought?\nSerguei","commit_id":"bf4390dd7bd62e808b876f2227078c0a421405a0"},{"author":{"_account_id":22143,"name":"David Wang","email":"dcwangmit01@gmail.com","username":"dcwangmit01"},"change_message_id":"cbb15d5862747dabc7c6cc264c50f153d50f36d9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"          configMap:"},{"line_number":33,"context_line":"            name: mariadb-configmap"},{"line_number":34,"context_line":"        - name: mariadb-persistent-storage"},{"line_number":35,"context_line":"          hostPath:"},{"line_number":36,"context_line":"            path: /var/lib/mysql"},{"line_number":37,"context_line":"        - name: kolla-logs"},{"line_number":38,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_79ca1e70","line":35,"in_reply_to":"3aaa91ec_6581d7fb","updated":"2016-06-27 19:29:40.000000000","message":"Serguei,\n\nI believe you need a persistent volume claim for the cases when a stateful pod (such as mariadb) migrates from on Node to another.  If there is no persistent volume claim, then the volume cannot be re-used and all of the data needs to be re-synced at the new node.\n\nWe use persistent volume claims for our Elasticsearch cluster running within kubernetes.  When a node dies, the pod is migrated to a new node, and the same disk remains and is attached to the new node with the new pod.  Without this, recovery would take much time since all of the data would have to re-sync to the new node.\n\n-dave","commit_id":"bf4390dd7bd62e808b876f2227078c0a421405a0"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"5b6404d2717451ddb3ac82b97a48daff5e63d80e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"          configMap:"},{"line_number":33,"context_line":"            name: mariadb-configmap"},{"line_number":34,"context_line":"        - name: mariadb-persistent-storage"},{"line_number":35,"context_line":"          hostPath:"},{"line_number":36,"context_line":"            path: /var/lib/mysql"},{"line_number":37,"context_line":"        - name: kolla-logs"},{"line_number":38,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_cfa9c426","line":35,"in_reply_to":"3aaa91ec_79ca1e70","updated":"2016-06-27 20:29:09.000000000","message":"HI Dave,\n\nThank you for explanation, it was not very clear from the documentation.\n\nSerguei","commit_id":"bf4390dd7bd62e808b876f2227078c0a421405a0"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"da8984ba4075a6640222e399ea597719e0fb09f2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"          configMap:"},{"line_number":33,"context_line":"            name: mariadb-configmap"},{"line_number":34,"context_line":"        - name: mariadb-persistent-storage"},{"line_number":35,"context_line":"          hostPath:"},{"line_number":36,"context_line":"            path: /var/lib/mysql"},{"line_number":37,"context_line":"        - name: kolla-logs"},{"line_number":38,"context_line":"          emptyDir: {}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3aaa91ec_6581d7fb","line":35,"in_reply_to":"3aaa91ec_d5306758","updated":"2016-06-27 18:18:47.000000000","message":"Kevin,\n\nWhat advantage you see to go through Persistent volume claim versus directly attaching rbd created image to the container? \nI brought up mariadb on my multinode cluster using direct approach. \nAppreciate your comments on this matter.\nThank you\nSerguei","commit_id":"bf4390dd7bd62e808b876f2227078c0a421405a0"}],"configmaps/mariadb/mariadb-configmap.yml.j2":[{"author":{"_account_id":21996,"name":"Ken Wronkiewicz","email":"wh-openstack@wirewd.com","username":"bowtie"},"change_message_id":"f6e34ef8ce2bcac2e6f8489de9c18f5e965910fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: v1"},{"line_number":2,"context_line":"kind: ConfigMap"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: mariadb-configmap"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3aaa91ec_f6ed74f0","line":1,"updated":"2016-06-27 21:53:23.000000000","message":"Is this file supposed to be here?  Replicates the configmap stored in ansible/ \n\n(I might be grossly misinterpreting Ansible)","commit_id":"bf4390dd7bd62e808b876f2227078c0a421405a0"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"4d9d51e5b4615c5d8eef1f5ae5077e0f0a0d5666","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: v1"},{"line_number":2,"context_line":"kind: ConfigMap"},{"line_number":3,"context_line":"metadata:"},{"line_number":4,"context_line":"  name: mariadb-configmap"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3aaa91ec_d9addd9c","line":1,"in_reply_to":"3aaa91ec_f6ed74f0","updated":"2016-06-28 15:57:25.000000000","message":"This is suppose to be here, but the file in templates/* are not. Those are generated at run time.","commit_id":"bf4390dd7bd62e808b876f2227078c0a421405a0"}],"kolla_kubernetes/pathfinder.py":[{"author":{"_account_id":22143,"name":"David Wang","email":"dcwangmit01@gmail.com","username":"dcwangmit01"},"change_message_id":"aba26085f69e1f05216efccfae602b061c54c77a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    # Search installation paths first"},{"line_number":103,"context_line":"    \u0027/etc/kolla\u0027,"},{"line_number":104,"context_line":"    \u0027/etc/kolla-kubernetes\u0027,"},{"line_number":105,"context_line":"    os.path.abspath(os.path.join(PathFinder.find_development_root(),"},{"line_number":106,"context_line":"                                 \u0027ansible/group_vars\u0027)),"},{"line_number":107,"context_line":"    # Then development paths"},{"line_number":108,"context_line":"    os.path.abspath(os.path.join(PathFinder.find_development_root(),"},{"line_number":109,"context_line":"                                 \u0027../kolla/etc/kolla\u0027)),"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_77469c24","line":106,"range":{"start_line":105,"start_character":0,"end_line":106,"end_character":56},"updated":"2016-08-08 20:10:19.000000000","message":"This is a dev path, so you should move it one line down below the next comment.  This works for dev --editable installs\n\nAlso, you need to add an installed search path, which depends on where setup.cfg copies the ansible stuff.  This makes it work for full installs.  Probalby somewhere like /usr/local/share/...\n\nPlease note that the original algorithm for searching for config files, which I did not change, is to return the first config file that is found within the ordered search paths.  In this case, it means, if you are searching for \"./ansible/group_vars/all.yml\", and there is one within /etc/kolla and /etc/kolla-kubernetes, then it will only return the /etc/kolla one. \n\nIMPORTANT: Also, this place might not be right.  You might actually mean to add the search path here: https://github.com/openstack/kolla-kubernetes/blob/master/kolla_kubernetes/service_resources.py#L71 as kolla-kubernetes.","commit_id":"5676feecbc173a4c555a49bf0b9397ce7a726b98"}],"services/mariadb/mariadb-bootstrap-job.yml.j2":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"da1c8f1252607fa42c793ba97a23501021e9cbf3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"          hostPath:"},{"line_number":38,"context_line":"            path: \"/var/lib/mysql\""},{"line_number":39,"context_line":"        {%- else %}"},{"line_number":40,"context_line":"          persistentVolumeClaim:"},{"line_number":41,"context_line":"            claimName: {{ resourceName }}"},{"line_number":42,"context_line":"        {%- endif %}"},{"line_number":43,"context_line":"        - name: kolla-logs"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9ad45d7e_c269958d","line":40,"updated":"2016-08-08 15:45:55.000000000","message":"you can just use the hostPath persistant volume for this. No need to make it specific here.","commit_id":"5676feecbc173a4c555a49bf0b9397ce7a726b98"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"862fd6a7adc97d9eaa5e2e161379704fa8d45906","unresolved":false,"context_lines":[{"line_number":37,"context_line":"          hostPath:"},{"line_number":38,"context_line":"            path: \"/var/lib/mysql\""},{"line_number":39,"context_line":"        {%- else %}"},{"line_number":40,"context_line":"          persistentVolumeClaim:"},{"line_number":41,"context_line":"            claimName: {{ resourceName }}"},{"line_number":42,"context_line":"        {%- endif %}"},{"line_number":43,"context_line":"        - name: kolla-logs"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9ad45d7e_8548472f","line":40,"in_reply_to":"9ad45d7e_c269958d","updated":"2016-08-08 16:02:24.000000000","message":"I was missing a setup step.  I\u0027ll fix in the next revision","commit_id":"5676feecbc173a4c555a49bf0b9397ce7a726b98"}],"services/mariadb/mariadb-pod.yml.j2":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"da1c8f1252607fa42c793ba97a23501021e9cbf3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"          hostPath:"},{"line_number":38,"context_line":"            path: \"/var/lib/mysql\""},{"line_number":39,"context_line":"        {%- else %}"},{"line_number":40,"context_line":"          persistentVolumeClaim:"},{"line_number":41,"context_line":"            claimName: {{ resourceName }}"},{"line_number":42,"context_line":"        {%- endif %}"},{"line_number":43,"context_line":"        - name: kolla-logs"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"9ad45d7e_020a8dd2","line":40,"updated":"2016-08-08 15:45:55.000000000","message":"Same here.","commit_id":"5676feecbc173a4c555a49bf0b9397ce7a726b98"}],"workflows/ansible/roles/mariadb/tasks/bootstrap.yml":[{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"c938b1514e97aa3b2cc0fe96ba8d3bed896a1bae","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  ignore_errors: True"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- fail: msg\u003d\"Mariadb failed to bootstrap.\""},{"line_number":14,"context_line":"  when: \"{{ (result.stdout | from_json).status.succeeded }} !\u003d 1\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Cleanup MariaDB Bootstrap pod"},{"line_number":17,"context_line":"  command: kollakube resource delete bootstrap mariadb-bootstrap"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3a98d1f4_79faa744","line":14,"updated":"2016-09-30 20:44:05.000000000","message":"put that to \"failed_when\" in task above","commit_id":"b91e34ffa7cd1862b66960ea433db6988c5768d8"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"ceccbf3cf4084f1082b678ec6ec551cbcf0464e2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  ignore_errors: True"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- fail: msg\u003d\"Mariadb failed to bootstrap.\""},{"line_number":14,"context_line":"  when: \"{{ (result.stdout | from_json).status.succeeded }} !\u003d 1\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Cleanup MariaDB Bootstrap pod"},{"line_number":17,"context_line":"  command: kollakube resource delete bootstrap mariadb-bootstrap"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3a98d1f4_c461123b","line":14,"in_reply_to":"3a98d1f4_792d47a7","updated":"2016-09-30 21:06:06.000000000","message":"Message is \"failed to bootstrap\" ;) I think big red failed task will carry similar message:)","commit_id":"b91e34ffa7cd1862b66960ea433db6988c5768d8"},{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"0af95fd266283c07ed807a7f0eafdee16b7d2853","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  ignore_errors: True"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- fail: msg\u003d\"Mariadb failed to bootstrap.\""},{"line_number":14,"context_line":"  when: \"{{ (result.stdout | from_json).status.succeeded }} !\u003d 1\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Cleanup MariaDB Bootstrap pod"},{"line_number":17,"context_line":"  command: kollakube resource delete bootstrap mariadb-bootstrap"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3a98d1f4_792d47a7","line":14,"in_reply_to":"3a98d1f4_79faa744","updated":"2016-09-30 20:48:24.000000000","message":"The purpose of this is a better error message.","commit_id":"b91e34ffa7cd1862b66960ea433db6988c5768d8"}],"workflows/ansible/roles/mariadb/tasks/config.yml":[{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"438ec8343fadb3740fab96d5b23fe6dc0ad5ad16","unresolved":false,"context_lines":[{"line_number":7,"context_line":"- name: Creating MariaDB configmap"},{"line_number":8,"context_line":"  command: kollakube resource create configmap mariadb"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Creating MariaDB pv"},{"line_number":11,"context_line":"  command: kollakube resource create pv mariadb"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Creating MariaDB pvc"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_4aa8c68d","line":10,"updated":"2016-10-06 21:45:34.000000000","message":"is this part of config? I\u0027d move this to bootstrap.","commit_id":"2441674cc2a182f0fbccd463b51823227177c664"}],"workflows/ansible/roles/mariadb/tasks/start.yml":[{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"c938b1514e97aa3b2cc0fe96ba8d3bed896a1bae","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  ignore_errors: True"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- fail: msg\u003d\"Mariadb failed to start.\""},{"line_number":14,"context_line":"  when: \"{{ (result.stdout | from_json).status.phase !\u003d \u0027Running\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3a98d1f4_998e93ce","line":14,"updated":"2016-09-30 20:44:05.000000000","message":"ditto","commit_id":"b91e34ffa7cd1862b66960ea433db6988c5768d8"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"438ec8343fadb3740fab96d5b23fe6dc0ad5ad16","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Starting MariaDB replication controller"},{"line_number":3,"context_line":"  command: kollakube resource create pod mariadb"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Checking if MariaDB service is running"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a95cdbc_6aa90290","line":2,"updated":"2016-10-06 21:45:34.000000000","message":"we create pod here right?:)","commit_id":"2441674cc2a182f0fbccd463b51823227177c664"}]}
