)]}'
{"etc/kolla-kubernetes/kolla-kubernetes.yml":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"89214468f3616522b556d84312b28737632ca9c5","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"enable_openvswitch_tcp: \"yes\""},{"line_number":62,"context_line":"enable_libvirt_tcp: \"yes\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"#################################"},{"line_number":65,"context_line":"# Kubernetes Cluster DNS setting"},{"line_number":66,"context_line":"#################################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a8ec9b2_089b2b73","line":63,"updated":"2016-09-15 18:09:09.000000000","message":"I don\u0027t think we should default insecure stuff on.\n\nThings seem to work without it if we fix the /var/run vs /run issue.","commit_id":"dd8d346626067e1d757698f6e1738721bf52e2df"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f7801e424a73df727605be2a4f727e72433b7fe4","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"enable_openvswitch_tcp: \"yes\""},{"line_number":62,"context_line":"enable_libvirt_tcp: \"yes\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"#################################"},{"line_number":65,"context_line":"# Kubernetes Cluster DNS setting"},{"line_number":66,"context_line":"#################################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a8ec9b2_2b07feca","line":63,"in_reply_to":"7a8ec9b2_089b2b73","updated":"2016-09-15 19:04:22.000000000","message":"Sure we can have default NO","commit_id":"dd8d346626067e1d757698f6e1738721bf52e2df"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"89214468f3616522b556d84312b28737632ca9c5","unresolved":false,"context_lines":[{"line_number":217,"context_line":"########################"},{"line_number":218,"context_line":"kolla_kubernetes_ovs_setup_bridge: \"yes\""},{"line_number":219,"context_line":"enable_resolve_conf_net_host_workaround: \"yes\""},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"########################"},{"line_number":222,"context_line":"# Workaround variables"},{"line_number":223,"context_line":"########################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a8ec9b2_a8a5d7a2","line":220,"updated":"2016-09-15 18:09:09.000000000","message":"This is duplicated.","commit_id":"dd8d346626067e1d757698f6e1738721bf52e2df"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f7801e424a73df727605be2a4f727e72433b7fe4","unresolved":false,"context_lines":[{"line_number":217,"context_line":"########################"},{"line_number":218,"context_line":"kolla_kubernetes_ovs_setup_bridge: \"yes\""},{"line_number":219,"context_line":"enable_resolve_conf_net_host_workaround: \"yes\""},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"########################"},{"line_number":222,"context_line":"# Workaround variables"},{"line_number":223,"context_line":"########################"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a8ec9b2_abfb0ec0","line":220,"in_reply_to":"7a8ec9b2_a8a5d7a2","updated":"2016-09-15 19:04:22.000000000","message":"will remove it","commit_id":"dd8d346626067e1d757698f6e1738721bf52e2df"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"89214468f3616522b556d84312b28737632ca9c5","unresolved":false,"context_lines":[{"line_number":222,"context_line":"# Workaround variables"},{"line_number":223,"context_line":"########################"},{"line_number":224,"context_line":"kolla_kubernetes_ovs_setup_bridge: \"yes\""},{"line_number":225,"context_line":"kolla_kubernetes_ovs_add_port: \"yes\""},{"line_number":226,"context_line":"enable_resolve_conf_net_host_workaround: \"yes\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a8ec9b2_2301e805","line":225,"updated":"2016-09-15 18:09:09.000000000","message":"Not sure how to feel about defaulting kolla_kubernetes_ovs_add_port \u003d yes. when the add_port logic was enabled by default before, and the network config wasn\u0027t perfect, it ended up stealing the ethernet device into the bridge, and cutting off access to the test system. I thought I oom\u0027ed the vm, and it took me a little while to figure out why it was broken.\n\nIt may be best to default it to no, have the documentation have the user setup everything without it, have some instructions for verify stuff\u0027s working, then tweak the setting and relaunch with the option enabled for those that need it?","commit_id":"dd8d346626067e1d757698f6e1738721bf52e2df"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f7801e424a73df727605be2a4f727e72433b7fe4","unresolved":false,"context_lines":[{"line_number":222,"context_line":"# Workaround variables"},{"line_number":223,"context_line":"########################"},{"line_number":224,"context_line":"kolla_kubernetes_ovs_setup_bridge: \"yes\""},{"line_number":225,"context_line":"kolla_kubernetes_ovs_add_port: \"yes\""},{"line_number":226,"context_line":"enable_resolve_conf_net_host_workaround: \"yes\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a8ec9b2_0bffa2aa","line":225,"in_reply_to":"7a8ec9b2_2301e805","updated":"2016-09-15 19:04:22.000000000","message":"I think we should do it this way because of kola, or we need to have get ok from Ryan and Steven Dake.","commit_id":"dd8d346626067e1d757698f6e1738721bf52e2df"}],"services/nova/nova-compute-pod.yml.j2":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"89214468f3616522b556d84312b28737632ca9c5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                  crudini --set /nova/nova.conf vnc vncserver_listen $IP;"},{"line_number":30,"context_line":"                  crudini --set /nova/nova.conf vnc vncserver_proxyclient_address $IP;"},{"line_number":31,"context_line":"                  crudini --set /nova/nova.conf vnc novncproxy_base_url {{ novncproxy_base_url }};"},{"line_number":32,"context_line":"                  crudini --set /nova/nova.conf libvirt virt_type qemu;"},{"line_number":33,"context_line":"{%- if enable_libvirt_tcp \u003d\u003d \"yes\" %}"},{"line_number":34,"context_line":"                  sed -i \u0027\u0027s|^connection_uri.*\u003d.*|connection_uri\u003d\\\"qemu+tcp://\u0027\u0027$IP\u0027\u0027/system\\\"|g\u0027\u0027 /nova/nova.conf;"},{"line_number":35,"context_line":"{%- endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7a8ec9b2_7d71d3a7","line":32,"updated":"2016-09-15 18:09:09.000000000","message":"This is undesirable I think. I think it should come from either nova genconfig or at least tweaked before entering the configmap.","commit_id":"dd8d346626067e1d757698f6e1738721bf52e2df"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"89214468f3616522b556d84312b28737632ca9c5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                  crudini --set /nova/nova.conf vnc novncproxy_base_url {{ novncproxy_base_url }};"},{"line_number":32,"context_line":"                  crudini --set /nova/nova.conf libvirt virt_type qemu;"},{"line_number":33,"context_line":"{%- if enable_libvirt_tcp \u003d\u003d \"yes\" %}"},{"line_number":34,"context_line":"                  sed -i \u0027\u0027s|^connection_uri.*\u003d.*|connection_uri\u003d\\\"qemu+tcp://\u0027\u0027$IP\u0027\u0027/system\\\"|g\u0027\u0027 /nova/nova.conf;"},{"line_number":35,"context_line":"{%- endif %}"},{"line_number":36,"context_line":"             \"],"},{"line_number":37,"context_line":"             \"volumeMounts\": ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7a8ec9b2_3df02bfe","line":34,"updated":"2016-09-15 18:09:09.000000000","message":"Why revert this to a sed?\n\nOh, the section in the crudini is wrong...\n\nIt should be \u0027libvirt\u0027 instead of \u0027vnc\u0027 in the crudini line.\n\nAnd thinking about it, is there any advantage to binding libvirt to a public address instead of just 127.0.0.1? both nova-libvirt and nova-compute run on the same host.","commit_id":"dd8d346626067e1d757698f6e1738721bf52e2df"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f7801e424a73df727605be2a4f727e72433b7fe4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                  crudini --set /nova/nova.conf vnc novncproxy_base_url {{ novncproxy_base_url }};"},{"line_number":32,"context_line":"                  crudini --set /nova/nova.conf libvirt virt_type qemu;"},{"line_number":33,"context_line":"{%- if enable_libvirt_tcp \u003d\u003d \"yes\" %}"},{"line_number":34,"context_line":"                  sed -i \u0027\u0027s|^connection_uri.*\u003d.*|connection_uri\u003d\\\"qemu+tcp://\u0027\u0027$IP\u0027\u0027/system\\\"|g\u0027\u0027 /nova/nova.conf;"},{"line_number":35,"context_line":"{%- endif %}"},{"line_number":36,"context_line":"             \"],"},{"line_number":37,"context_line":"             \"volumeMounts\": ["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7a8ec9b2_ab978e46","line":34,"in_reply_to":"7a8ec9b2_3df02bfe","updated":"2016-09-15 19:04:22.000000000","message":"I think 127.0.0.1 should work, needs to be tested\n\nI could not figure out how to make crudini to add \"qemu+tcp blah bla\nIt was not adding double quote character and I think it has to be this way.","commit_id":"dd8d346626067e1d757698f6e1738721bf52e2df"}],"services/nova/nova-control-scheduler-pod.yml.j2":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"89214468f3616522b556d84312b28737632ca9c5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    metadata:"},{"line_number":8,"context_line":"      labels:"},{"line_number":9,"context_line":"        service: nova"},{"line_number":10,"context_line":"        type: scheduler "},{"line_number":11,"context_line":"      annotations:"},{"line_number":12,"context_line":"        pod.alpha.kubernetes.io/initialized: \"true\""},{"line_number":13,"context_line":"        pod.alpha.kubernetes.io/init-containers: \u0027["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7a8ec9b2_e2045e19","line":10,"updated":"2016-09-15 18:09:09.000000000","message":"ws","commit_id":"dd8d346626067e1d757698f6e1738721bf52e2df"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f7801e424a73df727605be2a4f727e72433b7fe4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    metadata:"},{"line_number":8,"context_line":"      labels:"},{"line_number":9,"context_line":"        service: nova"},{"line_number":10,"context_line":"        type: scheduler "},{"line_number":11,"context_line":"      annotations:"},{"line_number":12,"context_line":"        pod.alpha.kubernetes.io/initialized: \"true\""},{"line_number":13,"context_line":"        pod.alpha.kubernetes.io/init-containers: \u0027["}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7a8ec9b2_8b857208","line":10,"in_reply_to":"7a8ec9b2_e2045e19","updated":"2016-09-15 19:04:22.000000000","message":"will fix it","commit_id":"dd8d346626067e1d757698f6e1738721bf52e2df"}]}
