)]}'
{"services/cinder/cinder-volume-lvm-pod.yml.j2":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"61a178aff70f49533cd5b4cc84ee7a1e1f2cc25f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{%- set resourceName \u003d kolla_kubernetes.cli.args.resource_name %}"},{"line_number":2,"context_line":"{%- set loggerConfigmapName \u003d \"cinder-volume\" %}"},{"line_number":3,"context_line":"{%- set nethostContainer \u003d \"yes\" %}"},{"line_number":4,"context_line":"{%- import \"services/common/common-kube-logger.yml.j2\" as kube_logger with context %}"},{"line_number":5,"context_line":"apiVersion: extensions/v1beta1"},{"line_number":6,"context_line":"kind: DaemonSet"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5a8bc5a2_d035e5a8","line":3,"range":{"start_line":3,"start_character":8,"end_line":3,"end_character":24},"updated":"2016-09-27 23:19:29.000000000","message":"how about netHostTrue ?","commit_id":"d5e907e67c173d230606ff6aeae479f680f221c2"}],"services/nova/nova-libvirt-pod.yml.j2":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"61a178aff70f49533cd5b4cc84ee7a1e1f2cc25f","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        - name: nova-libvirt-bin-secret"},{"line_number":144,"context_line":"          secret:"},{"line_number":145,"context_line":"            secretName: nova-libvirt-bin"},{"line_number":146,"context_line":"{%- endif %}"},{"line_number":147,"context_line":"{%- if enable_resolve_conf_net_host_workaround \u003d\u003d \"yes\" %}"},{"line_number":148,"context_line":"        - name: resolv-conf"},{"line_number":149,"context_line":"          configMap:"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5a8bc5a2_10b3cd0b","line":146,"updated":"2016-09-27 23:19:29.000000000","message":"Can we move this into a macro in services/common/common-lib.yaml.j2 now?\n\nsomething like:\n{% macro _common_volumes() %}\n{%- if enable_resolve_conf_net_host_workaround \u003d\u003d \"yes\" %}\n- name: resolv-conf\n  configMap:\n    name: resolv-conf\n{%- endif %}\n.... other common volumes here like /var/log/kolla\n{% endmacro %}\n\n{% macro common_volumes(indent) %}\n{{ _common_volumes | indent(indent) }}\n{% endmacro %}\n\nThen we can call it here as something like\n{{ common_volumes(indent\u003d8) }}\n\nWill clean up the code quite a bit I think.","commit_id":"d5e907e67c173d230606ff6aeae479f680f221c2"}]}
