)]}'
{"doc/source/ceph-guide.rst":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"a8595d2769e84a76a6b6a1a156125f173a38bee3","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"::"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    kollakube res create pod ceph-rbd"},{"line_number":42,"context_line":"    kollakube res create pod ceph-admin"},{"line_number":43,"context_line":"    watch kubectl get pods --namespace\u003dkolla"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a98d1f4_24e7ef40","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":37},"updated":"2016-10-03 11:02:53.000000000","message":"What role play ceph-rbd and ceph-admin pods when external ceph cluster is used?","commit_id":"1834e52500c0cd4bb1bc5d9ba23439e8c1dda286"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"842229cb50743189f22391c6a9f96a1c9ef5ba87","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"::"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    cmd\u003d\"rbd create --pool kollavolumes --size 10240 mariadb; rbd map --pool kollavolumes mariadb; #format it and unmount/unmap...\""},{"line_number":67,"context_line":"    kubectl exec -it ceph-admin -- /bin/bash -xec \"$cmd\""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Ceph managed by Kolla-Kubernetes"}],"source_content_type":"text/x-rst","patch_set":24,"id":"3a98d1f4_bdbccddc","line":66,"range":{"start_line":66,"start_character":9,"end_line":66,"end_character":60},"updated":"2016-10-04 04:02:25.000000000","message":"if \"--image-feature layering\" is not used then kubernetes cannot mount cph image.\nOct  3 21:24:08 k8s-5 kubelet: RBD image feature set mismatch. You can disable features unsupported by the kernel with \"rbd feature disable\"","commit_id":"81e494ccb6245076e77564d4eb6d8776f9ed32f3"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"e6da523b83532a4df1fb8204b15813394629bb56","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"::"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    cmd\u003d\"rbd create --pool kollavolumes --size 10240 mariadb; rbd map --pool kollavolumes mariadb; #format it and unmount/unmap...\""},{"line_number":67,"context_line":"    kubectl exec -it ceph-admin -- /bin/bash -xec \"$cmd\""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Ceph managed by Kolla-Kubernetes"}],"source_content_type":"text/x-rst","patch_set":24,"id":"3a98d1f4_4324b5c5","line":66,"range":{"start_line":66,"start_character":9,"end_line":66,"end_character":60},"in_reply_to":"3a98d1f4_bdbccddc","updated":"2016-10-04 13:44:38.000000000","message":"True. I\u0027ll add it to the next ps.","commit_id":"81e494ccb6245076e77564d4eb6d8776f9ed32f3"}],"doc/source/minikube-quickstart.rst":[{"author":{"_account_id":10419,"name":"Ryan Hallisey","email":"rhallise@redhat.com","username":"rhallisey"},"change_message_id":"8c3bf033588ec2255ea3d8003ea37bdca3a20494","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    curl -Lo kubectl \\"},{"line_number":28,"context_line":"      http://storage.googleapis.com/kubernetes-release/release/v1.3.6/bin/linux/amd64/kubectl"},{"line_number":29,"context_line":"    chmod +x kubectl"},{"line_number":30,"context_line":"    sudo mv kubectl /usr/local/bin"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Start minikube and services"}],"source_content_type":"text/x-rst","patch_set":104,"id":"1a95cdbc_f84843b5","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":9},"updated":"2016-10-09 20:17:53.000000000","message":"there is already a script in the tools dir to get the latest kubectl. ./tools/setup-kubectl.sh","commit_id":"065f95b63b20fe5e1b59c73d5b1d6d51f6e74ef7"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"da167bcb549e6ad33153fa11e70a03a527e19c1b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    curl -Lo kubectl \\"},{"line_number":28,"context_line":"      http://storage.googleapis.com/kubernetes-release/release/v1.3.6/bin/linux/amd64/kubectl"},{"line_number":29,"context_line":"    chmod +x kubectl"},{"line_number":30,"context_line":"    sudo mv kubectl /usr/local/bin"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Start minikube and services"}],"source_content_type":"text/x-rst","patch_set":104,"id":"1a95cdbc_b8007b35","line":29,"range":{"start_line":29,"start_character":4,"end_line":29,"end_character":9},"in_reply_to":"1a95cdbc_f84843b5","updated":"2016-10-09 20:29:07.000000000","message":"I didn\u0027t change it in this PS. But, the version listed here matches up with the minikube version above. All tested as a set. If the minikube version doesn\u0027t match the kubectl version it might not work.","commit_id":"065f95b63b20fe5e1b59c73d5b1d6d51f6e74ef7"}],"services/ceph/ceph-admin-pod.yml.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"1ce728ae016286a226adaf48446efced0509a7de","unresolved":false,"context_lines":[{"line_number":38,"context_line":"          name: ceph-client-admin-keyring"},{"line_number":39,"context_line":"        - mountPath: /dev"},{"line_number":40,"context_line":"          name: host-dev"},{"line_number":41,"context_line":"        - mountPath: /lib/modules"},{"line_number":42,"context_line":"          name: lib-modules"},{"line_number":43,"context_line":"  volumes:"},{"line_number":44,"context_line":"{{ lib.common_volumes(indent\u003d4) }}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"3a98d1f4_52a65dae","line":41,"updated":"2016-10-03 21:33:55.000000000","message":"is :ro an option here?","commit_id":"01e78126ee1f6ee94e7a58027126c01ef314355f"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"eb5eefe922b6dc3968f6de4a3b60c1d59218105b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"          name: ceph-client-admin-keyring"},{"line_number":39,"context_line":"        - mountPath: /dev"},{"line_number":40,"context_line":"          name: host-dev"},{"line_number":41,"context_line":"        - mountPath: /lib/modules"},{"line_number":42,"context_line":"          name: lib-modules"},{"line_number":43,"context_line":"  volumes:"},{"line_number":44,"context_line":"{{ lib.common_volumes(indent\u003d4) }}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"3a98d1f4_92a9c526","line":41,"in_reply_to":"3a98d1f4_52a65dae","updated":"2016-10-03 21:45:20.000000000","message":"not sure. its not on any of the other /lib/module mountPath\u0027s. I just copied it from nova-api","commit_id":"01e78126ee1f6ee94e7a58027126c01ef314355f"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"ba645a5c08e04e3bff37febfb351174e9315be56","unresolved":false,"context_lines":[{"line_number":38,"context_line":"          name: ceph-client-admin-keyring"},{"line_number":39,"context_line":"        - mountPath: /dev"},{"line_number":40,"context_line":"          name: host-dev"},{"line_number":41,"context_line":"        - mountPath: /lib/modules"},{"line_number":42,"context_line":"          name: lib-modules"},{"line_number":43,"context_line":"  volumes:"},{"line_number":44,"context_line":"{{ lib.common_volumes(indent\u003d4) }}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"3a98d1f4_8387b9b3","line":41,"in_reply_to":"3a98d1f4_92a9c526","updated":"2016-10-03 23:20:23.000000000","message":"something to investigate in the future.  I have brought this up in prior reviews and I think I got the same answer :)  Any chance of filing a techdebt bug?  We really don\u0027t want the containers being able to overwrite kernel modules for security reasons.","commit_id":"01e78126ee1f6ee94e7a58027126c01ef314355f"}],"services/ceph/ceph-rbd-pod.yml.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"1ce728ae016286a226adaf48446efced0509a7de","unresolved":false,"context_lines":[{"line_number":41,"context_line":"{{ lib.common_volume_mounts(indent\u003d12) }}"},{"line_number":42,"context_line":"            - mountPath: /host/"},{"line_number":43,"context_line":"              name: host-usr-bin"},{"line_number":44,"context_line":"            - mountPath: /lib/modules"},{"line_number":45,"context_line":"              name: lib-modules"},{"line_number":46,"context_line":"      volumes:"},{"line_number":47,"context_line":"{{ lib.common_volumes(indent\u003d8) }}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"3a98d1f4_72c8b955","line":44,"updated":"2016-10-03 21:33:55.000000000","message":"is :ro an option here?","commit_id":"01e78126ee1f6ee94e7a58027126c01ef314355f"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"eb5eefe922b6dc3968f6de4a3b60c1d59218105b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"{{ lib.common_volume_mounts(indent\u003d12) }}"},{"line_number":42,"context_line":"            - mountPath: /host/"},{"line_number":43,"context_line":"              name: host-usr-bin"},{"line_number":44,"context_line":"            - mountPath: /lib/modules"},{"line_number":45,"context_line":"              name: lib-modules"},{"line_number":46,"context_line":"      volumes:"},{"line_number":47,"context_line":"{{ lib.common_volumes(indent\u003d8) }}"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"3a98d1f4_f24f698f","line":44,"in_reply_to":"3a98d1f4_72c8b955","updated":"2016-10-03 21:45:20.000000000","message":"same answer as in the other file.","commit_id":"01e78126ee1f6ee94e7a58027126c01ef314355f"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"1ce728ae016286a226adaf48446efced0509a7de","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            path: /usr/bin"},{"line_number":51,"context_line":"        - name: lib-modules"},{"line_number":52,"context_line":"          hostPath:"},{"line_number":53,"context_line":"            path: /lib/modules"}],"source_content_type":"text/x-jinja2","patch_set":18,"id":"3a98d1f4_52d49dea","line":53,"updated":"2016-10-03 21:33:55.000000000","message":"is :ro an option here","commit_id":"01e78126ee1f6ee94e7a58027126c01ef314355f"}],"tests/conf/ceph-all-in-one/kolla_kubernetes_config":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"1ce728ae016286a226adaf48446efced0509a7de","unresolved":false,"context_lines":[{"line_number":6,"context_line":"kolla_kubernetes_external_bridge_ip: \"172.18.0.1\""},{"line_number":7,"context_line":"kolla_kubernetes_external_subnet: \"24\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"storage_provider: \"ceph\" "},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"storage_interface: \"docker0\""},{"line_number":12,"context_line":"storage_ceph:"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"3a98d1f4_f2092996","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":25},"updated":"2016-10-03 21:33:55.000000000","message":"hate to nitpick...","commit_id":"01e78126ee1f6ee94e7a58027126c01ef314355f"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"eb5eefe922b6dc3968f6de4a3b60c1d59218105b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"kolla_kubernetes_external_bridge_ip: \"172.18.0.1\""},{"line_number":7,"context_line":"kolla_kubernetes_external_subnet: \"24\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"storage_provider: \"ceph\" "},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"storage_interface: \"docker0\""},{"line_number":12,"context_line":"storage_ceph:"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"3a98d1f4_1211355d","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":25},"in_reply_to":"3a98d1f4_f2092996","updated":"2016-10-03 21:45:20.000000000","message":"good catch. Fixed.","commit_id":"01e78126ee1f6ee94e7a58027126c01ef314355f"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"1ce728ae016286a226adaf48446efced0509a7de","unresolved":false,"context_lines":[{"line_number":11,"context_line":"storage_interface: \"docker0\""},{"line_number":12,"context_line":"storage_ceph:"},{"line_number":13,"context_line":"  monitors:"},{"line_number":14,"context_line":"  - 172.17.0.1"},{"line_number":15,"context_line":"  user: kolla"},{"line_number":16,"context_line":"  pool: kollavolumes"},{"line_number":17,"context_line":"  secretName: ceph-kolla"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"3a98d1f4_52fbbd78","line":14,"updated":"2016-10-03 21:33:55.000000000","message":"where does this monitor address come from - or isthis just a template?","commit_id":"01e78126ee1f6ee94e7a58027126c01ef314355f"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"eb5eefe922b6dc3968f6de4a3b60c1d59218105b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"storage_interface: \"docker0\""},{"line_number":12,"context_line":"storage_ceph:"},{"line_number":13,"context_line":"  monitors:"},{"line_number":14,"context_line":"  - 172.17.0.1"},{"line_number":15,"context_line":"  user: kolla"},{"line_number":16,"context_line":"  pool: kollavolumes"},{"line_number":17,"context_line":"  secretName: ceph-kolla"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"3a98d1f4_6511d551","line":14,"in_reply_to":"3a98d1f4_52fbbd78","updated":"2016-10-03 21:45:20.000000000","message":"the address comes from here. Then applied everywhere else. This config file is appended to the default kolla-kubernetes.yml in the tools/setup_gate.sh script.\n\nI asked infra for a ip space that would be free on all their vm\u0027s.","commit_id":"01e78126ee1f6ee94e7a58027126c01ef314355f"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"ba645a5c08e04e3bff37febfb351174e9315be56","unresolved":false,"context_lines":[{"line_number":11,"context_line":"storage_interface: \"docker0\""},{"line_number":12,"context_line":"storage_ceph:"},{"line_number":13,"context_line":"  monitors:"},{"line_number":14,"context_line":"  - 172.17.0.1"},{"line_number":15,"context_line":"  user: kolla"},{"line_number":16,"context_line":"  pool: kollavolumes"},{"line_number":17,"context_line":"  secretName: ceph-kolla"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"3a98d1f4_e3979de9","line":14,"in_reply_to":"3a98d1f4_6511d551","updated":"2016-10-03 23:20:23.000000000","message":"roger thanks.  I guess I should have picked up on the \"tests\" directory :)","commit_id":"01e78126ee1f6ee94e7a58027126c01ef314355f"}],"tools/setup_gate.sh":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"1ce728ae016286a226adaf48446efced0509a7de","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            kubectl logs $NAME -c $CON --namespace $NAMESPACE \u003e \\"},{"line_number":63,"context_line":"                $WORKSPACE/logs/pods/$NAMESPACE-$NAME-$CON.txt"},{"line_number":64,"context_line":"        done"},{"line_number":65,"context_line":"    done"},{"line_number":66,"context_line":"    sudo iptables-save \u003e $WORKSPACE/logs/iptables.txt"},{"line_number":67,"context_line":"    sudo ip a \u003e $WORKSPACE/logs/ip.txt"},{"line_number":68,"context_line":"    sudo route -n \u003e $WORKSPACE/logs/routes.txt"}],"source_content_type":"text/x-sh","patch_set":18,"id":"3a98d1f4_9248e5cd","line":65,"updated":"2016-10-03 21:33:55.000000000","message":"can you break out the gate change separately.  While it doesn\u0027t matter yet for kolla-kubernetes, its a very  good habit to get into to maintain stable branches.","commit_id":"01e78126ee1f6ee94e7a58027126c01ef314355f"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"eb5eefe922b6dc3968f6de4a3b60c1d59218105b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            kubectl logs $NAME -c $CON --namespace $NAMESPACE \u003e \\"},{"line_number":63,"context_line":"                $WORKSPACE/logs/pods/$NAMESPACE-$NAME-$CON.txt"},{"line_number":64,"context_line":"        done"},{"line_number":65,"context_line":"    done"},{"line_number":66,"context_line":"    sudo iptables-save \u003e $WORKSPACE/logs/iptables.txt"},{"line_number":67,"context_line":"    sudo ip a \u003e $WORKSPACE/logs/ip.txt"},{"line_number":68,"context_line":"    sudo route -n \u003e $WORKSPACE/logs/routes.txt"}],"source_content_type":"text/x-sh","patch_set":18,"id":"3a98d1f4_a5459d43","line":65,"in_reply_to":"3a98d1f4_9248e5cd","updated":"2016-10-03 21:45:20.000000000","message":"whats better, accepting patches without checks, running the risk checks never get written,\n\nor doing too much in one patch set?","commit_id":"01e78126ee1f6ee94e7a58027126c01ef314355f"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"ba645a5c08e04e3bff37febfb351174e9315be56","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            kubectl logs $NAME -c $CON --namespace $NAMESPACE \u003e \\"},{"line_number":63,"context_line":"                $WORKSPACE/logs/pods/$NAMESPACE-$NAME-$CON.txt"},{"line_number":64,"context_line":"        done"},{"line_number":65,"context_line":"    done"},{"line_number":66,"context_line":"    sudo iptables-save \u003e $WORKSPACE/logs/iptables.txt"},{"line_number":67,"context_line":"    sudo ip a \u003e $WORKSPACE/logs/ip.txt"},{"line_number":68,"context_line":"    sudo route -n \u003e $WORKSPACE/logs/routes.txt"}],"source_content_type":"text/x-sh","patch_set":18,"id":"3a98d1f4_c3a4614c","line":65,"in_reply_to":"3a98d1f4_a5459d43","updated":"2016-10-03 23:20:23.000000000","message":"patches with checks is better.  Doing too much in one patchset is also bad (because big changes get little review action).  This patch doesn\u0027t fall into the later category.","commit_id":"01e78126ee1f6ee94e7a58027126c01ef314355f"}]}