)]}'
{"helm/all_values.yaml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"d43e629bf67a68b7d3e7b4f1c827f8cde9cac517","unresolved":false,"context_lines":[{"line_number":1,"context_line":"common:"},{"line_number":2,"context_line":"        selector_key: kolla_controller"},{"line_number":3,"context_line":"        selector_value: \"true\""},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"5a74a57a_a81c76c2","line":1,"updated":"2016-11-29 21:17:14.000000000","message":"yes!","commit_id":"8de0fcb817a3c479fb28b9efab73e2e7374581e1"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"d43e629bf67a68b7d3e7b4f1c827f8cde9cac517","unresolved":false,"context_lines":[{"line_number":1,"context_line":"common:"},{"line_number":2,"context_line":"        selector_key: kolla_controller"},{"line_number":3,"context_line":"        selector_value: \"true\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"        docker_registry: docker.io"},{"line_number":6,"context_line":"        docker_namespace: kolla"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"5a74a57a_0859ea8e","line":3,"updated":"2016-11-29 21:17:14.000000000","message":"will this be exported via helm install foo --set common.selector_value?","commit_id":"8de0fcb817a3c479fb28b9efab73e2e7374581e1"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"e9d5173893537e6a6bfee740137a2a4615bfa57e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"common:"},{"line_number":2,"context_line":"        selector_key: kolla_controller"},{"line_number":3,"context_line":"        selector_value: \"true\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"        docker_registry: docker.io"},{"line_number":6,"context_line":"        docker_namespace: kolla"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"5a74a57a_83c07c7e","line":3,"in_reply_to":"5a74a57a_0859ea8e","updated":"2016-11-29 21:47:34.000000000","message":"@Kevin. as PoC could you add selector_key and selector_value to neutron-l3-agent to see if this value will take precedence over the ones defined here.","commit_id":"8de0fcb817a3c479fb28b9efab73e2e7374581e1"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"d43e629bf67a68b7d3e7b4f1c827f8cde9cac517","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        fluentd_image_tag: 3.0.1"},{"line_number":22,"context_line":"        kolla_toolbox_image_tag: 3.0.1"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"neutron-openvswitch-agent:"},{"line_number":25,"context_line":"        type: network"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        #Image overrides"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"5a74a57a_c877f206","line":24,"updated":"2016-11-29 21:17:14.000000000","message":"yes!","commit_id":"8de0fcb817a3c479fb28b9efab73e2e7374581e1"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"d43e629bf67a68b7d3e7b4f1c827f8cde9cac517","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        tunnel_interface: eth0"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"neutron-l3-agent:"},{"line_number":36,"context_line":"        type: network"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        #Image overrides"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"5a74a57a_0882cac8","line":35,"updated":"2016-11-29 21:17:14.000000000","message":"yes!","commit_id":"8de0fcb817a3c479fb28b9efab73e2e7374581e1"}],"helm/openstack-neutron/templates/_l3_agent_daemonset.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"aeff16650658dcbe6db98a07ae034e3b5dfa1542","unresolved":false,"context_lines":[{"line_number":98,"context_line":"          volumeMounts:"},{"line_number":99,"context_line":"{{- include \"common_volume_mounts\" $env | indent 12 }}"},{"line_number":100,"context_line":"            - mountPath: {{ .Values.container_config_directory }}"},{"line_number":101,"context_line":"              name: pod-main-config"},{"line_number":102,"context_line":"            - mountPath: /var/lib/neutron/kolla/"},{"line_number":103,"context_line":"              name: neutron-metadata-socket"},{"line_number":104,"context_line":"            - mountPath: /var/run"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9a629dbe_6d8e2a2f","line":101,"updated":"2016-11-11 10:43:15.000000000","message":"is it possible to make the config a read-only mount?","commit_id":"a44feac7bd2fc2303d440c3009740bba6bfadf72"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"ea77f80f61a076af72b0f307a6fbe971189db2c7","unresolved":false,"context_lines":[{"line_number":98,"context_line":"          volumeMounts:"},{"line_number":99,"context_line":"{{- include \"common_volume_mounts\" $env | indent 12 }}"},{"line_number":100,"context_line":"            - mountPath: {{ .Values.container_config_directory }}"},{"line_number":101,"context_line":"              name: pod-main-config"},{"line_number":102,"context_line":"            - mountPath: /var/lib/neutron/kolla/"},{"line_number":103,"context_line":"              name: neutron-metadata-socket"},{"line_number":104,"context_line":"            - mountPath: /var/run"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9a629dbe_590a048b","line":101,"in_reply_to":"9a629dbe_6d8e2a2f","updated":"2016-11-11 13:00:39.000000000","message":"Probably. Should have a blueprint for that though. As all the templates could use that.","commit_id":"a44feac7bd2fc2303d440c3009740bba6bfadf72"}],"helm/src/neutron/templates/l3_agent_daemonset.yaml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"4208c41cf407806b6c864512d507142d08ab2e07","unresolved":false,"context_lines":[{"line_number":104,"context_line":"              name: host-run"},{"line_number":105,"context_line":"            - mountPath: /run/netns/"},{"line_number":106,"context_line":"              name: host-run-netns"},{"line_number":107,"context_line":"              # shared: true # This seems not support in K8s yet :("},{"line_number":108,"context_line":"          env:"},{"line_number":109,"context_line":"            - name: KOLLA_CONFIG_STRATEGY"},{"line_number":110,"context_line":"              value: COPY_ONCE"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_4a4d436b","line":107,"updated":"2016-11-24 18:57:25.000000000","message":"what is the impact of the lack of shared here?","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a59538f44a12f1edbf71ce57e7a5990bceada522","unresolved":false,"context_lines":[{"line_number":104,"context_line":"              name: host-run"},{"line_number":105,"context_line":"            - mountPath: /run/netns/"},{"line_number":106,"context_line":"              name: host-run-netns"},{"line_number":107,"context_line":"              # shared: true # This seems not support in K8s yet :("},{"line_number":108,"context_line":"          env:"},{"line_number":109,"context_line":"            - name: KOLLA_CONFIG_STRATEGY"},{"line_number":110,"context_line":"              value: COPY_ONCE"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_aa7aee85","line":107,"in_reply_to":"5a74a57a_4a4d436b","updated":"2016-11-28 17:59:38.000000000","message":"not really a specific issue to the helm review, as the non helm templates have this issue, but...\n\nI believe this will cause issues if the container is ever restarted.\n\nk8s has 2 reviews up to try and solve this. am really hoping for a 1.5 fix but I\u0027m becoming sceptical it will make it. :/","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"f91d02363fb5e1f352c54827f57df0776008cb9a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"              name: host-run"},{"line_number":105,"context_line":"            - mountPath: /run/netns/"},{"line_number":106,"context_line":"              name: host-run-netns"},{"line_number":107,"context_line":"              # shared: true # This seems not support in K8s yet :("},{"line_number":108,"context_line":"          env:"},{"line_number":109,"context_line":"            - name: KOLLA_CONFIG_STRATEGY"},{"line_number":110,"context_line":"              value: COPY_ONCE"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_de9e0b62","line":107,"in_reply_to":"5a74a57a_aa7aee85","updated":"2016-11-28 20:03:00.000000000","message":"thats ok - if not in 1.5, sounds like there is enough action to make it happen for 1.6.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"4208c41cf407806b6c864512d507142d08ab2e07","unresolved":false,"context_lines":[{"line_number":108,"context_line":"          env:"},{"line_number":109,"context_line":"            - name: KOLLA_CONFIG_STRATEGY"},{"line_number":110,"context_line":"              value: COPY_ONCE"},{"line_number":111,"context_line":"{{- include \"common_containers\" . | indent 8 }}"},{"line_number":112,"context_line":"      volumes:"},{"line_number":113,"context_line":"{{- include \"common_volumes\" . | indent 8 }}"},{"line_number":114,"context_line":"        - name: pod-main-config"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_0a98abbf","line":111,"updated":"2016-11-24 18:57:25.000000000","message":"somewhere in here I think we are missing the init container for entrypoint as per spec.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a59538f44a12f1edbf71ce57e7a5990bceada522","unresolved":false,"context_lines":[{"line_number":108,"context_line":"          env:"},{"line_number":109,"context_line":"            - name: KOLLA_CONFIG_STRATEGY"},{"line_number":110,"context_line":"              value: COPY_ONCE"},{"line_number":111,"context_line":"{{- include \"common_containers\" . | indent 8 }}"},{"line_number":112,"context_line":"      volumes:"},{"line_number":113,"context_line":"{{- include \"common_volumes\" . | indent 8 }}"},{"line_number":114,"context_line":"        - name: pod-main-config"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_caa48a09","line":111,"in_reply_to":"5a74a57a_0a98abbf","updated":"2016-11-28 17:59:38.000000000","message":"Right. That is a whole nother patch set. this is just converting the existing templates to helm. entrypoint support should be a second patchset.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"f91d02363fb5e1f352c54827f57df0776008cb9a","unresolved":false,"context_lines":[{"line_number":108,"context_line":"          env:"},{"line_number":109,"context_line":"            - name: KOLLA_CONFIG_STRATEGY"},{"line_number":110,"context_line":"              value: COPY_ONCE"},{"line_number":111,"context_line":"{{- include \"common_containers\" . | indent 8 }}"},{"line_number":112,"context_line":"      volumes:"},{"line_number":113,"context_line":"{{- include \"common_volumes\" . | indent 8 }}"},{"line_number":114,"context_line":"        - name: pod-main-config"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_7e84170a","line":111,"in_reply_to":"5a74a57a_caa48a09","updated":"2016-11-28 20:03:00.000000000","message":"wfm.  We have a blueprint dedicated to this - I\u0027d like to see that make it in shortly after whatever solution we choose is merged.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"}],"helm/src/neutron/templates/openvswitch_agent_daemonset.yaml":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3a6c769beb832d8a4ff6942ac48cc74024f09bbf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- define \"neutron-openvswitch-agent\" }}"},{"line_number":2,"context_line":"{{- $restype :\u003d .Values.type }}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{{- $openvswitchAgentImageBuilt :\u003d printf \"%s/%s/%s-%s-neutron-openvswitch-agent:%s\" .Values.docker_registry .Values.docker_namespace .Values.kolla_base_distro .Values.kolla_install_type .Values.openvswitch_agent_image_tag }}"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"7a77a97e_f2d20c5b","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":41},"updated":"2016-11-18 18:57:50.000000000","message":"@Kevin, could you elaborate why you defined this template as \"named\", is it going to be included in some other template?","commit_id":"fb9cb63f95f741fbee021d51bfd085977cc1f097"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"4208c41cf407806b6c864512d507142d08ab2e07","unresolved":false,"context_lines":[{"line_number":11,"context_line":"apiVersion: extensions/v1beta1"},{"line_number":12,"context_line":"kind: DaemonSet"},{"line_number":13,"context_line":"metadata:"},{"line_number":14,"context_line":"  name: neutron-openvswitch-agent-{{ $restype }}"},{"line_number":15,"context_line":"  labels:"},{"line_number":16,"context_line":"    component: neutron"},{"line_number":17,"context_line":"    system: openvswitch-agent-{{ $restype }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_272202ba","line":14,"updated":"2016-11-24 18:57:25.000000000","message":"Is this to deploy each of the agents separately via Values.type?  If so, What is the downside of just deploying all the agents in one go?","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a59538f44a12f1edbf71ce57e7a5990bceada522","unresolved":false,"context_lines":[{"line_number":11,"context_line":"apiVersion: extensions/v1beta1"},{"line_number":12,"context_line":"kind: DaemonSet"},{"line_number":13,"context_line":"metadata:"},{"line_number":14,"context_line":"  name: neutron-openvswitch-agent-{{ $restype }}"},{"line_number":15,"context_line":"  labels:"},{"line_number":16,"context_line":"    component: neutron"},{"line_number":17,"context_line":"    system: openvswitch-agent-{{ $restype }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_cac9eaad","line":14,"in_reply_to":"5a74a57a_272202ba","updated":"2016-11-28 17:59:38.000000000","message":"It is to support multiple instances.\n\nhelm install neutron-openvswitch-agent-compute\nhelm install neutron-openvswitch-agent-network\n\nFor example, for the l3 agent in dvr mode, you need compute and network agents that have different config params for each.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"f91d02363fb5e1f352c54827f57df0776008cb9a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"apiVersion: extensions/v1beta1"},{"line_number":12,"context_line":"kind: DaemonSet"},{"line_number":13,"context_line":"metadata:"},{"line_number":14,"context_line":"  name: neutron-openvswitch-agent-{{ $restype }}"},{"line_number":15,"context_line":"  labels:"},{"line_number":16,"context_line":"    component: neutron"},{"line_number":17,"context_line":"    system: openvswitch-agent-{{ $restype }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_3ebc5fba","line":14,"in_reply_to":"5a74a57a_cac9eaad","updated":"2016-11-28 20:03:00.000000000","message":"thanks for the explanation.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"4208c41cf407806b6c864512d507142d08ab2e07","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                  \"/bin/sh\","},{"line_number":32,"context_line":"                  \"-c\","},{"line_number":33,"context_line":"                  \"cp -a /srv/configmap/..data/* /srv/pod-main-config/;"},{"line_number":34,"context_line":"                  TUNNEL_INTERFACE\u003d{{ .Values.tunnel_interface }};"},{"line_number":35,"context_line":"                  F\u003d/var/lib/kolla-kubernetes/neutron-openvswitch-agent/tunnel_interface;"},{"line_number":36,"context_line":"                  [ -f $F ] \u0026\u0026 TUNNEL_INTERFACE\u003d$(\u003c$F);"},{"line_number":37,"context_line":"                  IP\u003d$(ip addr list \\\"$TUNNEL_INTERFACE\\\" | grep \u0027\u0027inet \u0027\u0027 |cut -d\u0027\u0027 \u0027\u0027 -f6|cut -d/ -f1);"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_27ada231","line":34,"updated":"2016-11-24 18:57:25.000000000","message":"wouldn\u0027t tunnel_interface come from the configmap?  Having OpenStack config in two places is not really all that ideal.  Is this triggered by your need to have OVS run outside of Kubernetes itself?","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"f91d02363fb5e1f352c54827f57df0776008cb9a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                  \"/bin/sh\","},{"line_number":32,"context_line":"                  \"-c\","},{"line_number":33,"context_line":"                  \"cp -a /srv/configmap/..data/* /srv/pod-main-config/;"},{"line_number":34,"context_line":"                  TUNNEL_INTERFACE\u003d{{ .Values.tunnel_interface }};"},{"line_number":35,"context_line":"                  F\u003d/var/lib/kolla-kubernetes/neutron-openvswitch-agent/tunnel_interface;"},{"line_number":36,"context_line":"                  [ -f $F ] \u0026\u0026 TUNNEL_INTERFACE\u003d$(\u003c$F);"},{"line_number":37,"context_line":"                  IP\u003d$(ip addr list \\\"$TUNNEL_INTERFACE\\\" | grep \u0027\u0027inet \u0027\u0027 |cut -d\u0027\u0027 \u0027\u0027 -f6|cut -d/ -f1);"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_bec86f56","line":34,"in_reply_to":"5a74a57a_0a76826f","updated":"2016-11-28 20:03:00.000000000","message":"ok - how we handle this is tech debt bugs - where we file a bug and say \"Tech Debt: XYZ should be passed as a configmap\".","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a59538f44a12f1edbf71ce57e7a5990bceada522","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                  \"/bin/sh\","},{"line_number":32,"context_line":"                  \"-c\","},{"line_number":33,"context_line":"                  \"cp -a /srv/configmap/..data/* /srv/pod-main-config/;"},{"line_number":34,"context_line":"                  TUNNEL_INTERFACE\u003d{{ .Values.tunnel_interface }};"},{"line_number":35,"context_line":"                  F\u003d/var/lib/kolla-kubernetes/neutron-openvswitch-agent/tunnel_interface;"},{"line_number":36,"context_line":"                  [ -f $F ] \u0026\u0026 TUNNEL_INTERFACE\u003d$(\u003c$F);"},{"line_number":37,"context_line":"                  IP\u003d$(ip addr list \\\"$TUNNEL_INTERFACE\\\" | grep \u0027\u0027inet \u0027\u0027 |cut -d\u0027\u0027 \u0027\u0027 -f6|cut -d/ -f1);"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_0a76826f","line":34,"in_reply_to":"5a74a57a_27ada231","updated":"2016-11-28 17:59:38.000000000","message":"Hmm... Yes, I think this could be passed through a configmap. But, I\u0027m not changing logic in this review, only converting from jinja to gotl.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"4208c41cf407806b6c864512d507142d08ab2e07","unresolved":false,"context_lines":[{"line_number":64,"context_line":"              \"command\": ["},{"line_number":65,"context_line":"                  \"/bin/sh\","},{"line_number":66,"context_line":"                  \"-c\","},{"line_number":67,"context_line":"                  \"chown --recursive neutron.kolla /var/log/kolla;\""},{"line_number":68,"context_line":"              ],"},{"line_number":69,"context_line":"              \"volumeMounts\": ["},{"line_number":70,"context_line":"                  {"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_6774fafc","line":67,"updated":"2016-11-24 18:57:25.000000000","message":"the config.json at present does this same thing.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"f91d02363fb5e1f352c54827f57df0776008cb9a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"              \"command\": ["},{"line_number":65,"context_line":"                  \"/bin/sh\","},{"line_number":66,"context_line":"                  \"-c\","},{"line_number":67,"context_line":"                  \"chown --recursive neutron.kolla /var/log/kolla;\""},{"line_number":68,"context_line":"              ],"},{"line_number":69,"context_line":"              \"volumeMounts\": ["},{"line_number":70,"context_line":"                  {"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_becf8f54","line":67,"in_reply_to":"5a74a57a_0a24c25b","updated":"2016-11-28 20:03:00.000000000","message":"I\u0027m struggling to understand how it runs as the wrong user.  the containers use sudo to chown the files so chown runs in the root context.  Do you have evidence in terms of busted execution?\n\nI think it is unwise to duplicate the functionality of the container security model within the helm charts themselves.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a59538f44a12f1edbf71ce57e7a5990bceada522","unresolved":false,"context_lines":[{"line_number":64,"context_line":"              \"command\": ["},{"line_number":65,"context_line":"                  \"/bin/sh\","},{"line_number":66,"context_line":"                  \"-c\","},{"line_number":67,"context_line":"                  \"chown --recursive neutron.kolla /var/log/kolla;\""},{"line_number":68,"context_line":"              ],"},{"line_number":69,"context_line":"              \"volumeMounts\": ["},{"line_number":70,"context_line":"                  {"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_0a24c25b","line":67,"in_reply_to":"5a74a57a_6774fafc","updated":"2016-11-28 17:59:38.000000000","message":"It fails, as its running as the wrong user. This runs it as root, so it has permission to do the chown.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"0d729f1264929162ad923149a0da593ebca103b8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"              \"command\": ["},{"line_number":65,"context_line":"                  \"/bin/sh\","},{"line_number":66,"context_line":"                  \"-c\","},{"line_number":67,"context_line":"                  \"chown --recursive neutron.kolla /var/log/kolla;\""},{"line_number":68,"context_line":"              ],"},{"line_number":69,"context_line":"              \"volumeMounts\": ["},{"line_number":70,"context_line":"                  {"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_f1620c3d","line":67,"in_reply_to":"5a74a57a_becf8f54","updated":"2016-11-29 04:21:03.000000000","message":"not sure. but it consistently failed until we did this. been this way for a while. now that we have unit tests though, it will be much easier to remove and retest.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"4208c41cf407806b6c864512d507142d08ab2e07","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            privileged: true"},{"line_number":87,"context_line":"          env:"},{"line_number":88,"context_line":"            - name: KOLLA_CONFIG_STRATEGY"},{"line_number":89,"context_line":"              value: COPY_ONCE"},{"line_number":90,"context_line":"          volumeMounts:"},{"line_number":91,"context_line":"{{- include \"common_volume_mounts\" $env | indent 12 }}"},{"line_number":92,"context_line":"            - mountPath: {{ .Values.container_config_directory }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_a71612a5","line":89,"updated":"2016-11-24 18:57:25.000000000","message":"does COPY_ONCE vs COPY_ALWAYS make any difference here?  The reason we have COPY_ONCE is to preserve immutability and provide a single source of truth for configuration of containers.  The reason we have COPY_ALWAYS is to tradeoff immutability for the ability for operators to jerk around and hand-modify config files and bounce the service via docker stop docker start.  My (limited) understanding of kubernetes at this point is that these pods essentially bounce pods s a warm blooded operator would do.   If kubernetes bounces the pods, I don\u0027t think COPY_ALWAYS has any usage here.  Is that accurate?","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a59538f44a12f1edbf71ce57e7a5990bceada522","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            privileged: true"},{"line_number":87,"context_line":"          env:"},{"line_number":88,"context_line":"            - name: KOLLA_CONFIG_STRATEGY"},{"line_number":89,"context_line":"              value: COPY_ONCE"},{"line_number":90,"context_line":"          volumeMounts:"},{"line_number":91,"context_line":"{{- include \"common_volume_mounts\" $env | indent 12 }}"},{"line_number":92,"context_line":"            - mountPath: {{ .Values.container_config_directory }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_eab6a6f7","line":89,"in_reply_to":"5a74a57a_a71612a5","updated":"2016-11-28 17:59:38.000000000","message":"Thats what I was thinking. If your using k8s to do the orchestration, COPY_ONCE should do the right thing. I think if you bounce the pod, k8s rebuilds it anyway, so COPY_ALWAYS wouldn\u0027t work anyway in that case.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"f91d02363fb5e1f352c54827f57df0776008cb9a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            privileged: true"},{"line_number":87,"context_line":"          env:"},{"line_number":88,"context_line":"            - name: KOLLA_CONFIG_STRATEGY"},{"line_number":89,"context_line":"              value: COPY_ONCE"},{"line_number":90,"context_line":"          volumeMounts:"},{"line_number":91,"context_line":"{{- include \"common_volume_mounts\" $env | indent 12 }}"},{"line_number":92,"context_line":"            - mountPath: {{ .Values.container_config_directory }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_7e009766","line":89,"in_reply_to":"5a74a57a_eab6a6f7","updated":"2016-11-28 20:03:00.000000000","message":"sweet so thats decided :)","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"4208c41cf407806b6c864512d507142d08ab2e07","unresolved":false,"context_lines":[{"line_number":132,"context_line":"#        - name: NEUTRON_INTERFACE"},{"line_number":133,"context_line":"#          value: FIXME{ neutron_external_interface }"},{"line_number":134,"context_line":"      volumes:"},{"line_number":135,"context_line":"{{- include \"common_volumes\" . | indent 8 }}"},{"line_number":136,"context_line":"        - name: neutron-openvswitch-agent-configmap"},{"line_number":137,"context_line":"          configMap:"},{"line_number":138,"context_line":"            name: neutron-openvswitch-agent"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_c4106c04","line":135,"updated":"2016-11-24 18:57:25.000000000","message":"I like that common things are placed in one location such that they must not be copied all over the place.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"4208c41cf407806b6c864512d507142d08ab2e07","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            items:"},{"line_number":140,"context_line":"            - key: neutron.conf"},{"line_number":141,"context_line":"              path: neutron.conf"},{"line_number":142,"context_line":"            - key: config.json"},{"line_number":143,"context_line":"              path: config.json"},{"line_number":144,"context_line":"            - key: ml2-conf.ini"},{"line_number":145,"context_line":"              path: ml2_conf.ini"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_e4ce48b3","line":142,"updated":"2016-11-24 18:57:25.000000000","message":"nice :)","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"4208c41cf407806b6c864512d507142d08ab2e07","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            - key: ml2-conf.ini"},{"line_number":145,"context_line":"              path: ml2_conf.ini"},{"line_number":146,"context_line":"        - name: pod-main-config"},{"line_number":147,"context_line":"          emptyDir: {}"},{"line_number":148,"context_line":"# NOTE: (sbezverk) Linux bridge will be moved to its own file at the time of development"},{"line_number":149,"context_line":"# keeping it here just for future reference."},{"line_number":150,"context_line":"#        - name: neutron-linuxbridge-agent-config"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_24e4c00b","line":147,"updated":"2016-11-24 18:57:25.000000000","message":"I assume this is some kind of local store to the pods that ends up storing all these files for usage by the pod.  Could you confirm?","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a59538f44a12f1edbf71ce57e7a5990bceada522","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            - key: ml2-conf.ini"},{"line_number":145,"context_line":"              path: ml2_conf.ini"},{"line_number":146,"context_line":"        - name: pod-main-config"},{"line_number":147,"context_line":"          emptyDir: {}"},{"line_number":148,"context_line":"# NOTE: (sbezverk) Linux bridge will be moved to its own file at the time of development"},{"line_number":149,"context_line":"# keeping it here just for future reference."},{"line_number":150,"context_line":"#        - name: neutron-linuxbridge-agent-config"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_ea84e60b","line":147,"in_reply_to":"5a74a57a_24e4c00b","updated":"2016-11-28 17:59:38.000000000","message":"confirmed. emptyDir\u0027s are temporary directories created when the pod is created, and deleted when the pod is terminated. Guaranteed to exist between those events without change by k8s. So great for passing things between containers in the same pod.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"f91d02363fb5e1f352c54827f57df0776008cb9a","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            - key: ml2-conf.ini"},{"line_number":145,"context_line":"              path: ml2_conf.ini"},{"line_number":146,"context_line":"        - name: pod-main-config"},{"line_number":147,"context_line":"          emptyDir: {}"},{"line_number":148,"context_line":"# NOTE: (sbezverk) Linux bridge will be moved to its own file at the time of development"},{"line_number":149,"context_line":"# keeping it here just for future reference."},{"line_number":150,"context_line":"#        - name: neutron-linuxbridge-agent-config"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_5e34bb48","line":147,"in_reply_to":"5a74a57a_ea84e60b","updated":"2016-11-28 20:03:00.000000000","message":"nice thanks for bringing me up to speed.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"4208c41cf407806b6c864512d507142d08ab2e07","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            path: /lib/modules"},{"line_number":165,"context_line":"        - name: host-var-lib-kk"},{"line_number":166,"context_line":"          hostPath:"},{"line_number":167,"context_line":"            path: /var/lib/kolla-kubernetes"},{"line_number":168,"context_line":"{{- end }}"},{"line_number":169,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_3574eccd","line":167,"updated":"2016-11-24 18:57:25.000000000","message":"somewhere in here should be the init container for entrypoint as per spec.  The Kolla community is either going to use this as a template to stamp out charts or someone elses template to stamp out charts, so might as well tidy that part up :)","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"f91d02363fb5e1f352c54827f57df0776008cb9a","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            path: /lib/modules"},{"line_number":165,"context_line":"        - name: host-var-lib-kk"},{"line_number":166,"context_line":"          hostPath:"},{"line_number":167,"context_line":"            path: /var/lib/kolla-kubernetes"},{"line_number":168,"context_line":"{{- end }}"},{"line_number":169,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_be3dcf2c","line":167,"in_reply_to":"5a74a57a_0ace8262","updated":"2016-11-28 20:03:00.000000000","message":"wfm - we have a blueprint for that already in launchpad.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a59538f44a12f1edbf71ce57e7a5990bceada522","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            path: /lib/modules"},{"line_number":165,"context_line":"        - name: host-var-lib-kk"},{"line_number":166,"context_line":"          hostPath:"},{"line_number":167,"context_line":"            path: /var/lib/kolla-kubernetes"},{"line_number":168,"context_line":"{{- end }}"},{"line_number":169,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_0ace8262","line":167,"in_reply_to":"5a74a57a_3574eccd","updated":"2016-11-28 17:59:38.000000000","message":"I think we should do that in a different patch set. Just jinja2 -\u003e gotl will be a lot of churn and difficult to review, so if we do it in two stages, it should merge quicker.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"}],"helm/src/neutron/values/openvswitch_agent_daemonset.yaml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"4208c41cf407806b6c864512d507142d08ab2e07","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"logger_configmap_name: neutron-openvswitch-agent-logger"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"tunnel_interface: eth0"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_8a383ba2","line":9,"updated":"2016-11-24 18:57:25.000000000","message":"when would this not be eth0?","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"f91d02363fb5e1f352c54827f57df0776008cb9a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"logger_configmap_name: neutron-openvswitch-agent-logger"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"tunnel_interface: eth0"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_5e0bdb7c","line":9,"in_reply_to":"5a74a57a_4576ad3e","updated":"2016-11-28 20:03:00.000000000","message":"wfm.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a59538f44a12f1edbf71ce57e7a5990bceada522","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"logger_configmap_name: neutron-openvswitch-agent-logger"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"tunnel_interface: eth0"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_aa7f4ede","line":9,"in_reply_to":"5a74a57a_8a383ba2","updated":"2016-11-28 17:59:38.000000000","message":"redhat systems don\u0027t use eth* at all anymore.\n\nOn one of my systems, I have a 40gig interface (with multiple vlans) that comes in tunked, then goes to an openvswitch which I untag to a virtual port int-tun which I then would specify here.\n\nI plan on writing up some example architecture documents at some point which would cover this use case.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"8ecb67d983f3e2ce708448be08dd6067730cd072","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"logger_configmap_name: neutron-openvswitch-agent-logger"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"tunnel_interface: eth0"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5a74a57a_4576ad3e","line":9,"in_reply_to":"5a74a57a_aa7f4ede","updated":"2016-11-28 18:14:53.000000000","message":"As Kevins pointed out there are several cases where we need this to be configurable: I have a deployment running with 4nics, and run one of them (\u0027enp5s0\u0027) as a dedicated tunnel interface.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"}],"tests/bin/ceph_workflow.sh":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"e02567c8a7d3d5d26a222d8cf47ae591a17d7772","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"kollakube res create pod neutron-dhcp-agent neutron-metadata-agent-network"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"helm install kolla/neutron-l3-agent --version 2.0.2-1 \\"},{"line_number":122,"context_line":"    --set enable_kube_logger\u003dfalse,type\u003dnetwork \\"},{"line_number":123,"context_line":"    --namespace kolla --name neutron-l3-agent-network"},{"line_number":124,"context_line":"helm install kolla/neutron-openvswitch-agent --version 2.0.2-1 \\"}],"source_content_type":"text/x-sh","patch_set":33,"id":"5a74a57a_8f67b6e9","line":121,"range":{"start_line":121,"start_character":13,"end_line":121,"end_character":35},"updated":"2016-11-30 02:41:11.000000000","message":"I think it is not correct location for charts, should be helm/microservices/neutron-l3-agent\nUnless it is specific to package deployment model","commit_id":"9533f80853177c1f07c895e365db3cacc9f0dfbf"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"fb1971c0f1193908b83aa918fecc52374a545f82","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"kollakube res create pod neutron-dhcp-agent neutron-metadata-agent-network"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"helm install kolla/neutron-l3-agent --version 2.0.2-1 \\"},{"line_number":122,"context_line":"    --set enable_kube_logger\u003dfalse,type\u003dnetwork \\"},{"line_number":123,"context_line":"    --namespace kolla --name neutron-l3-agent-network"},{"line_number":124,"context_line":"helm install kolla/neutron-openvswitch-agent --version 2.0.2-1 \\"}],"source_content_type":"text/x-sh","patch_set":33,"id":"5a74a57a_c5f0afcc","line":121,"range":{"start_line":121,"start_character":13,"end_line":121,"end_character":35},"in_reply_to":"5a74a57a_8f67b6e9","updated":"2016-11-30 04:24:19.000000000","message":"It could be that kfox is managing his own helm repository, but i agree. is there a \u0027kolla\u0027 helm repo we plan to create and maintain?","commit_id":"9533f80853177c1f07c895e365db3cacc9f0dfbf"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"e02567c8a7d3d5d26a222d8cf47ae591a17d7772","unresolved":false,"context_lines":[{"line_number":121,"context_line":"helm install kolla/neutron-l3-agent --version 2.0.2-1 \\"},{"line_number":122,"context_line":"    --set enable_kube_logger\u003dfalse,type\u003dnetwork \\"},{"line_number":123,"context_line":"    --namespace kolla --name neutron-l3-agent-network"},{"line_number":124,"context_line":"helm install kolla/neutron-openvswitch-agent --version 2.0.2-1 \\"},{"line_number":125,"context_line":"    --set enable_kube_logger\u003dfalse,type\u003dnetwork,tunnel_interface\u003ddocker0 \\"},{"line_number":126,"context_line":"    --namespace kolla --name neutron-openvswitch-agent-network"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-sh","patch_set":33,"id":"5a74a57a_cf61aed5","line":124,"range":{"start_line":124,"start_character":13,"end_line":124,"end_character":44},"updated":"2016-11-30 02:41:11.000000000","message":"same comment as abone","commit_id":"9533f80853177c1f07c895e365db3cacc9f0dfbf"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"fb1971c0f1193908b83aa918fecc52374a545f82","unresolved":false,"context_lines":[{"line_number":121,"context_line":"helm install kolla/neutron-l3-agent --version 2.0.2-1 \\"},{"line_number":122,"context_line":"    --set enable_kube_logger\u003dfalse,type\u003dnetwork \\"},{"line_number":123,"context_line":"    --namespace kolla --name neutron-l3-agent-network"},{"line_number":124,"context_line":"helm install kolla/neutron-openvswitch-agent --version 2.0.2-1 \\"},{"line_number":125,"context_line":"    --set enable_kube_logger\u003dfalse,type\u003dnetwork,tunnel_interface\u003ddocker0 \\"},{"line_number":126,"context_line":"    --namespace kolla --name neutron-openvswitch-agent-network"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-sh","patch_set":33,"id":"5a74a57a_e5edabf0","line":124,"range":{"start_line":124,"start_character":13,"end_line":124,"end_character":44},"in_reply_to":"5a74a57a_cf61aed5","updated":"2016-11-30 04:24:19.000000000","message":"same","commit_id":"9533f80853177c1f07c895e365db3cacc9f0dfbf"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"fb1971c0f1193908b83aa918fecc52374a545f82","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    create pod openvswitch-ovsdb-network openvswitch-vswitchd-network"},{"line_number":130,"context_line":"[ \"x$1\" \u003d\u003d \"xceph-multi\" ] \u0026\u0026 kollakube res \\"},{"line_number":131,"context_line":"    create pod openvswitch-ovsdb-compute openvswitch-vswitchd-compute \u0026\u0026 \\"},{"line_number":132,"context_line":"    helm install kolla/neutron-openvswitch-agent --version 2.0.2-1 \\"},{"line_number":133,"context_line":"        --set enable_kube_logger\u003dfalse,type\u003dcompute,selector_key\u003dkolla_compute,tunnel_interface\u003ddocker0 \\"},{"line_number":134,"context_line":"        --namespace kolla --name neutron-openvswitch-agent-compute"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-sh","patch_set":33,"id":"5a74a57a_65b8bbe6","line":132,"range":{"start_line":132,"start_character":17,"end_line":132,"end_character":48},"updated":"2016-11-30 04:24:19.000000000","message":"same as above","commit_id":"9533f80853177c1f07c895e365db3cacc9f0dfbf"}],"tools/build_packages.py":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"4208c41cf407806b6c864512d507142d08ab2e07","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def helm_build_package(repodir, srcdir):"},{"line_number":22,"context_line":"    command_line \u003d \"cd %s; helm package %s\" % (repodir, srcdir)"},{"line_number":23,"context_line":"    try:"},{"line_number":24,"context_line":"        res \u003d subprocess.check_output("},{"line_number":25,"context_line":"            command_line, shell\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_b562bcab","line":22,"updated":"2016-11-24 18:57:25.000000000","message":"why not just let helm build the charts?  Introducing a new build system for charts was necessary for Docker.  I guess I lack the detailed requirements that trigger the need to build packages with a wrapper around helm that does some black magic with our repository.  Could you fill me in?","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a59538f44a12f1edbf71ce57e7a5990bceada522","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def helm_build_package(repodir, srcdir):"},{"line_number":22,"context_line":"    command_line \u003d \"cd %s; helm package %s\" % (repodir, srcdir)"},{"line_number":23,"context_line":"    try:"},{"line_number":24,"context_line":"        res \u003d subprocess.check_output("},{"line_number":25,"context_line":"            command_line, shell\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_ead306d3","line":22,"in_reply_to":"5a74a57a_b562bcab","updated":"2016-11-28 17:59:38.000000000","message":"see my review on ps 8 here: https://review.openstack.org/#/c/401394/8\n\nGoes through some of the reasoning.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"8ecb67d983f3e2ce708448be08dd6067730cd072","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def helm_build_package(repodir, srcdir):"},{"line_number":22,"context_line":"    command_line \u003d \"cd %s; helm package %s\" % (repodir, srcdir)"},{"line_number":23,"context_line":"    try:"},{"line_number":24,"context_line":"        res \u003d subprocess.check_output("},{"line_number":25,"context_line":"            command_line, shell\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_8515259d","line":22,"in_reply_to":"5a74a57a_ead306d3","updated":"2016-11-28 18:14:53.000000000","message":"I\u0027ll also respond to the issues raised here in the ps kevin refers to.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"4208c41cf407806b6c864512d507142d08ab2e07","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    f.close()"},{"line_number":38,"context_line":"    f \u003d open(dest, \u0027w\u0027)"},{"line_number":39,"context_line":"    lines \u003d lines.replace(\u0027@NAME@\u0027, \"%s-%s\" % (package[\u0027name\u0027],"},{"line_number":40,"context_line":"                                               subpackage[\u0027name\u0027]))"},{"line_number":41,"context_line":"    f.write(lines)"},{"line_number":42,"context_line":"    f.close()"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_55e96813","line":40,"updated":"2016-11-24 18:57:25.000000000","message":"Not really keen on this.  The reason we introduced a build.py in the Kolla repo is because Docker lacked any type of templating at all.  We knew going in Docker wouldn\u0027t take templating.  I worked really hard to keep the scope of build.py to JUST templating, however, as you can see today build.py has spun a bit into a FrankenSystem.  Helm on the other hand doesn\u0027t have this problem - it does have a templating system.  Docker really blew it here.\n\nThe rationale I see in the review history is that upstream doesn\u0027t have the features we need.  Having trouble understanding that rationale sa it applies to this specific part.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a59538f44a12f1edbf71ce57e7a5990bceada522","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    f.close()"},{"line_number":38,"context_line":"    f \u003d open(dest, \u0027w\u0027)"},{"line_number":39,"context_line":"    lines \u003d lines.replace(\u0027@NAME@\u0027, \"%s-%s\" % (package[\u0027name\u0027],"},{"line_number":40,"context_line":"                                               subpackage[\u0027name\u0027]))"},{"line_number":41,"context_line":"    f.write(lines)"},{"line_number":42,"context_line":"    f.close()"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_6a8e16d1","line":40,"in_reply_to":"5a74a57a_55e96813","updated":"2016-11-28 17:59:38.000000000","message":"helm lacks templating of chart.yaml and variables.yaml. they are equally bad off as docker is. :/","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"f91d02363fb5e1f352c54827f57df0776008cb9a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    f.close()"},{"line_number":38,"context_line":"    f \u003d open(dest, \u0027w\u0027)"},{"line_number":39,"context_line":"    lines \u003d lines.replace(\u0027@NAME@\u0027, \"%s-%s\" % (package[\u0027name\u0027],"},{"line_number":40,"context_line":"                                               subpackage[\u0027name\u0027]))"},{"line_number":41,"context_line":"    f.write(lines)"},{"line_number":42,"context_line":"    f.close()"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_5e591b8d","line":40,"in_reply_to":"5a74a57a_6a8e16d1","updated":"2016-11-28 20:03:00.000000000","message":"the question is will helm take templating of these files if that is something needed?","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"4208c41cf407806b6c864512d507142d08ab2e07","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            trivial_template(os.path.join(srcdir, \u0027src\u0027, \u0027common_main.yaml\u0027),"},{"line_number":83,"context_line":"                             os.path.join(packagetemplatedir, template),"},{"line_number":84,"context_line":"                             package, subpackage)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            shutil.copy(os.path.join(srcdir, \u0027src\u0027, package[\u0027name\u0027],"},{"line_number":87,"context_line":"                                     \u0027templates\u0027, template),"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_55ca486e","line":84,"updated":"2016-11-24 18:57:25.000000000","message":"I tend to agree we need a common macro library.  Can this not be done some other way that doesn\u0027t involve a custom build system?  We should follow our upstream here (Helm) rather then invent a new Helm.  Docker\u0027s build system lacked complete flexibility and their engineers weren\u0027t listening to anybody.  It was my way or highway.\n\nIs your assertion here that helm has the same problem?","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a59538f44a12f1edbf71ce57e7a5990bceada522","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            trivial_template(os.path.join(srcdir, \u0027src\u0027, \u0027common_main.yaml\u0027),"},{"line_number":83,"context_line":"                             os.path.join(packagetemplatedir, template),"},{"line_number":84,"context_line":"                             package, subpackage)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            shutil.copy(os.path.join(srcdir, \u0027src\u0027, package[\u0027name\u0027],"},{"line_number":87,"context_line":"                                     \u0027templates\u0027, template),"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_eab86677","line":84,"in_reply_to":"5a74a57a_55ca486e","updated":"2016-11-28 17:59:38.000000000","message":"helm has the same problem.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"f91d02363fb5e1f352c54827f57df0776008cb9a","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            trivial_template(os.path.join(srcdir, \u0027src\u0027, \u0027common_main.yaml\u0027),"},{"line_number":83,"context_line":"                             os.path.join(packagetemplatedir, template),"},{"line_number":84,"context_line":"                             package, subpackage)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            shutil.copy(os.path.join(srcdir, \u0027src\u0027, package[\u0027name\u0027],"},{"line_number":87,"context_line":"                                     \u0027templates\u0027, template),"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_1e98831b","line":84,"in_reply_to":"5a74a57a_eab86677","updated":"2016-11-28 20:03:00.000000000","message":"looking at the issue trackers for helm, it looks like the upstream is responsive to requests for features.  Any evidence that its my way or highway with helm devs?  I did give it a good go to work with docker to template their systems, but they just wouldn\u0027t take it.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"4208c41cf407806b6c864512d507142d08ab2e07","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                                     \u0027values\u0027, template),"},{"line_number":91,"context_line":"                        os.path.join(packagedir, \u0027values.yaml\u0027))"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            f \u003d open(os.path.join(srcdir, \u0027src\u0027, \u0027common_values.yaml\u0027), \u0027r\u0027)"},{"line_number":94,"context_line":"            lines \u003d f.read()"},{"line_number":95,"context_line":"            f.close()"},{"line_number":96,"context_line":"            f \u003d open(os.path.join(packagedir, \u0027values.yaml\u0027), \u0027a\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_55f40885","line":93,"updated":"2016-11-24 18:57:25.000000000","message":"I\u0027m torn here - I see good things in the idea of a common_values.yaml.  From what I can see of the helm issue tracker the Helm upstream is actually listening, so we don\u0027t have the same problems we had with the Docker upstream around building packages.  I suspect this is done because common_values.yaml is not a thing that helm has.  I think they would take that in the medium term.  We don\u0027t have to keep things super tidy in terms of config duplication if Helm offers a way out.  Seems premature to judge that they wont take a common values concept.  If I were maintaining Helm, it is something i\u0027d take.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"f91d02363fb5e1f352c54827f57df0776008cb9a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                                     \u0027values\u0027, template),"},{"line_number":91,"context_line":"                        os.path.join(packagedir, \u0027values.yaml\u0027))"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            f \u003d open(os.path.join(srcdir, \u0027src\u0027, \u0027common_values.yaml\u0027), \u0027r\u0027)"},{"line_number":94,"context_line":"            lines \u003d f.read()"},{"line_number":95,"context_line":"            f.close()"},{"line_number":96,"context_line":"            f \u003d open(os.path.join(packagedir, \u0027values.yaml\u0027), \u0027a\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_fe52e733","line":93,"in_reply_to":"5a74a57a_0a7be2c1","updated":"2016-11-28 20:03:00.000000000","message":"Agree we want clean package api from user POV.  Does it need to happen right this moment?  Can possibly find some middle ground and focus some work upstream (in helm) to get these problems fixed.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a59538f44a12f1edbf71ce57e7a5990bceada522","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                                     \u0027values\u0027, template),"},{"line_number":91,"context_line":"                        os.path.join(packagedir, \u0027values.yaml\u0027))"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            f \u003d open(os.path.join(srcdir, \u0027src\u0027, \u0027common_values.yaml\u0027), \u0027r\u0027)"},{"line_number":94,"context_line":"            lines \u003d f.read()"},{"line_number":95,"context_line":"            f.close()"},{"line_number":96,"context_line":"            f \u003d open(os.path.join(packagedir, \u0027values.yaml\u0027), \u0027a\u0027)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_0a7be2c1","line":93,"in_reply_to":"5a74a57a_55f40885","updated":"2016-11-28 17:59:38.000000000","message":"What we want is a clean package api from the users perspective. that is our long term supported contract between us an operators. Once helm has all the features needed, we can just have helm build them.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"4208c41cf407806b6c864512d507142d08ab2e07","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            trivial_template(os.path.join(srcdir, \u0027src\u0027, \u0027common_chart.yaml\u0027),"},{"line_number":101,"context_line":"                             os.path.join(packagedir, \u0027Chart.yaml\u0027),"},{"line_number":102,"context_line":"                             package, subpackage)"},{"line_number":103,"context_line":"            helm_build_package(repodir, packagedir)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            # FIXME unhardcode version..."}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_754bc4b0","line":102,"updated":"2016-11-24 18:57:25.000000000","message":"If I parse this correctly this review takes a special snowflake Helm blob of stuff and produces a Helm standard blob of stuff.  I\u0027m struggling to understand why this is necessary.  This approach seems incorrect to me.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"f91d02363fb5e1f352c54827f57df0776008cb9a","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            trivial_template(os.path.join(srcdir, \u0027src\u0027, \u0027common_chart.yaml\u0027),"},{"line_number":101,"context_line":"                             os.path.join(packagedir, \u0027Chart.yaml\u0027),"},{"line_number":102,"context_line":"                             package, subpackage)"},{"line_number":103,"context_line":"            helm_build_package(repodir, packagedir)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            # FIXME unhardcode version..."}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_812274a1","line":102,"in_reply_to":"5a74a57a_2a5dfe46","updated":"2016-11-28 20:03:00.000000000","message":"Followup question why do we need to compose a single variables.yaml file from multiple?","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a59538f44a12f1edbf71ce57e7a5990bceada522","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            trivial_template(os.path.join(srcdir, \u0027src\u0027, \u0027common_chart.yaml\u0027),"},{"line_number":101,"context_line":"                             os.path.join(packagedir, \u0027Chart.yaml\u0027),"},{"line_number":102,"context_line":"                             package, subpackage)"},{"line_number":103,"context_line":"            helm_build_package(repodir, packagedir)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"            # FIXME unhardcode version..."}],"source_content_type":"text/x-python","patch_set":27,"id":"5a74a57a_2a5dfe46","line":102,"in_reply_to":"5a74a57a_754bc4b0","updated":"2016-11-28 17:59:38.000000000","message":"it build a single variables.yaml from multiple. Helm has no such functionality to template a variables.yaml file. :/\n\nThis could be done with jinja2 or gotol, but for the poc, simple append was sufficient.","commit_id":"14cee5f444f6c8471148a8c9387fec0632fa2508"}],"tools/helm_build_microservices.py":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"9d7ed31a069260a71953ef821203db809298bb12","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# limitations under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"import os"},{"line_number":15,"context_line":"import shutil"},{"line_number":16,"context_line":"import subprocess"},{"line_number":17,"context_line":"import sys"},{"line_number":18,"context_line":"import tempfile"}],"source_content_type":"text/x-python","patch_set":29,"id":"5a74a57a_a31c99c2","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":6},"updated":"2016-11-29 21:31:49.000000000","message":"unused\n\n2016-11-29 20:57:27.323284 | ./tools/helm_build_microservices.py:15:1: F401 \u0027shutil\u0027 imported but unused\n2016-11-29 20:57:27.323337 | import shutil\n2016-11-29 20:57:27.323347 | ^","commit_id":"8de0fcb817a3c479fb28b9efab73e2e7374581e1"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"9d7ed31a069260a71953ef821203db809298bb12","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import shutil"},{"line_number":16,"context_line":"import subprocess"},{"line_number":17,"context_line":"import sys"},{"line_number":18,"context_line":"import tempfile"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def helm_build_package(repodir, srcdir):"}],"source_content_type":"text/x-python","patch_set":29,"id":"5a74a57a_e37cd1ed","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":15},"updated":"2016-11-29 21:31:49.000000000","message":"unused \n\n2016-11-29 20:57:27.323371 | ./tools/helm_build_microservices.py:18:1: F401 \u0027tempfile\u0027 imported but unused\n2016-11-29 20:57:27.323381 | import tempfile","commit_id":"8de0fcb817a3c479fb28b9efab73e2e7374581e1"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"d43e629bf67a68b7d3e7b4f1c827f8cde9cac517","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    command_line \u003d \"cd %s; helm package %s\" % (repodir, srcdir)"},{"line_number":23,"context_line":"    try:"},{"line_number":24,"context_line":"        res \u003d subprocess.check_output("},{"line_number":25,"context_line":"            command_line, shell\u003dTrue,"},{"line_number":26,"context_line":"            executable\u003d\u0027/bin/bash\u0027)"},{"line_number":27,"context_line":"        res \u003d res.strip()  # strip whitespace"},{"line_number":28,"context_line":"        print(res)"}],"source_content_type":"text/x-python","patch_set":29,"id":"5a74a57a_88809a8d","line":25,"range":{"start_line":25,"start_character":32,"end_line":25,"end_character":36},"updated":"2016-11-29 21:17:14.000000000","message":"shell\u003dTrue is not secure - since its a dev tool not sure it really matters until we add a linting gate for bandit.","commit_id":"8de0fcb817a3c479fb28b9efab73e2e7374581e1"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"d43e629bf67a68b7d3e7b4f1c827f8cde9cac517","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    try:"},{"line_number":24,"context_line":"        res \u003d subprocess.check_output("},{"line_number":25,"context_line":"            command_line, shell\u003dTrue,"},{"line_number":26,"context_line":"            executable\u003d\u0027/bin/bash\u0027)"},{"line_number":27,"context_line":"        res \u003d res.strip()  # strip whitespace"},{"line_number":28,"context_line":"        print(res)"},{"line_number":29,"context_line":"    except subprocess.CalledProcessError as e:"}],"source_content_type":"text/x-python","patch_set":29,"id":"5a74a57a_28486687","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":35},"updated":"2016-11-29 21:17:14.000000000","message":"why /bin/bash?","commit_id":"8de0fcb817a3c479fb28b9efab73e2e7374581e1"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"d43e629bf67a68b7d3e7b4f1c827f8cde9cac517","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    microservices \u003d os.listdir(microdir)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    for package in [p for p in microservices if _isdir(microdir, p)]:"},{"line_number":53,"context_line":"        helm_build_package(repodir, os.path.join(microdir, package))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"},{"line_number":56,"context_line":"    sys.exit(main())"}],"source_content_type":"text/x-python","patch_set":29,"id":"5a74a57a_c34b555e","line":53,"updated":"2016-11-29 21:17:14.000000000","message":"what would be ideal here is to a build per package and a global build so devs don\u0027t end up checking in an unintended change.  We can change that in a followup.","commit_id":"8de0fcb817a3c479fb28b9efab73e2e7374581e1"}],"tools/helm_prebuild.py":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"9d7ed31a069260a71953ef821203db809298bb12","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import copy"},{"line_number":15,"context_line":"import os"},{"line_number":16,"context_line":"import shutil"},{"line_number":17,"context_line":"import subprocess"},{"line_number":18,"context_line":"import sys"},{"line_number":19,"context_line":"import yaml"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"5a74a57a_e8666e28","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":17},"updated":"2016-11-29 21:31:49.000000000","message":"unused\n\n2016-11-29 20:57:27.344615 | ./tools/helm_prebuild.py:17:1: F401 \u0027subprocess\u0027 imported but unused\n2016-11-29 20:57:27.344651 | import subprocess","commit_id":"8de0fcb817a3c479fb28b9efab73e2e7374581e1"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"9d7ed31a069260a71953ef821203db809298bb12","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    values \u003d yaml.load(open(os.path.join(srcdir, \"all_values.yaml\")))"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    for package in [p for p in microservices if _isdir(microdir, p)]:"},{"line_number":34,"context_line":"        shutil.copy(os.path.join(srcdir, \"kolla-common\", \"templates\", \"_common_lib.yaml\"),"},{"line_number":35,"context_line":"                    os.path.join(microdir, package, \"templates\", \"_common_lib.yaml\"))"},{"line_number":36,"context_line":"        pkg_values \u003d copy.deepcopy(values[\u0027common\u0027])"},{"line_number":37,"context_line":"        pkg_values.update(values[package])"},{"line_number":38,"context_line":"        f \u003d open(os.path.join(microdir, package, \"values.yaml\"), \"w\")"}],"source_content_type":"text/x-python","patch_set":29,"id":"5a74a57a_68ac1e36","line":35,"range":{"start_line":34,"start_character":2,"end_line":35,"end_character":85},"updated":"2016-11-29 21:31:49.000000000","message":"pep8 gates complaining about these lines being too long\n\n2016-11-29 20:57:27.344730 | ./tools/helm_prebuild.py:34:80: E501 line too long (90 \u003e 79 characters)\n2016-11-29 20:57:27.344768 |         shutil.copy(os.path.join(srcdir, \"kolla-common\", \"templates\", \"_common_lib.yaml\"),\n2016-11-29 20:57:27.344797 |                                                                                ^\n2016-11-29 20:57:27.344821 | ./tools/helm_prebuild.py:35:80: E501 line too long (85 \u003e 79 characters)\n2016-11-29 20:57:27.344845 |                     os.path.join(microdir, package, \"templates\", \"_common_lib.yaml\"))","commit_id":"8de0fcb817a3c479fb28b9efab73e2e7374581e1"}]}
