)]}'
{"helm/all_values.yaml":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"c30ae7753584ae57323f858c154df176dc5f8a10","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"nova-novncproxy:"},{"line_number":138,"context_line":"        image_tag: 2.0.2"},{"line_number":139,"context_line":"        replicas: 3"},{"line_number":140,"context_line":"        port: 6080"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a71b18c_33e3eda5","line":139,"range":{"start_line":139,"start_character":18,"end_line":139,"end_character":19},"updated":"2016-12-11 15:07:52.000000000","message":"I\u0027m not sure this will work in practice, without an ingress controller to maintain session affinity. Though we won\u0027t be able to test this in the gate. For now could we reduce this to a single replica?","commit_id":"42bf3ec423057b663380b94ffa5112e1a6333c9a"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"8d178a6424b2fc7d830ed923b64a7c5a216688ed","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"nova-novncproxy:"},{"line_number":138,"context_line":"        image_tag: 2.0.2"},{"line_number":139,"context_line":"        replicas: 3"},{"line_number":140,"context_line":"        port: 6080"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a71b18c_53530939","line":139,"range":{"start_line":139,"start_character":18,"end_line":139,"end_character":19},"in_reply_to":"3a71b18c_33e3eda5","updated":"2016-12-11 15:42:57.000000000","message":"yeah, we should drop it to 1 for until we\u0027re sure. but I think it does work? the one I know for sure I\u0027ve had trouble with having multiple is the console-auth.\n\nIt would be nice to figure out a way to get a gate test for novncproxy. Not going to require it in this ps. just thinking out loud. Maybe we could do something with selenium?","commit_id":"42bf3ec423057b663380b94ffa5112e1a6333c9a"},{"author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"change_message_id":"4fb915a3297036b4901c7ea6862a7c40e7f3cbf4","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"nova-novncproxy:"},{"line_number":138,"context_line":"        image_tag: 2.0.2"},{"line_number":139,"context_line":"        replicas: 3"},{"line_number":140,"context_line":"        port: 6080"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a71b18c_4c728a12","line":139,"range":{"start_line":139,"start_character":18,"end_line":139,"end_character":19},"in_reply_to":"3a71b18c_53530939","updated":"2016-12-11 21:51:59.000000000","message":"Done","commit_id":"42bf3ec423057b663380b94ffa5112e1a6333c9a"}],"helm/kolla-common/templates/_common_nova_control_pod.yaml":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"8d178a6424b2fc7d830ed923b64a7c5a216688ed","unresolved":false,"context_lines":[{"line_number":13,"context_line":"        pod.alpha.kubernetes.io/initialized: \"true\""},{"line_number":14,"context_line":"        pod.alpha.kubernetes.io/init-containers: \u0027["},{"line_number":15,"context_line":"          {"},{"line_number":16,"context_line":"              \"name\": \"initialize-{{ .Values.element_name }}\","},{"line_number":17,"context_line":"              \"image\": {{ include \"kolla_toolbox_image_full\" . | quote }},"},{"line_number":18,"context_line":"              \"command\": ["},{"line_number":19,"context_line":"                  \"/bin/sh\","}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a71b18c_565db713","line":16,"range":{"start_line":16,"start_character":23,"end_line":16,"end_character":60},"updated":"2016-12-11 15:42:57.000000000","message":"should we just rename this \"initialize-config\" ?\n\nI don\u0027t think there\u0027s much reason to make it unique in a pod. It makes it harder for the user to debug if it keeps changing too.","commit_id":"42bf3ec423057b663380b94ffa5112e1a6333c9a"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"8d178a6424b2fc7d830ed923b64a7c5a216688ed","unresolved":false,"context_lines":[{"line_number":15,"context_line":"          {"},{"line_number":16,"context_line":"              \"name\": \"initialize-{{ .Values.element_name }}\","},{"line_number":17,"context_line":"              \"image\": {{ include \"kolla_toolbox_image_full\" . | quote }},"},{"line_number":18,"context_line":"              \"command\": ["},{"line_number":19,"context_line":"                  \"/bin/sh\","},{"line_number":20,"context_line":"                  \"-ce\","},{"line_number":21,"context_line":"                  \"cp -a /config/..data/* /nova/; \"],"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a71b18c_96882f73","line":18,"updated":"2016-12-11 15:42:57.000000000","message":"I\u0027m seeing very very little nova specific in here. maybe we should rename the file _common_statefulset.yaml and remove the remaining traces of nova?","commit_id":"42bf3ec423057b663380b94ffa5112e1a6333c9a"},{"author":{"_account_id":24147,"name":"Mark Giles","email":"mark.giles@oracle.com","username":"mark-giles"},"change_message_id":"4fb915a3297036b4901c7ea6862a7c40e7f3cbf4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"          {"},{"line_number":16,"context_line":"              \"name\": \"initialize-{{ .Values.element_name }}\","},{"line_number":17,"context_line":"              \"image\": {{ include \"kolla_toolbox_image_full\" . | quote }},"},{"line_number":18,"context_line":"              \"command\": ["},{"line_number":19,"context_line":"                  \"/bin/sh\","},{"line_number":20,"context_line":"                  \"-ce\","},{"line_number":21,"context_line":"                  \"cp -a /config/..data/* /nova/; \"],"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a71b18c_ac579e58","line":18,"in_reply_to":"3a71b18c_96882f73","updated":"2016-12-11 21:51:59.000000000","message":"Good suggestions - applied all of the changes you suggested in this file.","commit_id":"42bf3ec423057b663380b94ffa5112e1a6333c9a"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"8d178a6424b2fc7d830ed923b64a7c5a216688ed","unresolved":false,"context_lines":[{"line_number":18,"context_line":"              \"command\": ["},{"line_number":19,"context_line":"                  \"/bin/sh\","},{"line_number":20,"context_line":"                  \"-ce\","},{"line_number":21,"context_line":"                  \"cp -a /config/..data/* /nova/; \"],"},{"line_number":22,"context_line":"              \"volumeMounts\": ["},{"line_number":23,"context_line":"                  {"},{"line_number":24,"context_line":"                      \"name\": \"{{ .Values.element_name }}-config\","}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a71b18c_d67e2769","line":21,"range":{"start_line":21,"start_character":43,"end_line":21,"end_character":47},"updated":"2016-12-11 15:42:57.000000000","message":"podconfig","commit_id":"42bf3ec423057b663380b94ffa5112e1a6333c9a"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"8d178a6424b2fc7d830ed923b64a7c5a216688ed","unresolved":false,"context_lines":[{"line_number":25,"context_line":"                      \"mountPath\": \"/config/\""},{"line_number":26,"context_line":"                  },"},{"line_number":27,"context_line":"                  {"},{"line_number":28,"context_line":"                      \"name\": \"nova-config\","},{"line_number":29,"context_line":"                      \"mountPath\": \"/nova/\""},{"line_number":30,"context_line":"                  }"},{"line_number":31,"context_line":"              ]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a71b18c_1695ff85","line":28,"range":{"start_line":28,"start_character":31,"end_line":28,"end_character":35},"updated":"2016-12-11 15:42:57.000000000","message":"pod","commit_id":"42bf3ec423057b663380b94ffa5112e1a6333c9a"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"8d178a6424b2fc7d830ed923b64a7c5a216688ed","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                  },"},{"line_number":27,"context_line":"                  {"},{"line_number":28,"context_line":"                      \"name\": \"nova-config\","},{"line_number":29,"context_line":"                      \"mountPath\": \"/nova/\""},{"line_number":30,"context_line":"                  }"},{"line_number":31,"context_line":"              ]"},{"line_number":32,"context_line":"          }"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a71b18c_f697a38d","line":29,"range":{"start_line":29,"start_character":37,"end_line":29,"end_character":41},"updated":"2016-12-11 15:42:57.000000000","message":"podconfig","commit_id":"42bf3ec423057b663380b94ffa5112e1a6333c9a"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"8d178a6424b2fc7d830ed923b64a7c5a216688ed","unresolved":false,"context_lines":[{"line_number":40,"context_line":"          volumeMounts:"},{"line_number":41,"context_line":"{{- include \"common_volume_mounts\" . | indent 12 }}"},{"line_number":42,"context_line":"            - mountPath: {{ .Values.container_config_directory }}"},{"line_number":43,"context_line":"              name: nova-config"},{"line_number":44,"context_line":"            - mountPath: /nova"},{"line_number":45,"context_line":"              name: nova-config"},{"line_number":46,"context_line":"          env:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a71b18c_76eab310","line":43,"range":{"start_line":43,"start_character":20,"end_line":43,"end_character":24},"updated":"2016-12-11 15:42:57.000000000","message":"pod","commit_id":"42bf3ec423057b663380b94ffa5112e1a6333c9a"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"8d178a6424b2fc7d830ed923b64a7c5a216688ed","unresolved":false,"context_lines":[{"line_number":41,"context_line":"{{- include \"common_volume_mounts\" . | indent 12 }}"},{"line_number":42,"context_line":"            - mountPath: {{ .Values.container_config_directory }}"},{"line_number":43,"context_line":"              name: nova-config"},{"line_number":44,"context_line":"            - mountPath: /nova"},{"line_number":45,"context_line":"              name: nova-config"},{"line_number":46,"context_line":"          env:"},{"line_number":47,"context_line":"{{- include \"common_env_vars\" . | indent 12 }}"},{"line_number":48,"context_line":"{{- if .privileged }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a71b18c_368e7b79","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":31},"updated":"2016-12-11 15:42:57.000000000","message":"this looks like dead code.","commit_id":"42bf3ec423057b663380b94ffa5112e1a6333c9a"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"8d178a6424b2fc7d830ed923b64a7c5a216688ed","unresolved":false,"context_lines":[{"line_number":54,"context_line":"{{- include \"common_volumes\" . | indent 8 }}"},{"line_number":55,"context_line":"        - name: {{ .Values.element_name }}-config"},{"line_number":56,"context_line":"          configMap:"},{"line_number":57,"context_line":"            name: nova-{{ .serviceType }}"},{"line_number":58,"context_line":"        - name: nova-config"},{"line_number":59,"context_line":"          emptyDir: {}"},{"line_number":60,"context_line":"metadata:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a71b18c_f6dec36b","line":57,"range":{"start_line":57,"start_character":18,"end_line":57,"end_character":22},"updated":"2016-12-11 15:42:57.000000000","message":"{{ .serviceName }}","commit_id":"42bf3ec423057b663380b94ffa5112e1a6333c9a"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"8d178a6424b2fc7d830ed923b64a7c5a216688ed","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        - name: {{ .Values.element_name }}-config"},{"line_number":56,"context_line":"          configMap:"},{"line_number":57,"context_line":"            name: nova-{{ .serviceType }}"},{"line_number":58,"context_line":"        - name: nova-config"},{"line_number":59,"context_line":"          emptyDir: {}"},{"line_number":60,"context_line":"metadata:"},{"line_number":61,"context_line":"   name: {{ .Values.element_name }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a71b18c_16dc1f72","line":58,"range":{"start_line":58,"start_character":16,"end_line":58,"end_character":20},"updated":"2016-12-11 15:42:57.000000000","message":"pod","commit_id":"42bf3ec423057b663380b94ffa5112e1a6333c9a"}]}
