)]}'
{"helm/microservice/glance-api-svc/templates/glance_api_svc.yaml":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"298f4ce50a86f73f443ab3854675bdb38a088889","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- $elementPort :\u003d .Values.glance_api_port | default 9292 }}"},{"line_number":2,"context_line":"{{- $elementName :\u003d printf \"%s-api\" .Values.element_name }}"},{"line_number":3,"context_line":"{{- $elementService :\u003d .Values.element_name }}"},{"line_number":4,"context_line":"{{- $elementType :\u003d .Values.type }}"},{"line_number":5,"context_line":"{{- with $env :\u003d dict \"element_port\" $elementPort \"element_name\" $elementName \"element_service\" $elementService \"element_type\" $elementType \"Values\" .Values }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1a6eadb0_ff98ea6c","line":2,"range":{"start_line":2,"start_character":44,"end_line":2,"end_character":56},"updated":"2016-12-12 17:49:13.000000000","message":"I think for most openstack services, there will only ever be one instance per namespace. so requiring an element_name is extra effort on the user. can we make a default of the service name?","commit_id":"299ee2dbdcd5d7e66270528e20eac44264622ad8"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"010ab1e1cb14e0ff407a4d0fbe239efc7a8f9c79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- $elementPort :\u003d .Values.glance_api_port | default 9292 }}"},{"line_number":2,"context_line":"{{- $elementName :\u003d printf \"%s-api\" .Values.element_name }}"},{"line_number":3,"context_line":"{{- $elementService :\u003d .Values.element_name }}"},{"line_number":4,"context_line":"{{- $elementType :\u003d .Values.type }}"},{"line_number":5,"context_line":"{{- with $env :\u003d dict \"element_port\" $elementPort \"element_name\" $elementName \"element_service\" $elementService \"element_type\" $elementType \"Values\" .Values }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1a6eadb0_254a3184","line":2,"range":{"start_line":2,"start_character":44,"end_line":2,"end_character":56},"in_reply_to":"1a6eadb0_ff98ea6c","updated":"2016-12-13 12:16:18.000000000","message":"I agree, it is very unlikely that more than one instance of the same service will exist in a namespace.","commit_id":"299ee2dbdcd5d7e66270528e20eac44264622ad8"}],"tests/bin/ceph_workflow.sh":[{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f3ec83b5acc3aa6b47820cf2f12ee59d009026ac","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    nova-api "},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"helm install kolla/glance-api-svc --version 3.0.0-1 \\"},{"line_number":51,"context_line":"    --namespace kolla --name glance-api-svc --set element_name\u003dglance"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"helm install kolla/glance-registry-svc --version 3.0.0-1 \\"},{"line_number":54,"context_line":"    --namespace kolla --name glance-registry-svc --set element_name\u003dglance"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a71b18c_33a84d20","line":51,"range":{"start_line":51,"start_character":50,"end_line":51,"end_character":69},"updated":"2016-12-11 15:14:05.000000000","message":"Would another fix not be to change this to glance-api? I think this may be a better solution than changing the SVC template, but may be off base.","commit_id":"20d1773ece13352003e5000bdb09fc2bd0cf4943"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"b3f4a46fb28672e2b1f1a501dbb29ec66b56d6c2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    nova-api "},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"helm install kolla/glance-api-svc --version 3.0.0-1 \\"},{"line_number":51,"context_line":"    --namespace kolla --name glance-api-svc --set element_name\u003dglance"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"helm install kolla/glance-registry-svc --version 3.0.0-1 \\"},{"line_number":54,"context_line":"    --namespace kolla --name glance-registry-svc --set element_name\u003dglance"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a71b18c_96666f4f","line":51,"range":{"start_line":51,"start_character":50,"end_line":51,"end_character":69},"in_reply_to":"3a71b18c_33a84d20","updated":"2016-12-11 16:29:10.000000000","message":"I think the problem then becomes that the selector value for the service becomes \u0027glance-api\u0027 instead of \u0027glance\u0027. This results in differing behavior than the previous kollakube approach if im not mistaken. I think (could be wrong) the service name for the selector and the name of the service itself should be different here","commit_id":"20d1773ece13352003e5000bdb09fc2bd0cf4943"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"f3ec83b5acc3aa6b47820cf2f12ee59d009026ac","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    --namespace kolla --name glance-api-svc --set element_name\u003dglance"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"helm install kolla/glance-registry-svc --version 3.0.0-1 \\"},{"line_number":54,"context_line":"    --namespace kolla --name glance-registry-svc --set element_name\u003dglance"},{"line_number":55,"context_line":"    "},{"line_number":56,"context_line":"kollakube res create svc neutron-server nova-metadata nova-novncproxy horizon \\"},{"line_number":57,"context_line":"    cinder-api"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3a71b18c_b36a9deb","line":54,"range":{"start_line":54,"start_character":55,"end_line":54,"end_character":74},"updated":"2016-12-11 15:14:05.000000000","message":"As above but to glance-registry.","commit_id":"20d1773ece13352003e5000bdb09fc2bd0cf4943"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"298f4ce50a86f73f443ab3854675bdb38a088889","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    nova-api "},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"helm install kolla/glance-api-svc --version 3.0.0-1 \\"},{"line_number":51,"context_line":"    --namespace kolla --name glance-api-svc --set element_name\u003dglance"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"helm install kolla/glance-registry-svc --version 3.0.0-1 \\"},{"line_number":54,"context_line":"    --namespace kolla --name glance-registry-svc --set element_name\u003dglance"}],"source_content_type":"text/x-sh","patch_set":7,"id":"1a6eadb0_5fce3e5b","line":51,"range":{"start_line":51,"start_character":44,"end_line":51,"end_character":69},"updated":"2016-12-12 17:49:13.000000000","message":"If this is defaulted to glance, then we can remove the override here.","commit_id":"299ee2dbdcd5d7e66270528e20eac44264622ad8"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"6f69966d4e89a3bf34040828f86abe24cab0a845","unresolved":false,"context_lines":[{"line_number":46,"context_line":"done"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"kollakube res create svc memcached keystone-admin keystone-public \\"},{"line_number":49,"context_line":"    neutron-server horizon cinder-api nova-api "},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"helm install kolla/glance-api-svc --version 3.0.0-1 \\"},{"line_number":52,"context_line":"    --namespace kolla --name glance-api-svc"}],"source_content_type":"text/x-sh","patch_set":9,"id":"1a6eadb0_033b68d2","line":49,"range":{"start_line":49,"start_character":38,"end_line":49,"end_character":47},"updated":"2016-12-13 14:19:36.000000000","message":"nova api gets created by helm now, I think it should not be here.","commit_id":"219aeac3e94005e4e5169cc9fa1d11533e0253d5"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"d7fb54fef5523d662b98c25e9b72d5c5259e9f69","unresolved":false,"context_lines":[{"line_number":54,"context_line":"helm install kolla/glance-registry-svc --version 3.0.0-1 \\"},{"line_number":55,"context_line":"    --namespace kolla --name glance-registry-svc"},{"line_number":56,"context_line":"    "},{"line_number":57,"context_line":"kollakube res create svc neutron-server nova-metadata nova-novncproxy horizon \\"},{"line_number":58,"context_line":"    cinder-api"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"helm install kolla/mariadb-svc --version 3.0.0-1 \\"}],"source_content_type":"text/x-sh","patch_set":11,"id":"1a6eadb0_f241d33a","line":57,"range":{"start_line":57,"start_character":39,"end_line":57,"end_character":69},"updated":"2016-12-13 14:51:59.000000000","message":"these need to be removed.","commit_id":"709b16411fc007552990ed37237612e407f9d2a6"}]}
