)]}'
{"helm/all_values.yaml":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"6393027fa9ec25dee7b703bc9ea3625aac3941cc","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":"glance-create-keystone-endpoint-public:"},{"line_number":304,"context_line":"        kolla_kubernetes_external_vip:"},{"line_number":305,"context_line":"        neutron_server_port: 9292"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"glance-create-keystone-endpoint-internal:"},{"line_number":308,"context_line":"        glance_internal_service: glance-api"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a6eadb0_4a44feb5","line":305,"range":{"start_line":305,"start_character":8,"end_line":305,"end_character":27},"updated":"2016-12-16 04:23:54.000000000","message":"this needs updating. same with the rest.","commit_id":"d4fbb4ce876e4f7bd760ad7d6819c9cc26f1b3a1"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"a33971e244c2d6c777e4a404853eed204ed26579","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":"glance-create-keystone-endpoint-public:"},{"line_number":304,"context_line":"        kolla_kubernetes_external_vip:"},{"line_number":305,"context_line":"        neutron_server_port: 9292"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"glance-create-keystone-endpoint-internal:"},{"line_number":308,"context_line":"        glance_internal_service: glance-api"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a6eadb0_b8f15197","line":305,"range":{"start_line":305,"start_character":8,"end_line":305,"end_character":27},"in_reply_to":"1a6eadb0_4a44feb5","updated":"2016-12-16 14:44:30.000000000","message":"oops. thanks kevin","commit_id":"d4fbb4ce876e4f7bd760ad7d6819c9cc26f1b3a1"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"54b363223c59be957dcf712451ad8c60022e528d","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        type: dashboard"},{"line_number":323,"context_line":"        port: 80"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"glance-create-db:"},{"line_number":326,"context_line":"      database_host: \"mariadb\""},{"line_number":327,"context_line":"      database_port: 3306"},{"line_number":328,"context_line":"      database_name: \"glance\""},{"line_number":329,"context_line":"      database_user: \"glance\""},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"glance-manage-db:"},{"line_number":332,"context_line":"      image_tag: 2.0.2"},{"line_number":333,"context_line":"      ceph_backend: true"},{"line_number":334,"context_line":"      pvc_name: \"glance\""},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"glance-create-keystone-endpoint-public:"},{"line_number":337,"context_line":"        kolla_kubernetes_external_vip:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a6eadb0_0450200a","line":334,"range":{"start_line":325,"start_character":0,"end_line":334,"end_character":24},"updated":"2016-12-16 16:08:36.000000000","message":"nit: indentation","commit_id":"823e7a2e564797d183beaf31732d3cc02d06ca40"}],"helm/microservice/glance-create-keystone-endpoint-public/templates/glance-create-keystone-endpoint-public.yaml":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"3e9109cc374bbe7b79a5c494fd3a2dba2e14e8ac","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{{- $serviceName :\u003d \"glance\" }}"},{"line_number":5,"context_line":"{{- $serviceType :\u003d \"image\" }}"},{"line_number":6,"context_line":"{{- $interface :\u003d \"public\" }}"},{"line_number":7,"context_line":"{{- $glancePublicEndpointBuilt :\u003d printf \"http://%s:%1.f/v1/%(tenant_id)s\" .Values.kolla_kubernetes_external_vip .Values.glance_api_port }}"},{"line_number":8,"context_line":"{{- $endpointURLFull :\u003d .Values.glance_public_endpoint | default $glancePublicEndpointBuilt }}"},{"line_number":9,"context_line":"{{- with $env :\u003d dict \"netHostTrue\" $netHostTrue \"podTypeBootstrap\" $podTypeBootstrap \"resourceName\" $resourceName \"serviceName\" $serviceName \"serviceType\" $serviceType \"interface\" $interface \"endpointURLFull\" $endpointURLFull \"Values\" .Values }}"},{"line_number":10,"context_line":"{{- include \"common_create_keystone_endpoint\" $env }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a6eadb0_bef13997","line":7,"updated":"2016-12-16 15:31:51.000000000","message":"The issue is, the %(tenant_id)s is being interpreted by the printf as a non constant string. Looking a the golang docs, it looks like the literal escape for % is %%. so adding an extra % should fix the issue.\n\nThe other files need changing too.","commit_id":"823e7a2e564797d183beaf31732d3cc02d06ca40"}],"tests/bin/ceph_workflow.sh":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"827201d9f325edff672c86f3dc0c7a0715a8c3c6","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    cinder-create-keystone-endpoint-adminv2"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"helm install kolla/glance-create-keystone-endpoint-internal --version 3.0.0-1 \\"},{"line_number":238,"context_line":"    --namespace kolla --name glance-create-keystone-endpoint-internal --set \"$common_vars\" "},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"helm install kolla/glance-create-keystone-endpoint-admin --version 3.0.0-1 \\"},{"line_number":241,"context_line":"    --namespace kolla --name glance-create-keystone-endpoint-admin --set \"$common_vars\""}],"source_content_type":"text/x-sh","patch_set":6,"id":"1a6eadb0_7d3dde29","line":238,"updated":"2016-12-16 19:50:17.000000000","message":"So close.... tiny ws issue.\n\nI think I\u0027m going to let this through though with the ws here. there are a few other ws issues in the file already. \n\nI\u0027ll submit a follow on patch to clean them all up.","commit_id":"57d1a89da3ad9aa082f69574347ed01c3241e920"}]}
