)]}'
{"helm/microservice/glance-api/templates/glance_api.yaml":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"fa90198c2bfe9d3a5b1e2375593a964af5b86bf7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        kolla_upgrade: minor_rolling_safe"},{"line_number":41,"context_line":"{{- end }}"},{"line_number":42,"context_line":"        pod.beta.kubernetes.io/init-containers: \u0027["},{"line_number":43,"context_line":"{{- include \"common_dependency_container_multi\" $env | indent 10 }}"},{"line_number":44,"context_line":"          {"},{"line_number":45,"context_line":"              \"name\": \"update-config\","},{"line_number":46,"context_line":"              \"image\": {{ include \"kolla_toolbox_image_full\" . | quote }},"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da4df55a_0ee73ae5","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":67},"updated":"2016-12-22 01:52:58.000000000","message":"already fixed in another ps","commit_id":"96704506286c5360842eeda4d3694e90dccc0e0a"}],"helm/microservice/glance-manage-db/templates/glance_manage_db.yaml":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"fa90198c2bfe9d3a5b1e2375593a964af5b86bf7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  name: glance-manage-db"},{"line_number":11,"context_line":"spec:"},{"line_number":12,"context_line":"  template:"},{"line_number":13,"context_line":"{{- include \"init_container_tail\" $env | indent 4 }}"},{"line_number":14,"context_line":"{{- include \"common_dependency_container_single\" | indent 10 }}"},{"line_number":15,"context_line":"{{- include \"init_container_tail\" | indent 4 }}"},{"line_number":16,"context_line":"    spec:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da4df55a_6ece065c","line":13,"updated":"2016-12-22 01:52:58.000000000","message":"already fixed in another ps","commit_id":"96704506286c5360842eeda4d3694e90dccc0e0a"}],"helm/microservice/mariadb-init-element/templates/mariadb-init-element.yaml":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"fa90198c2bfe9d3a5b1e2375593a964af5b86bf7","unresolved":false,"context_lines":[{"line_number":8,"context_line":"kind: Job"},{"line_number":9,"context_line":"spec:"},{"line_number":10,"context_line":"  template:"},{"line_number":11,"context_line":"{{- include \"init_container_tail\" $env | indent 4 }}"},{"line_number":12,"context_line":"{{- include \"common_dependency_container_single\" | indent 10 }}"},{"line_number":13,"context_line":"{{- include \"init_container_tail\" | indent 4 }}"},{"line_number":14,"context_line":"    spec:"},{"line_number":15,"context_line":"      nodeSelector:"},{"line_number":16,"context_line":"          {{ .Values.selector_key }}: {{ .Values.selector_value | quote }}"},{"line_number":17,"context_line":"      containers:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da4df55a_6ec7e645","line":14,"range":{"start_line":11,"start_character":0,"end_line":14,"end_character":9},"updated":"2016-12-22 01:52:58.000000000","message":"already fixed in another ps","commit_id":"96704506286c5360842eeda4d3694e90dccc0e0a"}],"helm/microservice/mariadb-pod/templates/mariadb-pod.yaml":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"fa90198c2bfe9d3a5b1e2375593a964af5b86bf7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    metadata:"},{"line_number":14,"context_line":"      labels:"},{"line_number":15,"context_line":"        service: {{ .Values.element_name }}"},{"line_number":16,"context_line":"      annotations:"},{"line_number":17,"context_line":"        pod.beta.kubernetes.io/init-containers: \u0027["},{"line_number":18,"context_line":"{{- include \"common_dependency_container_single\" | indent 10 }}"},{"line_number":19,"context_line":"        ]\u0027"},{"line_number":20,"context_line":"    spec:"},{"line_number":21,"context_line":"      nodeSelector:"},{"line_number":22,"context_line":"          {{ .Values.selector_key }}: {{ .Values.selector_value | quote }}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da4df55a_aec1ce30","line":19,"range":{"start_line":16,"start_character":0,"end_line":19,"end_character":10},"updated":"2016-12-22 01:52:58.000000000","message":"already fixed in another ps","commit_id":"96704506286c5360842eeda4d3694e90dccc0e0a"}],"helm/microservice/openvswitch-ovsdb/templates/openvswitch-ovsdb-daemonset.yaml":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"12c5a35d8e80998a345b68ad786f6b1d56374109","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        system: openvswitch-db-{{ $restype }}"},{"line_number":21,"context_line":"      annotations:"},{"line_number":22,"context_line":"        pod.beta.kubernetes.io/init-containers: \u0027["},{"line_number":23,"context_line":"{{- include \"common_dependency_container_multi\" $env | indent 10 }}"},{"line_number":24,"context_line":"          {"},{"line_number":25,"context_line":"             \"name\": \"initialize-ovs-db\","},{"line_number":26,"context_line":"             \"image\": \"{{ $openvswitchDBFull }}\","}],"source_content_type":"text/x-yaml","patch_set":6,"id":"da4df55a_82dda444","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":67},"updated":"2016-12-22 14:20:05.000000000","message":"ovsdb does not depend on any kubernetes resources, having it here useless will just confuse people.","commit_id":"13e957e3f43f94840f5975442b5592b5c54911d4"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"b54bd3daef1af7fdb0ce34f311fa935c410cf199","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        system: openvswitch-db-{{ $restype }}"},{"line_number":21,"context_line":"      annotations:"},{"line_number":22,"context_line":"        pod.beta.kubernetes.io/init-containers: \u0027["},{"line_number":23,"context_line":"{{- include \"common_dependency_container_multi\" $env | indent 10 }}"},{"line_number":24,"context_line":"          {"},{"line_number":25,"context_line":"             \"name\": \"initialize-ovs-db\","},{"line_number":26,"context_line":"             \"image\": \"{{ $openvswitchDBFull }}\","}],"source_content_type":"text/x-yaml","patch_set":6,"id":"da4df55a_fd79a030","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":67},"in_reply_to":"da4df55a_82dda444","updated":"2016-12-22 22:19:25.000000000","message":"It would allow the user to have it depend on anything else they would want to slip into the vals via dependencies. like if they were doing some other sdn stuff that required a kernel module or something loaded by deamonset and had a unix socket or something.\n\nI don\u0027t think it hurts anything to have it here, with no dependencies out of the box?","commit_id":"13e957e3f43f94840f5975442b5592b5c54911d4"}],"helm/microservice/openvswitch-vswitchd/templates/openvswitch-vswitchd-daemonset.yaml":[{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"12c5a35d8e80998a345b68ad786f6b1d56374109","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        system: openvswitch-vswitchd-{{ $restype }}"},{"line_number":21,"context_line":"      annotations:"},{"line_number":22,"context_line":"        pod.beta.kubernetes.io/init-containers: \u0027["},{"line_number":23,"context_line":"{{- include \"common_dependency_container_multi\" $env | indent 10 }}"},{"line_number":24,"context_line":"          {"},{"line_number":25,"context_line":"             \"name\": \"initialize-ovs-vswitchd\","},{"line_number":26,"context_line":"             \"image\": \"{{ $openvswitchVswitchdFull }}\","}],"source_content_type":"text/x-yaml","patch_set":6,"id":"da4df55a_220158af","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":48},"updated":"2016-12-22 14:20:05.000000000","message":"If you check below, line 51 vswitchd already uses entrypoint for the ovsdb socket. Having two dependencies container looks like a bad design. I suggest either remove common_dependency, or move dependency for vswitchd to all.yaml and make it kubernetes_entrypoint: true, so this dependency will be check in all cases.","commit_id":"13e957e3f43f94840f5975442b5592b5c54911d4"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"b54bd3daef1af7fdb0ce34f311fa935c410cf199","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        system: openvswitch-vswitchd-{{ $restype }}"},{"line_number":21,"context_line":"      annotations:"},{"line_number":22,"context_line":"        pod.beta.kubernetes.io/init-containers: \u0027["},{"line_number":23,"context_line":"{{- include \"common_dependency_container_multi\" $env | indent 10 }}"},{"line_number":24,"context_line":"          {"},{"line_number":25,"context_line":"             \"name\": \"initialize-ovs-vswitchd\","},{"line_number":26,"context_line":"             \"image\": \"{{ $openvswitchVswitchdFull }}\","}],"source_content_type":"text/x-yaml","patch_set":6,"id":"da4df55a_1dae6485","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":48},"in_reply_to":"da4df55a_220158af","updated":"2016-12-22 22:19:25.000000000","message":"oh. I didn\u0027t notice that before. thanks for pointing it out. I\u0027ll rework it.","commit_id":"13e957e3f43f94840f5975442b5592b5c54911d4"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"5e850135811d5fe319cda28811e19f63b45ac6d8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        system: openvswitch-vswitchd-{{ $restype }}"},{"line_number":28,"context_line":"      annotations:"},{"line_number":29,"context_line":"        pod.beta.kubernetes.io/init-containers: \u0027["},{"line_number":30,"context_line":"{{- include \"common_dependency_container_multi\" $env | indent 10 }}"},{"line_number":31,"context_line":"          {"},{"line_number":32,"context_line":"             \"name\": \"initialize-ovs-vswitchd\","},{"line_number":33,"context_line":"             \"image\": \"{{ $openvswitchVswitchdFull }}\","}],"source_content_type":"text/x-yaml","patch_set":9,"id":"da4df55a_cb806d49","line":30,"range":{"start_line":30,"start_character":13,"end_line":30,"end_character":46},"updated":"2016-12-23 19:19:58.000000000","message":"This condition is a mandatory and must be enabled regardless of kubernetes_entrypoint true or false. I could not find where it is forced.","commit_id":"56cc1a5bbcb4de500abbc634066462a163d53e88"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"9d7838f24dc1580aa35288ced1b00592692cba9b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{{- $resourceName :\u003d printf \"openvswitch-vswitchd-%s\" $restype }}"},{"line_number":5,"context_line":"{{- $netHostTrue :\u003d true }}"},{"line_number":6,"context_line":"{{- $podTypeBootstrap :\u003d false }}"},{"line_number":7,"context_line":"{{- $extraDepVolumeMounts :\u003d \"openvswitch_vswitchd_dep_volume_mounts\" }}"},{"line_number":8,"context_line":"{{- define \"openvswitch_vswitchd_dep_volume_mounts\" }}"},{"line_number":9,"context_line":"{"},{"line_number":10,"context_line":"   \"name\": \"openvswitch-run\","},{"line_number":11,"context_line":"   \"mountPath\": \"/var/run/openvswitch/\""},{"line_number":12,"context_line":"}"},{"line_number":13,"context_line":"{{- end }}"},{"line_number":14,"context_line":"{{- with $env :\u003d dict \"extraDepVolumeMounts\" $extraDepVolumeMounts \"netHostTrue\" $netHostTrue \"podTypeBootstrap\" $podTypeBootstrap \"resourceName\" $resourceName \"Values\" .Values \"Release\" .Release }}"},{"line_number":15,"context_line":"apiVersion: extensions/v1beta1"},{"line_number":16,"context_line":"kind: DaemonSet"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"da4df55a_4b9c7d69","line":13,"range":{"start_line":7,"start_character":0,"end_line":13,"end_character":10},"updated":"2016-12-23 19:38:57.000000000","message":"not needed","commit_id":"8210bc7a76c12ea5ecd083d672f23fc7962b6536"}]}