)]}'
{"helm/microservice/iscsid/templates/iscsid-daemonset.yaml":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"9266efa4c62cb5226486d8afd49b5cce7fc2709c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        system: iscsid"},{"line_number":20,"context_line":"      annotations:"},{"line_number":21,"context_line":"        pod.beta.kubernetes.io/init-containers: \u0027["},{"line_number":22,"context_line":"          {"},{"line_number":23,"context_line":"             \"name\": \"initialize-iscsid\","},{"line_number":24,"context_line":"             \"image\": \"{{ $imageFull }}\","},{"line_number":25,"context_line":"             \"imagePullPolicy\": {{ .Values.image_pull_policy | quote }},"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"da4df55a_3a83019a","line":22,"updated":"2016-12-24 02:45:32.000000000","message":"could you add the dependency container macro here and in the other daemonset please?","commit_id":"695ef94827ff7a532fec216f013af8c4c967de3d"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"c049689f9779d69a6b2e84a127d3027ad88d8a09","unresolved":false,"context_lines":[{"line_number":19,"context_line":"        system: iscsid"},{"line_number":20,"context_line":"      annotations:"},{"line_number":21,"context_line":"        pod.beta.kubernetes.io/init-containers: \u0027["},{"line_number":22,"context_line":"          {"},{"line_number":23,"context_line":"             \"name\": \"initialize-iscsid\","},{"line_number":24,"context_line":"             \"image\": \"{{ $imageFull }}\","},{"line_number":25,"context_line":"             \"imagePullPolicy\": {{ .Values.image_pull_policy | quote }},"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"da4df55a_ce7876c7","line":22,"in_reply_to":"da4df55a_3a83019a","updated":"2016-12-24 04:25:39.000000000","message":"Done","commit_id":"695ef94827ff7a532fec216f013af8c4c967de3d"}],"helm/microservice/tgtd/templates/tgtd-daemonset.yaml":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"9266efa4c62cb5226486d8afd49b5cce7fc2709c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                  {{- if not (empty .Values.storage_interface) }}"},{"line_number":31,"context_line":"                    compute_storage_interface\u003d\u0027\u0027{{ .Values.storage_interface }}\u0027\u0027;"},{"line_number":32,"context_line":"                  {{- else -}}"},{"line_number":33,"context_line":"                    compute_storage_interface\u003d$(ip route | grep default | awk \u0027\u0027{print $5}\u0027\u0027);"},{"line_number":34,"context_line":"                  {{- end -}}"},{"line_number":35,"context_line":"                  storage_ip\u003d$(ip addr show dev $compute_storage_interface | grep \u0027\u0027state UP\u0027\u0027 -A2 | tail -n1 | awk \u0027\u0027{print $2}\u0027\u0027 | cut -f1  -d\u0027\u0027/\u0027\u0027);"},{"line_number":36,"context_line":"                  jq \u0027\u0027.command \u003d \\\"tgtd -d 1 -f --iscsi portal\u003d\u0027\u0027$storage_ip\u0027\u0027:3260\\\"\u0027\u0027 /srv/configmap/..data/config.json \u003e /srv/pod-main-config/config.json; \"],"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"da4df55a_fa7899c6","line":33,"updated":"2016-12-24 02:45:32.000000000","message":"this doesn\u0027t use the local config file override that the others do. could you use that pattern instead?","commit_id":"695ef94827ff7a532fec216f013af8c4c967de3d"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"c049689f9779d69a6b2e84a127d3027ad88d8a09","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                  {{- if not (empty .Values.storage_interface) }}"},{"line_number":31,"context_line":"                    compute_storage_interface\u003d\u0027\u0027{{ .Values.storage_interface }}\u0027\u0027;"},{"line_number":32,"context_line":"                  {{- else -}}"},{"line_number":33,"context_line":"                    compute_storage_interface\u003d$(ip route | grep default | awk \u0027\u0027{print $5}\u0027\u0027);"},{"line_number":34,"context_line":"                  {{- end -}}"},{"line_number":35,"context_line":"                  storage_ip\u003d$(ip addr show dev $compute_storage_interface | grep \u0027\u0027state UP\u0027\u0027 -A2 | tail -n1 | awk \u0027\u0027{print $2}\u0027\u0027 | cut -f1  -d\u0027\u0027/\u0027\u0027);"},{"line_number":36,"context_line":"                  jq \u0027\u0027.command \u003d \\\"tgtd -d 1 -f --iscsi portal\u003d\u0027\u0027$storage_ip\u0027\u0027:3260\\\"\u0027\u0027 /srv/configmap/..data/config.json \u003e /srv/pod-main-config/config.json; \"],"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"da4df55a_91585334","line":33,"in_reply_to":"da4df55a_fa7899c6","updated":"2016-12-24 04:25:39.000000000","message":"Done","commit_id":"695ef94827ff7a532fec216f013af8c4c967de3d"}],"tests/bin/ceph_workflow.sh":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"9266efa4c62cb5226486d8afd49b5cce7fc2709c","unresolved":false,"context_lines":[{"line_number":402,"context_line":"    --set \"$common_vars,tunnel_interface\u003d$tunnel_interface,element_name\u003dnova-compute\" \\"},{"line_number":403,"context_line":"    --namespace kolla --name nova-compute"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"cat \u003e\u003e /tmp/iscsi-tgtd-configmap.yaml \u003c\u003c\"EOF\""},{"line_number":406,"context_line":"apiVersion: v1"},{"line_number":407,"context_line":"data:"},{"line_number":408,"context_line":"  config.json: |"},{"line_number":409,"context_line":"    {"},{"line_number":410,"context_line":"        \"command\": \"iscsid -d 8 -f --pid\u003d/run/iscsid.pid\","},{"line_number":411,"context_line":"        \"config_files\": []"},{"line_number":412,"context_line":"    }"},{"line_number":413,"context_line":"kind: ConfigMap"},{"line_number":414,"context_line":"metadata:"},{"line_number":415,"context_line":"  name: iscsid"},{"line_number":416,"context_line":"  namespace: kolla"},{"line_number":417,"context_line":"---"},{"line_number":418,"context_line":"apiVersion: v1"},{"line_number":419,"context_line":"data:"},{"line_number":420,"context_line":"  config.json: |"},{"line_number":421,"context_line":"    {"},{"line_number":422,"context_line":"        \"command\": \"tgtd -d 1 -f --iscsi portal\u003d0.0.0.0:3260\","},{"line_number":423,"context_line":"        \"config_files\": []"},{"line_number":424,"context_line":"    }"},{"line_number":425,"context_line":"kind: ConfigMap"},{"line_number":426,"context_line":"metadata:"},{"line_number":427,"context_line":"  name: tgtd"},{"line_number":428,"context_line":"  namespace: kolla"},{"line_number":429,"context_line":"EOF"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"kubectl create -f /tmp/iscsi-tgtd-configmap.yaml"},{"line_number":432,"context_line":""}],"source_content_type":"text/x-sh","patch_set":16,"id":"da4df55a_9a4ead94","line":429,"range":{"start_line":405,"start_character":0,"end_line":429,"end_character":3},"updated":"2016-12-24 02:45:32.000000000","message":"Since this is all static, can it just be added as a file to tests/config/iscsi... ?","commit_id":"695ef94827ff7a532fec216f013af8c4c967de3d"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"c049689f9779d69a6b2e84a127d3027ad88d8a09","unresolved":false,"context_lines":[{"line_number":402,"context_line":"    --set \"$common_vars,tunnel_interface\u003d$tunnel_interface,element_name\u003dnova-compute\" \\"},{"line_number":403,"context_line":"    --namespace kolla --name nova-compute"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"cat \u003e\u003e /tmp/iscsi-tgtd-configmap.yaml \u003c\u003c\"EOF\""},{"line_number":406,"context_line":"apiVersion: v1"},{"line_number":407,"context_line":"data:"},{"line_number":408,"context_line":"  config.json: |"},{"line_number":409,"context_line":"    {"},{"line_number":410,"context_line":"        \"command\": \"iscsid -d 8 -f --pid\u003d/run/iscsid.pid\","},{"line_number":411,"context_line":"        \"config_files\": []"},{"line_number":412,"context_line":"    }"},{"line_number":413,"context_line":"kind: ConfigMap"},{"line_number":414,"context_line":"metadata:"},{"line_number":415,"context_line":"  name: iscsid"},{"line_number":416,"context_line":"  namespace: kolla"},{"line_number":417,"context_line":"---"},{"line_number":418,"context_line":"apiVersion: v1"},{"line_number":419,"context_line":"data:"},{"line_number":420,"context_line":"  config.json: |"},{"line_number":421,"context_line":"    {"},{"line_number":422,"context_line":"        \"command\": \"tgtd -d 1 -f --iscsi portal\u003d0.0.0.0:3260\","},{"line_number":423,"context_line":"        \"config_files\": []"},{"line_number":424,"context_line":"    }"},{"line_number":425,"context_line":"kind: ConfigMap"},{"line_number":426,"context_line":"metadata:"},{"line_number":427,"context_line":"  name: tgtd"},{"line_number":428,"context_line":"  namespace: kolla"},{"line_number":429,"context_line":"EOF"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"kubectl create -f /tmp/iscsi-tgtd-configmap.yaml"},{"line_number":432,"context_line":""}],"source_content_type":"text/x-sh","patch_set":16,"id":"da4df55a_ce5f963f","line":429,"range":{"start_line":405,"start_character":0,"end_line":429,"end_character":3},"in_reply_to":"da4df55a_9a4ead94","updated":"2016-12-24 04:25:39.000000000","message":"Done","commit_id":"695ef94827ff7a532fec216f013af8c4c967de3d"}],"tests/bin/setup_config.sh":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"9266efa4c62cb5226486d8afd49b5cce7fc2709c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    sed -i \"s/172.17.0.1/$(cat /etc/nodepool/primary_node_private)/\" \\"},{"line_number":29,"context_line":"        etc/kolla-kubernetes/kolla-kubernetes.yml"},{"line_number":30,"context_line":"fi"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Need to change globals.yaml to enable generation of iscsi configs"},{"line_number":33,"context_line":"# later used for generation of configmaps."},{"line_number":34,"context_line":"# sed -i \u0027s/.*enable_cinder_backend_lvm.*/enable_cinder_backend_lvm: \"yes\"/g\u0027 /etc/kolla/globals.yml"}],"source_content_type":"text/x-sh","patch_set":16,"id":"da4df55a_3a08612c","line":31,"updated":"2016-12-24 02:45:32.000000000","message":"should be able to wrap this in a conditional for checking if $type is iscsi.","commit_id":"695ef94827ff7a532fec216f013af8c4c967de3d"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"c049689f9779d69a6b2e84a127d3027ad88d8a09","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    sed -i \"s/172.17.0.1/$(cat /etc/nodepool/primary_node_private)/\" \\"},{"line_number":29,"context_line":"        etc/kolla-kubernetes/kolla-kubernetes.yml"},{"line_number":30,"context_line":"fi"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Need to change globals.yaml to enable generation of iscsi configs"},{"line_number":33,"context_line":"# later used for generation of configmaps."},{"line_number":34,"context_line":"# sed -i \u0027s/.*enable_cinder_backend_lvm.*/enable_cinder_backend_lvm: \"yes\"/g\u0027 /etc/kolla/globals.yml"}],"source_content_type":"text/x-sh","patch_set":16,"id":"da4df55a_313167ed","line":31,"in_reply_to":"da4df55a_3a08612c","updated":"2016-12-24 04:25:39.000000000","message":"Done","commit_id":"695ef94827ff7a532fec216f013af8c4c967de3d"}]}