)]}'
{"helm/all_values.yaml":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"15145635e18a92506f1967cd60da5ec36357593d","unresolved":false,"context_lines":[{"line_number":456,"context_line":"        replicas: 1"},{"line_number":457,"context_line":"        port: 8879"},{"line_number":458,"context_line":"        pvc_name: \"helm-repo\""},{"line_number":459,"context_line":"        persistent: \"true\""},{"line_number":460,"context_line":"        method: \"git\""},{"line_number":461,"context_line":"        url: \"https://github.com/openstack/kolla-kubernetes\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_94f0bdca","line":459,"range":{"start_line":459,"start_character":0,"end_line":459,"end_character":26},"updated":"2017-01-07 17:40:00.000000000","message":"can you remove the quotes?","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f223cd4b208ea0b0119ff1b4906766db670c1d8f","unresolved":false,"context_lines":[{"line_number":456,"context_line":"        replicas: 1"},{"line_number":457,"context_line":"        port: 8879"},{"line_number":458,"context_line":"        pvc_name: \"helm-repo\""},{"line_number":459,"context_line":"        persistent: \"true\""},{"line_number":460,"context_line":"        method: \"git\""},{"line_number":461,"context_line":"        url: \"https://github.com/openstack/kolla-kubernetes\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_149e8d06","line":459,"range":{"start_line":459,"start_character":0,"end_line":459,"end_character":26},"in_reply_to":"ba5201f7_94f0bdca","updated":"2017-01-07 18:23:35.000000000","message":"Done","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"f9077e8e36da47e27dd3fd0e53b7d7be0d508af2","unresolved":false,"context_lines":[{"line_number":755,"context_line":"            kolla:"},{"line_number":756,"context_line":"                helm-repo:"},{"line_number":757,"context_line":"                    all:"},{"line_number":758,"context_line":"                        port: 8879 "},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"helm-repo-pv:"},{"line_number":761,"context_line":"        global:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ba5201f7_dad5a01b","line":758,"updated":"2017-01-10 22:03:05.000000000","message":"ws","commit_id":"7b1720163e5bbb6f5463c63ceba479affe6b3268"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"f9077e8e36da47e27dd3fd0e53b7d7be0d508af2","unresolved":false,"context_lines":[{"line_number":770,"context_line":"                helm-repo:"},{"line_number":771,"context_line":"                    all:"},{"line_number":772,"context_line":"                        volume_size_gb: 10"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"helm-repo:"},{"line_number":775,"context_line":"        global:"},{"line_number":776,"context_line":"            kolla:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ba5201f7_9ac31857","line":773,"updated":"2017-01-10 22:03:05.000000000","message":"You can drop out both the pv and -pvc here entirely and add them to the stateful-service lists in tools/helm_prebuild_microservices.py\n\nIt will then pull the stateful-service chunk from above in.","commit_id":"7b1720163e5bbb6f5463c63ceba479affe6b3268"}],"helm/microservice/helm-repo-svc/templates/helm-repo_svc.yaml":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"15145635e18a92506f1967cd60da5ec36357593d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- $searchPath :\u003d \":global.kolla.helm-repo.svc:global.kolla.helm-repo.all:global.kolla.helm-repo.all:global.kolla.all\" }}"},{"line_number":2,"context_line":"{{- $elementPort :\u003d .Values.helm_repo_port | default 8879 }}"},{"line_number":3,"context_line":"{{- $elementService :\u003d \"helm-repo\" }}"},{"line_number":4,"context_line":"{{- $elementName :\u003d $elementService }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_34df113b","line":1,"range":{"start_line":1,"start_character":74,"end_line":1,"end_character":101},"updated":"2017-01-07 17:40:00.000000000","message":"extra helm-repo.all","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f223cd4b208ea0b0119ff1b4906766db670c1d8f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- $searchPath :\u003d \":global.kolla.helm-repo.svc:global.kolla.helm-repo.all:global.kolla.helm-repo.all:global.kolla.all\" }}"},{"line_number":2,"context_line":"{{- $elementPort :\u003d .Values.helm_repo_port | default 8879 }}"},{"line_number":3,"context_line":"{{- $elementService :\u003d \"helm-repo\" }}"},{"line_number":4,"context_line":"{{- $elementName :\u003d $elementService }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_54b3b597","line":1,"range":{"start_line":1,"start_character":74,"end_line":1,"end_character":101},"in_reply_to":"ba5201f7_34df113b","updated":"2017-01-07 18:23:35.000000000","message":"Done","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"}],"helm/microservice/helm-repo/templates/helm-repo.yaml":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"580dc2eed0a93a922a4ecdabf76cb25bab5eff2b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                       if [ \"x{{ $method }}\" \u003d\u003d \"xgit\"  ]; then"},{"line_number":34,"context_line":"                         pushd /tmp;"},{"line_number":35,"context_line":"                         git clone {{ $url }}"},{"line_number":36,"context_line":"                         cp -r kolla-kubernetes/helm/microservices/* /helm-repo;"},{"line_number":37,"context_line":"                         popd;"},{"line_number":38,"context_line":"                       fi;"},{"line_number":39,"context_line":"                       pushd /helm-repo;"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba5201f7_b6e0732a","line":36,"updated":"2017-01-06 22:00:20.000000000","message":"shoudln\u0027t this be:\ntools/helm_prebuild_microservices.py\ntools/helm_build_microservices.py /helm-repo\n\n?","commit_id":"40f9f1c5b3fa58cb99c631abf31ae65c4231d2ae"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"de5ba40ec13a06999162abb7b8d7dd8c93abc9ea","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                       if [ \"x{{ $method }}\" \u003d\u003d \"xgit\"  ]; then"},{"line_number":34,"context_line":"                         pushd /tmp;"},{"line_number":35,"context_line":"                         git clone {{ $url }}"},{"line_number":36,"context_line":"                         cp -r kolla-kubernetes/helm/microservices/* /helm-repo;"},{"line_number":37,"context_line":"                         popd;"},{"line_number":38,"context_line":"                       fi;"},{"line_number":39,"context_line":"                       pushd /helm-repo;"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ba5201f7_560bc7d5","line":36,"in_reply_to":"ba5201f7_b6e0732a","updated":"2017-01-06 22:04:03.000000000","message":"I was not at that point yet, but you are right.","commit_id":"40f9f1c5b3fa58cb99c631abf31ae65c4231d2ae"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"f884ab0573e13eca16136ff900195eaa6a051355","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        pod.alpha.kubernetes.io/init-containers: \u0027["},{"line_number":25,"context_line":"          {"},{"line_number":26,"context_line":"              \"name\": \"prepare-repo\","},{"line_number":27,"context_line":"              \"image\": {{ $imageFull }},"},{"line_number":28,"context_line":"              \"imagePullPolicy\": {{ .Values.image_pull_policy | quote }},"},{"line_number":29,"context_line":"              \"command\": ["},{"line_number":30,"context_line":"                  \"/bin/sh\","}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba5201f7_1a6961f9","line":27,"updated":"2017-01-07 00:51:33.000000000","message":"portdirect pointed out this should be: | quote }} too.","commit_id":"ca560e51f89f86c3f9411c4061e321c27c6bfde3"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"51dd27d5a4c43dbe0f92d3f75da255027825793d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"              \"command\": ["},{"line_number":30,"context_line":"                  \"/bin/sh\","},{"line_number":31,"context_line":"                  \"-c\","},{"line_number":32,"context_line":"                  \" if [ ! \"$(ls -A /helm-repo)\" ]; then"},{"line_number":33,"context_line":"                       if [ \"x{{ $method }}\" \u003d\u003d \"xgit\"  ]; then"},{"line_number":34,"context_line":"                         pushd /tmp;"},{"line_number":35,"context_line":"                         git clone {{ $url }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba5201f7_fa601da7","line":32,"updated":"2017-01-07 00:22:35.000000000","message":"how about:\nif [ 0 -eq $(ls /helm-repo/ | wc -l) ]; then","commit_id":"ca560e51f89f86c3f9411c4061e321c27c6bfde3"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"51dd27d5a4c43dbe0f92d3f75da255027825793d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                  \"/bin/sh\","},{"line_number":31,"context_line":"                  \"-c\","},{"line_number":32,"context_line":"                  \" if [ ! \"$(ls -A /helm-repo)\" ]; then"},{"line_number":33,"context_line":"                       if [ \"x{{ $method }}\" \u003d\u003d \"xgit\"  ]; then"},{"line_number":34,"context_line":"                         pushd /tmp;"},{"line_number":35,"context_line":"                         git clone {{ $url }}"},{"line_number":36,"context_line":"                         tools/helm_prebuild_microservices.py;"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba5201f7_1a6401b7","line":33,"updated":"2017-01-07 00:22:35.000000000","message":"should be safe to drop the quotes out of this line?","commit_id":"ca560e51f89f86c3f9411c4061e321c27c6bfde3"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"51dd27d5a4c43dbe0f92d3f75da255027825793d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                  \" if [ ! \"$(ls -A /helm-repo)\" ]; then"},{"line_number":33,"context_line":"                       if [ \"x{{ $method }}\" \u003d\u003d \"xgit\"  ]; then"},{"line_number":34,"context_line":"                         pushd /tmp;"},{"line_number":35,"context_line":"                         git clone {{ $url }}"},{"line_number":36,"context_line":"                         tools/helm_prebuild_microservices.py;"},{"line_number":37,"context_line":"                         tools/helm_build_microservices.py /helm-repo;"},{"line_number":38,"context_line":"                         popd;"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba5201f7_fa39fda4","line":35,"updated":"2017-01-07 00:22:35.000000000","message":"Might add a directory argument to the end so that you always know what the subdir is called.\n\ngit clone {{ $url }} kolla-kubernetes","commit_id":"ca560e51f89f86c3f9411c4061e321c27c6bfde3"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"51dd27d5a4c43dbe0f92d3f75da255027825793d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                       if [ \"x{{ $method }}\" \u003d\u003d \"xgit\"  ]; then"},{"line_number":34,"context_line":"                         pushd /tmp;"},{"line_number":35,"context_line":"                         git clone {{ $url }}"},{"line_number":36,"context_line":"                         tools/helm_prebuild_microservices.py;"},{"line_number":37,"context_line":"                         tools/helm_build_microservices.py /helm-repo;"},{"line_number":38,"context_line":"                         popd;"},{"line_number":39,"context_line":"                       fi;"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba5201f7_babdb503","line":36,"updated":"2017-01-07 00:22:35.000000000","message":"the two tool lines need to either be run out of the mirroed repo subdir, or be prefixed with it. so,\npushd kolla-kubernetes;\n....\n or\n\nkolla-kubernetes/tools/helm_prebuild_microservices.py;","commit_id":"ca560e51f89f86c3f9411c4061e321c27c6bfde3"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"51dd27d5a4c43dbe0f92d3f75da255027825793d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                    fi;\""},{"line_number":44,"context_line":"              ],"},{"line_number":45,"context_line":"              \"volumeMounts\": ["},{"line_number":46,"context_line":"{{- if eq $persistent \"true\" }}"},{"line_number":47,"context_line":"                  {"},{"line_number":48,"context_line":"                      \"name\": \"helm-repo-persistent-storage\","},{"line_number":49,"context_line":"                      \"mountPath\": \"/helm-repo\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba5201f7_5a112903","line":46,"updated":"2017-01-07 00:22:35.000000000","message":"If its a bool rather then a string, should be able to do:\n{{- if $persistent }}\n\nhelm install X --set persistent\u003dtrue will automatically cast to a bool, so should be easier to make work that way anyway.","commit_id":"ca560e51f89f86c3f9411c4061e321c27c6bfde3"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"51dd27d5a4c43dbe0f92d3f75da255027825793d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"          image: \"{{ $imageFull }}\""},{"line_number":61,"context_line":"          volumeMounts:"},{"line_number":62,"context_line":"{{- include \"common_volume_mounts\" $env | indent 12 }}"},{"line_number":63,"context_line":"{{- if  eq $persistent \"true\" }}"},{"line_number":64,"context_line":"            - mountPath: /helm-repo"},{"line_number":65,"context_line":"              name: helm-repo-persistent-storage"},{"line_number":66,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba5201f7_7afc2db8","line":63,"updated":"2017-01-07 00:22:35.000000000","message":"same.","commit_id":"ca560e51f89f86c3f9411c4061e321c27c6bfde3"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"15145635e18a92506f1967cd60da5ec36357593d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- $searchPath :\u003d \":global.kolla.helm-repo.deployment:global.kolla.helm-repo.all:global.kolla.helm-repo.all:global.kolla.all\" }}"},{"line_number":2,"context_line":"{{- $imageBuilt :\u003d printf \"%s/%s/%s-%s-helm-repo:%s\" .Values.docker_registry .Values.docker_namespace .Values.kolla_base_distro .Values.kolla_install_type .Values.image_tag }}"},{"line_number":3,"context_line":"{{- $imageFull :\u003d .Values.image_full | default $imageBuilt }}"},{"line_number":4,"context_line":"{{- $resourceName :\u003d \"helm-repo\" }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_74f7d9d2","line":1,"range":{"start_line":1,"start_character":55,"end_line":1,"end_character":81},"updated":"2017-01-07 17:40:00.000000000","message":"one extra global.kolla.helm-repo.all. it can be removed.","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f223cd4b208ea0b0119ff1b4906766db670c1d8f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{{- $searchPath :\u003d \":global.kolla.helm-repo.deployment:global.kolla.helm-repo.all:global.kolla.helm-repo.all:global.kolla.all\" }}"},{"line_number":2,"context_line":"{{- $imageBuilt :\u003d printf \"%s/%s/%s-%s-helm-repo:%s\" .Values.docker_registry .Values.docker_namespace .Values.kolla_base_distro .Values.kolla_install_type .Values.image_tag }}"},{"line_number":3,"context_line":"{{- $imageFull :\u003d .Values.image_full | default $imageBuilt }}"},{"line_number":4,"context_line":"{{- $resourceName :\u003d \"helm-repo\" }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_f46829f7","line":1,"range":{"start_line":1,"start_character":55,"end_line":1,"end_character":81},"in_reply_to":"ba5201f7_74f7d9d2","updated":"2017-01-07 18:23:35.000000000","message":"Done","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"15145635e18a92506f1967cd60da5ec36357593d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                  \" if [ ! \u0027\u0027$(ls -A /helm-repo)\u0027\u0027 ]; then"},{"line_number":33,"context_line":"                       pushd /tmp;"},{"line_number":34,"context_line":"                       if [ \u0027\u0027x{{ $method }}\u0027\u0027 \u003d\u003d \u0027\u0027xgit\u0027\u0027  ]; then"},{"line_number":35,"context_line":"                         git clone {{ $url }};"},{"line_number":36,"context_line":"                         pushd kolla-kubernetes;"},{"line_number":37,"context_line":"                         tools/helm_prebuild_microservices.py;"},{"line_number":38,"context_line":"                         tools/helm_build_microservices.py /helm-repo;"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_b4fdc1b2","line":35,"updated":"2017-01-07 17:40:00.000000000","message":"Can you make this:\ngit clone {{ $url }} kolla-kubernetes;\n\nThat way if someone clones a local mirror of their own that isn\u0027t named exactly \u0027kolla-kubernetes\u0027 it will still work?","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f223cd4b208ea0b0119ff1b4906766db670c1d8f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                  \" if [ ! \u0027\u0027$(ls -A /helm-repo)\u0027\u0027 ]; then"},{"line_number":33,"context_line":"                       pushd /tmp;"},{"line_number":34,"context_line":"                       if [ \u0027\u0027x{{ $method }}\u0027\u0027 \u003d\u003d \u0027\u0027xgit\u0027\u0027  ]; then"},{"line_number":35,"context_line":"                         git clone {{ $url }};"},{"line_number":36,"context_line":"                         pushd kolla-kubernetes;"},{"line_number":37,"context_line":"                         tools/helm_prebuild_microservices.py;"},{"line_number":38,"context_line":"                         tools/helm_build_microservices.py /helm-repo;"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_346f11fd","line":35,"in_reply_to":"ba5201f7_b4fdc1b2","updated":"2017-01-07 18:23:35.000000000","message":"Done","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"15145635e18a92506f1967cd60da5ec36357593d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                         popd;"},{"line_number":40,"context_line":"                       fi;"},{"line_number":41,"context_line":"                       if [ \u0027\u0027x{{ $method }}\u0027\u0027 \u003d\u003d \u0027\u0027xtar\u0027\u0027  ]; then"},{"line_number":42,"context_line":"                         mkdir tar;"},{"line_number":43,"context_line":"                         pushd tar;"},{"line_number":44,"context_line":"                         curl -O {{ $url }};"},{"line_number":45,"context_line":"                         tar -zxvf *;"},{"line_number":46,"context_line":"                         pushd kolla-kubernetes;"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_94199d24","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":35},"updated":"2017-01-07 17:40:00.000000000","message":"If this was changed to \"pushd /tmp;\", it could be moved with outside the loop at the top before the if started.","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"2ab52b905d1bb2a635ded76ac3d0b743088c88b9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                         popd;"},{"line_number":40,"context_line":"                       fi;"},{"line_number":41,"context_line":"                       if [ \u0027\u0027x{{ $method }}\u0027\u0027 \u003d\u003d \u0027\u0027xtar\u0027\u0027  ]; then"},{"line_number":42,"context_line":"                         mkdir tar;"},{"line_number":43,"context_line":"                         pushd tar;"},{"line_number":44,"context_line":"                         curl -O {{ $url }};"},{"line_number":45,"context_line":"                         tar -zxvf *;"},{"line_number":46,"context_line":"                         pushd kolla-kubernetes;"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_4b24cfae","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":35},"in_reply_to":"ba5201f7_745c394b","updated":"2017-01-09 16:12:30.000000000","message":"ah. you could change the -O to a \u0027-o kolla-kubernetes.tar.gz\u0027. then the filename is always known. Then you could share the code again?","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f223cd4b208ea0b0119ff1b4906766db670c1d8f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                         popd;"},{"line_number":40,"context_line":"                       fi;"},{"line_number":41,"context_line":"                       if [ \u0027\u0027x{{ $method }}\u0027\u0027 \u003d\u003d \u0027\u0027xtar\u0027\u0027  ]; then"},{"line_number":42,"context_line":"                         mkdir tar;"},{"line_number":43,"context_line":"                         pushd tar;"},{"line_number":44,"context_line":"                         curl -O {{ $url }};"},{"line_number":45,"context_line":"                         tar -zxvf *;"},{"line_number":46,"context_line":"                         pushd kolla-kubernetes;"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_745c394b","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":35},"in_reply_to":"ba5201f7_94199d24","updated":"2017-01-07 18:23:35.000000000","message":"The reason I went to tar folder in /tmp is to be able to run tar for wildcard archive name. It is a precaution in case some files were hanging in /tmp","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"15145635e18a92506f1967cd60da5ec36357593d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                         pushd tar;"},{"line_number":44,"context_line":"                         curl -O {{ $url }};"},{"line_number":45,"context_line":"                         tar -zxvf *;"},{"line_number":46,"context_line":"                         pushd kolla-kubernetes;"},{"line_number":47,"context_line":"                         tools/helm_prebuild_microservices.py;"},{"line_number":48,"context_line":"                         tools/helm_build_microservices.py /helm-repo;"},{"line_number":49,"context_line":"                         popd; popd;"},{"line_number":50,"context_line":"                       fi;"},{"line_number":51,"context_line":"                       popd;"},{"line_number":52,"context_line":"                       pushd /helm-repo;"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_d4d5e51b","line":49,"range":{"start_line":46,"start_character":0,"end_line":49,"end_character":36},"updated":"2017-01-07 17:40:00.000000000","message":"likewise, these are common in both if branches and could be combined outside the bottom of the if.","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f223cd4b208ea0b0119ff1b4906766db670c1d8f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                         pushd tar;"},{"line_number":44,"context_line":"                         curl -O {{ $url }};"},{"line_number":45,"context_line":"                         tar -zxvf *;"},{"line_number":46,"context_line":"                         pushd kolla-kubernetes;"},{"line_number":47,"context_line":"                         tools/helm_prebuild_microservices.py;"},{"line_number":48,"context_line":"                         tools/helm_build_microservices.py /helm-repo;"},{"line_number":49,"context_line":"                         popd; popd;"},{"line_number":50,"context_line":"                       fi;"},{"line_number":51,"context_line":"                       popd;"},{"line_number":52,"context_line":"                       pushd /helm-repo;"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_9457dd24","line":49,"range":{"start_line":46,"start_character":0,"end_line":49,"end_character":36},"in_reply_to":"ba5201f7_d4d5e51b","updated":"2017-01-07 18:23:35.000000000","message":"you see here I needed to do popd twice, that was why I could not have common code for both if branches.","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"15145635e18a92506f1967cd60da5ec36357593d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                    fi;"},{"line_number":56,"context_line":"              \"],"},{"line_number":57,"context_line":"              \"volumeMounts\": ["},{"line_number":58,"context_line":"{{- if eq $persistent \"true\" }}"},{"line_number":59,"context_line":"                  {"},{"line_number":60,"context_line":"                      \"name\": \"helm-repo-persistent-storage\","},{"line_number":61,"context_line":"                      \"mountPath\": \"/helm-repo\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_14aa0d85","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":31},"updated":"2017-01-07 17:40:00.000000000","message":"{{- if $persistent }}","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f223cd4b208ea0b0119ff1b4906766db670c1d8f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                    fi;"},{"line_number":56,"context_line":"              \"],"},{"line_number":57,"context_line":"              \"volumeMounts\": ["},{"line_number":58,"context_line":"{{- if eq $persistent \"true\" }}"},{"line_number":59,"context_line":"                  {"},{"line_number":60,"context_line":"                      \"name\": \"helm-repo-persistent-storage\","},{"line_number":61,"context_line":"                      \"mountPath\": \"/helm-repo\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_b4522133","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":31},"in_reply_to":"ba5201f7_14aa0d85","updated":"2017-01-07 18:23:35.000000000","message":"Done","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"15145635e18a92506f1967cd60da5ec36357593d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"          image: \"{{ $imageFull }}\""},{"line_number":73,"context_line":"          volumeMounts:"},{"line_number":74,"context_line":"{{- include \"common_volume_mounts\" $env | indent 12 }}"},{"line_number":75,"context_line":"{{- if  eq $persistent \"true\" }}"},{"line_number":76,"context_line":"            - mountPath: /helm-repo"},{"line_number":77,"context_line":"              name: helm-repo-persistent-storage"},{"line_number":78,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_54981578","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":32},"updated":"2017-01-07 17:40:00.000000000","message":"{{- if $persistent }}","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f223cd4b208ea0b0119ff1b4906766db670c1d8f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"          image: \"{{ $imageFull }}\""},{"line_number":73,"context_line":"          volumeMounts:"},{"line_number":74,"context_line":"{{- include \"common_volume_mounts\" $env | indent 12 }}"},{"line_number":75,"context_line":"{{- if  eq $persistent \"true\" }}"},{"line_number":76,"context_line":"            - mountPath: /helm-repo"},{"line_number":77,"context_line":"              name: helm-repo-persistent-storage"},{"line_number":78,"context_line":"{{- end }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_d4332512","line":75,"range":{"start_line":75,"start_character":0,"end_line":75,"end_character":32},"in_reply_to":"ba5201f7_54981578","updated":"2017-01-07 18:23:35.000000000","message":"Done","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"15145635e18a92506f1967cd60da5ec36357593d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"              name: {{ $resourceName | quote }}"},{"line_number":84,"context_line":"      volumes:"},{"line_number":85,"context_line":"{{- include \"common_volumes\" $env | indent 8 }}"},{"line_number":86,"context_line":"{{- if eq $persistent \"true\" }}"},{"line_number":87,"context_line":"        - name: helm-repo-persistent-storage"},{"line_number":88,"context_line":"          persistentVolumeClaim:"},{"line_number":89,"context_line":"            claimName: {{ .Values.pvc_name }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_b499417b","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":31},"updated":"2017-01-07 17:40:00.000000000","message":"{{- if $persistent }}","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"f223cd4b208ea0b0119ff1b4906766db670c1d8f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"              name: {{ $resourceName | quote }}"},{"line_number":84,"context_line":"      volumes:"},{"line_number":85,"context_line":"{{- include \"common_volumes\" $env | indent 8 }}"},{"line_number":86,"context_line":"{{- if eq $persistent \"true\" }}"},{"line_number":87,"context_line":"        - name: helm-repo-persistent-storage"},{"line_number":88,"context_line":"          persistentVolumeClaim:"},{"line_number":89,"context_line":"            claimName: {{ .Values.pvc_name }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ba5201f7_f4366901","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":31},"in_reply_to":"ba5201f7_b499417b","updated":"2017-01-07 18:23:35.000000000","message":"Done","commit_id":"7cd847468f8c3f0edeed9d362840e7060f53c847"}]}
