)]}'
{"helm/service/keystone/values.yaml":[{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"2d474dc12e4eb7844f4130ea2c53e17c04a299e0","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                        jobs:"},{"line_number":22,"context_line":"                        - keystone-create-db"},{"line_number":23,"context_line":"                        - keystone-manage-db"},{"line_number":24,"context_line":"                        service:"},{"line_number":25,"context_line":"                        - mariadb"},{"line_number":26,"context_line":"                        - keystone-admin"},{"line_number":27,"context_line":"                        - keystone-public"},{"line_number":28,"context_line":"                        - keystone-internal"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a461143_1efe2e37","side":"PARENT","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":33},"updated":"2017-01-27 13:22:15.000000000","message":"If we\u0027re declaring the database jobs as dependencies, we should leave the mariadb service as a dependency here.","commit_id":"0a01a372e3a42865f73061cc2e7becd8f8b4ac10"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"b6584083e3a349ef97328233e823a4529be5aac2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                        jobs:"},{"line_number":22,"context_line":"                        - keystone-create-db"},{"line_number":23,"context_line":"                        - keystone-manage-db"},{"line_number":24,"context_line":"                        service:"},{"line_number":25,"context_line":"                        - mariadb"},{"line_number":26,"context_line":"                        - keystone-admin"},{"line_number":27,"context_line":"                        - keystone-public"},{"line_number":28,"context_line":"                        - keystone-internal"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a461143_99131866","side":"PARENT","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":33},"in_reply_to":"3a461143_1efe2e37","updated":"2017-01-27 13:53:13.000000000","message":"here is the logic, endpoint jobs depend on create/manage db which will only run when mariadb is up and functioning. Having mariadb here seems redundant.","commit_id":"0a01a372e3a42865f73061cc2e7becd8f8b4ac10"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"af8088d15bef2f707c109903c9c64fa59995454a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                        jobs:"},{"line_number":22,"context_line":"                        - keystone-create-db"},{"line_number":23,"context_line":"                        - keystone-manage-db"},{"line_number":24,"context_line":"                        service:"},{"line_number":25,"context_line":"                        - mariadb"},{"line_number":26,"context_line":"                        - keystone-admin"},{"line_number":27,"context_line":"                        - keystone-public"},{"line_number":28,"context_line":"                        - keystone-internal"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a461143_d4556550","side":"PARENT","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":33},"in_reply_to":"3a461143_99131866","updated":"2017-01-27 14:10:03.000000000","message":"I agree, it looks redundant at first glance.  My line of thinking is that as someone works up from the microservices (create_keystone_endpoints) level up to the service level, it would be clear to them that one of the dependencies for this keystone microservice is the full completion of the mariadb service.  I agree with you -- the create/manage db jobs will only run after mariadb is up and functional, but I think it reinforces our microservice/service architecture choice to have the mariadb service listed here as well. What are your thoughts?","commit_id":"0a01a372e3a42865f73061cc2e7becd8f8b4ac10"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"bcb67ed908b5fddfed858fe6d3149bdb39e8d19e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                        jobs:"},{"line_number":22,"context_line":"                        - keystone-create-db"},{"line_number":23,"context_line":"                        - keystone-manage-db"},{"line_number":24,"context_line":"                        service:"},{"line_number":25,"context_line":"                        - mariadb"},{"line_number":26,"context_line":"                        - keystone-admin"},{"line_number":27,"context_line":"                        - keystone-public"},{"line_number":28,"context_line":"                        - keystone-internal"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a461143_ab222cff","side":"PARENT","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":33},"in_reply_to":"3a461143_ba0d2340","updated":"2017-01-27 20:13:14.000000000","message":"I\u0027m on the fence. In this case, keystone\u0027s creation jobs already successfully ran, so the db was alive at least at that point.\n\nThey are all in the same service package, so its incredibly likely that they will run within 10\u0027s of seconds of each other.\n\nThe deps thing is not entirely race free itself, as there exisits a race between the dep container finishing and the main container starting.\n\nSo, I guess either way it doesn\u0027t matter too much. Stay or go, its not really race free.\n\nI have a very slight preference to being explicit, but not enough to justify another ps.","commit_id":"0a01a372e3a42865f73061cc2e7becd8f8b4ac10"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"5e728f05de1f99df311cf83b4035eade0a24cb98","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                        jobs:"},{"line_number":22,"context_line":"                        - keystone-create-db"},{"line_number":23,"context_line":"                        - keystone-manage-db"},{"line_number":24,"context_line":"                        service:"},{"line_number":25,"context_line":"                        - mariadb"},{"line_number":26,"context_line":"                        - keystone-admin"},{"line_number":27,"context_line":"                        - keystone-public"},{"line_number":28,"context_line":"                        - keystone-internal"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a461143_ba0d2340","side":"PARENT","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":33},"in_reply_to":"3a461143_ba7d231e","updated":"2017-01-27 15:15:15.000000000","message":"Sounds good to me. :)","commit_id":"0a01a372e3a42865f73061cc2e7becd8f8b4ac10"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"24373d5e18a6d10f1282607612c38360939e5461","unresolved":false,"context_lines":[{"line_number":21,"context_line":"                        jobs:"},{"line_number":22,"context_line":"                        - keystone-create-db"},{"line_number":23,"context_line":"                        - keystone-manage-db"},{"line_number":24,"context_line":"                        service:"},{"line_number":25,"context_line":"                        - mariadb"},{"line_number":26,"context_line":"                        - keystone-admin"},{"line_number":27,"context_line":"                        - keystone-public"},{"line_number":28,"context_line":"                        - keystone-internal"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a461143_ba7d231e","side":"PARENT","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":33},"in_reply_to":"3a461143_d4556550","updated":"2017-01-27 14:31:04.000000000","message":"I perfectly understand your point. I guess we just need to decide. I guess kfox1111 will be a tie breaker here ;)","commit_id":"0a01a372e3a42865f73061cc2e7becd8f8b4ac10"}]}