)]}'
{"tests/bin/ironic_deploy_tests.sh":[{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"a8cee09dc727b55ee2a07fe4f53ec6f314cd7190","unresolved":false,"context_lines":[{"line_number":120,"context_line":"# NOTE(sbezverk) Workaround for Ubuntu using user nova for libvirtd. Possibly can be removed"},{"line_number":121,"context_line":"# in Pike."},{"line_number":122,"context_line":"  sudo useradd -M --shell /usr/sbin/nologin --uid 42436 --gid 42436 nova"},{"line_number":123,"context_line":"  alias virsh_m\u003d\u0027sudo -u nova bash -c virsh\u0027"},{"line_number":124,"context_line":"else"},{"line_number":125,"context_line":"  sudo yum install -y libvirt qemu-kvm-ev qemu-img-ev ipmitool libvirt-client libvirt-devel \\"},{"line_number":126,"context_line":"                      tcpdump strace"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ffe62b97_9b07b51d","line":123,"updated":"2017-03-24 20:33:52.000000000","message":"Alias\u0027s in shell scripts are a real pain to support - even for a temp. fix.\n\nBetter to do something like:\n\nfunction virsh_m () { command1; command2 }\nexport -f virsh_m #I can be called 1x at the end of the logic\n\nI\u0027d call virsh_m something like virsh_distro or virsh_modified as \u0027m\u0027 makes me think too much.","commit_id":"e169e8d94d32f897cb97d621f6fc30da774395e7"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"60398ae5b6273d12d1cf530bf52f2faf9ac56552","unresolved":false,"context_lines":[{"line_number":120,"context_line":"# NOTE(sbezverk) Workaround for Ubuntu using user nova for libvirtd. Possibly can be removed"},{"line_number":121,"context_line":"# in Pike."},{"line_number":122,"context_line":"  sudo useradd -M --shell /usr/sbin/nologin --uid 42436 --gid 42436 nova"},{"line_number":123,"context_line":"  alias virsh_m\u003d\u0027sudo -u nova bash -c virsh\u0027"},{"line_number":124,"context_line":"else"},{"line_number":125,"context_line":"  sudo yum install -y libvirt qemu-kvm-ev qemu-img-ev ipmitool libvirt-client libvirt-devel \\"},{"line_number":126,"context_line":"                      tcpdump strace"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ffe62b97_e91274b1","line":123,"in_reply_to":"ffe62b97_9b07b51d","updated":"2017-03-24 23:24:09.000000000","message":"Cannot say I agree with this, because if I go with function then each call would need to check whether it is called from centos env or from Ubuntu, also I will need to pass two parameters. Probably for the gate it is not that important, but still why not to save a few cpu cycles.","commit_id":"e169e8d94d32f897cb97d621f6fc30da774395e7"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"f0dbd53c188b6bd986ee826224c2b661252d4ad4","unresolved":false,"context_lines":[{"line_number":120,"context_line":"# NOTE(sbezverk) Workaround for Ubuntu using user nova for libvirtd. Possibly can be removed"},{"line_number":121,"context_line":"# in Pike."},{"line_number":122,"context_line":"  sudo useradd -M --shell /usr/sbin/nologin --uid 42436 --gid 42436 nova"},{"line_number":123,"context_line":"  alias virsh_m\u003d\u0027sudo -u nova bash -c virsh\u0027"},{"line_number":124,"context_line":"else"},{"line_number":125,"context_line":"  sudo yum install -y libvirt qemu-kvm-ev qemu-img-ev ipmitool libvirt-client libvirt-devel \\"},{"line_number":126,"context_line":"                      tcpdump strace"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ffe62b97_16a585b5","line":123,"in_reply_to":"ffe62b97_e91274b1","updated":"2017-03-27 13:12:06.000000000","message":"Yup I see your point, the alias is convenient. But you\u0027re setting a precedence that alias\u0027s in scripts are allowed; maybe they are used in OS, being new I don\u0027t know. But I do know bad coding practices tend to propagate. From the bash manual page: \"For almost every purpose, aliases are superseded by shell functions.\" I won\u0027t hold the review up if you don\u0027t agree.","commit_id":"e169e8d94d32f897cb97d621f6fc30da774395e7"},{"author":{"_account_id":22959,"name":"Zeyu Zhu","email":"zhuzeyu0409@gmail.com","username":"zhuzeyu"},"change_message_id":"545ff5e9e15ffc3849e104439362e08bcb0c73b2","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                          pkg-config strace tcpdump"},{"line_number":118,"context_line":"  sudo sed -i \u0027s|/usr/libexec/qemu-kvm|/usr/bin/qemu-system-x86_64|g\u0027 $DIR/../conf/ironic/vm-1.xml"},{"line_number":119,"context_line":"  sudo sed -i \"s|machine\u003d\u0027pc\u0027|machine\u003d\u0027pc-i440fx-xenial\u0027|g\" $DIR/../conf/ironic/vm-1.xml"},{"line_number":120,"context_line":"  "},{"line_number":121,"context_line":"  sudo dpkg -l | grep libvirt"},{"line_number":122,"context_line":"  sudo apt-cache policy libvirt-bin"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-sh","patch_set":25,"id":"ffe62b97_4e39a9ef","line":120,"range":{"start_line":120,"start_character":0,"end_line":120,"end_character":2},"updated":"2017-03-30 02:09:06.000000000","message":"whitespace","commit_id":"11fcb070f611356a4130be8c9ee693d6d812e4c7"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"2dbfc70d77aa612a8dee2615fc09e5621ad06e23","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                          pkg-config strace tcpdump"},{"line_number":118,"context_line":"  sudo sed -i \u0027s|/usr/libexec/qemu-kvm|/usr/bin/qemu-system-x86_64|g\u0027 $DIR/../conf/ironic/vm-1.xml"},{"line_number":119,"context_line":"  sudo sed -i \"s|machine\u003d\u0027pc\u0027|machine\u003d\u0027pc-i440fx-xenial\u0027|g\" $DIR/../conf/ironic/vm-1.xml"},{"line_number":120,"context_line":"  "},{"line_number":121,"context_line":"  sudo dpkg -l | grep libvirt"},{"line_number":122,"context_line":"  sudo apt-cache policy libvirt-bin"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-sh","patch_set":25,"id":"7ffa3b31_ad2f6286","line":120,"range":{"start_line":120,"start_character":0,"end_line":120,"end_character":2},"in_reply_to":"ffe62b97_4e39a9ef","updated":"2017-04-20 16:19:42.000000000","message":"Done","commit_id":"11fcb070f611356a4130be8c9ee693d6d812e4c7"},{"author":{"_account_id":22959,"name":"Zeyu Zhu","email":"zhuzeyu0409@gmail.com","username":"zhuzeyu"},"change_message_id":"545ff5e9e15ffc3849e104439362e08bcb0c73b2","unresolved":false,"context_lines":[{"line_number":124,"context_line":"  sudo docker exec  $(sudo docker ps | grep libvirt: | awk \u0027{print$1}\u0027) \\"},{"line_number":125,"context_line":"                      sudo dpkg -l | grep libvirt"},{"line_number":126,"context_line":"  sudo docker exec  $(sudo docker ps | grep libvirt: | awk \u0027{print$1}\u0027) \\"},{"line_number":127,"context_line":"                      sudo apt-cache policy libvirt-bin  "},{"line_number":128,"context_line":"  sudo chown :root -R /var/lib/libvirt/qemu"},{"line_number":129,"context_line":"else"},{"line_number":130,"context_line":"  sudo yum install -y libvirt qemu-kvm-ev qemu-img-ev ipmitool libvirt-client libvirt-devel \\"}],"source_content_type":"text/x-sh","patch_set":25,"id":"ffe62b97_ce2c99ad","line":127,"range":{"start_line":127,"start_character":55,"end_line":127,"end_character":57},"updated":"2017-03-30 02:09:06.000000000","message":"ditto","commit_id":"11fcb070f611356a4130be8c9ee693d6d812e4c7"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"2dbfc70d77aa612a8dee2615fc09e5621ad06e23","unresolved":false,"context_lines":[{"line_number":124,"context_line":"  sudo docker exec  $(sudo docker ps | grep libvirt: | awk \u0027{print$1}\u0027) \\"},{"line_number":125,"context_line":"                      sudo dpkg -l | grep libvirt"},{"line_number":126,"context_line":"  sudo docker exec  $(sudo docker ps | grep libvirt: | awk \u0027{print$1}\u0027) \\"},{"line_number":127,"context_line":"                      sudo apt-cache policy libvirt-bin  "},{"line_number":128,"context_line":"  sudo chown :root -R /var/lib/libvirt/qemu"},{"line_number":129,"context_line":"else"},{"line_number":130,"context_line":"  sudo yum install -y libvirt qemu-kvm-ev qemu-img-ev ipmitool libvirt-client libvirt-devel \\"}],"source_content_type":"text/x-sh","patch_set":25,"id":"7ffa3b31_6d539a18","line":127,"range":{"start_line":127,"start_character":55,"end_line":127,"end_character":57},"in_reply_to":"ffe62b97_ce2c99ad","updated":"2017-04-20 16:19:42.000000000","message":"Done","commit_id":"11fcb070f611356a4130be8c9ee693d6d812e4c7"}],"tests/bin/setup_config_iscsi.sh":[{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"07f5afeb99b27976c69471d1cb1e4fbdb0b30d8a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"sed -i \u0027s/log_outputs \u003d \"3:/log_outputs \u003d \"1:/\u0027 /etc/kolla/nova-libvirt/libvirtd.conf"},{"line_number":43,"context_line":"sed -i \u0027s/log_level \u003d 3/log_level \u003d 1/\u0027 /etc/kolla/nova-libvirt/libvirtd.conf"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"if [ \"x$CONFIG\" \u003d\u003d \"xironic\" ]; then"},{"line_number":46,"context_line":"   grep -r -l bridge_mappings /etc/kolla | xargs -l \\"},{"line_number":47,"context_line":"      sed  -i \u0027s|\\(bridge_mappings.*\u003d.*\\)|\\1,physnet2:br-tenants|g\u0027"},{"line_number":48,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":25,"id":"7ffa3b31_52951d32","line":45,"updated":"2017-04-20 16:06:40.000000000","message":"Can we move this up to the pre-existing xironic check? So we don\u0027t check it twice.","commit_id":"11fcb070f611356a4130be8c9ee693d6d812e4c7"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"2dbfc70d77aa612a8dee2615fc09e5621ad06e23","unresolved":false,"context_lines":[{"line_number":42,"context_line":"sed -i \u0027s/log_outputs \u003d \"3:/log_outputs \u003d \"1:/\u0027 /etc/kolla/nova-libvirt/libvirtd.conf"},{"line_number":43,"context_line":"sed -i \u0027s/log_level \u003d 3/log_level \u003d 1/\u0027 /etc/kolla/nova-libvirt/libvirtd.conf"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"if [ \"x$CONFIG\" \u003d\u003d \"xironic\" ]; then"},{"line_number":46,"context_line":"   grep -r -l bridge_mappings /etc/kolla | xargs -l \\"},{"line_number":47,"context_line":"      sed  -i \u0027s|\\(bridge_mappings.*\u003d.*\\)|\\1,physnet2:br-tenants|g\u0027"},{"line_number":48,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":25,"id":"7ffa3b31_4d7b3e7a","line":45,"in_reply_to":"7ffa3b31_52951d32","updated":"2017-04-20 16:19:42.000000000","message":"will do","commit_id":"11fcb070f611356a4130be8c9ee693d6d812e4c7"}],"tools/setup_gate_common.sh":[{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"07f5afeb99b27976c69471d1cb1e4fbdb0b30d8a","unresolved":false,"context_lines":[{"line_number":112,"context_line":"tftp_server \u003d undefined"},{"line_number":113,"context_line":"pxe_append_params \u003d nofb nomodeset vga\u003dnormal console\u003dtty0 console\u003dttyS0,115200n8"},{"line_number":114,"context_line":"EOF\u0027"},{"line_number":115,"context_line":"#sudo bash -c \u0027cat \u003c\u003c EOF \u003e\u003e /etc/kolla/config/nova-libvirt/libvirtd.conf"},{"line_number":116,"context_line":"#unix_sock_ro_perms \u003d \"0777\""},{"line_number":117,"context_line":"#unix_sock_rw_perms \u003d \"0777\""},{"line_number":118,"context_line":"#auth_unix_ro \u003d \"none\""}],"source_content_type":"text/x-sh","patch_set":25,"id":"7ffa3b31_d2cecd58","line":115,"updated":"2017-04-20 16:06:40.000000000","message":"Why added the commented out code?","commit_id":"11fcb070f611356a4130be8c9ee693d6d812e4c7"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"2dbfc70d77aa612a8dee2615fc09e5621ad06e23","unresolved":false,"context_lines":[{"line_number":112,"context_line":"tftp_server \u003d undefined"},{"line_number":113,"context_line":"pxe_append_params \u003d nofb nomodeset vga\u003dnormal console\u003dtty0 console\u003dttyS0,115200n8"},{"line_number":114,"context_line":"EOF\u0027"},{"line_number":115,"context_line":"#sudo bash -c \u0027cat \u003c\u003c EOF \u003e\u003e /etc/kolla/config/nova-libvirt/libvirtd.conf"},{"line_number":116,"context_line":"#unix_sock_ro_perms \u003d \"0777\""},{"line_number":117,"context_line":"#unix_sock_rw_perms \u003d \"0777\""},{"line_number":118,"context_line":"#auth_unix_ro \u003d \"none\""}],"source_content_type":"text/x-sh","patch_set":25,"id":"7ffa3b31_2dceb2b3","line":115,"in_reply_to":"7ffa3b31_d2cecd58","updated":"2017-04-20 16:19:42.000000000","message":"It is still work in progress I am trying difference variations","commit_id":"11fcb070f611356a4130be8c9ee693d6d812e4c7"}]}