)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8163d8abec0aa3ec5e540be932243e8b604130f1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Changes for kubernetes 1.6.0 upgrade"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Author:    Serguei Bezverkhi \u003csbezverk@cisco.com\u003e"},{"line_number":12,"context_line":"Co-Authored-By: Kevin Fox \u003ckevin@efox.cc\u003e"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If58c17c587a0a7d8a9f063aaac2a674c5eb8db9f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":50,"id":"dfeb2761_32ab50d7","line":11,"updated":"2017-03-31 03:28:16.000000000","message":"this line won\u0027t be processed by the various infra tools and may break something.  The fact that your listed as an author in the commit log is sufficient.","commit_id":"161a69ffef069a8d630861182da22ef384f81686"}],"tests/bin/setup_canal.sh":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"915c443222fa83b6d88bfdf121702a6d345e01d4","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"curl \"$url\" -o /tmp/canal.yaml"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"sed -i \"s@192.168.0.0/16@172.16.130.0/22@\" /tmp/canal.yaml"},{"line_number":11,"context_line":"sed -i \"s@10.96.232.136@172.16.128.100@\" /tmp/canal.yaml"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"kubectl create -f /tmp/canal.yaml"}],"source_content_type":"text/x-sh","patch_set":43,"id":"dfeb2761_56d012ca","line":10,"range":{"start_line":10,"start_character":32,"end_line":10,"end_character":35},"updated":"2017-03-30 20:55:35.000000000","message":"can you please change 130 to 132","commit_id":"fc36518b8502bdffad0ca0fe5d6c471047d940cd"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8163d8abec0aa3ec5e540be932243e8b604130f1","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"curl \"$url\" -o /tmp/canal.yaml"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"sed -i \"s@192.168.0.0/16@172.16.132.0/22@\" /tmp/canal.yaml"},{"line_number":11,"context_line":"sed -i \"s@10.96.232.136@172.16.128.100@\" /tmp/canal.yaml"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"kubectl create -f /tmp/canal.yaml"}],"source_content_type":"text/x-sh","patch_set":50,"id":"dfeb2761_f2b4c837","line":10,"updated":"2017-03-31 03:28:16.000000000","message":"out of curiosity (for the deployment guide) why 132?","commit_id":"161a69ffef069a8d630861182da22ef384f81686"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"6147786fd9565af633ece0d04e405be5813af481","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"curl \"$url\" -o /tmp/canal.yaml"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"sed -i \"s@192.168.0.0/16@172.16.132.0/22@\" /tmp/canal.yaml"},{"line_number":11,"context_line":"sed -i \"s@10.96.232.136@172.16.128.100@\" /tmp/canal.yaml"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"kubectl create -f /tmp/canal.yaml"}],"source_content_type":"text/x-sh","patch_set":50,"id":"dfeb2761_7271d8e0","line":10,"in_reply_to":"dfeb2761_f2b4c837","updated":"2017-03-31 03:58:10.000000000","message":"AS you can see it is subneted, 132 puts it in the right subnet for 22 bit mask","commit_id":"161a69ffef069a8d630861182da22ef384f81686"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"3d740ceacb711b882d0dc02612ca00cbab53ff9d","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"curl \"$url\" -o /tmp/canal.yaml"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"sed -i \"s@192.168.0.0/16@172.16.132.0/22@\" /tmp/canal.yaml"},{"line_number":11,"context_line":"sed -i \"s@10.96.232.136@172.16.128.100@\" /tmp/canal.yaml"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"kubectl create -f /tmp/canal.yaml"}],"source_content_type":"text/x-sh","patch_set":51,"id":"dfeb2761_8047541e","line":10,"range":{"start_line":10,"start_character":33,"end_line":10,"end_character":35},"updated":"2017-03-31 12:56:46.000000000","message":"132\u003d\n10000100\nsubnet mask 22 bit \n11111100\n\nAs you can see 132 is exactly at the right border.","commit_id":"dc7e31192116d9567ca67ad5d42f4b27ce2a883e"}],"tools/setup_kubernetes.sh":[{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"8d7970b00ba8c8ca96991dda79dbc49ca0db81a5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -e"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"if [ -f /etc/redhat-release ]; then"},{"line_number":4,"context_line":"    cat \u003e /tmp/setup.$$ \u003c\u003c\"EOF\""},{"line_number":5,"context_line":"setenforce 0"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ffe62b97_b3a6790e","line":2,"updated":"2017-03-29 13:56:21.000000000","message":"Can we add a comment along the lines of \"Used for the Gate - not general purpose deployment\u0027?","commit_id":"0d442d0097a69c61069d598c1afe8db04f959601"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"8d7970b00ba8c8ca96991dda79dbc49ca0db81a5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"if [ -f /etc/redhat-release ]; then"},{"line_number":4,"context_line":"    cat \u003e /tmp/setup.$$ \u003c\u003c\"EOF\""},{"line_number":5,"context_line":"setenforce 0"},{"line_number":6,"context_line":"cat \u003c\u003c\"EOEF\" \u003e /etc/yum.repos.d/kubernetes.repo"},{"line_number":7,"context_line":"[kubernetes]"},{"line_number":8,"context_line":"name\u003dKubernetes"},{"line_number":9,"context_line":"baseurl\u003dhttp://yum.kubernetes.io/repos/kubernetes-el7-x86_64"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ffe62b97_93dff567","line":6,"updated":"2017-03-29 13:56:21.000000000","message":"Not for this review - but wow - some blank lines between sections of code would be great. :)","commit_id":"0d442d0097a69c61069d598c1afe8db04f959601"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"8d7970b00ba8c8ca96991dda79dbc49ca0db81a5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"if [ \"$1\" \u003d\u003d \"master\" ]; then"},{"line_number":32,"context_line":"    cat \u003e\u003e /tmp/setup.$$ \u003c\u003c\"EOF\""},{"line_number":33,"context_line":"[ -d /etc/kubernetes/manifests ] \u0026\u0026 rmdir /etc/kubernetes/manifests || true"},{"line_number":34,"context_line":"kubeadm init --skip-preflight-checks --service-cidr 172.16.128.0/24 --api-advertise-address $(cat /etc/nodepool/primary_node_private) | tee /tmp/kubeout"},{"line_number":35,"context_line":"grep \u0027kubeadm join --token\u0027 /tmp/kubeout | awk \u0027{print $3}\u0027 | sed \u0027s/[^\u003d]*\u003d//\u0027 \u003e /etc/kubernetes/token.txt"},{"line_number":36,"context_line":"grep \u0027kubeadm join --token\u0027 /tmp/kubeout | awk \u0027{print $4}\u0027 \u003e /etc/kubernetes/ip.txt"},{"line_number":37,"context_line":"rm -f /tmp/kubeout"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ffe62b97_1392c54c","line":34,"range":{"start_line":34,"start_character":84,"end_line":34,"end_character":91},"updated":"2017-03-29 13:56:21.000000000","message":"According to the help it\u0027s \"api-advertise-addresses\" - like the original code.\n\n[root@KollaDevAuto ~]# kubeadm init --help | grep api\n      --api-advertise-addresses stringSlice   The IP addresses to advertise, in case autodetection fails","commit_id":"0d442d0097a69c61069d598c1afe8db04f959601"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"8d7970b00ba8c8ca96991dda79dbc49ca0db81a5","unresolved":false,"context_lines":[{"line_number":43,"context_line":"fi"},{"line_number":44,"context_line":"cat \u003e\u003e /tmp/setup.$$ \u003c\u003c\"EOF\""},{"line_number":45,"context_line":"sed -i \u0027s/10.96.0.10/172.16.128.10/g\u0027 /etc/systemd/system/kubelet.service.d/10-kubeadm.conf"},{"line_number":46,"context_line":"sed -i \u0027s|KUBELET_KUBECONFIG_ARGS\u003d|KUBELET_KUBECONFIG_ARGS\u003d--cgroup-driver\u003dsystemd |g\u0027 i\\"},{"line_number":47,"context_line":"        /etc/systemd/system/kubelet.service.d/10-kubeadm.conf"},{"line_number":48,"context_line":"systemctl daemon-reload"},{"line_number":49,"context_line":"systemctl stop kubelet"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ffe62b97_f3940139","line":46,"updated":"2017-03-29 13:56:21.000000000","message":"Comment to explain this is a temp fix until https://github.com/kubernetes/kubernetes/issues/43805 is fixed?","commit_id":"0d442d0097a69c61069d598c1afe8db04f959601"},{"author":{"_account_id":18675,"name":"Sharath Rao","email":"sharath.rao@ericsson.com","username":"sharath.rao"},"change_message_id":"8f135f2c37d1627ec0e988cad9403f4db0e7b987","unresolved":false,"context_lines":[{"line_number":41,"context_line":"if [ \"$1\" \u003d\u003d \"master\" ]; then"},{"line_number":42,"context_line":"    cat \u003e\u003e /tmp/setup.$$ \u003c\u003c\"EOF\""},{"line_number":43,"context_line":"[ -d /etc/kubernetes/manifests ] \u0026\u0026 rmdir /etc/kubernetes/manifests || true"},{"line_number":44,"context_line":"kubeadm init --skip-preflight-checks --service-cidr 172.16.128.0/24 \\"},{"line_number":45,"context_line":"             --apiserver-advertise-address $(cat /etc/nodepool/primary_node_private) | tee /tmp/kubeout"},{"line_number":46,"context_line":"grep \u0027kubeadm join --token\u0027 /tmp/kubeout | awk \u0027{print $3}\u0027 | sed \u0027s/[^\u003d]*\u003d//\u0027 \u003e /etc/kubernetes/token.txt"},{"line_number":47,"context_line":"grep \u0027kubeadm join --token\u0027 /tmp/kubeout | awk \u0027{print $4}\u0027 \u003e /etc/kubernetes/ip.txt"}],"source_content_type":"text/x-sh","patch_set":14,"id":"ffe62b97_b74d303c","line":44,"range":{"start_line":44,"start_character":13,"end_line":44,"end_character":36},"updated":"2017-03-29 21:40:48.000000000","message":"Is it wise to skip this?","commit_id":"9695a024da1b5ee5c6b0d8fd0d826b090dc857a9"},{"author":{"_account_id":18675,"name":"Sharath Rao","email":"sharath.rao@ericsson.com","username":"sharath.rao"},"change_message_id":"4619dd0fdb315234b04bff2a3802391f05d08aa2","unresolved":false,"context_lines":[{"line_number":55,"context_line":"cat \u003e\u003e /tmp/setup.$$ \u003c\u003c\"EOF\""},{"line_number":56,"context_line":"sed -i \u0027s/10.96.0.10/172.16.128.10/g\u0027 /etc/systemd/system/kubelet.service.d/10-kubeadm.conf"},{"line_number":57,"context_line":"#sed -i \u0027s|RBAC|AlwaysAllow|g\u0027 /etc/kubernetes/manifests/kube-apiserver.yaml"},{"line_number":58,"context_line":"#sed -i \u0027s|insecure-port\u003d0|insecure-port\u003d8080|g\u0027 \\"},{"line_number":59,"context_line":"#        /etc/kubernetes/manifests/kube-apiserver.yaml "},{"line_number":60,"context_line":"systemctl daemon-reload"},{"line_number":61,"context_line":"systemctl stop kubelet"}],"source_content_type":"text/x-sh","patch_set":35,"id":"ffe62b97_d093feff","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":50},"updated":"2017-03-30 14:17:26.000000000","message":"Done we need this?","commit_id":"55aa68ea9c944fafc3ec6f3737565f15ed28fece"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8163d8abec0aa3ec5e540be932243e8b604130f1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"[ -d /etc/kubernetes/manifests ] \u0026\u0026 rmdir /etc/kubernetes/manifests || true"},{"line_number":50,"context_line":"kubeadm init --skip-preflight-checks --service-cidr 172.16.128.0/24 \\"},{"line_number":51,"context_line":"             --apiserver-advertise-address $(cat /etc/nodepool/primary_node_private) | tee /tmp/kubeout"},{"line_number":52,"context_line":"grep \u0027kubeadm join --token\u0027 /tmp/kubeout | awk \u0027{print $4}\u0027 \u003e /etc/kubernetes/token.txt"},{"line_number":53,"context_line":"grep \u0027kubeadm join --token\u0027 /tmp/kubeout | awk \u0027{print $5}\u0027 \u003e /etc/kubernetes/ip.txt"},{"line_number":54,"context_line":"rm -f /tmp/kubeout"},{"line_number":55,"context_line":"sed -i \u0027s|^#\\(Environment.*KUBELET_NETWORK_ARGS.*\\)|\\1|g\u0027 \\"}],"source_content_type":"text/x-sh","patch_set":50,"id":"dfeb2761_32c23087","line":52,"updated":"2017-03-31 03:28:16.000000000","message":"this may be why multinode isn\u0027t working .  Two kubeadm joins back to back may brea kkubeadm.  I suggest running it once and redirecting output to a temporary file.  Then awking the output as two serpate commands rather then piping.","commit_id":"161a69ffef069a8d630861182da22ef384f81686"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"21eefd02e3871d35e112d197e746336abda5d50a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"[ -d /etc/kubernetes/manifests ] \u0026\u0026 rmdir /etc/kubernetes/manifests || true"},{"line_number":50,"context_line":"kubeadm init --skip-preflight-checks --service-cidr 172.16.128.0/24 \\"},{"line_number":51,"context_line":"             --apiserver-advertise-address $(cat /etc/nodepool/primary_node_private) | tee /tmp/kubeout"},{"line_number":52,"context_line":"grep \u0027kubeadm join --token\u0027 /tmp/kubeout | awk \u0027{print $4}\u0027 \u003e /etc/kubernetes/token.txt"},{"line_number":53,"context_line":"grep \u0027kubeadm join --token\u0027 /tmp/kubeout | awk \u0027{print $5}\u0027 \u003e /etc/kubernetes/ip.txt"},{"line_number":54,"context_line":"rm -f /tmp/kubeout"},{"line_number":55,"context_line":"sed -i \u0027s|^#\\(Environment.*KUBELET_NETWORK_ARGS.*\\)|\\1|g\u0027 \\"}],"source_content_type":"text/x-sh","patch_set":50,"id":"dfeb2761_b2886ac6","line":52,"in_reply_to":"dfeb2761_32c23087","updated":"2017-03-31 15:43:29.000000000","message":"its not doing two kubeadm joins. its doing greps.","commit_id":"161a69ffef069a8d630861182da22ef384f81686"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"6147786fd9565af633ece0d04e405be5813af481","unresolved":false,"context_lines":[{"line_number":49,"context_line":"[ -d /etc/kubernetes/manifests ] \u0026\u0026 rmdir /etc/kubernetes/manifests || true"},{"line_number":50,"context_line":"kubeadm init --skip-preflight-checks --service-cidr 172.16.128.0/24 \\"},{"line_number":51,"context_line":"             --apiserver-advertise-address $(cat /etc/nodepool/primary_node_private) | tee /tmp/kubeout"},{"line_number":52,"context_line":"grep \u0027kubeadm join --token\u0027 /tmp/kubeout | awk \u0027{print $4}\u0027 \u003e /etc/kubernetes/token.txt"},{"line_number":53,"context_line":"grep \u0027kubeadm join --token\u0027 /tmp/kubeout | awk \u0027{print $5}\u0027 \u003e /etc/kubernetes/ip.txt"},{"line_number":54,"context_line":"rm -f /tmp/kubeout"},{"line_number":55,"context_line":"sed -i \u0027s|^#\\(Environment.*KUBELET_NETWORK_ARGS.*\\)|\\1|g\u0027 \\"}],"source_content_type":"text/x-sh","patch_set":50,"id":"dfeb2761_92457c73","line":52,"in_reply_to":"dfeb2761_32c23087","updated":"2017-03-31 03:58:10.000000000","message":"multimode is working as well as single node.","commit_id":"161a69ffef069a8d630861182da22ef384f81686"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8163d8abec0aa3ec5e540be932243e8b604130f1","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        count\u003d$((count + 1))"},{"line_number":86,"context_line":"        [ $count -gt 30 ] \u0026\u0026 echo kube-apiserver failed to come back up. \u0026\u0026 exit -1"},{"line_number":87,"context_line":"    done"},{"line_number":88,"context_line":"#FIXME This is a horible hack to get k8s 1.6 working. This should be removed in favor"},{"line_number":89,"context_line":"#      of more fine grained rules."},{"line_number":90,"context_line":"# It should be run on the master only when it is up, hence moving it inside of if"},{"line_number":91,"context_line":"kubectl update -f \u003c(cat \u003c\u003cEOF"}],"source_content_type":"text/x-sh","patch_set":50,"id":"dfeb2761_1254ccc9","line":88,"range":{"start_line":88,"start_character":1,"end_line":88,"end_character":6},"updated":"2017-03-31 03:28:16.000000000","message":"TODO(sbezverk) - FIXME is not a thing used in OpenStack.","commit_id":"161a69ffef069a8d630861182da22ef384f81686"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"6147786fd9565af633ece0d04e405be5813af481","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        count\u003d$((count + 1))"},{"line_number":86,"context_line":"        [ $count -gt 30 ] \u0026\u0026 echo kube-apiserver failed to come back up. \u0026\u0026 exit -1"},{"line_number":87,"context_line":"    done"},{"line_number":88,"context_line":"#FIXME This is a horible hack to get k8s 1.6 working. This should be removed in favor"},{"line_number":89,"context_line":"#      of more fine grained rules."},{"line_number":90,"context_line":"# It should be run on the master only when it is up, hence moving it inside of if"},{"line_number":91,"context_line":"kubectl update -f \u003c(cat \u003c\u003cEOF"}],"source_content_type":"text/x-sh","patch_set":50,"id":"dfeb2761_525ff440","line":88,"range":{"start_line":88,"start_character":1,"end_line":88,"end_character":6},"in_reply_to":"dfeb2761_1254ccc9","updated":"2017-03-31 03:58:10.000000000","message":"Done","commit_id":"161a69ffef069a8d630861182da22ef384f81686"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"8163d8abec0aa3ec5e540be932243e8b604130f1","unresolved":false,"context_lines":[{"line_number":108,"context_line":")"},{"line_number":109,"context_line":"    set -e"},{"line_number":110,"context_line":"fi"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-sh","patch_set":50,"id":"dfeb2761_9259fcff","line":111,"updated":"2017-03-31 03:28:16.000000000","message":"extra line can be deleted.","commit_id":"161a69ffef069a8d630861182da22ef384f81686"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"6147786fd9565af633ece0d04e405be5813af481","unresolved":false,"context_lines":[{"line_number":108,"context_line":")"},{"line_number":109,"context_line":"    set -e"},{"line_number":110,"context_line":"fi"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-sh","patch_set":50,"id":"dfeb2761_122e0ca5","line":111,"in_reply_to":"dfeb2761_9259fcff","updated":"2017-03-31 03:58:10.000000000","message":"Done","commit_id":"161a69ffef069a8d630861182da22ef384f81686"}]}