)]}'
{"helm/microservice/nova-api-create-simple-cell-job/templates/nova-api-create-cell.yaml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"a7d248cc456dea6887e4c53e709efed9a5907df5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            - name: KOLLA_CONFIG_STRATEGY"},{"line_number":61,"context_line":"              value: \"COPY_ONCE\""},{"line_number":62,"context_line":"          # This is needed as centos images nova user doesn\u0027t have permissions to"},{"line_number":63,"context_line":"          # change nova.conf."},{"line_number":64,"context_line":"          securityContext:"},{"line_number":65,"context_line":"              runAsUser: 0"},{"line_number":66,"context_line":"          command: ["}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7ffa3b31_dd130eb8","line":63,"updated":"2017-04-15 06:14:40.000000000","message":"the centos images do provide sudo capabilities for some commands:\nhttps://github.com/openstack/kolla/blob/master/docker/nova/nova-base/nova_sudoers#L1\n\nWhich command specifically in this bash script requires root access?  the cp operation?  If so - that should be handled by config.json.  With a config.json integration here, nova-manage can be run against an /etc/nova that is owned by the nova user.\n\nI think the root of the problem here is the cell code isn\u0027t using config.json to properly configure /etc/nova.","commit_id":"ad0972ab7325bc54218e47c02e69e8ca25a708bd"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"0b26b6bee86b85ac7166633de89afb66cd48b21a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"              value: \"\""},{"line_number":62,"context_line":"            - name: KOLLA_CONFIG_STRATEGY"},{"line_number":63,"context_line":"              value: \"COPY_ONCE\""},{"line_number":64,"context_line":"          # This is needed as centos images nova user doesn\u0027t have permissions to"},{"line_number":65,"context_line":"          # change nova.conf."},{"line_number":66,"context_line":"          securityContext:"},{"line_number":67,"context_line":"              runAsUser: 0"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"ff0f0b1f_f90c4c3c","line":64,"range":{"start_line":64,"start_character":12,"end_line":64,"end_character":16},"updated":"2017-05-20 17:41:12.000000000","message":"please make this a todo since this is a security problem.  This is easily rectified in the images.","commit_id":"e9bce849b6001682d86b7036754fdebf12415123"},{"author":{"_account_id":17591,"name":"Steve Wilkerson","email":"wilkers.steve@gmail.com","username":"srwilkers"},"change_message_id":"5884bb2030ed31505d2a8ef3bdb2e76005628bb4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"              value: \"\""},{"line_number":62,"context_line":"            - name: KOLLA_CONFIG_STRATEGY"},{"line_number":63,"context_line":"              value: \"COPY_ONCE\""},{"line_number":64,"context_line":"          # This is needed as centos images nova user doesn\u0027t have permissions to"},{"line_number":65,"context_line":"          # change nova.conf."},{"line_number":66,"context_line":"          securityContext:"},{"line_number":67,"context_line":"              runAsUser: 0"},{"line_number":68,"context_line":"          command: ["},{"line_number":69,"context_line":"              \"bash\","},{"line_number":70,"context_line":"              \"-ce\","}],"source_content_type":"text/x-yaml","patch_set":29,"id":"ff0f0b1f_602f54a1","line":67,"range":{"start_line":64,"start_character":0,"end_line":67,"end_character":26},"updated":"2017-05-22 00:43:46.000000000","message":"This shouldn\u0027t be necessary, as the containers already set to run as user 0: https://github.com/openstack/kolla-kubernetes/blob/f4504e8371117c3d24da748ef2b3833a16437721/helm/microservice/nova-api-create-simple-cell-job/templates/nova-api-create-cell.yaml#L50-L51\n\nThat is, unless I\u0027m missing something here.","commit_id":"e9bce849b6001682d86b7036754fdebf12415123"}],"services/nova/nova-libvirt-secret.yml.j2":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"a7d248cc456dea6887e4c53e709efed9a5907df5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{%- macro secret() -%}"},{"line_number":2,"context_line":"\u003csecret ephemeral\u003d\u0027no\u0027 private\u003d\u0027no\u0027\u003e"},{"line_number":3,"context_line":"  \u003cuuid\u003e{{ cinder_rbd_secret_uuid }}\u003c/uuid\u003e"},{"line_number":4,"context_line":"  \u003cusage type\u003d\u0027ceph\u0027\u003e"},{"line_number":5,"context_line":"    \u003cname\u003eclient.cinder secret\u003c/name\u003e"},{"line_number":6,"context_line":"  \u003c/usage\u003e"}],"source_content_type":"text/x-jinja2","patch_set":17,"id":"7ffa3b31_bd1842d3","line":3,"updated":"2017-04-15 06:14:40.000000000","message":"is this change needed because ceph hasn\u0027t been ported? (just trying to learn)","commit_id":"ad0972ab7325bc54218e47c02e69e8ca25a708bd"}],"tests/bin/ceph_workflow.sh":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"a7d248cc456dea6887e4c53e709efed9a5907df5","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    --namespace kolla --name nova-novncproxy-svc \\"},{"line_number":113,"context_line":"    --values /tmp/general_config.yaml --values /tmp/ceph_config.yaml"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"if [ \"x$branch\" !\u003d \"x2\" -a \"x$branch\" !\u003d \"x3\" ]; then"},{"line_number":116,"context_line":"helm install kolla/nova-placement-svc --debug --version $VERSION \\"},{"line_number":117,"context_line":"    --namespace kolla --name nova-placement-svc \\"},{"line_number":118,"context_line":"    --values /tmp/general_config.yaml --values /tmp/ceph_config.yaml"}],"source_content_type":"text/x-sh","patch_set":17,"id":"7ffa3b31_9d0d8692","line":115,"updated":"2017-04-15 06:14:40.000000000","message":"this can probably be rebased - I am pretty sure this merged with the placement API.","commit_id":"ad0972ab7325bc54218e47c02e69e8ca25a708bd"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"a7d248cc456dea6887e4c53e709efed9a5907df5","unresolved":false,"context_lines":[{"line_number":229,"context_line":"    --namespace kolla --name cinder-create-keystone-servicev2 \\"},{"line_number":230,"context_line":"    --values /tmp/general_config.yaml --values /tmp/ceph_config.yaml"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"if [ \"x$branch\" !\u003d \"x2\" -a \"x$branch\" !\u003d \"x3\" ]; then"},{"line_number":233,"context_line":"helm install kolla/nova-placement-create-keystone-service-job --debug --version $VERSION \\"},{"line_number":234,"context_line":"    --namespace kolla --name nova-placement-create-keystone-service \\"},{"line_number":235,"context_line":"    --values /tmp/general_config.yaml --values /tmp/ceph_config.yaml"}],"source_content_type":"text/x-sh","patch_set":17,"id":"7ffa3b31_7d12bab3","line":232,"updated":"2017-04-15 06:14:40.000000000","message":"ditto","commit_id":"ad0972ab7325bc54218e47c02e69e8ca25a708bd"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"a7d248cc456dea6887e4c53e709efed9a5907df5","unresolved":false,"context_lines":[{"line_number":289,"context_line":"helm install kolla/heat-create-keystone-user-job --version $VERSION \\"},{"line_number":290,"context_line":"    --namespace kolla --name heat-create-keystone-user"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"if [ \"x$branch\" !\u003d \"x2\" -a \"x$branch\" !\u003d \"x3\" ]; then"},{"line_number":293,"context_line":"helm install kolla/nova-placement-create-keystone-endpoint-public-job --debug --version $VERSION \\"},{"line_number":294,"context_line":"    --namespace kolla --name nova-placement-create-keystone-endpoint-public \\"},{"line_number":295,"context_line":"    --values /tmp/general_config.yaml --values /tmp/ceph_config.yaml"}],"source_content_type":"text/x-sh","patch_set":17,"id":"7ffa3b31_5d27fe13","line":292,"updated":"2017-04-15 06:14:40.000000000","message":"ditto","commit_id":"ad0972ab7325bc54218e47c02e69e8ca25a708bd"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"a7d248cc456dea6887e4c53e709efed9a5907df5","unresolved":false,"context_lines":[{"line_number":447,"context_line":""},{"line_number":448,"context_line":"helm ls"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"if [ \"x$branch\" !\u003d \"x2\" -a \"x$branch\" !\u003d \"x3\" ]; then"},{"line_number":451,"context_line":"helm install kolla/nova-placement-deployment --debug --version $VERSION \\"},{"line_number":452,"context_line":"    --namespace kolla --name nova-placement-deployment \\"},{"line_number":453,"context_line":"    --values /tmp/general_config.yaml --values /tmp/ceph_config.yaml"}],"source_content_type":"text/x-sh","patch_set":17,"id":"7ffa3b31_3d24320d","line":450,"updated":"2017-04-15 06:14:40.000000000","message":"ditto","commit_id":"ad0972ab7325bc54218e47c02e69e8ca25a708bd"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"a7d248cc456dea6887e4c53e709efed9a5907df5","unresolved":false,"context_lines":[{"line_number":532,"context_line":"helm install kolla/nova-api-create-simple-cell-job --debug --version $VERSION \\"},{"line_number":533,"context_line":"    --namespace kolla --name nova-api-create-simple-cell-job \\"},{"line_number":534,"context_line":"    --values /tmp/general_config.yaml --values /tmp/ceph_config.yaml"},{"line_number":535,"context_line":"fi"},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"#kollakube res create pod keepalived"},{"line_number":538,"context_line":""}],"source_content_type":"text/x-sh","patch_set":17,"id":"7ffa3b31_5d6c9e35","line":535,"updated":"2017-04-15 06:14:40.000000000","message":"sbezverk is doing some work in this area on a cell patch that has merged:\nhttps://review.openstack.org/#/c/456954/","commit_id":"ad0972ab7325bc54218e47c02e69e8ca25a708bd"}]}