)]}'
{"helm/microservice/keepalived-daemonset/templates/keepalived-daemonset.yaml":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"6b0cc09add9312220a86deaa03f9327285bd1d32","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    spec:"},{"line_number":64,"context_line":"      hostNetwork: True"},{"line_number":65,"context_line":"      hostIPC: True"},{"line_number":66,"context_line":"      hostPID: True #Needed for pidfile."},{"line_number":67,"context_line":"      nodeSelector:"},{"line_number":68,"context_line":"          {{ $selectorKey }}: {{ $selectorValue | quote }}"},{"line_number":69,"context_line":"      containers:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7ffa3b31_dbefa1ae","line":66,"updated":"2017-04-14 15:50:09.000000000","message":"I don\u0027t think this is really needed to map the pidfile.  The role of hostPID is to run all processes in the host PID namespace (i.e. turn off PID namespace isolation).","commit_id":"09deec563756bf37fe9592fd3bad90367cd1d004"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"f63b3dbde62557652d754ea047e0f73c837a2a02","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                command:"},{"line_number":77,"context_line":"                - /bin/bash"},{"line_number":78,"context_line":"                - -c"},{"line_number":79,"context_line":"                - systemctl stop keepalived "},{"line_number":80,"context_line":"          env:"},{"line_number":81,"context_line":"            - name: KOLLA_CONFIG_STRATEGY"},{"line_number":82,"context_line":"              value: COPY_ONCE"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7ffa3b31_6740e736","line":79,"updated":"2017-04-15 00:04:00.000000000","message":"I don\u0027t think this will work from within the container, as its not running systemd.","commit_id":"8269c8c6f98d028a45cf428274e609ad0006da36"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"59df64b936a1f96172bbf6a5382bc2f9a16ee792","unresolved":false,"context_lines":[{"line_number":69,"context_line":"          imagePullPolicy: {{ $imagePullPolicy | quote }}"},{"line_number":70,"context_line":"          name: main"},{"line_number":71,"context_line":"          securityContext:"},{"line_number":72,"context_line":"            privileged: true"},{"line_number":73,"context_line":"          env:"},{"line_number":74,"context_line":"            - name: KOLLA_CONFIG_STRATEGY"},{"line_number":75,"context_line":"              value: COPY_ONCE"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7ffa3b31_3f7e51e4","line":72,"updated":"2017-04-17 13:18:37.000000000","message":"Does this need to run in \u0027privileged: true\u0027 or can we just use NET_ADMIN here?","commit_id":"75e091c73b8d547295cb21dbc324d0904766b4e9"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"54857e6ab67dab163c77136dfa43e8603888e392","unresolved":false,"context_lines":[{"line_number":89,"context_line":"          emptyDir: {}"},{"line_number":90,"context_line":"        - name: keepalived-run"},{"line_number":91,"context_line":"          hostPath:"},{"line_number":92,"context_line":"            path: /var/run/keepalived"},{"line_number":93,"context_line":"        - name: host-lib-modules"},{"line_number":94,"context_line":"          hostPath:"},{"line_number":95,"context_line":"            path: /lib/modules"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7ffa3b31_5d693ebc","line":92,"updated":"2017-04-15 04:26:17.000000000","message":"surprised you would need this hostmount.","commit_id":"75e091c73b8d547295cb21dbc324d0904766b4e9"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"8ece91a984252cbfb7b35a266c5138b95e1f335a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"          emptyDir: {}"},{"line_number":90,"context_line":"        - name: keepalived-run"},{"line_number":91,"context_line":"          hostPath:"},{"line_number":92,"context_line":"            path: /var/run/keepalived"},{"line_number":93,"context_line":"        - name: host-lib-modules"},{"line_number":94,"context_line":"          hostPath:"},{"line_number":95,"context_line":"            path: /lib/modules"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7ffa3b31_a2737a80","line":92,"in_reply_to":"7ffa3b31_5d693ebc","updated":"2017-04-15 12:40:47.000000000","message":"sorry getting you surprised, not sure what to do to unsurprised you..","commit_id":"75e091c73b8d547295cb21dbc324d0904766b4e9"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"7c385f7bd30d4bb053edbc783908859cc3ded3d7","unresolved":false,"context_lines":[{"line_number":89,"context_line":"          emptyDir: {}"},{"line_number":90,"context_line":"        - name: keepalived-run"},{"line_number":91,"context_line":"          hostPath:"},{"line_number":92,"context_line":"            path: /var/run/keepalived"},{"line_number":93,"context_line":"        - name: host-lib-modules"},{"line_number":94,"context_line":"          hostPath:"},{"line_number":95,"context_line":"            path: /lib/modules"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7ffa3b31_e29e2206","line":92,"in_reply_to":"7ffa3b31_a2737a80","updated":"2017-04-15 14:50:29.000000000","message":"what I mean here is are you sure this is needed?  It was never needed in the ansible implementation:\nhttps://github.com/openstack/kolla-ansible/blob/master/ansible/roles/haproxy/defaults/main.yml#L22-L25\n\nunless that is where the haproxy socket is being shared from.","commit_id":"75e091c73b8d547295cb21dbc324d0904766b4e9"},{"author":{"_account_id":23928,"name":"Pete Birley","email":"petebirley@gmail.com","username":"portdirect"},"change_message_id":"2f02a90bcbe1ec4788c579a15fcb66e30142df94","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                command:"},{"line_number":77,"context_line":"                - /bin/bash"},{"line_number":78,"context_line":"                - -c"},{"line_number":79,"context_line":"                - sudo ifconfig {{ $apiInterface }} delete {{ $kollaKubernetesExternalVIP }}"},{"line_number":80,"context_line":"          securityContext:"},{"line_number":81,"context_line":"            privileged: true"},{"line_number":82,"context_line":"          env:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7ffa3b31_df552d52","line":79,"updated":"2017-04-17 13:20:49.000000000","message":"Would this not be better with iproute2 commands?","commit_id":"3f46e13ce012700009d11866ec926d8d9c363e7f"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"89c6e2cad485d74d64f50d1c37bba0a2296e1f64","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                command:"},{"line_number":77,"context_line":"                - /bin/bash"},{"line_number":78,"context_line":"                - -c"},{"line_number":79,"context_line":"                - sudo ifconfig {{ $apiInterface }} delete {{ $kollaKubernetesExternalVIP }}"},{"line_number":80,"context_line":"          securityContext:"},{"line_number":81,"context_line":"            privileged: true"},{"line_number":82,"context_line":"          env:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7ffa3b31_b0384bd3","line":79,"in_reply_to":"7ffa3b31_df552d52","updated":"2017-04-17 16:53:02.000000000","message":"depends on if iproute2 is installed in the container? Not sure.\n\nProbably should shoot the keepalived right away here too, just to make sure it doesn\u0027t get killed 30 seconds later and decide to put the ip back.","commit_id":"3f46e13ce012700009d11866ec926d8d9c363e7f"}],"tests/bin/ceph_workflow.sh":[{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"54857e6ab67dab163c77136dfa43e8603888e392","unresolved":false,"context_lines":[{"line_number":519,"context_line":"    --namespace kolla --name keepalived-daemonset \\"},{"line_number":520,"context_line":"    --values /tmp/general_config.yaml --values /tmp/ceph_config.yaml"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"#kollakube res create pod keepalived"},{"line_number":523,"context_line":""},{"line_number":524,"context_line":"$DIR/tools/pull_containers.sh kolla"},{"line_number":525,"context_line":"$DIR/tools/wait_for_pods.sh kolla"}],"source_content_type":"text/x-sh","patch_set":8,"id":"7ffa3b31_1d63b6de","line":522,"updated":"2017-04-15 04:26:17.000000000","message":"can probably delete this cruft","commit_id":"75e091c73b8d547295cb21dbc324d0904766b4e9"}]}