)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"c93a416f94af9faae66ac5c7a0672d931c36517c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# Valid options are [ centos, oraclelinux, ubuntu ]"},{"line_number":30,"context_line":"kolla_base_distro: \"centos\""},{"line_number":31,"context_line":"# Valid options are [ binary, source ]"},{"line_number":32,"context_line":"kolla_install_type: \"source\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"kolla_internal_vip_address: \"{{ kolla_internal_address }}\""},{"line_number":35,"context_line":"kolla_internal_fqdn: \"{{ kolla_internal_vip_address }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ff0f0b1f_cfd413c0","line":32,"range":{"start_line":32,"start_character":21,"end_line":32,"end_character":27},"updated":"2017-05-21 15:43:13.000000000","message":"unnecessary change","commit_id":"cc813df5fb4539c92dc8a5b4e90ff3a2deebed24"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"9d3e6ed2ebc9d34075cccae17d034aa984b46f3e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# Valid options are [ centos, oraclelinux, ubuntu ]"},{"line_number":30,"context_line":"kolla_base_distro: \"centos\""},{"line_number":31,"context_line":"# Valid options are [ binary, source ]"},{"line_number":32,"context_line":"kolla_install_type: \"source\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"kolla_internal_vip_address: \"{{ kolla_internal_address }}\""},{"line_number":35,"context_line":"kolla_internal_fqdn: \"{{ kolla_internal_vip_address }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ff0f0b1f_55a89475","line":32,"range":{"start_line":32,"start_character":21,"end_line":32,"end_character":27},"in_reply_to":"ff0f0b1f_cfd413c0","updated":"2017-05-21 20:57:56.000000000","message":"Ok. I will put this change back to the AIO script then.","commit_id":"cc813df5fb4539c92dc8a5b4e90ff3a2deebed24"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"c93a416f94af9faae66ac5c7a0672d931c36517c","unresolved":false,"context_lines":[{"line_number":290,"context_line":"# These roles are required for Kolla to be operation, however a savvy deployer"},{"line_number":291,"context_line":"# could disable some of these required roles and run their own services."},{"line_number":292,"context_line":"enable_glance: \"yes\""},{"line_number":293,"context_line":"enable_haproxy: \"no\""},{"line_number":294,"context_line":"enable_keystone: \"yes\""},{"line_number":295,"context_line":"enable_mariadb: \"yes\""},{"line_number":296,"context_line":"enable_memcached: \"yes\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ff0f0b1f_4f4b63af","line":293,"range":{"start_line":293,"start_character":17,"end_line":293,"end_character":19},"updated":"2017-05-21 15:43:13.000000000","message":"haproxy keep yes is better for me","commit_id":"cc813df5fb4539c92dc8a5b4e90ff3a2deebed24"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"9d3e6ed2ebc9d34075cccae17d034aa984b46f3e","unresolved":false,"context_lines":[{"line_number":290,"context_line":"# These roles are required for Kolla to be operation, however a savvy deployer"},{"line_number":291,"context_line":"# could disable some of these required roles and run their own services."},{"line_number":292,"context_line":"enable_glance: \"yes\""},{"line_number":293,"context_line":"enable_haproxy: \"no\""},{"line_number":294,"context_line":"enable_keystone: \"yes\""},{"line_number":295,"context_line":"enable_mariadb: \"yes\""},{"line_number":296,"context_line":"enable_memcached: \"yes\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ff0f0b1f_b5cc906a","line":293,"range":{"start_line":293,"start_character":17,"end_line":293,"end_character":19},"in_reply_to":"ff0f0b1f_4f4b63af","updated":"2017-05-21 20:57:56.000000000","message":"Ok. Same as above. Will put it back to the AIO script.","commit_id":"cc813df5fb4539c92dc8a5b4e90ff3a2deebed24"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"c93a416f94af9faae66ac5c7a0672d931c36517c","unresolved":false,"context_lines":[{"line_number":307,"context_line":"enable_ceph: \"no\""},{"line_number":308,"context_line":"enable_ceph_rgw: \"no\""},{"line_number":309,"context_line":"enable_chrony: \"no\""},{"line_number":310,"context_line":"enable_cinder: \"yes\""},{"line_number":311,"context_line":"enable_cinder_backend_hnas_iscsi: \"no\""},{"line_number":312,"context_line":"enable_cinder_backend_hnas_nfs: \"no\""},{"line_number":313,"context_line":"enable_cinder_backend_iscsi: \"yes\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ff0f0b1f_efd117cf","line":310,"range":{"start_line":310,"start_character":16,"end_line":310,"end_character":19},"updated":"2017-05-21 15:43:13.000000000","message":"no need to change it, cinder is optional","commit_id":"cc813df5fb4539c92dc8a5b4e90ff3a2deebed24"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"9d3e6ed2ebc9d34075cccae17d034aa984b46f3e","unresolved":false,"context_lines":[{"line_number":307,"context_line":"enable_ceph: \"no\""},{"line_number":308,"context_line":"enable_ceph_rgw: \"no\""},{"line_number":309,"context_line":"enable_chrony: \"no\""},{"line_number":310,"context_line":"enable_cinder: \"yes\""},{"line_number":311,"context_line":"enable_cinder_backend_hnas_iscsi: \"no\""},{"line_number":312,"context_line":"enable_cinder_backend_hnas_nfs: \"no\""},{"line_number":313,"context_line":"enable_cinder_backend_iscsi: \"yes\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"ff0f0b1f_95c74c46","line":310,"range":{"start_line":310,"start_character":16,"end_line":310,"end_character":19},"in_reply_to":"ff0f0b1f_efd117cf","updated":"2017-05-21 20:57:56.000000000","message":"Sure. Agree.  Will use the AIO script to over-ride instead.","commit_id":"cc813df5fb4539c92dc8a5b4e90ff3a2deebed24"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"639e1d8de60adc25eaddd7746187d08ac40c7d6a","unresolved":false,"context_lines":[{"line_number":262,"context_line":"# OpenStack options"},{"line_number":263,"context_line":"####################"},{"line_number":264,"context_line":"openstack_release: \"auto\""},{"line_number":265,"context_line":"openstack_logging_debug: \"True\""},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"openstack_region_name: \"RegionOne\""},{"line_number":268,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ff0f0b1f_9bc96f5a","line":265,"range":{"start_line":265,"start_character":26,"end_line":265,"end_character":30},"updated":"2017-05-24 01:47:45.000000000","message":"no need to change","commit_id":"5ba91e15b2a47eb991a0cf1c942bbe3c543b52de"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"5e610a740da1ffa05e9a12a3432492eef3948361","unresolved":false,"context_lines":[{"line_number":262,"context_line":"# OpenStack options"},{"line_number":263,"context_line":"####################"},{"line_number":264,"context_line":"openstack_release: \"auto\""},{"line_number":265,"context_line":"openstack_logging_debug: \"True\""},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"openstack_region_name: \"RegionOne\""},{"line_number":268,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"ff0f0b1f_866232d7","line":265,"range":{"start_line":265,"start_character":26,"end_line":265,"end_character":30},"in_reply_to":"ff0f0b1f_9bc96f5a","updated":"2017-05-24 02:12:09.000000000","message":"Ok. I will set it back to False.","commit_id":"5ba91e15b2a47eb991a0cf1c942bbe3c543b52de"}],"tools/setup_kube_AIO.sh":[{"author":{"_account_id":22368,"name":"Justin Scott","email":"justin.a.scott@intel.com","username":"jascott1"},"change_message_id":"b67e50a997ca11efebc84d72acf06fbdd8585164","unresolved":false,"context_lines":[{"line_number":4,"context_line":"## This is meant to set up Kolla Kubernetes All-In-One for CentOS-7"},{"line_number":5,"context_line":"## Cinder iSCSI backend is used here"},{"line_number":6,"context_line":"## Note that $1 will be the kube proxy IP, $2 will be the tunnel_interface and $3 will be the ext_interface_name"},{"line_number":7,"context_line":"## Run the script as root user"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"## Ensure that the required parameters are passed in"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f013ff3_f27b69bb","line":7,"updated":"2017-05-16 17:37:45.000000000","message":"Why not use sudo where needed?","commit_id":"2de515d236852fad2dd8e0a5fa92f41df7b6390b"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"235a556907e011512160b8e7b3979ce29339f6bb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"## This is meant to set up Kolla Kubernetes All-In-One for CentOS-7"},{"line_number":5,"context_line":"## Cinder iSCSI backend is used here"},{"line_number":6,"context_line":"## Note that $1 will be the kube proxy IP, $2 will be the tunnel_interface and $3 will be the ext_interface_name"},{"line_number":7,"context_line":"## Run the script as root user"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"## Ensure that the required parameters are passed in"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f013ff3_6e46487f","line":7,"in_reply_to":"1f013ff3_f27b69bb","updated":"2017-05-17 04:45:23.000000000","message":"@Justin, I agree that it will be good to use sudo whenever possible, however there are some commands that do not appear to  work even as sudo user, e.g.\n\n\n[centos@centos7 ~]$ sudo echo 1 \u003e /proc/sys/net/bridge/bridge-nf-call-iptables\nbash: /proc/sys/net/bridge/bridge-nf-call-iptables: Permission denied\n[centos@centos7 ~]$\n\n\nThe deployment guide asked us to use manual approach at this point in time.  But I am trying to follow what the Gate is doing as we know that those steps are tested to be working.","commit_id":"2de515d236852fad2dd8e0a5fa92f41df7b6390b"},{"author":{"_account_id":22368,"name":"Justin Scott","email":"justin.a.scott@intel.com","username":"jascott1"},"change_message_id":"b67e50a997ca11efebc84d72acf06fbdd8585164","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"## Install Kubernetes 1.6.2 and other dependencies"},{"line_number":52,"context_line":"kubelet_version\u003d1.6.2-0"},{"line_number":53,"context_line":"yum install -y docker ebtables kubeadm-$kubelet_version kubectl-$kubelet_version kubelet-$kubelet_version kubernetes-cni-$kubelet_version git gcc python-devel libffi-devel openssl-devel crudini"},{"line_number":54,"context_line":"yum install -y python-docker-py"},{"line_number":55,"context_line":"sudo systemctl enable docker"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f013ff3_b2096196","line":52,"updated":"2017-05-16 17:37:45.000000000","message":"Consider moving this to top to make it easier to specify k8s version.","commit_id":"2de515d236852fad2dd8e0a5fa92f41df7b6390b"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"235a556907e011512160b8e7b3979ce29339f6bb","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"## Install Kubernetes 1.6.2 and other dependencies"},{"line_number":52,"context_line":"kubelet_version\u003d1.6.2-0"},{"line_number":53,"context_line":"yum install -y docker ebtables kubeadm-$kubelet_version kubectl-$kubelet_version kubelet-$kubelet_version kubernetes-cni-$kubelet_version git gcc python-devel libffi-devel openssl-devel crudini"},{"line_number":54,"context_line":"yum install -y python-docker-py"},{"line_number":55,"context_line":"sudo systemctl enable docker"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f013ff3_0e090430","line":52,"in_reply_to":"1f013ff3_b2096196","updated":"2017-05-17 04:45:23.000000000","message":"Agree. I will move it up.","commit_id":"2de515d236852fad2dd8e0a5fa92f41df7b6390b"},{"author":{"_account_id":22368,"name":"Justin Scott","email":"justin.a.scott@intel.com","username":"jascott1"},"change_message_id":"b67e50a997ca11efebc84d72acf06fbdd8585164","unresolved":false,"context_lines":[{"line_number":75,"context_line":"systemctl start docker"},{"line_number":76,"context_line":"systemctl restart kubelet"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"kubeadm init --skip-preflight-checks --service-cidr 172.16.128.0/24 --pod-network-cidr 172.16.132.0/22"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"mkdir -p ~/.kube"},{"line_number":81,"context_line":"cp /etc/kubernetes/admin.conf ~/.kube/config"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f013ff3_12225501","line":78,"updated":"2017-05-16 17:37:45.000000000","message":"nit: cidrs dont match the deployment guide and seem arbitrary.","commit_id":"2de515d236852fad2dd8e0a5fa92f41df7b6390b"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"235a556907e011512160b8e7b3979ce29339f6bb","unresolved":false,"context_lines":[{"line_number":75,"context_line":"systemctl start docker"},{"line_number":76,"context_line":"systemctl restart kubelet"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"kubeadm init --skip-preflight-checks --service-cidr 172.16.128.0/24 --pod-network-cidr 172.16.132.0/22"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"mkdir -p ~/.kube"},{"line_number":81,"context_line":"cp /etc/kubernetes/admin.conf ~/.kube/config"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f013ff3_d1173d45","line":78,"in_reply_to":"1f013ff3_12225501","updated":"2017-05-17 04:45:23.000000000","message":"This is the value used by the Gate.  Since the aim of this script is to help developer get their system up in the shortest possible time, I think it is better to use the same convention as the Gate.","commit_id":"2de515d236852fad2dd8e0a5fa92f41df7b6390b"},{"author":{"_account_id":22368,"name":"Justin Scott","email":"justin.a.scott@intel.com","username":"jascott1"},"change_message_id":"b67e50a997ca11efebc84d72acf06fbdd8585164","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"## Setup Canal"},{"line_number":105,"context_line":"url\u003d\"https://raw.githubusercontent.com/projectcalico/canal/master\""},{"line_number":106,"context_line":"url\u003d\"$url/k8s-install/1.6/canal.yaml\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"curl \"$url\" -o /tmp/canal.yaml"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f013ff3_52569d5e","line":106,"updated":"2017-05-16 17:37:45.000000000","message":"Consider making canal version a variable to be easier to change when it changes next.","commit_id":"2de515d236852fad2dd8e0a5fa92f41df7b6390b"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"235a556907e011512160b8e7b3979ce29339f6bb","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"## Setup Canal"},{"line_number":105,"context_line":"url\u003d\"https://raw.githubusercontent.com/projectcalico/canal/master\""},{"line_number":106,"context_line":"url\u003d\"$url/k8s-install/1.6/canal.yaml\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"curl \"$url\" -o /tmp/canal.yaml"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f013ff3_ce02fc0b","line":106,"in_reply_to":"1f013ff3_52569d5e","updated":"2017-05-17 04:45:23.000000000","message":"Ok. I will update this as well.","commit_id":"2de515d236852fad2dd8e0a5fa92f41df7b6390b"},{"author":{"_account_id":22368,"name":"Justin Scott","email":"justin.a.scott@intel.com","username":"jascott1"},"change_message_id":"b67e50a997ca11efebc84d72acf06fbdd8585164","unresolved":false,"context_lines":[{"line_number":108,"context_line":"curl \"$url\" -o /tmp/canal.yaml"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"url\u003d\"https://raw.githubusercontent.com/projectcalico/canal/master\""},{"line_number":111,"context_line":"url\u003d\"$url/k8s-install/1.6/rbac.yaml\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"curl \"$url\" -o /tmp/rbac.yaml"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f013ff3_52257dc1","line":111,"updated":"2017-05-16 17:37:45.000000000","message":"Consider making 1.6 a var (at the top) to make it easier to change next.","commit_id":"2de515d236852fad2dd8e0a5fa92f41df7b6390b"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"235a556907e011512160b8e7b3979ce29339f6bb","unresolved":false,"context_lines":[{"line_number":108,"context_line":"curl \"$url\" -o /tmp/canal.yaml"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"url\u003d\"https://raw.githubusercontent.com/projectcalico/canal/master\""},{"line_number":111,"context_line":"url\u003d\"$url/k8s-install/1.6/rbac.yaml\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"curl \"$url\" -o /tmp/rbac.yaml"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f013ff3_9102d508","line":111,"in_reply_to":"1f013ff3_52257dc1","updated":"2017-05-17 04:45:23.000000000","message":"Ok. Same as above.","commit_id":"2de515d236852fad2dd8e0a5fa92f41df7b6390b"},{"author":{"_account_id":22368,"name":"Justin Scott","email":"justin.a.scott@intel.com","username":"jascott1"},"change_message_id":"b67e50a997ca11efebc84d72acf06fbdd8585164","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"## Set libvirt type to QEMU"},{"line_number":257,"context_line":"crudini --set /etc/kolla/nova-compute/nova.conf libvirt virt_type qemu"},{"line_number":258,"context_line":"crudini --set /etc/kolla/nova-compute/nova.conf libvirt cpu_mode none"},{"line_number":259,"context_line":"crudini --set /etc/kolla/keystone/keystone.conf cache enabled False"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f013ff3_b2660129","line":257,"updated":"2017-05-16 17:37:45.000000000","message":"Where does crudini get installed? Its not called out here or used in the Deployment Guide.","commit_id":"2de515d236852fad2dd8e0a5fa92f41df7b6390b"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"235a556907e011512160b8e7b3979ce29339f6bb","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"## Set libvirt type to QEMU"},{"line_number":257,"context_line":"crudini --set /etc/kolla/nova-compute/nova.conf libvirt virt_type qemu"},{"line_number":258,"context_line":"crudini --set /etc/kolla/nova-compute/nova.conf libvirt cpu_mode none"},{"line_number":259,"context_line":"crudini --set /etc/kolla/keystone/keystone.conf cache enabled False"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f013ff3_1137e5e5","line":257,"in_reply_to":"1f013ff3_b2660129","updated":"2017-05-17 04:45:23.000000000","message":"This is used in the Gate.  It is a different approach from the Deployment Guide but will give the same end result.","commit_id":"2de515d236852fad2dd8e0a5fa92f41df7b6390b"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"0691e5117240616c78922447f08b76fcd7cc232c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"## Run the script as root user"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"## Version Pinning"},{"line_number":11,"context_line":"kubelet_version\u003d1.6.2-0"},{"line_number":12,"context_line":"canal_version\u003d1.6"},{"line_number":13,"context_line":"HELM_VERSION\u003d\"2.3.0\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff0f0b1f_1a187d7f","line":10,"updated":"2017-05-17 12:07:49.000000000","message":"Consider optional inputs for versions as these change rapidly and will be a pain to constantly update the script.","commit_id":"02e66914b5c5b66f9f9d7c01c6bcff8c5e581a28"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"0691e5117240616c78922447f08b76fcd7cc232c","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"## Ensure that the required parameters are passed in"},{"line_number":17,"context_line":"if [ \"$#\" -ne 3 ]"},{"line_number":18,"context_line":"then"},{"line_number":19,"context_line":"  echo \"Please provide the following Information to the script: \\$1 for kube proxy IP, \\$2 for tunnel_interface, \\$3 for ext interface\""},{"line_number":20,"context_line":"  exit 1"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff0f0b1f_9a2a4d8e","line":17,"updated":"2017-05-17 12:07:49.000000000","message":"As you are using bash explicitly - why not use bash notation throughout? Like [[ ]] etc.","commit_id":"02e66914b5c5b66f9f9d7c01c6bcff8c5e581a28"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"0691e5117240616c78922447f08b76fcd7cc232c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"fi"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"## Setup Host"},{"line_number":25,"context_line":"yum install -y net-tools wget telnet"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff0f0b1f_3d08db26","line":24,"updated":"2017-05-17 12:07:49.000000000","message":"General comment - would be great to have feedback as the script progresses. \u0027Installing packages\u0027 etc. Right now the script is a blind run-through of actions which is not too helpful to the user.","commit_id":"02e66914b5c5b66f9f9d7c01c6bcff8c5e581a28"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"0691e5117240616c78922447f08b76fcd7cc232c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"EOEF"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"## Install Kubernetes 1.6.2 and other dependencies"},{"line_number":58,"context_line":"yum install -y docker ebtables kubeadm-$kubelet_version kubectl-$kubelet_version kubelet-$kubelet_version kubernetes-cni-$kubelet_version git gcc python-devel libffi-devel openssl-devel crudini"},{"line_number":59,"context_line":"yum install -y python-docker-py"},{"line_number":60,"context_line":"sudo systemctl enable docker"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff0f0b1f_3d59fbfd","line":57,"updated":"2017-05-17 12:07:49.000000000","message":"I believe kubernetes has removed 1.6.2. 1.6.3 has some issues and you\u0027ll need the patched version of kubectl - that we pull in the gate: https://github.com/sbezverk/kubelet--45613/raw/master/kubelet.gz","commit_id":"02e66914b5c5b66f9f9d7c01c6bcff8c5e581a28"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"8998909605fd607117c7f9e9556791b23580a9ff","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"## Install Kubernetes 1.6.2 and other dependencies"},{"line_number":58,"context_line":"yum install -y docker ebtables kubeadm-$kubelet_version kubectl-$kubelet_version kubelet-$kubelet_version kubernetes-cni-$kubelet_version git gcc python-devel libffi-devel openssl-devel crudini"},{"line_number":59,"context_line":"yum install -y python-docker-py"},{"line_number":60,"context_line":"sudo systemctl enable docker"},{"line_number":61,"context_line":"sudo systemctl enable kubelet"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff0f0b1f_f7add731","line":58,"range":{"start_line":58,"start_character":106,"end_line":58,"end_character":137},"updated":"2017-05-17 15:37:13.000000000","message":"cni version is 0.5.1 or 0.5.2 etc - not 1.6.3 - pretty sure this will fail","commit_id":"02e66914b5c5b66f9f9d7c01c6bcff8c5e581a28"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"2487cadebf322343eff3e9ede6126f04d9d830f1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"sed -i \u0027s/10.96.0.10/172.16.128.10/g\u0027 /etc/systemd/system/kubelet.service.d/10-kubeadm.conf"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"modprobe br_netfilter || true"},{"line_number":78,"context_line":"echo 1 \u003e /proc/sys/net/bridge/bridge-nf-call-iptables"},{"line_number":79,"context_line":"systemctl daemon-reload"},{"line_number":80,"context_line":"systemctl start docker"},{"line_number":81,"context_line":"systemctl restart kubelet"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff0f0b1f_2039ce40","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":4},"updated":"2017-05-17 12:19:40.000000000","message":"try to use this: sudo bash -c \u0027echo 1 \u003e /proc/sys/net/bridge/bridge-nf-call-iptables\u0027\n\nI think it might work","commit_id":"02e66914b5c5b66f9f9d7c01c6bcff8c5e581a28"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"0691e5117240616c78922447f08b76fcd7cc232c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"systemctl start docker"},{"line_number":81,"context_line":"systemctl restart kubelet"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"kubeadm init --skip-preflight-checks --service-cidr 172.16.128.0/24 --pod-network-cidr 172.16.132.0/22"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"mkdir -p ~/.kube"},{"line_number":86,"context_line":"cp /etc/kubernetes/admin.conf ~/.kube/config"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff0f0b1f_5d2f0ff6","line":83,"range":{"start_line":83,"start_character":13,"end_line":83,"end_character":36},"updated":"2017-05-17 12:07:49.000000000","message":"I know that the gate does this, but for a developer, when you skip these checks, you miss valuable feedback about your environment. Because this is a clean environment kubeadm should work with fine.","commit_id":"02e66914b5c5b66f9f9d7c01c6bcff8c5e581a28"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"0691e5117240616c78922447f08b76fcd7cc232c","unresolved":false,"context_lines":[{"line_number":106,"context_line":")"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"## Setup Canal"},{"line_number":110,"context_line":"url\u003d\"https://raw.githubusercontent.com/projectcalico/canal/master\""},{"line_number":111,"context_line":"url\u003d\"$url/k8s-install/$canal_version/canal.yaml\""},{"line_number":112,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff0f0b1f_7d13f3b9","line":109,"updated":"2017-05-17 12:07:49.000000000","message":"Maybe #Setup Canal CNI Driver, add RBAC work-around?","commit_id":"02e66914b5c5b66f9f9d7c01c6bcff8c5e581a28"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"0691e5117240616c78922447f08b76fcd7cc232c","unresolved":false,"context_lines":[{"line_number":139,"context_line":"kubectl create -f /tmp/canal.yaml"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"## Untaint Master"},{"line_number":143,"context_line":"kubectl taint nodes --all\u003dtrue  node-role.kubernetes.io/master:NoSchedule-"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff0f0b1f_9d1da7bf","line":142,"updated":"2017-05-17 12:07:49.000000000","message":"# Untaint Master -to mark master node as schedulable","commit_id":"02e66914b5c5b66f9f9d7c01c6bcff8c5e581a28"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"0691e5117240616c78922447f08b76fcd7cc232c","unresolved":false,"context_lines":[{"line_number":152,"context_line":"helm init"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"## Setup Loopback LVM for Cinder"},{"line_number":157,"context_line":"mkdir -p /data/kolla"},{"line_number":158,"context_line":"df -h"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff0f0b1f_1d8757da","line":155,"updated":"2017-05-17 12:07:49.000000000","message":"Three blank lines?","commit_id":"02e66914b5c5b66f9f9d7c01c6bcff8c5e581a28"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"0691e5117240616c78922447f08b76fcd7cc232c","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"## Setup Loopback LVM for Cinder"},{"line_number":157,"context_line":"mkdir -p /data/kolla"},{"line_number":158,"context_line":"df -h"},{"line_number":159,"context_line":"dd if\u003d/dev/zero of\u003d/data/kolla/cinder-volumes.img bs\u003d5M count\u003d2048"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff0f0b1f_bd750bfd","line":156,"updated":"2017-05-17 12:07:49.000000000","message":"This step should be optional I think?","commit_id":"02e66914b5c5b66f9f9d7c01c6bcff8c5e581a28"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"0691e5117240616c78922447f08b76fcd7cc232c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"pip install python-cinderclient"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"## Git Clone Kolla Ansible"},{"line_number":178,"context_line":"cd /opt \u0026\u0026 git clone http://github.com/openstack/kolla-ansible"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff0f0b1f_5dcb8f1d","line":177,"updated":"2017-05-17 12:07:49.000000000","message":"kolla-ansible","commit_id":"02e66914b5c5b66f9f9d7c01c6bcff8c5e581a28"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"0691e5117240616c78922447f08b76fcd7cc232c","unresolved":false,"context_lines":[{"line_number":178,"context_line":"cd /opt \u0026\u0026 git clone http://github.com/openstack/kolla-ansible"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"## Git Clone Kolla Kubernetes"},{"line_number":182,"context_line":"cd /opt \u0026\u0026 git clone http://github.com/openstack/kolla-kubernetes"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff0f0b1f_ddd67fc4","line":181,"updated":"2017-05-17 12:07:49.000000000","message":"kolla-kubernetes","commit_id":"02e66914b5c5b66f9f9d7c01c6bcff8c5e581a28"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"0691e5117240616c78922447f08b76fcd7cc232c","unresolved":false,"context_lines":[{"line_number":281,"context_line":""},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"## Build all Helm microcharts, service charts, and metacharts"},{"line_number":284,"context_line":"/opt/kolla-kubernetes/tools/helm_build_all.sh /tmp/"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"## Create cloud.yml file for the deployment of the charts"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff0f0b1f_3d6c5b07","line":284,"range":{"start_line":284,"start_character":46,"end_line":284,"end_character":51},"updated":"2017-05-17 12:07:49.000000000","message":"Curious how this works? For me these have to be generated to the working directory which is why the deployment guide suggests creating a working dir and not using /opt /tmp etc.","commit_id":"02e66914b5c5b66f9f9d7c01c6bcff8c5e581a28"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"0691e5117240616c78922447f08b76fcd7cc232c","unresolved":false,"context_lines":[{"line_number":292,"context_line":"       docker_registry: docker.io"},{"line_number":293,"context_line":"       image_tag: \"4.0.0\""},{"line_number":294,"context_line":"       kube_logger: false"},{"line_number":295,"context_line":"       external_vip: $1"},{"line_number":296,"context_line":"       base_distro: \"centos\""},{"line_number":297,"context_line":"       install_type: \"source\""},{"line_number":298,"context_line":"       tunnel_interface: $2"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff0f0b1f_bd586b56","line":295,"range":{"start_line":295,"start_character":21,"end_line":295,"end_character":23},"updated":"2017-05-17 12:07:49.000000000","message":"For me, it would be great at the top of the script to name $args to variable names. MGMT_IP\u003d$1 etc. This makes this prt of the script readable without scrolling up to the top.","commit_id":"02e66914b5c5b66f9f9d7c01c6bcff8c5e581a28"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"0691e5117240616c78922447f08b76fcd7cc232c","unresolved":false,"context_lines":[{"line_number":349,"context_line":"## Execute Helm Charts in Phases"},{"line_number":350,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/service/mariadb --namespace kolla --name mariadb --values /opt/cloud.yaml"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"while [ `kubectl get pods -n kolla -o wide | grep mariadb-0 | awk \u0027{print $3}\u0027` !\u003d \u0027Running\u0027 ]"},{"line_number":353,"context_line":"do"},{"line_number":354,"context_line":"  sleep 10"},{"line_number":355,"context_line":"done"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/service/rabbitmq --namespace kolla --name rabbitmq --values /opt/cloud.yaml"},{"line_number":358,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/service/memcached --namespace kolla --name memcached --values /opt/cloud.yaml"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff0f0b1f_3d133b69","line":355,"range":{"start_line":352,"start_character":0,"end_line":355,"end_character":4},"updated":"2017-05-17 12:07:49.000000000","message":"Should be a function, that you call with the namespace and the pod name. As you use this same code several times. That will also help when you add new charts - you just pass a list to the function.","commit_id":"02e66914b5c5b66f9f9d7c01c6bcff8c5e581a28"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"0691e5117240616c78922447f08b76fcd7cc232c","unresolved":false,"context_lines":[{"line_number":354,"context_line":"  sleep 10"},{"line_number":355,"context_line":"done"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/service/rabbitmq --namespace kolla --name rabbitmq --values /opt/cloud.yaml"},{"line_number":358,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/service/memcached --namespace kolla --name memcached --values /opt/cloud.yaml"},{"line_number":359,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/service/keystone --namespace kolla --name keystone --values /opt/cloud.yaml"},{"line_number":360,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/service/glance --namespace kolla --name glance --values /opt/cloud.yaml"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ff0f0b1f_40084227","line":357,"updated":"2017-05-17 12:07:49.000000000","message":"Also should be a function - you pass a list of helm charts and run through and install them. Otherwise the same line repeated over and over. Also will make this scale if new services come along.","commit_id":"02e66914b5c5b66f9f9d7c01c6bcff8c5e581a28"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"0691e5117240616c78922447f08b76fcd7cc232c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ff0f0b1f_607a2689","line":383,"updated":"2017-05-17 12:07:49.000000000","message":"So when all is said and done - would be good to have an output message: \u0027kolla-kubernetes\u0027 installed successfully.\n\nAlso would be good to catch this not working an error out after a period of time.\n\nFinally you could run the keystone script, generate the ability to access horizon, and display this to the user.\n\nBasically more feedback post installation.","commit_id":"02e66914b5c5b66f9f9d7c01c6bcff8c5e581a28"},{"author":{"_account_id":25709,"name":"Bernard Maltais","email":"bernard@ducourier.com","username":"bmaltais"},"change_message_id":"2c5daf8e79f66cc88481a955f6f1d21825e43174","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  echo \"Please provide the following Information to the script: \\$1 for kube proxy IP, \\$2 for tunnel_interface, \\$3 for ext interface, \\$4 for keepalived VIP, \\$5 for subnet size of management network\""},{"line_number":23,"context_line":"  exit 1"},{"line_number":24,"context_line":"fi"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"## Setup Host"},{"line_number":28,"context_line":"yum install -y net-tools wget telnet"}],"source_content_type":"text/x-sh","patch_set":6,"id":"ff0f0b1f_6140e508","line":25,"updated":"2017-05-17 14:36:24.000000000","message":"Here is a proposed addition to check if the interfaces passed on are actually valid and UP:\n\n## Ensure that the specified interface exist and are UP on the system\n\nfunction check_ifup {\n    set -o pipefail # optional.\n    /usr/sbin/ip address | grep $1 | grep -q \"state UP\"\n}\n\nfunction check_eth {\nif check_ifup $1;\nthen\n  echo \"Interface $1 validated as UP.\"\nelse\n  echo \"Please make sure interface $1 is present and UP before running the script.\"\n  exit 1\nfi\n}\n\ncheck_eth $2\ncheck_eth $3","commit_id":"76507349336cafe7e920a4ab062de4d15f059281"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"8ac8f2bc261e5bc7a85b9cdc2b70ee57cd70e688","unresolved":false,"context_lines":[{"line_number":3,"context_line":"## Compilation of Instructions from Kolla Kubernetes Gate"},{"line_number":4,"context_line":"## This is meant to set up Kolla Kubernetes All-In-One for CentOS-7"},{"line_number":5,"context_line":"## Cinder iSCSI backend is used here"},{"line_number":6,"context_line":"## Note that $1 will be the kube proxy IP, $2 will be the tunnel_interface, $3 will be the ext_interface_name, "},{"line_number":7,"context_line":"## $4 will be the keepalived VIP, $5 will be the subnet size of the keepalived VIP network"},{"line_number":8,"context_line":"## Lastly, $6 will take the value of master or minion (note that it will always be master for AIO)"},{"line_number":9,"context_line":"## Note that keepalive runs on the same subnet as the \"management\" subnet, i.e. tunnel_interface"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ff0f0b1f_a0a937e0","line":6,"range":{"start_line":6,"start_character":13,"end_line":6,"end_character":16},"updated":"2017-05-18 11:54:16.000000000","message":"Can you name these variables, makes the script easier to read if these have names throughout the code.","commit_id":"03d812644890c5a173243482d9880e9e7d26f026"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"8ac8f2bc261e5bc7a85b9cdc2b70ee57cd70e688","unresolved":false,"context_lines":[{"line_number":3,"context_line":"## Compilation of Instructions from Kolla Kubernetes Gate"},{"line_number":4,"context_line":"## This is meant to set up Kolla Kubernetes All-In-One for CentOS-7"},{"line_number":5,"context_line":"## Cinder iSCSI backend is used here"},{"line_number":6,"context_line":"## Note that $1 will be the kube proxy IP, $2 will be the tunnel_interface, $3 will be the ext_interface_name, "},{"line_number":7,"context_line":"## $4 will be the keepalived VIP, $5 will be the subnet size of the keepalived VIP network"},{"line_number":8,"context_line":"## Lastly, $6 will take the value of master or minion (note that it will always be master for AIO)"},{"line_number":9,"context_line":"## Note that keepalive runs on the same subnet as the \"management\" subnet, i.e. tunnel_interface"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ff0f0b1f_9d18e081","line":6,"range":{"start_line":6,"start_character":110,"end_line":6,"end_character":111},"updated":"2017-05-18 11:54:16.000000000","message":"Trailing whitespace.","commit_id":"03d812644890c5a173243482d9880e9e7d26f026"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"bce79d59e0487a23fe22a94bec4bac38768cc672","unresolved":false,"context_lines":[{"line_number":3,"context_line":"## Compilation of Instructions from Kolla Kubernetes Gate"},{"line_number":4,"context_line":"## This is meant to set up Kolla Kubernetes All-In-One for CentOS-7"},{"line_number":5,"context_line":"## Cinder iSCSI backend is used here"},{"line_number":6,"context_line":"## Note that $1 will be the kube proxy IP, $2 will be the tunnel_interface, $3 will be the ext_interface_name, "},{"line_number":7,"context_line":"## $4 will be the keepalived VIP, $5 will be the subnet size of the keepalived VIP network"},{"line_number":8,"context_line":"## Lastly, $6 will take the value of master or minion (note that it will always be master for AIO)"},{"line_number":9,"context_line":"## Note that keepalive runs on the same subnet as the \"management\" subnet, i.e. tunnel_interface"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ff0f0b1f_a7a949e0","line":6,"range":{"start_line":6,"start_character":13,"end_line":6,"end_character":16},"in_reply_to":"ff0f0b1f_a0a937e0","updated":"2017-05-18 14:30:36.000000000","message":"Will remove trailing whitespace and name the variables","commit_id":"03d812644890c5a173243482d9880e9e7d26f026"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"8ac8f2bc261e5bc7a85b9cdc2b70ee57cd70e688","unresolved":false,"context_lines":[{"line_number":13,"context_line":"## Ensure that the required parameters are passed in"},{"line_number":14,"context_line":"if [ \"$#\" -ne 6 ]"},{"line_number":15,"context_line":"then"},{"line_number":16,"context_line":"  echo \"Please provide the following Information to the script: "},{"line_number":17,"context_line":"       \\$1 for kube proxy IP,"},{"line_number":18,"context_line":"       \\$2 for tunnel_interface,"},{"line_number":19,"context_line":"       \\$3 for ext interface, "},{"line_number":20,"context_line":"       \\$4 for keepalived VIP, "},{"line_number":21,"context_line":"       \\$5 for subnet size of management network,"},{"line_number":22,"context_line":"       \\$6 for master/minion\" "},{"line_number":23,"context_line":"  exit 1"},{"line_number":24,"context_line":"fi"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"ff0f0b1f_7d0d0c3d","line":22,"range":{"start_line":16,"start_character":2,"end_line":22,"end_character":30},"updated":"2017-05-18 11:54:16.000000000","message":"Lots of trailing whitespace","commit_id":"03d812644890c5a173243482d9880e9e7d26f026"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"bce79d59e0487a23fe22a94bec4bac38768cc672","unresolved":false,"context_lines":[{"line_number":13,"context_line":"## Ensure that the required parameters are passed in"},{"line_number":14,"context_line":"if [ \"$#\" -ne 6 ]"},{"line_number":15,"context_line":"then"},{"line_number":16,"context_line":"  echo \"Please provide the following Information to the script: "},{"line_number":17,"context_line":"       \\$1 for kube proxy IP,"},{"line_number":18,"context_line":"       \\$2 for tunnel_interface,"},{"line_number":19,"context_line":"       \\$3 for ext interface, "},{"line_number":20,"context_line":"       \\$4 for keepalived VIP, "},{"line_number":21,"context_line":"       \\$5 for subnet size of management network,"},{"line_number":22,"context_line":"       \\$6 for master/minion\" "},{"line_number":23,"context_line":"  exit 1"},{"line_number":24,"context_line":"fi"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-sh","patch_set":7,"id":"ff0f0b1f_67ab31d6","line":22,"range":{"start_line":16,"start_character":2,"end_line":22,"end_character":30},"in_reply_to":"ff0f0b1f_7d0d0c3d","updated":"2017-05-18 14:30:36.000000000","message":"Will remove trailing whitespace","commit_id":"03d812644890c5a173243482d9880e9e7d26f026"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"8ac8f2bc261e5bc7a85b9cdc2b70ee57cd70e688","unresolved":false,"context_lines":[{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"function check_eth {"},{"line_number":34,"context_line":"if check_ifup $1;"},{"line_number":35,"context_line":"then"},{"line_number":36,"context_line":"  echo \"Interface $1 validated as UP.\""},{"line_number":37,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ff0f0b1f_e003af0c","line":34,"updated":"2017-05-18 11:54:16.000000000","message":"Indent is off in this function.","commit_id":"03d812644890c5a173243482d9880e9e7d26f026"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"bce79d59e0487a23fe22a94bec4bac38768cc672","unresolved":false,"context_lines":[{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"function check_eth {"},{"line_number":34,"context_line":"if check_ifup $1;"},{"line_number":35,"context_line":"then"},{"line_number":36,"context_line":"  echo \"Interface $1 validated as UP.\""},{"line_number":37,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ff0f0b1f_0784755d","line":34,"in_reply_to":"ff0f0b1f_e003af0c","updated":"2017-05-18 14:30:36.000000000","message":"Will update indentation","commit_id":"03d812644890c5a173243482d9880e9e7d26f026"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"8ac8f2bc261e5bc7a85b9cdc2b70ee57cd70e688","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"## Setup Host"},{"line_number":48,"context_line":"sudo sed -i \u0027s/enforcing/permissive/g\u0027 /etc/selinux/config"},{"line_number":49,"context_line":"sudo yum install -y net-tools wget telnet"},{"line_number":50,"context_line":"sudo yum install -y epel-release"},{"line_number":51,"context_line":"sudo yum install -y python-pip"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ff0f0b1f_60943f8c","line":48,"updated":"2017-05-18 11:54:16.000000000","message":"Something I pointed out in the previous review: can you add feedback to the user throughout the script?\n\necho \u0027Turning off firewall\u0027\necho \u0027Installing service level charts\u0027\n\netc..","commit_id":"03d812644890c5a173243482d9880e9e7d26f026"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"bce79d59e0487a23fe22a94bec4bac38768cc672","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"## Setup Host"},{"line_number":48,"context_line":"sudo sed -i \u0027s/enforcing/permissive/g\u0027 /etc/selinux/config"},{"line_number":49,"context_line":"sudo yum install -y net-tools wget telnet"},{"line_number":50,"context_line":"sudo yum install -y epel-release"},{"line_number":51,"context_line":"sudo yum install -y python-pip"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ff0f0b1f_c77d5d6f","line":48,"in_reply_to":"ff0f0b1f_60943f8c","updated":"2017-05-18 14:30:36.000000000","message":"I will add all the echo statements","commit_id":"03d812644890c5a173243482d9880e9e7d26f026"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"8ac8f2bc261e5bc7a85b9cdc2b70ee57cd70e688","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"# Bring up br-ex for keepalived to bind VIP to it"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"sudo ifconfig br-ex up"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/microservice/keepalived-daemonset --namespace kolla --name keepalived-daemonset --values /opt/cloud.yaml"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ff0f0b1f_40637bdd","line":294,"updated":"2017-05-18 11:54:16.000000000","message":"Unneeded extra line.","commit_id":"03d812644890c5a173243482d9880e9e7d26f026"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"bce79d59e0487a23fe22a94bec4bac38768cc672","unresolved":false,"context_lines":[{"line_number":291,"context_line":""},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"# Bring up br-ex for keepalived to bind VIP to it"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"sudo ifconfig br-ex up"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/microservice/keepalived-daemonset --namespace kolla --name keepalived-daemonset --values /opt/cloud.yaml"}],"source_content_type":"text/x-sh","patch_set":7,"id":"ff0f0b1f_6794518c","line":294,"in_reply_to":"ff0f0b1f_40637bdd","updated":"2017-05-18 14:30:36.000000000","message":"Will remove the extra line","commit_id":"03d812644890c5a173243482d9880e9e7d26f026"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"8ac8f2bc261e5bc7a85b9cdc2b70ee57cd70e688","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ff0f0b1f_a013770d","line":339,"updated":"2017-05-18 11:54:16.000000000","message":"Mentioned in other review - be useful to display a message at the end - possibly even set up keystone so the cluster is accessible.","commit_id":"03d812644890c5a173243482d9880e9e7d26f026"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"bce79d59e0487a23fe22a94bec4bac38768cc672","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ff0f0b1f_e732a1a7","line":339,"in_reply_to":"ff0f0b1f_a013770d","updated":"2017-05-18 14:30:36.000000000","message":"Ok. Will generate openrc file as well","commit_id":"03d812644890c5a173243482d9880e9e7d26f026"},{"author":{"_account_id":25709,"name":"Bernard Maltais","email":"bernard@ducourier.com","username":"bmaltais"},"change_message_id":"f074b64d72f1129e97df77139d498c28ea547c16","unresolved":false,"context_lines":[{"line_number":36,"context_line":"## Ensure that the specified interface exist and are UP on the system"},{"line_number":37,"context_line":"function check_ifup {"},{"line_number":38,"context_line":"    set -o pipefail # optional."},{"line_number":39,"context_line":"    /usr/sbin/ip address | grep $kube_proxy_ip | grep -q \"state UP\""},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"function check_eth {"}],"source_content_type":"text/x-sh","patch_set":9,"id":"ff0f0b1f_6d9b0fc9","line":39,"range":{"start_line":39,"start_character":32,"end_line":39,"end_character":46},"updated":"2017-05-18 16:21:03.000000000","message":"$1","commit_id":"f9fff4e45bf54657ec302a130f5524309c674108"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"f4e013d133717a3e57e49adde816d6e9d46c0ed8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"## Ensure that the specified interface exist and are UP on the system"},{"line_number":37,"context_line":"function check_ifup {"},{"line_number":38,"context_line":"    set -o pipefail # optional."},{"line_number":39,"context_line":"    /usr/sbin/ip address | grep $kube_proxy_ip | grep -q \"state UP\""},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"function check_eth {"}],"source_content_type":"text/x-sh","patch_set":9,"id":"ff0f0b1f_f6a7e0a6","line":39,"range":{"start_line":39,"start_character":32,"end_line":39,"end_character":46},"in_reply_to":"ff0f0b1f_6d9b0fc9","updated":"2017-05-19 04:23:29.000000000","message":"My bad.  I did a global search and replace and didnt check through after that.","commit_id":"f9fff4e45bf54657ec302a130f5524309c674108"},{"author":{"_account_id":25709,"name":"Bernard Maltais","email":"bernard@ducourier.com","username":"bmaltais"},"change_message_id":"f074b64d72f1129e97df77139d498c28ea547c16","unresolved":false,"context_lines":[{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"function check_eth {"},{"line_number":43,"context_line":"    if check_ifup $kube_proxy_ip;"},{"line_number":44,"context_line":"    then"},{"line_number":45,"context_line":"      echo \"Interface $kube_proxy_ip validated as UP.\""},{"line_number":46,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":9,"id":"ff0f0b1f_0daa53d3","line":43,"range":{"start_line":43,"start_character":18,"end_line":43,"end_character":32},"updated":"2017-05-18 16:21:03.000000000","message":"$1","commit_id":"f9fff4e45bf54657ec302a130f5524309c674108"},{"author":{"_account_id":25709,"name":"Bernard Maltais","email":"bernard@ducourier.com","username":"bmaltais"},"change_message_id":"f074b64d72f1129e97df77139d498c28ea547c16","unresolved":false,"context_lines":[{"line_number":42,"context_line":"function check_eth {"},{"line_number":43,"context_line":"    if check_ifup $kube_proxy_ip;"},{"line_number":44,"context_line":"    then"},{"line_number":45,"context_line":"      echo \"Interface $kube_proxy_ip validated as UP.\""},{"line_number":46,"context_line":"    else"},{"line_number":47,"context_line":"      echo \"Please make sure interface $kube_proxy_ip is present and UP before running the script.\""},{"line_number":48,"context_line":"      exit 1"}],"source_content_type":"text/x-sh","patch_set":9,"id":"ff0f0b1f_4d896b73","line":45,"range":{"start_line":45,"start_character":22,"end_line":45,"end_character":36},"updated":"2017-05-18 16:21:03.000000000","message":"$1","commit_id":"f9fff4e45bf54657ec302a130f5524309c674108"},{"author":{"_account_id":25709,"name":"Bernard Maltais","email":"bernard@ducourier.com","username":"bmaltais"},"change_message_id":"f074b64d72f1129e97df77139d498c28ea547c16","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    then"},{"line_number":45,"context_line":"      echo \"Interface $kube_proxy_ip validated as UP.\""},{"line_number":46,"context_line":"    else"},{"line_number":47,"context_line":"      echo \"Please make sure interface $kube_proxy_ip is present and UP before running the script.\""},{"line_number":48,"context_line":"      exit 1"},{"line_number":49,"context_line":"fi"},{"line_number":50,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":9,"id":"ff0f0b1f_0d837355","line":47,"range":{"start_line":47,"start_character":39,"end_line":47,"end_character":53},"updated":"2017-05-18 16:21:03.000000000","message":"$1","commit_id":"f9fff4e45bf54657ec302a130f5524309c674108"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"d88556a1511e9f86ea2f674d044938e00a0f99bc","unresolved":false,"context_lines":[{"line_number":170,"context_line":"tempest_image_alt_id: \"{{ tempest_image_id }}\""},{"line_number":171,"context_line":"tempest_flavor_ref_alt_id: \"{{ tempest_flavor_ref_id }}\""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"neutron_plugin_agent: \"openvswitch\""},{"line_number":174,"context_line":"api_interface_address: 0.0.0.0"},{"line_number":175,"context_line":"tunnel_interface_address: 0.0.0.0"},{"line_number":176,"context_line":"orchestration_engine: KUBERNETES"},{"line_number":177,"context_line":"memcached_servers: \"memcached\""},{"line_number":178,"context_line":"keystone_admin_url: \"http://keystone-admin:35357/v3\""},{"line_number":179,"context_line":"keystone_internal_url: \"http://keystone-internal:5000/v3\""},{"line_number":180,"context_line":"keystone_public_url: \"http://keystone-public:5000/v3\""},{"line_number":181,"context_line":"glance_registry_host: \"glance-registry\""},{"line_number":182,"context_line":"neutron_host: \"neutron\""},{"line_number":183,"context_line":"keystone_database_address: \"mariadb\""},{"line_number":184,"context_line":"glance_database_address: \"mariadb\""},{"line_number":185,"context_line":"nova_database_address: \"mariadb\""},{"line_number":186,"context_line":"nova_api_database_address: \"mariadb\""},{"line_number":187,"context_line":"neutron_database_address: \"mariadb\""},{"line_number":188,"context_line":"cinder_database_address: \"mariadb\""},{"line_number":189,"context_line":"ironic_database_address: \"mariadb\""},{"line_number":190,"context_line":"placement_database_address: \"mariadb\""},{"line_number":191,"context_line":"rabbitmq_servers: \"rabbitmq\""},{"line_number":192,"context_line":"openstack_logging_debug: \"True\""},{"line_number":193,"context_line":"enable_haproxy: \"no\""},{"line_number":194,"context_line":"enable_heat: \"no\""},{"line_number":195,"context_line":"enable_cinder: \"yes\""},{"line_number":196,"context_line":"enable_cinder_backend_lvm: \"yes\""},{"line_number":197,"context_line":"enable_cinder_backend_iscsi: \"yes\""},{"line_number":198,"context_line":"enable_cinder_backend_rbd: \"no\""},{"line_number":199,"context_line":"enable_ceph: \"no\""},{"line_number":200,"context_line":"enable_elasticsearch: \"no\""},{"line_number":201,"context_line":"enable_kibana: \"no\""},{"line_number":202,"context_line":"glance_backend_ceph: \"no\""},{"line_number":203,"context_line":"cinder_backend_ceph: \"no\""},{"line_number":204,"context_line":"nova_backend_ceph: \"no\""},{"line_number":205,"context_line":"EOF"},{"line_number":206,"context_line":"cat ./add-to-globals.yml | sudo tee -a /etc/kolla/globals.yml"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"ff0f0b1f_f382604f","line":204,"range":{"start_line":173,"start_character":1,"end_line":204,"end_character":23},"updated":"2017-05-18 17:24:39.000000000","message":"the majority of this should probably be moved directly into ansible/group_vars/all.yml and removed here and tests/conf/*/*\n\nIt was originally added in these places due to needing to be different from kolla-ansible. But now that we\u0027re not using kolla-ansible, setting them to be sane defaults for kolla-kubernetes will make it easier on everyone.","commit_id":"f9fff4e45bf54657ec302a130f5524309c674108"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"f4e013d133717a3e57e49adde816d6e9d46c0ed8","unresolved":false,"context_lines":[{"line_number":170,"context_line":"tempest_image_alt_id: \"{{ tempest_image_id }}\""},{"line_number":171,"context_line":"tempest_flavor_ref_alt_id: \"{{ tempest_flavor_ref_id }}\""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"neutron_plugin_agent: \"openvswitch\""},{"line_number":174,"context_line":"api_interface_address: 0.0.0.0"},{"line_number":175,"context_line":"tunnel_interface_address: 0.0.0.0"},{"line_number":176,"context_line":"orchestration_engine: KUBERNETES"},{"line_number":177,"context_line":"memcached_servers: \"memcached\""},{"line_number":178,"context_line":"keystone_admin_url: \"http://keystone-admin:35357/v3\""},{"line_number":179,"context_line":"keystone_internal_url: \"http://keystone-internal:5000/v3\""},{"line_number":180,"context_line":"keystone_public_url: \"http://keystone-public:5000/v3\""},{"line_number":181,"context_line":"glance_registry_host: \"glance-registry\""},{"line_number":182,"context_line":"neutron_host: \"neutron\""},{"line_number":183,"context_line":"keystone_database_address: \"mariadb\""},{"line_number":184,"context_line":"glance_database_address: \"mariadb\""},{"line_number":185,"context_line":"nova_database_address: \"mariadb\""},{"line_number":186,"context_line":"nova_api_database_address: \"mariadb\""},{"line_number":187,"context_line":"neutron_database_address: \"mariadb\""},{"line_number":188,"context_line":"cinder_database_address: \"mariadb\""},{"line_number":189,"context_line":"ironic_database_address: \"mariadb\""},{"line_number":190,"context_line":"placement_database_address: \"mariadb\""},{"line_number":191,"context_line":"rabbitmq_servers: \"rabbitmq\""},{"line_number":192,"context_line":"openstack_logging_debug: \"True\""},{"line_number":193,"context_line":"enable_haproxy: \"no\""},{"line_number":194,"context_line":"enable_heat: \"no\""},{"line_number":195,"context_line":"enable_cinder: \"yes\""},{"line_number":196,"context_line":"enable_cinder_backend_lvm: \"yes\""},{"line_number":197,"context_line":"enable_cinder_backend_iscsi: \"yes\""},{"line_number":198,"context_line":"enable_cinder_backend_rbd: \"no\""},{"line_number":199,"context_line":"enable_ceph: \"no\""},{"line_number":200,"context_line":"enable_elasticsearch: \"no\""},{"line_number":201,"context_line":"enable_kibana: \"no\""},{"line_number":202,"context_line":"glance_backend_ceph: \"no\""},{"line_number":203,"context_line":"cinder_backend_ceph: \"no\""},{"line_number":204,"context_line":"nova_backend_ceph: \"no\""},{"line_number":205,"context_line":"EOF"},{"line_number":206,"context_line":"cat ./add-to-globals.yml | sudo tee -a /etc/kolla/globals.yml"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"ff0f0b1f_56a32c9f","line":204,"range":{"start_line":173,"start_character":1,"end_line":204,"end_character":23},"in_reply_to":"ff0f0b1f_f382604f","updated":"2017-05-19 04:23:29.000000000","message":"Ok.  I will remove this block and make an attempt to update the content of all.yml. Let me know if the updated content makes sense.","commit_id":"f9fff4e45bf54657ec302a130f5524309c674108"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"d88556a1511e9f86ea2f674d044938e00a0f99bc","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"## Create cloud.yml file for the deployment of the charts"},{"line_number":251,"context_line":"echo \"Create cloud.yml file for the deployment of the charts\""},{"line_number":252,"context_line":"cat \u003c\u003cEOF \u003e /opt/cloud.yaml"},{"line_number":253,"context_line":"global:"},{"line_number":254,"context_line":"   kolla:"},{"line_number":255,"context_line":"     all:"}],"source_content_type":"text/x-sh","patch_set":9,"id":"ff0f0b1f_93bfa4fa","line":252,"range":{"start_line":252,"start_character":13,"end_line":252,"end_character":16},"updated":"2017-05-18 17:24:39.000000000","message":"/etc?","commit_id":"f9fff4e45bf54657ec302a130f5524309c674108"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"f4e013d133717a3e57e49adde816d6e9d46c0ed8","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"## Create cloud.yml file for the deployment of the charts"},{"line_number":251,"context_line":"echo \"Create cloud.yml file for the deployment of the charts\""},{"line_number":252,"context_line":"cat \u003c\u003cEOF \u003e /opt/cloud.yaml"},{"line_number":253,"context_line":"global:"},{"line_number":254,"context_line":"   kolla:"},{"line_number":255,"context_line":"     all:"}],"source_content_type":"text/x-sh","patch_set":9,"id":"ff0f0b1f_3679d82e","line":252,"range":{"start_line":252,"start_character":13,"end_line":252,"end_character":16},"in_reply_to":"ff0f0b1f_93bfa4fa","updated":"2017-05-19 04:23:29.000000000","message":"This is more of a place-holder.  I am putting everything under /opt\n\nIs there a reason for putting it under /etc? I can change it in that case.","commit_id":"f9fff4e45bf54657ec302a130f5524309c674108"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"d88556a1511e9f86ea2f674d044938e00a0f99bc","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"## Set up OVS for the Infrastructure"},{"line_number":320,"context_line":"echo \"Set up OVS for the Infrastructure\""},{"line_number":321,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/service/openvswitch --namespace kolla --name openvswitch --values /opt/cloud.yaml"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"while [ `kubectl get pods -n kolla -o wide | grep openvswitch-vswitchd | awk \u0027{print $3}\u0027` !\u003d \u0027Running\u0027 ]"},{"line_number":324,"context_line":"do"}],"source_content_type":"text/x-sh","patch_set":9,"id":"ff0f0b1f_135a74f2","line":321,"range":{"start_line":321,"start_character":13,"end_line":321,"end_character":21},"updated":"2017-05-18 17:24:39.000000000","message":"debug\u0027s incredibly verbose. Can those be removed everywhere?","commit_id":"f9fff4e45bf54657ec302a130f5524309c674108"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"f4e013d133717a3e57e49adde816d6e9d46c0ed8","unresolved":false,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"## Set up OVS for the Infrastructure"},{"line_number":320,"context_line":"echo \"Set up OVS for the Infrastructure\""},{"line_number":321,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/service/openvswitch --namespace kolla --name openvswitch --values /opt/cloud.yaml"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"while [ `kubectl get pods -n kolla -o wide | grep openvswitch-vswitchd | awk \u0027{print $3}\u0027` !\u003d \u0027Running\u0027 ]"},{"line_number":324,"context_line":"do"}],"source_content_type":"text/x-sh","patch_set":9,"id":"ff0f0b1f_b68de832","line":321,"range":{"start_line":321,"start_character":13,"end_line":321,"end_character":21},"in_reply_to":"ff0f0b1f_135a74f2","updated":"2017-05-19 04:23:29.000000000","message":"Agree. I will remove.","commit_id":"f9fff4e45bf54657ec302a130f5524309c674108"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"d88556a1511e9f86ea2f674d044938e00a0f99bc","unresolved":false,"context_lines":[{"line_number":365,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/service/nova-control --namespace kolla --name nova-control --values /opt/cloud.yaml"},{"line_number":366,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/service/nova-compute --namespace kolla --name nova-compute --values /opt/cloud.yaml"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"while [ `kubectl get pods -n kolla -o wide | grep nova-compute | awk \u0027{print $3}\u0027` !\u003d \u0027Running\u0027 ]"},{"line_number":370,"context_line":"do"},{"line_number":371,"context_line":"  sleep 10"},{"line_number":372,"context_line":"done"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/microservice/nova-cell0-create-db-job --namespace kolla --name nova-cell0-create-db-job --values /opt/cloud.yaml"},{"line_number":375,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/microservice/nova-api-create-simple-cell-job --namespace kolla --name nova-api-create-simple-cell --values /opt/cloud.yaml"}],"source_content_type":"text/x-sh","patch_set":9,"id":"ff0f0b1f_73ff70aa","line":372,"range":{"start_line":368,"start_character":0,"end_line":372,"end_character":4},"updated":"2017-05-18 17:24:39.000000000","message":"can wait_for_pods be reused for this? Its has some additional tests in it that might make it more robust.","commit_id":"f9fff4e45bf54657ec302a130f5524309c674108"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"f4e013d133717a3e57e49adde816d6e9d46c0ed8","unresolved":false,"context_lines":[{"line_number":365,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/service/nova-control --namespace kolla --name nova-control --values /opt/cloud.yaml"},{"line_number":366,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/service/nova-compute --namespace kolla --name nova-compute --values /opt/cloud.yaml"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"while [ `kubectl get pods -n kolla -o wide | grep nova-compute | awk \u0027{print $3}\u0027` !\u003d \u0027Running\u0027 ]"},{"line_number":370,"context_line":"do"},{"line_number":371,"context_line":"  sleep 10"},{"line_number":372,"context_line":"done"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/microservice/nova-cell0-create-db-job --namespace kolla --name nova-cell0-create-db-job --values /opt/cloud.yaml"},{"line_number":375,"context_line":"helm install --debug /opt/kolla-kubernetes/helm/microservice/nova-api-create-simple-cell-job --namespace kolla --name nova-api-create-simple-cell --values /opt/cloud.yaml"}],"source_content_type":"text/x-sh","patch_set":9,"id":"ff0f0b1f_d68a9c19","line":372,"range":{"start_line":368,"start_character":0,"end_line":372,"end_character":4},"in_reply_to":"ff0f0b1f_73ff70aa","updated":"2017-05-19 04:23:29.000000000","message":"Yes, I think we can reuse wait_for_pods.  The only concern I have is the default time out is 180 seconds (if I am reading it correctly).  I wasnt sure if it is sufficient as some people might have slower internet connection or slower processor (I will update nonetheless).","commit_id":"f9fff4e45bf54657ec302a130f5524309c674108"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"36aa0ee5b1691a8ccfd96eab106bc2d5a382e105","unresolved":false,"context_lines":[{"line_number":75,"context_line":"sudo pip install python-cinderclient"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"## Install Ansible"},{"line_number":79,"context_line":"echo \"Turn off firewalld\""},{"line_number":80,"context_line":"sudo systemctl stop firewalld"},{"line_number":81,"context_line":"sudo systemctl disable firewalld"}],"source_content_type":"text/x-sh","patch_set":12,"id":"ff0f0b1f_f73589db","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":18},"updated":"2017-05-19 16:10:50.000000000","message":"Wrong comment (disable firewall)","commit_id":"624d20f3d52bd9837b22b919d664bb26c0153445"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"08bd61e51de383f1fe4b88934dc85c0b51f8b2e8","unresolved":false,"context_lines":[{"line_number":75,"context_line":"sudo pip install python-cinderclient"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"## Install Ansible"},{"line_number":79,"context_line":"echo \"Turn off firewalld\""},{"line_number":80,"context_line":"sudo systemctl stop firewalld"},{"line_number":81,"context_line":"sudo systemctl disable firewalld"}],"source_content_type":"text/x-sh","patch_set":12,"id":"ff0f0b1f_7ef4a286","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":18},"in_reply_to":"ff0f0b1f_f73589db","updated":"2017-05-20 16:44:50.000000000","message":"Agree.  Will update.","commit_id":"624d20f3d52bd9837b22b919d664bb26c0153445"},{"author":{"_account_id":25709,"name":"Bernard Maltais","email":"bernard@ducourier.com","username":"bmaltais"},"change_message_id":"ecb85f457117ba5d0ee5ecd0bf258c95157f99b3","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"## Copy default kolla-kubernetes configuration to /etc"},{"line_number":111,"context_line":"echo \"Copy default kolla-kubernetes configuration to /etc\""},{"line_number":112,"context_line":"sudo cp -aR kolla-kubernetes/etc/kolla-kubernetes /etc"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"## Set Up Kubernetes"}],"source_content_type":"text/x-sh","patch_set":12,"id":"ff0f0b1f_ca9e5d62","line":112,"updated":"2017-05-19 15:22:48.000000000","message":"need to add /opt/ to fix an issue of files not getting copied.","commit_id":"624d20f3d52bd9837b22b919d664bb26c0153445"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"08bd61e51de383f1fe4b88934dc85c0b51f8b2e8","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"## Copy default kolla-kubernetes configuration to /etc"},{"line_number":111,"context_line":"echo \"Copy default kolla-kubernetes configuration to /etc\""},{"line_number":112,"context_line":"sudo cp -aR kolla-kubernetes/etc/kolla-kubernetes /etc"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"## Set Up Kubernetes"}],"source_content_type":"text/x-sh","patch_set":12,"id":"ff0f0b1f_5eef9eaf","line":112,"in_reply_to":"ff0f0b1f_ca9e5d62","updated":"2017-05-20 16:44:50.000000000","message":"Agree. Will update.","commit_id":"624d20f3d52bd9837b22b919d664bb26c0153445"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"c93a416f94af9faae66ac5c7a0672d931c36517c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"## Compilation of Instructions from Kolla Kubernetes Gate"},{"line_number":4,"context_line":"## This is meant to set up Kolla Kubernetes All-In-One for CentOS-7"},{"line_number":5,"context_line":"## Cinder iSCSI backend is used here"},{"line_number":6,"context_line":"## Note that $1 will be the kube proxy IP, $2 will be the tunnel_interface, $3 will be the ext_interface_name,"}],"source_content_type":"text/x-sh","patch_set":13,"id":"ff0f0b1f_8f517b65","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":3},"updated":"2017-05-21 15:43:13.000000000","message":"one \"#\" is ok,","commit_id":"cc813df5fb4539c92dc8a5b4e90ff3a2deebed24"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"9d3e6ed2ebc9d34075cccae17d034aa984b46f3e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"## Compilation of Instructions from Kolla Kubernetes Gate"},{"line_number":4,"context_line":"## This is meant to set up Kolla Kubernetes All-In-One for CentOS-7"},{"line_number":5,"context_line":"## Cinder iSCSI backend is used here"},{"line_number":6,"context_line":"## Note that $1 will be the kube proxy IP, $2 will be the tunnel_interface, $3 will be the ext_interface_name,"}],"source_content_type":"text/x-sh","patch_set":13,"id":"ff0f0b1f_75c6f84a","line":3,"range":{"start_line":3,"start_character":0,"end_line":3,"end_character":3},"in_reply_to":"ff0f0b1f_8f517b65","updated":"2017-05-21 20:57:56.000000000","message":"I think it does not really make a difference whether it is one \u0027#\u0027 or two.  It is just a convention.","commit_id":"cc813df5fb4539c92dc8a5b4e90ff3a2deebed24"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a21a69a25f1914765057aed7fc6b24202e1f6f49","unresolved":false,"context_lines":[{"line_number":170,"context_line":"tempest_image_alt_id: \"{{ tempest_image_id }}\""},{"line_number":171,"context_line":"tempest_flavor_ref_alt_id: \"{{ tempest_flavor_ref_id }}\""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"enable_haproxy: \"no\""},{"line_number":174,"context_line":"enable_heat: \"no\""},{"line_number":175,"context_line":"enable_cinder: \"yes\""},{"line_number":176,"context_line":"enable_cinder_backend_lvm: \"yes\""}],"source_content_type":"text/x-sh","patch_set":14,"id":"ff0f0b1f_1411b752","line":173,"updated":"2017-05-23 19:18:11.000000000","message":"There should be little reason to turn off haproxy. I\u0027d leave it enabled.","commit_id":"f17c7bd2fcb5ae008f71c1f1c7cef39a353d9881"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"f6573b2088ab6ce336f1d51c62f19e1bab6f60e2","unresolved":false,"context_lines":[{"line_number":170,"context_line":"tempest_image_alt_id: \"{{ tempest_image_id }}\""},{"line_number":171,"context_line":"tempest_flavor_ref_alt_id: \"{{ tempest_flavor_ref_id }}\""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"enable_haproxy: \"no\""},{"line_number":174,"context_line":"enable_heat: \"no\""},{"line_number":175,"context_line":"enable_cinder: \"yes\""},{"line_number":176,"context_line":"enable_cinder_backend_lvm: \"yes\""}],"source_content_type":"text/x-sh","patch_set":14,"id":"ff0f0b1f_e0f0b993","line":173,"in_reply_to":"ff0f0b1f_1411b752","updated":"2017-05-23 22:43:24.000000000","message":"Ok.  I have removed it so that it will take the default value, i.e. enabled.","commit_id":"f17c7bd2fcb5ae008f71c1f1c7cef39a353d9881"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"a21a69a25f1914765057aed7fc6b24202e1f6f49","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"## Create cloud.yml file for the deployment of the charts"},{"line_number":225,"context_line":"echo \"Create cloud.yml file for the deployment of the charts\""},{"line_number":226,"context_line":"cat \u003c\u003cEOF \u003e /opt/cloud.yaml"},{"line_number":227,"context_line":"global:"},{"line_number":228,"context_line":"   kolla:"},{"line_number":229,"context_line":"     all:"}],"source_content_type":"text/x-sh","patch_set":14,"id":"ff0f0b1f_143ad7ca","line":226,"updated":"2017-05-23 19:18:11.000000000","message":"/opts still kind of a weird place for a config file.","commit_id":"f17c7bd2fcb5ae008f71c1f1c7cef39a353d9881"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"f6573b2088ab6ce336f1d51c62f19e1bab6f60e2","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"## Create cloud.yml file for the deployment of the charts"},{"line_number":225,"context_line":"echo \"Create cloud.yml file for the deployment of the charts\""},{"line_number":226,"context_line":"cat \u003c\u003cEOF \u003e /opt/cloud.yaml"},{"line_number":227,"context_line":"global:"},{"line_number":228,"context_line":"   kolla:"},{"line_number":229,"context_line":"     all:"}],"source_content_type":"text/x-sh","patch_set":14,"id":"ff0f0b1f_2040f1a4","line":226,"in_reply_to":"ff0f0b1f_143ad7ca","updated":"2017-05-23 22:43:24.000000000","message":"Ok.  I have updated and move cloud.yaml to /etc/kolla/","commit_id":"f17c7bd2fcb5ae008f71c1f1c7cef39a353d9881"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"639e1d8de60adc25eaddd7746187d08ac40c7d6a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"## Setup Host"},{"line_number":57,"context_line":"echo \"Setup Host\""},{"line_number":58,"context_line":"sudo sed -i \u0027s/enforcing/permissive/g\u0027 /etc/selinux/config"},{"line_number":59,"context_line":"sudo yum install -y net-tools wget telnet"},{"line_number":60,"context_line":"sudo yum install -y epel-release"},{"line_number":61,"context_line":"sudo yum install -y python-pip"},{"line_number":62,"context_line":"sudo yum install -y git gcc python-devel libffi-devel openssl-devel crudini jq"},{"line_number":63,"context_line":"sudo pip install -U pip"},{"line_number":64,"context_line":"sudo yum install -y ntp"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"## Install Ansible"}],"source_content_type":"text/x-sh","patch_set":15,"id":"ff0f0b1f_db9a4760","line":64,"range":{"start_line":59,"start_character":0,"end_line":64,"end_character":23},"updated":"2017-05-24 01:47:45.000000000","message":"define a fuction for yum install?","commit_id":"5ba91e15b2a47eb991a0cf1c942bbe3c543b52de"},{"author":{"_account_id":20998,"name":"Anthony Lin","email":"anthony.jclin@gmail.com","username":"anthony.lin"},"change_message_id":"5e610a740da1ffa05e9a12a3432492eef3948361","unresolved":false,"context_lines":[{"line_number":56,"context_line":"## Setup Host"},{"line_number":57,"context_line":"echo \"Setup Host\""},{"line_number":58,"context_line":"sudo sed -i \u0027s/enforcing/permissive/g\u0027 /etc/selinux/config"},{"line_number":59,"context_line":"sudo yum install -y net-tools wget telnet"},{"line_number":60,"context_line":"sudo yum install -y epel-release"},{"line_number":61,"context_line":"sudo yum install -y python-pip"},{"line_number":62,"context_line":"sudo yum install -y git gcc python-devel libffi-devel openssl-devel crudini jq"},{"line_number":63,"context_line":"sudo pip install -U pip"},{"line_number":64,"context_line":"sudo yum install -y ntp"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"## Install Ansible"}],"source_content_type":"text/x-sh","patch_set":15,"id":"ff0f0b1f_e67fae63","line":64,"range":{"start_line":59,"start_character":0,"end_line":64,"end_character":23},"in_reply_to":"ff0f0b1f_db9a4760","updated":"2017-05-24 02:12:09.000000000","message":"Hmm, wasnt sure if there is really a need to do so...\n\nWe can compress into 1 or 2 lines if need be.  It will be very long though...","commit_id":"5ba91e15b2a47eb991a0cf1c942bbe3c543b52de"}]}