)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"cbbecce200870202bc1f337528cac6b5dcd24deb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Michal (inc0) Jastrzebski \u003cinc007@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-02 08:55:57 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP Dockerfile to run ansible orchiestration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we move to ansible orchiestration, we want it to run on k8s."},{"line_number":10,"context_line":"That means we need container with it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"df3967d1_26acd532","line":7,"range":{"start_line":7,"start_character":30,"end_line":7,"end_character":44},"updated":"2017-08-02 17:40:57.000000000","message":"Type orchestration","commit_id":"04e26e18087b2df82c0593db4fbb473693444c01"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"cbbecce200870202bc1f337528cac6b5dcd24deb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP Dockerfile to run ansible orchiestration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we move to ansible orchiestration, we want it to run on k8s."},{"line_number":10,"context_line":"That means we need container with it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I02bc0bc314ed29fae172cea189d064b4bbd2ff76"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"df3967d1_e6636d19","line":9,"range":{"start_line":9,"start_character":24,"end_line":9,"end_character":38},"updated":"2017-08-02 17:40:57.000000000","message":"ditto","commit_id":"04e26e18087b2df82c0593db4fbb473693444c01"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"cbbecce200870202bc1f337528cac6b5dcd24deb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"WIP Dockerfile to run ansible orchiestration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we move to ansible orchiestration, we want it to run on k8s."},{"line_number":10,"context_line":"That means we need container with it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I02bc0bc314ed29fae172cea189d064b4bbd2ff76"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"df3967d1_867021de","line":10,"updated":"2017-08-02 17:40:57.000000000","message":"Not a great explanation? \u0027need container\u0027 with what?","commit_id":"04e26e18087b2df82c0593db4fbb473693444c01"}],"Dockerfile":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"6ab1986907fc3c1ee5135c068eb7674c05806664","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ADD ansible /ansible"},{"line_number":20,"context_line":"ADD helm /helm"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":2,"id":"5f201791_41ee0589","line":21,"updated":"2017-06-20 17:18:28.000000000","message":"Guessing this is a first stab prototype? Seems reasonable, but should work more like the rest of the kolla containers. centos/ubuntu/etc.","commit_id":"cf62483ebd09a37d15d742e1da753800fcd2ccc7"},{"author":{"_account_id":9927,"name":"Britt Houser","email":"bhouser@cisco.com","username":"britthouser"},"change_message_id":"1c0b1c336f24b6893fb0a75b5c250ae38bff6f07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5f2577a7_e4c6a068","updated":"2017-09-15 15:47:48.000000000","message":"We install wget, but then still use curl?  Why not just standardize on curl?","commit_id":"04e26e18087b2df82c0593db4fbb473693444c01"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"cbbecce200870202bc1f337528cac6b5dcd24deb","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"RUN apt-get update \u0026\u0026 apt-get -y install python-dev curl libffi-dev gcc libssl-dev sshpass wget"},{"line_number":4,"context_line":"RUN curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py \\"},{"line_number":5,"context_line":"    \u0026\u0026 python get-pip.py \\"},{"line_number":6,"context_line":"    \u0026\u0026 rm get-pip.py"},{"line_number":7,"context_line":"RUN pip install ansible\u003d\u003d2.2.* oslo_config"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":9,"id":"df3967d1_e64c8d9f","line":5,"updated":"2017-08-02 17:40:57.000000000","message":"Weird indent.","commit_id":"04e26e18087b2df82c0593db4fbb473693444c01"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"cbbecce200870202bc1f337528cac6b5dcd24deb","unresolved":false,"context_lines":[{"line_number":9,"context_line":"ENV HELM_LATEST_VERSION\u003d\"v2.4.2\""},{"line_number":10,"context_line":"ENV KUBE_LATEST_VERSION\u003d\"v1.6.6\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"RUN wget http://storage.googleapis.com/kubernetes-helm/helm-${HELM_LATEST_VERSION}-linux-amd64.tar.gz \\"},{"line_number":13,"context_line":"    \u0026\u0026 tar -xvf helm-${HELM_LATEST_VERSION}-linux-amd64.tar.gz \\"},{"line_number":14,"context_line":"    \u0026\u0026 mv linux-amd64/helm /usr/local/bin \\"},{"line_number":15,"context_line":"    \u0026\u0026 rm -f /helm-${HELM_LATEST_VERSION}-linux-amd64.tar.gz"}],"source_content_type":"text/x-dockerfile","patch_set":9,"id":"df3967d1_c64f4990","line":12,"updated":"2017-08-02 17:40:57.000000000","message":"Line too long.","commit_id":"04e26e18087b2df82c0593db4fbb473693444c01"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"cbbecce200870202bc1f337528cac6b5dcd24deb","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    \u0026\u0026 tar -xvf helm-${HELM_LATEST_VERSION}-linux-amd64.tar.gz \\"},{"line_number":14,"context_line":"    \u0026\u0026 mv linux-amd64/helm /usr/local/bin \\"},{"line_number":15,"context_line":"    \u0026\u0026 rm -f /helm-${HELM_LATEST_VERSION}-linux-amd64.tar.gz"},{"line_number":16,"context_line":"RUN curl -L https://storage.googleapis.com/kubernetes-release/release/${KUBE_LATEST_VERSION}/bin/linux/amd64/kubectl -o /usr/local/bin/kubectl \\"},{"line_number":17,"context_line":"    \u0026\u0026 chmod +x /usr/local/bin/kubectl"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ADD ansible /ansible"}],"source_content_type":"text/x-dockerfile","patch_set":9,"id":"df3967d1_a646857b","line":16,"updated":"2017-08-02 17:40:57.000000000","message":"Line way too long.","commit_id":"04e26e18087b2df82c0593db4fbb473693444c01"}],"ansible/roles/horizon/tasks/config.yml":[{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"cbbecce200870202bc1f337528cac6b5dcd24deb","unresolved":false,"context_lines":[{"line_number":93,"context_line":"  failed_when: false"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"- name: Create configmap horizon-config"},{"line_number":96,"context_line":"  command: \"kubectl --namespace {{ kubernetes_namespace }} create configmap horizon --from-file /etc/kolla/horizon/horizon.conf --from-file /etc/kolla/horizon/config.json\""},{"line_number":97,"context_line":"  when: k8s_generate_configmaps | bool"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"- name: Delete secrets"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df3967d1_a63b25e9","line":96,"updated":"2017-08-02 17:40:57.000000000","message":"Do yaml files have to stick to 79 column width?","commit_id":"04e26e18087b2df82c0593db4fbb473693444c01"}],"ansible/roles/mariadb/tasks/config.yml":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"6ab1986907fc3c1ee5135c068eb7674c05806664","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f201791_a1ef1986","line":31,"updated":"2017-06-20 17:18:28.000000000","message":"this is all or nothing... this will break things.\n\nMaybe do the upload outside of ansible or at least make it conditional, defaulted off.","commit_id":"cf62483ebd09a37d15d742e1da753800fcd2ccc7"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"9695e037d54c124aab3e2038aa0c8e849d0c9947","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f201791_d2e2e52f","line":31,"in_reply_to":"5f201791_a1ef1986","updated":"2017-06-20 19:29:05.000000000","message":"I think whole point is to put it in job. What we can do is to examine if it\u0027s run in container (specific ENV?) and create only if it is.","commit_id":"cf62483ebd09a37d15d742e1da753800fcd2ccc7"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"7b0b6b23f8d23ea049efe51a2e7000d63cfb0be0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  command: \"kubectl --namespace {{ kubernetes_namespace }} create secret generic {{ item | replace(\u0027_\u0027, \u0027-\u0027) }} --from-literal\u003dpassword\u003d{{ hostvars[inventory_hostname][item] }}\""},{"line_number":47,"context_line":"  with_items:"},{"line_number":48,"context_line":"    - \"database_password\""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df3967d1_c52d7aa9","line":49,"updated":"2017-07-28 19:26:05.000000000","message":"I think this is orchestration and belongs under /orchestration/ansible ?","commit_id":"2ca71d0332cf73353583675774a4d9f015f222ae"}],"ansible/site.retry":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"6ab1986907fc3c1ee5135c068eb7674c05806664","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f201791_81665d51","line":1,"updated":"2017-06-20 17:18:28.000000000","message":"hmm?","commit_id":"cf62483ebd09a37d15d742e1da753800fcd2ccc7"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"9695e037d54c124aab3e2038aa0c8e849d0c9947","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f201791_92d6ad4f","line":1,"in_reply_to":"5f201791_81665d51","updated":"2017-06-20 19:29:05.000000000","message":"this is leftover from my initial patch. .retry files are kinda temp files from ansible which I commited by accident","commit_id":"cf62483ebd09a37d15d742e1da753800fcd2ccc7"}],"helm/microservice/kolla-configs-job/Chart.yaml":[{"author":{"_account_id":22368,"name":"Justin Scott","email":"justin.a.scott@intel.com","username":"jascott1"},"change_message_id":"252811aad339f225af2353a444dde4a14dc6d7e2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"apiVersion: v1"},{"line_number":2,"context_line":"version: 0.7.0-1"},{"line_number":3,"context_line":"description: Config and secret generation for Kolla Kubernetes"},{"line_number":4,"context_line":"name: kolla-configs"},{"line_number":5,"context_line":"keywords:"},{"line_number":6,"context_line":"  - openstack"},{"line_number":7,"context_line":"  - kolla"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_ff66b855","line":4,"updated":"2017-11-08 19:54:07.000000000","message":"chart name should be \"kolla-configs-job\" to match directory name.","commit_id":"04e26e18087b2df82c0593db4fbb473693444c01"}],"helm/microservice/mariadb-config-job/requirements.lock":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"6ab1986907fc3c1ee5135c068eb7674c05806664","unresolved":false,"context_lines":[{"line_number":1,"context_line":"dependencies:"},{"line_number":2,"context_line":"- condition: \"\""},{"line_number":3,"context_line":"  enabled: false"},{"line_number":4,"context_line":"  import-values: null"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5f201791_c11d75be","line":1,"updated":"2017-06-20 17:18:28.000000000","message":"lock files shouldn\u0027t be uploaded.","commit_id":"cf62483ebd09a37d15d742e1da753800fcd2ccc7"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"9695e037d54c124aab3e2038aa0c8e849d0c9947","unresolved":false,"context_lines":[{"line_number":1,"context_line":"dependencies:"},{"line_number":2,"context_line":"- condition: \"\""},{"line_number":3,"context_line":"  enabled: false"},{"line_number":4,"context_line":"  import-values: null"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5f201791_b23649b4","line":1,"in_reply_to":"5f201791_c11d75be","updated":"2017-06-20 19:29:05.000000000","message":"damn  I thought i removed all of them:P","commit_id":"cf62483ebd09a37d15d742e1da753800fcd2ccc7"}],"helm/microservice/mariadb-config-job/templates/mariadb-config.yaml":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"6ab1986907fc3c1ee5135c068eb7674c05806664","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  template:"},{"line_number":5,"context_line":"    spec:"},{"line_number":6,"context_line":"      containers:"},{"line_number":7,"context_line":"        - image: \"192.168.204.9:5000/kolla/kolla-k8s-orchestration\""},{"line_number":8,"context_line":"          name: mariadb-config"},{"line_number":9,"context_line":"          command: [\"ansible-playbook\"]"},{"line_number":10,"context_line":"          args: [\"-e\", \"@/etc/kolla-globals/globals.yml\", \"-e\", \"@/etc/kolla-passwords/passwords.yml\", \"-e\", \"CONFIG_DIR\u003d/etc/kolla\", \"ansible/site.yml\"]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f201791_e19191f3","line":7,"updated":"2017-06-20 17:18:28.000000000","message":"hardcoded address.","commit_id":"cf62483ebd09a37d15d742e1da753800fcd2ccc7"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"9695e037d54c124aab3e2038aa0c8e849d0c9947","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  template:"},{"line_number":5,"context_line":"    spec:"},{"line_number":6,"context_line":"      containers:"},{"line_number":7,"context_line":"        - image: \"192.168.204.9:5000/kolla/kolla-k8s-orchestration\""},{"line_number":8,"context_line":"          name: mariadb-config"},{"line_number":9,"context_line":"          command: [\"ansible-playbook\"]"},{"line_number":10,"context_line":"          args: [\"-e\", \"@/etc/kolla-globals/globals.yml\", \"-e\", \"@/etc/kolla-passwords/passwords.yml\", \"-e\", \"CONFIG_DIR\u003d/etc/kolla\", \"ansible/site.yml\"]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f201791_f253a1e1","line":7,"in_reply_to":"5f201791_e19191f3","updated":"2017-06-20 19:29:05.000000000","message":"yeah, I\u0027m doing this without templating.","commit_id":"cf62483ebd09a37d15d742e1da753800fcd2ccc7"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"6ab1986907fc3c1ee5135c068eb7674c05806664","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        - image: \"192.168.204.9:5000/kolla/kolla-k8s-orchestration\""},{"line_number":8,"context_line":"          name: mariadb-config"},{"line_number":9,"context_line":"          command: [\"ansible-playbook\"]"},{"line_number":10,"context_line":"          args: [\"-e\", \"@/etc/kolla-globals/globals.yml\", \"-e\", \"@/etc/kolla-passwords/passwords.yml\", \"-e\", \"CONFIG_DIR\u003d/etc/kolla\", \"ansible/site.yml\"]"},{"line_number":11,"context_line":"          volumeMounts:"},{"line_number":12,"context_line":"          - name: globals"},{"line_number":13,"context_line":"            mountPath: /etc/kolla-globals/"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f201791_e1587157","line":10,"updated":"2017-06-20 17:18:28.000000000","message":"does this need a way to limit it to generate just the mariadb config?\n\nAlternately, maybe we should just rename this whole thing to be:\nkolla-genconfig-job or something like that.\nThen if folks want to use alternate config generation tools it doesn\u0027t get in the way too much.","commit_id":"cf62483ebd09a37d15d742e1da753800fcd2ccc7"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"9695e037d54c124aab3e2038aa0c8e849d0c9947","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        - image: \"192.168.204.9:5000/kolla/kolla-k8s-orchestration\""},{"line_number":8,"context_line":"          name: mariadb-config"},{"line_number":9,"context_line":"          command: [\"ansible-playbook\"]"},{"line_number":10,"context_line":"          args: [\"-e\", \"@/etc/kolla-globals/globals.yml\", \"-e\", \"@/etc/kolla-passwords/passwords.yml\", \"-e\", \"CONFIG_DIR\u003d/etc/kolla\", \"ansible/site.yml\"]"},{"line_number":11,"context_line":"          volumeMounts:"},{"line_number":12,"context_line":"          - name: globals"},{"line_number":13,"context_line":"            mountPath: /etc/kolla-globals/"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f201791_92646dbb","line":10,"in_reply_to":"5f201791_e1587157","updated":"2017-06-20 19:29:05.000000000","message":"yeah I guess there is little point of generating just mariadb.","commit_id":"cf62483ebd09a37d15d742e1da753800fcd2ccc7"},{"author":{"_account_id":19384,"name":"Serguei Bezverkhi","email":"sbezverk@cisco.com","username":"sbezverk"},"change_message_id":"434deb7a070b2ded6a8922c9aed19e305ced6a08","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        - name: passwords"},{"line_number":21,"context_line":"          secret:"},{"line_number":22,"context_line":"            secretName: passwords"},{"line_number":23,"context_line":"      restartPolicy: OnFailure"},{"line_number":24,"context_line":"metadata:"},{"line_number":25,"context_line":"  name: mariadb-config"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f201791_436cc435","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":30},"updated":"2017-06-20 22:03:49.000000000","message":"It looks scary to me. If the deployment job fails I do not think it should restart. Since you are orchestrating installation within container, ansible detects and retries, I would think. Would be curious how k8s will react when other process will intercept possible failure scenarios.","commit_id":"cf62483ebd09a37d15d742e1da753800fcd2ccc7"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"ec4e3d4a2747011d19d469871260e28d216c82dd","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        - name: passwords"},{"line_number":21,"context_line":"          secret:"},{"line_number":22,"context_line":"            secretName: passwords"},{"line_number":23,"context_line":"      restartPolicy: OnFailure"},{"line_number":24,"context_line":"metadata:"},{"line_number":25,"context_line":"  name: mariadb-config"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f201791_c65fc2e3","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":30},"in_reply_to":"5f201791_436cc435","updated":"2017-06-20 22:41:52.000000000","message":"Yeah agree","commit_id":"cf62483ebd09a37d15d742e1da753800fcd2ccc7"}],"helm/orchestration/kolla-configs/templates/generate-configmaps.yml":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"7b0b6b23f8d23ea049efe51a2e7000d63cfb0be0","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    spec:"},{"line_number":7,"context_line":"      containers:"},{"line_number":8,"context_line":"        - image: \"{{ $orchestrationImage }}\""},{"line_number":9,"context_line":"          name: generate-configmaps"},{"line_number":10,"context_line":"          command: [\"ansible-playbook\"]"},{"line_number":11,"context_line":"          args: [\"-e\", \"@/etc/kolla-globals/globals.yml\", \"-e\", \"@/etc/kolla-passwords/passwords.yml\",\"-e\", \"k8s_generate_configmaps\u003dyes\", \"-e\", \"CONFIG_DIR\u003d/etc/kolla\", \"ansible/site.yml\"]"},{"line_number":12,"context_line":"          volumeMounts:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df3967d1_a555d61f","line":9,"range":{"start_line":9,"start_character":15,"end_line":9,"end_character":35},"updated":"2017-07-28 19:26:05.000000000","message":"\u0027main\u0027 please.","commit_id":"2ca71d0332cf73353583675774a4d9f015f222ae"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"7b0b6b23f8d23ea049efe51a2e7000d63cfb0be0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"            secretName: passwords"},{"line_number":24,"context_line":"      restartPolicy: OnFailure"},{"line_number":25,"context_line":"metadata:"},{"line_number":26,"context_line":"  name: mariadb-config"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df3967d1_c558da57","line":26,"updated":"2017-07-28 19:26:05.000000000","message":"needs a different name.","commit_id":"2ca71d0332cf73353583675774a4d9f015f222ae"}],"tests/bin/setup_config.sh":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"e0e80756bf31cbf6f6dafd6ae3c78521a9339c9e","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Build orch image"},{"line_number":41,"context_line":"docker build . --tag\u003d\"localhost:30400/kolla-kubernetes-orchestration:latest\""},{"line_number":42,"context_line":"docker push localhost:30400/kolla-kubernetes-orchestration:latest"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Create secrets and configmaps"},{"line_number":45,"context_line":"kubectl create secret generic --namespace\u003dkolla --from-file /etc/kolla/passwords.yml passwords"}],"source_content_type":"text/x-sh","patch_set":9,"id":"df3967d1_d598151c","line":42,"updated":"2017-08-02 16:27:26.000000000","message":"this probably belongs somewhere other then setup_config.","commit_id":"04e26e18087b2df82c0593db4fbb473693444c01"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"937cdee25800a4cc629e8bac9dfbf72c802b9c4a","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Build orch image"},{"line_number":41,"context_line":"docker build . --tag\u003d\"localhost:30400/kolla-kubernetes-orchestration:latest\""},{"line_number":42,"context_line":"docker push localhost:30400/kolla-kubernetes-orchestration:latest"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Create secrets and configmaps"},{"line_number":45,"context_line":"kubectl create secret generic --namespace\u003dkolla --from-file /etc/kolla/passwords.yml passwords"}],"source_content_type":"text/x-sh","patch_set":9,"id":"df3967d1_e17c7684","line":42,"in_reply_to":"df3967d1_d598151c","updated":"2017-08-02 18:06:47.000000000","message":"right","commit_id":"04e26e18087b2df82c0593db4fbb473693444c01"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"e0e80756bf31cbf6f6dafd6ae3c78521a9339c9e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"crudini --set /etc/kolla/overrides/nova.conf libvirt rbd_secret_uuid $UUID"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Keystone does not seem to invalidate its cache on entry point addition."},{"line_number":59,"context_line":"crudini --set /etc/kolla/overrides/keystone.conf cache enabled False"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# sed -i \u0027s/log_outputs \u003d \"3:/log_outputs \u003d \"1:/\u0027 /etc/kolla/overrides/libvirtd.conf"},{"line_number":62,"context_line":"# sed -i \u0027s/log_level \u003d 3/log_level \u003d 1/\u0027 /etc/kolla/overrides/libvirtd.conf"}],"source_content_type":"text/x-sh","patch_set":9,"id":"df3967d1_b56d9105","line":59,"updated":"2017-08-02 16:27:26.000000000","message":"Since its all overrides now, can we just cp some reference files from tests/config into /etc/kolla/overrides instead?","commit_id":"04e26e18087b2df82c0593db4fbb473693444c01"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"937cdee25800a4cc629e8bac9dfbf72c802b9c4a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"crudini --set /etc/kolla/overrides/nova.conf libvirt rbd_secret_uuid $UUID"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Keystone does not seem to invalidate its cache on entry point addition."},{"line_number":59,"context_line":"crudini --set /etc/kolla/overrides/keystone.conf cache enabled False"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# sed -i \u0027s/log_outputs \u003d \"3:/log_outputs \u003d \"1:/\u0027 /etc/kolla/overrides/libvirtd.conf"},{"line_number":62,"context_line":"# sed -i \u0027s/log_level \u003d 3/log_level \u003d 1/\u0027 /etc/kolla/overrides/libvirtd.conf"}],"source_content_type":"text/x-sh","patch_set":9,"id":"df3967d1_01789a8d","line":59,"in_reply_to":"df3967d1_b56d9105","updated":"2017-08-02 18:06:47.000000000","message":"I think tests/config is for globals not end-result of genconfig?","commit_id":"04e26e18087b2df82c0593db4fbb473693444c01"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"e0e80756bf31cbf6f6dafd6ae3c78521a9339c9e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"crudini --set /etc/kolla/overrides/keystone.conf cache enabled False"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# sed -i \u0027s/log_outputs \u003d \"3:/log_outputs \u003d \"1:/\u0027 /etc/kolla/overrides/libvirtd.conf"},{"line_number":62,"context_line":"# sed -i \u0027s/log_level \u003d 3/log_level \u003d 1/\u0027 /etc/kolla/overrides/libvirtd.conf"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# sed -i \\"},{"line_number":65,"context_line":"#     \u0027/\\[global\\]/a osd pool default size \u003d 1\\nosd pool default min size \u003d 1\\nosd crush chooseleaf type \u003d 0\\ndebug default \u003d 5\\n\u0027\\"}],"source_content_type":"text/x-sh","patch_set":9,"id":"df3967d1_9025fbad","line":62,"updated":"2017-08-02 16:27:26.000000000","message":"this was useful levels of logging. we shouldn\u0027t drop it.","commit_id":"04e26e18087b2df82c0593db4fbb473693444c01"},{"author":{"_account_id":10787,"name":"Michal Jastrzebski (inc0)","email":"michal.jastrzebski@intel.com","username":"inc0"},"change_message_id":"937cdee25800a4cc629e8bac9dfbf72c802b9c4a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"crudini --set /etc/kolla/overrides/keystone.conf cache enabled False"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# sed -i \u0027s/log_outputs \u003d \"3:/log_outputs \u003d \"1:/\u0027 /etc/kolla/overrides/libvirtd.conf"},{"line_number":62,"context_line":"# sed -i \u0027s/log_level \u003d 3/log_level \u003d 1/\u0027 /etc/kolla/overrides/libvirtd.conf"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"# sed -i \\"},{"line_number":65,"context_line":"#     \u0027/\\[global\\]/a osd pool default size \u003d 1\\nosd pool default min size \u003d 1\\nosd crush chooseleaf type \u003d 0\\ndebug default \u003d 5\\n\u0027\\"}],"source_content_type":"text/x-sh","patch_set":9,"id":"df3967d1_413342f7","line":62,"in_reply_to":"df3967d1_9025fbad","updated":"2017-08-02 18:06:47.000000000","message":"yeah I know, just not sure how to do it yet..","commit_id":"04e26e18087b2df82c0593db4fbb473693444c01"},{"author":{"_account_id":22368,"name":"Justin Scott","email":"justin.a.scott@intel.com","username":"jascott1"},"change_message_id":"252811aad339f225af2353a444dde4a14dc6d7e2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"#     \u0027/\\[global\\]/a osd pool default size \u003d 1\\nosd pool default min size \u003d 1\\nosd crush chooseleaf type \u003d 0\\ndebug default \u003d 5\\n\u0027\\"},{"line_number":66,"context_line":"#     /etc/kolla/overrides/ceph.conf"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"kubectl create configmap --namespace\u003dkolla --from-file /etc/kolla/override conf-overrides"},{"line_number":69,"context_line":"helm install helm/microservice/kolla-configs-job"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# ./tools/fix-mitaka-config.py"}],"source_content_type":"text/x-sh","patch_set":9,"id":"3f4b6375_ff2118fe","line":68,"updated":"2017-11-08 19:54:07.000000000","message":"typo: /etc/kolla/override should be /etc/kolla/overrides","commit_id":"04e26e18087b2df82c0593db4fbb473693444c01"}],"tools/setup_gate_common.sh":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"e0e80756bf31cbf6f6dafd6ae3c78521a9339c9e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"function setup_namespace {"},{"line_number":110,"context_line":"kubectl create namespace kolla"},{"line_number":111,"context_line":"}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"function setup_resolv_conf_common {"}],"source_content_type":"text/x-sh","patch_set":9,"id":"df3967d1_1017cbef","line":110,"updated":"2017-08-02 16:27:26.000000000","message":"if your tweaking this and everywhere its called, and it only ends up converting into a \"kubectl create namespace kolla\", maybe be we should just move the code back to where its called? it will be more obvious to the reader?","commit_id":"04e26e18087b2df82c0593db4fbb473693444c01"},{"author":{"_account_id":24043,"name":"Rich Wellum","username":"rwellum","inactive":true},"change_message_id":"cbbecce200870202bc1f337528cac6b5dcd24deb","unresolved":false,"context_lines":[{"line_number":111,"context_line":"}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"function setup_resolv_conf_common {"},{"line_number":114,"context_line":"tools/setup-resolv-conf.sh kolla"},{"line_number":115,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":9,"id":"df3967d1_410ea332","line":114,"updated":"2017-08-02 17:40:57.000000000","message":"Why are all the functions unindented in this file?","commit_id":"04e26e18087b2df82c0593db4fbb473693444c01"}]}